Re: [PATCH] video: fbdev: sm501fb: onvert sysfs snprintf to sysfs_emit

2022-10-17 Thread Helge Deller
On 10/18/22 08:25, Xuezhi Zhang wrote: From: Xuezhi Zhang Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Xuezhi Zhang applied. Thanks! Helge ---

not ok 1 - single_pixel_source_buffer: The buggy address belongs to the physical page

2022-10-17 Thread Naresh Kamboju
Following kunit tests started failing on Linux mainline. - drm_format_helper_test — FAIL - drm_test_fb_xrgb_to_xrgb2101010 — FAIL - single_pixel_source_buffer — FAIL Good: v6.0-3015-g2bca25eaeba6 Bad: v6.0-5118-g833477fce7a1 Reported-by: Linux Kernel Functional Testing [ 50.320990]

[PATCH 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c

2022-10-17 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption. In i915_gem_execbuffer.c, eb->reloc_cache.vaddr is mapped by kmap_atomic() in eb_

[PATCH 8/9] drm/i915: Use kmap_local_page() in i915_cmd_parser.c

2022-10-17 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption. There're 2 reasons why function copy_batch() doesn't need to disable pagefaults a

[RESEND PATCH v2] drm/bridge: dw-hdmi-i2s: set insert_pcuv bit if hardware supports it

2022-10-17 Thread Geraldo Nascimento
pu/drm/bridge/synopsys/dw-hdmi-i2s-audio-20221017.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio-20221017.c @@ -42,6 +42,7 @@ static int dw_hdmi_i2s_hw_params(struct device *dev, void *data, struct dw_hdmi *hdmi = audio->hdmi; u8 conf0 = 0; u8 conf1 = 0; + u8

[PATCH 7/9] drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c

2022-10-17 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption. In drm/i915/gt/uc/intel_us_fw.c, the function intel_uc_fw_copy_rsa() just use the

Re: [PATCH v1] drm/panel: simple: set bpc field for logic technologies displays

2022-10-17 Thread Francesco Dolcini
On Wed, Aug 31, 2022 at 04:16:22PM +0200, Francesco Dolcini wrote: > From: Aishwarya Kothari > > In case bpc is not set for a panel it then throws a WARN(). Add bpc to > the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh. > > Fixes: 5728fe7fa539 ("drm/panel: simple: add display ti

[PATCH 3/9] drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c

2022-10-17 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption. In drm/i915/gem/i915_gem_shmem.c, the function shmem_pwrite() need to disable pag

[PATCH v3] x86/hyperv: Replace kmap() with kmap_local_page()

2022-10-17 Thread Zhao Liu
From: Zhao Liu kmap() is being deprecated in favor of kmap_local_page()[1]. There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap's

[PATCH 5/9] drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_coherency.c

2022-10-17 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption. In drm/i915/gem/selftests/i915_gem_coherency.c, functions cpu_set() and cpu_get()

[PATCH 6/9] drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_context.c

2022-10-17 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption. In drm/i915/gem/selftests/i915_gem_context.c, functions cpu_fill() and cpu_check(

[PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

2022-10-17 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption. There're 2 reasons why i915_gem_object_read_from_page_kmap() doesn't need to disa

[PATCH 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2022-10-17 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. In the following patches, we can convert the calls of kmap_atomic() / kunmap_atomic() to kmap_local_page() / kunmap_local(), which can instead do the mapping / unmapping regardless of the context. With

Re: [PATCH v6 0/7] treewide cleanup of random integer usage

2022-10-17 Thread liulongfang
On 2022/10/11 7:06, Jason A. Donenfeld Wrote: > Changes v5->v6: > - Added a few missing conversions that weren't in my older tree, so now > this should be ready to go, as well as a couple nits people had from > v5. Barring something large and unforeseen, this is the "final > version", as this

Re: [PATCH v3] x86/hyperv: Replace kmap() with kmap_local_page()

2022-10-17 Thread Zhao Liu
Sorry, please ignore the last hyperv patch, I made a mistake. Zhao On Mon, Oct 17, 2022 at 05:37:26PM +0800, Zhao Liu wrote: > Date: Mon, 17 Oct 2022 17:37:26 +0800 > From: Zhao Liu > Subject: [PATCH v3] x86/hyperv: Replace kmap() with kmap_local_page() > X-Mailer: git-send-email 2.34.1 > > Fro

[PATCH 2/9] drm/i915: Use kmap_local_page() in gem/i915_gem_pyhs.c

2022-10-17 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption. In drm/i915/gem/i915_gem_phys.c, the functions i915_gem_object_get_pages_phys() a

[PATCH 4/9] drm/i915: Use kmap_local_page() in gem/selftests/huge_pages.c

2022-10-17 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption. In drm/i915/gem/selftests/huge_pages.c, function __cpu_check_shmem() mainly uses

[PATCH] video: fbdev: sm501fb: onvert sysfs snprintf to sysfs_emit

2022-10-17 Thread Xuezhi Zhang
From: Xuezhi Zhang Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Xuezhi Zhang --- drivers/video/fbdev/sm501fb.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH] fbdev: da8xx-fb: Fix error handling in .remove()

2022-10-17 Thread Helge Deller
On 10/17/22 21:52, Uwe Kleine-König wrote: Even in the presence of problems (here: regulator_disable() might fail), it's important to unregister all resources acquired during .probe() and disable the device (i.e. DMA activity) because even if .remove() returns an error code, the device is removed

kunit: drm_framebuffer: kernel BUG at drivers/gpu/drm/drm_buddy.c

2022-10-17 Thread Naresh Kamboju
Following kernel BUG reported while running kunit drm_framebuffer tests on Linux mainline 6.1.0-rc1. Started happening from Linux next 6.0.0-rc1-next-20220818. Stared happening on Linux mainline from git_sha: 833477fce7a14d43ae4c07f8ddc32fa5119471a2 Reported-by: Linux Kernel Functional Testing

[PATCH] drm/edid: Parse VRR cap fields from HFVSDB block

2022-10-17 Thread Ankit Nautiyal
This patch parses HFVSDB fields for VRR capabilities of an HDMI2.1 sink and stores the VRR caps in a new structure in drm_hdmi_info. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/drm_edid.c | 26 -- include/drm/drm_connector.h | 27 +++ 2 file

Re: [v1] arm64: dts: qcom: sc7280: assign DSI clock source parents

2022-10-17 Thread Bjorn Andersson
On Wed, 7 Sep 2022 17:05:53 +0530, Rajeev Nandan wrote: > Assign DSI clock source parents to DSI PHY clocks. > > Applied, thanks! [1/1] arm64: dts: qcom: sc7280: assign DSI clock source parents commit: 80edac18ac173f0f0130c2164f75ddadcd68fa7f Best regards, -- Bjorn Andersson

Re: (subset) [PATCH 0/9] arm: dts: qcom: rename DSI PHY nodes

2022-10-17 Thread Bjorn Andersson
On Sat, 24 Sep 2022 12:00:59 +0300, Dmitry Baryshkov wrote: > Historically DSI PHY device tree nodes used the dsi-phy@ names. Replace > them with generic phy@ names. > > Dmitry Baryshkov (9): > ARM: dts: qcom-apq8064: change DSI PHY node name to generic one > ARM: dts: qcom-msm8974: change DSI

Re: [PATCH v7 01/10] drm: bridge: Add Samsung DSIM bridge driver

2022-10-17 Thread Jagan Teki
On Mon, Oct 17, 2022 at 2:31 PM Marek Szyprowski wrote: > > Hi, > > On 17.10.2022 10:48, Marek Vasut wrote: > > On 10/17/22 09:43, Jagan Teki wrote: > >> On Mon, Oct 17, 2022 at 12:49 PM Marek Vasut wrote: > >>> On 10/17/22 04:49, Jagan Teki wrote: > On Sun, Oct 16, 2022 at 3:16 AM Marek Vas

Re: [git pull] drm fixes for 6.1-rc1

2022-10-17 Thread Arthur Marsh
Thanks Arunpravin, your patch applied to the 6.1-rc1 code built a kernel that loaded the amdgpu module on my pc with Cape Verde GPU card with no problems. Regards, Arthur. On 18 October 2022 7:10:45 am ACDT, Arunpravin Paneer Selvam wrote: >Hi Christian, > >Looks like we have to exit the loo

[PATCH] drm/amdkfd: Fix memory leak in kfd_mem_dmamap_userptr()

2022-10-17 Thread Rafael Mendonca
If the number of pages from the userptr BO differs from the SG BO then the allocated memory for the SG table doesn't get freed before returning -EINVAL, which may lead to a memory leak in some error paths. Fix this by checking the number of pages before allocating memory for the SG table. Fixes: 2

答复: [PATCH] drm/amdkfd: use vma_lookup() instead of find_vma()

2022-10-17 Thread 王德明
Hi, The function vma_lookup show below. Vma valid check is included in it. Or, What other questions do you have? static inline struct vm_area_struct *vma_lookup(struct mm_struct *mm, unsigned long addr) { struct vm_area_struct *vma = find_vma(mm, addr); if (vma && addr < vma-

RE: [PATCH] drm/amdgpu/powerplay/psm: Fix memory leak in power state init

2022-10-17 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Rafael Mendonca > Sent: Tuesday, October 18, 2022 8:54 AM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ; Daniel Vetter > Cc: Rafael Mendonca ; amd- > g.

[PATCH] drm/amdgpu/powerplay/psm: Fix memory leak in power state init

2022-10-17 Thread Rafael Mendonca
Commit 902bc65de0b3 ("drm/amdgpu/powerplay/psm: return an error in power state init") made the power state init function return early in case of failure to get an entry from the powerplay table, but it missed to clean up the allocated memory for the current power state before returning. Fixes: 902

Re: [PATCH v2 1/2] drm/i915: Add intel_ prefix to struct ip_version

2022-10-17 Thread Lucas De Marchi
On Mon, Oct 17, 2022 at 10:29:56AM -0700, Lucas De Marchi wrote: On Tue, Oct 11, 2022 at 08:38:50AM -0700, Radhakrishna Sripada wrote: Rename struct ip_version to intel_ip_version to comply with the naming conventions for structures. Suggested-by: Jani Nikula Signed-off-by: Radhakrishna Sripad

Re: [PATCH v5 4/4] drm/i915: Improve long running compute w/a for GuC submission

2022-10-17 Thread Ceraolo Spurio, Daniele
On 10/6/2022 2:38 PM, john.c.harri...@intel.com wrote: From: John Harrison A workaround was added to the driver to allow compute workloads to run 'forever' by disabling pre-emption on the RCS engine for Gen12. It is not totally unbound as the heartbeat will kick in eventually and cause a res

Re: [PATCH v5 1/4] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-10-17 Thread Ceraolo Spurio, Daniele
On 10/6/2022 2:38 PM, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst case scenario is approximately 110 sec

Re: [PATCH v2 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-10-17 Thread John Harrison
On 10/12/2022 17:03, Daniele Ceraolo Spurio wrote: Our current FW loading process is the same for all FWs: - Pin FW to GGTT at the start of the ggtt->uc_fw node - Load the FW - Unpin This worked because we didn't have a case where 2 FWs would be loaded on the same GGTT at the same time. On MTL,

Re: [PATCH v7 00/21] Move all drivers to a common dma-buf locking convention

2022-10-17 Thread Dmitry Osipenko
On 10/17/22 20:22, Dmitry Osipenko wrote: > Hello, > > This series moves all drivers to a dynamic dma-buf locking specification. > From now on all dma-buf importers are made responsible for holding > dma-buf's reservation lock around all operations performed over dma-bufs > in accordance to the lo

Re: [Bug][5.18-rc0] Between commits ed4643521e6a and 34af78c4e616, appears warning "WARNING: CPU: 31 PID: 51848 at drivers/dma-buf/dma-fence-array.c:191 dma_fence_array_create+0x101/0x120" and some ga

2022-10-17 Thread Mikhail Gavrilov
On Wed, May 11, 2022 at 5:01 PM Christian König wrote: > > > We have implemented a workaround, but still don't know the exact root cause. > > If anybody wants to look into this it would be rather helpful to be able > to reproduce the issue. > > Regards, > Christian. I see that issue was returned

linux-next: manual merge of the drm-intel tree with Linus' tree

2022-10-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_driver.c between commit: 1c66a12ab431 ("drm/i915: Handle each GT on init/release and suspend/resume") from Linus' tree and commit: 3703060d17b0 ("drm/i915/display: remove drm_device alias

Re: [git pull] drm fixes for 6.1-rc1

2022-10-17 Thread Arunpravin Paneer Selvam
Hi Christian, Looks like we have to exit the loop if there are no blocks to compare. May be that's why the function returns false. @Arthur Marsh Could you please test the attached patch. Thanks, Arun On 10/17/2022 1:39 PM, Christian König wrote: Am 17.10.22 um 10:01 schrieb Dave Airlie: On Mo

Re: [PATCH 3/3] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-17 Thread Dixit, Ashutosh
On Fri, 14 Oct 2022 20:26:18 -0700, Ashutosh Dixit wrote: > > From: Badal Nilawar Hi Badal, One question below. > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > index 1fb053cbf52db..3a9bb4387248e 100644 > --- a/drivers/gpu/drm/i91

[PATCH 13/16] drm/vmwgfx: Port the framebuffer code to drm fb helpers

2022-10-17 Thread Zack Rusin
From: Zack Rusin Instead of using vmwgfx specific framebuffer implementation use the drm fb helpers. There's no change in functionality, the only difference is a reduction in the amount of code inside the vmwgfx module. drm fb helpers do not deal correctly with changes in crtc preferred mode at

[PATCH 10/16] drm/vmwgfx: Refactor ttm reference object hashtable to use linux/hashtable.

2022-10-17 Thread Zack Rusin
From: Maaz Mombasawala This is part of an effort to move from the vmwgfx_open_hash hashtable to linux/hashtable implementation. Refactor the ref_hash hashtable, used for fast lookup of reference objects associated with a ttm file. This also exposed a problem related to inconsistently using 32-bit

[PATCH 11/16] drm/vmwgfx : Remove vmwgfx_hashtab

2022-10-17 Thread Zack Rusin
From: Maaz Mombasawala The vmwgfx driver has migrated from using the hashtable in vmwgfx_hashtab to the linux/hashtable implementation. Remove the vmwgfx_hashtab from the driver. Signed-off-by: Maaz Mombasawala Reviewed-by: Martin Krastev Reviewed-by: Zack Rusin Signed-off-by: Zack Rusin ---

[PATCH 14/16] drm/vmwgfx: Remove explicit and broken vblank handling

2022-10-17 Thread Zack Rusin
From: Zack Rusin The explicit vblank handling was never finished. The driver never had the full implementation of vblank and what was there is emulated by DRM when the driver doesn't pretend to be implementing it itself. Let DRM handle the vblank emulation and stop pretending the driver is doing

[PATCH 15/16] drm/vmwgfx: Add a mksstat counter for cotable resizes

2022-10-17 Thread Zack Rusin
From: Zack Rusin There's been a lot of cotable resizes on startup which we can track by adding a mks stat to measure both the invocation count and time spent doing cotable resizes. This is only used if kernel is configured with CONFIG_DRM_VMWGFX_MKSSTATS The stats are collected on the host size

[PATCH 08/16] drm/vmwgfx: Support cursor surfaces with mob cursor

2022-10-17 Thread Zack Rusin
From: Michael Banack Add support for cursor surfaces when using mob cursors. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 78 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 1 + 2 files changed, 50 insertions(+), 29 de

[PATCH 09/16] drm/vmwgfx: Diff cursors when using cmds

2022-10-17 Thread Zack Rusin
From: Michael Banack Extend the cursor diffing support to support the command-path. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 119 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 2 + 2 files changed, 61 insertions(+

[PATCH 12/16] drm/vmwgfx: Do not allow invalid bpp's for dumb buffers

2022-10-17 Thread Zack Rusin
From: Zack Rusin Dumb buffers allow a very limited set of formats. Basically everything apart from 1, 2 and 4 is expected to return an error. Make vmwgfx follow those guidelines. This fixes igt's dumb_buffer invalid_bpp test on vmwgfx. Signed-off-by: Zack Rusin Reviewed-by: Martin Krastev Rev

[PATCH 07/16] drm/vmwgfx: Start diffing new mob cursors against old ones

2022-10-17 Thread Zack Rusin
From: Michael Banack Avoid making the SVGA device do extra work if the new cursor image matches the old one. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 95 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 12 ++-- 2 fil

[PATCH 06/16] drm/vmwgfx: Clean up cursor mobs

2022-10-17 Thread Zack Rusin
From: Michael Banack Clean up the cursor mob path by moving ownership of the mobs into the plane_state, and just leaving a cache of unused mobs in the plane itself. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 425 --

[PATCH 04/16] drm/vmwgfx: Remove ttm object hashtable

2022-10-17 Thread Zack Rusin
From: Maaz Mombasawala The object_hash hashtable for ttm objects is not being used. Remove it and perform refactoring in ttm_object init function. Signed-off-by: Maaz Mombasawala Reviewed-by: Zack Rusin Reviewed-by: Martin Krastev Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/ttm_obj

[PATCH 03/16] drm/vmwgfx: Refactor resource manager's hashtable to use linux/hashtable implementation.

2022-10-17 Thread Zack Rusin
From: Maaz Mombasawala Vmwgfx's hashtab implementation needs to be replaced with linux/hashtable to reduce maintenance burden. Refactor cmdbuf resource manager to use linux/hashtable.h implementation as part of this effort. Signed-off-by: Maaz Mombasawala Reviewed-by: Zack Rusin Reviewed-by: M

[PATCH 02/16] drm/vmwgfx: Fix frame-size warning in vmw_mksstat_add_ioctl

2022-10-17 Thread Zack Rusin
From: Martin Krastev Function vmw_mksstat_add_ioctl allocates three big arrays on stack. That triggers frame-size [-Wframe-larger-than=] warning. Refactor that function to use kmalloc_array instead. Signed-off-by: Martin Krastev Reviewed-by: Zack Rusin Reviewed-by: Maaz Mombasawala Signed-off

[PATCH 16/16] drm/vmwgfx: Optimize initial sizes of cotables

2022-10-17 Thread Zack Rusin
From: Zack Rusin It's important to get the initial size of cotables right because otherwise every app needs to start with a synchronous cotable resize. This has an measurable impact on system wide performance but is not relevant for long running single full screen apps for which the cotable resi

[PATCH 05/16] drm/vmwgfx: Refactor resource validation hashtable to use linux/hashtable implementation.

2022-10-17 Thread Zack Rusin
From: Maaz Mombasawala Vmwgfx's hashtab implementation needs to be replaced with linux/hashtable to reduce maintenence burden. As part of this effort, refactor the res_ht hashtable used for resource validation during execbuf execution to use linux/hashtable implementation. This also refactors vmw

[PATCH 01/16] drm/vmwgfx: Write the driver id registers

2022-10-17 Thread Zack Rusin
From: Zack Rusin Driver id registers are a new mechanism in the svga device to hint to the device which driver is running. This should not change device behavior in any way, but might be convenient to work-around specific bugs in guest drivers. Signed-off-by: Zack Rusin Reviewed-by: Martin Kras

[PATCH 00/16] vmwgfx: fb, cursors and hashtable refactor

2022-10-17 Thread Zack Rusin
From: Zack Rusin This is a bit larger series than usual but these are all connected in various ways. The most important changes around everything is centered include: - finally getting rid of vmwgfx_hashtab and porting the driver to linux/hashtable - cleaning up the cursor mob handling, which

[PATCH] fbdev: da8xx-fb: Fix error handling in .remove()

2022-10-17 Thread Uwe Kleine-König
Even in the presence of problems (here: regulator_disable() might fail), it's important to unregister all resources acquired during .probe() and disable the device (i.e. DMA activity) because even if .remove() returns an error code, the device is removed and the .remove() callback is never called a

Re: [PATCH] drm/amdkfd: use vma_lookup() instead of find_vma()

2022-10-17 Thread Felix Kuehling
On 2022-10-06 22:48, Deming Wang wrote: Using vma_lookup() verifies the start address is contained in the found vma. This results in easier to read the code. Thank you for the patches. This and your other patch look good to me. However, you missed one use of find_vma in svm_range_is_valid.

[PATCH] drm/bridge: ps8640: Add back the 50 ms mystery delay after HPD

2022-10-17 Thread Douglas Anderson
Back in commit 826cff3f7ebb ("drm/bridge: parade-ps8640: Enable runtime power management") we removed a mysterious 50 ms delay because "Parade's support [couldn't] explain what the delay [was] for". While I'm always a fan of removing mysterious delays, I suspect that we need this mysterious delay

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
On 10/17/22 21:00, John Keeping wrote: > On Mon, Oct 17, 2022 at 08:30:23PM +0200, Johan Jonker wrote: >> >> >> On 10/17/22 13:29, Heiko Stuebner wrote: >>> Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: Hi Johan, On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan J

Re: [PATCH 2/2] drm/connector: send hotplug uevent on connector cleanup

2022-10-17 Thread Lyude Paul
LGTM! Thank you for the help with this: Reviewed-by: Lyude Paul On Mon, 2022-10-17 at 15:32 +, Simon Ser wrote: > A typical DP-MST unplug removes a KMS connector. However care must > be taken to properly synchronize with user-space. The expected > sequence of events is the following: > > 1.

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread John Keeping
On Mon, Oct 17, 2022 at 08:30:23PM +0200, Johan Jonker wrote: > > > On 10/17/22 13:29, Heiko Stuebner wrote: > > Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: > >> Hi Johan, > >> > >> On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: > >>> Your patch contribution ca

Re: [PATCH v3] drm/amd/display: add an ASSERT() to irq service functions

2022-10-17 Thread Harry Wentland
On 2022-10-17 12:13, Hamza Mahfooz wrote: > Currently, if we encounter unimplemented functions, it is difficult to > tell what caused them just by looking at dmesg and that is compounded by > the fact that it is often hard to reproduce said issues, for instance we > have had reports of this conditi

Re: [PATCH] drm: bridge: adv7511: use dev_err_probe in probe function

2022-10-17 Thread Laurent Pinchart
Hi Ahmad, Thank you for the patch. On Mon, Oct 17, 2022 at 08:28:09PM +0200, Ahmad Fatoum wrote: > adv7511 probe may need to be attempted multiple times before no > -EPROBE_DEFER is returned. Currently, every such probe results in > an error message: > > [4.534229] adv7511 1-003d: failed to

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
On 10/17/22 13:29, Heiko Stuebner wrote: > Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: >> Hi Johan, >> >> On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: >>> Your patch contribution causes a kernel panic on MK808 with Rockchip >>> rk3066a SoC. >>> Would you li

[PATCH] drm: bridge: adv7511: use dev_err_probe in probe function

2022-10-17 Thread Ahmad Fatoum
adv7511 probe may need to be attempted multiple times before no -EPROBE_DEFER is returned. Currently, every such probe results in an error message: [4.534229] adv7511 1-003d: failed to find dsi host [4.580288] adv7511 1-003d: failed to find dsi host This is misleading, as there is no erro

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-17 Thread Rob Herring
On Mon, Oct 17, 2022 at 9:54 AM Thierry Reding wrote: > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 07.10.22 um 14:49 schrieb Thierry Reding: > > > From: Thierry Reding > > > > > > Simple framebuffers can be set up in system memory, which cannot be > > >

Re: [PATCH v2 1/2] drm/i915: Add intel_ prefix to struct ip_version

2022-10-17 Thread Lucas De Marchi
On Tue, Oct 11, 2022 at 08:38:50AM -0700, Radhakrishna Sripada wrote: Rename struct ip_version to intel_ip_version to comply with the naming conventions for structures. Suggested-by: Jani Nikula Signed-off-by: Radhakrishna Sripada Reviewed-by: Lucas De Marchi Lucas De Marchi

[PATCH v7 18/21] dma-buf: Move dma_buf_mmap() to dynamic locking specification

2022-10-17 Thread Dmitry Osipenko
Move dma_buf_mmap() function to the dynamic locking specification by taking the reservation lock. Neither of the today's drivers take the reservation lock within the mmap() callback, hence it's safe to enforce the locking. Acked-by: Sumit Semwal Acked-by: Christian König Signed-off-by: Dmitry Os

Re: [PATCH 5/7] drm/vc4: dpi: Support BGR666 formats

2022-10-17 Thread Dave Stevenson
Hi Laurent Thanks for the review. On Sat, 15 Oct 2022 at 18:31, Laurent Pinchart wrote: > > On Sat, Oct 15, 2022 at 08:26:48PM +0300, Laurent Pinchart wrote: > > Hi Maxime and Joerg, > > > > Thank you for the patch. > > > > On Thu, Oct 13, 2022 at 11:56:49AM +0200, Maxime Ripard wrote: > > > Fro

[PATCH v7 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification

2022-10-17 Thread Dmitry Osipenko
Move dma_buf_vmap/vunmap() functions to the dynamic locking specification by asserting that the reservation lock is held. Acked-by: Sumit Semwal Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/dma-buf/dma-buf.c | 4 1 file changed, 4 insertions(+) diff --git a/driver

[PATCH v7 21/21] dma-buf: Remove obsoleted internal lock

2022-10-17 Thread Dmitry Osipenko
The internal dma-buf lock isn't needed anymore because the updated locking specification claims that dma-buf reservation must be locked by importers, and thus, the internal data is already protected by the reservation lock. Remove the obsoleted internal lock. Acked-by: Sumit Semwal Acked-by: Chri

[PATCH v7 17/21] dma-buf: Move dma_buf_map_attachment() to dynamic locking specification

2022-10-17 Thread Dmitry Osipenko
Move dma-buf attachment mapping functions to the dynamic locking specification by asserting that the reservation lock is held. Acked-by: Sumit Semwal Reviewed-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/dma-buf/dma-buf.c | 10 ++ 1 file changed, 2 insertions(+), 8 de

[PATCH v7 16/21] dma-buf: Move dma_buf_attach() to dynamic locking specification

2022-10-17 Thread Dmitry Osipenko
Move dma-buf attachment API functions to the dynamic locking specification by taking the reservation lock around the mapping operations. The strict locking convention prevents deadlock situations for dma-buf importers and exporters. Acked-by: Sumit Semwal Reviewed-by: Christian König Signed-off-

[PATCH v7 19/21] dma-buf: Document dynamic locking convention

2022-10-17 Thread Dmitry Osipenko
Add documentation for the dynamic locking convention. The documentation tells dma-buf API users when they should take the reservation lock and when not. Acked-by: Sumit Semwal Reviewed-by: Christian König Signed-off-by: Dmitry Osipenko --- Documentation/driver-api/dma-buf.rst | 6 +++ drivers

[PATCH v7 20/21] media: videobuf2: Stop using internal dma-buf lock

2022-10-17 Thread Dmitry Osipenko
All drivers that use dma-bufs have been moved to the updated locking specification and now dma-buf reservation is guaranteed to be locked by importers during the mapping operations. There is no need to take the internal dma-buf lock anymore. Remove locking from the videobuf2 memory allocators. Ack

[PATCH v7 13/21] media: videobuf2: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare V4L2 memory allocators to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Tomasz Figa Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/media/common/videobuf2/videobuf2-dma-contig.c | 11 +

[PATCH v7 11/21] misc: fastrpc: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare fastrpc to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Acked-by: Srinivas Kandagatla Signed-off-by: Dmitry Osipenko --- drivers/misc/fastrpc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 d

[PATCH v7 10/21] RDMA/umem: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare InfiniBand drivers to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Jason Gunthorpe Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/infiniband/core/umem_dmabuf.c | 7 --- 1 file change

[PATCH v7 14/21] media: tegra-vde: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare Tegra video decoder driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/media/platform/nvidia/tegra-vde/dmabuf-cache.c | 6 +++--- 1 file changed,

[PATCH v7 08/21] drm/tegra: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare Tegra DRM driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/gem.c | 17 + 1 file changed, 9 insertions(+), 8 deleti

[PATCH v7 09/21] drm/etnaviv: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare Etnaviv driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH v7 07/21] drm/omapdrm: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare OMAP DRM driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH v7 12/21] xen/gntdev: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare gntdev driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Juergen Gross Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/xen/gntdev-dmabuf.c | 8 1 file changed, 4 insertions(

[PATCH v7 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare i915 driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions and handling cases where importer now holds the reservation lock. Acked-by: Christian König Reviewed-by: Michael J. Ruhl Signed-off-by: Dmitry Osipenko --- dri

[PATCH v7 05/21] drm/armada: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare Armada driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/armada/armada_gem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-

[PATCH v7 04/21] drm/prime: Prepare to dynamic dma-buf locking specification

2022-10-17 Thread Dmitry Osipenko
Prepare DRM prime core to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Reviewed-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_prime.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

[PATCH v7 03/21] drm/gem: Take reservation lock for vmap/vunmap operations

2022-10-17 Thread Dmitry Osipenko
The new common dma-buf locking convention will require buffer importers to hold the reservation lock around mapping operations. Make DRM GEM core to take the lock around the vmapping operations and update DRM drivers to use the locked functions for the case where DRM core now holds the lock. This p

[PATCH v7 01/21] dma-buf: Add unlocked variant of vmapping functions

2022-10-17 Thread Dmitry Osipenko
Add unlocked variant of dma_buf_vmap/vunmap() that will be utilized by drivers that don't take the reservation lock explicitly. Acked-by: Sumit Semwal Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/dma-buf/dma-buf.c | 43 +++ include/li

[PATCH v7 02/21] dma-buf: Add unlocked variant of attachment-mapping functions

2022-10-17 Thread Dmitry Osipenko
Add unlocked variant of dma_buf_map/unmap_attachment() that will be used by drivers that don't take the reservation lock explicitly. Acked-by: Sumit Semwal Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/dma-buf/dma-buf.c | 53 +++ inclu

[PATCH v7 00/21] Move all drivers to a common dma-buf locking convention

2022-10-17 Thread Dmitry Osipenko
Hello, This series moves all drivers to a dynamic dma-buf locking specification. >From now on all dma-buf importers are made responsible for holding dma-buf's reservation lock around all operations performed over dma-bufs in accordance to the locking specification. This allows us to utilize reserv

Re: [PATCH 4/7] drm/vc4: dpi: Support RGB565 format

2022-10-17 Thread Dave Stevenson
Hi Laurent On Sat, 15 Oct 2022 at 18:29, Laurent Pinchart wrote: > > Hi Maxime and Chris, > > Thank you for the patch. > > On Thu, Oct 13, 2022 at 11:56:48AM +0200, Maxime Ripard wrote: > > From: Chris Morgan > > > > The RGB565 format with padding over 24 bits > > (MEDIA_BUS_FMT_RGB565_1X24_CPAD

Re: [PATCH 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24.

2022-10-17 Thread Dave Stevenson
Hi Laurent On Sat, 15 Oct 2022 at 18:14, Laurent Pinchart wrote: > > Hi Maxime (and Dave), > > Thank you for the patch. > > On Thu, Oct 13, 2022 at 11:56:50AM +0200, Maxime Ripard wrote: > > From: Dave Stevenson > > > > DPI hasn't really been used up until now, so the default has > > been meanin

Re: [Intel-gfx] [PATCH v3 14/14] drm/i915/xelpmp: Add multicast steering for media GT

2022-10-17 Thread Balasubramani Vivekanandan
On 14.10.2022 16:02, Matt Roper wrote: > MTL's media IP (Xe_LPM+) only has a single type of steering ("OAADDRM") > which selects between media slice 0 and media slice 1. We'll always > steer to media slice 0 unless it is fused off (which is the case when > VD0, VE0, and SFC0 are all reported as un

Re: [PATCH v3 13/14] drm/i915/xelpg: Add multicast steering

2022-10-17 Thread Balasubramani Vivekanandan
On 14.10.2022 16:02, Matt Roper wrote: > MTL's graphics IP (Xe_LPG) once again changes the multicast register > types and steering details. Key changes from past platforms: > * The number of instances of some MCR types (NODE, OAAL2, and GAM) vary >according to the MTL subplatform and cannot b

Re: [Intel-gfx] [PATCH v3 12/14] drm/i915: Define multicast registers as a new type

2022-10-17 Thread Balasubramani Vivekanandan
On 14.10.2022 16:02, Matt Roper wrote: > Rather than treating multicast registers as 'i915_reg_t' let's define > them as a completely new type. This will allow the compiler to help us > make sure we're using multicast-aware functions to operate on multicast > registers. > > This plan does break d

Re: [PATCH] drm/amdkfd: Fix type of reset_type parameter in hqd_destroy() callback

2022-10-17 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Oct 17, 2022 at 12:30 PM Nathan Chancellor wrote: > > When booting a kernel compiled with CONFIG_CFI_CLANG on a machine with > an RX 6700 XT, there is a CFI failure in kfd_destroy_mqd_cp(): > > [ 12.894543] CFI failure at kfd_destroy_mqd_cp+0x2a/0x40 [amdgpu]

Re: [Intel-gfx] [PATCH v3 11/14] drm/i915/gt: Add MCR-specific workaround initializers

2022-10-17 Thread Balasubramani Vivekanandan
On 14.10.2022 16:02, Matt Roper wrote: > Let's be more explicit about which of our workarounds are updating MCR > registers. > > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 433 +++--- > .../gpu/drm/i915/gt/intel_workarounds_types.h | 4 +- > 2

Re: [PATCH v3 10/14] drm/i915/guc: Handle save/restore of MCR registers explicitly

2022-10-17 Thread Balasubramani Vivekanandan
On 14.10.2022 16:02, Matt Roper wrote: > MCR registers can be placed on the GuC's save/restore list, but at the > moment they are always handled in a multicast manner (i.e., the GuC > reads one instance to save the value and then does a multicast write to > restore that single value to all instance

Re: [PATCH v3 09/14] drm/i915/gt: Always use MCR functions on multicast registers

2022-10-17 Thread Balasubramani Vivekanandan
On 14.10.2022 16:02, Matt Roper wrote: > Rather than relying on the implicit behavior of intel_uncore_*() > functions, let's always use the intel_gt_mcr_*() functions to operate on > multicast/replicated registers. > > v2: > - Add TLB invalidation registers > > v3: > - Switch more uncore operat

Re: [RESEND PATCH] drm/amd/amdgpu: Replace kmap() with kmap_local_page()

2022-10-17 Thread Alex Deucher
Applied. Thanks! On Sun, Oct 16, 2022 at 1:42 PM Fabio M. De Francesco wrote: > > kmap() is being deprecated in favor of kmap_local_page(). > > There are two main problems with kmap(): (1) It comes with an overhead as > mapping space is restricted and protected by a global lock for > synchroniza

  1   2   >