Re: [PATCH v1 3/5] arm64: dts: qcom: sm8450-hdk: enable display hardware

On Fri, Nov 04, 2022 at 04:13:56PM +0300, Dmitry Baryshkov wrote: > Enable MDSS/DPU/DSI0 on SM8450-HDK device. Note, there is no panel > configuration (yet). > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 18 ++ > 1 file changed, 18 insertio

Re: [PATCH v3 2/2] drivers: gpu: drm: remove support for sofef00 driver on s6e3fc2x01 panel

On Sat, Oct 08, 2022 at 03:12:03PM +0200, Nia Espera wrote: Same comment as on patch 1 regarding $subject prefix. > Removes functionality from sofef00 panel driver which allowed it to > drive the s6e3fc2x01 panel > This states what the removed code relates to, but not why you're doing it. > Si

Re: [PATCH v3 1/2] drivers: gpu: drm: add driver for samsung s6e3fc2x01 cmd mode panel

On Sat, Oct 08, 2022 at 03:12:01PM +0200, Nia Espera wrote: > Adds a dedicated driver for the Samsung s6e3fc2x01 panel used in OnePlus > 6T smartphones which was previously driven by the sofef00 panel driver > > Signed-off-by: Nia Espera > Reviewed-by: Caleb Connolly > --- > MAINTAINERS

[PATCH v8 7/7] drm/panfrost: Switch to generic memory shrinker

Replace Panfrost's custom memory shrinker with a common drm-shmem memory shrinker. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/panfrost/Makefile | 1 - drivers/gpu/drm/panfrost/panfrost_device.h| 4 - drivers/gpu/drm/panfrost/panfrost_drv.c | 19 +-- drivers/gpu

[PATCH v8 5/7] drm/gem: Add drm_gem_pin_unlocked()

Add unlocked variants of drm_gem_un/pin() functions. These new helpers will take care of GEM dma-reservation locking for DRM drivers. VirtIO-GPU driver will use these helpers to pin shmem framebuffers, preventing them from eviction during scanout. Signed-off-by: Dmitry Osipenko --- drivers/gpu/

[PATCH v8 6/7] drm/virtio: Support memory shrinking

Support generic drm-shmem memory shrinker and add new madvise IOCTL to the VirtIO-GPU driver. BO cache manager of Mesa driver will mark BOs as "don't need" using the new IOCTL to let shrinker purge the marked BOs on OOM, the shrinker will also evict unpurgeable shmem BOs from memory if guest suppor

[PATCH v8 3/7] drm/shmem-helper: Switch to reservation lock

Replace all drm-shmem locks with a GEM reservation lock. This makes locks consistent with dma-buf locking convention where importers are responsible for holding reservation lock for all operations performed over dma-bufs, preventing deadlock between dma-buf importers and exporters. Suggested-by: D

[PATCH v8 4/7] drm/shmem-helper: Add memory shrinker

Introduce common drm-shmem shrinker for DRM drivers. To start using drm-shmem shrinker drivers should do the following: 1. Implement evict() callback of shmem object where driver should check whether object is purgeable or evictable and perform shrinking action 2. Register shrinker using drm_g

[PATCH v8 2/7] drm/shmem-helper: Don't use vmap_use_count for dma-bufs

DMA-buf core has its own refcounting of vmaps, use it instead of drm-shmem counting. This change prepares drm-shmem for addition of memory shrinker support where drm-shmem will use a single dma-buf reservation lock for all operations performed over dma-bufs. Signed-off-by: Dmitry Osipenko --- dr

[PATCH v8 1/7] drm/msm/gem: Prevent blocking within shrinker loop

Consider this scenario: 1. APP1 continuously creates lots of small GEMs 2. APP2 triggers `drop_caches` 3. Shrinker starts to evict APP1 GEMs, while APP1 produces new purgeable GEMs 4. msm_gem_shrinker_scan() returns non-zero number of freed pages and causes shrinker to try shrink more 5. msm

[PATCH v8 0/7] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

This series: 1. Adds common drm-shmem memory shrinker 2. Enables shrinker for VirtIO-GPU driver 3. Switches Panfrost driver to the common shrinker Related patches: Mesa: https://gitlab.freedesktop.org/digetx/mesa/-/commits/virgl-madvise igt: https://gitlab.freedesktop.org/digetx/igt-gpu-

bug report with amdgpu drm-next-6.2

I have an Ampere Altra machine that I have put a Radeon 6500 XT card on seeing the pull request for drm-next-6.2 https://lore.kernel.org/dri-devel/20221104205827.6008-1-alexander.deuc...@amd.com/ I grabbed the tree and built it. On boot I am getting [ 23.877255] [drm] amdgpu kernel modesetting

[PATCH] drm/atomic: do not branch based on the value of current->comm[0]

This reverts 26b1d3b527e7 ("drm/atomic: Take the atomic toys away from X"), a rootkit-like kludge that has no business being inside of a general purpose kernel. It's the type of debugging hack I'll use momentarily but never commit, or a sort of babbies-first-process-hider malware trick. The backst

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, 5 Nov 2022 14:13:14 -0700 Linus Torvalds wrote: > (Comparing output is also fun because the ordering of the patches is > random, so consecutive runs with the same rule will give different > patches. I assume that it's just because it's done in parallel, but it > doesn't help the "try to s

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, 5 Nov 2022 14:13:14 -0700 Linus Torvalds wrote: > And trying "when != ptr->timer" actually does the right thing in that > it gets rid of the case where the timer is modified outside of the > del_timer() case, *but* it also causes odd other changes to the > output. > > Look at what it gen

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, Nov 5, 2022 at 2:03 PM Jason A. Donenfeld wrote: > > Something that might help here is changing the `...` into > `... when exists` or into `... when != ptr` or similar. I actually tried that. You don't want "when exists", you'd want "when forall", but that seems to be the default. And t

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, Nov 05, 2022 at 12:36:42PM -0400, Steven Rostedt wrote: > --8< > @@ > identifier ptr, timer, rfield, slab; > @@ > ( > - del_timer(&ptr->timer); > + timer_shutdown(&ptr->timer); > | > - del_timer_sync(&ptr->timer); > + timer_shutdow

[Bug 216665] New: Synopsys Designware HDMI >= 2.10a seems not to insert PCUV bits into HDMI audio stream unless insert_pcuv bit is set

https://bugzilla.kernel.org/show_bug.cgi?id=216665 Bug ID: 216665 Summary: Synopsys Designware HDMI >= 2.10a seems not to insert PCUV bits into HDMI audio stream unless insert_pcuv bit is set Product: Drivers Vers

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, Nov 05, 2022 at 02:00:24AM -0400, Steven Rostedt wrote: > > Back in April, I posted an RFC patch set to help mitigate a common issue > where a timer gets armed just before it is freed, and when the timer > goes off, it crashes in the timer code without any evidence of who the > culprit was

Re: [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

On Thu, Nov 03, 2022 at 09:51:23AM -0700, Ira Weiny wrote: > Date: Thu, 3 Nov 2022 09:51:23 -0700 > From: Ira Weiny > Subject: Re: [PATCH 1/9] drm/i915: Use kmap_local_page() in > gem/i915_gem_object.c > > On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote: > > On luned? 17 ot

Re: [PATCH 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

On Sat, Oct 29, 2022 at 09:12:27AM +0200, Fabio M. De Francesco wrote: > Date: Sat, 29 Oct 2022 09:12:27 +0200 > From: "Fabio M. De Francesco" > Subject: Re: [PATCH 0/9] drm/i915: Replace kmap_atomic() with > kmap_local_page() Hi Fabio, thanks for your review!! (I'm sorry I missed the previous m

bug report with amdgpu drm-next-6.2

I have an Ampere Altra machine that I have put a Radeon 6500 XT card on seeing the pull request for drm-next-6.2 https://lore.kernel.org/dri-devel/20221104205827.6008-1-alexander.deuc...@amd.com/ I grabbed the tree and built it. On boot I am getting [ 23.877255] [drm] amdgpu kernel modesetting

Re: [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote: > Date: Sat, 29 Oct 2022 13:17:03 +0200 > From: "Fabio M. De Francesco" > Subject: Re: [PATCH 1/9] drm/i915: Use kmap_local_page() in > gem/i915_gem_object.c > > On luned? 17 ottobre 2022 11:37:17 CEST Zhao Liu wrote: > > Fro

Re: [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

On Thu, Nov 03, 2022 at 08:22:04PM +0100, Fabio M. De Francesco wrote: > Date: Thu, 03 Nov 2022 20:22:04 +0100 > From: "Fabio M. De Francesco" > Subject: Re: [PATCH 1/9] drm/i915: Use kmap_local_page() in > gem/i915_gem_object.c > > On gioved? 3 novembre 2022 17:51:23 CET Ira Weiny wrote: > > On

Re: [PATCH 2/9] drm/i915: Use kmap_local_page() in gem/i915_gem_pyhs.c

On Sat, Oct 29, 2022 at 03:32:08PM +0200, Fabio M. De Francesco wrote: > Date: Sat, 29 Oct 2022 15:32:08 +0200 > From: "Fabio M. De Francesco" > Subject: Re: [PATCH 2/9] drm/i915: Use kmap_local_page() in > gem/i915_gem_pyhs.c > > On luned? 17 ottobre 2022 11:37:18 CEST Zhao Liu wrote: > > From:

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

Maxime Ripard writes: > Hi Paul, > > On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: >> Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a >> écrit : >> > The Ingenic CGU clocks implements a mux with a set_parent hook, but >> > doesn't provide a determine_rate implementation.

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, Nov 5, 2022 at 11:04 AM Steven Rostedt wrote: > > Here's the changes I made after running the script Please. No. What part of "I don't want extra crud" was I unclear on? I'm not interested in converting everything. That's clearly a 6.,2 issue, possibly even longer considering how compli

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, 5 Nov 2022 14:03:56 -0400 Steven Rostedt wrote: > --- a/drivers/isdn/hardware/mISDN/hfcmulti.c > +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c > @@ -4544,7 +4544,7 @@ release_port(struct hfc_multi *hc, struct dchannel *dch) > spin_lock_irqsave(&hc->lock, flags); > > if (dch->

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, 5 Nov 2022 12:36:42 -0400 Steven Rostedt wrote: > --8< > @@ > identifier ptr, timer, rfield, slab; > @@ > ( > - del_timer(&ptr->timer); > + timer_shutdown(&ptr->timer); > | > - del_timer_sync(&ptr->timer); > + timer_shutdown_sync

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, 5 Nov 2022 08:59:36 -0700 Linus Torvalds wrote: > Others in the series were *definitely* not scripted, doing clearly > manual cleanups: > > -if (dch->timer.function) { > -del_timer(&dch->timer); > -dch->timer.function = NULL; > -} > +timer_shutdown(&dch->timer

Re: [PATCH v6 14/23] drm/modes: Properly generate a drm_display_mode from a named mode

Den 26.10.2022 17.33, skrev max...@cerno.tech: > The framework will get the drm_display_mode from the drm_cmdline_mode it > got by parsing the video command line argument by calling > drm_connector_pick_cmdline_mode(). > > The heavy lifting will then be done by the drm_mode_create_from_cmdline_

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, 5 Nov 2022 12:36:42 -0400 Steven Rostedt wrote: > On Sat, 5 Nov 2022 08:59:36 -0700 > Linus Torvalds wrote: > > > On Fri, Nov 4, 2022 at 11:01 PM Steven Rostedt wrote: > > > > > > > > Patch 1 fixes an issue with sunrpc/xprt where it incorrectly uses > > > del_singleshot_timer_sync()

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, 5 Nov 2022 08:59:36 -0700 Linus Torvalds wrote: > On Fri, Nov 4, 2022 at 11:01 PM Steven Rostedt wrote: > > > > Patch 1 fixes an issue with sunrpc/xprt where it incorrectly uses > > del_singleshot_timer_sync() for something that is not a oneshot timer. As > > this > > will be converted

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Fri, Nov 4, 2022 at 11:01 PM Steven Rostedt wrote: > > Patch 1 fixes an issue with sunrpc/xprt where it incorrectly uses > del_singleshot_timer_sync() for something that is not a oneshot timer. As this > will be converted to shutdown, this needs to be fixed first. So this is the kind of thing

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, 5 Nov 2022 07:18:17 -0700 Guenter Roeck wrote: > Just in case you didn't notice: > > Looking through the resulting code, I think some of the remaining > calls to del_singleshot_timer_sync() can be converted as well. > > The calls in drivers/staging/wlan-ng/prism2usb.c:prism2sta_disconne

Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

On Sat, Nov 05, 2022 at 02:00:24AM -0400, Steven Rostedt wrote: > > Back in April, I posted an RFC patch set to help mitigate a common issue > where a timer gets armed just before it is freed, and when the timer > goes off, it crashes in the timer code without any evidence of who the > culprit was

Re: [PATCH v6 09/23] drm/modes: Switch to named mode descriptors

Den 26.10.2022 17.33, skrev max...@cerno.tech: > The current named mode parsing relies only the mode name, and doesn't allow only the -> only on the > to specify any other parameter. > > Let's convert that string list to an array of a custom structure that will > hold the name and some additi

Re: [PATCH v6 08/23] drm/modes: Move named modes parsing to a separate function

Den 26.10.2022 17.33, skrev max...@cerno.tech: > The current construction of the named mode parsing doesn't allow to extend > it easily. Let's move it to a separate function so we can add more > parameters and modes. > > In order for the tests to still pass, some extra checks are needed, so > i

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

Hi Maxime, Le ven. 4 nov. 2022 à 15:59:46 +0100, Maxime Ripard a écrit : Hi Paul, On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a écrit : > The Ingenic CGU clocks implements a mux with a set_parent hook, but > doesn

Re: [PATCH v4a 31/38] timers: drm: Use timer_shutdown_sync() for on stack timers

Den 05.11.2022 07.00, skrev Steven Rostedt: > From: "Steven Rostedt (Google)" > > Before a timer is released, timer_shutdown_sync() must be called. > > Link: https://lore.kernel.org/all/20221104054053.431922...@goodmis.org/ > > Cc: "Noralf Trønnes" > Cc: David Airlie > Cc: Daniel Vetter >

Re: [Linaro-mm-sig] Re: [RFC][PATCH v3 12/33] timers: dma-buf: Use timer_shutdown_sync() before freeing timer

Am 04.11.22 um 19:58 schrieb Steven Rostedt: On Fri, 4 Nov 2022 08:15:53 +0100 Christian König wrote: index fb6e0a6ae2c9..5d3e7b503501 100644 --- a/drivers/dma-buf/st-dma-fence.c +++ b/drivers/dma-buf/st-dma-fence.c @@ -412,7 +412,7 @@ static int test_wait_timeout(void *arg) err = 0;