[PATCH v4 4/4] doc: add documentation for accel subsystem

2022-11-19 Thread Oded Gabbay
Add an introduction section for the accel subsystem. Most of the relevant data is in the DRM documentation, so the introduction only presents the why of the new subsystem, how are the compute accelerators exposed to user-space and what changes need to be done in a standard DRM driver to register it

[PATCH v4 3/4] drm: initialize accel framework

2022-11-19 Thread Oded Gabbay
Now that we have the accel framework code ready, let's call the accel functions from all the appropriate places. These places are the drm module init/exit functions, and all the drm_minor handling functions. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/drm_drv.c | 102 +++

[PATCH v4 2/4] accel: add dedicated minor for accelerator devices

2022-11-19 Thread Oded Gabbay
The accelerator devices are exposed to user-space using a dedicated major. In addition, they are represented in /dev with new, dedicated device char names: /dev/accel/accel*. This is done to make sure any user-space software that tries to open a graphic card won't open the accelerator device by mis

[PATCH v4 1/4] drivers/accel: define kconfig and register a new major

2022-11-19 Thread Oded Gabbay
Add a new Kconfig for the accel subsystem. The Kconfig currently contains only the basic CONFIG_DRM_ACCEL option that will be used to decide whether to compile the accel registration code. Therefore, the kconfig option is defined as bool. The accel code will be compiled as part of drm.ko and will

[PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-19 Thread Oded Gabbay
This is the fourth (and hopefully last) version of the patch-set to add the new subsystem for compute accelerators. I removed the RFC headline as I believe it is now ready for merging. Compare to v3, this patch-set contains one additional patch that adds documentation regarding the accel subsystem

Re: Try to address the DMA-buf coherency problem

2022-11-19 Thread Nicolas Dufresne
Le vendredi 18 novembre 2022 à 11:32 -0800, Rob Clark a écrit : > On Thu, Nov 17, 2022 at 7:38 AM Nicolas Dufresne wrote: > > > > Le jeudi 17 novembre 2022 à 13:10 +0100, Christian König a écrit : > > > > > DMA-Buf let's the exporter setup the DMA addresses the importer uses > > > > > to > > > >

Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types

2022-11-19 Thread Laurent Pinchart
Hello, On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote: > Hi Sakari, > > Gentle ping. > > On Sun, Jul 17, 2022 at 06:54:00AM +, Sakari Ailus wrote: > > Folks, > > > > > Laurent Pinchart (6): > > > dt-bindings: media: Add macros for video interface bus types > > > dt-bindings:

Re: [PATCH 014/606] drm/bridge: adv7511: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:48PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/

Re: [PATCH 017/606] drm/bridge: anx7625: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:51PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 015/606] drm/bridge/analogix/anx6345: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:49PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 016/606] drm/bridge/analogix/anx78xx: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:50PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 035/606] drm/bridge: ti-sn65dsi83: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:09PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/

Re: [PATCH 024/606] drm/bridge: lt9611: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:58PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 022/606] drm/bridge: lt8912b: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:56PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 037/606] drm/bridge: tfp410: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:11PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 025/606] drm/bridge: lt9611uxc: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:59PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 028/606] drm/bridge: parade-ps8622: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:02PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/

Re: [PATCH 034/606] drm/bridge/tc358775: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:08PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 032/606] drm/bridge: tc358767: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:06PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 033/606] drm/bridge: tc358768: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:07PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 030/606] drm/bridge: sii9234: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:04PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 027/606] drm/bridge: nxp-ptn3460: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:01PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 036/606] drm/bridge: ti-sn65dsi86: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:10PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 029/606] drm/bridge: sii902x: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:03PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 021/606] drm/bridge: it66121: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:55PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 018/606] drm/bridge: icn6211: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:52PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 026/606] drm/bridge: megachips: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:00PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > .../gpu/drm/bridg

[PATCH v6 3/5] drm/tidss: Add support to configure OLDI mode for am625-dss.

2022-11-19 Thread Aradhya Bhatia
The newer version of DSS (AM625-DSS) has 2 OLDI TXes at its disposal. These can be configured to support the following modes: 1. OLDI_SINGLE_LINK_SINGLE_MODE Single Output over OLDI 0. +--++-+ +---+ | || | | | | CRTC +--->+ ENCODER +

[PATCH v6 5/5] drm/tidss: Enable Dual and Duplicate Modes for OLDI

2022-11-19 Thread Aradhya Bhatia
The AM625 DSS IP contains 2 OLDI TXes which can work together to enable 2 cloned displays of or even a single dual-link display with higher resolutions like WUXGA (1920x1200@60fps) with a reduced OLDI clock frequency. Configure the necessary register to enable and disable the OLDI TXes with requir

[PATCH v6 0/5] Add DSS support for AM625 SoC

2022-11-19 Thread Aradhya Bhatia
This patch series adds a new compatible for the Display SubSyetem controller on TI's AM625 SoC. It further adds the required support for the same in the tidss driver. The AM625-DSS is a newer version of the DSS from the AM65X version with the major change being the addition of another OLDI TX. Wit

[PATCH v6 4/5] drm/tidss: Add IO CTRL and Power support for OLDI TX in am625

2022-11-19 Thread Aradhya Bhatia
The ctrl mmr module of the AM625 is different from the AM65X SoC. Thus the ctrl mmr registers that supported the OLDI TX power have become different in AM625 SoC. Add IO CTRL support and control the OLDI TX power for AM625. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/tidss/tidss_dispc.c

Re: [PATCH 031/606] drm/bridge: sii8620: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:36:05PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

[PATCH v6 2/5] drm/tidss: Add support for AM625 DSS

2022-11-19 Thread Aradhya Bhatia
Add support for the DSS controller on TI's new AM625 SoC in the tidss driver. The first video port (VP0) in am625-dss can output OLDI signals through 2 OLDI TXes. A 3rd output port has been added with "DISPC_VP_OLDI" bus type. DSS controllers before AM625 had a 1 to 1 coupling between Videoports

[PATCH v6 1/5] dt-bindings: display: ti, am65x-dss: Add support for am625 dss

2022-11-19 Thread Aradhya Bhatia
The DSS controller on TI's AM625 SoC is an update from that on TI's AM65X SoC. The former has an additional OLDI TX on its first video port (VP0) that helps output cloned video or WUXGA (1920x1200@60fps) resolution video output over a dual-link mode to reduce the required OLDI clock output. Add th

Re: [PATCH 023/606] drm/bridge: lt9211: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:57PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 020/606] drm/bridge: it6505: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:54PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH 019/606] drm/bridge: chrontel-ch7033: Convert to i2c's .probe_new()

2022-11-19 Thread Laurent Pinchart
On Fri, Nov 18, 2022 at 11:35:53PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/b

Re: [PATCH v5 1/5] drm/ofdrm: Add ofdrm for Open Firmware framebuffers

2022-11-19 Thread Michal Suchánek
Hello, On Tue, Oct 11, 2022 at 05:07:08PM +0200, Thomas Zimmermann wrote: > Open Firmware provides basic display output via the 'display' node. > DT platform code already provides a device that represents the node's > framebuffer. Add a DRM driver for the device. The display mode and > color forma

Re: [PATCH v8 06/14] drm: bridge: samsung-dsim: Handle proper DSI host initialization

2022-11-19 Thread Marek Vasut
On 11/17/22 14:04, Marek Szyprowski wrote: On 17.11.2022 05:58, Marek Vasut wrote: On 11/10/22 19:38, Jagan Teki wrote: DSI host initialization handling in previous exynos dsi driver has some pitfalls. It initializes the host during host transfer() hook that is indeed not the desired call flow

Re: [PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-19 Thread Christian König
Am 18.11.22 um 18:05 schrieb T.J. Mercier: On Fri, Nov 18, 2022 at 12:27 AM Christian König wrote: Am 18.11.22 um 03:36 schrieb T.J. Mercier: > On Thu, Nov 17, 2022 at 2:16 AM Christian König > wrote: >> Am 17.11.22 um 08:48 schrieb Charan Teja Kalla: >>> Sometime back

[PATCH] drm/amd/display: rewrite the check for mods

2022-11-19 Thread Jiasheng Jiang
On Thu, 17 Nov 2022 15:56:09 +0800, Simon Ser wrote: >> @@ -638,11 +638,14 @@ static int get_plane_modifiers(struct amdgpu_device >> *adev, unsigned int plane_ty >> return 0; >> >> *mods = kmalloc(capacity * sizeof(uint64_t), GFP_KERNEL); >> +if (!*mods) >> +ret

[PATCH v2] amdgpu: nbio_v7_4: Add pointer check

2022-11-19 Thread Denis Arefev
Return value of a function 'amdgpu_ras_find_obj' is dereferenced at nbio_v7_4.c:325 without checking for null Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [PATCH 01/23] dt-bindings: display: tegra: add bindings for Tegra20 VIP

2022-11-19 Thread Luca Ceresoli
Hello Krzysztof, thanks for the review. I'm glad my error rate on bindings is lower than it used to be before I attended your ELCE talk! ;) On Tue, 15 Nov 2022 13:12:44 +0100 Krzysztof Kozlowski wrote: > On 09/11/2022 15:18, luca.ceres...@bootlin.com wrote: > > From: Luca Ceresoli > > > > VIP

[PATCH] fbdev: da8xx-fb: add missing regulator_disable() in fb_probe

2022-11-19 Thread Dongliang Mu
The error handling code in fb_probe misses regulator_disable if regulator_enable is called successfully. The previous commit only adds regulator_disable in the .remove(), forgetting the error handling code in the .probe. Fix this by adding a new error label to call regulator_disable. Fixes: 61109

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-19 Thread Carlo Caione
On 17/11/2022 15:59, Mark Brown wrote: So this is an issue in the MIPI DBI code where the interpretation of the buffer passed in depends on both the a caller parameter and the capabilities of the underlying SPI controller, meaning that a driver can suddenly become buggy when used with a new co

Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types

2022-11-19 Thread Paul Elder
Hi Sakari, Gentle ping. On Sun, Jul 17, 2022 at 06:54:00AM +, Sakari Ailus wrote: > Folks, > > > Laurent Pinchart (6): > > dt-bindings: media: Add macros for video interface bus types > > dt-bindings: Use new video interface bus type macros in examples > > ARM: dts: freescale: Use new

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-19 Thread Carlo Caione
On 18/11/2022 16:44, Mark Brown wrote: The problem arrives when your controller does support 16-bits, so your data is not swapped, but you still put the data on the bus with 8-bit transfers. Why would you need to use 8 bit transfers if the controller supports 16 bits? No idea why this driv

Re: [bug report] Merge branch 'for-linux-next' of git://anongit.freedesktop.org/drm/drm-misc

2022-11-19 Thread José Expósito
Hi Dan, On Fri, Nov 18, 2022 at 02:17:34PM +0300, Dan Carpenter wrote: > Hello Stephen Rothwell, > > The patch 23b727d76bda: "Merge branch 'for-linux-next' of > git://anongit.freedesktop.org/drm/drm-misc" from Nov 17, 2022, leads > to the following Smatch static checker warning: > > driver

Re: [PATCH 0/3] drm/fb-helper: Restore damage worker

2022-11-19 Thread Daniel Vetter
On Fri, Nov 18, 2022 at 02:35:32PM +0100, Thomas Zimmermann wrote: > It turns out that the removal of the damage worker can lead to > locking cycles. The display update now runs while holding the > fbdefio lock, which conflicts with locks in the modesetting code > that updates the display. There's

Re: DRM-managed resources / devm_drm_dev_alloc leaking resources

2022-11-19 Thread Daniel Vetter
On Fri, Nov 18, 2022 at 05:15:58PM +0100, Maxime Ripard wrote: > Hi, > > Javier and I looked into it some more today, and I think we have a > better idea of what is going on. > > On Thu, Nov 17, 2022 at 05:53:11PM +0100, Maxime Ripard wrote: > > After trying to get more kunit tests for KMS, I fou

[drm-intel:for-linux-next-gt 1/1] drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr_wait_for_reg_fw(). Prototype was for intel_gt_mcr_wait_for_reg() instead

2022-11-19 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-gt head: 192bb40f030a41ca95c5cff8c9340b725bc7ba8b commit: 192bb40f030a41ca95c5cff8c9340b725bc7ba8b [1/1] drm/i915/gt: Manage uncore->lock while waiting on MCR register config: i386-defconfig compiler: gcc-11 (Debian 11.3.0-8) 11.3.0