[PATCH v1] drm/ttm: Clean up page shift operation

2022-11-21 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. v1 -> v2: fix missing page shift to fpfn and lpfn Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- drivers/gpu/drm/ttm/ttm_range_manager.c| 13

Re: [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start

2022-11-21 Thread Christian König
Am 22.11.22 um 00:42 schrieb Mikhail Gavrilov: On Mon, Nov 14, 2022 at 6:22 PM Christian König wrote: I've found and fixed a few problems around the userptr handling which might explain what you see here. A series of four patches starting with "drm/amdgpu: always register an MMU notifier for

[PATCH v4] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-21 Thread Aravind Iddamsetty
On XE_LPM+ platforms the media engines are carved out into a separate GT but have a common GGTMMADR address range which essentially makes the GGTT address space to be shared between media and render GT. As a result any updates in GGTT shall invalidate TLB of GTs sharing it and similarly any

Re: [PATCH 2/2] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2022-11-21 Thread Arunpravin Paneer Selvam
On 11/22/2022 10:48 AM, Somalapuram, Amaranath wrote: On 11/16/2022 2:50 PM, Arunpravin Paneer Selvam wrote: Hi Amar, On 11/16/2022 2:20 PM, Somalapuram Amaranath wrote: ttm_resource allocate size in bytes i.e less than page size. Signed-off-by: Somalapuram Amaranath ---  

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-21 Thread Dave Airlie
On Tue, 22 Nov 2022 at 09:06, Sonal Santan wrote: > > On 11/19/22 12:44, Oded Gabbay wrote: > > This is the fourth (and hopefully last) version of the patch-set to add the > > new subsystem for compute accelerators. I removed the RFC headline as > > I believe it is now ready for merging. > > > >

Re: [PATCH 2/2] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2022-11-21 Thread Somalapuram, Amaranath
On 11/16/2022 2:50 PM, Arunpravin Paneer Selvam wrote: Hi Amar, On 11/16/2022 2:20 PM, Somalapuram Amaranath wrote: ttm_resource allocate size in bytes i.e less than page size. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/drm_gem.c | 2 +-   1 file changed, 1 insertion(+), 1

[PATCH v2] drm/amdgpu: Fix potential double free and null pointer dereference

2022-11-21 Thread Liang He
In amdgpu_get_xgmi_hive(), we should not call kfree() after kobject_put() as the PUT will call kfree(). In amdgpu_device_ip_init(), we need to check the returned *hive* which can be NULL before we dereference it. Signed-off-by: Liang He --- v1->v2: we need the extra GET to keep *hive* alive,

[PATCH] drm/amdgpu: Fix Double Free, Null Pointer Dereference and MemLeak

2022-11-21 Thread Liang He
In amdgpu_get_xgmi_hive(), we should not call kfree() after kobject_put() as the PUT will call kfree(). Besides, we should not call kobject_get() again for the new *alloced* as its refcount will be initialized to 1 for the returned *hive*. In amdgpu_device_ip_init(), we need to check the returned

Re: [PATCH v1 6/8] drm: rcar-du: Add r8a779g0 support

2022-11-21 Thread Laurent Pinchart
On Thu, Nov 17, 2022 at 03:08:38PM +, Kieran Bingham wrote: > Quoting Tomi Valkeinen (2022-11-17 12:25:45) > > From: Tomi Valkeinen > > > > Add support for DU on r8a779g0, which is identical to DU on r8a779a0. > > > > Signed-off-by: Tomi Valkeinen > > --- > >

Re: [PATCH v1 5/8] arm64: dts: renesas: white-hawk-cpu: Add DP output support

2022-11-21 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Thu, Nov 17, 2022 at 02:25:44PM +0200, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Add DT nodes needed for the mini DP connector. The DP is driven by > sn65dsi86, which in turn gets the pixel data from the SoC via DSI. > > Signed-off-by: Tomi

Re: [PATCH v1 4/8] arm64: dts: renesas: r8a779g0: Add display related data

2022-11-21 Thread Laurent Pinchart
On Thu, Nov 17, 2022 at 03:03:39PM +, Kieran Bingham wrote: > Quoting Tomi Valkeinen (2022-11-17 12:25:43) > > From: Tomi Valkeinen > > > > Add DT nodes for components needed to get the DSI output working: > > - FCPv > > - VSPd > > - DU > > - DSI > > > > Signed-off-by: Tomi Valkeinen > >

Re: [PATCH v1 3/8] clk: renesas: r8a779g0: Add display related clocks

2022-11-21 Thread Laurent Pinchart
On Thu, Nov 17, 2022 at 02:08:57PM +, Kieran Bingham wrote: > Quoting Tomi Valkeinen (2022-11-17 12:25:42) > > From: Tomi Valkeinen > > > > Add clocks related to display which are needed to get the DSI output > > working. > > > > Extracted from Renesas BSP tree. > > > > Signed-off-by: Tomi

Re: [PATCH v1 2/8] dt-bindings: display: bridge: renesas,dsi-csi2-tx: Add r8a779g0

2022-11-21 Thread Laurent Pinchart
On Thu, Nov 17, 2022 at 04:14:21PM +0100, Geert Uytterhoeven wrote: > On Thu, Nov 17, 2022 at 1:26 PM Tomi Valkeinen wrote: > > From: Tomi Valkeinen > > > > Extend the Renesas DSI display bindings to support the r8a779g0 V4H. > > > > Signed-off-by: Tomi Valkeinen > > --- > >

Re: [PATCH v1 1/8] dt-bindings: display: renesas,du: Provide bindings for r8a779g0

2022-11-21 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Thu, Nov 17, 2022 at 02:25:40PM +0200, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Extend the Renesas DU display bindings to support the r8a779g0 V4H. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- >

linux-next: manual merge of the amdgpu tree with the drm tree

2022-11-21 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the amdgpu tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_job.c between commits: 1b2d5eda5ad7 ("drm/amdgpu: move explicit sync check into the CS") 1728baa7e4e6 ("drm/amdgpu: use scheduler dependencies for CS") from the drm tree and commit:

[GIT PULL FOR v6.2] RZ/G2L DSI Kconfig fix

2022-11-21 Thread Laurent Pinchart
Hi Dave, Daniel, The following changes since commit 4e291f2f585313efa5200cce655e17c94906e50a: Merge tag 'drm-misc-next-2022-11-10-1' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2022-11-16 07:17:32 +1000) are available in the Git repository at:

Re: [PATCH] drm: rcar-du: Fix Kconfig dependency between DRM and RZG2L_MIPI_DSI

2022-11-21 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Mon, Nov 21, 2022 at 06:11:21PM +, Biju Das wrote: > When CONFIG_DRM=m and CONFIG_DRM_RZG2L_MIPI_DSI=y, it results in a > build failure. This patch fixes the build issue by adding dependency > to DRM. > > Fixes: 7a043f978ed1 ("drm: rcar-du: Add RZ/G2L

Re: [PATCH 4/6] drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded

2022-11-21 Thread Ceraolo Spurio, Daniele
On 11/21/2022 3:16 PM, Daniele Ceraolo Spurio wrote: If the GSC was loaded, the only way to stop it during the driver unload flow is to do a driver-FLR. The driver-FLR is not the same as PCI config space FLR in that it doesn't reset the SGUnit and doesn't modify the PCI config space. Thus, it

Re: [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start

2022-11-21 Thread Mikhail Gavrilov
On Mon, Nov 14, 2022 at 6:22 PM Christian König wrote: > > I've found and fixed a few problems around the userptr handling which > might explain what you see here. > > A series of four patches starting with "drm/amdgpu: always register an > MMU notifier for userptr" is under review now. > > Going

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix negative value passed as remaining time

2022-11-21 Thread Janusz Krzysztofik
Hi Andrzej, Thanks for providing your R-b. On Monday, 21 November 2022 18:40:51 CET Andrzej Hajda wrote: > On 21.11.2022 15:56, Janusz Krzysztofik wrote: > > Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work > > with GuC") extended the API of

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-21 Thread Janusz Krzysztofik
Hi Andrzej, Thanks for providing your R-b, however, I'd still like to convince you that my approach, which you accepted anyway, is better justified than if we updated 0 timeout with -ETIME immediately after returned by dma_fence_wait_timeout(). On Monday, 21 November 2022 13:12:00 CET Andrzej

[PATCH 6/6] drm/i915/mtl: MTL has one GSC CS on the media GT

2022-11-21 Thread Daniele Ceraolo Spurio
Now that we have the GSC FW support code as a user to the GSC CS, we can add the relevant flag to the engine mask. Note that the engine will still be disabled until we define the GSC FW binary file. Signed-off-by: Daniele Ceraolo Spurio Cc: Matt Roper Cc: Rodrigo Vivi ---

[PATCH 4/6] drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded

2022-11-21 Thread Daniele Ceraolo Spurio
If the GSC was loaded, the only way to stop it during the driver unload flow is to do a driver-FLR. The driver-FLR is not the same as PCI config space FLR in that it doesn't reset the SGUnit and doesn't modify the PCI config space. Thus, it doesn't require a re-enumeration of the PCI BARs.

[PATCH 3/6] drm/i915/gsc: GSC firmware loading

2022-11-21 Thread Daniele Ceraolo Spurio
GSC FW is loaded by submitting a dedicated command via the GSC engine. The memory area used for loading the FW is then re-purposed as local memory for the GSC itself, so we use a separate allocation instead of using the one where we keep the firmware stored for reload. The GSC is not reset as

[PATCH 5/6] drm/i915/gsc: Disable GSC engine and power well if FW is not selected

2022-11-21 Thread Daniele Ceraolo Spurio
From: Jonathan Cavitt The GSC CS is only used for communicating with the GSC FW, so no need to initialize it if we're not going to use the FW. If we're not using neither the engine nor the microcontoller, then we can also disable the power well. IMPORTANT: lack of GSC FW breaks media C6 due to

[PATCH 2/6] drm/i915/gsc: Skip the version check when fetching the GSC FW

2022-11-21 Thread Daniele Ceraolo Spurio
The current exectation from the FW side is that the driver will query the GSC FW version after the FW is loaded, similarly to what the mei driver does on DG2. However, we're discussing with the FW team if there is a way to extract the version from the bin file before loading, so we can keep the

[PATCH 1/6] drm/i915/uc: Introduce GSC FW

2022-11-21 Thread Daniele Ceraolo Spurio
On MTL the GSC FW needs to be loaded on the media GT by the graphics driver. We're going to treat it like a new uc_fw, so add the initial defs and init/fini functions for it. Similarly to the other FWs, the GSC FW path can be overriden via modparam. The modparam can also be used to disable the

[PATCH 0/6] drm/i915: Add support for GSC FW loading

2022-11-21 Thread Daniele Ceraolo Spurio
Starting from MTL, the GSC FW is runtime loaded by the driver, instead of being stored in flash memory. Loading the GSC FW is required to allow the media GT to go into its C6 state and for content protection features (PXP, HDCP). The loading happens via a submission to the GSC engine. All

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-21 Thread Sonal Santan
On 11/19/22 12:44, Oded Gabbay wrote: > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one additional patch that

[PATCH] drm/mediatek: Clean dangling pointer on bind error path

2022-11-21 Thread Nícolas F . R . A . Prado
mtk_drm_bind() can fail, in which case drm_dev_put() is called, destroying the drm_device object. However a pointer to it was still being held in the private object, and that pointer would be passed along to DRM in mtk_drm_sys_prepare() if a suspend were triggered at that point, resulting in a

[PATCH] drm/msm/dpu: Print interrupt index in addition to the mask

2022-11-21 Thread Marijn Suijten
The mask only describes the `irq_idx % 32` part, making it generally impossible to deduce what interrupt is being enabled/disabled. Since `debug/core_irq` in debugfs (and other prints) also include the full `DPU_IRQ_IDX()` value, print the same full value here for easier correlation instead of

[linux-next:master] BUILD REGRESSION e4cd8d3ff7f9efeb97330e5e9b99eeb2a68f5cf9

2022-11-21 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: e4cd8d3ff7f9efeb97330e5e9b99eeb2a68f5cf9 Add linux-next specific files for 20221121 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211130053.np70vidn-...@intel.com https

Re: [PATCH] drm/amdgpu: Partially revert "drm/amdgpu: update drm_display_info correctly when the edid is read"

2022-11-21 Thread Luben Tuikov
Acked-by: Luben Tuikov Regards, Luben On 2022-11-21 12:38, Alex Deucher wrote: > This partially reverts 20543be93ca45968f344261c1a997177e51bd7e1. > > Calling drm_connector_update_edid_property() in > amdgpu_connector_free_edid() causes a noticable pause in > the system every 10 seconds on

Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples

2022-11-21 Thread Sakari Ailus
Hi Laurent, On Sat, Jul 16, 2022 at 06:12:05PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote: > > On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote: > > > Now that a header exists with macros for the media interface

Re: [PATCH v10 18/19] drm/vc4: vec: Add support for more analog TV standards

2022-11-21 Thread Mateusz Kwiatkowski
Hi Mauro, As the author of the original version of this commit, and also a person who argued quite a bit on these descriptions and decisions, let me chip in a bit. W dniu 17.11.2022 o 16:49, Mauro Carvalho Chehab pisze: > On Thu, 17 Nov 2022 10:29:01 +0100 > Maxime Ripard wrote: > >> From:

Re: [PATCH v13,2/3] drm: mediatek: Set dpi format in mmsys

2022-11-21 Thread Matthias Brugger
On 24/10/2022 04:04, xinlei@mediatek.com wrote: From: Xinlei Lee Dpi output needs to adjust the output format to dual edge for MT8186. Co-developed-by: Jitao Shi Signed-off-by: Jitao Shi Signed-off-by: Xinlei Lee Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v4] dma-buf: fix racing conflict of dma_heap_add()

2022-11-21 Thread Christian König
Hi Dawei, from the technical description, coding style etc.. it looks clean to me, but I'm the completely wrong person to ask for a background check. I have a high level understanding of how dma-heaps work, but not a single line of this code is from me. Feel free to add my Acked-by, but

Re: [Intel-gfx] [PATCH v2 0/5] Add module oriented dmesg output

2022-11-21 Thread John Harrison
On 11/18/2022 02:52, Jani Nikula wrote: On Thu, 17 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented

[PATCH] drm: rcar-du: Fix Kconfig dependency between DRM and RZG2L_MIPI_DSI

2022-11-21 Thread Biju Das
When CONFIG_DRM=m and CONFIG_DRM_RZG2L_MIPI_DSI=y, it results in a build failure. This patch fixes the build issue by adding dependency to DRM. Fixes: 7a043f978ed1 ("drm: rcar-du: Add RZ/G2L DSI driver") Reported-by: kernel test robot Signed-off-by: Biju Das --- Ref: *

Re: git send-email friendly smtp provider anyone?

2022-11-21 Thread Noralf Trønnes
Den 21.11.2022 16.19, skrev Maxime Ripard: > On Mon, Nov 21, 2022 at 12:48:52PM +0100, Noralf Trønnes wrote: >> A couple of years ago my email provider blocked me from using git >> send-email with their smtp server. So I switched to the one my ISP >> provides. Now my ISP have outsourced their

Re: [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-21 Thread Vivi, Rodrigo
On Sat, 2022-11-19 at 09:02 +0530, Nilawar, Badal wrote: > > > On 19-11-2022 00:07, Vivi, Rodrigo wrote: > > On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > > > From: Vinay Belgaumkar > > > > > > By defaut idle messaging is disabled for GSC CS so to unblock RC6 > > > entry on media

Re: [PATCH v3] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-21 Thread Vivi, Rodrigo
On Fri, 2022-11-18 at 13:37 -0800, Dixit, Ashutosh wrote: > On Fri, 18 Nov 2022 10:37:37 -0800, Vivi, Rodrigo wrote: > > > > On Sat, 2022-11-19 at 00:03 +0530, Badal Nilawar wrote: > > > From: Vinay Belgaumkar > > > > > > By defaut idle messaging is disabled for GSC CS so to unblock RC6 > > >

Re: git send-email friendly smtp provider anyone?

2022-11-21 Thread Noralf Trønnes
Den 21.11.2022 18.06, skrev Simon Ser: > On Monday, November 21st, 2022 at 18:02, Simon Ser > wrote: > >> On Monday, November 21st, 2022 at 17:52, Noralf Trønnes nor...@tronnes.org >> wrote: >> >>> Den 21.11.2022 14.33, skrev Simon Ser: >>> I think you can apply for a linux.dev mailbox

Re: [PATCH] [next] drm/amdgpu: Replace remaining 1-element array with flex-array

2022-11-21 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 21, 2022 at 2:26 AM Paulo Miguel Almeida wrote: > > One-element arrays are deprecated, and we are replacing them with > flexible array members instead. So, replace one-element array with > flexible-array member in struct GOP_VBIOS_CONTENT and refactor the >

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix negative value passed as remaining time

2022-11-21 Thread Andrzej Hajda
On 21.11.2022 15:56, Janusz Krzysztofik wrote: Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC") extended the API of intel_gt_retire_requests_timeout() with an extra argument 'remaining_timeout', intended for passing back unconsumed portion of requested timeout

[PATCH] drm/amdgpu: Partially revert "drm/amdgpu: update drm_display_info correctly when the edid is read"

2022-11-21 Thread Alex Deucher
This partially reverts 20543be93ca45968f344261c1a997177e51bd7e1. Calling drm_connector_update_edid_property() in amdgpu_connector_free_edid() causes a noticable pause in the system every 10 seconds on polled outputs so revert this part of the change. Bug:

Re: [PATCH] drm/amdgpu: fix unused-function error

2022-11-21 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 21, 2022 at 8:09 AM Ren Zhijie wrote: > > If CONFIG_DRM_AMDGPU=y and CONFIG_DRM_AMD_DC is not set, > gcc complained about unused-function : > > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1705:13: error: > ‘amdgpu_discovery_set_sriov_display’ defined but

Re: git send-email friendly smtp provider anyone?

2022-11-21 Thread Simon Ser
On Monday, November 21st, 2022 at 18:02, Simon Ser wrote: > On Monday, November 21st, 2022 at 17:52, Noralf Trønnes nor...@tronnes.org > wrote: > > > Den 21.11.2022 14.33, skrev Simon Ser: > > > > > I think you can apply for a linux.dev mailbox 1. > > > > Yeah you're right, I didn't know

Re: git send-email friendly smtp provider anyone?

2022-11-21 Thread Simon Ser
On Monday, November 21st, 2022 at 17:52, Noralf Trønnes wrote: > Den 21.11.2022 14.33, skrev Simon Ser: > > > I think you can apply for a linux.dev mailbox 1. > > Yeah you're right, I didn't know about that possibility. > But it depends on whether or not I can just use their smtp server and >

Re: git send-email friendly smtp provider anyone?

2022-11-21 Thread Noralf Trønnes
Den 21.11.2022 14.33, skrev Simon Ser: > I think you can apply for a linux.dev mailbox [1]. > Yeah you're right, I didn't know about that possibility. But it depends on whether or not I can just use their smtp server and keep my current email address. This looks like what's the problem with

Re: [PATCH v2 3/3] drm/gem-shmem: When drm_gem_object_init failed, should release object

2022-11-21 Thread Thomas Zimmermann
Hi Am 19.11.22 um 07:41 schrieb ChunyouTang: when goto err_free, the object had init, so it should be release when fail. Signed-off-by: ChunyouTang Thanks a lot. I merged the patch into drm-misc-next. Best regards Thomas --- drivers/gpu/drm/drm_gem.c | 19

Re: [PATCH] drm: Fix potential null-ptr-deref due to drmm_mode_config_init()

2022-11-21 Thread Thomas Zimmermann
Hi, merged into drm-misc-next. Thanks a lot. Best regards Thomas Am 18.11.22 um 03:16 schrieb Shang XiaoJing: drmm_mode_config_init() will call drm_mode_create_standard_properties() and won't check the ret value. When drm_mode_create_standard_properties() failed due to alloc, property will be

[Bug 216716] [drm:psp_resume [amdgpu]] *ERROR* PSP resume failed on r9 7950x igpu

2022-11-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216716 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH resend] drm/armada: Fix off-by-one error in armada_overlay_get_property()

2022-11-21 Thread Russell King (Oracle)
On Mon, Nov 21, 2022 at 04:43:14PM +0100, Geert Uytterhoeven wrote: > As ffs() returns one more than the index of the first bit set (zero > means no bits set), the color key mode value is shifted one position too > much. > > Fix this by using FIELD_GET() instead. Reviewed-by: Russell King

[PATCH resend] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC

2022-11-21 Thread Geert Uytterhoeven
The Freescale/NXP i.MX LCDIFv3 LCD controller is only present on Freescale/NXP i.MX SoCs. Hence add a dependency on ARCH_MXC, to prevent asking the user about this driver when configuring a kernel without Freescale/NXP i.MX support. Fixes: 9db35bb349a0ef32 ("drm: lcdif: Add support for i.MX8MP

[PATCH resend] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC

2022-11-21 Thread Geert Uytterhoeven
Freescale/NXP i.MX LCDIF and eLCDIF LCD controllers are only present on Freescale/NXP i.MX SoCs. Hence add a dependency on ARCH_MXS || ARCH_MXC, to prevent asking the user about this driver when configuring a kernel without Freescale/NXP i.MX support. Fixes: 45d59d704080cc0c ("drm: Add new

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-21 Thread Alex Deucher
On Mon, Nov 21, 2022 at 10:57 AM Alex Deucher wrote: > > On Sat, Nov 19, 2022 at 3:44 PM Oded Gabbay wrote: > > > > This is the fourth (and hopefully last) version of the patch-set to add the > > new subsystem for compute accelerators. I removed the RFC headline as > > I believe it is now ready

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-21 Thread Alex Deucher
On Sat, Nov 19, 2022 at 3:44 PM Oded Gabbay wrote: > > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one

[PATCH resend] drm/armada: Fix off-by-one error in armada_overlay_get_property()

2022-11-21 Thread Geert Uytterhoeven
As ffs() returns one more than the index of the first bit set (zero means no bits set), the color key mode value is shifted one position too much. Fix this by using FIELD_GET() instead. Fixes: c96103b6c49ff9a8 ("drm/armada: move colorkey properties into overlay plane state") Signed-off-by:

Re: [PATCH v4] dma-buf: fix racing conflict of dma_heap_add()

2022-11-21 Thread Dawei Li
On Sat, Nov 05, 2022 at 12:05:36AM +0800, Dawei Li wrote: Hi Christian, May I have your opinion on this change? Thanks, Dawei > Racing conflict could be: > task A task B > list_for_each_entry > strcmp(h->name)) >list_for_each_entry >

Re: [PATCH v4 4/4] doc: add documentation for accel subsystem

2022-11-21 Thread Jeffrey Hugo
On 11/21/2022 8:18 AM, Oded Gabbay wrote: On Mon, Nov 21, 2022 at 12:02 AM Jeffrey Hugo wrote: On 11/19/2022 1:44 PM, Oded Gabbay wrote: Add an introduction section for the accel subsystem. Most of the relevant data is in the DRM documentation, so the introduction only presents the why of

Re: [PATCH 0/8] drm/mipi-dbi: Convert to shadow-plane helpers

2022-11-21 Thread Javier Martinez Canillas
On 11/21/22 13:27, Noralf Trønnes wrote: > > > Den 21.11.2022 11.45, skrev Thomas Zimmermann: >> Convert the MIPI-DBI-based drivers to shadow-plane helpers. The >> drivers vmap/vunmap GEM buffer memory during the atomic commit. >> Shadow-plane helpers automate this process. >> >> Patches 1 to 4

Re: git send-email friendly smtp provider anyone?

2022-11-21 Thread Maxime Ripard
On Mon, Nov 21, 2022 at 12:48:52PM +0100, Noralf Trønnes wrote: > A couple of years ago my email provider blocked me from using git > send-email with their smtp server. So I switched to the one my ISP > provides. Now my ISP have outsourced their email service so the first 3 > emails gets through

Re: [PATCH v4 4/4] doc: add documentation for accel subsystem

2022-11-21 Thread Oded Gabbay
On Mon, Nov 21, 2022 at 12:02 AM Jeffrey Hugo wrote: > > On 11/19/2022 1:44 PM, Oded Gabbay wrote: > > Add an introduction section for the accel subsystem. Most of the > > relevant data is in the DRM documentation, so the introduction only > > presents the why of the new subsystem, how are the

Re: [PATCH 0/8] drm/mipi-dbi: Convert to shadow-plane helpers

2022-11-21 Thread Noralf Trønnes
Den 21.11.2022 13.41, skrev Thomas Zimmermann: > Hi > > Am 21.11.22 um 13:27 schrieb Noralf Trønnes: >> >> >> Den 21.11.2022 11.45, skrev Thomas Zimmermann: >>> Convert the MIPI-DBI-based drivers to shadow-plane helpers. The >>> drivers vmap/vunmap GEM buffer memory during the atomic commit.

Re: [PATCH v4 2/4] accel: add dedicated minor for accelerator devices

2022-11-21 Thread Oded Gabbay
On Sun, Nov 20, 2022 at 11:47 PM Jeffrey Hugo wrote: > > On 11/19/2022 1:44 PM, Oded Gabbay wrote: > > diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c > > index fac6ad6ac28e..703d40c4ff45 100644 > > --- a/drivers/accel/drm_accel.c > > +++ b/drivers/accel/drm_accel.c > > @@

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-21 Thread Oded Gabbay
On Mon, Nov 21, 2022 at 8:26 AM Dave Airlie wrote: > > On Sun, 20 Nov 2022 at 06:44, Oded Gabbay wrote: > > > > This is the fourth (and hopefully last) version of the patch-set to add the > > new subsystem for compute accelerators. I removed the RFC headline as > > I believe it is now ready for

Re: [PATCH v4 0/4] new subsystem for compute accelerator devices

2022-11-21 Thread Thomas Zimmermann
Acked-by: Thomas Zimmermann Am 19.11.22 um 21:44 schrieb Oded Gabbay: This is the fourth (and hopefully last) version of the patch-set to add the new subsystem for compute accelerators. I removed the RFC headline as I believe it is now ready for merging. Compare to v3, this patch-set

[PATCH v3 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-21 Thread Janusz Krzysztofik
Users of intel_gt_retire_requests_timeout() expect 0 return value on success. However, we have no protection from passing back 0 potentially returned by a call to dma_fence_wait_timeout() when it succedes right after its timeout has expired. Replace 0 with -ETIME before potentially using the

[PATCH v3 0/2] drm/i915: Fix timeout handling when retiring requests

2022-11-21 Thread Janusz Krzysztofik
Fixes for issues discovered via code review while working on https://gitlab.freedesktop.org/drm/intel/issues/7349. v3: PATCH 1: don't fail on any error passed back via remaining_timeout, PATCH 2: use conditional expression, more compact but also better reflecting intention standing

[PATCH v3 1/2] drm/i915: Fix negative value passed as remaining time

2022-11-21 Thread Janusz Krzysztofik
Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC") extended the API of intel_gt_retire_requests_timeout() with an extra argument 'remaining_timeout', intended for passing back unconsumed portion of requested timeout when 0 (success) is returned. However, when

Re: [PATCH v10 00/19] drm: Analog TV Improvements

2022-11-21 Thread Daniel Vetter
On Thu, Nov 17, 2022 at 10:28:43AM +0100, Maxime Ripard wrote: > Hi, > > Here's a series aiming at improving the command line named modes support, > and more importantly how we deal with all the analog TV variants. > > The named modes support were initially introduced to allow to specify the >

[PATCH] drm/logicvc: Drop obsolete dependency on COMPILE_TEST

2022-11-21 Thread Jean Delvare
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. It is actually better to always build such

[PATCH] i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer

2022-11-21 Thread Wang Yufen
Fix to return a negative error code from the gi2c->err instead of 0. Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA") Signed-off-by: Wang Yufen --- drivers/i2c/busses/i2c-qcom-geni.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c

[PATCH v2 2/2] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-21 Thread Carlo Caione
The pixel data for the ILI9486 is always 16-bits wide and it must be sent over the SPI bus. When the controller is only able to deal with 8-bit transfers, this 16-bits data needs to be swapped before the sending to account for the big endian bus, this is on the contrary not needed when the SPI

[PATCH v2 0/2] Make ILI9486 driver working with 16-bits SPI controllers

2022-11-21 Thread Carlo Caione
This patchset is trying to fix problems seen on S905X boards when interfacing with an ILI9486 equipped SPI panel. To: Kamlesh Gurudasani To: David Airlie To: Daniel Vetter To: Mark Brown To: Neil Armstrong To: Kevin Hilman To: Jerome Brunet To: Martin Blumenstingl Cc:

[PATCH v2 1/2] drm/tiny: rpi-lcd-35: Enable driver module autoloading

2022-11-21 Thread Carlo Caione
SPI devices use the spi_device_id for module autoloading even on systems using device tree. Add the spi_device_id entry to enable autoloading for the 3.5inch RPi Display (rpi-lcd-35). Signed-off-by: Carlo Caione --- drivers/gpu/drm/tiny/ili9486.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] gpu: vgpu: delete a semicolon

2022-11-21 Thread Li kunyu
Remove extra semicolons at the end of statements to make them look cleaner. Signed-off-by: Li kunyu --- drivers/gpu/drm/i915/gvt/vgpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c index

Re: git send-email friendly smtp provider anyone?

2022-11-21 Thread Simon Ser
I think you can apply for a linux.dev mailbox [1]. [1]: https://korg.docs.kernel.org/linuxdev.html

[PATCH] drm/amdgpu: fix unused-function error

2022-11-21 Thread Ren Zhijie
If CONFIG_DRM_AMDGPU=y and CONFIG_DRM_AMD_DC is not set, gcc complained about unused-function : drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1705:13: error: ‘amdgpu_discovery_set_sriov_display’ defined but not used [-Werror=unused-function] static void

Re: [PATCH v3] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-21 Thread Iddamsetty, Aravind
On 19-11-2022 04:22, Matt Roper wrote: > On Tue, Nov 15, 2022 at 08:34:54PM +0530, Aravind Iddamsetty wrote: >> On XE_LPM+ platforms the media engines are carved out into a separate >> GT but have a common GGTMMADR address range which essentially makes >> the GGTT address space to be shared

Re: [PATCH 0/8] drm/mipi-dbi: Convert to shadow-plane helpers

2022-11-21 Thread Thomas Zimmermann
Hi Am 21.11.22 um 13:27 schrieb Noralf Trønnes: Den 21.11.2022 11.45, skrev Thomas Zimmermann: Convert the MIPI-DBI-based drivers to shadow-plane helpers. The drivers vmap/vunmap GEM buffer memory during the atomic commit. Shadow-plane helpers automate this process. Patches 1 to 4 prepare

Re: [PATCH 0/8] drm/mipi-dbi: Convert to shadow-plane helpers

2022-11-21 Thread Noralf Trønnes
Den 21.11.2022 11.45, skrev Thomas Zimmermann: > Convert the MIPI-DBI-based drivers to shadow-plane helpers. The > drivers vmap/vunmap GEM buffer memory during the atomic commit. > Shadow-plane helpers automate this process. > > Patches 1 to 4 prepare the MIPI code for the change and simplify

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-21 Thread Andrzej Hajda
On 21.11.2022 11:59, Janusz Krzysztofik wrote: On Monday, 21 November 2022 11:51:15 CET Janusz Krzysztofik wrote: Hi Andrzej, Thanks for your comment. On Monday, 21 November 2022 11:17:42 CET Andrzej Hajda wrote: On 21.11.2022 09:30, Janusz Krzysztofik wrote: Hi Nimroy, Thanks for looking

Re: [PATCH] i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer

2022-11-21 Thread Tommaso Merciai
Hi Wang, On Mon, Nov 21, 2022 at 06:17:52PM +0800, Wang Yufen wrote: > Fix to return a negative error code from the gi2c->err instead of > 0. > > Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA") > Signed-off-by: Wang Yufen > --- > drivers/i2c/busses/i2c-qcom-geni.c | 1 - > 1

Re: [PATCH 3/5] kobject: kset_uevent_ops: make filter() callback take a const *

2022-11-21 Thread Rafael J. Wysocki
On Mon, Nov 21, 2022 at 10:47 AM Greg Kroah-Hartman wrote: > > The filter() callback in struct kset_uevent_ops does not modify the > kobject passed into it, so make the pointer const to enforce this > restriction. When doing so, fix up all existing filter() callbacks to > have the correct

git send-email friendly smtp provider anyone?

2022-11-21 Thread Noralf Trønnes
Hi A couple of years ago my email provider blocked me from using git send-email with their smtp server. So I switched to the one my ISP provides. Now my ISP have outsourced their email service so the first 3 emails gets through and the rest looks like it ends up in a tar pit or something, 18

[PATCH] drm/i915/selftests: Fix error return code in live_parallel_switch()

2022-11-21 Thread Ziyang Xuan
In live_parallel_switch(), excute intel_context_create() failed, the error code should be set before return from error handling path. Fixes: 50d16d44cce4 ("drm/i915/selftests: Exercise context switching in parallel") Signed-off-by: Ziyang Xuan ---

Re: [PATCH] drm/vc4: Fix NULL pointer access in vc4_platform_drm_probe()

2022-11-21 Thread Dave Stevenson
Hi Lino On Sun, 20 Nov 2022 at 15:26, Lino Sanfilippo wrote: > > From: Lino Sanfilippo > > In vc4_platform_drm_probe() function vc4_match_add_drivers() is called to > find component matches for the component drivers. If no such match is found > the passed variable "match" is still NULL after

Re: [PATCH 593/606] backlight: tosa: Convert to i2c's .probe_new()

2022-11-21 Thread Daniel Thompson
On Fri, Nov 18, 2022 at 11:45:27PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 592/606] backlight: lv5207lp: Convert to i2c's .probe_new()

2022-11-21 Thread Daniel Thompson
On Fri, Nov 18, 2022 at 11:45:26PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 591/606] backlight: lp855x: Convert to i2c's .probe_new()

2022-11-21 Thread Daniel Thompson
On Fri, Nov 18, 2022 at 11:45:25PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 590/606] backlight: lm3639: Convert to i2c's .probe_new()

2022-11-21 Thread Daniel Thompson
On Fri, Nov 18, 2022 at 11:45:24PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH AUTOSEL 6.0 38/44] drm/amdgpu: Unlock bo_list_mutex after error handling

2022-11-21 Thread Christian König
Am 21.11.22 um 10:57 schrieb Michel Dänzer: On 11/19/22 03:11, Sasha Levin wrote: From: Philip Yang [ Upstream commit 64f65135c41a75f933d3bca236417ad8e9eb75de ] Get below kernel WARNING backtrace when pressing ctrl-C to kill kfdtest application. If amdgpu_cs_parser_bos returns error after

Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types

2022-11-21 Thread Laurent Pinchart
Hi Sakari, On Mon, Nov 21, 2022 at 10:54:01AM +, Sakari Ailus wrote: > On Sat, Nov 19, 2022 at 09:15:04PM +0200, Laurent Pinchart wrote: > > On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote: > > > On Sun, Jul 17, 2022 at 06:54:00AM +, Sakari Ailus wrote: > > > > Folks, > > > >

Re: [PATCH 589/606] backlight: lm3630a: Convert to i2c's .probe_new()

2022-11-21 Thread Daniel Thompson
On Fri, Nov 18, 2022 at 11:45:23PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 588/606] backlight: bd6107: Convert to i2c's .probe_new()

2022-11-21 Thread Daniel Thompson
On Fri, Nov 18, 2022 at 11:45:22PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH v2 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-21 Thread Janusz Krzysztofik
On Monday, 21 November 2022 11:51:15 CET Janusz Krzysztofik wrote: > Hi Andrzej, > > Thanks for your comment. > > On Monday, 21 November 2022 11:17:42 CET Andrzej Hajda wrote: > > > > On 21.11.2022 09:30, Janusz Krzysztofik wrote: > > > Hi Nimroy, > > > > > > Thanks for looking at this. > > > >

Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types

2022-11-21 Thread Sakari Ailus
Hi Laurent, On Sat, Nov 19, 2022 at 09:15:04PM +0200, Laurent Pinchart wrote: > Hello, > > On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote: > > Hi Sakari, > > > > Gentle ping. > > > > On Sun, Jul 17, 2022 at 06:54:00AM +, Sakari Ailus wrote: > > > Folks, > > > > > > > Laurent

Re: [PATCH v2 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-21 Thread Janusz Krzysztofik
Hi Andrzej, Thanks for your comment. On Monday, 21 November 2022 11:17:42 CET Andrzej Hajda wrote: > > On 21.11.2022 09:30, Janusz Krzysztofik wrote: > > Hi Nimroy, > > > > Thanks for looking at this. > > > > On Friday, 18 November 2022 20:56:50 CET Das, Nirmoy wrote: > >> On 11/18/2022 11:42

  1   2   >