[PATCH 6/8] drm/mipi-dbi: Support shadow-plane state

2022-11-21 Thread Thomas Zimmermann
Introduce struct drm_mipi_dbi_plane_state that contains state related to MIPI DBI. It currently only inherits from struct drm_shadow_plane_state, so that MIPI DBI drivers can use the vmap'ed GEM-buffer memory. Implement state helpers, the {begin,end}_fb_access helpers and wire up everything. With

[PATCH 3/8] drm/st7586: Call MIPI DBI mode_valid helper

2022-11-21 Thread Thomas Zimmermann
MIPI DBI drivers validate each mode against their native resolution. Add this test to st7586. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/st7586.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tiny/st7586.c b/drivers/gpu/drm/tiny/st7586.c index

[PATCH 2/8] drm/ili9225: Call MIPI DBI mode_valid helper

2022-11-21 Thread Thomas Zimmermann
MIPI DBI drivers validate each mode against their native resolution. Add this test to ili9225. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/ili9225.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tiny/ili9225.c b/drivers/gpu/drm/tiny/ili9225.c index

[PATCH 8/8] drm/mipi-dbi: Move drm_dev_{enter, exit}() out from fb_dirty functions

2022-11-21 Thread Thomas Zimmermann
Call drm_dev_enter() and drm_dev_exit() in the outer-most callbacks of the modesetting pipeline. If drm_dev_enter() fails, the driver can thus avoid unnecessary work. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_mipi_dbi.c | 13 +++-- drivers/gpu/drm/tiny/ili9225.c | 13

[PATCH 7/8] drm/mipi-dbi: Use shadow-plane mappings

2022-11-21 Thread Thomas Zimmermann
Use the buffer mappings provided by shadow-plane helpers. As the mappings are established while the commit can still fail, errors are now reported correctly to callers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_mipi_dbi.c | 31 +++

[PATCH 1/8] drm/simple-kms: Remove drm_gem_simple_display_pipe_prepare_fb()

2022-11-21 Thread Thomas Zimmermann
The helper drm_gem_simple_display_pipe_prepare_fb() is simple-KMS' default implementation for prepare_fb. Remove the call from drivers that set it explicitly. Then inline the helper into the only caller within simple-kms helpers and remove . No functional changes. Simple-KMS drivers that

[PATCH 5/8] drm/mipi-dbi: Prepare framebuffer copy operation in pipe-update helpers

2022-11-21 Thread Thomas Zimmermann
Move the vmap/vunmap blocks from the inner fb_dirty helpers into the MIPI DBI update helpers. The function calls can result in waiting and/or processing overhead. Reduce the penalties by executing the functions once in the outer-most function of the pipe update. This change also prepares for MIPI

[PATCH 4/8] drm/mipi-dbi: Initialize default driver functions with macro

2022-11-21 Thread Thomas Zimmermann
Introduce DRM_MIPI_DBI_SIMPLE_DISPLAY_PIPE_FUNCS to initialize MIPI-DBI helpers to default values and convert drivers. The prepare_fb function set by some drivers is called implicitly by simple-kms helpers, so leave it out. Signed-off-by: Thomas Zimmermann ---

[PATCH 0/8] drm/mipi-dbi: Convert to shadow-plane helpers

2022-11-21 Thread Thomas Zimmermann
Convert the MIPI-DBI-based drivers to shadow-plane helpers. The drivers vmap/vunmap GEM buffer memory during the atomic commit. Shadow-plane helpers automate this process. Patches 1 to 4 prepare the MIPI code for the change and simplify the restof the patchset. Patches 5 to 7 rework the vmap

Re: [PATCH 587/606] backlight: arcxcnn: Convert to i2c's .probe_new()

2022-11-21 Thread Daniel Thompson
On Fri, Nov 18, 2022 at 11:45:21PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Daniel Thompson Daniel.

Re: The state of Quantization Range handling

2022-11-21 Thread Pekka Paalanen
On Fri, 18 Nov 2022 15:53:29 + Dave Stevenson wrote: > Hi Pekka > > On Fri, 18 Nov 2022 at 10:15, Pekka Paalanen wrote: > > > > On Thu, 17 Nov 2022 22:13:26 +0100 > > Sebastian Wick wrote: > > > > > Hi Dave, > > > > > > I noticed that I didn't get the Broadcast RGB property thanks to

Re: [PATCH v2 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-21 Thread Andrzej Hajda
On 21.11.2022 09:30, Janusz Krzysztofik wrote: Hi Nimroy, Thanks for looking at this. On Friday, 18 November 2022 20:56:50 CET Das, Nirmoy wrote: On 11/18/2022 11:42 AM, Janusz Krzysztofik wrote: Users of intel_gt_retire_requests_timeout() expect 0 return value on success. However, we

Re: [PATCH 586/606] backlight: adp8870: Convert to i2c's .probe_new()

2022-11-21 Thread Daniel Thompson
On Fri, Nov 18, 2022 at 11:45:20PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 585/606] backlight: adp8860: Convert to i2c's .probe_new()

2022-11-21 Thread Daniel Thompson
On Fri, Nov 18, 2022 at 11:45:19PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Daniel Thompson Daniel.

Re: DRM-managed resources / devm_drm_dev_alloc leaking resources

2022-11-21 Thread Stanislaw Gruszka
Hi On Sat, Nov 19, 2022 at 12:14:14PM +0100, Daniel Vetter wrote: > On Fri, Nov 18, 2022 at 05:15:58PM +0100, Maxime Ripard wrote: > > Hi, > > > > Javier and I looked into it some more today, and I think we have a > > better idea of what is going on. > > > > On Thu, Nov 17, 2022 at 05:53:11PM

RE: [PATCH 585/606] backlight: adp8860: Convert to i2c's .probe_new()

2022-11-21 Thread Hennerich, Michael
> -Original Message- > From: Uwe Kleine-König > Sent: Freitag, 18. November 2022 23:45 > To: Angel Iglesias ; Lee Jones > ; Grant Likely ; Wolfram > Sang ; Hennerich, Michael > ; Lee Jones ; Daniel > Thompson ; Jingoo Han > ; Helge Deller > Cc: linux-...@vger.kernel.org;

Re: [PATCH AUTOSEL 6.0 38/44] drm/amdgpu: Unlock bo_list_mutex after error handling

2022-11-21 Thread Michel Dänzer
On 11/19/22 03:11, Sasha Levin wrote: > From: Philip Yang > > [ Upstream commit 64f65135c41a75f933d3bca236417ad8e9eb75de ] > > Get below kernel WARNING backtrace when pressing ctrl-C to kill kfdtest > application. > > If amdgpu_cs_parser_bos returns error after taking bo_list_mutex, as >

Re: [Linaro-mm-sig] [PATCH 3/5] kobject: kset_uevent_ops: make filter() callback take a const *

2022-11-21 Thread Christian König
Am 21.11.22 um 10:46 schrieb Greg Kroah-Hartman: The filter() callback in struct kset_uevent_ops does not modify the kobject passed into it, so make the pointer const to enforce this restriction. When doing so, fix up all existing filter() callbacks to have the correct signature to preserve the

[PATCH 3/5] kobject: kset_uevent_ops: make filter() callback take a const *

2022-11-21 Thread Greg Kroah-Hartman
The filter() callback in struct kset_uevent_ops does not modify the kobject passed into it, so make the pointer const to enforce this restriction. When doing so, fix up all existing filter() callbacks to have the correct signature to preserve the build. Cc: "Rafael J. Wysocki" Cc: Sumit Semwal

[PATCH v4 1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-21 Thread Kalyan Thota
Pin each crtc with one encoder. This arrangement will disallow crtc switching between encoders and also will facilitate to advertise certain features on crtc based on encoder type. Changes in v1: - use drm_for_each_encoder macro while iterating through encoder list (Dmitry) Changes in v2: -

[PATCH v4 3/3] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-21 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalog. Changes in v1: - cache color enabled state in the dpu crtc obj (Dmitry) - simplify dspp allocation while creating crtc (Dmitry) - register for color when crtc is created (Dmitry)

[PATCH v4 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin

2022-11-21 Thread Kalyan Thota
Since DRM encoder type for few encoders can be similar (like eDP and DP), get the connector type for a given encoder to differentiate between builtin and pluggable displays. Changes in v1: - add connector type in the disp_info (Dmitry) - add helper functions to know encoder type - update commit

[PATCH v4 0/3] add color management support for the crtc

2022-11-21 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalog Kalyan Thota (3): drm/msm/disp/dpu1: pin 1 crtc to 1 encoder drm/msm/disp/dpu1: add helper to know if display is builtin drm/msm/disp/dpu1: add color management support for the

Re: [Intel-gfx] [PATCH] drm/i915: Fix workarounds on Gen2-3

2022-11-21 Thread Tvrtko Ursulin
On 18/11/2022 17:14, Matt Roper wrote: On Fri, Nov 18, 2022 at 11:52:49AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In 3653727560d0 ("drm/i915: Simplify internal helper function signature") I broke the old platforms by not noticing engine workaround init does not initialize the list

Re: [PATCH v2 1/2] drm/i915: Fix negative value passed as remaining time

2022-11-21 Thread Janusz Krzysztofik
On Friday, 18 November 2022 11:42:21 CET Janusz Krzysztofik wrote: > Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work > with GuC") extended the API of intel_gt_retire_requests_timeout() with an > extra argument 'remaining_timeout', intended for passing back unconsumed >

Re: [PATCH v4 00/10] Initial support for Cadence MHDP(HDMI/DP) for i.MX8MQ

2022-11-21 Thread Alexander Stein
Hello Sandor, thanks for the updated series. Am Montag, 21. November 2022, 08:23:50 CET schrieb Sandor Yu: > The patch set initial support for Cadence MHDP(HDMI/DP) DRM bridge > drivers and Cadence HDP-TX PHY(HDMI/DP) drivers for iMX8MQ. > > The patch set compose of DRM bridge drivers and PHY

Re: [PATCH v2 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-21 Thread Janusz Krzysztofik
Hi Nimroy, Thanks for looking at this. On Friday, 18 November 2022 20:56:50 CET Das, Nirmoy wrote: > > On 11/18/2022 11:42 AM, Janusz Krzysztofik wrote: > > Users of intel_gt_retire_requests_timeout() expect 0 return value on > > success. However, we have no protection from passing back 0

<    1   2