[PATCH] drm/msm/hdm: Fix the error handling path of msm_hdmi_dev_probe()

2022-12-10 Thread Christophe JAILLET
If an error occurs after a successful msm_hdmi_get_phy() call, it must be undone by a corresponding msm_hdmi_put_phy(), as already done in the remove function. Fixes: 437365464043 ("drm/msm/hdmi: move msm_hdmi_get_phy() to msm_hdmi_dev_probe()") Signed-off-by: Christophe JAILLET --- Not sure if

Re: Screen corruption using radeon kernel driver

2022-12-10 Thread Luben Tuikov
On 2022-12-10 10:32, Mikhail Krylov wrote: > On Wed, Nov 30, 2022 at 11:07:32AM -0500, Alex Deucher wrote: >> On Wed, Nov 30, 2022 at 10:42 AM Robin Murphy wrote: >>> >>> On 2022-11-30 14:28, Alex Deucher wrote: On Wed, Nov 30, 2022 at 7:54 AM Robin Murphy wrote: > > On 2022-11-29

Re: [PATCH v9 00/18] drm: bridge: Add Samsung MIPI DSIM bridge

2022-12-10 Thread Jagan Teki
On Sun, Dec 11, 2022 at 7:58 AM Marek Vasut wrote: > > On 12/9/22 16:23, Jagan Teki wrote: > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > > > > The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. > > I wonder

Re: [PATCH v9 07/18] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices

2022-12-10 Thread Jagan Teki
On Sun, Dec 11, 2022 at 7:58 AM Marek Vasut wrote: > > On 12/9/22 16:23, Jagan Teki wrote: > > The child devices in MIPI DSI can be binding with OF-graph > > and also via child nodes. > > > > The OF-graph interface represents the child devices via > > remote and associated endpoint numbers like >

[PATCH] Documentation: gpu: vc4: add blank line separator before KUnit code block

2022-12-10 Thread Bagas Sanjaya
kernel test robot reports htmldocs warning: Documentation/gpu/vc4.rst:65: WARNING: Unexpected indentation. The warning is due to missing blank line separator between KUnit mock driver sentence and its code block. Add the separator to fix the warning. Link:

Re: [PATCH v9 08/18] drm: bridge: samsung-dsim: Mark PHY as optional

2022-12-10 Thread Marek Vasut
On 12/9/22 16:23, Jagan Teki wrote: In i.MX8M Mini/Nano SoC the DSI Phy requires a MIPI DPHY bit 8M Plus too. to reset in order to activate the PHY and that can be done via upstream i.MX8M blk-ctrl driver. So, mark the phy get as optional. v9, v8, v7, v6, v5, v4, v3, v2: * none v1: * new

Re: [PATCH v9 00/18] drm: bridge: Add Samsung MIPI DSIM bridge

2022-12-10 Thread Marek Vasut
On 12/9/22 16:23, Jagan Teki wrote: This series supports common bridge support for Samsung MIPI DSIM which is used in Exynos and i.MX8MM SoC's. The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. I wonder if it would rather make sense to split the series up and submit all

Re: [PATCH v9 05/18] drm: exynos: dsi: Properly name HSA/HBP/HFP/HSE bits

2022-12-10 Thread Marek Vasut
On 12/9/22 16:23, Jagan Teki wrote: HSA/HBP/HFP/HSE mode bits in Processor Reference Manuals specify a naming conversion as 'disable mode bit' due to its bit definition, 0 = Enable and 1 = Disable. For HSE bit, the i.MX 8M Mini/Nano/Plus Applications Processor Reference Manual named this bit as

Re: [PATCH v9 07/18] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices

2022-12-10 Thread Marek Vasut
On 12/9/22 16:23, Jagan Teki wrote: The child devices in MIPI DSI can be binding with OF-graph and also via child nodes. The OF-graph interface represents the child devices via remote and associated endpoint numbers like dsi { compatible = "fsl,imx8mm-mipi-dsim"; ports {

Re: [PATCH v9 04/18] drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags

2022-12-10 Thread Marek Vasut
On 12/9/22 16:23, Jagan Teki wrote: HFP/HBP/HSA/EOT_PACKET modes in Exynos DSI host specifies 0 = Enable and 1 = Disable. The logic for checking these mode flags was correct before the MIPI_DSI*_NO_* mode flag conversion. Fix the MIPI_DSI*_NO_* mode flags handling. Fixes: <0f3b68b66a6d>

Re: [PATCH v9 03/18] drm: exynos: dsi: Restore proper bridge chain order

2022-12-10 Thread Marek Vasut
On 12/9/22 16:23, Jagan Teki wrote: From: Marek Szyprowski Restore the proper bridge chain by finding the previous bridge in the chain instead of passing NULL. This establishes a proper bridge chain while attaching downstream bridges. v9, v4: * none v3: * new patch Signed-off-by: Marek

Re: [PATCH 1/9] drm/amdgpu: generally allow over-commit during BO allocation

2022-12-10 Thread Felix Kuehling
Am 2022-12-10 um 09:12 schrieb Christian König: Am 10.12.22 um 07:15 schrieb Felix Kuehling: On 2022-11-25 05:21, Christian König wrote: We already fallback to a dummy BO with no backing store when we allocate GDS,GWS and OA resources and to GTT when we allocate VRAM. Drop all those

Re: [PATCH v2 00/11] pwm: Allow .get_state to fail

2022-12-10 Thread Uwe Kleine-König
Hello Andy, On Sat, Dec 10, 2022 at 10:57:16PM +0200, Andy Shevchenko wrote: > On Sat, Dec 10, 2022 at 10:18:33AM +0100, Uwe Kleine-König wrote: > > On Fri, Dec 09, 2022 at 11:47:54PM +0200, Andy Shevchenko wrote: > > > On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-König wrote: > > ... >

Re: [PATCH v2 00/11] pwm: Allow .get_state to fail

2022-12-10 Thread Andy Shevchenko
On Sat, Dec 10, 2022 at 10:18:33AM +0100, Uwe Kleine-König wrote: > On Fri, Dec 09, 2022 at 11:47:54PM +0200, Andy Shevchenko wrote: > > On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-König wrote: ... > > I'm wondering why we didn't see a compiler warning about mistyped function > >

Re: [PATCH] fbdev: make offb driver tristate

2022-12-10 Thread Helge Deller
On 11/26/22 14:40, Thomas Zimmermann wrote: Am 26.11.22 um 01:04 schrieb Randy Dunlap: Make the offb (Open Firmware frame buffer) driver tristate, i.e., so that it can be built as a loadable module. However, it still depends on the setting of DRM_OFDRM so that both of these drivers cannot be

Re: [PATCH] fbdev: fbcon: release buffer when fbcon_do_set_font() failed

2022-12-10 Thread Helge Deller
On 12/5/22 23:10, Tetsuo Handa wrote: syzbot is reporting memory leak at fbcon_do_set_font() [1], for commit a5a923038d70 ("fbdev: fbcon: Properly revert changes when vc_resize() failed") missed that the buffer might be newly allocated by fbcon_set_font(). Link:

Re: [PATCH linux-next v3] fbdev: use sysfs_emit() to instead of scnprintf()

2022-12-10 Thread Helge Deller
On 12/5/22 09:31, ye.xingc...@zte.com.cn wrote: From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen I've applied this

Re: [PATCH v2 1/2] video: fbdev: uvesafb: Fixes an error handling path in uvesafb_probe()

2022-12-10 Thread Helge Deller
On 12/10/22 12:35, Christophe JAILLET wrote: If an error occurs after a successful uvesafb_init_mtrr() call, it must be undone by a corresponding arch_phys_wc_del() call, as already done in the remove function. This has been added in the remove function in commit 63e28a7a5ffc ("uvesafb: Clean

Re: [PATCH 1/9] drm/amdgpu: generally allow over-commit during BO allocation

2022-12-10 Thread Christian König
Am 10.12.22 um 07:15 schrieb Felix Kuehling: On 2022-11-25 05:21, Christian König wrote: We already fallback to a dummy BO with no backing store when we allocate GDS,GWS and OA resources and to GTT when we allocate VRAM. Drop all those workarounds and generalize this for GTT as well. This

[drm-misc:drm-misc-next 20/26] htmldocs: Documentation/gpu/vc4.rst:65: WARNING: Unexpected indentation.

2022-12-10 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 612e241fb4bcd98d8ff9da7a795abb86b8ccfe38 commit: 5304c8e60100120c25557037edcc85791cb33a9a [20/26] Documentation: gpu: vc4: Add KUnit Tests Section reproduce: git remote add drm-misc

[PATCH v2 2/2] video: fbdev: uvesafb: Simplify uvesafb_remove()

2022-12-10 Thread Christophe JAILLET
When the remove() function is called, we know that the probe() function has successfully been executed. So 'info' is known to be not NULL. Simplify the code accordingly. Signed-off-by: Christophe JAILLET --- Change in v2: - new patch --- drivers/video/fbdev/uvesafb.c | 28

[PATCH v2 1/2] video: fbdev: uvesafb: Fixes an error handling path in uvesafb_probe()

2022-12-10 Thread Christophe JAILLET
If an error occurs after a successful uvesafb_init_mtrr() call, it must be undone by a corresponding arch_phys_wc_del() call, as already done in the remove function. This has been added in the remove function in commit 63e28a7a5ffc ("uvesafb: Clean up MTRR code") Fixes: 8bdb3a2d7df4 ("uvesafb:

Re: [PATCH] drm: Drop ARCH_MULTIPLATFORM from dependencies

2022-12-10 Thread Uwe Kleine-König
Hello Arnd, On Fri, Dec 09, 2022 at 11:53:49PM +0100, Arnd Bergmann wrote: > On Fri, Dec 9, 2022, at 23:05, Uwe Kleine-König wrote: > > Some of these dependencies used to be sensible when only a small part of > > the platforms supported by ARCH=arm could be compiled together in a > > single

Re: [syzbot] WARNING in drm_wait_one_vblank

2022-12-10 Thread Siddh Raman Pant
On Fri, 09 Dec 2022 17:41:23 +0530, syzbot wrote > syzbot has tested the proposed patch but the reproducer is still triggering > an issue: I keep getting "ERROR: Out of memory at tomoyo_realpath_from_path." and cannot reproduce the crash...

Re: [syzbot] WARNING in drm_wait_one_vblank

2022-12-10 Thread Siddh Raman Pant
Test the reproducer on latest. #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

Re: [PATCH v2 00/11] pwm: Allow .get_state to fail

2022-12-10 Thread Uwe Kleine-König
Hello Andy, On Fri, Dec 09, 2022 at 11:47:54PM +0200, Andy Shevchenko wrote: > On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-König wrote: > > In v1 Thierry had the concern: > > > > | That raises the question about what to do in these cases. If we return > > | an error, that could