Re: [PATCH 1/2] drm/msm/dsi: add a helper method to compute the dsi byte clk

2022-12-21 Thread Abhinav Kumar
Hi Dmitry Sorry for the late response. On 10/31/2022 5:20 PM, Dmitry Baryshkov wrote: On 28/10/2022 01:22, Abhinav Kumar wrote: On 10/27/2022 10:35 AM, Dmitry Baryshkov wrote: On 22/09/2022 03:49, Abhinav Kumar wrote: Re-arrange the dsi_calc_pclk method to two helpers, one to compute the

[PATCH v2 6/8] drm/msm/dpu: Remove num_enc from topology struct in favour of num_dsc

2022-12-21 Thread Marijn Suijten
Downstream calls this num_enc yet the DSC patches introduced a new num_dsc struct member, leaving num_enc effectively unused. Fixes: 7e9cc175b159 ("drm/msm/disp/dpu1: Add support for DSC in topology") Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 9 -

[PATCH v2 2/8] drm/msm/dsi: Use DSC slice(s) packet size to compute word count

2022-12-21 Thread Marijn Suijten
According to downstream the value to use for WORD_COUNT is bytes_per_pkt, which denotes the number of bytes in a packet based on how many slices have been configured by the panel driver times the width of a slice times the number of bytes per pixel. The DSC panels seen thus far use one byte per

[PATCH v2 0/8] drm/msm: DSC Electric Boogaloo for sm8[12]50

2022-12-21 Thread Marijn Suijten
This preliminary Display Stream Compression support package for (initially tested on) sm8[12]50 is based on comparing DSC behaviour between downstream and mainline. Some new callbacks are added (for binding blocks on active CTLs), logic bugs are corrected, zeroed struct members are now assigned

[PATCH v2 1/8] drm/msm/dpu: Wire up DSC mask for active CTL configuration

2022-12-21 Thread Marijn Suijten
Active CTLs have to configure what DSC block(s) have to be enabled, and what DSC block(s) have to be flushed; this value was initialized to zero resulting in the necessary register writes to never happen (or would write zero otherwise). This seems to have gotten lost in the DSC v4->v5 series

[PATCH v2 8/8] drm/msm/dpu: Add DSC configuration for SM8150 and SM8250

2022-12-21 Thread Marijn Suijten
These DSC blocks on CTL V1 need to set its corresponding PINGPONG block index in a hardware register to configure where to send pixel output to, via the newly-added DPU_DSC_OUTPUT_CTRL feature flag. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar ---

[PATCH v2 7/8] drm/msm/dpu: Implement DSC binding to PP block for CTL V1

2022-12-21 Thread Marijn Suijten
All V1 CTL blocks (active CTLs) explicitly bind the pixel output from a DSC block to a PINGPONG block by setting the PINGPONG index in a DSC hardware register. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar ---

[PATCH v2 5/8] drm/msm/dpu: Reject topologies for which no DSC blocks are available

2022-12-21 Thread Marijn Suijten
Resource allocation of DSC blocks should behave more like LMs and CTLs where NULL resources (based on initial hw_blk creation via definitions in the catalog) are skipped ^1. The current hardcoded mapping of DSC blocks however means that resource allocation shouldn't succeed at all when the DSC

[PATCH v2 3/8] drm/msm/dsi: Flip greater-than check for slice_count and slice_per_intf

2022-12-21 Thread Marijn Suijten
According to downstream /and the comment copied from it/ this comparison should be the other way around. In other words, when the panel driver requests to use more slices per packet than what could be sent over this interface, it is bumped down to only use a single slice per packet (and strangely

[PATCH v2 4/8] drm/msm/dpu: Disallow unallocated resources to be returned

2022-12-21 Thread Marijn Suijten
In the event that the topology requests resources that have not been created by the system (because they are typically not represented in dpu_mdss_cfg ^1), the resource(s) in global_state (in this case DSC blocks) remain NULL but will still be returned out of dpu_rm_get_assigned_resources, where

[PATCH v3 7/7] HAX: force enable PXP Kconfig

2022-12-21 Thread Alan Previn
Force PXP configs on for CI testing to trigger full subtests in IGT's gem_pxp as opposed to the partial "unsupported hw substests". Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Kconfig | 2 +- drivers/misc/mei/pxp/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v3 5/7] drm/i915/pxp: Trigger the global teardown for before suspending

2022-12-21 Thread Alan Previn
A driver bug was recently discovered where the security firmware was receiving internal HW signals indicating that session key expirations had occurred. Architecturally, the firmware was expecting a response from the GuC to acknowledge the event with the firmware side. However the OS was in a

[PATCH v3 1/7] mei: mei-me: resume device in prepare

2022-12-21 Thread Alan Previn
From: Alexander Usyskin Async runtime resume is not possible while system is suspending. The power management subsystem resumes device only in the suspend phase, not in the prepare phase. Force resume device in prepare to allow drivers on mei bus to communicate in prepare callbacks.

[PATCH v3 2/7] drm/i915/pxp: add device link between i915 and mei_pxp

2022-12-21 Thread Alan Previn
From: Alexander Usyskin Add device link with i915 as consumer and mei_pxp as supplier to ensure proper ordering of power flows. V2: condition on absence of heci_pxp to filter out DG Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 7 +++ 1 file changed, 7

[PATCH v3 6/7] drm/i915/pxp: Pxp hw init should be in resume_complete

2022-12-21 Thread Alan Previn
During suspend flow, i915 currently achors' on the pm_suspend_prepare callback as the location where we quiesce the entire GPU and perform all necessary cleanup in order to go into suspend. PXP is also called during this time to perform the arbitration session teardown (with the assurance no

[PATCH v3 4/7] drm/i915/pxp: Invalidate all PXP fw sessions during teardown

2022-12-21 Thread Alan Previn
A gap was recently discovered where if an application did not invalidate all of the stream keys (intentionally or not), and the driver did a full PXP global teardown on the GT subsystem, we find that future session creation would fail on the security firmware's side of the equation. i915 is the

[PATCH v3 3/7] mei: clean pending read with vtag on bus

2022-12-21 Thread Alan Previn
From: Alexander Usyskin Client on bus have only one vtag map slot and should disregard the vtag value when cleaning pending read flag. Fixes read flow control message unexpectedly generated when clent on bus send messages with different vtags. Signed-off-by: Alexander Usyskin ---

[PATCH v3 0/7] drm/i915/pxp: Add missing cleanup steps for PXP global-teardown

2022-12-21 Thread Alan Previn
A customer issue was recently discovered and in the process a gap in i915's PXP interaction with HW+FW architecure was also realized. This series adds those missing pieces. This fix includes changes where i915 calls into the mei component interface in order to submit requests to the security

Re: [PATCH v5 03/12] dt-bindings: display: bridge: snps, dw-mipi-dsi: fix clock properties

2022-12-21 Thread Rob Herring
On Wed, Dec 21, 2022 at 12:22 PM Johan Jonker wrote: > > Fix clock properties from the common snps,dw-mipi-dsi.yaml file, > as they don't match with what is used on the SoCs. > > Signed-off-by: Johan Jonker > --- > .../display/bridge/snps,dw-mipi-dsi.yaml | 16 +++- > 1 file

Re: [PATCH v5 04/12] dt-bindings: display: rockchip: convert dw_mipi_dsi_rockchip.txt to yaml

2022-12-21 Thread Rob Herring
On Wed, Dec 21, 2022 at 12:22 PM Johan Jonker wrote: > > Convert dw_mipi_dsi_rockchip.txt to yaml. > > Changed: > add clock-master property > file name > requirements > > Signed-off-by: Johan Jonker > --- > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 94 -- >

Re: [PATCH v5 05/12] dt-bindings: usb: convert fcs, fusb302.txt to yaml

2022-12-21 Thread Rob Herring
On Wed, Dec 21, 2022 at 12:23 PM Johan Jonker wrote: > > Convert fcs,fusb302.txt to yaml. > > Changed: > Add vbus-supply property > > Signed-off-by: Johan Jonker > --- > .../devicetree/bindings/usb/fcs,fusb302.txt | 34 -- > .../devicetree/bindings/usb/fcs,fusb302.yaml | 66

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-21 Thread Brian Norris
Hi Mark, Sean, (and dri-devel) On Wed, Dec 14, 2022 at 07:04:37PM -0800, Brian Norris wrote: > On Tue, Dec 13, 2022 at 04:51:11PM +, Mark Brown wrote: > > On Tue, Dec 13, 2022 at 05:56:30AM -0800, KernelCI bot wrote: > > > > The KernelCI bisection bot found regressions in at least two KMS

Re: [PATCH] drm/amd/display: Remove the unused function dmub_outbox_irq_info_funcs

2022-12-21 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Dec 19, 2022 at 9:22 AM Jiapeng Chong wrote: > > The function dmub_outbox_irq_info_funcs is defined in the > irq_service_dcn201.c file, but not called elsewhere, so remove this > unused function. > >

[pull] amdgpu, amdkfd drm-fixes-6.2

2022-12-21 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.2. The following changes since commit 38624d2c972e7692ca59d0d3b97741a3313addb3: Merge tag 'drm-intel-next-fixes-2022-12-15' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2022-12-20 15:43:14 +1000) are available in the Git repository at:

Re: [PATCH v2 07/13] drm/format-helper: Add conversion from XRGB8888 to ARGB8888

2022-12-21 Thread Maíra Canal
On 12/20/22 13:11, Thomas Zimmermann wrote: > Add dedicated helper to convert from XRGB to ARGB. Sets > all alpha bits to make pixels fully opaque. > > v2: > * use cpubuf_to_le32() > * type fixes > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Javier Martinez Canillas >

Re: [PATCH v2 05/13] drm/format-helper: Type fixes in format-helper tests

2022-12-21 Thread Maíra Canal
On 12/20/22 13:11, Thomas Zimmermann wrote: > Change the source-buffer type of le32buf_to_cpu() to __le32* to > reflect endianness. Result buffers are converted to local endianness, > so instantiate them from regular u8 or u32 types. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Maíra Canal

Re: [PATCH 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2022-12-21 Thread Han Jingoo
On Tue, Dec 20, 2022, Jianhua Lu wrote: > > Add support for Kinetic KTZ8866 backlight, which is used in > Xiaomi tablet, Mi Pad 5 series. This driver lightly based on > downstream implementation [1]. > [1] >

Re: [PATCH v2 04/13] drm/format-helper: Store RGB565 in little-endian order

2022-12-21 Thread Maíra Canal
On 12/20/22 13:11, Thomas Zimmermann wrote:> Fix to-RGB565 conversion helpers to store the result in little- > endian byte order. Update test cases as well. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Maíra Canal Best Regards, - Maíra Canal > --- > drivers/gpu/drm/drm_format_helper.c

WARNING: CPU: 2 PID: 42 at drivers/gpu/drm/drm_modeset_lock.c:276

2022-12-21 Thread Stefan Wahren
Hi, if i enable PROVE_LOCKING on the Raspberry Pi 3 B+ (arm/multi_v7_defconfig) using v6.1 (didn't test older versions) i'm getting the following warning: [  204.043396] WARNING: CPU: 2 PID: 42 at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x6c/0x70 [  204.043426] Modules

Re: [PATCH v9 01/15] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc

2022-12-21 Thread Dmitry Baryshkov
On 21/12/2022 16:10, Vinod Polimera wrote: -Original Message- From: Dmitry Baryshkov Sent: Wednesday, December 14, 2022 9:05 PM To: Vinod Polimera (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org Cc:

Re: [PATCH v2 03/13] drm/format-helper: Fix test-input format conversion

2022-12-21 Thread Maíra Canal
On 12/20/22 13:11, Thomas Zimmermann wrote: > Convert test input for format helpers from host byte order to > little-endian order. The current code does it the other way around, > but there's no effective difference to the result. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Maíra Canal

Re: [PATCH v2 02/13] drm/format-helper: Comment on RGB888 byte order

2022-12-21 Thread Maíra Canal
On 12/20/22 13:11, Thomas Zimmermann wrote: > RGB888 is different than the other formats as most of its pixels are > unaligned and therefore helper functions do not use endianness conversion > helpers. Comment on this in the source code. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Maíra

[PATCH 3/3] drm/i915/uc: Fix two issues with over-size firmware files

2022-12-21 Thread John . C . Harrison
From: John Harrison In the case where a firmware file is too large (e.g. someone downloaded a web page ASCII dump from github...), the firmware object is released but the pointer is not zerod. If no other firmware file was found then release would be called again leading to a double kfree.

[PATCH 2/3] drm/i915/guc: Fix a static analysis warning

2022-12-21 Thread John . C . Harrison
From: John Harrison A static analyser was complaining about not checking for null pointers. However, the location of the complaint can only be reached in the first place if said pointer is non-null. Basically, if we are using a v69 GuC then the descriptor pool is guaranteed to be alocated at

[PATCH 1/3] drm/i915/guc: Fix missing return code checks in submission init

2022-12-21 Thread John . C . Harrison
From: John Harrison The CI results for the 'fast request' patch set (enables error return codes for fire-and-forget H2G messages) hit an issue with the KMD sending context submission requests on an invalid context. That was caused by a fault injection probe failing the context creation of a

[PATCH 0/3] Fixes for various UC related issues

2022-12-21 Thread John . C . Harrison
From: John Harrison Fix a bunch of assorted issues with firmware loading and GuC intialisation. Signed-off-by: John Harrison John Harrison (3): drm/i915/guc: Fix missing return code checks in submission init drm/i915/guc: Fix a static analysis warning drm/i915/uc: Fix two issues with

Re: [PATCH] treewide: Convert del_timer*() to timer_shutdown*()

2022-12-21 Thread Kalle Valo
Steven Rostedt writes: > [ > Linus, > > I ran the script against your latest master branch: > commit b6bb9676f2165d518b35ba3bea5f1fcfc0d969bf > > As the timer_shutdown*() code is now in your tree, I figured > we can start doing the conversions. At least add the trivial ones >

[PATCH v5 12/12] arm64: dts: rockchip: rk356x: remove hclk from dsi node

2022-12-21 Thread Johan Jonker
The hclk is not used in the dw-mipi-dsi-rockchip.c driver, so remove hclk from the rk356x.dtsi dsi node. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi

[PATCH v5 11/12] arm64: dts: rockchip: rename vbus-supply to phy-supply in rk3566-box-demo.dts

2022-12-21 Thread Johan Jonker
'vbus-supply' does not match any of the regexes in rk3566-box-demo.dts in the usb2phy0_otg node, so rename vbus-supply to phy-supply. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 10/12] arm64: dts: rockchip: rk3399: fix dsi node

2022-12-21 Thread Johan Jonker
Use generic node name for rk3399.dtsi dsi node. With the conversion of rockchip,dw-mipi-dsi.yaml a port@1 node is required, so add a node with label mipi_out. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 ++-- 1 file changed, 10 insertions(+), 2

[PATCH v5 09/12] arm64: dts: rockchip: px30: fix dsi node

2022-12-21 Thread Johan Jonker
With the conversion of rockchip,dw-mipi-dsi.yaml a port@1 node is required, so add a node with label dsi_out. Also add label dsi_in to port@0. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/px30.dtsi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH v5 08/12] arm64: dts: rockchip: px30: fix lvds node

2022-12-21 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Also add label lvds_in to port@0. Signed-off-by: Johan Jonker --- Changed V5: rename title add label lvds_in --- arch/arm64/boot/dts/rockchip/px30.dtsi | 6 +- 1 file changed, 5

[PATCH v5 07/12] ARM: dts: rockchip: rk3288: fix lvds node

2022-12-21 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Signed-off-by: Johan Jonker --- Changed V5: rename title --- arch/arm/boot/dts/rk3288.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi

[PATCH v5 06/12] ARM: dts: rockchip: rk3288: fix dsi node

2022-12-21 Thread Johan Jonker
Use generic node name for rk3288.dtsi dsi node. With the conversion of rockchip,dw-mipi-dsi.yaml a port@1 node is required, so add a node with label mipi_out. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3288.dtsi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH v5 05/12] dt-bindings: usb: convert fcs,fusb302.txt to yaml

2022-12-21 Thread Johan Jonker
Convert fcs,fusb302.txt to yaml. Changed: Add vbus-supply property Signed-off-by: Johan Jonker --- .../devicetree/bindings/usb/fcs,fusb302.txt | 34 -- .../devicetree/bindings/usb/fcs,fusb302.yaml | 66 +++ 2 files changed, 66 insertions(+), 34 deletions(-) delete

[PATCH v5 04/12] dt-bindings: display: rockchip: convert dw_mipi_dsi_rockchip.txt to yaml

2022-12-21 Thread Johan Jonker
Convert dw_mipi_dsi_rockchip.txt to yaml. Changed: add clock-master property file name requirements Signed-off-by: Johan Jonker --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 94 -- .../rockchip/rockchip,dw-mipi-dsi.yaml| 173 ++ 2 files changed, 173

[PATCH v5 03/12] dt-bindings: display: bridge: snps, dw-mipi-dsi: fix clock properties

2022-12-21 Thread Johan Jonker
Fix clock properties from the common snps,dw-mipi-dsi.yaml file, as they don't match with what is used on the SoCs. Signed-off-by: Johan Jonker --- .../display/bridge/snps,dw-mipi-dsi.yaml | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git

[PATCH v5 02/12] dt-bindings: soc: rockchip: grf: add rockchip,lvds.yaml

2022-12-21 Thread Johan Jonker
Add new converted rockchip,lvds.yaml to grf.yaml file. Prepare for more SoCs with lvds output. Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- Changed V5: Drop the quotes --- .../devicetree/bindings/soc/rockchip/grf.yaml | 24 +++ 1 file changed, 14 insertions(+),

[PATCH v5 01/12] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-21 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- Changed V3: Filename matching compatible style Drop "Regulator phandle for " Specify properties and requirements per

[PATCH v3 1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version

2022-12-21 Thread Alan Previn
If PXP arb-session is being attempted on older hardware SKUs or on hardware with older, unsupported, firmware versions, then don't report the failure with a drm_error. Instead, look specifically for the API-version error reply and drm_dbg that reply. In this case, the user-space will eventually

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version

2022-12-21 Thread Teres Alexis, Alan Previn
On Wed, 2022-12-21 at 12:21 +0200, Jani Nikula wrote: > On Tue, 20 Dec 2022, Alan Previn wrote: > > Alan:[snip] > > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > @@ -298,6 +298,11 @@ int intel_pxp_tee_cmd_create_arb_session(struct > > intel_pxp *pxp, > > > > if (ret) > >

Re: [PATCH v3 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2022-12-21 Thread Akhil P Oommen
On 12/21/2022 8:13 PM, Ulf Hansson wrote: > On Tue, 20 Dec 2022 at 08:44, Akhil P Oommen wrote: >> From: Ulf Hansson >> >> Some genpd providers doesn't ensure that it has turned off at hardware. >> This is fine until the consumer really requires during some special >> scenarios that the power

[PATCH v4 5/5] drm/msm/a6xx: Use genpd notifier to ensure cx-gdsc collapse

2022-12-21 Thread Akhil P Oommen
As per the recommended recovery sequence of adreno gpu, cx gdsc should collapse at hardware before it is turned back ON. This helps to clear out the stale states in hardware before it is reinitialized. Use the genpd notifier along with the newly introduced dev_pm_genpd_synced_poweroff() api to

[PATCH v4 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset'

2022-12-21 Thread Akhil P Oommen
Remove the unused 'reset' interface which was supposed to help to ensure that cx gdsc has collapsed during gpu recovery. This is was not enabled so far due to missing gpucc driver support. Similar functionality using genpd framework will be implemented in the upcoming patch. This effectively

[PATCH v4 3/5] drm/msm/a6xx: Vote for cx gdsc from gpu driver

2022-12-21 Thread Akhil P Oommen
When a device has multiple power domains, dev->power_domain is left empty during probe. That didn't cause any issue so far because we are freeloading on smmu driver's vote on cx gdsc. Instead of that, create a device_link between cx genpd device and gmu device to keep a vote from gpu driver.

[PATCH v4 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag

2022-12-21 Thread Akhil P Oommen
Add support for the newly added 'synced_poweroff' genpd flag. This allows some clients (like adreno gpu driver) to request gdsc driver to ensure a votable gdsc (like gpucc cx gdsc) has collapsed at hardware. Signed-off-by: Akhil P Oommen --- (no changes since v3) Changes in v3: - Rename the

[PATCH v4 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2022-12-21 Thread Akhil P Oommen
From: Ulf Hansson Some genpd providers doesn't ensure that it has turned off at hardware. This is fine until the consumer really requires during some special scenarios that the power domain collapse at hardware before it is turned ON again. An example is the reset sequence of Adreno GPU which

[PATCH v4 0/5] Improve GPU reset sequence for Adreno GPU

2022-12-21 Thread Akhil P Oommen
This is a rework of [1] using genpd instead of 'reset' framework. As per the recommended reset sequence of Adreno gpu, we should ensure that gpucc-cx-gdsc has collapsed at hardware to reset gpu's internal hardware states. Because this gdsc is implemented as 'votable', gdsc driver doesn't poll

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2022-12-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 Grigorije (grigorij...@gmail.com) changed: What|Removed |Added CC||grigorij...@gmail.com

Re: [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS

2022-12-21 Thread Mike Lothian
On Wed, 21 Dec 2022 at 15:52, Luben Tuikov wrote: > > On 2022-12-21 10:34, Mike Lothian wrote: > > On Fri, 14 Oct 2022 at 09:47, Christian König > > wrote: > >> > >> Entirely remove the sync obj in the job. > >> > >> Signed-off-by: Christian König > >> --- > >>

Re: [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS

2022-12-21 Thread Luben Tuikov
On 2022-12-21 10:34, Mike Lothian wrote: > On Fri, 14 Oct 2022 at 09:47, Christian König > wrote: >> >> Entirely remove the sync obj in the job. >> >> Signed-off-by: Christian König >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 21 ++--- >>

Re: [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS

2022-12-21 Thread Mike Lothian
https://gitlab.freedesktop.org/drm/amd/-/issues/2309 On Wed, 21 Dec 2022 at 15:34, Mike Lothian wrote: > > On Fri, 14 Oct 2022 at 09:47, Christian König > wrote: > > > > Entirely remove the sync obj in the job. > > > > Signed-off-by: Christian König > > --- > >

Re: [PATCH 2/2] drm/fbdev: Move damage clip check to higher level

2022-12-21 Thread Hogander, Jouni
On Wed, 2022-12-21 at 13:05 +0100, Thomas Zimmermann wrote: > Hi > > Am 21.12.22 um 12:19 schrieb Jouni Högander: > > Checking if damage clip is valid is common to all fb helpers. > > Makes more sense to check it in higher level than adding into > > all helpers. > > It was a deliberate decision

Re: [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS

2022-12-21 Thread Mike Lothian
On Fri, 14 Oct 2022 at 09:47, Christian König wrote: > > Entirely remove the sync obj in the job. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 21 ++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.h | 2 ++ >

Re: [RESEND] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2022-12-21 Thread Krzysztof Kozlowski
On 21/12/2022 16:15, Jianhua Lu wrote: > On Wed, Dec 21, 2022 at 04:03:44PM +0100, Krzysztof Kozlowski wrote: >> On 21/12/2022 14:24, Jianhua Lu wrote: >>> Add Kinetic KTZ8866 backlight binding documentation. >>> >>> Signed-off-by: Jianhua Lu >> >> Do not resend. You need to fix everything, test

Re: [PATCH] drm/panfrost: Fix GEM handle creation ref-counting

2022-12-21 Thread Steven Price
On 19/12/2022 17:10, Rob Clark wrote: > On Mon, Dec 19, 2022 at 6:02 AM Steven Price wrote: >> >> panfrost_gem_create_with_handle() previously returned a BO but with the >> only reference being from the handle, which user space could in theory >> guess and release, causing a use-after-free.

[PATCH v2 4/4] drm/msm/a6xx: Update ROQ size in coredump

2022-12-21 Thread Akhil P Oommen
Since RoQ size differs between generations, calculate dynamically the RoQ size while capturing coredump. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 11 ++- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 17 ++--- 2

[PATCH v2 3/4] drm/msm/a6xx: Update a6xx gpu coredump

2022-12-21 Thread Akhil P Oommen
Update gpu coredump for a660/a650 family of gpus with the extra information available. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx.xml.h | 18 +++ drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 50 -

[PATCH v2 2/4] drm/msm: Fix failure paths in msm_drm_init()

2022-12-21 Thread Akhil P Oommen
Ensure that we do drm_dev_put() when there is an early return in msm_drm_init(). Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/disp/msm_disp_snapshot.c | 3 +++ drivers/gpu/drm/msm/msm_drv.c| 11 +++ 2 files changed, 10 insertions(+), 4

[PATCH v2 1/4] drm/msm/adreno: Fix null ptr access in adreno_gpu_cleanup()

2022-12-21 Thread Akhil P Oommen
Fix the below kernel panic due to null pointer access: [ 18.504431] Unable to handle kernel NULL pointer dereference at virtual address 0048 [ 18.513464] Mem abort info: [ 18.516346] ESR = 0x9605 [ 18.520204] EC = 0x25: DABT (current EL), IL = 32 bits [

Re: [RESEND] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2022-12-21 Thread Krzysztof Kozlowski
On 21/12/2022 14:24, Jianhua Lu wrote: > Add Kinetic KTZ8866 backlight binding documentation. > > Signed-off-by: Jianhua Lu Do not resend. You need to fix everything, test and send a new patchset (entire) with the changelog. Best regards, Krzysztof

Re: [PATCH v3 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2022-12-21 Thread Ulf Hansson
On Tue, 20 Dec 2022 at 08:44, Akhil P Oommen wrote: > > From: Ulf Hansson > > Some genpd providers doesn't ensure that it has turned off at hardware. > This is fine until the consumer really requires during some special > scenarios that the power domain collapse at hardware before it is > turned

RE: [PATCH v9 01/15] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc

2022-12-21 Thread Vinod Polimera
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, December 14, 2022 9:05 PM > To: Vinod Polimera (QUIC) ; dri- > de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedr...@lists.freedesktop.org; devicet...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org;

Re: [PATCH v2 09/13] drm/format-helper: Add conversion from XRGB8888 to 15-bit RGB555 formats

2022-12-21 Thread kernel test robot
' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-Fix-color-format-selection-in-fbdev-emulation/20221221-001529 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link

[Bug 216806] [Raven Ridge] console disappears after framebuffer device loads

2022-12-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216806 --- Comment #4 from Balazs Vinarz (viniba...@gmail.com) --- Just some more information to share here. I gave it another try, and the console freezes exactly at the moment when drm enables the kernel modesetting. [6.329371] [drm] amdgpu

Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight

2022-12-21 Thread Rob Herring
On Wed, 21 Dec 2022 15:02:16 +0800, Jianhua Lu wrote: > Add device tree bindings for the Kinetic KTZ8866 backlight driver. > > Signed-off-by: Jianhua Lu > --- > .../leds/backlight/kinetic,ktz8866.yaml | 37 +++ > 1 file changed, 37 insertions(+) > create mode 100644 >

Re: [PATCH v2 07/13] drm/format-helper: Add conversion from XRGB8888 to ARGB8888

2022-12-21 Thread kernel test robot
' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-Fix-color-format-selection-in-fbdev-emulation/20221221-001529 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link

Re: [PATCH 2/2] drm/fbdev: Move damage clip check to higher level

2022-12-21 Thread Thomas Zimmermann
Hi Am 21.12.22 um 12:19 schrieb Jouni Högander: Checking if damage clip is valid is common to all fb helpers. Makes more sense to check it in higher level than adding into all helpers. It was a deliberate decision to separate damage clipping and dirty updates; done in [1]. Clipping is an

Re: [PATCH 07/10] drm: Remove usage of deprecated DRM_DEBUG_KMS

2022-12-21 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Siddh-Raman-Pant/drm-Remove-usage-of-deprecated-DRM_-macros/20221221-113133 patch link: https://lore.kernel.org/r

Re: [PATCH 1/2] drm/i915/fbdev: Implement fb_dirty for intel custom fb helper

2022-12-21 Thread Thomas Zimmermann
Hi Am 21.12.22 um 12:19 schrieb Jouni Högander: After splitting generic drm_fb_helper into it's own file it's left to helper implementation to have fb_dirty function. Currently intel fb doesn't have it. This is causing problems to features (PSR, FBC, DRRS) relying on dirty callback. Implement

[PATCH 2/2] drm/fbdev: Move damage clip check to higher level

2022-12-21 Thread Jouni Högander
Checking if damage clip is valid is common to all fb helpers. Makes more sense to check it in higher level than adding into all helpers. Cc: Ville Syrjälä Cc: Thomas Zimmermann Cc: Jani Nikula Signed-off-by: Jouni Högander --- drivers/gpu/drm/drm_fb_helper.c | 4

[PATCH 1/2] drm/i915/fbdev: Implement fb_dirty for intel custom fb helper

2022-12-21 Thread Jouni Högander
After splitting generic drm_fb_helper into it's own file it's left to helper implementation to have fb_dirty function. Currently intel fb doesn't have it. This is causing problems to features (PSR, FBC, DRRS) relying on dirty callback. Implement simple fb_dirty callback to deliver notifications

[PATCH 0/2] Fixes for intel fb helper

2022-12-21 Thread Jouni Högander
This patch set is fixing Intel fb console update issues introduced by splitting generic drm_fb_helper into it's own file. Also damage clip check moved to higher level to share it between fb helpers. Cc: Ville Syrjälä Cc: Thomas Zimmermann Cc: Jani Nikula Jouni Högander (2): drm/i915/fbdev:

[PATCH v3 3/3] efi: earlycon: Add support for generic framebuffers

2022-12-21 Thread Markuss Broks
Add early console support for generic linear framebuffer devices. This driver supports probing from cmdline early parameters or from the device-tree using information in simple-framebuffer node. The EFI functionality should be retained in whole. The driver was disabled on ARM because of a bug in

[PATCH v3 2/3] efi: earlycon: move to video/console to prepare for changes

2022-12-21 Thread Markuss Broks
This would make the next patch in series with this one to show a clear diff, instead of just removing the previous driver and creating a new one. Signed-off-by: Markuss Broks --- drivers/{firmware/efi => video/console}/earlycon.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename

[PATCH v3 1/3] drivers: serial: earlycon: Pass device-tree node

2022-12-21 Thread Markuss Broks
Pass a pointer to device-tree node in case the driver probed from OF. This makes early console drivers able to fetch options from device-tree node properties. Signed-off-by: Markuss Broks --- drivers/tty/serial/earlycon.c | 3 +++ include/linux/serial_core.h | 1 + 2 files changed, 4

[PATCH v3 0/3] Add generic framebuffer support to EFI earlycon driver

2022-12-21 Thread Markuss Broks
Make the EFI earlycon driver be suitable for any linear framebuffers. This should be helpful for early porting of boards with no other means of output, like smartphones/tablets. There seems to be an issue with early_ioremap function on ARM32, but I am unable to find the exact cause. It appears the

Re: [PATCH 10/10] drm/drm_lease: Remove usage of deprecated DRM_DEBUG_LEASE

2022-12-21 Thread Simon Ser
Patch is: Reviewed-by: Simon Ser

Re: [PATCH v3 0/2] drm/imx/lcdc: Implement DRM driver for imx21

2022-12-21 Thread Uwe Kleine-König
Hello Rob, On Tue, Dec 20, 2022 at 12:19:48PM -0600, Rob Herring wrote: > On Sat, Dec 17, 2022 at 07:38:06PM +0100, Uwe Kleine-König wrote: > > On Fri, Dec 16, 2022 at 05:57:58PM -0600, Rob Herring wrote: > > > On Fri, Dec 16, 2022 at 06:50:04PM +0100, Uwe Kleine-König wrote: > > > > Hello, > > >

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version

2022-12-21 Thread Jani Nikula
On Tue, 20 Dec 2022, Alan Previn wrote: > If PXP arb-session is being attempted on older hardware SKUs or > on hardware with older, unsupported, firmware versions, then don't > report the failure with a drm_error. Instead, look specifically for > the API-version error reply and drm_dbg that

Re: [PATCH v2 3/7] media: renesas: vsp1: Change V3U to be gen4

2022-12-21 Thread Laurent Pinchart
Hi Tomi, On Wed, Dec 21, 2022 at 09:48:10AM +0200, Tomi Valkeinen wrote: > On 19/12/2022 23:01, Laurent Pinchart wrote: > > On Mon, Dec 19, 2022 at 04:01:35PM +0200, Tomi Valkeinen wrote: > >> V3U is actually gen4, not gen3. The same IP is also used in the > >> (not-yet-supported) V4H. > >> > >>

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

2022-12-21 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker. The relevant code here is not my area of expertise, nevertheless a few questions: On 21.12.22 03:23, Kaiwan N Billimoria wrote: > [REGRESSION] ? > Testing with 6.1, I find the same issue - VirtualBox VMs seem to hang > on boot, though the kernel

Re: [PATCH 06/10] drm: Remove usage of deprecated DRM_DEBUG_DRIVER

2022-12-21 Thread Thomas Zimmermann
Hi Am 21.12.22 um 11:00 schrieb Jani Nikula: On Wed, 21 Dec 2022, Siddh Raman Pant wrote: drm_print.h says DRM_DEBUG_DRIVER is deprecated. Thus, use newer drm_dbg_driver(). Also fix the deprecation comment in drm_print.h which mentions drm_dbg() instead of drm_dbg_driver(). Signed-off-by:

Re: [PATCH 01/10] drm: Remove usage of deprecated DRM_INFO

2022-12-21 Thread Thomas Zimmermann
Hi Am 21.12.22 um 10:49 schrieb Jani Nikula: On Wed, 21 Dec 2022, Siddh Raman Pant wrote: drm_print.h says DRM_INFO is deprecated. Thus, use newer printing macros drm_info() and pr_info(). I think it's a bit odd some of the conversion is to pr_*() and some to drm_*(NULL, ...) depending on

Re: [PATCH 00/10] drm: Remove usage of deprecated DRM_* macros

2022-12-21 Thread Jani Nikula
On Wed, 21 Dec 2022, Thomas Zimmermann wrote: > Hi > > Am 20.12.22 um 21:16 schrieb Siddh Raman Pant: >> This patchset aims to remove usages of deprecated DRM_* macros from the >> files residing in drivers/gpu/drm root. >> >> In process, I found out that NULL as first argument of drm_dbg_*

Re: [PATCH 06/10] drm: Remove usage of deprecated DRM_DEBUG_DRIVER

2022-12-21 Thread Jani Nikula
On Wed, 21 Dec 2022, Siddh Raman Pant wrote: > drm_print.h says DRM_DEBUG_DRIVER is deprecated. > Thus, use newer drm_dbg_driver(). > > Also fix the deprecation comment in drm_print.h which > mentions drm_dbg() instead of drm_dbg_driver(). > > Signed-off-by: Siddh Raman Pant > --- >

Re: [PATCH 01/10] drm: Remove usage of deprecated DRM_INFO

2022-12-21 Thread Jani Nikula
On Wed, 21 Dec 2022, Siddh Raman Pant wrote: > drm_print.h says DRM_INFO is deprecated. > Thus, use newer printing macros drm_info() and pr_info(). I think it's a bit odd some of the conversion is to pr_*() and some to drm_*(NULL, ...) depending on the logging level etc. Notably the pr_*()

Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight

2022-12-21 Thread Krzysztof Kozlowski
On 21/12/2022 10:40, jianhua lu wrote: > Thanks for review, I will resend this path. Are you going to test it, before sending? Best regards, Krzysztof

Re: [PATCH 04/10] drm/print: Fix support for NULL as first argument of drm_dbg_*

2022-12-21 Thread Jani Nikula
On Wed, 21 Dec 2022, Siddh Raman Pant wrote: > Comments say macros DRM_DEBUG_* are deprecated in favor of > drm_dbg_*(NULL, ...), but they have broken support for it, > as the macro will result in `(NULL) ? (NULL)->dev : NULL`. What's wrong with that? > > Thus, fix them by casting input drm to

Re: [PATCH 00/10] drm: Remove usage of deprecated DRM_* macros

2022-12-21 Thread Thomas Zimmermann
Hi Am 20.12.22 um 21:16 schrieb Siddh Raman Pant: This patchset aims to remove usages of deprecated DRM_* macros from the files residing in drivers/gpu/drm root. In process, I found out that NULL as first argument of drm_dbg_* wasn't working, but it was listed as the alternative in deprecation

  1   2   >