Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Stephen Kitt
On 7 January 2023 21:53:46 CET, Sam Ravnborg wrote: >Hi Stephen. > >On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: >> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint >> wrote: >> >From: Sam Ravnborg >> > >> >The atmel_lcdfb had code to save/restore power

[PATCH 11/12] drm/bridge: lt9611: rework infoframes handling

2023-01-07 Thread Dmitry Baryshkov
Rework handling infoframes: - Write full HDMI AVI infoframe instead of just fixing the VIC value - Also send the HDMI Vendor Specific infoframe, as recommended by the HDMI spec. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 57 +++-- 1 file

[PATCH 06/12] drm/bridge: lt9611: pass a pointer to the of node

2023-01-07 Thread Dmitry Baryshkov
Pass a pointer to the OF node while registering lt9611 MIPI device. Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 08/12] drm/bridge: lt9611: attach to the next bridge

2023-01-07 Thread Dmitry Baryshkov
The bindings require that there is a next bridge after the lt9611. If nothing else it can be the hdmi-connector (as used on the RB3 platform, see sdm845-db845c.dts). Bring in the next bridge into the drm bridges chain and attach to it. Since lt9611 is not anymore the last bridge in the chain,

[PATCH 12/12] drm/bridge: lt9611: stop filtering modes via the table

2023-01-07 Thread Dmitry Baryshkov
The lt9611 bridge can support different modes, it makes no sense to list them in the table. Drop the table and check the number of interfaces using the fixed value. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 41 +++-- 1 file changed, 4

[PATCH 10/12] drm/bridge: lt9611: simplify video timings programming

2023-01-07 Thread Dmitry Baryshkov
Inline calculated values to simplify the calculation in lt9611_mipi_video_setup(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c

[PATCH 09/12] drm/bridge: lt9611: fix sync polarity for DVI output

2023-01-07 Thread Dmitry Baryshkov
Attaching DVI sink to the lt9611 requires different setup. Fix the register write to make the DVI displays sync onto the correct sync pulse. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 05/12] drm/bridge: lt9611: fix clock calculation

2023-01-07 Thread Dmitry Baryshkov
Instead of having several fixed values for the pcr register, calculate it before programming. This allows the bridge to support most of the display modes. Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Signed-off-by: Dmitry Baryshkov ---

[PATCH 03/12] drm/bridge: lt9611: fix polarity programming

2023-01-07 Thread Dmitry Baryshkov
Fix programming of hsync and vsync polarities Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git

[PATCH 07/12] drm/bridge: lt9611: rework the mode_set function

2023-01-07 Thread Dmitry Baryshkov
The mode_set callback is deprectated for drm_bridges in favour of using atomic_enable callback. Move corresponding code into the function lt9611_bridge_atomic_enable() and turn lt9611_bridge_pre_enable() into the proper atomic_pre_enable callback. Signed-off-by: Dmitry Baryshkov ---

[PATCH 02/12] drm/bridge: lt9611: fix HPD reenablement

2023-01-07 Thread Dmitry Baryshkov
The driver will reset the bridge in the atomic_pre_enable(). However this will also drop the HPD interrupt state. Instead of resetting the bridge, properly wake it up. This fixes the HPD interrupt delivery after the disable/enable cycle. Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to

[PATCH 04/12] drm/bridge: lt9611: fix programming of video modes

2023-01-07 Thread Dmitry Baryshkov
Program the upper part of the hfront_porch into the proper register. Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/lontium-lt9611.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 01/12] drm/bridge: lt9611: fix sleep mode setup

2023-01-07 Thread Dmitry Baryshkov
On atomic_post_disable the bridge goes to the low power state. However the code disables too much of the chip, so the HPD event is not being detected and delivered to the host. Reduce the power saving in order to get the HPD event. Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI

[PATCH 00/12] drm/bridge: lt9611: several fixes and improvements

2023-01-07 Thread Dmitry Baryshkov
A series of patches to fix mode programming for the Lontium lt9611 DSI-to-HDMI bridge (found e.g. on the Thundercomm RB3/Dragonboard845c platform). Dmitry Baryshkov (12): drm/bridge: lt9611: fix sleep mode setup drm/bridge: lt9611: fix HPD reenablement drm/bridge: lt9611: fix polarity

Re: [RFC PATCH 2/4] dt-bindings: vendor-prefixes: Add lincolntech

2023-01-07 Thread Laurent Pinchart
Hi Aradhya, Thank you for the patch. On Tue, Jan 03, 2023 at 12:16:13PM +0530, Aradhya Bhatia wrote: > Add document vendor prefix for Lincoln Technology Solutions > (lincolntech). > > Signed-off-by: Aradhya Bhatia Reviewed-by: Laurent Pinchart > --- >

Re: [RFC PATCH 1/4] dt-bindings: vendor-prefixes: Add microtips

2023-01-07 Thread Laurent Pinchart
Hi Aradhya, Thank you for the patch. On Tue, Jan 03, 2023 at 12:16:12PM +0530, Aradhya Bhatia wrote: > Add document vendor prefix for Microtips Technology USA (microtips). > > Signed-off-by: Aradhya Bhatia Reviewed-by: Laurent Pinchart > --- >

Re: [RFC PATCH 3/4] dt-bindings: panel: Introduce dual-link LVDS panel

2023-01-07 Thread Laurent Pinchart
Hi Aradhya, Thank you for the patch. On Tue, Jan 03, 2023 at 12:16:14PM +0530, Aradhya Bhatia wrote: > Dual-link LVDS interfaces have 2 links, with even pixels traveling on > one link, and odd pixels on the other. These panels are also generic in > nature, with no documented constraints, much

[PATCH v2] drm: rcar-du: depend on DRM_RCAR_DU for components on that SoC

2023-01-07 Thread Peter Robinson
There's a few components in the rcar-du drm directory that don't make sense to be selectable if DRM_RCAR_DU isn't because they are part of the IP block so add a dependency and add compile check to ensure they're still tested. Signed-off-by: Peter Robinson --- v2: - typo fix in commit message -

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Stephen Kitt
On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint wrote: >From: Sam Ravnborg > >The atmel_lcdfb had code to save/restore power state. >This is not needed so drop it. > >Introduce backlight_is_brightness() to make logic simpler. > >Signed-off-by: Sam Ravnborg >Cc: Nicolas

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-07 Thread 吴涛@Eng
On Sat, Jan 7, 2023 at 2:45 AM Simon Ser wrote: > > On Friday, January 6th, 2023 at 23:28, Tao Wu wrote: > > > On Fri, Jan 6, 2023 at 1:54 AM Daniel Vetter dan...@ffwll.ch wrote: > > > > > On Thu, Jan 05, 2023 at 01:40:28PM -0800, Tao Wu(吴涛@Eng) wrote: > > > > > > > Hi Daniel, > > > > > > > >

Re: [PATCH] drm: rcar-du: depend on ARCH_RENESAS for components on that SoC

2023-01-07 Thread Laurent Pinchart
Hi Peter, On Sun, Jan 08, 2023 at 04:50:48AM +, Peter Robinson wrote: > > On Sun, Jan 08, 2023 at 04:31:47AM +, Peter Robinson wrote: > > > There's a few components in the rcar-du drm directory that > > > don't make sense to be slectedable if ARCH_RENESAS isn't because > > > >

Re: [PATCH] drm: rcar-du: depend on ARCH_RENESAS for components on that SoC

2023-01-07 Thread Peter Robinson
Hi Laurent, > Thank you for the patch. > > On Sun, Jan 08, 2023 at 04:31:47AM +, Peter Robinson wrote: > > There's a few components in the rcar-du drm directory that > > don't make sense to be slectedable if ARCH_RENESAS isn't because > > s/slectedable/selectable/ > > > they are part of those

Re: [PATCH] drm: rcar-du: depend on ARCH_RENESAS for components on that SoC

2023-01-07 Thread Laurent Pinchart
Hi Peter, Thank you for the patch. On Sun, Jan 08, 2023 at 04:31:47AM +, Peter Robinson wrote: > There's a few components in the rcar-du drm directory that > don't make sense to be slectedable if ARCH_RENESAS isn't because s/slectedable/selectable/ > they are part of those SoCs so add a

[PATCH] drm: rcar-du: depend on ARCH_RENESAS for components on that SoC

2023-01-07 Thread Peter Robinson
There's a few components in the rcar-du drm directory that don't make sense to be slectedable if ARCH_RENESAS isn't because they are part of those SoCs so add a dependency and add compile check to ensure they're still tested. Signed-off-by: Peter Robinson --- drivers/gpu/drm/rcar-du/Kconfig | 3

Re: [PATCH AUTOSEL 5.15 24/27] Revert "drm/amdgpu: Revert "drm/amdgpu: getting fan speed pwm for vega10 properly""

2023-01-07 Thread Yury Zhuravlev
Sorry, but do anybody know about this? I hope my message is not lost. On Tue, Jan 3, 2023 at 9:38 PM Yury Zhuravlev wrote: > Hello! > > Why is this revert for revert coming for 6.1 but reverted again for 6.1.2? > My GPU is not working correctly again! >

linux-next: duplicate patches in the drm tree

2023-01-07 Thread Stephen Rothwell
Hi all, The following commits are also in Linus Torvalds' tree as different commits (but the same patches): 9f1ecfc5dcb4 ("drm/scheduler: Fix lockup in drm_sched_entity_kill()") 4333472f8d7b ("drm/imx: ipuv3-plane: Fix overlay plane width") (in fact the first of these is in Linus' tree

Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness()

2023-01-07 Thread Miguel Ojeda
On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint wrote: > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. Note: Stephen sent this one too a while ago (with some more details in the commit message, which is always

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Sam Ravnborg
Hi Stephen. On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: > On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint > wrote: > >From: Sam Ravnborg > > > >The atmel_lcdfb had code to save/restore power state. > >This is not needed so drop it. > > > >Introduce

Re: [PATCH 2/2] drm/panel: boe-tv101wum-nl6: Reduce lcm_reset to send initial code time

2023-01-07 Thread Sam Ravnborg
On Fri, Jan 06, 2023 at 11:05:21AM +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Since the panel spec stipulates that the time from lcm_reset to DSI to > send the initial code should be greater than 6ms and less than 40ms, > so reduce the delay before sending the initial code and

Re: [PATCH] drm/amd/display: No need for Null pointer check before kfree

2023-01-07 Thread Deepak R Varma
On Wed, Dec 28, 2022 at 12:09:51AM +0530, Deepak R Varma wrote: > kfree() & vfree() internally performs NULL check on the pointer handed > to it and take no action if it indeed is NULL. Hence there is no need > for a pre-check of the memory pointer before handing it to > kfree()/vfree(). > > Issue

Re: [PATCH 1/2] drm/mediatek: dsi: Reduce the time of dsi from LP11 to sending cmd

2023-01-07 Thread Sam Ravnborg
On Fri, Jan 06, 2023 at 11:05:20AM +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > According to Figure 16 Turnaround Procedure on page 36 in [1], you > can see the status of LP-00 -> LP10 -> LP11. This state can correspond > to the state of DSI from LP00 -> LP11 in

Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable

2023-01-07 Thread Sam Ravnborg
Hi Stephen. On Thu, Jan 05, 2023 at 07:01:08PM -0800, Stephen Boyd wrote: > The unprepare sequence has started to fail after moving to panel bridge > code in the msm drm driver (commit 007ac0262b0d ("drm/msm/dsi: switch to > DRM_PANEL_BRIDGE")). You'll see messages like this in the kernel logs: >

Re: [PATCH] drm/nouveau/hwmon: Use sysfs_emit in show function callsbacks

2023-01-07 Thread Deepak R Varma
On Sun, Dec 25, 2022 at 02:32:08PM +0530, Deepak R Varma wrote: > According to Documentation/filesystems/sysfs.rst, the show() callback > function of kobject attributes should strictly use sysfs_emit() instead > of sprintf() family functions. So, make this change. > Issue identified using the

Re: [PATCH] drm/amdkfd: Use resource_size() helper function

2023-01-07 Thread Deepak R Varma
On Fri, Dec 23, 2022 at 02:45:00AM +0530, Deepak R Varma wrote: > Use the resource_size() function instead of a open coded computation > resource size. It makes the code more readable. > > Issue identified using resource_size.cocci coccinelle semantic patch. > > Signed-off-by: Deepak R Varma >

Re: [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-07 Thread Deepak R Varma
On Thu, Jan 05, 2023 at 09:13:35AM +0100, Julia Lawall wrote: > > Hi Julia, thanks for helping here. > > > > So, my question is why this > > > > make coccicheck M=drivers/gpu/drm/i915/ MODE=context > > COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > > > didn't catch this

[PATCH v2 12/13] drm/panel-sony-tulip-truly-nt35521: Drop custom DSI write macro

2023-01-07 Thread Javier Martinez Canillas
There is a macro for this already in the header, use that instead and delete the custom DSI write macro defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag. - Fix identation on macro usage (Sam

[PATCH v2 13/13] drm/panel-xinpeng-xpp055c272: Drop custom DSI write macro

2023-01-07 Thread Javier Martinez Canillas
There is a macro for this already in the header, use that instead and delete the custom DSI write macro defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag. - Fix identation on macro usage (Sam

[PATCH v2 11/13] drm/panel-mantix-mlaf057we51: Drop custom DSI write macro

2023-01-07 Thread Javier Martinez Canillas
There is a macro for this already in the header, use that instead and delete the custom DSI write macro defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag.

[PATCH v2 10/13] drm/panel-sharp-ls060t1sx01: Drop custom DSI write macro

2023-01-07 Thread Javier Martinez Canillas
There is a macro for this already in the header, use that instead and delete the custom DSI write macro defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag.

[PATCH v2 07/13] drm/panel-jdi-fhd-r63452: Drop custom DSI write macros

2023-01-07 Thread Javier Martinez Canillas
There are macros for these already in the header, use that instead and delete the custom DSI write macros defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag. - Fix identation on macro usage (Sam

[PATCH v2 09/13] drm/panel-samsung-sofef00: Drop custom DSI write macro

2023-01-07 Thread Javier Martinez Canillas
There is a macro for this already in the header, use that instead and delete the custom DSI write macro defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag.

[PATCH v2 05/13] drm/panel-boe-bf060y8m-aj0: Drop custom DSI write macro

2023-01-07 Thread Javier Martinez Canillas
There is a macro for this already in the header, use that instead and delete the custom DSI write macro defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag. - Fix identation on macro usage (Sam

[PATCH v2 06/13] drm/panel-novatek-nt35950: Drop custom DSI write macro

2023-01-07 Thread Javier Martinez Canillas
There is a macro for this already in the header, use that instead and delete the custom DSI write macro defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag.

[PATCH v2 08/13] drm/panel-samsung-s6e88a0-ams452ef01: Drop custom DSI write macro

2023-01-07 Thread Javier Martinez Canillas
There is a macro for this already in the header, use that instead and delete the custom DSI write macro defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag. - Fix identation on macro usage (Sam

[PATCH v2 01/13] drm/panel-asus-z00t-tm5p5-n35596: Drop custom DSI write macros

2023-01-07 Thread Javier Martinez Canillas
There are macros for these already in the header, use that instead and delete the custom DSI write macros defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag.

[PATCH v2 03/13] drm/panel-leadtek-ltk050h3146w: Drop custom DSI write macro

2023-01-07 Thread Javier Martinez Canillas
There is a macro for this already in the header, use that instead and delete the custom DSI write macro defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag. - Fix identation on macro usage (Sam

[PATCH v2 04/13] drm/panel-elida-kd35t133: Drop custom DSI write macro

2023-01-07 Thread Javier Martinez Canillas
There is a macro for this already in the header, use that instead and delete the custom DSI write macro defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag. - Fix identation on macro usage (Sam

[PATCH v2 02/13] drm/panel-sitronix-st7703: Drop custom DSI write macros

2023-01-07 Thread Javier Martinez Canillas
There are macros for these already in the header, use that instead and delete the custom DSI write macros defined in the driver. Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg --- Changes in v2: - Add Sam Ravnborg's Reviewed-by tag. - Fix identation on macro usage (Sam

[PATCH v2 00/13] drm/panel: Make panel drivers use existing DSI write macros

2023-01-07 Thread Javier Martinez Canillas
Hello, This series contains cleanups for DRM panel drivers that define their own DSI write macros instead of using what's already in . This is a v2 that addresses issues pointed out by Sam Ravnborg in the v1: https://lore.kernel.org/lkml/20221228014757.3170486-1-javi...@redhat.com/ The changes

[PATCH] habanalabs: remove redundant memset

2023-01-07 Thread Tom Rix
>From reviewing the code, the line memset(kdata, 0, usize); is not needed because kdata is either zeroed by kdata = kzalloc(asize, GFP_KERNEL); when allocated at runtime or by char stack_kdata[128] = {0}; at compile time. Signed-off-by: Tom Rix ---

[PATCH 05/15] video: fbdev: riva: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Antonino Daplas Cc: linux-fb...@vger.kernel.org --- drivers/video/fbdev/riva/fbdev.c | 8 +--- 1 file changed, 1 insertion(+), 7

[PATCH 06/15] video: fbdev: aty128fb: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Paul Mackerras Cc: linux-fb...@vger.kernel.org --- drivers/video/fbdev/aty/aty128fb.c | 11 ++- 1 file changed, 2 insertions(+),

[PATCH 03/15] video: fbdev: nvidia: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Antonino Daplas Cc: linux-fb...@vger.kernel.org --- drivers/video/fbdev/nvidia/nv_backlight.c | 8 +--- 1 file changed, 1

[PATCH 08/15] video: fbdev: omap2: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Allison Randal Cc: Sam Ravnborg Cc: Greg Kroah-Hartman Cc: Kate Stewart Cc: Thomas Gleixner Cc: Enrico Weigelt Cc: Alexios Zavras

[PATCH 14/15] backlight: tosa: Use backlight helper

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Stephen Kitt Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt

[PATCH 13/15] backlight: omap1: Use backlight helpers

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Rework backlight handling to avoid access to the deprecated backlight_properties.fb_blank member. The rework includes removal of get_brightness() operation, because there was no read back from HW so no use for it. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel

[PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Robin van der Gracht Cc: Miguel Ojeda Cc: Geert Uytterhoeven --- drivers/auxdisplay/ht16k33.c | 7 +-- 1 file changed, 1

[PATCH 00/15] backlight: Drop use of deprecated fb_blank property

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
| 22 --- 17 files changed, 41 insertions(+), 211 deletions(-) --- base-commit: a53be8dae86fe5d3567db245177e814e58210632 change-id: 20230107-sam-video-backlight-drop-fb_blank-d6feb73572ff Best regards, -- Sam Ravnborg

[PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg With all users gone remove the deprecated fb_blank member in backlight_properties. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 2 -- include/linux/backlight.h | 22

[PATCH 10/15] staging: fbtft: core: Introduce backlight_is_blank()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Avoiding direct access to backlight_properties.props. Access to the deprecated props.fb_blank replaced by backlight_is_blank(). Access to props.power is dropped - it was only used for debug. Signed-off-by: Sam Ravnborg Cc: Thomas Zimmermann Cc: Andy Shevchenko Cc: Javier

[PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg The atmel_lcdfb had code to save/restore power state. This is not needed so drop it. Introduce backlight_is_brightness() to make logic simpler. Signed-off-by: Sam Ravnborg Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: linux-fb...@vger.kernel.org Cc:

[PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Avoiding direct access to backlight_properties.props. Access to the deprecated props.fb_blank replaced by backlight_is_blank(). Access to props.power is dropped - it was only used for debug. Signed-off-by: Sam Ravnborg Cc: Stephen Kitt Cc: Greg Kroah-Hartman Cc: Daniel

[PATCH 11/15] powerpc: via-pmu-backlight: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Benjamin Herrenschmidt Cc: Sam Ravnborg Cc: linuxppc-...@lists.ozlabs.org --- drivers/macintosh/via-pmu-backlight.c | 7 +-- 1 file

[PATCH 07/15] video: fbdev: mx3fb: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: Kate Stewart Cc: Thomas Gleixner Cc: Laurent Pinchart Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: Jani Nikula ---

[PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Bartlomiej Zolnierkiewicz Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Souptick Joarder Cc: Maarten Lankhorst Cc: Jason Yan Cc: Jani Nikula

[PATCH 04/15] video: fbdev: radeon: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Benjamin Herrenschmidt Cc: linux-fb...@vger.kernel.org --- drivers/video/fbdev/aty/radeon_backlight.c | 10 +++--- 1 file changed, 3

Re: [PATCH v2 2/2] drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro

2023-01-07 Thread Javier Martinez Canillas
On 1/2/23 21:25, Javier Martinez Canillas wrote: > Many panel drivers define dsi_dcs_write_seq() and dsi_generic_write_seq() > macros to send DCS commands and generic write packets respectively, with > the payload specified as a list of parameters instead of using arrays. > > There's already a

Re: [PATCH v2 1/2] drm/mipi-dsi: Fix mipi_dsi_dcs_write_seq() macro definition format

2023-01-07 Thread Javier Martinez Canillas
On 1/2/23 21:30, Sam Ravnborg wrote: > On Mon, Jan 02, 2023 at 09:25:41PM +0100, Javier Martinez Canillas wrote: >> Change made using a `clang-format -i include/drm/drm_mipi_dsi.h` command. >> >> Suggested-by: Sam Ravnborg >> Signed-off-by: Javier Martinez Canillas > > Thanks, > > Reviewed-by:

[PATCH v5 06/10] drm: Remove usage of deprecated DRM_DEBUG_DRIVER

2023-01-07 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_DRIVER is deprecated. Thus, use newer drm_dbg_driver(). Also fix the deprecation comment in drm_print.h which mentions drm_dbg() instead of drm_dbg_driver(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_mipi_dbi.c | 10 +- include/drm/drm_print.h

[PATCH v5 08/10] drm: Remove usage of deprecated DRM_DEBUG_PRIME

2023-01-07 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_PRIME is deprecated in favor of drm_dbg_prime(). Signed-off-by: Siddh Raman Pant Reviewed-by: Simon Ser --- drivers/gpu/drm/drm_gem_dma_helper.c | 4 ++-- drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v5 04/10] drm: Remove usage of deprecated DRM_ERROR

2023-01-07 Thread Siddh Raman Pant
drm_print.h says DRM_ERROR is deprecated in favor of drm_err(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_bridge.c | 8 drivers/gpu/drm/drm_bufs.c | 8 drivers/gpu/drm/drm_client_modeset.c | 4 ++-- drivers/gpu/drm/drm_context.c| 4

[PATCH v5 01/10] drm/print: Fix and add support for NULL as first argument in drm_* macros

2023-01-07 Thread Siddh Raman Pant
Comments say macros DRM_DEBUG_* are deprecated in favor of drm_dbg_*(NULL, ...), but they have broken support for it, as the macro will result in `(NULL) ? (NULL)->dev : NULL`. Thus, fix them by separating logic to get dev ptr in a new function, which will return the dev ptr if arg is not NULL.

[PATCH v5 02/10] drm: Remove usage of deprecated DRM_INFO

2023-01-07 Thread Siddh Raman Pant
drm_print.h says DRM_INFO is deprecated in favor of drm_info(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_client_modeset.c | 2 +- drivers/gpu/drm/drm_connector.c | 7 --- drivers/gpu/drm/drm_drv.c| 2 +- drivers/gpu/drm/drm_pci.c| 2 +- 4 files

[PATCH v5 07/10] drm: Remove usage of deprecated DRM_DEBUG_KMS

2023-01-07 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_KMS is deprecated in favor of drm_dbg_kms(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_client_modeset.c | 112 ++--- drivers/gpu/drm/drm_color_mgmt.c | 4 +- drivers/gpu/drm/drm_connector.c| 21 ++---

[PATCH v5 09/10] drm/drm_blend: Remove usage of deprecated DRM_DEBUG_ATOMIC

2023-01-07 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_ATOMIC is deprecated in favor of drm_dbg_atomic(). Signed-off-by: Siddh Raman Pant Reviewed-by: Simon Ser --- drivers/gpu/drm/drm_blend.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_blend.c

[PATCH v5 05/10] drm: Remove usage of deprecated DRM_DEBUG

2023-01-07 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG is deprecated in favor of drm_dbg_core(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_agpsupport.c | 4 +- drivers/gpu/drm/drm_bufs.c| 114 +++--- drivers/gpu/drm/drm_context.c | 14 ++-- drivers/gpu/drm/drm_dma.c

[PATCH v5 10/10] drm/drm_lease: Remove usage of deprecated DRM_DEBUG_LEASE

2023-01-07 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_LEASE is deprecated in favor of drm_dbg_lease(). Signed-off-by: Siddh Raman Pant Reviewed-by: Simon Ser --- drivers/gpu/drm/drm_lease.c | 64 - 1 file changed, 34 insertions(+), 30 deletions(-) diff --git

[PATCH v5 00/10] drm: Remove usage of deprecated DRM_* macros

2023-01-07 Thread Siddh Raman Pant
This patchset aims to remove usages of deprecated DRM_* macros from the files residing in drivers/gpu/drm root. In process, I found out that NULL as first argument of drm_dbg_* wasn't working, but it was listed as the alternative in deprecation comment, so I fixed that before removing usages of

[PATCH v5 03/10] drm: Remove usage of deprecated DRM_NOTE

2023-01-07 Thread Siddh Raman Pant
drm_print.h says DRM_NOTE is deprecated in favor of drm_notice(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_displayid.c | 2 +- drivers/gpu/drm/drm_kms_helper_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_displayid.c

[Bug 216899] New: amdgpu ring timeout after gfxoff on Navi 24 beige_goby

2023-01-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216899 Bug ID: 216899 Summary: amdgpu ring timeout after gfxoff on Navi 24 beige_goby Product: Drivers Version: 2.5 Kernel Version: 6.1.2-gentoo Hardware: Intel OS: Linux

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-07 Thread Hang Zhang
On Fri, Jan 6, 2023 at 5:46 PM Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 05:12:57PM -0500, Hang Zhang wrote: > > On Fri, Jan 6, 2023 at 4:19 PM Daniel Vetter wrote: > > > On Fri, Jan 06, 2023 at 03:25:14PM -0500, Hang Zhang wrote: > > > > On Fri, Jan 6, 2023 at 3:05 PM Daniel Vetter

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-07 Thread Hang Zhang
On Fri, Jan 6, 2023 at 3:05 PM Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 02:58:27PM -0500, Hang Zhang wrote: > > On Fri, Jan 6, 2023 at 1:59 PM Daniel Vetter wrote: > > > > > > On Thu, Jan 05, 2023 at 01:38:54PM -0500, Hang Zhang wrote: > > > > On Thu, Jan 5, 2023 at 5:25 AM Daniel Vetter

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-07 Thread Hang Zhang
On Fri, Jan 6, 2023 at 1:59 PM Daniel Vetter wrote: > > On Thu, Jan 05, 2023 at 01:38:54PM -0500, Hang Zhang wrote: > > On Thu, Jan 5, 2023 at 5:25 AM Daniel Vetter wrote: > > > > > > On Thu, 5 Jan 2023 at 11:21, Daniel Vetter wrote: > > > > > > > > Hi Helge > > > > > > > > On Mon, 2 Jan 2023

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-07 Thread Hang Zhang
On Fri, Jan 6, 2023 at 4:19 PM Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 03:25:14PM -0500, Hang Zhang wrote: > > On Fri, Jan 6, 2023 at 3:05 PM Daniel Vetter wrote: > > > On Fri, Jan 06, 2023 at 02:58:27PM -0500, Hang Zhang wrote: > > > > On Fri, Jan 6, 2023 at 1:59 PM Daniel Vetter

[PATCH] drm: Alloc high address for drm buddy topdown flag

2023-01-07 Thread Arunpravin Paneer Selvam
As we are observing low numbers in viewperf graphics benchmark, we are strictly not allowing the top down flag enabled allocations to steal the memory space from cpu visible region. The approach is, we are sorting each order list entries in ascending order and compare the last entry of each order

Re: [PATCH v2 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable"

2023-01-07 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 05:27:33PM -0800, Brian Norris wrote: > On Fri, Jan 6, 2023 at 5:23 PM Brian Norris wrote: > > v2: > > * add 'ret != 0' warning case for self-refresh > > * describe failing test case and relation to drm/rockchip patch better > > Ugh, there's always something you

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-07 Thread Simon Ser
On Friday, January 6th, 2023 at 23:28, Tao Wu wrote: > On Fri, Jan 6, 2023 at 1:54 AM Daniel Vetter dan...@ffwll.ch wrote: > > > On Thu, Jan 05, 2023 at 01:40:28PM -0800, Tao Wu(吴涛@Eng) wrote: > > > > > Hi Daniel, > > > > > > May I know what's the requirement for adding render node support to

[PATCH v8 9/9] drm/bridge: it6505: Register Type C mode switches

2023-01-07 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant port are available in Device Tree. Configure the "lane_swap" state based on the entered alternate mode for a specific Type-C connector, which ends up updating the lane swap registers of the it6505 chip. Signed-off-by:

[PATCH v8 8/9] drm/bridge: it6505: Fix Kconfig indentation

2023-01-07 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin --- (no changes since v7) Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/Kconfig

[PATCH v8 6/9] drm/bridge: anx7625: Register Type C mode switches

2023-01-07 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant port are available in Device Tree. Configure the crosspoint switch based on the entered alternate mode for a specific Type-C connector. Signed-off-by: Pin-yen Lin --- (no changes since v7) Changes in v7: - Fixed

[PATCH v8 7/9] dt/bindings: display: bridge: it6505: Add mode-switch support

2023-01-07 Thread Pin-yen Lin
ITE IT6505 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints.

[PATCH v8 5/9] drm/bridge: anx7625: Check for Type-C during panel registration

2023-01-07 Thread Pin-yen Lin
The output port endpoints can be connected to USB-C connectors. Running drm_of_find_panel_or_bridge() with such endpoints leads to a continuous return value of -EPROBE_DEFER, even though there is no panel present. To avoid this, check for the existence of a "mode-switch" property in the port

[PATCH v8 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-01-07 Thread Pin-yen Lin
Analogix 7625 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints.

[PATCH v8 3/9] drm/display: Add Type-C switch helpers

2023-01-07 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "data-lanes" properties are available in Device Tree. Signed-off-by: Pin-yen Lin

[PATCH v8 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-01-07 Thread Pin-yen Lin
From: Prashant Malani When using OF graph, the fw_devlink code will create links between the individual port driver (cros-ec-typec here) and the parent device for a Type-C switch (like mode-switch). Since the mode-switch will in turn have the usb-c-connector (i.e the child of the port driver) as

[PATCH v8 1/9] device property: Add remote endpoint to devcon matcher

2023-01-07 Thread Pin-yen Lin
From: Prashant Malani When searching the device graph for device matches, check the remote-endpoint itself for a match. Some drivers register devices for individual endpoints. This allows the matcher code to evaluate those for a match too, instead of only looking at the remote parent devices.

[PATCH v8 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-07 Thread Pin-yen Lin
This series introduces bindings for anx7625/it6505 to register Type-C mode-switch in their output endpoints, and use data-lanes property to describe the pin connections. The first two patch modifies fwnode_graph_devcon_matches and cros_typec_init_ports to enable the registration of the

Re: [PATCH v7 7/9] dt/bindings: drm/bridge: it6505: Add mode-switch support

2023-01-07 Thread Pin-yen Lin
Hi Krzysztof, Thanks for the review. On Fri, Jan 6, 2023 at 8:48 PM Krzysztof Kozlowski wrote: > > On 05/01/2023 14:24, Pin-yen Lin wrote: > > ITE IT6505 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB Type-C DisplayPort alternate mode > > lane or

Re: [PATCH v7 3/9] drm/display: Add Type-C switch helpers

2023-01-07 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Thu, Jan 5, 2023 at 11:41 PM Andy Shevchenko wrote: > > On Thu, Jan 05, 2023 at 09:24:51PM +0800, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output between two downstream devices.

Re: [PATCH v7 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-01-07 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Thu, Jan 5, 2023 at 11:34 PM Andy Shevchenko wrote: > > On Thu, Jan 05, 2023 at 09:24:50PM +0800, Pin-yen Lin wrote: > > From: Prashant Malani > > > > When using OF graph, the fw_devlink code will create links between the > > individual port driver

  1   2   >