Re: [PATCH 0/4] Track exported dma-buffers with memcg

2023-01-11 Thread Shakeel Butt
On Wed, Jan 11, 2023 at 11:56:45PM +0100, Daniel Vetter wrote: > [...] > I think eventually, at least for other "account gpu stuff in cgroups" use > case we do want to actually charge the memory. > > The problem is a bit that with gpu allocations reclaim is essentially "we > pass the error to use

Re: [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device

2023-01-11 Thread Thomas Zimmermann
Hi Am 11.01.23 um 20:21 schrieb Aaron Plattner: On 1/11/23 8:58 AM, Javier Martinez Canillas wrote: Hello Daniel, On 1/11/23 16:41, Daniel Vetter wrote: This fixes a regression introduced by ee7a69aa38d8 ("fbdev: Disable sysfb device registration when removing conflicting FBs"), where we remo

Re: [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device

2023-01-11 Thread Thomas Zimmermann
Hi Am 11.01.23 um 17:37 schrieb Daniel Vetter: On Wed, Jan 11, 2023 at 05:20:00PM +0100, Thomas Zimmermann wrote: Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: This fixes a regression introduced by ee7a69aa38d8 ("fbdev: Disable sysfb device registration when removing conflicting FBs"), where

Re: [PATCH 2/2] drm/panel: boe-tv101wum-nl6: Reduce lcm_reset to send initial code time

2023-01-11 Thread 李昕磊

Re: [PATCH 0/6] Enable KFD to use render node BO mappings

2023-01-11 Thread Christian König
Am 12.01.23 um 02:31 schrieb Felix Kuehling: Rebased on latest amd-staging-drm-next. This is meant to be the final review of this series, assuming no more issues are found. This patch series enables KFD to interoperate more closely with DRM render nodes. ROCm user mode already uses DRM render no

Re: [PATCH v1 2/2] drm/virtio: Add the hotplug_mode_update property for rescanning of modes

2023-01-11 Thread Gerd Hoffmann
Hi, > > > I think we need to do a bit of refactoring/documenting here first. > > [Kasireddy, Vivek] Just for reference, here is Dave's commit that added this > > property for qxl: > > commit 4695b03970df378dcb93fe3e7158381f1e980fa2 > > Author: Dave Airlie > > Date: Fri Oct 11 11:05:00 2013 +1

Re: [PATCH 1/1] drm/ttm: Fix of rework on ttm_resource to use size_t type commit

2023-01-11 Thread Christian König
Am 11.01.23 um 23:45 schrieb Kevin Brace: From: Kevin Brace Commit e3c92eb4a84fb0f00442e6b5cabf4f11b0eaaf41 (drm/ttm: rework on ttm_resource to use size_t type) reworked ttm_resource{} to use size_t type size instead of unsigned long type num_pages. In that commit, when ttm_move_memcpy() is be

Re: [PATCH] drm/ttm: Fix a regression causing kernel oops'es

2023-01-11 Thread Christian König
Am 11.01.23 um 18:50 schrieb Zack Rusin: From: Zack Rusin The branch is explicitly taken if ttm == NULL which means that to avoid a null pointer reference the ttm object can not be used inside. Switch back to dst_mem to avoid kernel oops'es. This fixes kernel oops'es with any buffer objects wh

RE: [PATCH] drm/amd/display: fix possible buffer overflow relating to secure display

2023-01-11 Thread Liu, HaoPing (Alan)
[AMD Official Use Only - General] Reviewed-by: Alan Liu Thanks, Alan -Original Message- From: Mahfooz, Hamza Sent: Thursday, January 12, 2023 2:17 AM To: amd-...@lists.freedesktop.org Cc: Mahfooz, Hamza ; Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Deucher, Alexander

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-11 Thread Dmitry Baryshkov
On 12/01/2023 07:48, Pin-yen Lin wrote: On Thu, Jan 12, 2023 at 1:24 PM Dmitry Baryshkov wrote: On 12/01/2023 07:19, Pin-yen Lin wrote: Hi Dmitry, Thanks for the review. On Thu, Jan 12, 2023 at 12:40 PM Dmitry Baryshkov wrote: On 12/01/2023 06:20, Pin-yen Lin wrote: Add helpers to regis

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-11 Thread Pin-yen Lin
On Thu, Jan 12, 2023 at 1:24 PM Dmitry Baryshkov wrote: > > On 12/01/2023 07:19, Pin-yen Lin wrote: > > Hi Dmitry, > > > > Thanks for the review. > > > > On Thu, Jan 12, 2023 at 12:40 PM Dmitry Baryshkov > > wrote: > >> > >> On 12/01/2023 06:20, Pin-yen Lin wrote: > >>> Add helpers to register an

[PATCH] drm/msm/dpu: merge two CRTC debugfs dirs

2023-01-11 Thread Dmitry Baryshkov
For each CRTC we are creating two different debugfs directories one using crtc index (created automatically for the CRC files) and another one using CRTC name/object ID (for state and status files). This can be confusing, so move our custom files to crtc->debugfs_entry, effetively merging two debu

Re: [PATCH v10 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-01-11 Thread Dmitry Baryshkov
On Thu, 12 Jan 2023 at 07:26, Pin-yen Lin wrote: > > Hi Dmitry, > > Thanks for the review. > > On Thu, Jan 12, 2023 at 12:43 PM Dmitry Baryshkov > wrote: > > > > On 12/01/2023 06:20, Pin-yen Lin wrote: > > > Analogix 7625 can be used in systems to switch the DP traffic between > > > two downstrea

Re: [PATCH v10 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-01-11 Thread Pin-yen Lin
Hi Dmitry, Thanks for the review. On Thu, Jan 12, 2023 at 12:43 PM Dmitry Baryshkov wrote: > > On 12/01/2023 06:20, Pin-yen Lin wrote: > > Analogix 7625 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB Type-C DisplayPort alternate mode > > lane or reg

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-11 Thread Dmitry Baryshkov
On 12/01/2023 07:19, Pin-yen Lin wrote: Hi Dmitry, Thanks for the review. On Thu, Jan 12, 2023 at 12:40 PM Dmitry Baryshkov wrote: On 12/01/2023 06:20, Pin-yen Lin wrote: Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downs

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-11 Thread Pin-yen Lin
Hi Dmitry, Thanks for the review. On Thu, Jan 12, 2023 at 12:40 PM Dmitry Baryshkov wrote: > > On 12/01/2023 06:20, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output between two downstream devices. > > > > The helper

Re: [PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-11 Thread Pin-yen Lin
Hi Dmitry, On Thu, Jan 12, 2023 at 12:34 PM Dmitry Baryshkov wrote: > > On 12/01/2023 06:20, Pin-yen Lin wrote: > > > > This series introduces bindings for anx7625/it6505 to register Type-C > > mode-switch in their output endpoints, and use data-lanes property to > > describe the pin connections.

Re: [PATCH v10 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-01-11 Thread Dmitry Baryshkov
On 12/01/2023 06:20, Pin-yen Lin wrote: Analogix 7625 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-11 Thread Dmitry Baryshkov
On 12/01/2023 06:20, Pin-yen Lin wrote: Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "data-lanes" properties are available in Dev

Re: [PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-11 Thread Dmitry Baryshkov
On 12/01/2023 06:20, Pin-yen Lin wrote: This series introduces bindings for anx7625/it6505 to register Type-C mode-switch in their output endpoints, and use data-lanes property to describe the pin connections. Please cc everybody on all patches. Having received just a single patch made me spe

[PATCH v10 9/9] drm/bridge: it6505: Register Type C mode switches

2023-01-11 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant port are available in Device Tree. Configure the "lane_swap" state based on the entered alternate mode for a specific Type-C connector, which ends up updating the lane swap registers of the it6505 chip. Signed-off-by: P

[PATCH v10 8/9] drm/bridge: it6505: Fix Kconfig indentation

2023-01-11 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin Reviewed-by: AngeloGioacchino Del Regno --- Changes in v10: - Collected Reviewed-by tag Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1 file changed, 10 insertions(

[PATCH v10 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-01-11 Thread Pin-yen Lin
ITE IT6505 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints. Signed

[PATCH v10 6/9] drm/bridge: anx7625: Register Type C mode switches

2023-01-11 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant ports are available in Device Tree. Configure the crosspoint switch based on the entered alternate mode for a specific Type-C connector. Crosspoint switch can also be used for switching the output signal for different o

[PATCH v10 5/9] drm/bridge: anx7625: Check for Type-C during panel registration

2023-01-11 Thread Pin-yen Lin
The output port endpoints can be connected to USB-C connectors. Running drm_of_find_panel_or_bridge() with such endpoints leads to a continuous return value of -EPROBE_DEFER, even though there is no panel present. To avoid this, check for the existence of a "mode-switch" property in the port endpo

[PATCH v10 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-01-11 Thread Pin-yen Lin
Analogix 7625 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints. Als

[PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-11 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "data-lanes" properties are available in Device Tree. Signed-off-by: Pin-yen Lin Tes

[PATCH v10 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-01-11 Thread Pin-yen Lin
From: Prashant Malani When using OF graph, the fw_devlink code will create links between the individual port driver (cros-ec-typec here) and the parent device for a Type-C switch (like mode-switch). Since the mode-switch will in turn have the usb-c-connector (i.e the child of the port driver) as

[PATCH v10 1/9] device property: Add remote endpoint to devcon matcher

2023-01-11 Thread Pin-yen Lin
From: Prashant Malani When searching the device graph for device matches, check the remote-endpoint itself for a match. Some drivers register devices for individual endpoints. This allows the matcher code to evaluate those for a match too, instead of only looking at the remote parent devices. Th

[PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-11 Thread Pin-yen Lin
This series introduces bindings for anx7625/it6505 to register Type-C mode-switch in their output endpoints, and use data-lanes property to describe the pin connections. The first two patch modifies fwnode_graph_devcon_matches and cros_typec_init_ports to enable the registration of the switches.

Re: [PATCH v3 1/2] drm/msm/dsi: add a helper method to compute the dsi byte clk

2023-01-11 Thread Dmitry Baryshkov
On 12/01/2023 02:15, Abhinav Kumar wrote: Re-arrange the dsi_calc_pclk method to two helpers, one to compute the DSI byte clk and the other to compute the pclk. This makes the separation of the two clean and also allows clients to compute and use the dsi byte clk separately. changes in v2:

Re: [PATCH v3 2/2] drm/msm/dsi: implement opp table based check for dsi_mgr_bridge_mode_valid()

2023-01-11 Thread Dmitry Baryshkov
On 12/01/2023 02:16, Abhinav Kumar wrote: Currently there is no protection against a user trying to set an unsupported mode on DSI. Implement a check based on the opp table whether the byte clock for the mode can be supported by validating whether an opp table entry exists. For devices which hav

Re: [PATCH] drm/msm/dpu: Remove some unused variables

2023-01-11 Thread Dmitry Baryshkov
On 12/01/2023 05:38, Jiapeng Chong wrote: Variables 'sc8280xp_regdma' and 'sm8350_regdma' are defined in the dpu_hw_catalog.c file, but not used elsewhere, so remove these unused variables. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2029:37: warning: unused variable 'sc8280xp_regdma'. drive

[PATCH] drm/msm/dpu: Remove some unused variables

2023-01-11 Thread Jiapeng Chong
Variables 'sc8280xp_regdma' and 'sm8350_regdma' are defined in the dpu_hw_catalog.c file, but not used elsewhere, so remove these unused variables. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2029:37: warning: unused variable 'sc8280xp_regdma'. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:20

[pull] amdgpu, amdkfd drm-fixes-6.2

2023-01-11 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.2. The following changes since commit 93235bfd5a9c3329df31d1a4d7a93d138b3138c2: Merge tag 'amd-drm-fixes-6.2-2023-01-04' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2023-01-05 12:13:51 +0100) are available in the Git repository at: https://g

[PATCH] drm/amd/display: Remove useless else if

2023-01-11 Thread Jiapeng Chong
The assignment of the else and if branches is the same, so the if else here is redundant, so we remove it. ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:1951:2-4: WARNING: possible condition with no effect (if == else). Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3719 Reported-by:

Re: [Intel-gfx] [PATCH v3 1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version

2023-01-11 Thread Belgaumkar, Vinay
On 12/21/2022 9:49 AM, Alan Previn wrote: If PXP arb-session is being attempted on older hardware SKUs or on hardware with older, unsupported, firmware versions, then don't report the failure with a drm_error. Instead, look specifically for the API-version error reply and drm_dbg that reply. In

[PATCH v2 12/14] drm/amd/display: Do not add '-mhard-float' to dml_ccflags for clang

2023-01-11 Thread Nathan Chancellor
When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it warns: clang-16: error: argument unused during compilation: '-mhard-float' [-Werror,-Wunused-command-line-argument] Similar to commit 84edc2eff827 ("selftest/fpu: avoid clang warning"), just add this flag to GCC builds. Commit

[PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-11 Thread Nathan Chancellor
Hi all, Clang can emit a few different warnings when it encounters a flag that it recognizes but does not support internally. These warnings are elevated to errors within {as,cc}-option via -Werror to catch unsupported flags that should not be added to KBUILD_{A,C}FLAGS; see commit c3f0d0bc5b01 ("

[PATCH 4/4] drm/i915/guc: Add a debug print on GuC triggered reset

2023-01-11 Thread John . C . Harrison
From: John Harrison For understanding bug reports, it can be useful to have an explicit dmesg print when a reset notification is received from GuC. As opposed to simply inferring that this happened from other messages. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_submi

[PATCH 3/4] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-11 Thread John . C . Harrison
From: John Harrison Engine resets are supposed to never fail. But in the case when one does (due to unknown reasons that normally come down to a missing w/a), it is useful to get as much information out of the system as possible. Given that the GuC effectively dies on such a situation, it is not

[PATCH 2/4] drm/i915: Allow error capture of a pending request

2023-01-11 Thread John . C . Harrison
From: John Harrison A hang situation has been observed where the only requests on the context were either completed or not yet started according to the breaadcrumbs. However, the register state claimed a batch was (maybe) in progress. So, allow capture of the pending request on the grounds that t

[PATCH 1/4] drm/i915: Allow error capture without a request

2023-01-11 Thread John . C . Harrison
From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification' from GuC. The problem was not reproducible. However, it is possible to happen if the context in question has no active r

[PATCH 0/4] Allow error capture without a request / on reset failure

2023-01-11 Thread John . C . Harrison
From: John Harrison It is technically possible to get a hung context without a valid request. In such a situation, try to provide as much information in the error capture as possible rather than just aborting and capturing nothing. Similarly, in the case of an engine reset failure the GuC is not

Re: [PATCH 4/5] drm/vmwgfx: Remove redundant framebuffer format check

2023-01-11 Thread Zack Rusin
On Mon, 2023-01-09 at 07:58 -0300, Maíra Canal wrote: > Now that framebuffer_check() verifies that the format is properly > supported, there is no need to check it again on vmwgfx's inside > helpers. > > Therefore, remove the redundant framebuffer format check from the > vmw_kms_new_framebuffer_su

RE: [PATCH v11 0/3] drm: exynos: dsi: Restore the bridge chain

2023-01-11 Thread SR
Hi Jagan Teki, Sorry for late. > -Original Message- > From: Jagan Teki > Sent: Saturday, January 7, 2023 2:56 AM > To: Marek Szyprowski ; Inki Dae > ; Seung-Woo Kim ; Kyungmin Park > ; Neil Armstrong ; Robert > Foss ; Andrzej Hajda ; Sam > Ravnborg > Cc: Marek Vasut ; linux-samsung-...@

[PATCH 1/2] drm/i915/guc: Improve clean up of busyness stats worker

2023-01-11 Thread John . C . Harrison
From: John Harrison The stats worker thread management was mis-matched between enable/disable call sites. Fix those up. Also, abstract the cancel code into a helper function rather than replicating in multiple places. Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission

[PATCH 2/2] drm/i915/guc: Fix missing return code checks in submission init

2023-01-11 Thread John . C . Harrison
From: John Harrison The CI results for the 'fast request' patch set (enables error return codes for fire-and-forget H2G messages) hit an issue with the KMD sending context submission requests on an invalid context. That was caused by a fault injection probe failing the context creation of a kerne

[PATCH 0/2] Clean up some GuC related failure paths

2023-01-11 Thread John . C . Harrison
From: John Harrison Improve failure code handling during GuC intialisation. Signed-off-by: John Harrison John Harrison (2): drm/i915/guc: Improve clean up of busyness stats worker drm/i915/guc: Fix missing return code checks in submission init .../gpu/drm/i915/gt/uc/intel_guc_submission

[PATCH 5/6] drm/amdgpu: update mappings not managed by KFD

2023-01-11 Thread Felix Kuehling
When restoring after an eviction, use amdgpu_vm_handle_moved to update BO VA mappings in KFD VMs that are not managed through the KFD API. This should allow using the render node API to create more flexible memory mappings in KFD VMs. v2: Sync with pd fence after all page table updates v3: Update

[PATCH 6/6] drm/amdgpu: Do bo_va ref counting for KFD BOs

2023-01-11 Thread Felix Kuehling
This is needed to correctly handle BOs imported into the GEM API, which would otherwise get added twice to the same VM. Signed-off-by: Felix Kuehling --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 28 +++ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 3/6] drm/amdkfd: Improve amdgpu_vm_handle_moved

2023-01-11 Thread Felix Kuehling
Let amdgpu_vm_handle_moved update all BO VA mappings of BOs reserved by the caller. This will be useful for handling extra BO VA mappings in KFD VMs that are managed through the render node API. Signed-off-by: Felix Kuehling Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.

[PATCH 4/6] drm/amdgpu: Attach eviction fence on alloc

2023-01-11 Thread Felix Kuehling
Instead of attaching the eviction fence when a KFD BO is first mapped, attach it when it is allocated or imported. This in preparation to allow KFD BOs to be mapped using the render node API. Signed-off-by: Felix Kuehling --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 63 ++-

[PATCH 2/6] drm/amdkfd: Implement DMA buf fd export from KFD

2023-01-11 Thread Felix Kuehling
Exports a DMA buf fd of a given KFD buffer handle. This is intended for being able to import KFD BOs into GEM contexts to leverage the amdgpu_bo_va API for more flexible virtual address mappings. It will also be used for the new upstreamable RDMA solution coming to UCX and RCCL. The corresponding

[PATCH 0/6] Enable KFD to use render node BO mappings

2023-01-11 Thread Felix Kuehling
Rebased on latest amd-staging-drm-next. This is meant to be the final review of this series, assuming no more issues are found. This patch series enables KFD to interoperate more closely with DRM render nodes. ROCm user mode already uses DRM render nodes to create its GPU VM contexts and to CPU-ma

[PATCH 1/6] drm/amdgpu: Generalize KFD dmabuf import

2023-01-11 Thread Felix Kuehling
Use proper amdgpu_gem_prime_import function to handle all kinds of imports. Remember the dmabuf reference to enable proper multi-GPU attachment to multiple VMs without erroneously re-exporting the underlying BO multiple times. Signed-off-by: Felix Kuehling --- .../gpu/drm/amd/amdgpu/amdgpu_amdkf

Re: [PATCH 0/4] Track exported dma-buffers with memcg

2023-01-11 Thread T.J. Mercier
On Wed, Jan 11, 2023 at 2:56 PM Daniel Vetter wrote: > > On Mon, Jan 09, 2023 at 04:18:12PM -0800, Shakeel Butt wrote: > > Hi T.J., > > > > On Mon, Jan 9, 2023 at 1:38 PM T.J. Mercier wrote: > > > > > > Based on discussions at LPC, this series adds a memory.stat counter for > > > exported dmabufs

[PATCH v4 5/6] drm/i915/pxp: Trigger the global teardown for before suspending

2023-01-11 Thread Alan Previn
A driver bug was recently discovered where the security firmware was receiving internal HW signals indicating that session key expirations had occurred. Architecturally, the firmware was expecting a response from the GuC to acknowledge the event with the firmware side. However the OS was in a suspe

[PATCH v4 6/6] drm/i915/pxp: Pxp hw init should be in resume_complete

2023-01-11 Thread Alan Previn
During suspend flow, i915 currently achors' on the pm_suspend_prepare callback as the location where we quiesce the entire GPU and perform all necessary cleanup in order to go into suspend. PXP is also called during this time to perform the arbitration session teardown (with the assurance no additi

[PATCH v4 4/6] drm/i915/pxp: Invalidate all PXP fw sessions during teardown

2023-01-11 Thread Alan Previn
A gap was recently discovered where if an application did not invalidate all of the stream keys (intentionally or not), and the driver did a full PXP global teardown on the GT subsystem, we find that future session creation would fail on the security firmware's side of the equation. i915 is the ent

[PATCH v4 3/6] mei: clean pending read with vtag on bus

2023-01-11 Thread Alan Previn
From: Alexander Usyskin Client on bus have only one vtag map slot and should disregard the vtag value when cleaning pending read flag. Fixes read flow control message unexpectedly generated when clent on bus send messages with different vtags. Signed-off-by: Alexander Usyskin Signed-off-by: Ala

[PATCH v4 2/6] drm/i915/pxp: add device link between i915 and mei_pxp

2023-01-11 Thread Alan Previn
From: Alexander Usyskin Add device link with i915 as consumer and mei_pxp as supplier to ensure proper ordering of power flows. V2: condition on absence of heci_pxp to filter out DG Signed-off-by: Alexander Usyskin Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 7 +

[PATCH v4 1/6] mei: mei-me: resume device in prepare

2023-01-11 Thread Alan Previn
From: Alexander Usyskin Asynchronous runtime resume is not possible while the system is suspending. The power management subsystem resumes the device only in the suspend phase, not in the prepare phase. Force resume device in prepare to allow drivers on mei bus to communicate in their prepare cal

[PATCH v4 0/6] drm/i915/pxp: Add missing cleanup steps for PXP global-teardown

2023-01-11 Thread Alan Previn
A customer issue was recently discovered and in the process a gap in i915's PXP interaction with HW+FW architecure was also realized. This series adds those missing pieces. This fix includes changes where i915 calls into the mei component interface in order to submit requests to the security firmw

[PATCH v3 2/2] drm/msm/dsi: implement opp table based check for dsi_mgr_bridge_mode_valid()

2023-01-11 Thread Abhinav Kumar
Currently there is no protection against a user trying to set an unsupported mode on DSI. Implement a check based on the opp table whether the byte clock for the mode can be supported by validating whether an opp table entry exists. For devices which have not added opp table support yet, skip this

[PATCH v3 1/2] drm/msm/dsi: add a helper method to compute the dsi byte clk

2023-01-11 Thread Abhinav Kumar
Re-arrange the dsi_calc_pclk method to two helpers, one to compute the DSI byte clk and the other to compute the pclk. This makes the separation of the two clean and also allows clients to compute and use the dsi byte clk separately. changes in v2: - move the assignments to definition lin

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 --- Comment #8 from kolAflash (kolafl...@kolahilft.de) --- (In reply to Alex Deucher from comment #7) > do you still have the problem with: > CONFIG_DRM_FBDEV_EMULATION=n > in your .config? The problem unfortunately still exists with CONFIG_DRM_F

Re: [RFC PATCH 00/17] DRM_USE_DYNAMIC_DEBUG regression

2023-01-11 Thread Daniel Vetter
On Mon, Dec 05, 2022 at 05:34:07PM -0700, Jim Cromie wrote: > Hi everyone, > > DRM_USE_DYNAMIC_DEBUG=y has a regression on rc-* > > Regression is due to a chicken-egg problem loading modules; on > `modprobe i915`, drm is loaded 1st, and drm.debug is set. When > drm_debug_enabled() tested __drm_d

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dsi: implement opp table based check for dsi_mgr_bridge_mode_valid()

2023-01-11 Thread Abhinav Kumar
On 1/11/2023 2:56 PM, Dmitry Baryshkov wrote: On 12/01/2023 00:52, Abhinav Kumar wrote: Currently there is no protection against a user trying to set an unsupported mode on DSI. Implement a check based on the opp table whether the byte clock for the mode can be supported by validating whether

Re: [RFC PATCH 13/17] drm_print: fix stale macro-name in comment

2023-01-11 Thread Daniel Vetter
On Mon, Dec 05, 2022 at 05:34:20PM -0700, Jim Cromie wrote: > Cited commit uses stale macro name, fix this, and explain better. > > When DRM_USE_DYNAMIC_DEBUG=y, DYNDBG_CLASSMAP_DEFINE() maps DRM_UT_* > onto BITs in drm.debug. This still uses enum drm_debug_category, but > it is somewhat indirect

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2023 at 4:32 PM Matthew Brost wrote: > On Wed, Jan 11, 2023 at 04:18:01PM -0600, Jason Ekstrand wrote: > > On Wed, Jan 11, 2023 at 2:50 AM Tvrtko Ursulin < > > tvrtko.ursu...@linux.intel.com> wrote: > > > > > > > > On 10/01/2023 14:08, Jason Ekstrand wrote: > > > > On Tue, Jan 10,

Re: [PATCH v2 2/2] drm/msm/dsi: implement opp table based check for dsi_mgr_bridge_mode_valid()

2023-01-11 Thread Dmitry Baryshkov
On 12/01/2023 00:52, Abhinav Kumar wrote: Currently there is no protection against a user trying to set an unsupported mode on DSI. Implement a check based on the opp table whether the byte clock for the mode can be supported by validating whether an opp table entry exists. For devices which hav

Re: [PATCH 0/4] Track exported dma-buffers with memcg

2023-01-11 Thread Daniel Vetter
On Mon, Jan 09, 2023 at 04:18:12PM -0800, Shakeel Butt wrote: > Hi T.J., > > On Mon, Jan 9, 2023 at 1:38 PM T.J. Mercier wrote: > > > > Based on discussions at LPC, this series adds a memory.stat counter for > > exported dmabufs. This counter allows us to continue tracking > > system-wide total e

[PATCH v2 2/2] drm/msm/dsi: implement opp table based check for dsi_mgr_bridge_mode_valid()

2023-01-11 Thread Abhinav Kumar
Currently there is no protection against a user trying to set an unsupported mode on DSI. Implement a check based on the opp table whether the byte clock for the mode can be supported by validating whether an opp table entry exists. For devices which have not added opp table support yet, skip this

[PATCH v2 1/2] drm/msm/dsi: add a helper method to compute the dsi byte clk

2023-01-11 Thread Abhinav Kumar
Re-arrange the dsi_calc_pclk method to two helpers, one to compute the DSI byte clk and the other to compute the pclk. This makes the separation of the two clean and also allows clients to compute and use the dsi byte clk separately. changes in v2: - move the assignments to definition lin

[PATCH 1/1] drm/ttm: Fix of rework on ttm_resource to use size_t type commit

2023-01-11 Thread Kevin Brace
From: Kevin Brace Commit e3c92eb4a84fb0f00442e6b5cabf4f11b0eaaf41 (drm/ttm: rework on ttm_resource to use size_t type) reworked ttm_resource{} to use size_t type size instead of unsigned long type num_pages. In that commit, when ttm_move_memcpy() is being called from ttm_bo_move_memcpy(), the co

Re: [PATCH 5/5] drm/plane: Unexport drm_any_plane_has_format()

2023-01-11 Thread Daniel Vetter
On Mon, Jan 09, 2023 at 07:58:08AM -0300, Maíra Canal wrote: > As the format validation is being dealt with exclusively > inside framebuffer_check(), there is no need to export the > drm_any_plane_has_format() symbol. > > Therefore, unexport the drm_any_plane_has_format() symbol, reinforcing > tha

Re: [PATCH 1/5] drm/framebuffer: Check for valid formats

2023-01-11 Thread Daniel Vetter
On Mon, Jan 09, 2023 at 07:58:04AM -0300, Maíra Canal wrote: > Currently, framebuffer_check() doesn't check if the pixel format is > supported, which can lead to the acceptance of invalid pixel formats > e.g. the acceptance of invalid modifiers. Therefore, add a check for > valid formats on framebu

Re: [PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue()

2023-01-11 Thread Daniel Vetter
On Tue, Jan 10, 2023 at 11:24:47PM +0800, Jiasheng Jiang wrote: > Add drmm_alloc_workqueue() and drmm_alloc_ordered_workqueue(), the helpers > that provide managed workqueue cleanup. The workqueue will be destroyed > with the final reference of the DRM device. > > Signed-off-by: Jiasheng Jiang Y

[PATCH 0/1] DRM commit e3c92eb causes OpenChrome DRM to crash during boot

2023-01-11 Thread Kevin Brace
From: Kevin Brace Hi, I work on an out of the kernel tree DRM module for VIA Technologies Chrome integrated graphics (https://cgit.freedesktop.org/openchrome/drm-openchrome/), and DRM commit e3c92eb4a84fb0f00442e6b5cabf4f11b0eaaf41 (drm/ttm: rework on ttm_resource to use size_t type) definitely

Re: [PATCH 2/2] drm/debugfs: add descriptions to struct parameters

2023-01-11 Thread Daniel Vetter
On Mon, Jan 09, 2023 at 08:28:20AM -0300, Maíra Canal wrote: > On 1/6/23 17:19, Daniel Vetter wrote: > > On Thu, Jan 05, 2023 at 04:30:39PM -0300, Maíra Canal wrote: > > > The structs drm_debugfs_info and drm_debugfs_entry don't have > > > descriptions for their parameters, which is causing the fol

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 --- Comment #7 from Alex Deucher (alexdeuc...@gmail.com) --- do you still have the problem with: CONFIG_DRM_FBDEV_EMULATION=n in your .config? Does reverting a6250bdb6c4677ee77d699b338e077b900f94c0c fix it? -- You may reply to this email to add

Re: [PATCH v5 1/4] dt-bindings: display/msm: convert MDP5 schema to YAML format

2023-01-11 Thread Marijn Suijten
On 2023-01-12 00:31:33, Dmitry Baryshkov wrote: > On 12/01/2023 00:29, Marijn Suijten wrote: > > On 2023-01-10 06:40:27, Dmitry Baryshkov wrote: > >> On 09/01/2023 09:49, Marijn Suijten wrote: > >>> On 2023-01-09 07:01:49, Dmitry Baryshkov wrote: > > > +description: | > >>> > >>> Should m

Re: [PATCH] drm/msm/dpu: sort entries in the HW catalog

2023-01-11 Thread Marijn Suijten
On 2023-01-09 20:30:01, Dmitry Baryshkov wrote: > The usual problem is that there are two dimensions: with each > generations there are new (and removed) features, but on the other hand > within each generation there are units that are feature-rich and the > ones that are feature-deprived. qcm2

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread Matthew Brost
On Wed, Jan 11, 2023 at 04:18:01PM -0600, Jason Ekstrand wrote: > On Wed, Jan 11, 2023 at 2:50 AM Tvrtko Ursulin < > tvrtko.ursu...@linux.intel.com> wrote: > > > > > On 10/01/2023 14:08, Jason Ekstrand wrote: > > > On Tue, Jan 10, 2023 at 5:28 AM Tvrtko Ursulin > > > mailto:tvrtko.ursu...@linux.in

Re: [PATCH v5 1/4] dt-bindings: display/msm: convert MDP5 schema to YAML format

2023-01-11 Thread Dmitry Baryshkov
On 12/01/2023 00:29, Marijn Suijten wrote: On 2023-01-10 06:40:27, Dmitry Baryshkov wrote: On 09/01/2023 09:49, Marijn Suijten wrote: On 2023-01-09 07:01:49, Dmitry Baryshkov wrote: +description: | Should multiline descriptions be treated as a oneline string with `>`? Ack, I'm fine w

Re: [RFC PATCH v3 0/3] Support for Solid Fill Planes

2023-01-11 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 04:33:04PM -0800, Abhinav Kumar wrote: > Hi Daniel > > Thanks for looking into this series. > > On 1/6/2023 1:49 PM, Dmitry Baryshkov wrote: > > On Fri, 6 Jan 2023 at 20:41, Daniel Vetter wrote: > > > > > > On Fri, Jan 06, 2023 at 05:43:23AM +0200, Dmitry Baryshkov wrote

Re: [PATCH v5 1/4] dt-bindings: display/msm: convert MDP5 schema to YAML format

2023-01-11 Thread Marijn Suijten
On 2023-01-10 06:40:27, Dmitry Baryshkov wrote: > On 09/01/2023 09:49, Marijn Suijten wrote: > > On 2023-01-09 07:01:49, Dmitry Baryshkov wrote: > >> +description: | > > > > Should multiline descriptions be treated as a oneline string with `>`? > > Ack, I'm fine with either of them, let's us

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 --- Comment #6 from kolAflash (kolafl...@kolahilft.de) --- Created attachment 303585 --> https://bugzilla.kernel.org/attachment.cgi?id=303585&action=edit 6.1.4 dmesg after hibernation (In reply to Mario Limonciello (AMD) from comment #4) > [...

Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-11 Thread Marijn Suijten
On 2023-01-11 17:11:03, Dmitry Baryshkov wrote: > On 11/01/2023 10:44, Marijn Suijten wrote: > > On 2023-01-09 12:32:18, Abhinav Kumar wrote: > > > On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: > > > > +struct msm_mdss_data { > > +    u32 ubwc_version; > > +    u32 ubwc_swizzle;

Re: [RFC 3/3] drm: Update file owner during use

2023-01-11 Thread Daniel Vetter
On Tue, Jan 10, 2023 at 01:14:51PM +, Tvrtko Ursulin wrote: > > On 06/01/2023 18:00, Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 03:53:13PM +0100, Christian König wrote: > > > Am 06.01.23 um 11:53 schrieb Daniel Vetter: > > > > On Fri, Jan 06, 2023 at 11:32:17AM +0100, Christian König wro

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2023 at 2:50 AM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: > > On 10/01/2023 14:08, Jason Ekstrand wrote: > > On Tue, Jan 10, 2023 at 5:28 AM Tvrtko Ursulin > > mailto:tvrtko.ursu...@linux.intel.com>> > > > wrote: > > > > > > > > On 09/01/2023 17:27, Jason Ekstrand

Re: [PATCH] drm/vc4: Check for valid formats

2023-01-11 Thread Daniel Vetter
On Wed, Jan 11, 2023 at 11:32:43AM -0300, Maíra Canal wrote: > On 1/11/23 10:28, Ville Syrjälä wrote: > > On Mon, Jan 02, 2023 at 03:20:06PM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 02.01.23 um 14:57 schrieb Maíra Canal: > > > > Currently, vc4 is not checking valid formats before cr

Re: [PATCH v1 2/2] drm/virtio: Add the hotplug_mode_update property for rescanning of modes

2023-01-11 Thread Daniel Vetter
On Tue, Jan 10, 2023 at 01:58:52AM +, Kasireddy, Vivek wrote: > Hi Daniel, > > > > > On Fri, Jan 06, 2023 at 09:56:40AM +0100, Gerd Hoffmann wrote: > > > On Thu, Nov 17, 2022 at 05:30:54PM -0800, Vivek Kasireddy wrote: > > > > Setting this property will allow the userspace to look for new mod

Re: [PATCH v1 2/2] drm/virtio: Add the hotplug_mode_update property for rescanning of modes

2023-01-11 Thread Daniel Vetter
On Tue, Jan 10, 2023 at 10:28:39AM +0100, Gerd Hoffmann wrote: > On Fri, Jan 06, 2023 at 10:35:15AM +0100, Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 09:56:40AM +0100, Gerd Hoffmann wrote: > > > On Thu, Nov 17, 2022 at 05:30:54PM -0800, Vivek Kasireddy wrote: > > > > Setting this property wil

Re: [v11] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2023-01-11 Thread Marijn Suijten
On 2022-12-20 05:25:19, Kalyan Thota wrote: > Flush mechanism for DSPP blocks has changed in sc7280 family, it > allows individual sub blocks to be flushed in coordination with > master flush control. > > Representation: master_flush && (PCC_flush | IGC_flush .. etc ) > > This change adds necessa

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread Daniel Vetter
On Tue, 10 Jan 2023 at 09:46, Boris Brezillon wrote: > > Hi Daniel, > > On Mon, 9 Jan 2023 21:40:21 +0100 > Daniel Vetter wrote: > > > On Mon, Jan 09, 2023 at 06:17:48PM +0100, Boris Brezillon wrote: > > > Hi Jason, > > > > > > On Mon, 9 Jan 2023 09:45:09 -0600 > > > Jason Ekstrand wrote: > > >

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 --- Comment #5 from Alex Deucher (alexdeuc...@gmail.com) --- Can you attach your dmesg output? -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 --- Comment #4 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- > Perfect guess! OK.. so we need to find out why this works in 6.1.y and not in 6.0.y. There are some fairly severe bugs it fixed. Is it 100% failure rate on 6.0.y? Si

[PATCH v2 3/9] drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

2023-01-11 Thread Alan Previn
Add MTL hw-plumbing enabling for KCR operation under PXP which includes: 1. Updating 'pick-gt' to get the media tile for KCR interrupt handling 2. Adding MTL's KCR registers for PXP operation (init, status-checking, etc.). While doing #2, lets create a separate registers header file for PXP

  1   2   3   >