Re: [PATCH 1/3] drm/msm/dpu: fix blend setup for DMA4 and DMA5 layers

2023-01-17 Thread Dmitry Baryshkov
On Mon, 16 Jan 2023 08:33:14 +0200, Dmitry Baryshkov wrote: > SM8550 uses new register to map SSPP_DMA4 and SSPP_DMA5 units to blend > stages. Add proper support for this register to allow using these two > planes for image processing. > > Applied, thanks! [1/3] drm/msm/dpu: fix blend setup f

Re: [PATCH] drm/msm/dpu: merge two CRTC debugfs dirs

2023-01-17 Thread Dmitry Baryshkov
On Thu, 12 Jan 2023 07:36:59 +0200, Dmitry Baryshkov wrote: > For each CRTC we are creating two different debugfs directories one > using crtc index (created automatically for the CRC files) and another > one using CRTC name/object ID (for state and status files). > > This can be confusing, so m

Re: [PATCH] drm/msm/gem: Add check for kmalloc

2023-01-17 Thread Dmitry Baryshkov
On Mon, 12 Dec 2022 17:11:17 +0800, Jiasheng Jiang wrote: > Add the check for the return value of kmalloc in order to avoid > NULL pointer dereference in copy_from_user. > > Applied, thanks! [1/1] drm/msm/gem: Add check for kmalloc https://gitlab.freedesktop.org/lumag/msm/-/commit/d839f

Re: [PATCH] drm/msm/dpu: enable sourcesplit for sc7180/sc7280

2023-01-17 Thread Dmitry Baryshkov
On Mon, 16 Jan 2023 05:44:35 +0200, Dmitry Baryshkov wrote: > According to the vendor dts files, both sc7180 and sc7280 support the > source split mode (using two LMs for a single output). Change these two > platforms to use MIXER_SDM845_MASK, which includes > DPU_MIXER_SOURCESPLIT. Rename MIXER_

Re: [PATCH 1/2] drm/msm/dpu: remove dpu_encoder_virt_ops

2023-01-17 Thread Dmitry Baryshkov
On Mon, 02 Jan 2023 17:47:47 +0200, Dmitry Baryshkov wrote: > Struct dpu_encoder_virt_ops is used to provide several callbacks to the > phys_enc backends. However these ops are static and are not supposed to > change in the foreseeble future. Drop the indirection and call > corresponding function

Re: [PATCH] dt-bindings: display/msm: qcom, mdss: fix HDMI PHY node names

2023-01-17 Thread Dmitry Baryshkov
On Mon, 09 Jan 2023 06:54:53 +0200, Dmitry Baryshkov wrote: > On Qualcomm devices HDMI PHY node names were changed from hdmi-phy to > phy. Follow this change. > > Applied, thanks! [1/1] dt-bindings: display/msm: qcom,mdss: fix HDMI PHY node names https://gitlab.freedesktop.org/lumag/msm

Re: [PATCH v8 0/3] mdss-dsi-ctrl binding and dts fixes

2023-01-17 Thread Dmitry Baryshkov
On Mon, 16 Jan 2023 22:52:14 +, Bryan O'Donoghue wrote: > V8: > - Squash first and last patch to fix bisectability > > link: > https://lore.kernel.org/linux-arm-msm/167388664232.594279.4607492026981202284.r...@kernel.org/T/#u > > V7: > - The bulk of the patches for this series have been me

[PATCH] drm/msm/dpu: add missing dpu_encoder kerneldoc

2023-01-17 Thread Dmitry Baryshkov
Describe missing dpu_encoder_phys_wb_is_master() argument and struct dpu_encoder_virt.wide_bus_en field. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 1 + 2 files changed, 2 insertions(+) dif

[PATCH 2/2] drm/msm/dpu: use sm8350_regdma on SM8350 platform

2023-01-17 Thread Dmitry Baryshkov
Correct sm8350_dpu_cfg.dma_cfg to point to sm8350_regdma rather than sm8250_regdma. Fixes: 0e91bcbb0016 ("drm/msm/dpu: Add SM8350 to hw catalog") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 1/2] drm/msm/dpu: point sc8280xp_dpu_cfg to sc8280xp_regdma

2023-01-17 Thread Dmitry Baryshkov
SC8280XP configuration missed the reg_dma configuration. We do not use regdma for now, but let's put the correct pointer anyway. Fixes: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++ 1 file changed, 2 in

[PATCH] drm/msm: use strscpy instead of strncpy

2023-01-17 Thread Dmitry Baryshkov
Using strncpy can result in non-NULL-terminated destination string. Use strscpy instead. This fixes following warning: drivers/gpu/drm/msm/msm_fence.c: In function ‘msm_fence_context_alloc’: drivers/gpu/drm/msm/msm_fence.c:25:9: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstr

Re: [PATCH v2] drm/msm/dsi: Drop the redundant fail label

2023-01-17 Thread Dmitry Baryshkov
On 11/01/2023 03:10, Jiasheng Jiang wrote: Drop the redundant fail label and change the "goto fail" into "return ret" since they are the same. Reviewed-by: Doug Anderson Signed-off-by: Jiasheng Jiang --- Changelog: v1 -> v2: 1. No change of the error handling of the irq_of_parse_and_map. ---

Re: [PATCH v3] drm/msm/dpu: Disallow unallocated resources to be returned

2023-01-17 Thread Dmitry Baryshkov
On 10/01/2023 01:15, Marijn Suijten wrote: In the event that the topology requests resources that have not been created by the system (because they are typically not represented in dpu_mdss_cfg ^1), the resource(s) in global_state (in this case DSC blocks, until their allocation/assignment is bei

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-17 Thread Ben Skeggs
On Mon, 16 Jan 2023 at 22:27, Diogo Ivo wrote: > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote: > > On Thu, Dec 29, 2022 at 12:58 AM Diogo Ivo > > wrote: > > As a quick check can you try changing > > > > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_mem_target > > f

Re: [PATCH v6 2/2] drm/msm/dp: enhance dp controller isr

2023-01-17 Thread Dmitry Baryshkov
On 28/12/2022 04:16, Kuogee Hsieh wrote: dp_display_irq_handler() is the main isr handler with the helps of two sub isr, dp_aux_isr and dp_ctrl_isr, to service all DP interrupts on every irq triggered. Current all three isr does not return IRQ_HANDLED if there are any interrupts it had serviced.

Re: [PATCH v2] drm/msm: Add missing check and destroy for alloc_ordered_workqueue

2023-01-17 Thread Dmitry Baryshkov
On 09/01/2023 04:20, Jiasheng Jiang wrote: Add check for the return value of alloc_ordered_workqueue as it may return NULL pointer. Moreover, use the destroy_workqueue in the later fails in order to avoid memory leak. Signed-off-by: Jiasheng Jiang --- Changelog: v1 -> v2: 1. Convert "goto err

RE: [PATCH 6/8] iommu/intel: Add a gfp parameter to alloc_pgtable_page()

2023-01-17 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Tuesday, January 17, 2023 9:30 PM > > On Tue, Jan 17, 2023 at 03:35:08AM +, Tian, Kevin wrote: > > > From: Jason Gunthorpe > > > Sent: Saturday, January 7, 2023 12:43 AM > > > > > > @@ -2676,7 +2676,7 @@ static int copy_context_table(struct > intel_iommu > > >

Re: [PATCH] drm/msm/gem: Add check for kmalloc

2023-01-17 Thread Dmitry Baryshkov
On 12/12/2022 11:11, Jiasheng Jiang wrote: Add the check for the return value of kmalloc in order to avoid NULL pointer dereference in copy_from_user. Fixes: 20224d715a88 ("drm/msm/submit: Move copy_from_user ahead of locking bos") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/msm/msm_gem

[PATCH v2 3/3] drm/msm/mdss: add the sdm845 data for completeness

2023-01-17 Thread Dmitry Baryshkov
Add the platform data for sdm845 platform. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 158d7850c4ba.

[PATCH v2 2/3] drm/msm/mdss: add data for sc8180xp

2023-01-17 Thread Dmitry Baryshkov
Add platform data for sc8180xp based on sdmshrike-sde.dtsi. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c i

[PATCH v2 1/3] drm/msm/mdss: convert UBWC setup to use match data

2023-01-17 Thread Dmitry Baryshkov
To simplify adding new platforms and to make settings more obvious, rewrite the UBWC setup to use the data structure to pass platform config rather than just calling the functions direcly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 181 +++--

[PATCH v2 0/3] drm/msm/mdss: rework UBWC setup

2023-01-17 Thread Dmitry Baryshkov
The commit 92bab9142456 ("drm/msm: less magic numbers in msm_mdss_enable") reworked the static UBWC setup to replace magic numbers with calulating written values from the SoC/device parameters. This simplified adding new platforms. However I did not estimate that the values would still be cryptic a

Re: [PATCH] drm/msm/dpu: merge two CRTC debugfs dirs

2023-01-17 Thread Abhinav Kumar
On 1/11/2023 9:36 PM, Dmitry Baryshkov wrote: For each CRTC we are creating two different debugfs directories one using crtc index (created automatically for the CRC files) and another one using CRTC name/object ID (for state and status files). This can be confusing, so move our custom files

Re: [PATCH 2/5] drm/msm: Fix IS_ERR() vs NULL check in a5xx_submit_in_rb()

2023-01-17 Thread Dmitry Baryshkov
On 10/11/2022 11:44, Gaosheng Cui wrote: The msm_gem_get_vaddr() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl") Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- 1 f

[PATCH v2] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-17 Thread Dmitry Baryshkov
There are two flags attemting to guard connector polling: poll_enabled and poll_running. While poll_enabled semantics is clearly defined and fully adhered (mark that drm_kms_helper_poll_init() was called and not finalized by the _fini() call), the poll_running flag doesn't have such clearliness. T

linux-next: duplicate patch in the drm-intel tree

2023-01-17 Thread Stephen Rothwell
Hi all, The following commit is also in the drm-intel-fixes tree as a different commit (but the same patch): 0fe76b198d48 ("drm/i915/display: Check source height is > 0") this is commit 8565c502e7c1 ("drm/i915/display: Check source height is > 0") in the drm-intel-fixes tree. -- Cheers,

Re: [PATCH] drm/msm/dpu: Remove some unused variables

2023-01-17 Thread Abhinav Kumar
On 1/11/2023 7:38 PM, Jiapeng Chong wrote: Variables 'sc8280xp_regdma' and 'sm8350_regdma' are defined in the dpu_hw_catalog.c file, but not used elsewhere, so remove these unused variables. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2029:37: warning: unused variable 'sc8280xp_regdma'. d

Re: [PATCH] drm/msm/dpu: enable sourcesplit for sc7180/sc7280

2023-01-17 Thread Abhinav Kumar
On 1/15/2023 7:44 PM, Dmitry Baryshkov wrote: According to the vendor dts files, both sc7180 and sc7280 support the source split mode (using two LMs for a single output). Change these two platforms to use MIXER_SDM845_MASK, which includes DPU_MIXER_SOURCESPLIT. Rename MIXER_SC7180_MASK to MIXE

Re: remove arch/sh

2023-01-17 Thread Guenter Roeck
On 1/17/23 12:26, Geert Uytterhoeven wrote: Hi Rob, On Tue, Jan 17, 2023 at 8:01 PM Rob Landley wrote: On 1/16/23 01:13, Christoph Hellwig wrote: On Fri, Jan 13, 2023 at 09:09:52AM +0100, John Paul Adrian Glaubitz wrote: I'm still maintaining and using this port in Debian. It's a bit disapp

Re: [PATCH 05/22] sound: remove sh-specific sounds/soc/sh drivers

2023-01-17 Thread Kuninori Morimoto
Hi Christoph > > Now that arch/sh is removed these drivers are dead code. > > Signed-off-by: Christoph Hellwig > --- (snip) > sound/soc/sh/fsi.c | 9 - (snip) > config SND_SOC_SH4_FSI > tristate "SH4 FSI support" > depends on COMMON_CLK You can remove sound/soc/sh/fsi.c

[PATCH v2 3/5] drm/i915: Allow error capture of a pending request

2023-01-17 Thread John . C . Harrison
From: John Harrison A hang situation has been observed where the only requests on the context were either completed or not yet started according to the breaadcrumbs. However, the register state claimed a batch was (maybe) in progress. So, allow capture of the pending request on the grounds that t

[PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-17 Thread John . C . Harrison
From: John Harrison When GuC support was added to error capture, the locking around the request object was broken. Fix it up. The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request based

[PATCH v2 5/5] drm/i915/guc: Add a debug print on GuC triggered reset

2023-01-17 Thread John . C . Harrison
From: John Harrison For understanding bug reports, it can be useful to have an explicit dmesg print when a reset notification is received from GuC. As opposed to simply inferring that this happened from other messages. Signed-off-by: John Harrison Reviewed-by: Tvrtko Ursulin --- drivers/gpu/d

[PATCH v2 4/5] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-17 Thread John . C . Harrison
From: John Harrison Engine resets are supposed to never fail. But in the case when one does (due to unknown reasons that normally come down to a missing w/a), it is useful to get as much information out of the system as possible. Given that the GuC effectively dies on such a situation, it is not

[PATCH v2 2/5] drm/i915: Allow error capture without a request

2023-01-17 Thread John . C . Harrison
From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification' from GuC. The problem was not reproducible. However, it is possible to happen if the context in question has no active r

[PATCH v2 0/5] Allow error capture without a request / on reset failure

2023-01-17 Thread John . C . Harrison
From: John Harrison It is technically possible to get a hung context without a valid request. In such a situation, try to provide as much information in the error capture as possible rather than just aborting and capturing nothing. Similarly, in the case of an engine reset failure the GuC is not

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-17 Thread John Harrison
On 1/16/2023 04:43, Tvrtko Ursulin wrote: On 14/01/2023 01:27, John Harrison wrote: On 1/13/2023 01:22, Tvrtko Ursulin wrote: On 12/01/2023 20:59, John Harrison wrote: On 1/12/2023 02:15, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison Engine

Re: [PATCH] drm/amd/display: fix issues with driver unload

2023-01-17 Thread Alex Deucher
On Tue, Jan 17, 2023 at 3:55 PM Hamza Mahfooz wrote: > > Currently, we run into a number of WARN()s when attempting to unload the > amdgpu driver (e.g. using "modprobe -r amdgpu"). These all stem from > calling drm_encoder_cleanup() too early. So, to fix this we can stop > calling drm_encoder_clea

Re: linux-next: duplicate patch in the kspp tree

2023-01-17 Thread Stephen Rothwell
Hi Karol, On Tue, 17 Jan 2023 14:52:12 +0100 Karol Herbst wrote: > > On Tue, Jan 17, 2023 at 5:02 AM Stephen Rothwell > wrote: > > > > The following commit is also in the drm-misc tree as a different commit > > (but the same patch): > > > > 06b19f46455c ("drm/nouveau/fb/ga102: Replace zero-le

[PATCH] drm/amd/display: fix issues with driver unload

2023-01-17 Thread Hamza Mahfooz
Currently, we run into a number of WARN()s when attempting to unload the amdgpu driver (e.g. using "modprobe -r amdgpu"). These all stem from calling drm_encoder_cleanup() too early. So, to fix this we can stop calling drm_encoder_cleanup() in amdgpu_dm_fini() and instead have it be called from amd

Re: remove arch/sh

2023-01-17 Thread Geert Uytterhoeven
Hi Rob, On Tue, Jan 17, 2023 at 8:01 PM Rob Landley wrote: > On 1/16/23 01:13, Christoph Hellwig wrote: > > On Fri, Jan 13, 2023 at 09:09:52AM +0100, John Paul Adrian Glaubitz wrote: > >> I'm still maintaining and using this port in Debian. > >> > >> It's a bit disappointing that people keep hamm

[PATCH] drm/i915: Move/adjust register definitions related to Wa_22011450934

2023-01-17 Thread Matt Roper
The implementation of Wa_22011450934 introduced three new register definitions in i915_reg.h that didn't get moved to the GT/engine register headers when all the other registers moved; let's move them to the appropriate headers and tidy up their definitions now for consistency: - STATE_ACK_DEBUG

Re: [PATCH v8 1/3] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2023-01-17 Thread Rob Herring
On Mon, 16 Jan 2023 22:52:15 +, Bryan O'Donoghue wrote: > Currently we do not differentiate between the various users of the > qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one > compatible string but, the hardware does have some significant differences > in the number of

Re: [PATCH v7 4/4] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats

2023-01-17 Thread Rob Herring
On Mon, 16 Jan 2023 15:21:28 +, Bryan O'Donoghue wrote: > Add the list of current compats absent the deprecated qcm2290 to the list > of dsi compats listed here. > > Several MDSS yaml files exist which document the dsi sub-node. > For each existing SoC MDSS yaml, provide the right dsi compat

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-01-17 Thread Rob Herring
On Mon, Jan 16, 2023 at 07:08:19PM +0800, Pin-yen Lin wrote: > From: Nicolas Boichat > > Add bindings for Generic GPIO mux driver. > > Signed-off-by: Nicolas Boichat > Signed-off-by: Pin-yen Lin > --- > > Changes in v2: > - Referenced existing dt-binding schemas from graph.yaml > - Added ddc-

Re: [PATCH] drm: panel: visionox: add backlight dependency

2023-01-17 Thread Javier Martinez Canillas
On 1/17/23 19:22, Linus Walleij wrote: > On Tue, Jan 17, 2023 at 5:55 PM Arnd Bergmann wrote: > >> From: Arnd Bergmann >> >> The newly added driver uses the backlight subsystem but is missing the >> corresponding Kconfig dependency: >> >> arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visiono

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Allow error capture without a request

2023-01-17 Thread John Harrison
On 1/16/2023 04:38, Tvrtko Ursulin wrote: On 13/01/2023 21:29, John Harrison wrote: On 1/13/2023 09:46, Hellstrom, Thomas wrote: On Fri, 2023-01-13 at 09:51 +, Tvrtko Ursulin wrote: On 12/01/2023 20:40, John Harrison wrote: On 1/12/2023 02:01, Tvrtko Ursulin wrote: On 12/01/2023 02:53, j

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

2023-01-17 Thread Rodrigo Vivi
On Mon, Jan 16, 2023 at 01:44:46PM +0800, Zhenyu Wang wrote: > On 2023.01.10 13:49:57 -0500, Rodrigo Vivi wrote: > > On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote: > > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > > function adds the overhead of introduci

Re: [PATCH] drm/i915/display: Convert i9xx_pipe_crc_auto_source to void

2023-01-17 Thread Rodrigo Vivi
On Sat, Jan 14, 2023 at 07:33:53PM +0530, Deepak R Varma wrote: > Convert function i9xx_pipe_crc_auto_source() to return void instead > of int since the current implementation always returns 0 to the caller. > Issue identified using returnvar Coccinelle semantic patch. could you please share the c

Re: [PATCH V10 1/4] drm: of: Add drm_of_get_dsi_bus helper function

2023-01-17 Thread Chris Morgan
On Tue, Jan 17, 2023 at 05:58:19PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Jan 12, 2023 at 11:53:55AM -0600, Chris Morgan wrote: > > From: Chris Morgan > > > > Add helper function to find DSI host for devices where DSI panel is not > > a minor of a DSI bus (such as the Samsung AMS495QA01 p

Re: remove arch/sh

2023-01-17 Thread Rob Landley
On 1/16/23 01:13, Christoph Hellwig wrote: > On Fri, Jan 13, 2023 at 09:09:52AM +0100, John Paul Adrian Glaubitz wrote: >> I'm still maintaining and using this port in Debian. >> >> It's a bit disappointing that people keep hammering on it. It works fine for >> me. > > What platforms do you (or y

Re: [PATCH v3 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM HW model check

2023-01-17 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, Jan 17, 2023 at 1:15 PM Guilherme G. Piccoli wrote: > > The HW model validation that guards the indirect SRAM checking in the > VCN code path is redundant - there's no model that's not included in the > switch, making it useless in practice [0]. > > So,

RE: [PATCH 08/11] fbdev/hyperv: use pci aperture helpers

2023-01-17 Thread Dexuan Cui
> From: Daniel Vetter > Sent: Wednesday, January 11, 2023 7:41 AM > [...] > diff --git a/drivers/video/fbdev/hyperv_fb.c > b/drivers/video/fbdev/hyperv_fb.c > @@ -1076,9 +1076,7 @@ static int hvfb_getmem(struct hv_device *hdev, > struct fb_info *info) > info->screen_size = dio_fb_size; >

Re: [PATCH RFC v7 00/23] DEPT(Dependency Tracker)

2023-01-17 Thread Waiman Long
On 1/17/23 13:18, Boqun Feng wrote: [Cc Waiman] On Mon, Jan 16, 2023 at 10:00:52AM -0800, Linus Torvalds wrote: [ Back from travel, so trying to make sense of this series.. ] On Sun, Jan 8, 2023 at 7:33 PM Byungchul Park wrote: I've been developing a tool for detecting deadlock possibilities

Re: [PATCH v8 0/3] mdss-dsi-ctrl binding and dts fixes

2023-01-17 Thread David Heidelberg
For the series: Acked-by: David Heidelberg

Re: (subset) [PATCH v16 0/5] Add data-lanes and link-frequencies to dp_out endpoint

2023-01-17 Thread Bjorn Andersson
On Tue, 27 Dec 2022 09:44:58 -0800, Kuogee Hsieh wrote: > Add DP both data-lanes and link-frequencies property to dp_out endpoint and > support > functions to DP driver. > > Kuogee Hsieh (5): > arm64: dts: qcom: add data-lanes and link-freuencies into dp_out > endpoint > dt-bindings: msm/

Re: [PATCH] drm: panel: visionox: add backlight dependency

2023-01-17 Thread Linus Walleij
On Tue, Jan 17, 2023 at 5:55 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The newly added driver uses the backlight subsystem but is missing the > corresponding Kconfig dependency: > > arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-vtdr6130.o: in > function `visionox_vtdr6130_p

Re: [PATCH RFC v7 00/23] DEPT(Dependency Tracker)

2023-01-17 Thread Boqun Feng
[Cc Waiman] On Mon, Jan 16, 2023 at 10:00:52AM -0800, Linus Torvalds wrote: > [ Back from travel, so trying to make sense of this series.. ] > > On Sun, Jan 8, 2023 at 7:33 PM Byungchul Park wrote: > > > > I've been developing a tool for detecting deadlock possibilities by > > tracking wait/even

Re: [PATCH v2 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM HW model check

2023-01-17 Thread Guilherme G. Piccoli
On 17/01/2023 15:14, Limonciello, Mario wrote: > [Public] > > > >> -Original Message- >> From: Guilherme G. Piccoli >> Sent: Tuesday, January 17, 2023 12:14 >> To: Limonciello, Mario ; amd- >> g...@lists.freedesktop.org; Deucher, Alexander >> >> Cc: dri-devel@lists.freedesktop.org; Koe

[PATCH v3 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM HW model check

2023-01-17 Thread Guilherme G. Piccoli
The HW model validation that guards the indirect SRAM checking in the VCN code path is redundant - there's no model that's not included in the switch, making it useless in practice [0]. So, let's remove this switch statement for good. [0] lore.kernel.org/amd-gfx/mn0pr12mb61013d20b8a2263b22ae1bcf

[PATCH v3 1/2] drm/amdgpu/vcn: Adjust firmware names indentation

2023-01-17 Thread Guilherme G. Piccoli
This is an incredibly trivial fix, just for the sake of "aesthetical" organization of the defines. Some were space based, most were tab based and there was a lack of "alignment", now it's all the same and aligned. Cc: James Zhu Cc: Lazar Lijo Cc: Leo Liu Cc: Mario Limonciello Cc: Sonny Jiang

RE: [PATCH v2 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM HW model check

2023-01-17 Thread Limonciello, Mario
[Public] > -Original Message- > From: Guilherme G. Piccoli > Sent: Tuesday, January 17, 2023 12:14 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org; Deucher, Alexander > > Cc: dri-devel@lists.freedesktop.org; Koenig, Christian > ; Pan, Xinhui ; > ker...@gpiccoli.net; kernel

Re: [PATCH v2 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM HW model check

2023-01-17 Thread Guilherme G. Piccoli
On 17/01/2023 15:08, Limonciello, Mario wrote: > [...] > > Should have added this tag too: > Suggested-by: Alexander Deucher > > Looks good to me, thanks! > Reviewed-by: Mario Limonciello > You're totally right, thanks for the reminder and apologies for missing that! Just sending V3 heheh Ah

Re: [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()

2023-01-17 Thread Das, Nirmoy
Hi Alex, On 1/17/2023 7:06 PM, Alex Deucher wrote: On Tue, Jan 17, 2023 at 1:05 PM Nirmoy Das wrote: There are no current users of DRM_DEBUG_KMS_RATELIMITED() so remove it. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg

Re: [PATCH] drm/msm/dp: Remove INIT_SETUP delay

2023-01-17 Thread Kuogee Hsieh
On 1/17/2023 9:29 AM, Bjorn Andersson wrote: During initalization of the DisplayPort controller an EV_HPD_INIT_SETUP event is generated, but with a delay of 100 units. This delay existed to circumvent bug in the QMP combo PHY driver, where if the DP part was powered up before USB, the common pr

Re: [PATCH v6 05/11] dt-bindings: display/msm: rename mdp nodes to display-controller

2023-01-17 Thread Rob Herring
On Fri, 13 Jan 2023 10:37:14 +0200, Dmitry Baryshkov wrote: > Follow the 'generic names' rule and rename mdp nodes to > display-controller. > > Signed-off-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/dpu-common.yaml | 8 > .../devicetree/bindings/display/msm/

[PATCH] MAINTAINERS/ACCEL: Add include/drm/drm_accel.h to the accel entry

2023-01-17 Thread Jeffrey Hugo
get_maintainer.pl does not suggest Oded Gabbay, the DRM COMPUTE ACCELERATORS DRIVERS AND FRAMEWORK maintainer for changes that touch the Accel Subsystem header - drm_accel.h. This is because that file is missing from the Accel Subsystem entry. Fix this. Signed-off-by: Jeffrey Hugo --- MAINTAIN

[PATCH] MAINTAINERS/ACCEL: Add include/drm/drm_accel.h to the accel entry

2023-01-17 Thread Jeffrey Hugo
get_maintainer.pl does not suggest Oded Gabbay, the DRM COMPUTE ACCELERATORS DRIVERS AND FRAMEWORK maintainer for changes that touch the Accel Subsystem header - drm_accel.h. This is because that file is missing from the Accel Subsystem entry. Fix this. Signed-off-by: Jeffrey Hugo --- MAINTAIN

RE: [PATCH v2 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM HW model check

2023-01-17 Thread Limonciello, Mario
[Public] > -Original Message- > From: Guilherme G. Piccoli > Sent: Tuesday, January 17, 2023 11:59 > To: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > ker...@gpiccoli.net; kernel-...@igalia.com; Guilherm

Re: [PATCH v6 03/11] dt-bindings: display/msm: add core clock to the mdss bindings

2023-01-17 Thread Rob Herring
On Fri, Jan 13, 2023 at 10:37:12AM +0200, Dmitry Baryshkov wrote: > Add (optional) core clock to the mdss bindings to let the MDSS driver > access harware registers before MDP driver probes. typo > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,mdss.yaml | 34 +++

Re: [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()

2023-01-17 Thread Alex Deucher
On Tue, Jan 17, 2023 at 1:05 PM Nirmoy Das wrote: > > There are no current users of DRM_DEBUG_KMS_RATELIMITED() > so remove it. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sam Ravnborg > > Signed-off-by: Nirmoy Das > Rev

Re: [PATCH v6 02/11] dt-bindings: display/msm: add SoC-specific compats to qcom,mdp5.yaml

2023-01-17 Thread Rob Herring
On Fri, Jan 13, 2023 at 10:37:11AM +0200, Dmitry Baryshkov wrote: > Add platform-specific compatible entries to the qcom,mdp5.yaml to allow > distinguishing between various platforms. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,mdp5.yaml | 17 +++

[PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()

2023-01-17 Thread Nirmoy Das
There are no current users of DRM_DEBUG_KMS_RATELIMITED() so remove it. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg Signed-off-by: Nirmoy Das Reviewed-by: Sam Ravnborg --- include/drm/drm_print.h | 3 --- 1 file change

[PATCH v2] drm/radeon: Do not use deprecated drm log API

2023-01-17 Thread Nirmoy Das
Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR() with proper APIs. v2: replace pr_err with dev_err(Alex). Cc: Alex Deucher Cc: Christian König Signed-off-by: Nirmoy Das --- drivers/gpu/drm/radeon/radeon_dp_auxch.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

Re: [PATCH v6 01/11] dt-bindings: display/msm: convert MDP5 schema to YAML format

2023-01-17 Thread Rob Herring
On Fri, 13 Jan 2023 10:37:10 +0200, Dmitry Baryshkov wrote: > Convert the mdp5.txt into the yaml format. Changes to the existing (txt) > schema: > - MSM8996 has additional "iommu" clock, define it separately > - Add new properties used on some of platforms: >- interconnects, interconnect-n

[PATCH v2 2/2] drm/amdgpu/vcn: Remove redundant indirect SRAM HW model check

2023-01-17 Thread Guilherme G. Piccoli
The HW model validation that guards the indirect SRAM checking in the VCN code path is redundant - there's no model that's not included in the switch, making it useless in practice [0]. So, let's remove this switch statement for good. [0] lore.kernel.org/amd-gfx/mn0pr12mb61013d20b8a2263b22ae1bcf

Re: [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()

2023-01-17 Thread Sam Ravnborg
On Tue, Jan 17, 2023 at 06:44:47PM +0100, Nirmoy Das wrote: > There are no current users of DRM_DEBUG_KMS_RATELIMITED() > so remove it. Thanks > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sam Ravnborg > > Signed-off-by: N

[PATCH v2 1/2] drm/amdgpu/vcn: Adjust firmware names indentation

2023-01-17 Thread Guilherme G. Piccoli
This is an incredibly trivial fix, just for the sake of "aesthetical" organization of the defines. Some were space based, most were tab based and there was a lack of "alignment", now it's all the same and aligned. Cc: James Zhu Cc: Lazar Lijo Cc: Leo Liu Cc: Mario Limonciello Cc: Sonny Jiang

[PATCH 1/2] drm/drm_vma_manager: Add drm_vma_node_allow_once()

2023-01-17 Thread Nirmoy Das
Currently there is no easy way for a drm driver to safely check and allow drm_vma_offset_node for a drm file just once. Allow drm drivers to call non-refcounted version of drm_vma_node_allow() so that a driver doesn't need to keep track of each drm_vma_node_allow() to call subsequent drm_vma_node_r

[PATCH 2/2] drm/i915: Fix a memory leak with reused mmap_offset

2023-01-17 Thread Nirmoy Das
drm_vma_node_allow() and drm_vma_node_revoke() should be called in balanced pairs. We call drm_vma_node_allow() once per-file everytime a user calls mmap_offset, but only call drm_vma_node_revoke once per-file on each mmap_offset. As the mmap_offset is reused by the client, the per-file vm_count ma

Re: [PATCH 1/2] drm/radeon: Do not use deprecated drm log API

2023-01-17 Thread Das, Nirmoy
On 1/17/2023 6:48 PM, Alex Deucher wrote: On Tue, Jan 17, 2023 at 12:45 PM Nirmoy Das wrote: Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR() with proper APIs. Cc: Alex Deucher Cc: Christian König Signed-off-by: Nirmoy Das --- drivers/gpu/drm/radeon/radeon_dp_auxch.c | 5

Re: [PATCH 1/2] drm/radeon: Do not use deprecated drm log API

2023-01-17 Thread Alex Deucher
On Tue, Jan 17, 2023 at 12:45 PM Nirmoy Das wrote: > > Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR() > with proper APIs. > > Cc: Alex Deucher > Cc: Christian König > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/radeon/radeon_dp_auxch.c | 5 ++--- > 1 file changed, 2 ins

[PATCH] accel: Add .mmap to DRM_ACCEL_FOPS

2023-01-17 Thread Jeffrey Hugo
In reviewing the ivpu driver, DEFINE_DRM_ACCEL_FOPS could have been used if DRM_ACCEL_FOPS defined .mmap to be drm_gem_mmap. Lets add that since accel drivers are a variant of drm drivers, modern drm drivers are expected to use GEM, and mmap() is a common operation that is expected to be heavily u

[PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()

2023-01-17 Thread Nirmoy Das
There are no current users of DRM_DEBUG_KMS_RATELIMITED() so remove it. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg Signed-off-by: Nirmoy Das --- include/drm/drm_print.h | 3 --- 1 file changed, 3 deletions(-) diff --g

[PATCH 1/2] drm/radeon: Do not use deprecated drm log API

2023-01-17 Thread Nirmoy Das
Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR() with proper APIs. Cc: Alex Deucher Cc: Christian König Signed-off-by: Nirmoy Das --- drivers/gpu/drm/radeon/radeon_dp_auxch.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_d

[PATCH] drm/msm/dp: Remove INIT_SETUP delay

2023-01-17 Thread Bjorn Andersson
During initalization of the DisplayPort controller an EV_HPD_INIT_SETUP event is generated, but with a delay of 100 units. This delay existed to circumvent bug in the QMP combo PHY driver, where if the DP part was powered up before USB, the common properties would not be properly initialized - and

[PATCH] [v2] drm/amd/display: fix dp_retrieve_lttpr_cap return code

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann The dp_retrieve_lttpr_cap() return type changed from 'bool' to 'enum dc_status', so now the early 'return' uses the wrong type: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function 'dp_retrieve_lttpr_cap': drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_l

Re: (subset) [PATCH] vc4: fix build failure in vc4_dsi_dev_probe()

2023-01-17 Thread Maxime Ripard
On Tue, 17 Jan 2023 17:52:51 +0100, Arnd Bergmann wrote: > The bridge->of_node field is defined inside of an #ifdef, which > results in a build failure when compile-testing the vc4_dsi driver > without CONFIG_OF: > > drivers/gpu/drm/vc4/vc4_dsi.c: In function 'vc4_dsi_dev_probe': > drivers/gpu/drm

Re: (subset) [PATCH] drm/connector: fix a kernel-doc bad line warning

2023-01-17 Thread Maxime Ripard
On Mon, 16 Jan 2023 23:02:24 -0800, Randy Dunlap wrote: > Building the kernel documentation causes this warning 7 times. > Fix it by adding a " *" line instead of a blank line. > > drivers/gpu/drm/drm_connector.c:1849: warning: bad line: > > Applied to drm/drm-misc (drm-misc-next). Thanks! Max

Re: (subset) [PATCH] drm/atomic-helper: fix kernel-doc problems

2023-01-17 Thread Maxime Ripard
On Mon, 16 Jan 2023 23:02:16 -0800, Randy Dunlap wrote: > Fix a kernel-doc warning and other kernel-doc formatting for > drm_atomic_helper_connect_tv_check(). > > drivers/gpu/drm/drm_atomic_state_helper.c:560: warning: Cannot understand * > @drm_atomic_helper_connector_tv_check: Validate an anal

Re: [PATCH V10 1/4] drm: of: Add drm_of_get_dsi_bus helper function

2023-01-17 Thread Maxime Ripard
Hi, On Thu, Jan 12, 2023 at 11:53:55AM -0600, Chris Morgan wrote: > From: Chris Morgan > > Add helper function to find DSI host for devices where DSI panel is not > a minor of a DSI bus (such as the Samsung AMS495QA01 panel or the > official Raspberry Pi touchscreen display). > > Signed-off-by:

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 --- Comment #27 from Rainer Fiebig (j...@mailbox.org) --- (In reply to Alex Deucher from comment #26) > (In reply to Rainer Fiebig from comment #25) > > (In reply to Alex Deucher from comment #23) > > > I'll just revert it. It is more important f

Re: [PATCH 2/3] drm/msm/disp/dpu1: allow dspp selection for all the interfaces

2023-01-17 Thread Dmitry Baryshkov
On 17/01/2023 18:21, Kalyan Thota wrote: Allow dspps to be populated as a requirement for all the encoder types it need not be just DSI. If for any encoder the dspp allocation doesn't go through then there can be an option to fallback for color features. Signed-off-by: Kalyan Thota --- driver

[PATCH] drm: panel: visionox: add backlight dependency

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann The newly added driver uses the backlight subsystem but is missing the corresponding Kconfig dependency: arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-vtdr6130.o: in function `visionox_vtdr6130_probe': panel-visionox-vtdr6130.c:(.text+0xdee): undefined reference

[PATCH] vc4: fix build failure in vc4_dsi_dev_probe()

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann The bridge->of_node field is defined inside of an #ifdef, which results in a build failure when compile-testing the vc4_dsi driver without CONFIG_OF: drivers/gpu/drm/vc4/vc4_dsi.c: In function 'vc4_dsi_dev_probe': drivers/gpu/drm/vc4/vc4_dsi.c:1822:20: error: 'struct drm_brid

[linux-next:master] BUILD REGRESSION 9ce08dd7ea24253aac5fd2519f9aea27dfb390c9

2023-01-17 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 9ce08dd7ea24253aac5fd2519f9aea27dfb390c9 Add linux-next specific files for 20230117 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301100332.4eaki4d1-...@intel.com https

[PATCH] drm/panfrost: fix GENERIC_ATOMIC64 dependency

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann On ARMv5 and earlier, a randconfig build can still run into WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE_LPAE Depends on [n]: IOMMU_SUPPORT [=y] && (ARM [=y] || ARM64 || COMPILE_TEST [=y]) && !GENERIC_ATOMIC64 [=y] Selected by [y]: - DRM_PANFROST [=

Re: [PATCH v3 0/7] media/drm: renesas: Add new pixel formats

2023-01-17 Thread Mauro Carvalho Chehab
Em Tue, 17 Jan 2023 15:38:25 +0200 Laurent Pinchart escreveu: > Hi Tomi, > > (CC'ing Mauro and Hans) > > On Tue, Jan 10, 2023 at 04:25:37PM +0200, Tomi Valkeinen wrote: > > On 26/12/2022 16:56, Laurent Pinchart wrote: > > > Hi Tomi, > > > > > > (CC'ing Daniel and Dave) > > > > > > On Wed, D

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-17 Thread Jason Ekstrand
On Thu, Jan 12, 2023 at 11:17 AM Matthew Brost wrote: > On Thu, Jan 12, 2023 at 10:54:25AM +0100, Lucas De Marchi wrote: > > On Thu, Jan 05, 2023 at 09:27:57PM +, Matthew Brost wrote: > > > On Tue, Jan 03, 2023 at 12:21:08PM +, Tvrtko Ursulin wrote: > > > > > > > > On 22/12/2022 22:21, Ma

Re: [PATCH 1/3] drm/msm/disp/dpu1: allow reservation even if dspps are not available.

2023-01-17 Thread Dmitry Baryshkov
On 17/01/2023 18:35, Dmitry Baryshkov wrote: On 17/01/2023 18:21, Kalyan Thota wrote: if any topology requests for dspps and catalogue doesn't have the allocation, avoid failing the reservation. This can pave way to build logic allowing composer fallbacks for all the color features that are han

<    1   2   3   >