Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-27 Thread Gwan-gyeong Mun
On 1/27/23 11:00 AM, Andi Shyti wrote: Hi Gwan-gyeong, thanks for the review and the thorough explanation. On Fri, Jan 27, 2023 at 08:50:26AM +0200, Gwan-gyeong Mun wrote: On 1/11/23 5:36 PM, Andi Shyti wrote: On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: On Wed, 11 Jan 2

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-01-27 Thread Linux kernel regression tracking (Thorsten Leemhuis)
On 27.01.23 20:46, Chris Clayton wrote: > [Resend because the mail client on my phone decided to turn HTML on behind my > back, so my reply got bounced.] > > Thanks Thorsten. > > I did try to revert but it didnt revert cleanly and I don't have the > knowledge to fix it up. > > The patch was pa

[PATCH 2/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support

2023-01-27 Thread Liu Ying
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which configures parallel display format by using the "PARALLEL_DISP_FORMAT" field. Add a DRM bridge driver to support the display format configuration. Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/imx/Kconfig | 8 + dri

[PATCH 1/2] dt-bindings: display: bridge: Add NXP i.MX93 parallel display format configuration

2023-01-27 Thread Liu Ying
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which configures parallel display format by using the "PARALLEL_DISP_FORMAT" field. Add device tree bindings for the display format configuration. Signed-off-by: Liu Ying --- .../display/bridge/nxp,imx93-pdfc.yaml| 78 +++

[PATCH 0/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support

2023-01-27 Thread Liu Ying
Hi, This patch aims to add NXP i.MX93 parallel display format configuration DRM bridge driver support. i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which configures parallel display format by using the "PARALLEL_DISP_FORMAT" field. i.MX93 LCDIF display controller's parallel output co

Re: [PATCH] drm/i915/guc: Fix missing ecodes

2023-01-27 Thread John Harrison
On 1/26/2023 11:17, Teres Alexis, Alan Previn wrote: Firstly, thanks for catching this miss. Since I only have one trivial nit and one non-blocker ask. and the non-blocker ask will not impact the patch intent as it merely tweaks an existing debug message, I believe we have an rb: Reviewed-by: Al

Re: [PATCH] drm/nouveau/mmu: fix Use after Free bug in nvkm_vmm_node_split

2023-01-27 Thread Danilo Krummrich
On Fri, Jan 27, 2023 at 01:10:46PM +0100, Takashi Iwai wrote: > On Tue, 03 Jan 2023 15:07:55 +0100, > Takashi Iwai wrote: > > > > On Fri, 30 Dec 2022 08:27:58 +0100, > > Zheng Wang wrote: > > > > > > Here is a function call chain. > > > nvkm_vmm_pfn_map->nvkm_vmm_pfn_split_merge->nvkm_vmm_node_sp

Re: [PATCH drm-next 03/14] drm: manager to keep track of GPUs VA mappings

2023-01-27 Thread Danilo Krummrich
On Fri, Jan 27, 2023 at 12:24:07AM +, Matthew Brost wrote: > On Wed, Jan 18, 2023 at 07:12:45AM +0100, Danilo Krummrich wrote: > > This adds the infrastructure for a manager implementation to keep track > > of GPU virtual address (VA) mappings. > > > > New UAPIs, motivated by Vulkan sparse mem

[PATCH] drm/amdgpu/display: remove duplicate include header in files

2023-01-27 Thread ye.xingchen
From: ye xingchen opp.h is included more than once. Signed-off-by: ye xingchen --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c index 6475664baa8a.

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915/guc: Add GuC oriented print macros

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: While we do have GT oriented print macros, add few more GuC specific to have common look and feel across all messages related to the GuC and to avoid chasing the gt pointer. We will use these macros shortly in upcoming patches. Signed-off-by: Michal W

Re: [Intel-gfx] [PATCH v2 8/8] drm/i915/guc: Update GT/GuC messages in intel_uc.c

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: pass gt to print_fw_ver Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 80 +-- 1 file changed, 39 insertions(+)

Re: [Intel-gfx] [PATCH v2 7/8] drm/i915/guc: Update GuC messages in intel_guc_submission.c

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: improve few existing messages Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 61 -

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/guc: Update GuC messages in intel_guc_log.c

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: drop redundant GuC strings, minor improvements Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 37 -- 1 file ch

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/guc: Update GuC messages in intel_guc_ct.c

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: drop unused helpers Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 23 --- 1 fil

Re: [Intel-gfx] [PATCH v2 2/8] drm/i915/guc: Update GuC messages in intel_guc.c

2023-01-27 Thread John Harrison
On 1/24/2023 09:05, Michal Wajdeczko wrote: Use new macros to have common prefix that also include GT#. v2: drop now redundant "GuC" word from the message Signed-off-by: Michal Wajdeczko Cc: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 31 +++

Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

2023-01-27 Thread Tejun Heo
On Thu, Jan 12, 2023 at 04:56:07PM +, Tvrtko Ursulin wrote: ... > + /* > + * 1st pass - reset working values and update hierarchical weights and > + * GPU utilisation. > + */ > + if (!__start_scanning(root, period_us)) > + goto out_retry; /* > +

Re: [PATCH v3 5/8] drm/i915/pxp: Add ARB session creation with new PXP API Ver4.3

2023-01-27 Thread Teres Alexis, Alan Previn
With the acceptance of the explicit-px-fw-cmd-termination series upstream (https://patchwork.freedesktop.org/series/113307/), this patch #5 of this series will need a rerev with the addition of MTL's version of the explicit termination as well. ...alan On Wed, 2023-01-25 at 00:06 -0800, Teres Ale

Re: [PATCH v2 05/27] drm/msm/dpu: drop EAGAIN check from dpu_format_populate_layout

2023-01-27 Thread Abhinav Kumar
On 1/26/2023 10:05 PM, Dmitry Baryshkov wrote: On Fri, 27 Jan 2023 at 02:52, Abhinav Kumar wrote: On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: The pipe's layout is not cached, corresponding data structure is zeroed out each time in the dpu_plane_sspp_atomic_update(), right before the

What happened to basic prime support of bochs driver?

2023-01-27 Thread lepton
Hi Gerd, It seems in the latest kernel, there is no PRIME support for bochs-drm driver, I've found that you have an old CL which adds basic prime support to it. https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1893205.html Do you remember why it finally doesn't go through? Thanks!

Re: [PATCH] gpu: host1x: fix uninitialized variable use

2023-01-27 Thread Nathan Chancellor
On Fri, Jan 27, 2023 at 11:14:00PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The error handling for platform_get_irq() failing no longer > works after a recent change, clang now points this out with > a warning: > > drivers/gpu/host1x/dev.c:520:6: error: variable 'syncpt_irq' is unin

[PATCH v3] drm/mediatek: Add support for AR30 and BA30

2023-01-27 Thread Justin Green
Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver. Tested using "modetest -P" on an MT8195. Signed-off-by: Justin Green --- v2: * Rebase and resolve merge conflicts with the AFBC patch. v3: * Moved 10-bit support detection to mtk_disk_ovl.c drivers/gpu/drm/mediatek/mtk_d

Re: [PATCH v2 03/27] drm/msm/dpu: move SSPP allocation to the RM

2023-01-27 Thread Abhinav Kumar
On 1/26/2023 9:56 PM, Dmitry Baryshkov wrote: On Fri, 27 Jan 2023 at 01:29, Abhinav Kumar wrote: On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: Follow the example of all other hw blocks and initialize SSPP blocks in Resource Manager. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/

[pull] amdgpu drm-next-6.3

2023-01-27 Thread Alex Deucher
Hi Dave, Daniel, A few more new things for 6.3. The following changes since commit b4a9b36e69e935104e52e561aa9a82d39b5efc36: Documentation/gpu: update dGPU asic info table (2023-01-19 17:24:26 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git ta

Re: [Freedreno] [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-27 Thread Abhinav Kumar
On 1/27/2023 2:33 PM, Doug Anderson wrote: Hi, On Fri, Jan 27, 2023 at 10:54 AM Abhinav Kumar wrote: On 1/13/2023 3:56 PM, Douglas Anderson wrote: In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time"), we moved powering up DSI hosts to modeset time. This wasn't bec

Re: [Freedreno] [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-27 Thread Doug Anderson
Hi, On Fri, Jan 27, 2023 at 10:54 AM Abhinav Kumar wrote: > > On 1/13/2023 3:56 PM, Douglas Anderson wrote: > > In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > > time"), we moved powering up DSI hosts to modeset time. This wasn't > > because it was an elegant design, but

[PATCH] [v2] accel: fix CONFIG_DRM dependencies

2023-01-27 Thread Arnd Bergmann
From: Arnd Bergmann At the moment, accel drivers can be built-in even with CONFIG_DRM=m, but this causes a link failure: x86_64-linux-ld: drivers/accel/ivpu/ivpu_drv.o: in function `ivpu_dev_init': ivpu_drv.c:(.text+0x1535): undefined reference to `drmm_kmalloc' x86_64-linux-ld: ivpu_drv.c:(.tex

[PATCH] gpu: host1x: fix uninitialized variable use

2023-01-27 Thread Arnd Bergmann
From: Arnd Bergmann The error handling for platform_get_irq() failing no longer works after a recent change, clang now points this out with a warning: drivers/gpu/host1x/dev.c:520:6: error: variable 'syncpt_irq' is uninitialized when used here [-Werror,-Wuninitialized] if (syncpt_irq <

Re: [PATCH v2] drm/mediatek: Add support for AR30 and BA30

2023-01-27 Thread Justin Green
Thanks for the suggestion! That's a lot cleaner than manually traversing the device tree. Will send out another patch. On Thu, Jan 26, 2023 at 7:36 PM Chun-Kuang Hu wrote: > > Hi, Justin: > > Justin Green 於 2023年1月11日 週三 上午4:47寫道: > > > > Add support for AR30 and BA30 pixel formats to the Mediat

Re: [git pull] drm fixes for 6.2-rc6

2023-01-27 Thread pr-tracker-bot
The pull request you sent on Fri, 27 Jan 2023 15:22:36 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-01-27 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/76e26e3c6a49b368a6fd38e2da2b1b164470cc52 Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-27 Thread Danilo Krummrich
On 1/27/23 16:17, Christian König wrote: Am 27.01.23 um 15:44 schrieb Danilo Krummrich: [SNIP] What you want is one component for tracking the VA allocations (drm_mm based) and a different component/interface for tracking the VA mappings (probably rb tree based). That's what the GPUVA mana

[PATCH] drm/arm/malidp: use sysfs_emit in show function callback

2023-01-27 Thread Deepak R Varma
According to Documentation/filesystems/sysfs.rst, the show() callback function of kobject attributes should strictly use sysfs_emit() instead of sprintf() family functions. Issue identified using the device_attr_show.cocci Coccinelle script. Signed-off-by: Deepak R Varma --- drivers/gpu/drm/arm/

[PATCH] dt-bindings: display: bridge: sil, sii8620: convert to dtschema

2023-01-27 Thread Krzysztof Kozlowski
Convert the Silicon Image SiI8620 HDMI/MHL bridge bindings to DT schema. Signed-off-by: Krzysztof Kozlowski --- .../bindings/display/bridge/sil,sii8620.yaml | 107 ++ .../bindings/display/bridge/sil-sii8620.txt | 33 -- 2 files changed, 107 insertions(+), 33 deletions(-)

Re: [PATCH v7 3/6] mei: clean pending read with vtag on bus

2023-01-27 Thread Rodrigo Vivi
On Fri, Jan 27, 2023 at 10:09:31AM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 25, 2023 at 12:28:29PM -0500, Rodrigo Vivi wrote: > > > > Greg, ack on getting these 3 mei patches merged through intel-gfx? > > I only see 2 mei patches in this series, what am I missing? right... 2 mei patches on

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-27 Thread David Airlie
On Sat, Jan 28, 2023 at 1:17 AM Christian König wrote: > > Am 27.01.23 um 15:44 schrieb Danilo Krummrich: > > [SNIP] > > What you want is one component for tracking the VA allocations > (drm_mm based) and a different component/interface for tracking the > VA mappings (probably

[PATCH] drm/i915: Fix potential bit_17 double-free

2023-01-27 Thread Rob Clark
From: Rob Clark A userspace with multiple threads racing I915_GEM_SET_TILING to set the tiling to I915_TILING_NONE could trigger a double free of the bit_17 bitmask. (Or conversely leak memory on the transition to tiled.) Move allocation/free'ing of the bitmask within the section protected by t

Re: [PATCH 5/9] drm/display/dp_mst: Fix the payload VCPI check in drm_dp_mst_dump_topology()

2023-01-27 Thread Imre Deak
On Fri, Jan 27, 2023 at 09:42:39PM +0200, Ville Syrjälä wrote: > On Wed, Jan 25, 2023 at 01:48:48PM +0200, Imre Deak wrote: > > Fix an off-by-one error in the VCPI check in drm_dp_mst_dump_topology(). > > > > Cc: Lyude Paul > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Imre Deak > >

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-01-27 Thread Chris Clayton
[Resend because the mail client on my phone decided to turn HTML on behind my back, so my reply got bounced.] Thanks Thorsten. I did try to revert but it didnt revert cleanly and I don't have the knowledge to fix it up. The patch was part of a merge that included a number of related patches.

Re: [PATCH 5/9] drm/display/dp_mst: Fix the payload VCPI check in drm_dp_mst_dump_topology()

2023-01-27 Thread Ville Syrjälä
On Wed, Jan 25, 2023 at 01:48:48PM +0200, Imre Deak wrote: > Fix an off-by-one error in the VCPI check in drm_dp_mst_dump_topology(). > > Cc: Lyude Paul > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +- > 1 file change

Re: [PATCH] drm/nouveau/disp: Fix nvif_outp_acquire_dp() argument size

2023-01-27 Thread Kees Cook
On Wed, Jan 25, 2023 at 04:24:19PM -0500, Lyude Paul wrote: > Sorry! I've been pretty busy until now, this is: > > Reviewed-by: Lyude Paul > > Let me know if you've pushed it already or if you want me to push it to drm- > misc Either way is fine. I'm currently carrying it, but I can easily drop

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-01-27 Thread Chris Clayton
[Resend because the mail client on my phone dedcided to turn HTML on behinf my back, so my repluy got bounced.] Thanks Karol. I sent the original report to Ben and LKML. Thorsten then added you, Lyude Paul and the dri-devel and nouveau mail lists. So you should have received this report on or

Re: [PATCH v7 3/6] mei: clean pending read with vtag on bus

2023-01-27 Thread Teres Alexis, Alan Previn
Hi Greg, appreciate your time on this, Patch #2 adds a device link between i915 and mei (at bind time) specifically for the PXP interface that is subject to the issue being fixed. Change is on i915 but implication is mei suspend-resume aligfnent with i915. Rodrigo has already reviewed it but Ale

Re: [PATCH 5/7] drm/vmwgfx: Cleanup the vmw bo usage in the cursor paths

2023-01-27 Thread Martin Krastev (VMware)
From: Martin Krastev Ah, good! Reviewed-by: Martin Krastev Regards, Martin On 26.01.23 г. 19:38 ч., Zack Rusin wrote: From: Zack Rusin Base mapped count is useless because the ttm unmap functions handle null maps just fine so completely remove all the code related to it. Rename dummy to

Re: [Freedreno] [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-27 Thread Abhinav Kumar
On 1/13/2023 3:56 PM, Douglas Anderson wrote: In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time"), we moved powering up DSI hosts to modeset time. This wasn't because it was an elegant design, but there were no better options. That commit actually ended up breaking p

Re: [PATCH 4/7] drm/vmwgfx: Simplify fb pinning

2023-01-27 Thread Martin Krastev (VMware)
From: Martin Krastev LGTM! Reviewed-by: Martin Krastev Regards, Martin On 26.01.23 г. 19:38 ч., Zack Rusin wrote: From: Zack Rusin Only the legacy display unit requires pinning of the fb memory in vram. Both the screen objects and screen targets can present from any buffer. That makes t

Re: [PATCH] drm/mediatek: Remove unused GEM DMA header include

2023-01-27 Thread Doug Anderson
Hi, On Fri, Jan 27, 2023 at 8:54 AM Rob Clark wrote: > > From: Rob Clark > > No longer needed since the removal of dependency on DMA helper. > > Fixes: 2ea8aec56bf1 ("drm/mediatek: Remove dependency on GEM DMA helper") > Signed-off-by: Rob Clark Reported-by: Douglas Anderson Reviewed-by: Doug

Re: [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

2023-01-27 Thread Simon Ser
On Wednesday, January 25th, 2023 at 21:04, Thomas Zimmermann wrote: > Not having connectors indicates a driver bug. Is it? What if all connectors are of the DP-MST type, ie. they are created on-the-fly?

Re: [RESEND PATCH v11 02/18] drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper

2023-01-27 Thread Jagan Teki
Hi, On Thu, Jan 26, 2023 at 8:48 PM Jagan Teki wrote: > > On Thu, Jan 26, 2023 at 5:42 PM Maxime Ripard wrote: > > > > Hi, > > > > On Mon, Jan 23, 2023 at 08:41:56PM +0530, Jagan Teki wrote: > > > Add devm OF helper to return the next DSI bridge in the chain. > > > > > > Unlike general bridge re

Re: [PATCH v3 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup

2023-01-27 Thread Sam Ravnborg
On Fri, Jan 27, 2023 at 03:21:30PM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.01.23 um 22:03 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Wed, Jan 25, 2023 at 09:04:09PM +0100, Thomas Zimmermann wrote: > > > Initialize the fb-helper structure immediately after its allocation > > > in drm_f

Re: [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-27 Thread Dmitry Baryshkov
On 27/01/2023 18:32, Doug Anderson wrote: Hi, On Thu, Jan 26, 2023 at 9:49 PM Dmitry Baryshkov wrote: Hi, On Sat, 14 Jan 2023 at 01:56, Douglas Anderson wrote: In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time"), we moved powering up DSI hosts to modeset time. Th

Re: [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

2023-01-27 Thread Sam Ravnborg
On Fri, Jan 27, 2023 at 03:13:50PM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.01.23 um 21:52 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Wed, Jan 25, 2023 at 09:04:06PM +0100, Thomas Zimmermann wrote: > > > Test for connectors in the client code and remove a similar test > > > from the ge

Re: [PATCH 3/7] drm/vmwgfx: Rename vmw_buffer_object to vmw_bo

2023-01-27 Thread Martin Krastev (VMware)
From: Martin Krastev LGTM! Reviewed-by: Martin Krastev Regards, Martin On 26.01.23 г. 19:38 ч., Zack Rusin wrote: From: Zack Rusin The rest of the drivers which are using ttm have mostly standardized on driver_prefix_bo as the name for subclasses of the TTM buffer object. Make vmwgfx ma

[GIT PULL] drm/tegra: Changes for v6.3-rc1

2023-01-27 Thread Thierry Reding
Hi Dave, Daniel, The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2: Linux 6.2-rc1 (2022-12-25 13:41:39 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/drm/tegra.git tags/drm/tegra/for-6.3-rc1 for you to fetch changes up to 2abdd44e312

Re: [PATCH 2/7] drm/vmwgfx: Remove the duplicate bo_free function

2023-01-27 Thread Martin Krastev (VMware)
From: Martin Krastev LGTM! Reviewed-by: Martin Krastev Regards, Martin On 26.01.23 г. 19:38 ч., Zack Rusin wrote: From: Zack Rusin Remove the explicit bo_free parameter which was switching between vmw_bo_bo_free and vmw_gem_destroy which had exactly the same implementation. It makes no

[GIT PULL FOR v6.3] R-Car DU fixes and improvements

2023-01-27 Thread Laurent Pinchart
Hello Dave, Daniel, The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2: Linux 6.2-rc1 (2022-12-25 13:41:39 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/drm-next-20230127 for you to fetch

[PATCH] fbdev: Fix invalid page access after closing deferred I/O devices

2023-01-27 Thread Takashi Iwai
When a fbdev with deferred I/O is once opened and closed, the dirty pages still remain queued in the pageref list, and eventually later those may be processed in the delayed work. This may lead to a corruption of pages, hitting an Oops. This patch makes sure to cancel the delayed work and clean u

[PATCH] drm/mediatek: Remove unused GEM DMA header include

2023-01-27 Thread Rob Clark
From: Rob Clark No longer needed since the removal of dependency on DMA helper. Fixes: 2ea8aec56bf1 ("drm/mediatek: Remove dependency on GEM DMA helper") Signed-off-by: Rob Clark --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

Re: [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-27 Thread Doug Anderson
Hi, On Thu, Jan 26, 2023 at 9:49 PM Dmitry Baryshkov wrote: > > Hi, > > On Sat, 14 Jan 2023 at 01:56, Douglas Anderson wrote: > > > > In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > > time"), we moved powering up DSI hosts to modeset time. This wasn't > > because it was

Re: [PATCH 1/7] drm/vmwgfx: Use the common gem mmap instead of the custom code

2023-01-27 Thread Martin Krastev (VMware)
From: Martin Krastev LGTM! Reviewed-by: Martin Krastev Regards, Martin On 26.01.23 г. 19:38 ч., Zack Rusin wrote: From: Zack Rusin Before vmwgfx supported gem it needed to implement the entire mmap logic explicitly. With GEM support that's not needed and the generic code can be used by s

[PATCH] drm/vc4: hdmi: Always enable GCP with AVMUTE cleared

2023-01-27 Thread Maxime Ripard
From: Dom Cobley Issue is some displays go blank at the point of firmware to kms handover. Plugging/unplugging hdmi cable, power cycling display, or switching standby off/on typically resolve this case. Finally managed to find a display that suffers from this, and track down the issue. The fir

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-01-27 Thread Chris Clayton
Thanks Thorsten. I did try to revert but it didnt revert cleanly and I don't have the knowledge to fix it up. The patch was part of a merge that included a number of related patches. I'll try to revert the lot and report back. Chris On Fri, 27 Jan 2023, 11:20 Linux kernel regression tracking (

Re: [PATCH] drm/mediatek: Remove dependency on GEM DMA helper

2023-01-27 Thread Doug Anderson
Hi, On Thu, Jan 19, 2023 at 2:40 PM Rob Clark wrote: > > From: Rob Clark > > It appears that the dependency on the DMA helpers was only for > drm_gem_dma_vm_ops. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/mediatek/Kconfig | 1 - > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 7

[PATCH] drm/vc4: Fix YUV plane handling when planes are in different buffers

2023-01-27 Thread Maxime Ripard
From: Dave Stevenson YUV images can either be presented as one allocation with offsets for the different planes, or multiple allocations with 0 offsets. The driver only ever calls drm_fb_[dma|cma]_get_gem_obj with plane index 0, therefore any application using the second approach was incorrectly

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-01-27 Thread Chris Clayton
Hi Karol. I sent the originsl report to Ben and LKML. Thorsten then added you, Lyude Paul and the dri-devel and nouveau lists. So you should have received this report on or about January 19. Chris On Fri, 27 Jan 2023, 11:35 Karol Herbst, wrote: > Where was the original email sent to anyway, be

Re: [PATCH] drm/virtio: exbuf->fence_fd unmodified on interrupted wait

2023-01-27 Thread Rob Clark
On Fri, Jan 27, 2023 at 12:31 AM Ryan Neph wrote: > > An interrupted dma_fence_wait() becomes an -ERESTARTSYS returned > to userspace ioctl(DRM_IOCTL_VIRTGPU_EXECBUFFER) calls, prompting to > retry the ioctl(), but the passed exbuf->fence_fd has been reset to -1, > making the retry attempt fail at

[PATCH] drm/probe-helper: Cancel previous job before starting new one

2023-01-27 Thread Maxime Ripard
From: Dom Cobley Currently we schedule a call to output_poll_execute from drm_kms_helper_poll_enable for 10s in future. Later we try to replace that in drm_helper_probe_single_connector_modes with a 0s schedule with delayed_event set. But as there is already a job in the queue this fails, and th

[PATCH] backlight: ktz8866: Convert to i2c's .probe_new()

2023-01-27 Thread Uwe Kleine-König
The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König --- Hello, there is an ongoing effort to convert all drivers to .probe_new to eventually drop .probe with the i2c_device_id parameter. This driver currently sits

Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

2023-01-27 Thread Tvrtko Ursulin
On 27/01/2023 14:11, Michal Koutný wrote: On Fri, Jan 27, 2023 at 01:31:54PM +, Tvrtko Ursulin wrote: I think you missed the finish_suspend_scanning() part: if (root_drmcs.suspended_period_us) cancel_delayed_work_sync(&root_drmcs.scan_work); So if scanning was i

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-27 Thread Christian König
Am 27.01.23 um 15:44 schrieb Danilo Krummrich: [SNIP] What you want is one component for tracking the VA allocations (drm_mm based) and a different component/interface for tracking the VA mappings (probably rb tree based). That's what the GPUVA manager is doing. There are gpuva_regions whi

Re: [PATCH v2] drm/mediatek: Clean dangling pointer on bind error path

2023-01-27 Thread Chun-Kuang Hu
Hi, Nicolas: Nícolas F. R. A. Prado 於 2022年11月22日 週二 下午10:39寫道: > > mtk_drm_bind() can fail, in which case drm_dev_put() is called, > destroying the drm_device object. However a pointer to it was still > being held in the private object, and that pointer would be passed along > to DRM in mtk_drm_

RE: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-27 Thread Limonciello, Mario
[Public] > -Original Message- > From: Linux kernel regression tracking (Thorsten Leemhuis) > > Sent: Friday, January 27, 2023 03:15 > To: Greg KH ; Limonciello, Mario > > Cc: dri-devel@lists.freedesktop.org; sta...@vger.kernel.org; > stanislav.lisovs...@intel.com; Zuo, Jerry ; amd- > g

RE: [PATCH Resend v11 05/15] drm/msm/dp: disable self_refresh_aware after entering psr

2023-01-27 Thread Vinod Polimera
> -Original Message- > From: Dmitry Baryshkov > Sent: Tuesday, January 24, 2023 10:15 PM > To: Vinod Polimera > Cc: Vinod Polimera (QUIC) ; dri- > de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; Sankeerth > Billaka

[PATCH] drm/vc4: crtc: Increase setup cost in core clock calculation to handle extreme reduced blanking

2023-01-27 Thread Maxime Ripard
From: Dom Cobley The formula that determines the core clock requirement based on pixel clock and blanking has been determined experimentally to minimise the clock while supporting all modes we've seen. A new reduced blanking mode (4kp60 at 533MHz rather than the standard 594MHz) has been seen th

Re: [PATCH] drm/mediatek: mtk_drm_crtc: Add checks for devm_kcalloc

2023-01-27 Thread Chun-Kuang Hu
Hi, Ruanjinjie: Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. AngeloGioacchino Del Regno 於 2022年12月5日 週一 下午7:53寫道: > > Il 05/12/22 10:51, ruanjinjie ha scritto: > > As the devm

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-27 Thread Danilo Krummrich
On 1/27/23 14:23, Christian König wrote: Am 27.01.23 um 14:12 schrieb Danilo Krummrich: On 1/27/23 08:55, Christian König wrote: Am 27.01.23 um 02:26 schrieb Danilo Krummrich: On 1/27/23 02:05, Matthew Brost wrote: On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: This comm

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-27 Thread Hamza Mahfooz
Hey Greg, On 1/27/23 02:39, Greg KH wrote: On Fri, Jan 20, 2023 at 11:51:04AM -0600, Limonciello, Mario wrote: On 1/20/2023 11:46, Guenter Roeck wrote: On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. [Why] Changes cause

Re: [PATCH 13/14] drm/msm/a6xx: Add A619_holi speedbin support

2023-01-27 Thread Konrad Dybcio
On 27.01.2023 15:19, Dmitry Baryshkov wrote: > On 26/01/2023 17:16, Konrad Dybcio wrote: >> A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 >> (blair). This is what seems to be a first occurrence of this happening, >> but it's easy to overcome by guarding the SoC-specific

Re: [PATCH v3 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup

2023-01-27 Thread Thomas Zimmermann
Hi Am 25.01.23 um 22:03 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:09PM +0100, Thomas Zimmermann wrote: Initialize the fb-helper structure immediately after its allocation in drm_fbdev_generic_setup(). That will make it easier to fill it with driver-specific values, such as

Re: [PATCH 13/14] drm/msm/a6xx: Add A619_holi speedbin support

2023-01-27 Thread Konrad Dybcio
On 27.01.2023 15:19, Dmitry Baryshkov wrote: > On 26/01/2023 17:16, Konrad Dybcio wrote: >> A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 >> (blair). This is what seems to be a first occurrence of this happening, >> but it's easy to overcome by guarding the SoC-specific

Re: [PATCH 13/14] drm/msm/a6xx: Add A619_holi speedbin support

2023-01-27 Thread Dmitry Baryshkov
On 26/01/2023 17:16, Konrad Dybcio wrote: A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 (blair). This is what seems to be a first occurrence of this happening, but it's easy to overcome by guarding the SoC-specific fuse values with of_machine_is_compatible(). Do just tha

Re: [PATCH v3 02/10] drm/client: Add hotplug_failed flag

2023-01-27 Thread Thomas Zimmermann
Hi Am 25.01.23 um 21:57 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:07PM +0100, Thomas Zimmermann wrote: Signal failed hotplugging with a flag in struct drm_client_dev. If set, the client helpers will not further try to set up the fbdev display. This used to be signalled wi

Re: [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

2023-01-27 Thread Thomas Zimmermann
Hi Am 25.01.23 um 21:52 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:06PM +0100, Thomas Zimmermann wrote: Test for connectors in the client code and remove a similar test from the generic fbdev emulation. Do nothing if the test fails. Not having connectors indicates a driver

Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

2023-01-27 Thread Michal Koutný
On Fri, Jan 27, 2023 at 01:31:54PM +, Tvrtko Ursulin wrote: > I think you missed the finish_suspend_scanning() part: > > if (root_drmcs.suspended_period_us) > cancel_delayed_work_sync(&root_drmcs.scan_work); > > So if scanning was in progress migration will wait until it

Re: [PATCH] drm: override detected status for connectors which are forced on

2023-01-27 Thread Maxime Ripard
Hi Michael, all, On Fri, Jan 20, 2023 at 10:03:48AM +0100, Michael Rodin wrote: > Hi Maxime, > > thank you for your feedback! > On Thu, Dec 22, 2022 at 06:40:54PM +0100, Maxime Ripard wrote: > > Hi, > > > > On Thu, Dec 15, 2022 at 06:03:59PM +0100, Michael Rodin wrote: > > > The detected status

Re: [PATCH 3/7] drm/vmwgfx: Rename vmw_buffer_object to vmw_bo

2023-01-27 Thread Thomas Zimmermann
Am 26.01.23 um 18:38 schrieb Zack Rusin: From: Zack Rusin The rest of the drivers which are using ttm have mostly standardized on driver_prefix_bo as the name for subclasses of the TTM buffer object. Make vmwgfx match the rest of the drivers and follow the same naming semantics. This is espe

Re: [Intel-gfx] [PATCH] drm/i915: Avoid potential vm use-after-free

2023-01-27 Thread Tvrtko Ursulin
On 27/01/2023 13:10, Matthew Auld wrote: On Mon, 23 Jan 2023 at 16:57, Tvrtko Ursulin wrote: + some more people based on e1a7ab4fca0c On 19/01/2023 17:32, Rob Clark wrote: From: Rob Clark Adding the vm to the vm_xa table makes it visible to userspace, which could try to race with us to

Re: [PATCH 1/7] drm/vmwgfx: Use the common gem mmap instead of the custom code

2023-01-27 Thread Thomas Zimmermann
Hi Am 26.01.23 um 18:38 schrieb Zack Rusin: From: Zack Rusin Before vmwgfx supported gem it needed to implement the entire mmap logic explicitly. With GEM support that's not needed and the generic code can be used by simply setting the vm_ops to vmwgfx specific ones on the gem object itself.

Re: [PATCH 6/7] drm/vmwgfx: Abstract placement selection

2023-01-27 Thread Thomas Zimmermann
Hi Am 26.01.23 um 18:38 schrieb Zack Rusin: From: Zack Rusin Problem with explicit placement selection in vmwgfx is that by the time the buffer object needs to be validated the information about which placement was supposed to be used is lost. To workaround this the driver had a bunch of state

Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

2023-01-27 Thread Tvrtko Ursulin
On 27/01/2023 13:01, Michal Koutný wrote: On Thu, Jan 12, 2023 at 04:56:07PM +, Tvrtko Ursulin wrote: +static int drmcs_can_attach(struct cgroup_taskset *tset) +{ + int ret; + + /* +* As processes are getting moved between groups we need to ensure +* both that

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-27 Thread Christian König
Am 27.01.23 um 14:12 schrieb Danilo Krummrich: On 1/27/23 08:55, Christian König wrote: Am 27.01.23 um 02:26 schrieb Danilo Krummrich: On 1/27/23 02:05, Matthew Brost wrote: On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: This commit provides the interfaces for the new UA

Re: [PATCH 5/7] drm/vmwgfx: Cleanup the vmw bo usage in the cursor paths

2023-01-27 Thread Thomas Zimmermann
Hi Am 26.01.23 um 18:38 schrieb Zack Rusin: From: Zack Rusin Base mapped count is useless because the ttm unmap functions handle null maps just fine so completely remove all the code related to it. Rename dummy to is_iomem because that's what it is even if we're not activelly using it. Makes t

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-27 Thread Danilo Krummrich
On 1/27/23 08:55, Christian König wrote: Am 27.01.23 um 02:26 schrieb Danilo Krummrich: On 1/27/23 02:05, Matthew Brost wrote: On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: This commit provides the interfaces for the new UAPI motivated by the Vulkan API. It allows user mode

Re: [Intel-gfx] [PATCH] drm/i915: Avoid potential vm use-after-free

2023-01-27 Thread Matthew Auld
On Mon, 23 Jan 2023 at 16:57, Tvrtko Ursulin wrote: > > > + some more people based on e1a7ab4fca0c > > On 19/01/2023 17:32, Rob Clark wrote: > > From: Rob Clark > > > > Adding the vm to the vm_xa table makes it visible to userspace, which > > could try to race with us to close the vm. So we need

Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

2023-01-27 Thread Michal Koutný
On Thu, Jan 12, 2023 at 04:56:07PM +, Tvrtko Ursulin wrote: > +static int drmcs_can_attach(struct cgroup_taskset *tset) > +{ > + int ret; > + > + /* > + * As processes are getting moved between groups we need to ensure > + * both that the old group does not see a sudden down

Re: [RFC v3 00/12] DRM scheduling cgroup controller

2023-01-27 Thread Michal Koutný
On Fri, Jan 27, 2023 at 11:40:58AM +, Tvrtko Ursulin wrote: > The main point is, should someone prove me wrong and come up a smarter way > at some point in the future, then "drm.weight" as an ABI remains compatible > and the improvement can happen completely under the hood. In the mean time >

Re: [PATCH v2 01/16] of: device: make of_device_uevent_modalias() take a const device *

2023-01-27 Thread Greg Kroah-Hartman
On Wed, Jan 11, 2023 at 08:54:04AM -0600, Rob Herring wrote: > On Wed, Jan 11, 2023 at 5:30 AM Greg Kroah-Hartman > wrote: > > > > of_device_uevent_modalias() does not modify the device pointer passed to > > it, so mark it constant. In order to properly do this, a number of > > busses need to hav

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

2023-01-27 Thread Marek Vasut
On 1/27/23 12:04, Jagan Teki wrote: On Fri, Jan 27, 2023 at 4:26 PM Rasmus Villemoes wrote: On 27/01/2023 11.39, Jagan Teki wrote: On Fri, Jan 27, 2023 at 4:03 PM Rasmus Villemoes wrote: Hi Jagan and others I'm trying to test this series on our imx8mp-based boards, which has the mipi-dsi

Re: [PATCH] drm/nouveau/mmu: fix Use after Free bug in nvkm_vmm_node_split

2023-01-27 Thread Takashi Iwai
On Tue, 03 Jan 2023 15:07:55 +0100, Takashi Iwai wrote: > > On Fri, 30 Dec 2022 08:27:58 +0100, > Zheng Wang wrote: > > > > Here is a function call chain. > > nvkm_vmm_pfn_map->nvkm_vmm_pfn_split_merge->nvkm_vmm_node_split > > If nvkm_vma_tail return NULL in nvkm_vmm_node_split, it will > > final

Re: [RFC v3 00/12] DRM scheduling cgroup controller

2023-01-27 Thread Tvrtko Ursulin
On 27/01/2023 10:04, Michal Koutný wrote: On Thu, Jan 26, 2023 at 05:57:24PM +, Tvrtko Ursulin wrote: So even if the RFC shows just a simple i915 implementation, the controller itself shouldn't prevent a smarter approach (via exposed ABI). scan/query + over budget notification is IMO l

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-01-27 Thread Karol Herbst
Where was the original email sent to anyway, because I don't have it at all. Anyhow, I suspect we want to fetch logs to see what's happening, but due to the nature of this bug it might get difficult. I'm checking out the laptops I have here if I can reproduce this issue, but I think all mine with

Re: [PATCH 3/3] drm/msm/disp/dpu1: reserve the resources on topology change

2023-01-27 Thread Dmitry Baryshkov
On Fri, 27 Jan 2023 at 12:15, Kalyan Thota wrote: > > Some features like ctm can be enabled dynamically. Release and reserve > the dpu resources whenever a topology change occurs such that > required hw blocks are allocated appropriately. > > Signed-off-by: Kalyan Thota > --- > drivers/gpu/drm/m

  1   2   >