Re: [Intel-xe] [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager

2023-02-22 Thread Thomas Hellström
Hi, On 2/22/23 12:39, Christian König wrote: Hi Thomas, Am 22.02.23 um 12:00 schrieb Thomas Hellström: Hi, Christian, So I resurrected Maarten's previous patch series around this (the amdgpu suballocator) slightly modified the code to match the API of this patch series, re-introduced the

Re: [PATCH 3/3] drm/debugfs: remove dev->debugfs_list and debugfs_mutex

2023-02-22 Thread Stanislaw Gruszka
On Fri, Feb 17, 2023 at 08:38:28PM +0100, Daniel Vetter wrote: > > > > > I'm firmly in the camp that debugfs does not need to work under all > > > > > conditions, but that it must fail gracefully instead of crashing. > > > > Yeah I mean once we talk bring-up, you can just hand-roll the necessary >

Re: [PATCH] drm/msm: Fix possible uninitialized access in fbdev

2023-02-22 Thread Thomas Zimmermann
Hi Am 22.02.23 um 13:37 schrieb Dmitry Baryshkov: On 22/02/2023 14:37, Thomas Zimmermann wrote: Do not run drm_fb_helper_unprepare() if fbdev allocation fails. Avoids access to an uninitialized pointer. Original bug report is at [1]. Reported-by: kernel test robot Signed-off-by: Thomas

Re: [PATCH] drm/msm: Fix possible uninitialized access in fbdev

2023-02-22 Thread Dmitry Baryshkov
On 22/02/2023 14:37, Thomas Zimmermann wrote: Do not run drm_fb_helper_unprepare() if fbdev allocation fails. Avoids access to an uninitialized pointer. Original bug report is at [1]. Reported-by: kernel test robot Signed-off-by: Thomas Zimmermann Fixes: 3fb1f62f80a1 ("drm/fb-helper: Remove

[PATCH] drm/msm: Fix possible uninitialized access in fbdev

2023-02-22 Thread Thomas Zimmermann
Do not run drm_fb_helper_unprepare() if fbdev allocation fails. Avoids access to an uninitialized pointer. Original bug report is at [1]. Reported-by: kernel test robot Signed-off-by: Thomas Zimmermann Fixes: 3fb1f62f80a1 ("drm/fb-helper: Remove drm_fb_helper_unprepare() from

Re: [Intel-xe] [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager

2023-02-22 Thread Christian König
Hi Thomas, Am 22.02.23 um 12:00 schrieb Thomas Hellström: Hi, Christian, So I resurrected Maarten's previous patch series around this (the amdgpu suballocator) slightly modified the code to match the API of this patch series, re-introduced the per-allocation alignment as per a previous

Re: [RFC] drm/msm/adreno: Balance pm_runtime enable

2023-02-22 Thread Johan Hovold
On Fri, Feb 10, 2023 at 08:10:00AM -0800, Rob Clark wrote: > On Fri, Feb 3, 2023 at 10:12 AM Bjorn Andersson > wrote: > > > > When any of the components in the mdss hierarchy fails to bind, > > previously bound components are being unbound again. > > > > One such case happens when the DP

Re: [PATCH v4 01/14] dma-buf/dma-fence: Add deadline awareness

2023-02-22 Thread Luben Tuikov
On 2023-02-18 16:15, Rob Clark wrote: > From: Rob Clark > > Add a way to hint to the fence signaler of an upcoming deadline, such as > vblank, which the fence waiter would prefer not to miss. This is to aid > the fence signaler in making power management decisions, like boosting > frequency as

Re: [Intel-xe] [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager

2023-02-22 Thread Thomas Hellström
Hi, Christian, So I resurrected Maarten's previous patch series around this (the amdgpu suballocator) slightly modified the code to match the API of this patch series, re-introduced the per-allocation alignment as per a previous review comment from you on that series, and made checkpatch.pl

Re: [PATCH v4 11/14] drm/atomic-helper: Set fence deadline for vblank

2023-02-22 Thread Luben Tuikov
On 2023-02-18 16:15, Rob Clark wrote: > From: Rob Clark > > For an atomic commit updating a single CRTC (ie. a pageflip) calculate > the next vblank time, and inform the fence(s) of that deadline. > > v2: Comment typo fix (danvet) > > Signed-off-by: Rob Clark > Reviewed-by: Daniel Vetter >

Re: [PATCH v7 1/2] drm/mediatek: change mmsys compatible for mt8195 mediatek-drm

2023-02-22 Thread AngeloGioacchino Del Regno
Il 27/12/22 08:47, Jason-JH.Lin ha scritto: Because compatible of mt8195 is changing from "mediatek,mt8195-mmsys" to "mediatek,mt8195-vdosys0". We have to revert the multiple compatible finding function and add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver. Signed-off-by:

Re: [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-22 Thread Luben Tuikov
On 2023-02-18 16:15, Rob Clark wrote: > From: Rob Clark > > Will be used in the next commit to set a deadline on fences that an > atomic update is waiting on. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/drm_vblank.c | 32 > include/drm/drm_vblank.h

Re: [Intel-gfx] [PATCH v5 0/7] Introduce __xchg, non-atomic xchg

2023-02-22 Thread Andrzej Hajda
Hi, Ping on the series. Arnd, Andrew is there anything more I can do to push the process forward? Regards Andrzej On 18.01.2023 16:35, Andrzej Hajda wrote: Hi all, The helper is tiny and there are advices we can live without it, so I want to present few arguments why it would be good to

Re: [PATCH v4 03/14] dma-buf/fence-chain: Add fence deadline support

2023-02-22 Thread Tvrtko Ursulin
On 18/02/2023 21:15, Rob Clark wrote: From: Rob Clark Propagate the deadline to all the fences in the chain. Signed-off-by: Rob Clark Reviewed-by: Christian König for this one. --- drivers/dma-buf/dma-fence-chain.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-22 Thread Luben Tuikov
On 2023-02-22 04:49, Pekka Paalanen wrote: > On Tue, 21 Feb 2023 09:53:56 -0800 > Rob Clark wrote: > >> On Tue, Feb 21, 2023 at 8:48 AM Luben Tuikov wrote: >>> >>> On 2023-02-20 11:14, Rob Clark wrote: On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen wrote: > > On Sat, 18

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-02-22 Thread Christian König
Am 17.02.23 um 14:44 schrieb Danilo Krummrich: Add infrastructure to keep track of GPU virtual address (VA) mappings with a decicated VA space manager implementation. New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers start implementing, allow userspace applications to

Re: [PATCH v4 01/14] dma-buf/dma-fence: Add deadline awareness

2023-02-22 Thread Tvrtko Ursulin
On 18/02/2023 21:15, Rob Clark wrote: From: Rob Clark Add a way to hint to the fence signaler of an upcoming deadline, such as vblank, which the fence waiter would prefer not to miss. This is to aid the fence signaler in making power management decisions, like boosting frequency as the

Re: [PATCH v5 09/14] drm/syncobj: Add deadline support for syncobj waits

2023-02-22 Thread Pekka Paalanen
On Tue, 21 Feb 2023 09:25:18 -0800 Rob Clark wrote: > On Tue, Feb 21, 2023 at 12:53 AM Pekka Paalanen wrote: > > > > On Mon, 20 Feb 2023 12:18:56 -0800 > > Rob Clark wrote: > > > > > From: Rob Clark > > > > > > Add a new flag to let userspace provide a deadline as a hint for syncobj > > >

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

2023-02-22 Thread Frieder Schrempf
On 17.02.23 19:22, Rasmus Villemoes wrote: > On 07/02/2023 10.09, Rasmus Villemoes wrote: > >> I managed to get the whole chain lcdif -> mipi -> bridge -> dp-connector >> to probe with these settings >> > [...] >> Now hotplug-detect doesn't work with the current sn65dsi86 driver, but >> that's a

Re: [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

2023-02-22 Thread Pekka Paalanen
On Tue, 21 Feb 2023 09:50:20 -0800 Rob Clark wrote: > On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä > wrote: > > > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > > On Mon, 20 Feb 2023 07:55:41 -0800 > > > Rob Clark wrote: > > > > > > > On Mon, Feb 20, 2023 at 1:08 AM

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-22 Thread Pekka Paalanen
On Tue, 21 Feb 2023 09:53:56 -0800 Rob Clark wrote: > On Tue, Feb 21, 2023 at 8:48 AM Luben Tuikov wrote: > > > > On 2023-02-20 11:14, Rob Clark wrote: > > > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen > > > wrote: > > >> > > >> On Sat, 18 Feb 2023 13:15:49 -0800 > > >> Rob Clark

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-02-22 Thread Krzysztof Kozlowski
On 20/02/2023 13:12, Jianhua Lu wrote: > Novatek NT36523 is a display driver IC used to drive DSI panels. > > Signed-off-by: Jianhua Lu > --- > Changes in v2: > - Drop unnecessary description > - dsi0 -> dsi Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 06/10] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186

2023-02-22 Thread AngeloGioacchino Del Regno
Il 22/02/23 09:37, Chen-Yu Tsai ha scritto: On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno wrote: Get GPU support on MT8186 by adding its compatible. Signed-off-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 + 1 file

Re: [PATCH v12 03/10] drm/display: Add Type-C switch helpers

2023-02-22 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Tue, Feb 21, 2023 at 7:48 PM Andy Shevchenko wrote: > > On Tue, Feb 21, 2023 at 05:50:47PM +0800, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output between two downstream devices.

Re: [PATCH v2 00/10] Panfrost: Improve and add MediaTek SoCs support

2023-02-22 Thread Chen-Yu Tsai
On Wed, Feb 22, 2023 at 3:55 PM Chen-Yu Tsai wrote: > > On Tue, Feb 21, 2023 at 04:37:30PM +0100, AngeloGioacchino Del Regno wrote: > > Changes in v2: > > - Add power-domain-names commit from Chen-Yu to the series > > - Kept sram-supply in base schema, overridden for non-MediaTek > > - Added

Re: [PATCH v2 06/10] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186

2023-02-22 Thread Chen-Yu Tsai
On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno wrote: > > Get GPU support on MT8186 by adding its compatible. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 + > 1 file changed, 5 insertions(+) > > diff

Re: [PATCH 1/2] drm: rcar-du: Don't write unimplemented ESCR and OTAR registers on Gen3

2023-02-22 Thread Tomi Valkeinen
On 22/02/2023 07:06, Laurent Pinchart wrote: The ESCR and OTAR registers are not present in all DU channels on Gen3 SoCs. ESCR only exists in channels that can be routed to an LVDS or DPAD, and OTAR in channels that can be routed to a DPAD. Skip writing those registers for other channels. This

Re: [PATCH v2 05/10] dt-bindings: gpu: mali-bifrost: Add new MT8183 compatible

2023-02-22 Thread Chen-Yu Tsai
On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno wrote: > > Since new platform data was required in Panfrost for getting GPU DVFS > finally working on MediaTek SoCs, add a new "mediatek,mt8183b-mali" > compatible. > > Signed-off-by: AngeloGioacchino Del Regno > > Reviewed-by: Rob

Re: [PATCH v2 04/10] dt-bindings: gpu: mali-bifrost: Add compatible for MT8195 SoC

2023-02-22 Thread Chen-Yu Tsai
On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno wrote: > > The MediaTek MT8195 SoC has a Mali G57 MC5 (Valhall-JM) and has the > same number of power domains and requirements as MT8192 in terms of > bindings. > > Signed-off-by: AngeloGioacchino Del Regno > > Reviewed-by: Rob Herring

Re: [PATCH v2 03/10] dt-bindings: gpu: mali-bifrost: Allow up to 5 power domains for MT8192

2023-02-22 Thread Chen-Yu Tsai
On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno wrote: > > MediaTek MT8192 (and similar) needs five power domains for the > Mali GPU and no sram-supply: change the binding to allow so. > > Fixes: 5d82e74a97c2 ("dt-bindings: Add compatible for Mali Valhall (JM)") > Signed-off-by:

<    1   2