Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-02-28 Thread Marc Kleine-Budde
On 28.02.2023 15:54:33, Rob Herring wrote: > SPI and I2C bus node names are expected to be "spi" or "i2c", > respectively, with nothing else, a unit-address, or a '-N' index. A > pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these > cases. Mostly scripted with the following

[PATCH v6 2/2] MAINTAINERS: add maintainers for DRM LOONGSON driver

2023-02-28 Thread suijingfeng
From: suijingfeng This patch add myself as maintainer to fix following warning when run ./scripts/checkpatch.pl WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? Signed-off-by: suijingfeng Signed-off-by: suijingfeng <15330273...@189.cn> --- MAINTAINERS | 7 +++

[PATCH v6 1/2] drm: add kms driver for loongson display controller

2023-02-28 Thread suijingfeng
From: suijingfeng Loongson display controller IP has been integrated in both Loongson North Bridge chipset(ls7a1000 and ls7a2000) and Loongson SoCs(ls2k1000 and ls2k2000 etc), it even has been included in Loongson BMC products. This display controller is a PCI device, it has two display pipe.

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-02-28 Thread Wolfram Sang
4:33PM -0600, Rob Herring wrote: > SPI and I2C bus node names are expected to be "spi" or "i2c", > respectively, with nothing else, a unit-address, or a '-N' index. A > pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these > cases. Mostly scripted with the following commands: > > git

Re: [PATCH v4] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Gerd Hoffmann
On Wed, Mar 01, 2023 at 03:37:24AM +0300, Dmitry Osipenko wrote: > On 2/28/23 18:54, Rob Clark wrote: > > From: Rob Clark > > > > Add a build option to disable modesetting support. This is useful in > > cases where the guest only needs to use the GPU in a headless mode, or > > (such as in the

Re: [PATCH v7 01/15] dma-buf/dma-fence: Add deadline awareness

2023-02-28 Thread Bagas Sanjaya
On Mon, Feb 27, 2023 at 11:35:07AM -0800, Rob Clark wrote: > diff --git a/Documentation/driver-api/dma-buf.rst > b/Documentation/driver-api/dma-buf.rst > index 622b8156d212..183e480d8cea 100644 > --- a/Documentation/driver-api/dma-buf.rst > +++ b/Documentation/driver-api/dma-buf.rst > @@ -164,6

Re: [PATCH v4 3/4] drm/msm/dpu: Remove empty prepare_commit() function

2023-02-28 Thread Dmitry Baryshkov
On 21/02/2023 20:42, Jessica Zhang wrote: Now that the TE setup has been moved to prepare_for_kickoff(), we have not prepare_commit() callbacks left. This makes dpu_encoder_prepare_commit() do nothing. Remove prepare_commit() from DPU driver. Changes in V3: - Reworded commit message to be more

Re: [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-02-28 Thread Dmitry Baryshkov
On 21/02/2023 20:42, Jessica Zhang wrote: Currently, DPU will enable TE during prepare_commit(). However, this will cause a crash and reboot to sahara when trying to read/write to register in get_autorefresh_config(), because the core clock rates aren't set at that time. This used to work

Re: [PATCH v7 00/15] dma-fence: Deadline awareness

2023-02-28 Thread Bagas Sanjaya
On 2/28/23 22:44, Rob Clark wrote: > You can find my branch here: > > https://gitlab.freedesktop.org/robclark/msm/-/commits/dma-fence/deadline > Pulled, thanks! -- An old man doll... just what I always wanted! - Clara

Re: [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-02-28 Thread Dmitry Baryshkov
On Wed, 1 Mar 2023 at 02:17, Kuogee Hsieh wrote: > > There is a reboot/suspend test case where system suspend is forced > during system booting up. Since dp_display_host_init() of external > DP is executed at hpd thread context, this test case may created a > scenario that

[PATCH] drm/i915/gt: Create per-tile debugfs files

2023-02-28 Thread Andi Shyti
To support multi-GT configurations, we need to generate independent debug files for each GT. To achieve this create a separate directory for each GT under the debugfs directory. For instance, in a system with four tiles, the debugfs structure would look like this: /sys/kernel/debug/dri

Re: [PATCH v4] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Dmitry Osipenko
On 2/28/23 18:54, Rob Clark wrote: > From: Rob Clark > > Add a build option to disable modesetting support. This is useful in > cases where the guest only needs to use the GPU in a headless mode, or > (such as in the CrOS usage) window surfaces are proxied to a host > compositor. > > As the

[PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-02-28 Thread Kuogee Hsieh
There is a reboot/suspend test case where system suspend is forced during system booting up. Since dp_display_host_init() of external DP is executed at hpd thread context, this test case may created a scenario that dp_display_host_deinit() from pm_suspend() run before dp_display_host_init() if hpd

Re: [PATCH v2 11/50] drm/msm/dpu: drop DPU_DIM_LAYER from MIXER_MSM8998_MASK

2023-02-28 Thread Abhinav Kumar
On 2/11/2023 3:12 PM, Dmitry Baryshkov wrote: The msm8998 doesn't seem to support DIM_LAYER, so drop it from the supported features mask. Fixes: 2d8a4edb672d ("drm/msm/dpu: use feature bit for LM combined alpha check") Fixes: 94391a14fc27 ("drm/msm/dpu1: Add MSM8998 to hw catalog")

[PATCH v8 16/16] drm/i915: Add deadline based boost support

2023-02-28 Thread Rob Clark
From: Rob Clark v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7503dcb9043b..44491e7e214c 100644 ---

[PATCH v8 15/16] drm/msm/atomic: Switch to vblank_start helper

2023-02-28 Thread Rob Clark
From: Rob Clark Drop our custom thing and switch to drm_crtc_next_vblank_start() for calculating the time of the start of the next vblank period. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 15 --- drivers/gpu/drm/msm/msm_atomic.c| 8 +---

[PATCH v8 14/16] drm/msm: Add wait-boost support

2023-02-28 Thread Rob Clark
From: Rob Clark Add a way for various userspace waits to signal urgency. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 12 drivers/gpu/drm/msm/msm_gem.c | 5 + include/uapi/drm/msm_drm.h| 14 -- 3 files changed, 25 insertions(+), 6 deletions(-)

[PATCH v8 11/16] drm/vblank: Add helper to get next vblank time

2023-02-28 Thread Rob Clark
From: Rob Clark Will be used in the next commit to set a deadline on fences that an atomic update is waiting on. v2: Calculate time at *start* of vblank period, not end v3: Fix kbuild complaints Signed-off-by: Rob Clark Reviewed-by: Mario Kleiner --- drivers/gpu/drm/drm_vblank.c | 53

[PATCH v8 13/16] drm/msm: Add deadline based boost support

2023-02-28 Thread Rob Clark
From: Rob Clark Track the nearest deadline on a fence timeline and set a timer to expire shortly before to trigger boost if the fence has not yet been signaled. v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_fence.c | 74 +

[PATCH v8 12/16] drm/atomic-helper: Set fence deadline for vblank

2023-02-28 Thread Rob Clark
From: Rob Clark For an atomic commit updating a single CRTC (ie. a pageflip) calculate the next vblank time, and inform the fence(s) of that deadline. v2: Comment typo fix (danvet) Signed-off-by: Rob Clark Reviewed-by: Daniel Vetter Signed-off-by: Rob Clark ---

[PATCH v8 09/16] drm/scheduler: Add fence deadline support

2023-02-28 Thread Rob Clark
As the finished fence is the one that is exposed to userspace, and therefore the one that other operations, like atomic update, would block on, we need to propagate the deadline from from the finished fence to the actual hw fence. v2: Split into drm_sched_fence_set_parent() (ckoenig) v3: Ensure a

[PATCH v8 10/16] drm/syncobj: Add deadline support for syncobj waits

2023-02-28 Thread Rob Clark
From: Rob Clark Add a new flag to let userspace provide a deadline as a hint for syncobj and timeline waits. This gives a hint to the driver signaling the backing fences about how soon userspace needs it to compete work, so it can addjust GPU frequency accordingly. An immediate deadline can be

[PATCH v8 06/16] dma-buf/sync_file: Add SET_DEADLINE ioctl

2023-02-28 Thread Rob Clark
From: Rob Clark The initial purpose is for igt tests, but this would also be useful for compositors that wait until close to vblank deadline to make decisions about which frame to show. The igt tests can be found at:

[PATCH v8 02/16] dma-buf/fence-array: Add fence deadline support

2023-02-28 Thread Rob Clark
From: Rob Clark Propagate the deadline to all the fences in the array. Signed-off-by: Rob Clark Reviewed-by: Christian König --- drivers/dma-buf/dma-fence-array.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/dma-buf/dma-fence-array.c

[PATCH v8 07/16] dma-buf/sync_file: Support (E)POLLPRI

2023-02-28 Thread Rob Clark
From: Rob Clark Allow userspace to use the EPOLLPRI/POLLPRI flag to indicate an urgent wait (as opposed to a "housekeeping" wait to know when to cleanup after some work has completed). Usermode components of GPU driver stacks often poll() on fence fd's to know when it is safe to do things like

[PATCH v8 08/16] dma-buf/sw_sync: Add fence deadline support

2023-02-28 Thread Rob Clark
From: Rob Clark This consists of simply storing the most recent deadline, and adding an ioctl to retrieve the deadline. This can be used in conjunction with the SET_DEADLINE ioctl on a fence fd for testing. Ie. create various sw_sync fences, merge them into a fence-array, set deadline on the

[PATCH v8 05/16] dma-buf/sync_file: Surface sync-file uABI

2023-02-28 Thread Rob Clark
From: Rob Clark We had all of the internal driver APIs, but not the all important userspace uABI, in the dma-buf doc. Fix that. And re-arrange the comments slightly as otherwise the comments for the ioctl nr defines would not show up. Signed-off-by: Rob Clark ---

[PATCH v8 04/16] dma-buf/dma-resv: Add a way to set fence deadline

2023-02-28 Thread Rob Clark
From: Rob Clark Add a way to set a deadline on remaining resv fences according to the requested usage. Signed-off-by: Rob Clark Reviewed-by: Christian König --- drivers/dma-buf/dma-resv.c | 22 ++ include/linux/dma-resv.h | 2 ++ 2 files changed, 24 insertions(+) diff

[PATCH v8 03/16] dma-buf/fence-chain: Add fence deadline support

2023-02-28 Thread Rob Clark
From: Rob Clark Propagate the deadline to all the fences in the chain. v2: Use dma_fence_chain_contained [Tvrtko] Signed-off-by: Rob Clark Reviewed-by: Christian König for this one. --- drivers/dma-buf/dma-fence-chain.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v8 01/16] dma-buf/dma-fence: Add deadline awareness

2023-02-28 Thread Rob Clark
From: Rob Clark Add a way to hint to the fence signaler of an upcoming deadline, such as vblank, which the fence waiter would prefer not to miss. This is to aid the fence signaler in making power management decisions, like boosting frequency as the deadline approaches and awareness of missing

[PATCH v8 00/16] dma-fence: Deadline awareness

2023-02-28 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1) To

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-28 Thread Rob Clark
On Tue, Feb 28, 2023 at 6:30 AM Sebastian Wick wrote: > > On Tue, Feb 28, 2023 at 12:48 AM Rob Clark wrote: > > > > On Mon, Feb 27, 2023 at 2:44 PM Sebastian Wick > > wrote: > > > > > > On Mon, Feb 27, 2023 at 11:20 PM Rob Clark wrote: > > > > > > > > On Mon, Feb 27, 2023 at 1:36 PM Rodrigo

Re: [PATCH v2 0/2] drm/vc4: Improve drm_gem_object handling

2023-02-28 Thread Maíra Canal
On 2/2/23 08:19, Maíra Canal wrote: Currently, the array of BOs that are lookup up at the start of exec is being instantiated as drm_gem_dma_object, which is not needed and makes it difficult to use the drm_gem_objects_lookup() helper. Therefore, replace drm_gem_dma_object for drm_gem_object and

[PATCH] drm/nouveau/fifo: set nvkm_engn_cgrp_get storage-class-specifier to static

2023-02-28 Thread Tom Rix
smatch reports drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:33:18: warning: symbol 'nvkm_engn_cgrp_get' was not declared. Should it be static? nvkm_engn_cgrp_get is only used in runl.c, so it should be static Signed-off-by: Tom Rix --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c | 2

Re: [PATCH v7 10/15] drm/vblank: Add helper to get next vblank time

2023-02-28 Thread Mario Kleiner
LGTM. This one is Reviewed-by: Mario Kleiner -mario On Mon, Feb 27, 2023 at 8:36 PM Rob Clark wrote: > From: Rob Clark > > Will be used in the next commit to set a deadline on fences that an > atomic update is waiting on. > > v2: Calculate time at *start* of vblank period, not end > v3:

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-02-28 Thread Mark Brown
On Tue, Feb 28, 2023 at 03:54:33PM -0600, Rob Herring wrote: > SPI and I2C bus node names are expected to be "spi" or "i2c", > respectively, with nothing else, a unit-address, or a '-N' index. A > pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these > cases. Mostly scripted with the

[PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-02-28 Thread Rob Herring
SPI and I2C bus node names are expected to be "spi" or "i2c", respectively, with nothing else, a unit-address, or a '-N' index. A pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these cases. Mostly scripted with the following commands: git grep -l '\si2c[0-9] {'

AUXdisplay for LED arrays, keyboards with per-key LEDs -- was Re: [PATCH v2 2/2] leds: add aw20xx driver

2023-02-28 Thread Pavel Machek
Hi! > > +config LEDS_AW200XX > > + tristate "LED support for Awinic AW20036/AW20054/AW20072" > > + depends on LEDS_CLASS > > + depends on I2C > > + help > > + This option enables support for the AW20036/AW20054/AW20072 LED > > driver. > > + It is a 3x12/6x9/6x12 matrix LED driver

[PATCH v2] drm/edid: Fix csync detailed mode parsing

2023-02-28 Thread Ville Syrjala
From: Ville Syrjälä Remove the bogus csync check and replace it with something that: - triggers for all forms of csync, not just the basic analog variant - actually populates the mode csync flags so that drivers can decide what to do with the mode Originally the code tried to outright reject

Re: [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2023-02-28 Thread Dixit, Ashutosh
On Fri, 12 Aug 2022 11:06:58 -0700, Guenter Roeck wrote: > Hi Guenter/linux-hwmon, > On 8/12/22 10:37, Badal Nilawar wrote: > > From: Dale B Stimson > > > > Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. > > /snip/ > > Acked-by: Guenter Roeck > > > --- > >

Re: [Freedreno] [PATCH v3 04/15] drm/msm/a6xx: Extend and explain UBWC config

2023-02-28 Thread Konrad Dybcio
On 28.02.2023 21:48, Akhil P Oommen wrote: > On 3/1/2023 2:14 AM, Akhil P Oommen wrote: >> On 3/1/2023 2:10 AM, Konrad Dybcio wrote: >>> On 28.02.2023 21:23, Akhil P Oommen wrote: On 2/23/2023 5:36 PM, Konrad Dybcio wrote: > Rename lower_bit to hbb_lo and explain what it signifies.

Re: [Intel-gfx] [PATCH] drm/edid: Fix csync detailed mode parsing

2023-02-28 Thread Ville Syrjälä
On Tue, Feb 28, 2023 at 10:10:26PM +0200, Jani Nikula wrote: > On Mon, 27 Feb 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Remove the bogus csync check and replace it with something that: > > - triggers for all forms of csync, not just the basic analog variant > > - actually

Re: [LSF/MM/BPF proposal]: Physr discussion

2023-02-28 Thread T.J. Mercier
On Sat, Jan 21, 2023 at 7:03 AM Jason Gunthorpe wrote: > > I would like to have a session at LSF to talk about Matthew's > physr discussion starter: > > https://lore.kernel.org/linux-mm/ydykweu0htv8m...@casper.infradead.org/ > > I have become interested in this with some immediacy because of >

Re: [Freedreno] [PATCH v3 04/15] drm/msm/a6xx: Extend and explain UBWC config

2023-02-28 Thread Akhil P Oommen
On 3/1/2023 2:14 AM, Akhil P Oommen wrote: > On 3/1/2023 2:10 AM, Konrad Dybcio wrote: >> On 28.02.2023 21:23, Akhil P Oommen wrote: >>> On 2/23/2023 5:36 PM, Konrad Dybcio wrote: Rename lower_bit to hbb_lo and explain what it signifies. Add explanations (wherever possible to other

Re: [PATCH v3 04/15] drm/msm/a6xx: Extend and explain UBWC config

2023-02-28 Thread Akhil P Oommen
On 3/1/2023 2:10 AM, Konrad Dybcio wrote: > > On 28.02.2023 21:23, Akhil P Oommen wrote: >> On 2/23/2023 5:36 PM, Konrad Dybcio wrote: >>> Rename lower_bit to hbb_lo and explain what it signifies. >>> Add explanations (wherever possible to other tunables). >>> >>> Sort the variable definition and

Re: [PATCH v3 04/15] drm/msm/a6xx: Extend and explain UBWC config

2023-02-28 Thread Konrad Dybcio
On 28.02.2023 21:23, Akhil P Oommen wrote: > On 2/23/2023 5:36 PM, Konrad Dybcio wrote: >> Rename lower_bit to hbb_lo and explain what it signifies. >> Add explanations (wherever possible to other tunables). >> >> Sort the variable definition and assignment alphabetically. > Sorting based on

Re: [PATCH v3 04/15] drm/msm/a6xx: Extend and explain UBWC config

2023-02-28 Thread Akhil P Oommen
On 2/23/2023 5:36 PM, Konrad Dybcio wrote: > Rename lower_bit to hbb_lo and explain what it signifies. > Add explanations (wherever possible to other tunables). > > Sort the variable definition and assignment alphabetically. Sorting based on decreasing order of line length is more readable, isn't

Re: [Intel-gfx] [PATCH] drm/edid: Fix csync detailed mode parsing

2023-02-28 Thread Jani Nikula
On Mon, 27 Feb 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Remove the bogus csync check and replace it with something that: > - triggers for all forms of csync, not just the basic analog variant > - actually populates the mode csync flags so that drivers can > decide what to do with

[Bug 215511] Dual monitor with amd 5700 causes system to hang at startup.

2023-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215511 --- Comment #11 from Alex Deucher (alexdeuc...@gmail.com) --- Created attachment 303813 --> https://bugzilla.kernel.org/attachment.cgi?id=303813=edit possible fix 2/2 Do the two attached patches fix the issue? -- You may reply to this email

[Bug 215511] Dual monitor with amd 5700 causes system to hang at startup.

2023-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215511 --- Comment #10 from Alex Deucher (alexdeuc...@gmail.com) --- Created attachment 303812 --> https://bugzilla.kernel.org/attachment.cgi?id=303812=edit possible fix 1/2 -- You may reply to this email to add a comment. You are receiving this

Re: [PATCH v7 07/15] dma-buf/sw_sync: Add fence deadline support

2023-02-28 Thread Rob Clark
On Tue, Feb 28, 2023 at 1:23 AM Pekka Paalanen wrote: > > On Mon, 27 Feb 2023 11:35:13 -0800 > Rob Clark wrote: > > > From: Rob Clark > > > > This consists of simply storing the most recent deadline, and adding an > > ioctl to retrieve the deadline. This can be used in conjunction with > > the

Re: [PATCH v7 05/15] dma-buf/sync_file: Add SET_DEADLINE ioctl

2023-02-28 Thread Rob Clark
On Tue, Feb 28, 2023 at 1:22 AM Pekka Paalanen wrote: > > On Mon, 27 Feb 2023 11:35:11 -0800 > Rob Clark wrote: > > > From: Rob Clark > > > > The initial purpose is for igt tests, but this would also be useful for > > compositors that wait until close to vblank deadline to make decisions > >

Re: [PATCH 1/9] drm: execution context for GEM buffers v3

2023-02-28 Thread Danilo Krummrich
On 2/28/23 09:33, Christian König wrote: This adds the infrastructure for an execution context for GEM buffers which is similar to the existinc TTMs execbuf util and intended to replace "existing" it in the long term. The basic functionality is that we abstracts the necessary loop to lock

Re: Common DRM execution context v3

2023-02-28 Thread Danilo Krummrich
Hi Christian, On 2/28/23 09:33, Christian König wrote: Hi guys, thrid round for those patches. They have been in my queue for nearly a year now because I couldn't find much time to push into this. Danilo wants to use this for his GPU VAs tracker work and Arun needs it for hist secure

Re: [PATCH v2] drm/msm/disp/dpu: fix sc7280_pp base offset

2023-02-28 Thread Dmitry Baryshkov
On 27/02/2023 23:36, Kuogee Hsieh wrote: At sc7280, pingpong block is used to management the dither effects to reduce distortion at panel. Currently pingpong-0 base offset is wrongly set at 0x59000. This mistake will not cause system to crash. However it will make dither not work. This patch

Re: [PATCH v2] drm/msm/disp/dpu: fix sc7280_pp base offset

2023-02-28 Thread Abhinav Kumar
On 2/27/2023 1:36 PM, Kuogee Hsieh wrote: At sc7280, pingpong block is used to management the dither effects to reduce distortion at panel. Currently pingpong-0 base offset is wrongly set at 0x59000. This mistake will not cause system to crash. However it will make dither not work. This patch

Re: [PATCH v7 01/15] dma-buf/dma-fence: Add deadline awareness

2023-02-28 Thread Rob Clark
On Tue, Feb 28, 2023 at 1:21 AM Pekka Paalanen wrote: > > On Mon, 27 Feb 2023 11:35:07 -0800 > Rob Clark wrote: > > > From: Rob Clark > > > > Add a way to hint to the fence signaler of an upcoming deadline, such as > > vblank, which the fence waiter would prefer not to miss. This is to aid > >

Re: [PATCH v2 1/1] drm/doc: Document DRM device reset expectations

2023-02-28 Thread Rob Clark
On Mon, Feb 27, 2023 at 12:40 PM André Almeida wrote: > > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Signed-off-by: André Almeida > --- > Documentation/gpu/drm-uapi.rst | 51 ++ > 1 file changed, 51

Re: [PATCH] MAINTAINERS: Add myself as co-maintainer for DRM Panels drivers

2023-02-28 Thread Sam Ravnborg
Hi Neil, On Mon, Feb 27, 2023 at 05:42:01PM +0100, Neil Armstrong wrote: > Hi Thierry, > > On 27/02/2023 16:37, Thierry Reding wrote: > > On Mon, Feb 27, 2023 at 09:22:02AM +0100, Neil Armstrong wrote: > > > Hi Sam ! > > > > > > On 17/02/2023 11:45, Sam Ravnborg wrote: > > > > On Fri, Feb 17,

[PATCH] drm/etnaviv: fix reference leak when mmaping imported buffer

2023-02-28 Thread Lucas Stach
drm_gem_prime_mmap() takes a reference on the GEM object, but before that drm_gem_mmap_obj() already takes a reference, which will be leaked as only one reference is dropped when the mapping is closed. Drop the extra reference when dma_buf_mmap() succeeds. Signed-off-by: Lucas Stach ---

Re: [PATCH 7/9] drm/radeon: switch over to drm_exec

2023-02-28 Thread kernel test robot
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-intel/for-linux-next linus/master next-20230228] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next-fixes v6.2] [If your

Re: [PATCH 8/9] drm/qxl: switch to using drm_exec

2023-02-28 Thread kernel test robot
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-intel/for-linux-next linus/master next-20230228] [cannot apply to drm-intel/for-linux-next-fixes v6.2] [If your patch is applied to the wrong

Re: [PATCH 06/10] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in > preparation to adding more configuration data. > > Signed-off-by: Dmitry Baryshkov > --- >

Re: [PATCH 07/10] drm/display/dsc: include the rest of pre-SCR parameters

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > DSC model contains pre-SCR RC parameters for other bpp/bpc combinations, > include them here for completeness. Need to run now, note to self: Does i915 use the arrays to limit the bpp/bpc combos supported by hardware? Do we need to add separate

Re: [PATCH 05/10] drm/display/dsc: use flat array for rc_parameters lookup

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > Next commits are going to add support for additional RC parameter lookup > tables. These tables are going to use different bpp/bpc combinations, > thus it makes little sense to keep the 2d array for RC parameters. > Switch to using the flat array. >

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-02-28 Thread Liam R. Howlett
* Danilo Krummrich [230227 21:17]: > On Tue, Feb 21, 2023 at 01:20:50PM -0500, Liam R. Howlett wrote: > > * Danilo Krummrich [230217 08:45]: > > > Add infrastructure to keep track of GPU virtual address (VA) mappings > > > with a decicated VA space manager implementation. > > > > > > New UAPIs,

Re: [PATCH 04/10] drm/i915/dsc: stop using interim structure for calculated params

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > Stop using an interim structure rc_parameters for storing calculated > params and then setting drm_dsc_config using that structure. Instead put > calculated params into the struct drm_dsc_config directly. > > Signed-off-by: Dmitry Baryshkov > --- >

Re: [PATCH 03/10] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > This moves DSC RC tables to DRM DSC helper. No additional code changes > and/or cleanups are a part of this commit, it will be cleaned up in the > followup commits. > > Signed-off-by: Dmitry Baryshkov > --- >

Re: [PATCH v4] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Javier Martinez Canillas
Rob Clark writes: Hello Rob, > From: Rob Clark > > Add a build option to disable modesetting support. This is useful in > cases where the guest only needs to use the GPU in a headless mode, or > (such as in the CrOS usage) window surfaces are proxied to a host > compositor. > > As the

Re: [PATCH 01/10] drm/i915/dsc: change DSC param tables to follow the DSC model

2023-02-28 Thread Dmitry Baryshkov
On 28/02/2023 17:56, Jani Nikula wrote: On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: After cross-checking DSC models (20150914, 20161212, 20210623) change values in rc_parameters tables to follow config files present inside the DSC model. Handle two places, where i915 tables diverged from the

Re: [PATCH 8/9] drm/qxl: switch to using drm_exec

2023-02-28 Thread kernel test robot
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-intel/for-linux-next linus/master next-20230228] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next-fixes v6.2] [If your

Re: [PATCH 02/10] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > The rc_buf_thresh values are common to all DSC implementations. Move > them to the common helper together with the code to propagage them to > the drm_dsc_config. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c

RE: [Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Saarinen, Jani
> -Original Message- > From: Intel-gfx On Behalf Of Thomas > Zimmermann > Sent: tiistai 28. helmikuuta 2023 17.46 > To: Dmitry Osipenko ; > maarten.lankho...@linux.intel.com; airl...@gmail.com; dan...@ffwll.ch; Nikula, > Jani > Cc: intel-...@lists.freedesktop.org;

Re: [PATCH 01/10] drm/i915/dsc: change DSC param tables to follow the DSC model

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > After cross-checking DSC models (20150914, 20161212, 20210623) change > values in rc_parameters tables to follow config files present inside > the DSC model. Handle two places, where i915 tables diverged from the > model, by patching the rc values in

[PATCH v4] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Rob Clark
From: Rob Clark Add a build option to disable modesetting support. This is useful in cases where the guest only needs to use the GPU in a headless mode, or (such as in the CrOS usage) window surfaces are proxied to a host compositor. As the modesetting ioctls are a big surface area for

Re: [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Thomas Zimmermann
Hi Am 28.02.23 um 16:28 schrieb Dmitry Osipenko: On 2/28/23 18:26, Thomas Zimmermann wrote: This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. The locking appears incomplete. A caller of SHMEM helper's pin function never acquires the dma-buf reservation lock. So we get WARNING:

Re: [PATCH v7 00/15] dma-fence: Deadline awareness

2023-02-28 Thread Rob Clark
On Tue, Feb 28, 2023 at 4:43 AM Bagas Sanjaya wrote: > > On Mon, Feb 27, 2023 at 11:35:06AM -0800, Rob Clark wrote: > > From: Rob Clark > > > > This series adds a deadline hint to fences, so realtime deadlines > > such as vblank can be communicated to the fence signaller for power/ > > frequency

Re: [PATCH v3] drm/virtio: Add option to disable KMS support

2023-02-28 Thread Rob Clark
On Tue, Feb 28, 2023 at 4:34 AM Thomas Zimmermann wrote: > > Hi > > Am 27.02.23 um 19:15 schrieb Rob Clark: > > On Mon, Feb 27, 2023 at 9:57 AM Dmitry Osipenko > > wrote: > >> > >> On 2/27/23 20:38, Rob Clark wrote: > >> ... > >>> + if (IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS)) { > >>> +

Re: [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Dmitry Osipenko
On 2/28/23 18:26, Thomas Zimmermann wrote: > This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. > > The locking appears incomplete. A caller of SHMEM helper's pin > function never acquires the dma-buf reservation lock. So we get > > WARNING: CPU: 3 PID: 967 at

[PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Thomas Zimmermann
This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. The locking appears incomplete. A caller of SHMEM helper's pin function never acquires the dma-buf reservation lock. So we get WARNING: CPU: 3 PID: 967 at drivers/gpu/drm/drm_gem_shmem_helper.c:243 drm_gem_shmem_pin+0x42/0x90

Re: [PATCH v2 1/1] drm/doc: Document DRM device reset expectations

2023-02-28 Thread André Almeida
Hi Pekka, Thank you for your feedback, On 2/28/23 05:02, Pekka Paalanen wrote: On Mon, 27 Feb 2023 15:40:00 -0500 André Almeida wrote: Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Signed-off-by: André Almeida ---

Re: [PATCH 03/10] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-02-28 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/drm-i915-dsc-change-DSC-param-tables-to-follow-the-DSC-model/20230228-193505 base: git

Re: gud: set PATH connector property

2023-02-28 Thread Peter Stuge
Simon Ser wrote: > > > Would it be possible to set the PATH connector property based on the > > > USB port used by gud? > > > > Sadly not really easily. > > > > The physical topology underneath each host controller is stable but > > bus numbers (usb1, usb2 etc.) are not. > > Oh, that's news to

Re: [PATCH v13 04/18] drm: exynos: dsi: Switch to DSI panel or bridge find helper

2023-02-28 Thread Jagan Teki
On Tue, Feb 28, 2023 at 8:26 PM Maxime Ripard wrote: > > On Tue, Feb 28, 2023 at 08:09:26PM +0530, Jagan Teki wrote: > > On Tue, Feb 28, 2023 at 5:34 PM Maxime Ripard wrote: > > > > > > On Tue, Feb 28, 2023 at 02:08:53AM +0530, Jagan Teki wrote: > > > > On Tue, Feb 28, 2023 at 1:40 AM Marek

Re: [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Andi Shyti
Hi, > > >> >> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation > > >> >> > lock") removes the drm_gem_shmem_get_pages_locked() and > > >> >> > drm_gem_shmem_put_pages_locked(). > > >> >> > > > >> >> > But then commit edaa0db9 ("drm/shmem-helper: Fix locking for > > >> >> >

Re: [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Dmitry Osipenko
On 2/28/23 17:40, Jani Nikula wrote: ... >>> And the build is indeed currently broken. >>> >>> Moreover, when the build was fine for a while, apparently the changes in >>> shmem broke a bunch of machines in Intel CI. And due to this, we aren't >>> getting any CI results for incoming patches right

RE: [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Saarinen, Jani
Hi, > -Original Message- > From: Nikula, Jani > Sent: tiistai 28. helmikuuta 2023 16.40 > To: Andi Shyti > Cc: Andi Shyti ; Dmitry Osipenko > ; dri-devel@lists.freedesktop.org; Maarten > Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; David > Airlie ; Daniel Vetter ; Javier Martinez >

Re: [PATCH v13 04/18] drm: exynos: dsi: Switch to DSI panel or bridge find helper

2023-02-28 Thread Maxime Ripard
On Tue, Feb 28, 2023 at 08:09:26PM +0530, Jagan Teki wrote: > On Tue, Feb 28, 2023 at 5:34 PM Maxime Ripard wrote: > > > > On Tue, Feb 28, 2023 at 02:08:53AM +0530, Jagan Teki wrote: > > > On Tue, Feb 28, 2023 at 1:40 AM Marek Vasut wrote: > > > > > > > > On 2/27/23 20:49, Jagan Teki wrote: > >

Re: [PATCH v13 04/18] drm: exynos: dsi: Switch to DSI panel or bridge find helper

2023-02-28 Thread Jagan Teki
On Tue, Feb 28, 2023 at 8:05 PM Maxime Ripard wrote: > > On Tue, Feb 28, 2023 at 06:04:39PM +0530, Jagan Teki wrote: > > On Tue, Feb 28, 2023 at 5:40 PM Maxime Ripard wrote: > > > > > > On Mon, Feb 27, 2023 at 08:41:22PM +0100, Marek Vasut wrote: > > > > > If we go ahead with no need for

Re: [PATCH 03/10] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-02-28 Thread kernel test robot
Hi Dmitry, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm/drm-next linus/master v6.2 next-20230228] [If your patch is applied to the wrong git tree

Re: [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Andi Shyti wrote: > Hi, > >> >> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation >> >> > lock") removes the drm_gem_shmem_get_pages_locked() and >> >> > drm_gem_shmem_put_pages_locked(). >> >> > >> >> > But then commit edaa0db9 ("drm/shmem-helper: Fix

Re: [PATCH v13 04/18] drm: exynos: dsi: Switch to DSI panel or bridge find helper

2023-02-28 Thread Jagan Teki
On Tue, Feb 28, 2023 at 5:34 PM Maxime Ripard wrote: > > On Tue, Feb 28, 2023 at 02:08:53AM +0530, Jagan Teki wrote: > > On Tue, Feb 28, 2023 at 1:40 AM Marek Vasut wrote: > > > > > > On 2/27/23 20:49, Jagan Teki wrote: > > > > On Tue, Feb 28, 2023 at 1:11 AM Marek Vasut wrote: > > > >> > > >

Re: [PATCH v13 04/18] drm: exynos: dsi: Switch to DSI panel or bridge find helper

2023-02-28 Thread Maxime Ripard
On Tue, Feb 28, 2023 at 06:04:39PM +0530, Jagan Teki wrote: > On Tue, Feb 28, 2023 at 5:40 PM Maxime Ripard wrote: > > > > On Mon, Feb 27, 2023 at 08:41:22PM +0100, Marek Vasut wrote: > > > > If we go ahead with no need for DRM-managed helper at the moment, then > > > > find the panel hook in

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-28 Thread Sebastian Wick
On Tue, Feb 28, 2023 at 12:48 AM Rob Clark wrote: > > On Mon, Feb 27, 2023 at 2:44 PM Sebastian Wick > wrote: > > > > On Mon, Feb 27, 2023 at 11:20 PM Rob Clark wrote: > > > > > > On Mon, Feb 27, 2023 at 1:36 PM Rodrigo Vivi > > > wrote: > > > > > > > > On Fri, Feb 24, 2023 at 09:59:57AM

Re: [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Andi Shyti
Hi, > >> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation > >> > lock") removes the drm_gem_shmem_get_pages_locked() and > >> > drm_gem_shmem_put_pages_locked(). > >> > > >> > But then commit edaa0db9 ("drm/shmem-helper: Fix locking for > >> > drm_gem_shmem_get_pages_sgt()")

Re: [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Andi Shyti wrote: > Hi Dmitry, > > On Tue, Feb 28, 2023 at 04:15:28PM +0300, Dmitry Osipenko wrote: >> Hi, >> >> On 2/28/23 15:50, Andi Shyti wrote: >> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation >> > lock") removes the drm_gem_shmem_get_pages_locked()

Re: [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Andi Shyti
Hi Dmitry, On Tue, Feb 28, 2023 at 04:15:28PM +0300, Dmitry Osipenko wrote: > Hi, > > On 2/28/23 15:50, Andi Shyti wrote: > > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation > > lock") removes the drm_gem_shmem_get_pages_locked() and > > drm_gem_shmem_put_pages_locked(). > > > >

Re: [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Dmitry Osipenko
Hi, On 2/28/23 15:50, Andi Shyti wrote: > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation > lock") removes the drm_gem_shmem_get_pages_locked() and > drm_gem_shmem_put_pages_locked(). > > But then commit edaa0db9 ("drm/shmem-helper: Fix locking for >

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Apply Wa_14017073508 for MTL SoC Step

2023-02-28 Thread Nilawar, Badal
Hi Matt, On 24-02-2023 02:43, Matt Roper wrote: On Thu, Feb 23, 2023 at 03:20:28PM -0500, Rodrigo Vivi wrote: On Fri, Feb 24, 2023 at 12:11:40AM +0530, Badal Nilawar wrote: Apply Wa_14017073508 for MTL SoC die A step instead of graphics step. To get the SoC die stepping there is no direct

Re: [PATCH 02/10] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-02-28 Thread Dmitry Baryshkov
On 28/02/2023 14:49, Jani Nikula wrote: On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: On Tue, 28 Feb 2023 at 14:25, Jani Nikula wrote: On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: The rc_buf_thresh values are common to all DSC implementations. Move them to the common helper together with

  1   2   >