[PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG

2023-03-20 Thread Roman Beranek
In the case of DSI output, the value of SUN4I_TCON0_DCLK_DIV (4) does not represent the actual dotclock divider, PLL_MIPI instead runs at (bpp / lanes )-multiple [1] of the dotclock. [2] Setting 4 as dotclock divder thus leads to reduced frame rate, specifically by 1/3 on 4-lane panels, and by 2/3

Re: [PATCH v0.5 0/9] i.MX8MP HDMI support

2023-03-20 Thread Tommaso Merciai
Hello Lucas, On Fri, May 06, 2022 at 08:10:25PM +0200, Lucas Stach wrote: > Hi all, > > second round of the i.MX8MP HDMI work. Still not split up into proper > parts for merging through the various trees this needs to go into, but > should make it easy for people to test. > > I've worked in the

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-20 Thread Matti Vaittinen
Morning Stephen, On 3/20/23 21:23, Stephen Boyd wrote: Quoting Matti Vaittinen (2023-03-18 23:36:20) I think you would have an easier time if you just copied and renamed them into the kunit folder as an preparation series. Yes. That would simplify the syncing between the trees. It slightly b

Re: Build regressions/improvements in v6.3-rc3 (drm/msm/)

2023-03-20 Thread Randy Dunlap
Hi-- On 3/20/23 01:21, Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v6.3-rc3[1] compared to v6.2[2]. > > Summarized: > - build errors: +9/-14 > - build warnings: +4/-1447 > > JFYI, when comparing v6.3-rc3[1] to v6.3-rc2[3], the summaries

Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

2023-03-20 Thread 林欣螢

Re: [PATCH v2 18/23] PM / QoS: Decouple request alloc from dev_pm_qos_mtx

2023-03-20 Thread Dan Carpenter
Hi Rob, https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Rob-Clark/drm-msm-Pre-allocate-hw_fence/20230320-224826 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r

Re: [PATCH v2 23/23] drm/sched: Add (optional) fence signaling annotation

2023-03-20 Thread Luben Tuikov
This is good. Hopefully it helps us catch lockdep bugs. Reviewed-by: Luben Tuikov Regards, Luben On 2023-03-20 10:43, Rob Clark wrote: > From: Rob Clark > > Based on > https://lore.kernel.org/dri-devel/20200604081224.863494-10-daniel.vet...@ffwll.ch/ > but made to be optional. > > Signed-off

Re: [PATCH v4 7/8] accel/qaic: Add qaic driver to the build system

2023-03-20 Thread kernel test robot
Hi Jeffrey, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on lwn/docs-next] [cannot apply to linus/master v6.3-rc3 next-20230320] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[PATCH 3/3] drm/vmwgfx: Fix Legacy Display Unit atomic drm support

2023-03-20 Thread Zack Rusin
From: Martin Krastev Legacy Display Unit (LDU) fb dirty support used a custom fb dirty callback. Latter handled only the DIRTYFB IOCTL presentation path but not the ADDFB2/PAGE_FLIP/RMFB IOCTL path, common for Wayland compositors. Get rid of the custom callback in favor of drm_atomic_helper_di

[PATCH 2/3] drm/vmwgfx: Print errors when running on broken/unsupported configs

2023-03-20 Thread Zack Rusin
From: Zack Rusin virtualbox implemented an incomplete version of the svga device which they decided to drop soon after the initial release. The device was always broken in various ways and never supported by vmwgfx. vmwgfx should refuse to load on those configurations but currently drm has no wa

[PATCH 1/3] drm/vmwgfx: Drop mksstat_init_record fn as currently unused

2023-03-20 Thread Zack Rusin
From: Martin Krastev This internal helper handles a type of mksstat event counter which is currently unused. Remove the routine to avoid compile warnings. Reported-by: kernel test robot Signed-off-by: Martin Krastev Reviewed-by: Maaz Mombasawala Reviewed-by: Zack Rusin Signed-off-by: Zack Ru

Re: [PATCH v4 7/8] accel/qaic: Add qaic driver to the build system

2023-03-20 Thread kernel test robot
Hi Jeffrey, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on lwn/docs-next] [cannot apply to linus/master v6.3-rc3 next-20230320] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[RFC PATCH v2 13/13] drm/msm/dpu: allow using two SSPP blocks for a single plane

2023-03-20 Thread Dmitry Baryshkov
Virtual wide planes give high amount of flexibility, but it is not always enough: In parallel multirect case only the half of the usual width is supported for tiled formats. Thus the whole width of two tiled multirect rectangles can not be greater than max_linewidth, which is not enough for some p

[RFC PATCH v2 07/13] drm/msm/dpu: move resource allocation to CRTC

2023-03-20 Thread Dmitry Baryshkov
All resource allocation is centered around the LMs. Then other blocks (except DSCs) are allocated basing on the LMs that was selected, and LM powers up the CRTC rather than the encoder. Moreover if at some point the driver supports encoder cloning, allocating resources from the encoder will be inc

[RFC PATCH v2 02/13] drm/msm/dpu: take plane rotation into account for wide planes

2023-03-20 Thread Dmitry Baryshkov
Take into account the plane rotation and flipping when calculating src positions for the wide plane parts. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 27 ++- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/m

[RFC PATCH v2 08/13] drm/msm/dpu: fill CRTC resources in dpu_crtc.c

2023-03-20 Thread Dmitry Baryshkov
Stop poking into CRTC state from dpu_encoder.c, fill CRTC HW resources from dpu_crtc_assign_resources(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 27 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 24 ++ 2 files change

[RFC PATCH v2 09/13] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check

2023-03-20 Thread Dmitry Baryshkov
In preparation to virtualized planes support, move pstate->pipe initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In case of virtual planes the plane's pipe will not be known up to the point of atomic_check() callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp

[RFC PATCH v2 10/13] drm/msm/dpu: add list of supported formats to the DPU caps

2023-03-20 Thread Dmitry Baryshkov
As we are going to add virtual planes, add the list of supported formats to the hw catalog entry. It will be used to setup universal planes, with later selecting a pipe depending on whether the YUV format is used for the framebuffer. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/

[RFC PATCH v2 12/13] drm/msm/dpu: add support for virtual planes

2023-03-20 Thread Dmitry Baryshkov
Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features. Properly utilizing all planes requires the attention of the compositor, who should prefer simpler planes to YUV-supporting ones. Otherwise it is very easy to end up in a situ

[RFC PATCH v2 04/13] drm/msm/dpu: remove unused fields from dpu_encoder_virt

2023-03-20 Thread Dmitry Baryshkov
Remove historical fields intfs_swapped and topology fields from struct dpu_encoder_virt and also remove even more historical docs. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/msm/di

[RFC PATCH v2 11/13] drm/msm/dpu: add a field describing inline rotation to dpu_caps

2023-03-20 Thread Dmitry Baryshkov
We need to know if the platform supports inline rotation on any of the SSPP blocks or not. Add this information to struct dpu_caps in a form of the boolean field has_inline_rot. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + drivers/gpu/drm/msm/disp/dpu

[RFC PATCH v2 05/13] drm/msm/dpu: get rid of struct dpu_rm_requirements

2023-03-20 Thread Dmitry Baryshkov
The struct dpu_rm_requirements was used to wrap display topology and hw resources, which meant INTF indices. As of commit ef58e0ad3436 ("drm/msm/dpu: get INTF blocks directly rather than through RM") the hw resources struct was removed, leaving struct dpu_rm_requirements containing a single field (

[RFC PATCH v2 06/13] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2023-03-20 Thread Dmitry Baryshkov
Up to now the driver has been using encoder to allocate hardware resources. Switch it to use CRTC id in preparation for the next step. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 16 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 10 +- drivers/gpu/drm/

[RFC PATCH v2 03/13] drm/msm/dpu: encoder: simplify debugfs handling

2023-03-20 Thread Dmitry Baryshkov
As the debugfs is fully cleared on drm device removal, drop the encoder-specific cleanup function, remove debugfs_root from dpu_encoder struct and also remove phys_encoder late_register() ops which has been unused since the driver being added. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/

[RFC PATCH v2 01/13] drm/atomic-helper: split not-scaling part of drm_atomic_helper_check_plane_state

2023-03-20 Thread Dmitry Baryshkov
The helper drm_atomic_helper_check_plane_state() runs several checks on plane src and dst rectangles, including the check whether required scaling fits into the required margins. The msm driver would benefit from having a function that does all these checks except the scaling one. Split them into a

[RFC PATCH v2 00/13] drm/msm/dpu: support virtual wide planes

2023-03-20 Thread Dmitry Baryshkov
As promised in the basic wide planes support ([1]) here comes a series supporting 2*max_linewidth for all the planes. Note: this iteration features handling of rotation and reflection of the wide plane. However rot90 is still not tested: it is enabled on sc7280 and it only supports UBWC (tiled) fr

Re: [PATCH 19/32] drm/amdkfd: add runtime enable operation

2023-03-20 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: The debugger can attach to a process prior to HSA enablement (i.e. inferior is spawned by the debugger and attached to immediately before target process has been enabled for HSA dispatches) or it can attach to a running target that is already HSA enabled

Re: [PATCH] drm/vmwgfx: Fix src/dst_pitch confusion

2023-03-20 Thread Dave Airlie
On Tue, 21 Mar 2023 at 09:42, Zack Rusin wrote: > > On Tue, 2023-03-21 at 08:46 +1000, Dave Airlie wrote: > > !! External Email > > > > On Thu, 16 Mar 2023 at 01:25, Martin Krastev (VMware) > > wrote: > > > > > > From: Martin Krastev > > > > > > We reviewers botched that one. > > > > > > Reviewe

Re: [PATCH 06/37] drm/vkms/vkms_composer: Fix a few different kerneldoc formatting

2023-03-20 Thread Randy Dunlap
On 3/20/23 16:46, Melissa Wen wrote: > On 03/17, Lee Jones wrote: >> Fixes the following W=1 kernel build warning(s): >> >> drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Function parameter or >> member 'frame_info' not described in 'pre_mul_alpha_blend' >> drivers/gpu/drm/vkms/vkms_compos

Re: [PATCH 06/37] drm/vkms/vkms_composer: Fix a few different kerneldoc formatting

2023-03-20 Thread Melissa Wen
On 03/17, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Function parameter or > member 'frame_info' not described in 'pre_mul_alpha_blend' > drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Excess function parameter >

Re: [PATCH v2] dt-bindings: display: Drop unneeded quotes

2023-03-20 Thread Dmitry Baryshkov
On 21/03/2023 01:38, Rob Herring wrote: Cleanup bindings dropping unneeded quotes. Once all these are fixed, checking for this can be enabled in yamllint. Reviewed-by: Chun-Kuang Hu Reviewed-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart Signed-off-by: Rob Herring --- v2: - Also dro

Re: [PATCH] drm/vmwgfx: Fix src/dst_pitch confusion

2023-03-20 Thread Zack Rusin
On Tue, 2023-03-21 at 08:46 +1000, Dave Airlie wrote: > !! External Email > > On Thu, 16 Mar 2023 at 01:25, Martin Krastev (VMware) > wrote: > > > > From: Martin Krastev > > > > We reviewers botched that one. > > > > Reviewed-by: Martin Krastev > > Can someone land this into drm-misc-next p

Re: Linux 6.3-rc3

2023-03-20 Thread Linus Torvalds
On Mon, Mar 20, 2023 at 3:06 PM Nathan Chancellor wrote: > > Right, this seems like a subtle difference in semantics between > -Wuninitialized between clang and GCC. I guess it's a bit ambiguous whether it's "X may be USED uninitialized" or whether it is "X may BE uninitialized" and then de

[PATCH v2] dt-bindings: display: Drop unneeded quotes

2023-03-20 Thread Rob Herring
Cleanup bindings dropping unneeded quotes. Once all these are fixed, checking for this can be enabled in yamllint. Reviewed-by: Chun-Kuang Hu Reviewed-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart Signed-off-by: Rob Herring --- v2: - Also drop quotes on URLs --- .../bindings/auxdispl

Re: Linux 6.3-rc3

2023-03-20 Thread Segher Boessenkool
On Mon, Mar 20, 2023 at 03:06:31PM -0700, Nathan Chancellor wrote: > It seems like clang takes into account that the branch has no effect on > how uninitialized err is, although it does acknowledge there may be > control flow where err is not used uninitialized because it is not used > at all by st

Re: [PATCH 18/32] drm/amdkfd: add send exception operation

2023-03-20 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: Add a debug operation that allows the debugger to send an exception directly to runtime through a payload address. For memory violations, normal vmfault signals will be applied to notify runtime instead after passing in the saved exception data when a m

Re: [PATCH 17/32] drm/amdkfd: add raise exception event function

2023-03-20 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: Exception events can be generated from interrupts or queue activitity. The raise event function will save exception status of a queue, device or process then notify the debugger of the status change by writing to a debugger polled file descriptor that t

Re: [PATCH 02/37] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp

2023-03-20 Thread Laurent Pinchart
Hi Lee, (CC'ing Jon and Mauro) On Mon, Mar 20, 2023 at 08:17:00AM +, Lee Jones wrote: > On Sun, 19 Mar 2023, Laurent Pinchart wrote: > > Thank you for the patch. > > > > On Fri, Mar 17, 2023 at 08:16:43AM +, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > >

Re: [PATCH 16/32] drm/amdkfd: add per process hw trap enable and disable functions

2023-03-20 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: To enable HW debug mode per process, all devices must be debug enabled successfully. If a failure occures, rewind the enablement of debug mode on the enabled devices. A power management scenario that needs to be considered is HW debug mode setting duri

Re: [PATCH] drm/vmwgfx: Fix src/dst_pitch confusion

2023-03-20 Thread Dave Airlie
On Thu, 16 Mar 2023 at 01:25, Martin Krastev (VMware) wrote: > > From: Martin Krastev > > We reviewers botched that one. > > Reviewed-by: Martin Krastev Can someone land this into drm-misc-next please so I can start building with clang again? Dave.

Re: Linux 6.3-rc3

2023-03-20 Thread Nathan Chancellor
On Mon, Mar 20, 2023 at 01:30:17PM -0700, Linus Torvalds wrote: > On Mon, Mar 20, 2023 at 1:05 PM Guenter Roeck wrote: > > > > I have noticed that gcc doesn't always warn about uninitialized variables > > in most architectures. > > Yeah, I'm getting the feeling that when the gcc people were tryin

Re: [PATCH 15/32] drm/amdkfd: prepare trap workaround for gfx11

2023-03-20 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: Due to a HW bug, waves in only half the shader arrays can enter trap. When starting a debug session, relocate all waves to the first shader array of each shader engine and mask off the 2nd shader array as unavailable. When ending a debug session, re-en

[Bug 214853] [amdgpu] UBSAN shows several null-ptr-deref in ../dc/bios/command_table2.c some array-index-out-of-bounds in ../dc/bios/bios_parser2.c and an invalid-load in ../amdgpu_dm/amdgpu_dm.c

2023-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214853 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Status|NEW |RESOLVED Resol

RE: [PATCH v2] drm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi

2023-03-20 Thread Limonciello, Mario
[Public] > -Original Message- > From: Kai-Heng Feng > Sent: Wednesday, March 15, 2023 07:07 > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui > Cc: Kai-Heng Feng ; David Airlie > ; Daniel Vetter ; Zhang, Hawking > ; Gao, Likun ; Kuehling, > Felix ; Zhao, Victor ; > Xiao, Jac

Re: [PATCH 1/2] drm/i915: limit double GT reset to pre-MTL

2023-03-20 Thread Andi Shyti
Hi Daniele, On Mon, Mar 20, 2023 at 02:10:38PM -0700, Daniele Ceraolo Spurio wrote: > Commit 3db9d590557d ("drm/i915/gt: Reset twice") modified the code to > always hit the GDRST register twice when doing a reset, with the > reported aim to fix invalid post-reset engine state on some platforms > (

[PATCH 2/2] drm/i915/gsc: implement wa 14015076503

2023-03-20 Thread Daniele Ceraolo Spurio
The WA states that we need to alert the GSC FW before doing a GSC engine reset and then wait for 200ms. The GuC owns engine reset, so on the i915 side we only need to apply this for full GT reset. Given that we do full GT resets in the resume paths to cleanup the HW state and that a long wait in t

[PATCH 1/2] drm/i915: limit double GT reset to pre-MTL

2023-03-20 Thread Daniele Ceraolo Spurio
Commit 3db9d590557d ("drm/i915/gt: Reset twice") modified the code to always hit the GDRST register twice when doing a reset, with the reported aim to fix invalid post-reset engine state on some platforms (Jasperlake being the only one actually mentioned). This is a problem on MTL, due to the fact

Re: [PATCH 14/32] drm/amdgpu: expose debug api for mes

2023-03-20 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: Similar to the F32 HWS, the RS64 HWS for GFX11 now supports a multi-process debug API. The skip_process_ctx_clear ADD_QUEUE requirement is to prevent the MES from clearing the process context when the first queue is added to the scheduler in order to main

Re: [PATCH v2 18/23] PM / QoS: Decouple request alloc from dev_pm_qos_mtx

2023-03-20 Thread kernel test robot
Hi Rob, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on rafael-pm/linux-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.3-rc3 next-20230320] [cannot apply to chanwoo

Re: [PATCH v2 01/23] drm/msm: Pre-allocate hw_fence

2023-03-20 Thread Rob Clark
On Mon, Mar 20, 2023 at 9:52 AM Christian König wrote: > > > > Am 20.03.23 um 15:43 schrieb Rob Clark: > > From: Rob Clark > > > > Avoid allocating memory in job_run() by pre-allocating the hw_fence. > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/msm_fence.c | 12 +++

Re: [PATCH 1/2] drm/msm/a6xx: Some reg64 conversion

2023-03-20 Thread Rob Clark
On Mon, Mar 20, 2023 at 11:57 AM Konrad Dybcio wrote: > > > > On 20.03.2023 19:56, Konrad Dybcio wrote: > > > > > > On 20.03.2023 19:54, Rob Clark wrote: > >> From: Rob Clark > >> > >> The next generated header update will drop the _LO/_HI suffix, now that > >> the userspace tooling properly unde

Re: Linux 6.3-rc3

2023-03-20 Thread Linus Torvalds
On Mon, Mar 20, 2023 at 1:05 PM Guenter Roeck wrote: > > I have noticed that gcc doesn't always warn about uninitialized variables > in most architectures. Yeah, I'm getting the feeling that when the gcc people were trying to make -Wmaybe-uninitialized work better (when moving it into "-Wall"), t

Re: [PATCH] drm/amd/display: use a more accurate check in dm_helpers_dp_read_dpcd()

2023-03-20 Thread Harry Wentland
On 3/10/23 12:51, Ville Syrjälä wrote: > On Fri, Mar 10, 2023 at 07:48:04PM +0200, Ville Syrjälä wrote: >> On Thu, Mar 09, 2023 at 04:30:27PM -0500, Hamza Mahfooz wrote: >>> We should be checking if drm_dp_dpcd_read() returns the size that we are >>> asking it to read instead of just checking if

[PATCH 2/2] drm/i915: Check for unreliable MMIO during forcewake

2023-03-20 Thread Andi Shyti
From: Matt Roper Although we now sanitycheck MMIO access during driver load to make sure the MMIO BAR isn't returning all 0x, there have been a few cases where (temporarily?) unreliable MMIO access has happened after GPU resets or power events. We'll often notice this on our next GT regi

[PATCH 1/2] drm/i915: Sanitycheck MMIO access early in driver load

2023-03-20 Thread Andi Shyti
From: Matt Roper We occasionally see the PCI device in a non-accessible state at the point the driver is loaded. When this happens, all BAR accesses will read back as 0x. Rather than reading registers and misinterpreting their (invalid) values, let's specifically check for 0x in

[PATCH 0/2] Report MMIO communication problems more clearly

2023-03-20 Thread Andi Shyti
Hi, just copy pasting Matt's original cover letter: We're periodically facing problems in CI where all registers read back as 0x. In general this is what happens when the CPU is unable to communicate with a PCI device, so the transaction autocompletes with all F's as a placeholder. Some

Re: [PATCH v2] drm/amd/display: use a more accurate check in dm_helpers_dp_read_dpcd()

2023-03-20 Thread Harry Wentland
On 3/10/23 13:42, Hamza Mahfooz wrote: > We should be checking if drm_dp_dpcd_read() returns the size that we are > asking it to read instead of just checking if it is greater than zero. > So, compare the return value of drm_dp_dpcd_read() to the requested > read size. > > Signed-off-by: Hamza Mah

Re: [PATCH 13/32] drm/amdgpu: prepare map process for multi-process debug devices

2023-03-20 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: Unlike single process debug devices, multi-process debug devices allow debug mode setting per-VMID (non-device-global). Because the HWS manages PASID-VMID mapping, the new MAP_PROCESS API allows the KFD to forward the required SPI debug register write r

Re: [PATCH v2 18/23] PM / QoS: Decouple request alloc from dev_pm_qos_mtx

2023-03-20 Thread kernel test robot
Hi Rob, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on rafael-pm/linux-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.3-rc3 next-20230320] [cannot apply to chanwoo

Re: [PATCH 12/32] drm/amdkfd: prepare map process for single process debug devices

2023-03-20 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: Older HW only supports debugging on a single process because the SPI debug mode setting registers are device global. The HWS has supplied a single pinned VMID (0xf) for MAP_PROCESS for debug purposes. To pin the VMID, the KFD will remove the VMID from t

[Bug 214847] [radeon] UBSAN shows several null-ptr-deref in drm/radeon/atom.c, radeon_atombios.c, atombios_encoders.c, atombios_crtc.c

2023-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214847 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Status|NEW |RESOLVED Resol

Re: Linux 6.3-rc3

2023-03-20 Thread Guenter Roeck
On Mon, Mar 20, 2023 at 11:26:17AM -0700, Linus Torvalds wrote: > On Mon, Mar 20, 2023 at 11:05 AM Nathan Chancellor wrote: > > > > On the clang front, I am still seeing the following warning turned error > > for arm64 allmodconfig at least: > > > > drivers/gpu/host1x/dev.c:520:6: error: variabl

[PATCH] drm/vkms: remove the need for the primary plane to be visible

2023-03-20 Thread Maíra Canal
Before commit bc0d7fdefec6 ("drm: vkms: Supports to the case where primary plane doesn't match the CRTC"), the composition was executed on top of the primary plane. Therefore, the primary plane needed to be visible and full screen. After commit bc0d7fdefec6, this is no longer necessary, as the comp

[PATCH 2/2] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-03-20 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, we must wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 17 + drive

[PATCH 1/2] drm/i915/gt: Ensure memory quiesced before invalidation

2023-03-20 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drive

[PATCH 0/2] Aux invalidation

2023-03-20 Thread Andi Shyti
Hi, I'm just respinning these two aux invalidation patches from Jonathan. They have been sent some times ago and need to be reviewed. Thanks, Andi Jonathan Cavitt (2): drm/i915/gt: Ensure memory quiesced before invalidation drm/i915/gt: Poll aux invalidation register bit on invalidation dr

Re: [PATCH v2 000/101] fbdev: Fix memory leak in option parsing

2023-03-20 Thread Helge Deller
Hi Thomas, On 3/20/23 11:07, Thomas Zimmermann wrote: Geert, Helge?  Do you have further comments?  There's not really much for a v3 yet. I understand the motivation and I see you invested a lot of work on it, which is really appreciated. But I have mixed feelings about that patch itself. Ne

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-20 Thread Stephen Boyd
Quoting Matti Vaittinen (2023-03-18 23:36:20) > > > > I think you would have an easier time if you just copied and renamed > > them into the kunit folder as an preparation series. > > Yes. That would simplify the syncing between the trees. It slightly bugs > me to add dublicate code in kernel-bu

Re: Linux 6.3-rc3

2023-03-20 Thread Nathan Chancellor
On Mon, Mar 20, 2023 at 11:53:37AM -0700, Nathan Chancellor wrote: > On Mon, Mar 20, 2023 at 11:26:17AM -0700, Linus Torvalds wrote: > > On Mon, Mar 20, 2023 at 11:05 AM Nathan Chancellor > > wrote: > > > > > > On the clang front, I am still seeing the following warning turned error > > > for arm

[PATCH] drm/i915/selftests: Drop igt_cs_tlb

2023-03-20 Thread Andi Shyti
From: Jonathan Cavitt The gt_tlb live selftest has the same code coverage as the igt_cs_tlb subtest of gtt, except it is better at detecting TLB bugs. Furthermore, while igt_cs_tlb is hitting some unforeseen issues, these issues are either false positives due to the test being poorly formatted,

Re: [PATCH 11/32] drm/amdgpu: add configurable grace period for unmap queues

2023-03-20 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: The HWS schedule allows a grace period for wave completion prior to preemption for better performance by avoiding CWSR on waves that can potentially complete quickly. The debugger, on the other hand, will want to inspect wave status immediately after it ac

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-03-20 Thread Liam R. Howlett
* Danilo Krummrich [230313 19:46]: > On 3/7/23 23:43, Liam R. Howlett wrote: > > * Danilo Krummrich [230306 10:46]: > > > On 3/2/23 03:38, Liam R. Howlett wrote: > > > > * Danilo Krummrich [230227 08:17]: > > > > > > > > ... > > > > > > > Would this variant be significantly more efficient? > >

Re: [PATCH 1/2] drm/msm/a6xx: Some reg64 conversion

2023-03-20 Thread Konrad Dybcio
On 20.03.2023 19:54, Rob Clark wrote: > From: Rob Clark > > The next generated header update will drop the _LO/_HI suffix, now that > the userspace tooling properly understands 64b vs 32b regs (and the _LO/ > _HI workarounds are getting cleaned up). So convert to using the 64b > reg helpers i

Re: [PATCH] drm/vgem: Drop struct drm_vgem_gem_object

2023-03-20 Thread Maíra Canal
On 2/22/23 13:06, Maíra Canal wrote: Commit 45d9c8dde4cd ("drm/vgem: use shmem helpers") introduced shmem helpers to vgem and with that, removed all uses of the struct drm_vgem_gem_object. So, as the struct is no longer used, delete it. Signed-off-by: Maíra Canal --- Applied to drm-misc-next.

Re: [PATCH v4 6/8] accel/qaic: Add mhi_qaic_cntl

2023-03-20 Thread Jeffrey Hugo
On 3/20/2023 9:11 AM, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya Some of the MHI channels for an AIC100 device need to be routed to userspace so that userspace can communicate directly with QSM. The MHI bus does not support this, and while the WWAN subsystem does (for the same reas

Re: Linux 6.3-rc3

2023-03-20 Thread Linus Torvalds
On Mon, Mar 20, 2023 at 11:56 AM Nathan Chancellor wrote: > > I did see a patch fly by to fix that: > > https://lore.kernel.org/20230316082035.567520-3-christian.koe...@amd.com/ > > It seems like the DRM_TEGRA half of it is broken though: > > https://lore.kernel.org/202303170635.a2rsq1wu-...@intel

Re: [PATCH 1/2] drm/msm/a6xx: Some reg64 conversion

2023-03-20 Thread Konrad Dybcio
On 20.03.2023 19:56, Konrad Dybcio wrote: > > > On 20.03.2023 19:54, Rob Clark wrote: >> From: Rob Clark >> >> The next generated header update will drop the _LO/_HI suffix, now that >> the userspace tooling properly understands 64b vs 32b regs (and the _LO/ >> _HI workarounds are getting cle

Re: Linux 6.3-rc3

2023-03-20 Thread Nathan Chancellor
On Mon, Mar 20, 2023 at 11:49:55AM -0700, Linus Torvalds wrote: > On Mon, Mar 20, 2023 at 11:26 AM Linus Torvalds > wrote: > > > > Hmm. I do my arm64 allmodconfig builds with gcc, and I'm surprised > > that gcc doesn't warn about this. > > Side note: I'm also wondering why that TEGRA_HOST1X confi

[PATCH 1/2] drm/msm/a6xx: Some reg64 conversion

2023-03-20 Thread Rob Clark
From: Rob Clark The next generated header update will drop the _LO/_HI suffix, now that the userspace tooling properly understands 64b vs 32b regs (and the _LO/ _HI workarounds are getting cleaned up). So convert to using the 64b reg helpers in prep. Signed-off-by: Rob Clark --- drivers/gpu/d

Re: Linux 6.3-rc3

2023-03-20 Thread Nathan Chancellor
On Mon, Mar 20, 2023 at 11:26:17AM -0700, Linus Torvalds wrote: > On Mon, Mar 20, 2023 at 11:05 AM Nathan Chancellor wrote: > > > > On the clang front, I am still seeing the following warning turned error > > for arm64 allmodconfig at least: > > > > drivers/gpu/host1x/dev.c:520:6: error: variabl

Re: [PATCH] drm/bridge: nwl-dsi: fix packet read ISR handling

2023-03-20 Thread Kevin Groeneveld
Hi Neil, On 2023-03-20 06:44, Neil Armstrong wrote: Thanks for the patch, can you provide a Fixes tag ? Neil As with my other recent patch I did not think of adding a fixes tag as this bug is not a regressions but has existed since the first commit of the driver. If there should be a fixes

Re: [PATCH] drm/bridge: nwl-dsi: implement MIPI_DSI_MODE_NO_EOT_PACKET

2023-03-20 Thread Kevin Groeneveld
Hi Neil, On 2023-03-20 06:43, Neil Armstrong wrote: Thanks for the patch, can you provide a Fixes tag ? Neil I never seem to think about a fixes tag unless it was a regression. This limitation has existed since the first commit for this driver. If there should be a fixes tag then I guess it

Re: Linux 6.3-rc3

2023-03-20 Thread Linus Torvalds
On Mon, Mar 20, 2023 at 11:26 AM Linus Torvalds wrote: > > Hmm. I do my arm64 allmodconfig builds with gcc, and I'm surprised > that gcc doesn't warn about this. Side note: I'm also wondering why that TEGRA_HOST1X config has that ARM dependency in depends on ARCH_TEGRA || (ARM && COMPILE

Re: [Intel-gfx] [PATCH v4 06/10] drm/i915: Separate wakeref tracking

2023-03-20 Thread Andrzej Hajda
On 20.03.2023 00:57, Andi Shyti wrote: Hi Andrzej, On Mon, Mar 06, 2023 at 05:32:02PM +0100, Andrzej Hajda wrote: From: Chris Wilson Extract the callstack tracking of intel_runtime_pm.c into its own utility so that that we can reuse it for other online debugging of scoped wakerefs. Signed-of

Re: Linux 6.3-rc3

2023-03-20 Thread Linus Torvalds
On Mon, Mar 20, 2023 at 11:05 AM Nathan Chancellor wrote: > > On the clang front, I am still seeing the following warning turned error > for arm64 allmodconfig at least: > > drivers/gpu/host1x/dev.c:520:6: error: variable 'syncpt_irq' is > uninitialized when used here [-Werror,-Wuninitialized]

Re: [Intel-gfx] [PATCH v4 03/10] lib/ref_tracker: add printing to memory buffer

2023-03-20 Thread Andrzej Hajda
On 20.03.2023 00:18, Andi Shyti wrote: Hi Andrzej, This looks also good, just few questions. On Mon, Mar 06, 2023 at 05:31:59PM +0100, Andrzej Hajda wrote: In case one wants to show stats via debugfs. shall I say it? I'll say it... you can do better with the log here. It's not a typo fix :)

Re: [PATCH v4 6/8] accel/qaic: Add mhi_qaic_cntl

2023-03-20 Thread kernel test robot
Hi Jeffrey, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on lwn/docs-next linus/master v6.3-rc3 next-20230320] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: Linux 6.3-rc3

2023-03-20 Thread Nathan Chancellor
On Sun, Mar 19, 2023 at 01:50:21PM -0700, Linus Torvalds wrote: > So rc3 is fairly big, but that's not hugely usual: it's when a lot of > the fixes tick up as it takes a while before people find and start > reporting issues. ... > Please test and report any issues you find, On the clang front, I

Re: [Freedreno] [PATCH v3 4/7] drm/msm/a2xx: Implement .gpu_busy

2023-03-20 Thread Rob Clark
On Mon, Mar 13, 2023 at 9:54 AM Konrad Dybcio wrote: > > > > On 24.02.2023 16:04, Jonathan Marek wrote: > > This won't work because a2xx freedreno userspace expects to own all the > > perfcounters. > > > > This will break perfcounters for userspace, and when userspace isn't using > > perfcounter

Re: [PATCH][next] drm/i915/uapi: Replace fake flex-array with flexible-array member

2023-03-20 Thread Kees Cook
On Fri, Mar 17, 2023 at 12:18:01PM -0600, Gustavo A. R. Silva wrote: > Zero-length arrays as fake flexible arrays are deprecated and we are > moving towards adopting C99 flexible-array members instead. > > Address the following warning found with GCC-13 and > -fstrict-flex-arrays=3 enabled: > driv

Re: [PATCH] drm/rockchip: vop2: fix uninitialized variable possible_crtcs

2023-03-20 Thread Nathan Chancellor
On Thu, Mar 16, 2023 at 09:23:02AM -0400, Tom Rix wrote: > clang reportes this error > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:2322:8: error: > variable 'possible_crtcs' is used uninitialized whenever 'if' > condition is false [-Werror,-Wsometimes-uninitialized] > i

Re: [PATCH v2 01/23] drm/msm: Pre-allocate hw_fence

2023-03-20 Thread Christian König
Am 20.03.23 um 15:43 schrieb Rob Clark: From: Rob Clark Avoid allocating memory in job_run() by pre-allocating the hw_fence. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_fence.c | 12 +--- drivers/gpu/drm/msm/msm_fence.h | 3 ++- drivers/gpu/drm/msm/msm_gem_s

Re: [PATCH v2 5/8] drm/fbdev-generic: Set screen size to size of GEM buffer

2023-03-20 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The size of the screen memory should be equivalent to the size of > the screen's GEM buffer. Don't recalculate the value. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH v2 4/8] drm/fb-helper: Support smem_len in deferred I/O

2023-03-20 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The size of the framebuffer can either be stored in screen_info or > smem_len. Take both into account in the deferred I/O code. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platfor

[PATCH v2] drm/armada: Fix off-by-one error in armada_overlay_get_property()

2023-03-20 Thread Geert Uytterhoeven
As ffs() returns one more than the index of the first bit set (zero means no bits set), the color key mode value is shifted one position too much. Fix this by using FIELD_GET() instead. Fixes: c96103b6c49ff9a8 ("drm/armada: move colorkey properties into overlay plane state") Signed-off-by: Geert

Re: [PATCH] dt-bindings: display: Drop unneeded quotes

2023-03-20 Thread Chun-Kuang Hu
Hi, Rob: Rob Herring 於 2023年3月18日 週六 上午7:36寫道: > > Cleanup bindings dropping unneeded quotes. Once all these are fixed, > checking for this can be enabled in yamllint. For MediaTek part, Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Rob Herring > --- > .../bindings/auxdisplay/holtek,ht16k33

[git pull] habanalabs for drm-next-6.4

2023-03-20 Thread Oded Gabbay
Hi Dave, Daniel. First pull request for 6.4. Changes are all over the place - new uAPI, new features, optimizations, bug fixes, cleanups, etc. Full details are in the signed tag. Thanks, Oded The following changes since commit 8bf6e20253b2d2b614f2c0b491f840e956fa6b05: Merge tag 'drm-intel-n

Re: [Intel-gfx] [PATCH v4 02/10] lib/ref_tracker: __ref_tracker_dir_print improve printing

2023-03-20 Thread Andrzej Hajda
On 20.03.2023 00:11, Andi Shyti wrote: Hi Andrzej, looks good, few comments below, On Mon, Mar 06, 2023 at 05:31:58PM +0100, Andrzej Hajda wrote: To improve readability of ref_tracker printing following changes have been performed: - reports are printed per stack_handle - log is more compact,

RE: [PATCH 07/10] accel/habanalabs: fix field names in hl_info_hw_ip_info

2023-03-20 Thread Ofir Bitton
On 16/03/2023 13:36, Oded Gabbay wrote: > Don't use padX for actual reservedX fields. > > Signed-off-by: Oded Gabbay > --- > include/uapi/drm/habanalabs_accel.h | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/include/uapi/drm/habanalabs_accel.h > b/include/

Re: [Intel-gfx] [PATCH v4 01/10] lib/ref_tracker: add unlocked leak print helper

2023-03-20 Thread Andrzej Hajda
On 19.03.2023 23:59, Andi Shyti wrote: Hi Andrzej, [...] diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c index dc7b14aa3431e2..5e9f90bbf771b0 100644 --- a/lib/ref_tracker.c +++ b/lib/ref_tracker.c @@ -14,6 +14,38 @@ struct ref_tracker { depot_stack_handle_tfree_stack_handle; }

  1   2   3   >