Re: [Intel-gfx] [PATCH v5] drm/i915/pxp: limit drm-errors or warning on firmware API failures

2023-03-24 Thread Teres Alexis, Alan Previn
Thanks Daniele, Thanks Jani. ...alan

Re: [PATCH v2 1/2] docs: process: allow Closes tags with links

2023-03-24 Thread Bagas Sanjaya
On 3/25/23 01:52, Matthieu Baerts wrote: > diff --git a/Documentation/process/5.Posting.rst > b/Documentation/process/5.Posting.rst > index 7a670a075ab6..20f0b6b639b7 100644 > --- a/Documentation/process/5.Posting.rst > +++ b/Documentation/process/5.Posting.rst > @@ -217,6 +217,15 @@ latest

Re: [RFC v4 00/10] DRM scheduling cgroup controller

2023-03-24 Thread Tejun Heo
Hello, Tvrtko. On Tue, Mar 14, 2023 at 02:18:54PM +, Tvrtko Ursulin wrote: > DRM scheduling soft limits > ~~ > > Because of the heterogenous hardware and driver DRM capabilities, soft limits > are implemented as a loose co-operative (bi-directional) interface between

Re: [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-24 Thread Belgaumkar, Vinay
On 3/24/2023 4:31 PM, Dixit, Ashutosh wrote: On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: Hi Vinay, Thanks for the review. Comments inline below. Sorry about asking the same questions all over again :) Didn't look at previous versions. On 3/15/2023 8:59 PM, Ashutosh Dixit

Re: [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-24 Thread Dixit, Ashutosh
On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: > Hi Vinay, Thanks for the review. Comments inline below. > On 3/15/2023 8:59 PM, Ashutosh Dixit wrote: > > On dGfx, the PL1 power limit being enabled and set to a low value results > > in a low GPU operating freq. It also negates the

Re: [PULL] drm-fixes for 6.3-rc4

2023-03-24 Thread pr-tracker-bot
The pull request you sent on Fri, 24 Mar 2023 22:05:25 +0100: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-03-24 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/37154c19dd79966009befdcf2b499099e3cbbe9c Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH 06/10] drm/msm: fix vram leak on bind errors

2023-03-24 Thread Dmitry Baryshkov
On Mon, 6 Mar 2023 at 12:09, Johan Hovold wrote: > > Make sure to release the VRAM buffer also in a case a subcomponent fails > to bind. > > Fixes: d863f0c7b536 ("drm/msm: Call msm_init_vram before binding the gpu") > Cc: sta...@vger.kernel.org # 5.11 > Cc: Craig Tatlor > Signed-off-by:

Re: [PATCH 05/10] drm/msm: fix drm device leak on bind errors

2023-03-24 Thread Dmitry Baryshkov
On Wed, 22 Mar 2023 at 09:46, Johan Hovold wrote: > > On Tue, Mar 21, 2023 at 04:54:51PM +0200, Dmitry Baryshkov wrote: > > On 06/03/2023 12:07, Johan Hovold wrote: > > > Make sure to free the DRM device also in case of early errors during > > > bind(). > > > > > > Fixes: 2027e5b3413d ("drm/msm:

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-03-24 Thread Aidan MacDonald
Maxime Ripard writes: > On Thu, Mar 23, 2023 at 03:35:30PM +, Aidan MacDonald wrote: >> >> Stephen Boyd writes: >> >> > Quoting Maxime Ripard (2022-11-09 03:00:45) >> >> On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: >> >> > >> >> > Maxime Ripard writes: >> >> > >> >> >

Re: [PATCH] drm/panel: magnachip: Prevent error pointer dereference in probe

2023-03-24 Thread Chris Morgan
On Wed, Mar 22, 2023 at 12:07:10PM +0300, Dan Carpenter wrote: > Don't dereference "db->dsi_dev" when it is an error pointer. > > Fixes: 249a4f5e663c ("drm/panel: Add Magnachip D53E6EA8966 Panel Driver") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c

[PATCH] drm/msm: Avoid rounding down to zero jiffies

2023-03-24 Thread Rob Clark
From: Rob Clark If userspace asked for a timeout greater than zero, but less than a jiffy, they clearly weren't planning on spinning. So it is better to round up to one. This fixes an issue with supertuxkart that was (for some reason) spinning on a gl sync with 1ms timeout. CPU time for a

Re: [PATCH] drm/i915/overlay: Remove redundant drm_rect_visible() use

2023-03-24 Thread Ville Syrjälä
On Fri, Mar 24, 2023 at 11:25:33AM -0300, Arthur Grillo wrote: > The drm_rect_intersect() already returns if the intersection is visible > or not, so the use of drm_rect_visible() is duplicate. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/i915/display/intel_overlay.c | 3 +-- > 1

Re: [PATCH 00/10] drm/radeon: Convert fbdev to DRM client

2023-03-24 Thread Alex Deucher
On Tue, Mar 21, 2023 at 5:33 AM Thomas Zimmermann wrote: > > Hi > > Am 20.03.23 um 16:23 schrieb Alex Deucher: > > On Mon, Mar 20, 2023 at 11:19 AM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 20.03.23 um 16:11 schrieb Christian König: > >>> Am 17.03.23 um 10:20 schrieb Thomas

[PULL] drm-fixes for 6.3-rc4

2023-03-24 Thread Daniel Vetter
Hi Linus, Dave is already on vacations, should be back 17th April in time for the merge window. This includes the host1x once more, I only realized you applied it already after I pushed my tree out. We also discussed a bit what to improve, because there should be a pile of fallbacks in place: -

Re: [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Krzysztof Kozlowski
On 24/03/2023 20:57, Bjorn Andersson wrote: > On Fri, Mar 24, 2023 at 08:27:12PM +0100, Krzysztof Kozlowski wrote: >> On 24/03/2023 18:45, Bjorn Andersson wrote: >>> On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: Fixes the following DT bindings check error: >>> >>> Is that

[PATCH] fbdev: modedb: Fix kernel crash in fb_videomode_to_var()

2023-03-24 Thread Helge Deller
Fix a kernel crash in the fbdev modedb code which can happen if you boot a system without any graphic card driver, in which case the dummycon driver takes the console. If you then load a fbdev graphics driver and start a the X11-fbdev the kernel will crash with a backtrace: IAOQ[0]:

Re: [PULL] drm-intel-next

2023-03-24 Thread Daniel Vetter
On Thu, Mar 23, 2023 at 04:43:22PM -0400, Rodrigo Vivi wrote: > Hi Daniel, > > Here goes drm-intel-next-2023-03-23: > > Core Changes: > - drm: Add SDP Error Detection Configuration Register (Arun) > > Driver Changes: > - Meteor Lake enabling and fixes (RK, Jose, Madhumitha) > - Lock the fbdev

Re: [PATCH v7 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-03-24 Thread Dmitry Baryshkov
On Fri, 24 Mar 2023 at 21:21, Mark Yacoub wrote: > > From: Sean Paul > > Add HDCP 1.x support to msm DP bridges using the new HDCP > helpers. > > Cc: Stephen Boyd > Reviewed-by: Stephen Boyd > Signed-off-by: Sean Paul > Signed-off-by: Mark Yacoub > > --- > > Changes in v2: > -Squash [1] into

[PATCH v7 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-03-24 Thread Mark Yacoub
From: Sean Paul Add HDCP 1.x support to msm DP bridges using the new HDCP helpers. Cc: Stephen Boyd Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2: -Squash [1] into this patch with the following changes (Stephen) -Update the sc7180 dtsi

[PATCH v7 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-03-24 Thread Mark Yacoub
From: Sean Paul Add the register ranges required for HDCP key injection and HDCP TrustZone interaction as described in the dt-bindings for the sc7180 dp controller. Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v3: -Split off into a new patch containing just the dts

[PATCH v7 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-03-24 Thread Mark Yacoub
From: Sean Paul Now that all of the HDCP 1.x logic has been migrated to the central HDCP helpers, use it in the i915 driver. The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, however there are a few helper hooks which are connector-specific and need to be partially or

[PATCH v7 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-24 Thread Mark Yacoub
From: Sean Paul The shim functions return error codes, but they are discarded in intel_hdcp.c. This patch plumbs the return codes through so they are properly handled. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2:

[PATCH v7 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2023-03-24 Thread Mark Yacoub
From: Sean Paul Add the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. Cc: Rob Herring Cc: Stephen Boyd Reviewed-by: Rob Herring

[PATCH v7 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-03-24 Thread Mark Yacoub
From: Sean Paul Expand upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once a new platform supported HDCP we could make good

[PATCH v7 03/10] drm/hdcp: Update property value on content type and user changes

2023-03-24 Thread Mark Yacoub
From: Sean Paul Update the connector's property value in 2 cases which were previously missed: 1- Content type changes. The value should revert back to DESIRED from ENABLED in case the driver must re-authenticate the link due to the new content type. 2- Userspace sets value to DESIRED

[PATCH v7 05/10] drm/i915/hdcp: Consolidate HDCP setup/state cache

2023-03-24 Thread Mark Yacoub
From: Sean Paul Stick all of the setup for HDCP into a dedicated function. No functional change, but this will facilitate moving HDCP logic into helpers. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean Paul --- Changes in v2: -None Changes in v3: -None Changes in v4:

[PATCH v7 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2023-03-24 Thread Mark Yacoub
From: Sean Paul Instead of forcing a modeset in the hdcp atomic check, rename to drm_hdcp_has_changed and return true if the content protection value is changing and let the driver decide whether a modeset is required or not. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean

[PATCH v7 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-03-24 Thread Mark Yacoub
From: Sean Paul Move the hdcp atomic check from i915 to drm_hdcp so other drivers can use it. No functional changes, just cleaned up some of the code when moving it over. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Reviewed-by: Dmitry Baryshkov Signed-off-by: Sean Paul Signed-off-by:

[PATCH v7 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2023-03-24 Thread Mark Yacoub
From: Mark Yacoub Hi all, This is v7 of the HDCP patches. The patches are authored by Sean Paul. I rebased and addressed the review comments in v6-v7. Patches 1-4 focus on moving the common HDCP helpers to common DRM. This introduces a slight change in the original intel flow as it splits the

[PATCH] drm/vmwgfx: remove unused mksstat_init_record function

2023-03-24 Thread Tom Rix
clang with W=1 reports drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:716:21: error: unused function 'mksstat_init_record' [-Werror,-Wunused-function] static inline char *mksstat_init_record(mksstat_kern_stats_t stat_idx, ^ This function is not used so remove it. Signed-off-by: Tom Rix

Re: [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Bjorn Andersson
On Fri, Mar 24, 2023 at 08:27:12PM +0100, Krzysztof Kozlowski wrote: > On 24/03/2023 18:45, Bjorn Andersson wrote: > > On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: > >> Fixes the following DT bindings check error: > > > > Is that because idle-state-name and local-timer-stop

Re: [PATCH v7 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-03-24 Thread Dmitry Baryshkov
On Fri, 24 Mar 2023 at 21:21, Mark Yacoub wrote: > > From: Sean Paul > > Move the hdcp atomic check from i915 to drm_hdcp so other > drivers can use it. No functional changes, just cleaned up some of the > code when moving it over. > > Acked-by: Jani Nikula > Reviewed-by: Rodrigo Vivi >

Re: [Intel-gfx] [PATCH v6 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-03-24 Thread Mark Yacoub
On Tue, Mar 14, 2023 at 1:54 AM Kandpal, Suraj wrote: > > > > > From: Sean Paul > > > > Now that all of the HDCP 1.x logic has been migrated to the central HDCP > > helpers, use it in the i915 driver. > > > > The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, > > however

Re: [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-24 Thread Mark Yacoub
On Thu, Mar 23, 2023 at 3:18 AM Kandpal, Suraj wrote: > > > > > -Original Message- > > From: Kandpal, Suraj > > Sent: Friday, March 10, 2023 1:55 PM > > To: Mark Yacoub ; quic_khs...@quicinc.com; > > linux-arm-...@vger.kernel.org; dri-devel@lists.freedesktop.org; > >

Re: [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Krzysztof Kozlowski
On 24/03/2023 18:45, Bjorn Andersson wrote: > On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: >> Fixes the following DT bindings check error: > > Is that because idle-state-name and local-timer-stop should not be > defined for domain-idle-states or are you just clearing out the >

RE: [PATCH] drm/display: Add missing OLED Vesa brightnesses definitions

2023-03-24 Thread Clark, Felipe
[AMD Official Use Only - General] Hi Rodrigo and Harry, There was a typo in the third line of the pseudo-patch I wrote in the previous email. Here is the fixed version: #define DP_EDP_GENERAL_CAP_20x703 # define DP_EDP_OVERDRIVE_ENGINE_ENABLED (1 << 0) +# define

[PATCH v7 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-03-24 Thread Mark Yacoub
From: Sean Paul Now that all of the HDCP 1.x logic has been migrated to the central HDCP helpers, use it in the i915 driver. The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, however there are a few helper hooks which are connector-specific and need to be partially or

Re: [PULL] drm-misc-next

2023-03-24 Thread Daniel Vetter
On Thu, Mar 23, 2023 at 12:08:57PM +0100, Maarten Lankhorst wrote: > Hi Dave, Daniel, > > Lots of small commits with cleanup and fixes this time around, nothing major > otherwise. > > Cheers, > ~Maarten > > drm-misc-next-2023-03-23: > drm-misc-next for v6.4-rc1: > > Core Changes: > - Add unit

[PATCH v7 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-03-24 Thread Mark Yacoub
From: Sean Paul Add HDCP 1.x support to msm DP bridges using the new HDCP helpers. Cc: Stephen Boyd Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2: -Squash [1] into this patch with the following changes (Stephen) -Update the sc7180 dtsi

[PATCH v7 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2023-03-24 Thread Mark Yacoub
From: Sean Paul Add the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. Cc: Rob Herring Cc: Stephen Boyd Reviewed-by: Rob Herring

[PATCH v7 05/10] drm/i915/hdcp: Consolidate HDCP setup/state cache

2023-03-24 Thread Mark Yacoub
From: Sean Paul Stick all of the setup for HDCP into a dedicated function. No functional change, but this will facilitate moving HDCP logic into helpers. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean Paul --- Changes in v2: -None Changes in v3: -None Changes in v4:

[PATCH v7 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-24 Thread Mark Yacoub
From: Sean Paul The shim functions return error codes, but they are discarded in intel_hdcp.c. This patch plumbs the return codes through so they are properly handled. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2:

[PATCH v7 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-03-24 Thread Mark Yacoub
From: Sean Paul Expand upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once a new platform supported HDCP we could make good

[PATCH v7 03/10] drm/hdcp: Update property value on content type and user changes

2023-03-24 Thread Mark Yacoub
From: Sean Paul Update the connector's property value in 2 cases which were previously missed: 1- Content type changes. The value should revert back to DESIRED from ENABLED in case the driver must re-authenticate the link due to the new content type. 2- Userspace sets value to DESIRED

[PATCH v7 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2023-03-24 Thread Mark Yacoub
From: Sean Paul Instead of forcing a modeset in the hdcp atomic check, rename to drm_hdcp_has_changed and return true if the content protection value is changing and let the driver decide whether a modeset is required or not. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean

[PATCH v7 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-03-24 Thread Mark Yacoub
From: Sean Paul Move the hdcp atomic check from i915 to drm_hdcp so other drivers can use it. No functional changes, just cleaned up some of the code when moving it over. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Reviewed-by: Dmitry Baryshkov Signed-off-by: Sean Paul Signed-off-by:

Re: [PATCH v2 2/2] checkpatch: allow Closes tags with links

2023-03-24 Thread Joe Perches
On Fri, 2023-03-24 at 19:52 +0100, Matthieu Baerts wrote: > As a follow-up of the previous patch modifying the documentation to > allow using the "Closes:" tag, checkpatch.pl is updated accordingly. > > checkpatch.pl now mentions the "Closes:" tag between brackets to express > the fact it should

Re: [PATCH] drm/panel-edp: Add B133UAN01.0 edp panel entry

2023-03-24 Thread Neil Armstrong
Le 24/03/2023 à 18:04, Doug Anderson a écrit : Hi, On Fri, Mar 24, 2023 at 9:59 AM Vinod Koul wrote: From: Bjorn Andersson This panel is found in Lenovo Flex 5G laptop, so add the entry for it Signed-off-by: Bjorn Andersson Signed-off-by: Vinod Koul ---

[PATCH v2 2/2] checkpatch: allow Closes tags with links

2023-03-24 Thread Matthieu Baerts
As a follow-up of the previous patch modifying the documentation to allow using the "Closes:" tag, checkpatch.pl is updated accordingly. checkpatch.pl now mentions the "Closes:" tag between brackets to express the fact it should be used only if it makes sense. While at it, checkpatch.pl will not

[PATCH v2 1/2] docs: process: allow Closes tags with links

2023-03-24 Thread Matthieu Baerts
Making sure a bug tracker is up to date is not an easy task. For example, a first version of a patch fixing a tracked issue can be sent a long time after having created the issue. But also, it can take some time to have this patch accepted upstream in its final form. When it is done, someone --

[PATCH v2 0/2] docs & checkpatch: allow Closes tags with links

2023-03-24 Thread Matthieu Baerts
Since v6.3, checkpatch.pl now complains about the use of "Closes:" tags followed by a link [1]. It also complains if a "Reported-by:" tag is followed by a "Closes:" one [2]. As detailed in the first patch, this "Closes:" tag is used for a bit of time, mainly by DRM and MPTCP subsystems. It is

Re: [PATCH resent] drm/amd/display: Fix exception handling in dm_validate_stream_and_context()

2023-03-24 Thread Hamza Mahfooz
On 3/24/23 14:19, Markus Elfring wrote: May longer identifiers (or even the complete SHA-1 ID) occasionally also be tolerated for the tag “Fixes”? How do you think about the proposed change possibilities? Well, the hash length is restricted by convention (see ./scripts/checkpatch.pl in the

Re: (subset) [PATCH v2 0/4] arm64: qcom: sm8450: bindings check cleanup

2023-03-24 Thread Bjorn Andersson
On Fri, 24 Mar 2023 10:28:45 +0100, Neil Armstrong wrote: > A few fixes to pass the DT bindings check successfully > for sm8450 qrd & hdk DTs. > > The following are still needed to pass all the checks: > - > https://lore.kernel.org/r/20230308082424.140224-3-manivannan.sadhasi...@linaro.org > -

Re: (subset) [PATCH v6 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS

2023-03-24 Thread Bjorn Andersson
On Fri, 17 Mar 2023 16:06:31 +0100, Neil Armstrong wrote: > Switch the QMP PHY to the newly documented USB3/DP Combo PHY > bindings at [1] and add the DP controller nodes. > > The DP output is shared with the USB3 SuperSpeed lanes and is > usually connected to an USB-C port which Altmode is

Re: [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-24 Thread Belgaumkar, Vinay
On 3/15/2023 8:59 PM, Ashutosh Dixit wrote: On dGfx, the PL1 power limit being enabled and set to a low value results in a low GPU operating freq. It also negates the freq raise operation which is done before GuC firmware load. As a result GuC firmware load can time out. Such timeouts were

[Bug 216625] [regression] GPU lockup on Radeon R7 Kaveri

2023-03-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216625 --- Comment #11 from Pierre Ossman (pierre-bugzi...@ossman.eu) --- (In reply to Pierre Ossman from comment #9) > > It now hangs more arbitrarily, not just when trying to play a video. Having > done a suspend/resume cycle is still a requirement

Re: [PATCH resent] drm/amd/display: Fix exception handling in dm_validate_stream_and_context()

2023-03-24 Thread Hamza Mahfooz
Hi Markus, On 3/24/23 11:42, Markus Elfring wrote: Date: Sat, 18 Mar 2023 16:21:32 +0100 The label “cleanup” was used to jump to another pointer check despite of the detail in the implementation of the function “dm_validate_stream_and_context” that it was determined already that corresponding

Re: [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Bjorn Andersson
On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: > Fixes the following DT bindings check error: Is that because idle-state-name and local-timer-stop should not be defined for domain-idle-states or are you just clearing out the dtbs_check warning? According to cpu-capacity.txt

Re: Linux 6.3-rc3

2023-03-24 Thread Masahiro Yamada
Hello Linus, Thanks for giving me some more homeworks. On Thu, Mar 23, 2023 at 1:56 AM Linus Torvalds wrote: > > On Wed, Mar 22, 2023 at 9:40 AM Sedat Dilek wrote: > > > > You have to pass `make LLVM=1` in any case... to `oldconfig` or when > > adding any MAKEFLAGS like

Re: [PATCH] drm/panel-edp: Add B133UAN01.0 edp panel entry

2023-03-24 Thread Doug Anderson
Hi, On Fri, Mar 24, 2023 at 9:59 AM Vinod Koul wrote: > > From: Bjorn Andersson > > This panel is found in Lenovo Flex 5G laptop, so add the entry for it > > Signed-off-by: Bjorn Andersson > Signed-off-by: Vinod Koul > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1

[PATCH] drm/panel-edp: Add B133UAN01.0 edp panel entry

2023-03-24 Thread Vinod Koul
From: Bjorn Andersson This panel is found in Lenovo Flex 5G laptop, so add the entry for it Signed-off-by: Bjorn Andersson Signed-off-by: Vinod Koul --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c

[PATCH v2 2/2] drm/vkms: allow the primary plane to be positioned

2023-03-24 Thread Maíra Canal
Before commit bc0d7fdefec6 ("drm: vkms: Supports to the case where primary plane doesn't match the CRTC"), the composition was executed on top of the primary plane. Therefore, the primary plane needed to cover the entire CRTC. After commit bc0d7fdefec6, this is no longer necessary, as the

[PATCH v2 1/2] drm/vkms: remove the need for the primary plane to be visible

2023-03-24 Thread Maíra Canal
Before commit bc0d7fdefec6 ("drm: vkms: Supports to the case where primary plane doesn't match the CRTC"), the composition was executed on top of the primary plane. Therefore, the primary plane needed to be visible and full screen. After commit bc0d7fdefec6, this is no longer necessary, as the

[PATCH v2 0/2] Update the handling of the primary plane

2023-03-24 Thread Maíra Canal
This patchset focus on the proper handling of the primary plane after the modifications introduced in commit bc0d7fdefec6 ("drm: vkms: Supports to the case where primary plane doesn't match the CRTC"). Before this commit, the composition was executed on top of the primary plane. Therefore, the

Re: [PATCH] drm/msm/a6xx: add CONFIG_PM dependency

2023-03-24 Thread Ulf Hansson
On Fri, 24 Mar 2023 at 10:55, Arnd Bergmann wrote: > > From: Arnd Bergmann > > Selecting CONFIG_PM_GENERIC_DOMAINS causes a build failure when CONFIG_PM > is not enabled: > > WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS > Depends on [n]: PM [=n] > Selected by [m]: > -

Re: [PATCH v3 1/7] drm/dp_helper: Add helper to check DSC support with given o/p format

2023-03-24 Thread Maarten Lankhorst
ack On 2023-03-20 09:59, Jani Nikula wrote: Thomas, Maxime, Maarten, ack for merging this one via drm-intel? BR, Jani. On Thu, 09 Mar 2023, Suraj Kandpal wrote: From: Ankit Nautiyal Add helper to check if the DP sink supports DSC with the given o/p format. v2: Add documentation for the

Re: [PATCH] drm/bridge: it6505: Add lock for it6505 i2c bank

2023-03-24 Thread Hsin-Yi Wang
On Fri, Mar 24, 2023 at 8:18 PM Andrzej Hajda wrote: > > > > On 24.03.2023 08:29, Hsin-Yi Wang wrote: > > From: xiazhengqiao > > > > When the i2c bank register (REG_BANK_SEL) is set to 1, > > only the registers belong to bank 1 can be written. > > There will be a race condition when a process is

Re: [PATCH v4 3/8] accel/qaic: Add MHI controller

2023-03-24 Thread Jeffrey Hugo
On 3/24/2023 4:26 AM, Manivannan Sadhasivam wrote: On Mon, Mar 20, 2023 at 09:11:09AM -0600, Jeffrey Hugo wrote: An AIC100 device contains a MHI interface with a number of different channels for controlling different aspects of the device. The MHI controller works with the MHI bus to enable and

Re: Linux 6.3-rc3

2023-03-24 Thread Kalle Valo
Nathan Chancellor writes: >> This is nitpicking but it would be nice if the tarball contents wouldn't >> conflict with each other. Now both llvm-16.0.0-aarch64.tar.gz and >> llvm-16.0.0-x86_64.tar extract to the same directory llvm-16.0.0 with >> same binary names. It would be much better if

Re: Linux 6.3-rc3

2023-03-24 Thread Nathan Chancellor
On Fri, Mar 24, 2023 at 12:54:01PM +0200, Kalle Valo wrote: > Nathan Chancellor writes: > > > On Wed, Mar 22, 2023 at 02:44:47PM +0200, Kalle Valo wrote: > >> Nathan Chancellor writes: > >> > >> > Perhaps these would make doing allmodconfig builds with clang more > >> > frequently less painful

Re: BUG: KASAN: slab-use-after-free in drm_sched_get_cleanup_job+0x47b/0x5c0 [gpu_sched]

2023-03-24 Thread Christian König
Am 23.03.23 um 20:05 schrieb Mikhail Gavrilov: On Tue, Mar 21, 2023 at 11:47 PM Christian König wrote: Hi Mikhail, That looks like a reference counting issue to me. I'm going to take a look, but we have already fixed one of those recently. Probably best that you try this on drm-fixes, just

[PATCH] drm/i915/overlay: Remove redundant drm_rect_visible() use

2023-03-24 Thread Arthur Grillo
The drm_rect_intersect() already returns if the intersection is visible or not, so the use of drm_rect_visible() is duplicate. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/i915/display/intel_overlay.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH] drm/bridge: ps8640: Return NULL immediately when EDID read fail

2023-03-24 Thread Robert Foss
On Fri, Mar 24, 2023 at 4:59 AM Pin-yen Lin wrote: > > drm_edid_read returns NULL on error, so feeding it directly into > drm_edid_duplicate may lead to NULL pointer dereference. Add a check to > guard this. > > Fixes: 6a17b4d1b52f ("drm/bridge: ps8640: Add a cache for EDID") > Signed-off-by:

Re: [PATCH] drm/bridge: ps8640: Return NULL immediately when EDID read fail

2023-03-24 Thread Doug Anderson
Hi, On Thu, Mar 23, 2023 at 8:59 PM Pin-yen Lin wrote: > > drm_edid_read returns NULL on error, so feeding it directly into > drm_edid_duplicate may lead to NULL pointer dereference. Add a check to > guard this. > > Fixes: 6a17b4d1b52f ("drm/bridge: ps8640: Add a cache for EDID") >

Re: [PATCH] drm/bridge: it6505: Add lock for it6505 i2c bank

2023-03-24 Thread Andrzej Hajda
On 24.03.2023 08:29, Hsin-Yi Wang wrote: From: xiazhengqiao When the i2c bank register (REG_BANK_SEL) is set to 1, only the registers belong to bank 1 can be written. There will be a race condition when a process is writing bank 0 registers while another process set the bank to 1. Add a

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-03-24 Thread Maxime Ripard
Hi, On Thu, Mar 23, 2023 at 03:35:30PM +, Aidan MacDonald wrote: > > Stephen Boyd writes: > > > Quoting Maxime Ripard (2022-11-09 03:00:45) > >> On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: > >> > > >> > Maxime Ripard writes: > >> > > >> > > Hi, > >> > > > >> > > On

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-03-24 Thread Aidan MacDonald
Stephen Boyd writes: > Quoting Maxime Ripard (2022-11-09 03:00:45) >> On Mon, Nov 07, 2022 at 08:57:22PM +, Aidan MacDonald wrote: >> > >> > Maxime Ripard writes: >> > >> > > Hi, >> > > >> > > On Fri, Nov 04, 2022 at 05:35:29PM +, Aidan MacDonald wrote: >> > >> > Assigning the parent

Re: Linux 6.3-rc3

2023-03-24 Thread Kalle Valo
Nathan Chancellor writes: > On Wed, Mar 22, 2023 at 02:44:47PM +0200, Kalle Valo wrote: >> Nathan Chancellor writes: >> >> > Perhaps these would make doing allmodconfig builds with clang more >> > frequently less painful for you? >> > >> >

Re: [PATCH] gpu: host1x: fix uninitialized variable use

2023-03-24 Thread Daniel Vetter
On Fri, 24 Mar 2023 at 11:38, Thierry Reding wrote: > > On Fri, Mar 24, 2023 at 10:59:23AM +0100, Daniel Vetter wrote: > > On Fri, 24 Mar 2023 at 10:46, Daniel Vetter wrote: > > > > > > On Wed, Mar 08, 2023 at 05:28:06PM +, Jon Hunter wrote: > > > > > > > > > > > > On 08/03/2023 16:56,

Re: [PATCH] gpu: host1x: fix uninitialized variable use

2023-03-24 Thread Thierry Reding
On Fri, Mar 24, 2023 at 10:59:23AM +0100, Daniel Vetter wrote: > On Fri, 24 Mar 2023 at 10:46, Daniel Vetter wrote: > > > > On Wed, Mar 08, 2023 at 05:28:06PM +, Jon Hunter wrote: > > > > > > > > > On 08/03/2023 16:56, Nathan Chancellor wrote: > > > > Ping? This warning is now in 6.3-rc1. > >

Re: [PATCH v4 3/8] accel/qaic: Add MHI controller

2023-03-24 Thread Manivannan Sadhasivam
On Mon, Mar 20, 2023 at 09:11:09AM -0600, Jeffrey Hugo wrote: > An AIC100 device contains a MHI interface with a number of different > channels for controlling different aspects of the device. The MHI > controller works with the MHI bus to enable and drive that interface. > > AIC100 uses the BHI

[PATCH v6] drm/mediatek: add mediatek-drm of vdosys0 support for mt8188

2023-03-24 Thread Jason-JH . Lin
From: Nathan Lu add driver data of mt8188 vdosys0 to mediatek-drm and the sub driver. Signed-off-by: amy zhang Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger --- Rebase on maintainer's tree[1] [1]

Re: [PATCH] gpu: host1x: fix uninitialized variable use

2023-03-24 Thread Daniel Vetter
On Fri, 24 Mar 2023 at 10:46, Daniel Vetter wrote: > > On Wed, Mar 08, 2023 at 05:28:06PM +, Jon Hunter wrote: > > > > > > On 08/03/2023 16:56, Nathan Chancellor wrote: > > > Ping? This warning is now in 6.3-rc1. > > > > Thierry is away at the moment. > > > > David, Daniel, do you want to

[PATCH] drm/msm/a6xx: add CONFIG_PM dependency

2023-03-24 Thread Arnd Bergmann
From: Arnd Bergmann Selecting CONFIG_PM_GENERIC_DOMAINS causes a build failure when CONFIG_PM is not enabled: WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS Depends on [n]: PM [=n] Selected by [m]: - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=m] && (ARCH_QCOM [=y] ||

Re: [pull] amdgpu drm-fixes-6.3

2023-03-24 Thread Daniel Vetter
On Thu, Mar 23, 2023 at 12:19:39PM -0400, Alex Deucher wrote: > Hi Dave, Daniel, > > Fixes for 6.3. > > The following changes since commit e8d018dd0257f744ca50a729e3d042cf2ec9da65: > > Linux 6.3-rc3 (2023-03-19 13:27:55 -0700) > > are available in the Git repository at: > >

Re: [PATCH v2 1/4] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible

2023-03-24 Thread Krzysztof Kozlowski
On 24/03/2023 10:28, Neil Armstrong wrote: > The DSI compatible changed between patchset revisions, but that wasn't > reflected in the bindings. Fix it. > > Fixes: 0eda3c6cb1c5 ("dt-bindings: display/msm: add support for the display > on SM8450") > Signed-off-by: Neil Armstrong > ---

Re: [PATCH] gpu: host1x: fix uninitialized variable use

2023-03-24 Thread Daniel Vetter
On Wed, Mar 08, 2023 at 05:28:06PM +, Jon Hunter wrote: > > > On 08/03/2023 16:56, Nathan Chancellor wrote: > > Ping? This warning is now in 6.3-rc1. > > Thierry is away at the moment. > > David, Daniel, do you want to pick this up directly in the meantime as a fix > for 6.3? Mikko has

Re: Linux 6.3-rc3

2023-03-24 Thread Daniel Vetter
On Mon, 20 Mar 2023 at 19:05, Nathan Chancellor wrote: > > On Sun, Mar 19, 2023 at 01:50:21PM -0700, Linus Torvalds wrote: > > So rc3 is fairly big, but that's not hugely usual: it's when a lot of > > the fixes tick up as it takes a while before people find and start > > reporting issues. > > ...

[PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Neil Armstrong
Fixes the following DT bindings check error: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+'

[PATCH v2 1/4] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible

2023-03-24 Thread Neil Armstrong
The DSI compatible changed between patchset revisions, but that wasn't reflected in the bindings. Fix it. Fixes: 0eda3c6cb1c5 ("dt-bindings: display/msm: add support for the display on SM8450") Signed-off-by: Neil Armstrong ---

[PATCH v2 4/4] arm64: dts: qcom: sm8450: fix pcie1 gpios properties name

2023-03-24 Thread Neil Armstrong
Add the final "s" to the pgio properties and fix the invalid "enable" name to the correct "wake", checked against the HDK8450 schematics. Fixes: bc6588bc25fb ("arm64: dts: qcom: sm8450: add PCIe1 root device") Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++-- 1

[PATCH v2 3/4] arm64: dts: qcom: sm8450: remove invalid power-domain-names in pcie nodes

2023-03-24 Thread Neil Armstrong
Fixes the following DT bindings check error: pci@1c0: Unevaluated properties are not allowed ('power-domain-names' were unexpected) Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH v2 0/4] arm64: qcom: sm8450: bindings check cleanup

2023-03-24 Thread Neil Armstrong
A few fixes to pass the DT bindings check successfully for sm8450 qrd & hdk DTs. The following are still needed to pass all the checks: - https://lore.kernel.org/r/20230308082424.140224-3-manivannan.sadhasi...@linaro.org -

Re: [PULL] drm-intel-fixes

2023-03-24 Thread Daniel Vetter
On Thu, Mar 23, 2023 at 12:46:27PM +0200, Jani Nikula wrote: > > Hi Dave & Daniel - > > Otherwise a fairly regular fixes pull, except for two things: > > First, I have not gotten CI results on this. I don't know what gives. > > Second, I missed adding the hwmon revert to the tag. I

Re: [Intel-gfx] [PATCH v5] drm/i915/pxp: limit drm-errors or warning on firmware API failures

2023-03-24 Thread Jani Nikula
On Thu, 23 Mar 2023, "Ceraolo Spurio, Daniele" wrote: > On 3/23/2023 11:41 AM, Alan Previn wrote: >> MESA driver is creating protected context on every driver handle >> creation to query caps bits for app. So when running CI tests, >> they are observing hundreds of drm_errors when enabling PXP

Re: [PULL] drm-misc-fixes

2023-03-24 Thread Daniel Vetter
On Thu, Mar 23, 2023 at 09:24:01AM +0100, Thomas Zimmermann wrote: > Hi Dave and Daniel, > > here's the weekly PR for drm-misc-fixes. > > Best regards > Thomas > > drm-misc-fixes-2023-03-23: > Short summary of fixes pull: > > * fixes for bind and probing error handling > * panel-orientation

Re: [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node

2023-03-24 Thread neil . armstrong
On 24/03/2023 08:17, Krzysztof Kozlowski wrote: On 23/03/2023 14:13, Neil Armstrong wrote: On 23/03/2023 11:47, Krzysztof Kozlowski wrote: On 23/03/2023 11:25, Neil Armstrong wrote: Fixes the following DT bindings check error: codec@33f: clocks: [[137, 57, 1], [137, 102, 1], [137, 103,

Re: [PATCH v30 0/7] Add MediaTek SoC DRM (vdosys1) support for mt8195

2023-03-24 Thread AngeloGioacchino Del Regno
Il 24/03/23 00:25, Chun-Kuang Hu ha scritto: Hi, Angelo: AngeloGioacchino Del Regno 於 2023年3月23日 週四 下午4:58寫道: Il 21/03/23 13:18, Nancy.Lin ha scritto: The hardware path of vdosys1 with DPTx output need to go through by several modules, such as, OVL_ADAPTOR and MERGE. Add DRM and these

Re: [PATCH 6/6] accel/habanalabs: send disable pci when compute ctx is active

2023-03-24 Thread Stanislaw Gruszka
On Thu, Mar 23, 2023 at 01:35:25PM +0200, Oded Gabbay wrote: > From: Tal Cohen > > Fix an issue in hard reset flow in which the driver didn't send a > disable pci message if there was an active compute context. > In hard reset, disable pci message should be sent no matter if > a compute context

Re: [PATCH 5/6] accel/habanalabs: remove duplicated disable pci msg

2023-03-24 Thread Stanislaw Gruszka
On Thu, Mar 23, 2023 at 01:35:24PM +0200, Oded Gabbay wrote: > From: Tal Cohen > > The disable pci message is sent in reset device. It informs the FW not > to raise more EQs. The Driver may ignore received EQs, when the device > is in disabled mode. > The duplication happens when hard reset is

  1   2   >