Re: [PATCH v7 12/12] drm: sun4: dsi: Convert to bridge driver

2023-03-29 Thread Jagan Teki
On Wed, Mar 29, 2023 at 8:29 PM Maxime Ripard wrote: > > Hi, > > The patch prefix should be drm/sun4i: I did follow my previous prefix, I will update this. > > On Wed, Mar 29, 2023 at 06:49:29PM +0530, Jagan Teki wrote: > > Convert the encoder to bridge driver in order to standardize on a > >

Re: [PATCH v7 09/12] arm64: dts: rockchip: a64: Add endpoint@0 to dsi_in_tcon0

2023-03-29 Thread Jagan Teki
On Wed, Mar 29, 2023 at 8:32 PM Maxime Ripard wrote: > > The commit title is wrong, it's not a rockchip device. Thanks for the note, I will fix it in the next version. > > On Wed, Mar 29, 2023 at 06:46:15PM +0530, Jagan Teki wrote: > > The DSI downstream devices are likely to be Panel, Bridge

Re: [PATCH] drm/ttm: set TTM allocated pages as reserved

2023-03-29 Thread Christian König
Am 29.03.23 um 17:08 schrieb Paolo Bonzini: On 3/29/23 16:28, Paolo Bonzini wrote: On 3/29/23 15:54, Christian König wrote: KVM tries to grab references to pages in VMAs marked with VM_PFNMAP. This is illegal and can cause data corruption with TTM pages because only some of them are actually

Re: [PATCH v7 02/12] drm: bridge: panel: Implement drmm_of_dsi_get_bridge helper

2023-03-29 Thread Jagan Teki
On Wed, Mar 29, 2023 at 8:33 PM Maxime Ripard wrote: > > On Wed, Mar 29, 2023 at 06:46:08PM +0530, Jagan Teki wrote: > > Implement a DRM-managed action helper that returns the next DSI bridge > > in the chain. > > > > Unlike general bridge return helper drmm_of_get_bridge, this helper > > uses

RE: [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support

2023-03-29 Thread Vinod Polimera
> -Original Message- > From: Stephen Boyd > Sent: Monday, March 27, 2023 9:58 PM > To: Bjorn Andersson ; Vinod Polimera (QUIC) > > Cc: dri-devel@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; linux- >

Re: [PATCH] drm/ttm: set TTM allocated pages as reserved

2023-03-29 Thread Paolo Bonzini
On 3/29/23 16:28, Paolo Bonzini wrote: On 3/29/23 15:54, Christian König wrote: KVM tries to grab references to pages in VMAs marked with VM_PFNMAP. This is illegal and can cause data corruption with TTM pages because only some of them are actually reference counted. After some other offlist

Re: [PATCH v7 02/12] drm: bridge: panel: Implement drmm_of_dsi_get_bridge helper

2023-03-29 Thread Maxime Ripard
On Wed, Mar 29, 2023 at 06:46:08PM +0530, Jagan Teki wrote: > Implement a DRM-managed action helper that returns the next DSI bridge > in the chain. > > Unlike general bridge return helper drmm_of_get_bridge, this helper > uses the dsi specific panel_or_bridge helper to find the next DSI > device

Re: [PATCH 2/4] drm/i915: Initialize fbdev DRM client with callback functions

2023-03-29 Thread Sam Ravnborg
Hi Thomas, On Tue, Mar 28, 2023 at 01:14:20PM +0200, Thomas Zimmermann wrote: > Initialize i915's fbdev client by giving an instance of struct > drm_client_funcsi to drm_client_init(). Also clean up with An extra i had sneaked in here Sam

Re: [PATCH v7 09/12] arm64: dts: rockchip: a64: Add endpoint@0 to dsi_in_tcon0

2023-03-29 Thread Maxime Ripard
The commit title is wrong, it's not a rockchip device. On Wed, Mar 29, 2023 at 06:46:15PM +0530, Jagan Teki wrote: > The DSI downstream devices are likely to be Panel, Bridge and > I2C-Configured Bridge. > > It is possible to connect all three devices using upstream OF-graph port > or ports node

Re: [PATCH v7 12/12] drm: sun4: dsi: Convert to bridge driver

2023-03-29 Thread Maxime Ripard
Hi, The patch prefix should be drm/sun4i: On Wed, Mar 29, 2023 at 06:49:29PM +0530, Jagan Teki wrote: > Convert the encoder to bridge driver in order to standardize on a > single API by supporting all varients of downstream bridge devices. Which variant, and why do we need to convert to a

[PATCH 2/2] drm/exynos: Implement support for DSI clock and data lane polarity swap

2023-03-29 Thread Fabio Estevam
From: Marek Vasut Implement support for DSI clock and data lane DN/DP polarity swap by means of decoding 'lane-polarities' DT property. The controller does support DN/DP swap of clock lane and all data lanes, the controller does not support polarity swap of individual data lane bundles, add a

[PATCH 1/2] dt-bindings: display: exynos: dsim: Add 'lane-polarities'

2023-03-29 Thread Fabio Estevam
From: Fabio Estevam The Samsung DSIM IP block allows the inversion of the clock and data lanes. Add an optional property called 'lane-polarities' that describes the polarities of the MIPI DSI clock and data lanes. This is property is useful for properly describing the hardware when the board

Re: [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-29 Thread Johan Hovold
On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: > If we fail to initialize the GPU for whatever reason (say we don't > embed the GPU firmware files in the initrd), the error path involves > pm_runtime_put_sync() which then calls idle() instead of suspend(). > > This is suboptimal,

Re: [PATCH] drm/ttm: set TTM allocated pages as reserved

2023-03-29 Thread Paolo Bonzini
On 3/29/23 15:54, Christian König wrote: KVM tries to grab references to pages in VMAs marked with VM_PFNMAP. This is illegal and can cause data corruption with TTM pages because only some of them are actually reference counted. I think that you are referring to this: /* Don't set the

[PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-29 Thread Konrad Dybcio
If we fail to initialize the GPU for whatever reason (say we don't embed the GPU firmware files in the initrd), the error path involves pm_runtime_put_sync() which then calls idle() instead of suspend(). This is suboptimal, as it means that we're not going through the clean shutdown sequence.

Re: [pull] drm: dma-fence-deadline for v6.4

2023-03-29 Thread Daniel Vetter
On Tue, Mar 28, 2023 at 03:34:02PM -0700, Rob Clark wrote: > Hi Dave and Daniel, > > Here is the series for dma-fence deadline hint, without driver > specific patches, or UAPI, with the intent that it can be merged into > drm-next as well as -driver next trees to enable landing driver > specific

[PATCH] drm/ttm: set TTM allocated pages as reserved

2023-03-29 Thread Christian König
KVM tries to grab references to pages in VMAs marked with VM_PFNMAP. This is illegal and can cause data corruption with TTM pages because only some of them are actually reference counted. Mark all pages allocated by TTM as reserved, this way KVM handles the PFNs like they would point to MMIO

Re: [pull] drm: dma-fence-deadline-core for v6.4

2023-03-29 Thread Tvrtko Ursulin
On 28/03/2023 18:19, Daniel Vetter wrote: On Sat, Mar 25, 2023 at 11:24:56AM -0700, Rob Clark wrote: Hi Dave and Daniel, Here is the series for dma-fence deadline hint, without driver specific patches, with the intent that it can be merged into drm-next as well as -driver next trees to

Re: [PATCH 1/2] drm/amdgpu: Reset GPU on S0ix when device supports BOCO

2023-03-29 Thread Mario Limonciello
On 3/29/23 04:59, Kai-Heng Feng wrote: When the power is lost due to ACPI power resources being turned off, the driver should reset the GPU so it can work anew. First, _PR3 support of the hierarchy needs to be found correctly. Since the GPU on some discrete GFX cards is behind a PCIe switch,

Re: [PATCH 1/2] drm/amdgpu: Reset GPU on S0ix when device supports BOCO

2023-03-29 Thread Alex Deucher
On Wed, Mar 29, 2023 at 6:00 AM Kai-Heng Feng wrote: > > When the power is lost due to ACPI power resources being turned off, the > driver should reset the GPU so it can work anew. > > First, _PR3 support of the hierarchy needs to be found correctly. Since > the GPU on some discrete GFX cards is

[PATCH v7 12/12] drm: sun4: dsi: Convert to bridge driver

2023-03-29 Thread Jagan Teki
Convert the encoder to bridge driver in order to standardize on a single API by supporting all varients of downstream bridge devices. The drm_encoder can't be removed as it's exposed to userspace, so it then becomes a dumb encoder, without any operation implemented. Tested on DSI Panel, DSI

[PATCH v7 11/12] drm/bridge: Document bridge init order with enable_next_first

2023-03-29 Thread Jagan Teki
In order to switch HS mode properly by DSI host, the DSI sink has to send the MIPI-DCS commands first before the DSI host switches to HS mode. This behavior requires a bridge init alter in @enable and @disable function calls with the help of @enable_next_first. Document the affected bridge init

[PATCH v7 10/12] drm/bridge: Implement enable_next_first to alter bridge init order

2023-03-29 Thread Jagan Teki
DSI sink devices typically send the MIPI-DCS commands to the DSI host via general MIPI_DSI_DCS read and write API. The classical DSI sequence mentioned that the DSI host receives MIPI-DCS commands from the DSI sink first in order to switch HS mode properly. Once the DSI host switches to HS mode

[PATCH v7 09/12] arm64: dts: rockchip: a64: Add endpoint@0 to dsi_in_tcon0

2023-03-29 Thread Jagan Teki
The DSI downstream devices are likely to be Panel, Bridge and I2C-Configured Bridge. It is possible to connect all three devices using upstream OF-graph port or ports node however only Panel and Bridge are possible to connect via child node but not possible to connect I2C-Configured Bridge via

[PATCH v7 08/12] ARM: dts: sun8i: a33: Add endpoint@0 to dsi_in_tcon0

2023-03-29 Thread Jagan Teki
The DSI downstream devices are likely to be Panel, Bridge and I2C-Configured Bridge. It is possible to connect all three devices using upstream OF-graph port or ports node however only Panel and Bridge are possible to connect via child node but not possible to connect I2C-Configured Bridge via

[PATCH v7 07/12] drm: panel: ilitek-ili9881c: Enable prepare_prev_first for k101_im2byl02

2023-03-29 Thread Jagan Teki
Enable the drm panel prepare_prev_first flag for k101_im2byl02 panel so-that the previous controller should be prepared first before the prepare for the panel is called.     This makes sure that the previous controller(sun6i-mipi-dsi), likely to be a DSI host controller should be

[PATCH v7 06/12] drm: panel: feixin-k101-im2ba02: Enable prepare_prev_first flag

2023-03-29 Thread Jagan Teki
Enable the drm panel prepare_prev_first flag for feixin-k101-im2ba02 so-that the previous controller should be prepared first before the prepare for the panel is called.     This makes sure that the previous controller(sun6i-mipi-dsi), likely to be a DSI host controller should be

[PATCH v7 05/12] drm: panel: sitronix-st7703: Enable prepare_prev_first for xbd599

2023-03-29 Thread Jagan Teki
Enable the drm panel prepare_prev_first flag for xbd599 panel so-that the previous controller should be prepared first before the prepare for the panel is called.     This makes sure that the previous controller(sun6i-mipi-dsi), likely to be a DSI host controller should be initialized

[PATCH v7 04/12] drm: panel: sitronix-st7701: Enable prepare_prev_first for ts8550b

2023-03-29 Thread Jagan Teki
Enable the drm panel prepare_prev_first flag for ts8550b panel so-that the previous controller should be prepared first before the prepare for the panel is called.     This makes sure that the previous controller(sun6i-mipi-dsi), likely to be a DSI host controller should be initialized to

Re: [PATCH 2/2] drm/amdgpu: Remove ASPM workaround on VI and NV

2023-03-29 Thread Mario Limonciello
On 3/29/23 08:08, Gong, Richard wrote: On 3/29/2023 4:59 AM, Kai-Heng Feng wrote: Since the original issue is resolved by a new fix, the ASPM workaround can be dropped. What is the new fix? Can you elaborate more or add the new fix commit here? It's his first patch in the series, but yes

[PATCH v7 03/12] drm: panel: feiyang-fy07024di26a30d: Enable prepare_prev_first flag

2023-03-29 Thread Jagan Teki
Enable the drm panel prepare_prev_first flag for feiyang-fy07024di26a30d so-that the previous controller should be prepared first before the prepare for the panel is called.     This makes sure that the previous controller(sun6i-mipi-dsi), likely to be a DSI host controller should be

[PATCH v7 02/12] drm: bridge: panel: Implement drmm_of_dsi_get_bridge helper

2023-03-29 Thread Jagan Teki
Implement a DRM-managed action helper that returns the next DSI bridge in the chain. Unlike general bridge return helper drmm_of_get_bridge, this helper uses the dsi specific panel_or_bridge helper to find the next DSI device in the pipeline. Helper lookup a given downstream DSI device that has

[PATCH v7 01/12] drm: of: Lookup if child node has DSI panel or bridge

2023-03-29 Thread Jagan Teki
Devices can also be child nodes when we also control that device through the upstream device (ie, MIPI-DCS for a MIPI-DSI device). Unlike the drm_of_find_panel_or_bridge helper it requires a special case to lookup a child node of the given parent that isn't either port or ports. Lookup for a

[PATCH v7 00/12] drm: sun4i: Convert Allwinner DSI to bridge

2023-03-29 Thread Jagan Teki
This is v7 revision of converting Allwinner DSI to brige driver. Patch 1 and 2 implements drmm_of_dsi_get_bridge which is required to lookup the DSI sink device represented either child or OF-graph port or ports node. This is essential as not to break the existing bindings which indeed uses child

Re: [PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread Christian König
Am 29.03.23 um 13:28 schrieb Jani Nikula: On Wed, 29 Mar 2023, Maíra Canal wrote: On 3/29/23 03:55, David Gow wrote: The drm_buddy_test KUnit tests verify that returned blocks have sizes which are powers of two using is_power_of_2(). However, is_power_of_2() operations on a 'long', but the

Re: [PATCH 2/2] drm/amdgpu: Remove ASPM workaround on VI and NV

2023-03-29 Thread Gong, Richard
On 3/29/2023 4:59 AM, Kai-Heng Feng wrote: Since the original issue is resolved by a new fix, the ASPM workaround can be dropped. What is the new fix? Can you elaborate more or add the new fix commit here? Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 -

Re: [PATCH v2] drm/mediatek: Add ovl_adaptor get format function

2023-03-29 Thread AngeloGioacchino Del Regno
Il 29/03/23 03:59, Nancy.Lin ha scritto: Add ovl_adaptor get_format and get_num_formats component function. The two functions are need for getting the supported format in mtk_plane_init(). Signed-off-by: Nancy.Lin Small note: This commit depends on f287c66a6064 ("drm/mediatek: Refactor

[PATCH 2/2] drm/bridge: fsl-ldb: Add i.MX6SX support

2023-03-29 Thread Fabio Estevam
From: Fabio Estevam i.MX6SX has a single LVDS port and share a similar LDB_CTRL register layout with i.MX8MP and i.MX93. There is no LVDS CTRL register on the i.MX6SX, so only write to this register on the appropriate SoCs. Add support for the i.MX6SX LDB. Tested on a imx6sx-sdb board with a

[PATCH 1/2] dt-bindings: display: bridge: ldb: Add i.MX6SX support

2023-03-29 Thread Fabio Estevam
From: Fabio Estevam i.MX6SX has a single LVDS port and share a similar LDB_CTRL register layout with i.MX8MP and i.MX93. Signed-off-by: Fabio Estevam --- .../devicetree/bindings/display/bridge/fsl,ldb.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [PATCH v6 0/8] drm/i915: use ref_tracker library for tracking wakerefs

2023-03-29 Thread Andi Shyti
Eric, David (Miller), Could you please check the ref_tracker portion of this series? This patch has reached its 6th version, and we need your approval to proceed. Thank you, Andi On Wed, Mar 29, 2023 at 09:24:12AM +0200, Andrzej Hajda wrote: > Gently ping for network developers, could you look

Re: [PATCH v6 3/8] lib/ref_tracker: add printing to memory buffer

2023-03-29 Thread Andi Shyti
Hi Andrzej, On Wed, Mar 29, 2023 at 09:24:14AM +0200, Andrzej Hajda wrote: > Similar to stack_(depot|trace)_snprint the patch > adds helper to printing stats to memory buffer. > It will be helpful in case of debugfs. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH v6 2/8] lib/ref_tracker: improve printing stats

2023-03-29 Thread Andi Shyti
Hi Andrzej, [...] > -void ref_tracker_dir_print_locked(struct ref_tracker_dir *dir, > - unsigned int display_limit) > +struct ref_tracker_dir_stats { > + int total; > + int count; > + struct { > + depot_stack_handle_t stack_handle; > +

Re: [PATCH v6 1/8] lib/ref_tracker: add unlocked leak print helper

2023-03-29 Thread Andi Shyti
Hi Andrzej, On Wed, Mar 29, 2023 at 09:24:12AM +0200, Andrzej Hajda wrote: > To have reliable detection of leaks, caller must be able to check under the > same > lock both: tracked counter and the leaks. dir.lock is natural candidate for > such > lock and unlocked print helper can be called

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-03-29 Thread Hans Verkuil
Hi Luca, On 29/03/2023 13:16, Hans Verkuil wrote: > Hi Luca, > > I finally found the time to test this series. It looks OK, except for this > patch. > The list of supported formats really has to be the intersection of what the > tegra > supports and what the sensor supports. > > Otherwise you

Re: [PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread Jani Nikula
On Wed, 29 Mar 2023, Maíra Canal wrote: > On 3/29/23 03:55, David Gow wrote: >> The drm_buddy_test KUnit tests verify that returned blocks have sizes >> which are powers of two using is_power_of_2(). However, is_power_of_2() >> operations on a 'long', but the block size is a u64. So on systems

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-03-29 Thread Hans Verkuil
Hi Luca, I finally found the time to test this series. It looks OK, except for this patch. The list of supported formats really has to be the intersection of what the tegra supports and what the sensor supports. Otherwise you would advertise pixelformats that cannot be used, and the

Re: [PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread Maíra Canal
On 3/29/23 03:55, David Gow wrote: The drm_buddy_test KUnit tests verify that returned blocks have sizes which are powers of two using is_power_of_2(). However, is_power_of_2() operations on a 'long', but the block size is a u64. So on systems where long is 32-bit, this can sometimes fail even

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

2023-03-29 Thread Sui Jingfeng
On 2023/3/29 17:04, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:   The assignment already done in drm_client_buffer_vmap(),   just trival clean, no functional change. Signed-off-by: Sui Jingfeng <15330273...@189.cn> ---  

Re: [PATCH 6.2 regression fix] drm/nouveau/kms: Fix backlight registration

2023-03-29 Thread Hans de Goede
Hi, On 3/29/23 00:23, Lyude Paul wrote: > Reviewed-by: Lyude Paul > > (Also note to Mark: this is my way of letting you know someone fixed the > regression with backlight controls upstream, looking into the weird bright > screen after resume issue) Thanks. I have pushed this to drm-misc-fixes

Re: [PATCH 7/7] dt-bindings: display: add panel-timing property to sitronix,st7789v

2023-03-29 Thread Michael Riesch
Hi Maxime, On 3/29/23 11:16, Maxime Ripard wrote: > On Thu, Mar 16, 2023 at 11:29:53PM +0100, Michael Riesch wrote: >> Hi Rob, >> >> On 3/16/23 22:57, Rob Herring wrote: >>> On Tue, Mar 14, 2023 at 12:56:44PM +0100, Gerald Loacker wrote: The sitronix-st7789v driver now considers the

[PATCH 2/2] drm/amdgpu: Remove ASPM workaround on VI and NV

2023-03-29 Thread Kai-Heng Feng
Since the original issue is resolved by a new fix, the ASPM workaround can be dropped. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 15 --- drivers/gpu/drm/amd/amdgpu/nv.c| 2 +-

[PATCH 1/2] drm/amdgpu: Reset GPU on S0ix when device supports BOCO

2023-03-29 Thread Kai-Heng Feng
When the power is lost due to ACPI power resources being turned off, the driver should reset the GPU so it can work anew. First, _PR3 support of the hierarchy needs to be found correctly. Since the GPU on some discrete GFX cards is behind a PCIe switch, checking the _PR3 on downstream port alone

Re: [PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread Jani Nikula
On Wed, 29 Mar 2023, Jani Nikula wrote: > On Wed, 29 Mar 2023, David Gow wrote: >> The drm_buddy_test KUnit tests verify that returned blocks have sizes >> which are powers of two using is_power_of_2(). However, is_power_of_2() >> operations on a 'long', but the block size is a u64. So on

Re: [PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread Jani Nikula
On Wed, 29 Mar 2023, David Gow wrote: > The drm_buddy_test KUnit tests verify that returned blocks have sizes > which are powers of two using is_power_of_2(). However, is_power_of_2() > operations on a 'long', but the block size is a u64. So on systems where > long is 32-bit, this can sometimes

[PATCH][next] drm/msm/mdss: Fix spelling mistake "Unuspported" -> "Unsupported"

2023-03-29 Thread Colin Ian King
There is a spelling mistake in a dev_error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index c15d1e2dc718..7cb301854e64

Re: [PATCH 1/1] drm/i915: fix race condition UAF in i915_perf_add_config_ioctl

2023-03-29 Thread Tvrtko Ursulin
On 29/03/2023 01:48, Umesh Nerlige Ramappa wrote: On Tue, Mar 28, 2023 at 02:08:47PM +0100, Tvrtko Ursulin wrote: On 28/03/2023 10:36, Min Li wrote: Userspace can guess the id value and try to race oa_config object creation with config remove, resulting in a use-after-free if we

Re: [PATCH 7/7] dt-bindings: display: add panel-timing property to sitronix,st7789v

2023-03-29 Thread Maxime Ripard
On Thu, Mar 16, 2023 at 11:29:53PM +0100, Michael Riesch wrote: > Hi Rob, > > On 3/16/23 22:57, Rob Herring wrote: > > On Tue, Mar 14, 2023 at 12:56:44PM +0100, Gerald Loacker wrote: > >> The sitronix-st7789v driver now considers the panel-timing property. > > > > I read the patch for that and

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

2023-03-29 Thread Thomas Zimmermann
Am 29.03.23 um 11:04 schrieb Thomas Zimmermann: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:   The assignment already done in drm_client_buffer_vmap(),   just trival clean, no functional change. Signed-off-by: Sui Jingfeng <15330273...@189.cn> ---  

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

2023-03-29 Thread Thomas Zimmermann
(cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng: The assignment already done in drm_client_buffer_vmap(), just trival clean, no functional change. Signed-off-by: Sui Jingfeng <15330273...@189.cn> --- drivers/gpu/drm/drm_fbdev_generic.c | 5 ++--- 1 file changed, 2

Re: [PATCH 0/7] Add timing override to sitronix,st7789v

2023-03-29 Thread Gerald Loacker
Hi, Besides dt-bindings, there has been no feedback on this series yet. How to proceed? For clarification: Besides adjusting panel parameters, we need the panel-timing to add a partial display mode later. Regards, Gerald Am 14.03.2023 um 12:56 schrieb Gerald Loacker: > This patch set adds

Re: Linux 6.3-rc3

2023-03-29 Thread Kalle Valo
Nathan Chancellor writes: >> >> And maybe request a similar llvm directory under pub/tools to make it >> >> more official? :) > > We now have https://kernel.org/pub/tools/llvm/, which is about as > official as we can get I suppose :) Nice, thanks. Bookmarked and I'll advertise this to wireless

Re: [PATCH v2] drm/mediatek: Add ovl_adaptor get format function

2023-03-29 Thread 胡俊光

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-03-29 Thread Tvrtko Ursulin
On 28/03/2023 18:52, Rodrigo Vivi wrote: On Tue, Mar 28, 2023 at 05:01:36PM +, Teres Alexis, Alan Previn wrote: On Mon, 2023-03-27 at 17:15 +0100, Tvrtko Ursulin wrote: These two: e6177ec586d1 ("drm/i915/huc: stall media submission until HuC is loaded") b76c14c8fb2a ("drm/i915/huc:

[PATCH 1/1] drm/i915: fix race condition UAF in i915_perf_add_config_ioctl

2023-03-29 Thread Min Li
Userspace can guess the id value and try to race oa_config object creation with config remove, resulting in a use-after-free if we dereference the object after unlocking the metrics_lock. For that reason, unlocking the metrics_lock must be done after we are done dereferencing the object.

[PATCH v6 6/8] drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library

2023-03-29 Thread Andrzej Hajda
Beside reusing existing code, the main advantage of ref_tracker is tracking per instance of wakeref. It allows also to catch double put. On the other side we lose information about the first acquire and the last release, but the advantages outweigh it. Signed-off-by: Andrzej Hajda ---

[PATCH v6 8/8] drm/i915/gt: Hold a wakeref for the active VM

2023-03-29 Thread Andrzej Hajda
From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. Signed-off-by: Chris Wilson Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_context.h

[PATCH v6 7/8] drm/i915: track gt pm wakerefs

2023-03-29 Thread Andrzej Hajda
Track every intel_gt_pm_get() until its corresponding release in intel_gt_pm_put() by returning a cookie to the caller for acquire that must be passed by on released. When there is an imbalance, we can see who either tried to free a stale wakeref, or who forgot to free theirs. Signed-off-by:

[PATCH v6 5/8] drm/i915: Correct type of wakeref variable

2023-03-29 Thread Andrzej Hajda
Wakeref has dedicated type. Assumption it will be int compatible forever is incorrect. Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v6 4/8] lib/ref_tracker: remove warnings in case of allocation failure

2023-03-29 Thread Andrzej Hajda
Library can handle allocation failures. To avoid allocation warnings __GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been replaced with GFP_NOWAIT in case of stack allocation on tracker free call. Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- lib/ref_tracker.c | 5

[PATCH v2 8/9] drm/i915: Use kmap_local_page() in i915_cmd_parser.c

2023-03-29 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the call from kmap_atomic() to kmap_local_page(). The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption (the

[PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c

2023-03-29 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the calls from kmap_atomic() to kmap_local_page(). The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption (the

[PATCH v2 7/9] drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c

2023-03-29 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the call from kmap_atomic() to kmap_local_page(). The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption (the

[PATCH v6 3/8] lib/ref_tracker: add printing to memory buffer

2023-03-29 Thread Andrzej Hajda
Similar to stack_(depot|trace)_snprint the patch adds helper to printing stats to memory buffer. It will be helpful in case of debugfs. Signed-off-by: Andrzej Hajda --- include/linux/ref_tracker.h | 8 +++ lib/ref_tracker.c | 56 ++--- 2

[PATCH v6 1/8] lib/ref_tracker: add unlocked leak print helper

2023-03-29 Thread Andrzej Hajda
To have reliable detection of leaks, caller must be able to check under the same lock both: tracked counter and the leaks. dir.lock is natural candidate for such lock and unlocked print helper can be called with this lock taken. As a bonus we can reuse this helper in ref_tracker_dir_exit.

[PATCH v6 2/8] lib/ref_tracker: improve printing stats

2023-03-29 Thread Andrzej Hajda
In case the library is tracking busy subsystem, simply printing stack for every active reference will spam log with long, hard to read, redundant stack traces. To improve readabilty following changes have been made: - reports are printed per stack_handle - log is more compact, - added display name

[PATCH v2 6/9] drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_context.c

2023-03-29 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the call from kmap_atomic() to kmap_local_page(). The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption. With

[PATCH v2 5/9] drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_coherency.c

2023-03-29 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the call from kmap_atomic() to kmap_local_page(). The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption (the

[PATCH v6 0/8] drm/i915: use ref_tracker library for tracking wakerefs

2023-03-29 Thread Andrzej Hajda
Gently ping for network developers, could you look at ref_tracker patches, as the ref_tracker library was developed for network. This is revived patchset improving ref_tracker library and converting i915 internal tracker to ref_tracker. The old thread ended without consensus about small kernel

[PATCH v2 4/9] drm/i915: Use kmap_local_page() in gem/selftests/huge_pages.c

2023-03-29 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the call from kmap_atomic() to kmap_local_page(). The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption (the

[PATCH v2 3/9] drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c

2023-03-29 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1]. The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption (the preemption is disabled for !PREEMPT_RT case, otherwise it only disables

[PATCH v2 2/9] drm/i915: Use memcpy_[from/to]_page() in gem/i915_gem_pyhs.c

2023-03-29 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the call from kmap_atomic() + memcpy() to memcpy_[from/to]_page(), which use kmap_local_page() to build local mapping and then do memcpy(). The main difference between atomic

[PATCH v2 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

2023-03-29 Thread Zhao Liu
From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the call from kmap_atomic() to kmap_local_page(). The main difference between atomic and local mappings is that local mappings doesn't disable page faults or preemption (the

[PATCH v2 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2023-03-29 Thread Zhao Liu
From: Zhao Liu Hi list, Sorry for a long delay since v1 [1]. This patchset is based on 197b6b6 (Linux 6.3-rc4). Welcome and thanks for your review and comments! # Purpose of this patchset The purpose of this pacthset is to replace all uses of kmap_atomic() in i915 with kmap_local_page()

Re: [PATCH 1/2] drm: buddy_allocator: Fix buddy allocator init on 32-bit systems

2023-03-29 Thread Christian König
Am 29.03.23 um 08:55 schrieb David Gow: The drm buddy allocator tests were broken on 32-bit systems, as rounddown_pow_of_two() takes a long, and the buddy allocator handles 64-bit sizes even on 32-bit systems. This can be reproduced with the drm_buddy_allocator KUnit tests on i386:

[PATCH 2/2] drm: test: Fix 32-bit issue in drm_buddy_test

2023-03-29 Thread David Gow
The drm_buddy_test KUnit tests verify that returned blocks have sizes which are powers of two using is_power_of_2(). However, is_power_of_2() operations on a 'long', but the block size is a u64. So on systems where long is 32-bit, this can sometimes fail even on correctly sized blocks. This only

[PATCH 1/2] drm: buddy_allocator: Fix buddy allocator init on 32-bit systems

2023-03-29 Thread David Gow
The drm buddy allocator tests were broken on 32-bit systems, as rounddown_pow_of_two() takes a long, and the buddy allocator handles 64-bit sizes even on 32-bit systems. This can be reproduced with the drm_buddy_allocator KUnit tests on i386: ./tools/testing/kunit/kunit.py run --arch i386

[PATCH] drm/mediatek: dp: change the aux retries times when receiving AUX_DEFER

2023-03-29 Thread xinlei.lee
From: Xinlei Lee DP 1.4a Section 2.8.7.1.5.6.1: A DP Source device shall retry at least seven times upon receiving AUX_DEFER before giving up the AUX transaction. The drm_dp_i2c_do_msg() function in the drm_dp_helper.c file will judge the status of the msg->reply parameter passed to

<    1   2