Re: [PATCH 0/2] Use i915 instead of dev_priv

2023-04-22 Thread Andi Shyti
Hi, On Fri, Apr 21, 2023 at 03:46:52PM +0200, Andi Shyti wrote: > Hi, > > just another "Friday patch". While reviewing some patches from > Tejas I found a bit confusing the use of dev_priv__ inside the > for_each_engine(), perhaps it should be moved inside the gt/? > > As I was at it I made the

Re: [PATCH v2] drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2

2023-04-22 Thread Jeff Layton
On Wed, 2023-04-19 at 16:21 +0300, Jani Nikula wrote: > On Wed, 19 Apr 2023, Jeff Layton wrote: > > I've been experiencing some intermittent crashes down in the display > > driver code. The symptoms are ususally a line like this in dmesg: > > > > amdgpu :30:00.0: [drm] Failed to create

Re: [PATCH v2 0/2] Define MOCS and PAT tables for MTL

2023-04-22 Thread Andi Shyti
Hi, On Fri, Apr 21, 2023 at 08:25:33PM +0200, Andi Shyti wrote: > Hi, > > just extracting this patch from Fei's series. > > Andi > > Changelog: > == > v1 -> v2: > Taken from Fei's new series: https://patchwork.freedesktop.org/series/115980/ > - Removed unnecessary defines > - Place

[PATCH] fbdev: modedb: Add a 1920x1080 at 60 Hz video mode

2023-04-22 Thread Helge Deller
Add typical resolution for Full-HD monitors. Signed-off-by: Helge Deller diff --git a/drivers/video/fbdev/core/modedb.c b/drivers/video/fbdev/core/modedb.c index 6473e0dfe146..90915a4caac6 100644 --- a/drivers/video/fbdev/core/modedb.c +++ b/drivers/video/fbdev/core/modedb.c @@ -257,6 +257,10

Re: [Intel-gfx] [PATCH] video/hdmi: minor fixes for *_infoframe_init functions

2023-04-22 Thread kernel test robot
Hi Nikita, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Nikita-Zhandarovich/video-hdmi-minor-fixes-for-_infoframe_init-functions/20230421-221128 base:

[PATCH v2 09/13] drm/panel: sitronix-st7789v: avoid hardcoding panel size

2023-04-22 Thread Sebastian Reichel
Move the panel size information to the mode struct, so that different panel sizes can be specified depending on the panel type. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v2 12/13] drm/panel: sitronix-st7789v: avoid hardcoding polarity info

2023-04-22 Thread Sebastian Reichel
Add polarity information via mode and bus flags, so that they are no longer hardcoded and forward the information to the DRM stack. This is required for adding panels with different settings. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 22

[PATCH v2 06/13] drm/panel: sitronix-st7789v: simplify st7789v_spi_write

2023-04-22 Thread Sebastian Reichel
st7789v_spi_write initializes a message with just a single transfer, spi_sync_transfer can be used for that. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH v2 07/13] drm/panel: sitronix-st7789v: improve error handling

2023-04-22 Thread Sebastian Reichel
Improve error handling in the probe routine, so that probe defer errors are captured in /sys/kernel/debug/devices_deferred Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 23 ++- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git

[PATCH v2 05/13] drm/panel: sitronix-st7789v: make reset GPIO optional

2023-04-22 Thread Sebastian Reichel
The reset pin might not be software controllable from the SoC, so make it optional. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH v2 10/13] drm/panel: sitronix-st7789v: add media bus format

2023-04-22 Thread Sebastian Reichel
Add support for describing the media bus format in the panel configuration and expose that to userspace. Since both supported formats (RGB565 and RGB666) are using 6 bits per color also hardcode that information. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH v2 11/13] drm/panel: sitronix-st7789v: avoid hardcoding invert mode

2023-04-22 Thread Sebastian Reichel
While the default panel uses invert mode, some panels require non-invert mode instead. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH v2 02/13] dt-bindings: display: st7789v: add Inanbo T28CP45TN89

2023-04-22 Thread Sebastian Reichel
Add compatible value for Inanbo t28cp45tn89 and make reset GPIO non mandatory, since it might not be connected to the CPU. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 13/13] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support

2023-04-22 Thread Sebastian Reichel
UNI-T UTi260b has a Inanbo T28CP45TN89 v17 panel. I could not find proper documentation for the panel apart from a technical drawing, but according to the vendor U-Boot it is based on a Sitronix st7789v chip. I generated the init sequence by modifying the default one until proper graphics output

[PATCH v2 08/13] drm/panel: sitronix-st7789v: avoid hardcoding mode info

2023-04-22 Thread Sebastian Reichel
Avoid hard-coding the default_mode and supply it from match data. One additional layer of abstraction has been introduced, which will be needed for specifying other panel information (e.g. bus flags) in the next steps. Signed-off-by: Sebastian Reichel ---

[PATCH v2 04/13] drm/panel: sitronix-st7789v: remove unused constants

2023-04-22 Thread Sebastian Reichel
ST7789V_COLMOD_RGB_FMT_18BITS and ST7789V_COLMOD_CTRL_FMT_18BITS are unused in favour of MIPI_DCS_PIXEL_FMT_18BIT, remove them. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH v2 01/13] dt-bindings: vendor-prefixes: add Inanbo

2023-04-22 Thread Sebastian Reichel
Shenzhen INANBO Electronic Technology Co., Ltd. manufacturers TFT/OLED LCD panels. Acked-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 03/13] drm/panel: sitronix-st7789v: add SPI ID table

2023-04-22 Thread Sebastian Reichel
SPI device drivers should also have a SPI ID table. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH v2 00/13] Add Inanbo T28CP45TN89 panel support

2023-04-22 Thread Sebastian Reichel
Hi, This adds panel support for Inanbo T28CP45TN89, which I found inside of a handheld thermal camera. The panel is based on the st7789v controller. All information is based on reverse engineering. Changes since PATCHv1: * https://lore.kernel.org/all/20230317232355.1554980-1-...@kernel.org/ *

Re: [PATCH 1/3] drm: bridge: icn6211: Only warn on invalid chip IDs

2023-04-22 Thread Jagan Teki
Hi Brandon, On Wed, Apr 19, 2023 at 12:43 AM Marek Vasut wrote: > > On 4/18/23 15:42, Jagan Teki wrote: > > On Tue, Apr 18, 2023 at 5:52 PM Brandon Cheo Fusi > > wrote: > >> > >> Avoid aborting chip configuration after reading invalid IDs and > >> instead issue a warning. I have a bunch of

Re: [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-22 Thread Abhinav Kumar
On 4/22/2023 7:11 AM, Dmitry Baryshkov wrote: On 22/04/2023 15:08, Konrad Dybcio wrote: On 22.04.2023 00:35, Dmitry Baryshkov wrote: On 22/04/2023 01:34, Abhinav Kumar wrote: On 4/20/2023 3:52 PM, Dmitry Baryshkov wrote: On 20/04/2023 22:56, Marijn Suijten wrote: On 2023-04-20

Re: [PATCH v1 0/3] Add ioctls to map grant refs on the external backing storage

2023-04-22 Thread Oleksii Moisieiev
Hello, Just wanted to add some additional information hoping it will help to start the discussion and find a correct approach: My goal is to provide correct buffer for the interfaces, such as zwp_linux_dmabuf_v1_interface, so zero-copy feature will work. My suggestion is to give a possibility

[PATCH 0/7] add displays support for bsh-smm-s2/pro boards

2023-04-22 Thread Dario Binacchi
The series adds drivers for the displays used by bsh-smm-s2/pro boards. It has been tested applying it on top of these patches: Adam Ford (6) arm64: dts: imx8mn: Add display peripherals drm: bridge: samsung-dsim: Dynamically configure DPHY timing drm: bridge: samsung-dsim: Fetch

Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2023-04-22 Thread Konstantin Ryabitsev
April 21, 2023 1:01 PM, "Krzysztof Kozlowski" wrote: >> Ah, got it. So I guess from the perspective of "b4" every time the >> author modifies a patch (like adding new tags to it) then it's a new >> application of Signed-off-by and thus the old Signed-off-by is removed >> from the top and a new

[PATCH 5/7] drm/panel: Add Ilitek ILI9805 panel driver

2023-04-22 Thread Dario Binacchi
From: Michael Trimarchi The GPM1790A0 panel is based on the Ilitek ILI9805 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig| 8 +

[PATCH 4/7] dt-bindings: display: panel: Add Ilitek ili9805 panel controller

2023-04-22 Thread Dario Binacchi
From: Michael Trimarchi Add documentation for "ilitek,ili9805" panel. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- .../display/panel/ilitek,ili9805.yaml | 60 +++ 1 file changed, 60 insertions(+) create mode 100644

[PATCH 6/7] dt-bindings: ili9805: add compatible string for Tianma TM041XDHG01

2023-04-22 Thread Dario Binacchi
From: Michael Trimarchi Add Tianma TM041XDHG01 that utilizes an Ilitek ILI9805 controller chip, so its compatible string should be added to ilitek,ili9805 file. Add the compatible string for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi ---

[PATCH 2/7] drm/panel: Add Synaptics R63353 panel driver

2023-04-22 Thread Dario Binacchi
From: Michael Trimarchi The LS068B3SX02 panel is based on the Synaptics R63353 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 8 +

[PATCH 1/7] dt-bindings: display: panel: Add synaptics r63353 panel controller

2023-04-22 Thread Dario Binacchi
From: Michael Trimarchi Add documentation for "synaptics,r63353" panel. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- .../display/panel/synaptics,r63353.yaml | 58 +++ 1 file changed, 58 insertions(+) create mode 100644

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-22 Thread Arnaud Vrac
Le ven. 21 avr. 2023 à 15:27, Hans Verkuil a écrit : > > Hi Arnaud, > > Some review comments below... Hi Hans, For context, I first based my work on the fbdev driver from Qualcomm a few years ago, on our own CEC framework which does not implement any CEC protocol logic (as android does). At the

[PATCH 7/7] drm/panel: ilitek-ili9805: add support for Tianma TM041XDHG01 panel

2023-04-22 Thread Dario Binacchi
From: Michael Trimarchi Tianma TM041XDHG01 utilizes the Ilitek ILI9805 controller. Add this panel's initialzation sequence and timing to ILI9805 driver. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 53

Re: [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-22 Thread Dmitry Baryshkov
On 22/04/2023 15:08, Konrad Dybcio wrote: On 22.04.2023 00:35, Dmitry Baryshkov wrote: On 22/04/2023 01:34, Abhinav Kumar wrote: On 4/20/2023 3:52 PM, Dmitry Baryshkov wrote: On 20/04/2023 22:56, Marijn Suijten wrote: On 2023-04-20 22:51:22, Dmitry Baryshkov wrote: On 20/04/2023 22:47,

Re: [PATCH v10 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-04-22 Thread Konrad Dybcio
On 19.04.2023 17:43, Mark Yacoub wrote: > From: Sean Paul > > Add the register ranges required for HDCP key injection and > HDCP TrustZone interaction as described in the dt-bindings for the > sc7180 dp controller. > > Reviewed-by: Douglas Anderson > Signed-off-by: Sean Paul >

Re: [PATCH 4/4] arm64: dts: qcom: msm8998: add hdmi cec pinctrl nodes

2023-04-22 Thread Konrad Dybcio
On 18.04.2023 20:10, Arnaud Vrac wrote: > HDMI is not enabled yet on msm8998 so the pinctrl nodes are not > used. > > Signed-off-by: Arnaud Vrac > --- Are they supposed to be identical? Konrad > arch/arm64/boot/dts/qcom/msm8998.dtsi | 14 ++ > 1 file changed, 14 insertions(+) >

Re: [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-22 Thread Konrad Dybcio
On 22.04.2023 00:35, Dmitry Baryshkov wrote: > On 22/04/2023 01:34, Abhinav Kumar wrote: >> >> >> On 4/20/2023 3:52 PM, Dmitry Baryshkov wrote: >>> On 20/04/2023 22:56, Marijn Suijten wrote: On 2023-04-20 22:51:22, Dmitry Baryshkov wrote: > On 20/04/2023 22:47, Abhinav Kumar wrote:

Re: [PATCH 1/2] fbdev/offb: Update expected device name

2023-04-22 Thread Helge Deller
On 4/12/23 11:55, Cyril Brulebois wrote: Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required. This means

Re: [PATCH] video: fbdev: mmp: Fix deferred clk handling in mmphw_probe()

2023-04-22 Thread Helge Deller
On 4/13/23 21:33, Christophe JAILLET wrote: When dev_err_probe() is called, 'ret' holds the value of the previous successful devm_request_irq() call. 'ret' should be assigned with a meaningful value before being used in dev_err_probe(). While at it, use and return "PTR_ERR(ctrl->clk)" instead

Re: [PATCH] linux/vt_buffer.h: allow either builtin or modular for macros

2023-04-22 Thread Helge Deller
On 3/29/23 04:15, Randy Dunlap wrote: Fix build errors on ARCH=alpha when CONFIG_MDA_CONSOLE=m. This allows the ARCH macros to be the only ones defined. In file included from ../drivers/video/console/mdacon.c:37: ../arch/alpha/include/asm/vga.h:17:40: error: expected identifier or '(' before

[linux-next:master] BUILD REGRESSION d3e1ee0e67e7603d36f4fa2fec6b881c01aabe89

2023-04-22 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d3e1ee0e67e7603d36f4fa2fec6b881c01aabe89 Add linux-next specific files for 20230421 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202304210303.nlmi0srq-...@intel.com