Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-28 Thread Stephen Boyd
Quoting Pin-yen Lin (2023-04-20 02:10:46) > On Thu, Apr 20, 2023 at 2:10 PM Stephen Boyd wrote: > > > > Quoting Stephen Boyd (2023-04-13 17:22:46) > > > Quoting Pin-yen Lin (2023-04-13 02:50:44) > > > > > > > > Actually the `mode-switch` property here is mainly because > > > >

Re: [Freedreno] [PATCH v2 5/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature PP_BLK and PP_BLK_TE

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 07:04, Abhinav Kumar wrote: On 4/28/2023 8:21 PM, Dmitry Baryshkov wrote: On Sat, 29 Apr 2023 at 05:50, Abhinav Kumar wrote: On 4/28/2023 6:41 PM, Dmitry Baryshkov wrote: On 29/04/2023 04:08, Abhinav Kumar wrote: On 4/28/2023 5:45 PM, Dmitry Baryshkov wrote: On

Re: [PATCH] drm/msm/dpu: drop unused SSPP sub-block information

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 07:29, Abhinav Kumar wrote: On 4/28/2023 7:42 PM, Dmitry Baryshkov wrote: The driver  doesn't support hsic/memcolor, pcc and igc SSPP subblocks. Drop corresponding definitions. Signed-off-by: Dmitry Baryshkov ---   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 8  

Re: [PATCH] drm/msm/dpu: drop unused SSPP sub-block information

2023-04-28 Thread Abhinav Kumar
On 4/28/2023 7:42 PM, Dmitry Baryshkov wrote: The driver doesn't support hsic/memcolor, pcc and igc SSPP subblocks. Drop corresponding definitions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 8 1 file changed, 8 deletions(-) diff --git

Re: [Freedreno] [PATCH v2 5/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature PP_BLK and PP_BLK_TE

2023-04-28 Thread Abhinav Kumar
On 4/28/2023 8:21 PM, Dmitry Baryshkov wrote: On Sat, 29 Apr 2023 at 05:50, Abhinav Kumar wrote: On 4/28/2023 6:41 PM, Dmitry Baryshkov wrote: On 29/04/2023 04:08, Abhinav Kumar wrote: On 4/28/2023 5:45 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: Legacy DPU

Re: drm/fb-helper: Fix height, width, and accel_flags in fb_var

2023-04-28 Thread Sui Jingfeng
Hi, I have just tested this patch on a LoongArch(3a5000+ls7a2000 evb) machine, both fbtest and the fbdev test of IGT finished. fbtest say test001: ~ test013: PASSED, After apply your patch, the warn log `accel_flags changed from 0 to 1` disappeared while  running it. So, Tested-by: Sui

Re: [PATCH v2 0/7] add DSC 1.2 dpu supports

2023-04-28 Thread Abhinav Kumar
On 4/28/2023 8:12 PM, Dmitry Baryshkov wrote: On Sat, 29 Apr 2023 at 05:51, Abhinav Kumar wrote: On 4/28/2023 7:46 PM, Dmitry Baryshkov wrote: On Sat, 29 Apr 2023 at 02:45, Kuogee Hsieh wrote: This series adds the DPU side changes to support DSC 1.2 encoder. This was validated with

Re: [PATCH v2 5/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature PP_BLK and PP_BLK_TE

2023-04-28 Thread Dmitry Baryshkov
On Sat, 29 Apr 2023 at 05:50, Abhinav Kumar wrote: > > > > On 4/28/2023 6:41 PM, Dmitry Baryshkov wrote: > > On 29/04/2023 04:08, Abhinav Kumar wrote: > >> > >> > >> On 4/28/2023 5:45 PM, Dmitry Baryshkov wrote: > >>> On 29/04/2023 02:45, Kuogee Hsieh wrote: > Legacy DPU requires PP hardware

Re: [PATCH v2 0/7] add DSC 1.2 dpu supports

2023-04-28 Thread Dmitry Baryshkov
On Sat, 29 Apr 2023 at 05:51, Abhinav Kumar wrote: > > > > On 4/28/2023 7:46 PM, Dmitry Baryshkov wrote: > > On Sat, 29 Apr 2023 at 02:45, Kuogee Hsieh wrote: > >> > >> This series adds the DPU side changes to support DSC 1.2 encoder. This > >> was validated with both DSI DSC 1.2 panel and DP

Re: [PATCH v3 0/3] drm/vkms: Add support for multiple pipes

2023-04-28 Thread Jim Shargo
Hey, all! I am so excited to see other folks excited about extending VKMS. I think it's a great project and has outstanding potential! Life stuff made me AFK for the last few months, but I'm back now and I've been wrapping up the work on the patchset Brandon linked. The current WIP patches are

Re: [PATCH v2 0/7] add DSC 1.2 dpu supports

2023-04-28 Thread Abhinav Kumar
On 4/28/2023 7:46 PM, Dmitry Baryshkov wrote: On Sat, 29 Apr 2023 at 02:45, Kuogee Hsieh wrote: This series adds the DPU side changes to support DSC 1.2 encoder. This was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. The DSI and DP parts will be pushed later on top of this

Re: [PATCH v2 5/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature PP_BLK and PP_BLK_TE

2023-04-28 Thread Abhinav Kumar
On 4/28/2023 6:41 PM, Dmitry Baryshkov wrote: On 29/04/2023 04:08, Abhinav Kumar wrote: On 4/28/2023 5:45 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: Legacy DPU requires PP hardware block involved into setting up DSC Nit: to be envolved data path. This patch

Re: [PATCH v2 0/7] add DSC 1.2 dpu supports

2023-04-28 Thread Dmitry Baryshkov
On Sat, 29 Apr 2023 at 02:45, Kuogee Hsieh wrote: > > This series adds the DPU side changes to support DSC 1.2 encoder. This > was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. > The DSI and DP parts will be pushed later on top of this change. > This seriel is rebase on [1], [2]

[PATCH] drm/msm/dpu: drop unused SSPP sub-block information

2023-04-28 Thread Dmitry Baryshkov
The driver doesn't support hsic/memcolor, pcc and igc SSPP subblocks. Drop corresponding definitions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h

Re: [PATCH v2 5/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature PP_BLK and PP_BLK_TE

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 04:08, Abhinav Kumar wrote: On 4/28/2023 5:45 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: Legacy DPU requires PP hardware block involved into setting up DSC Nit: to be envolved data path. This patch add DDPU_PINGPONG_DSC feature bit to both adds

Re: [PATCH v2 7/7] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 04:22, Abhinav Kumar wrote: On 4/28/2023 5:52 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going to be setup. This patch doesn't determine

[PATCH v2 3/3] drm/msm/dpu: access CSC/CSC10 registers directly

2023-04-28 Thread Dmitry Baryshkov
Stop using _sspp_subblk_offset() to get offset of the csc_blk. Inline this function and use ctx->cap->sblk->csc_blk.base directly. As this was the last user, drop _sspp_subblk_offset() too. Reviewed-by: Jeykumar Sankaran Signed-off-by: Dmitry Baryshkov ---

[PATCH v2 2/3] drm/msm/dpu: access QSEED registers directly

2023-04-28 Thread Dmitry Baryshkov
Stop using _sspp_subblk_offset() to get offset of the scaler_blk. Inline this function and use ctx->cap->sblk->scaler_blk.base directly. Reviewed-by: Jeykumar Sankaran Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 27 +++-- 1 file changed, 9

[PATCH v2 1/3] drm/msm/dpu: drop SSPP's SRC subblock

2023-04-28 Thread Dmitry Baryshkov
The src_blk declares a lame copy of main SSPP register space. It's offset is always 0. It's length has been fixed to 0x150, while SSPP's length is now correct. Drop the src_blk and access SSPP registers without additional subblock lookup. Signed-off-by: Dmitry Baryshkov ---

[PATCH v2 0/3] drm/msm/dpu: drop _sspp_subblk_offset()

2023-04-28 Thread Dmitry Baryshkov
Rework dpu_hw_sspp.c to access sblk base address directly rather than getting the sblk address through indirect function call. Changes since v1: - Dropped DPU_SSPP_SRC feature, making SRC-related functions mandatory (suggested by Jeykumar) Dmitry Baryshkov (3): drm/msm/dpu: drop SSPP's SRC

Re: [PATCH v2 7/7] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-28 Thread Abhinav Kumar
On 4/28/2023 5:52 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going to be setup. This patch doesn't determine the mode. It changes programming of DSC

Re: [Intel-gfx] [PATCH 4/6] drm/i915/uc: Enhancements to firmware table validation

2023-04-28 Thread Ceraolo Spurio, Daniele
On 4/28/2023 5:32 PM, John Harrison wrote: On 4/28/2023 17:30, John Harrison wrote: On 4/28/2023 17:26, Ceraolo Spurio, Daniele wrote: On 4/28/2023 5:16 PM, John Harrison wrote: On 4/28/2023 17:04, Ceraolo Spurio, Daniele wrote: On 4/20/2023 6:15 PM, john.c.harri...@intel.com wrote:

[PATCH] agp/uninorth: remove unused variable size

2023-04-28 Thread Tom Rix
For ppc64, gcc with W=1 reports drivers/char/agp/uninorth-agp.c: In function 'uninorth_create_gatt_table': drivers/char/agp/uninorth-agp.c:372:13: error: variable 'size' set but not used [-Werror=unused-but-set-variable] 372 | int size; | ^~~~ This variable is not

Re: [PATCH v2 1/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 04:10, Abhinav Kumar wrote: On 4/28/2023 5:30 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Reported-by: kernel test robot What exactly was reported?

Re: [PATCH v2 1/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-28 Thread Abhinav Kumar
On 4/28/2023 5:30 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Reported-by: kernel test robot What exactly was reported?

Re: [PATCH v2 5/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature PP_BLK and PP_BLK_TE

2023-04-28 Thread Abhinav Kumar
On 4/28/2023 5:45 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: Legacy DPU requires PP hardware block involved into setting up DSC Nit: to be envolved data path. This patch add DDPU_PINGPONG_DSC feature bit to both adds PP_BLK and PP_BLK_TE so that both

Re: [Freedreno] [PATCH v2 4/7] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-04-28 Thread Abhinav Kumar
On 4/28/2023 6:04 PM, Dmitry Baryshkov wrote: On 29/04/2023 04:03, Abhinav Kumar wrote: On 4/28/2023 5:35 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: From: Abhinav Kumar In preparation of calling ping-pong DSC related functions only for chipsets which have such

Re: [Freedreno] [PATCH v2 4/7] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 04:03, Abhinav Kumar wrote: On 4/28/2023 5:35 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: From: Abhinav Kumar In preparation of calling ping-pong DSC related functions only for chipsets which have such a design add the dsc blocks for the chipsets for

Re: [Freedreno] [PATCH v2 4/7] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-04-28 Thread Abhinav Kumar
On 4/28/2023 5:35 PM, Dmitry Baryshkov wrote: On 29/04/2023 02:45, Kuogee Hsieh wrote: From: Abhinav Kumar In preparation of calling ping-pong DSC related functions only for chipsets which have such a design add the dsc blocks for the chipsets for which DSC is present but was not added in

Re: [PATCH v2 6/7] drm/msm/dpu: save dpu topology configuration

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 02:45, Kuogee Hsieh wrote: At current implementation, topology configuration is thrown away after dpu_rm_reserve(). This patch save the topology so that it can be used for DSC related calculation later. Even if we delay the virtual wide planes patchset, please don't save the

Re: [PATCH v2 7/7] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 02:45, Kuogee Hsieh wrote: During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going to be setup. This patch doesn't determine the mode. It changes programming of DSC bits according to the mode being selected.

Re: [PATCH v2 5/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature PP_BLK and PP_BLK_TE

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 02:45, Kuogee Hsieh wrote: Legacy DPU requires PP hardware block involved into setting up DSC Nit: to be envolved data path. This patch add DDPU_PINGPONG_DSC feature bit to both adds PP_BLK and PP_BLK_TE so that both dpu_hw_pp_setup_dsc() and dpu_hw_pp_dsc_enable() will be

Re: [PATCH v2 4/7] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 02:45, Kuogee Hsieh wrote: From: Abhinav Kumar In preparation of calling ping-pong DSC related functions only for chipsets which have such a design add the dsc blocks for the chipsets for which DSC is present but was not added in the catalog. Why/how is it prearing us for such

Re: [Intel-gfx] [PATCH 4/6] drm/i915/uc: Enhancements to firmware table validation

2023-04-28 Thread John Harrison
On 4/28/2023 17:30, John Harrison wrote: On 4/28/2023 17:26, Ceraolo Spurio, Daniele wrote: On 4/28/2023 5:16 PM, John Harrison wrote: On 4/28/2023 17:04, Ceraolo Spurio, Daniele wrote: On 4/20/2023 6:15 PM, john.c.harri...@intel.com wrote: From: John Harrison The validation of the

Re: [PATCH v2 2/7] drm/msm/dpu: separate DSC flush update out of interface

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 02:45, Kuogee Hsieh wrote: Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separate DSC flush away from dpu_hw_ctl_intf_cfg_v1() by Nit: separates adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits

Re: [PATCH 4/6] drm/i915/uc: Enhancements to firmware table validation

2023-04-28 Thread John Harrison
On 4/28/2023 17:26, Ceraolo Spurio, Daniele wrote: On 4/28/2023 5:16 PM, John Harrison wrote: On 4/28/2023 17:04, Ceraolo Spurio, Daniele wrote: On 4/20/2023 6:15 PM, john.c.harri...@intel.com wrote: From: John Harrison The validation of the firmware table was being done inside the code for

Re: [PATCH v2 1/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 02:45, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Reported-by: kernel test robot What exactly was reported? Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 +

Re: [PATCH v2 0/7] add DSC 1.2 dpu supports

2023-04-28 Thread Dmitry Baryshkov
On 29/04/2023 02:45, Kuogee Hsieh wrote: This series adds the DPU side changes to support DSC 1.2 encoder. This was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. The DSI and DP parts will be pushed later on top of this change. This seriel is rebase on [1], [2] and catalog fixes

Re: [PATCH 4/6] drm/i915/uc: Enhancements to firmware table validation

2023-04-28 Thread Ceraolo Spurio, Daniele
On 4/28/2023 5:16 PM, John Harrison wrote: On 4/28/2023 17:04, Ceraolo Spurio, Daniele wrote: On 4/20/2023 6:15 PM, john.c.harri...@intel.com wrote: From: John Harrison The validation of the firmware table was being done inside the code for scanning the table for the next available

Re: [Intel-gfx] [PATCH 6/6] drm/i915/uc: Make unexpected firmware versions an error in debug builds

2023-04-28 Thread John Harrison
On 4/28/2023 17:19, Ceraolo Spurio, Daniele wrote: On 4/20/2023 6:15 PM, john.c.harri...@intel.com wrote: From: John Harrison If the DEBUG_GEM config option is set then escalate the 'unexpected firmware version' message from a notice to an error. This will ensure that the CI system treats

Re: [Intel-gfx] [PATCH 6/6] drm/i915/uc: Make unexpected firmware versions an error in debug builds

2023-04-28 Thread Ceraolo Spurio, Daniele
On 4/20/2023 6:15 PM, john.c.harri...@intel.com wrote: From: John Harrison If the DEBUG_GEM config option is set then escalate the 'unexpected firmware version' message from a notice to an error. This will ensure that the CI system treats such occurences as a failure and logs a bug about it

Re: [PATCH 4/6] drm/i915/uc: Enhancements to firmware table validation

2023-04-28 Thread John Harrison
On 4/28/2023 17:04, Ceraolo Spurio, Daniele wrote: On 4/20/2023 6:15 PM, john.c.harri...@intel.com wrote: From: John Harrison The validation of the firmware table was being done inside the code for scanning the table for the next available firmware blob. Which is unnecessary. So pull it out

Re: [PATCH 5/6] drm/i915/uc: Reject duplicate entries in firmware table

2023-04-28 Thread Ceraolo Spurio, Daniele
On 4/20/2023 6:15 PM, john.c.harri...@intel.com wrote: From: John Harrison It was noticed that duplicate entries in the firmware table could cause an infinite loop in the firmware loading code if that entry failed to load. Duplicate entries are a bug anyway and so should never happen.

Re: [PATCH 4/6] drm/i915/uc: Enhancements to firmware table validation

2023-04-28 Thread Ceraolo Spurio, Daniele
On 4/20/2023 6:15 PM, john.c.harri...@intel.com wrote: From: John Harrison The validation of the firmware table was being done inside the code for scanning the table for the next available firmware blob. Which is unnecessary. So pull it out into a separate function that is only called once

Re: [PATCH 3/6] drm/i915/uc: Track patch level versions on reduced version firmware files

2023-04-28 Thread Ceraolo Spurio, Daniele
On 4/20/2023 6:15 PM, john.c.harri...@intel.com wrote: From: John Harrison When reduced version firmware files were added (matching major component being the only strict requirement), the minor version was still tracked and a notification reported if it was older. However, the patch version

[PATCH v2 6/7] drm/msm/dpu: save dpu topology configuration

2023-04-28 Thread Kuogee Hsieh
At current implementation, topology configuration is thrown away after dpu_rm_reserve(). This patch save the topology so that it can be used for DSC related calculation later. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 32 ++--- 1 file

[PATCH v2 5/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature PP_BLK and PP_BLK_TE

2023-04-28 Thread Kuogee Hsieh
Legacy DPU requires PP hardware block involved into setting up DSC data path. This patch add DDPU_PINGPONG_DSC feature bit to both PP_BLK and PP_BLK_TE so that both dpu_hw_pp_setup_dsc() and dpu_hw_pp_dsc_enable() will be executed during DSC path setup. Reported-by : Marijn Suijten

[PATCH v2 2/7] drm/msm/dpu: separate DSC flush update out of interface

2023-04-28 Thread Kuogee Hsieh
Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separate DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits at same time to make it consistent with the location of flush

[PATCH v2 4/7] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-04-28 Thread Kuogee Hsieh
From: Abhinav Kumar In preparation of calling ping-pong DSC related functions only for chipsets which have such a design add the dsc blocks for the chipsets for which DSC is present but was not added in the catalog. Signed-off-by: Abhinav Kumar ---

[PATCH v2 7/7] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-28 Thread Kuogee Hsieh
During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going to be setup. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 56 - 1 file changed, 31 insertions(+), 25 deletions(-)

[PATCH v2 3/7] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-28 Thread Kuogee Hsieh
From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE) contains dual hard slice DSC encoders so both share same base address but with its own different sub block address. Signed-off-by: Abhinav

[PATCH v2 1/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-28 Thread Kuogee Hsieh
Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Reported-by: kernel test robot Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 34 ++-

[PATCH v2 0/7] add DSC 1.2 dpu supports

2023-04-28 Thread Kuogee Hsieh
This series adds the DPU side changes to support DSC 1.2 encoder. This was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. The DSI and DP parts will be pushed later on top of this change. This seriel is rebase on [1], [2] and catalog fixes from [3]. [1]:

[PATCH v3 2/4] drm/msm/dpu: remove DPU_DSPP_IGC handling in dspp flush

2023-04-28 Thread Abhinav Kumar
Inverse gamma correction blocks (IGC) are not used today so lets remove the usage of DPU_DSPP_IGC in the DSPP flush to make it easier to remove IGC from the catalog. We can add this back when IGC is properly supported in DPU with one of the standard DRM properties. changes in v3: - minor

[PATCH v3 3/4] drm/msm/dpu: remove GC and IGC related code from dpu catalog

2023-04-28 Thread Abhinav Kumar
Gamma Correction (GC) and Inverse Gamma Correction(IGC) is currently unused. In addition dpu_dspp_sub_blks didn't even have an igc member describing the block. Drop related code from the dpu hardware catalog otherwise this becomes a burden to carry across chipsets in the catalog. changes in v3:

[PATCH v3 4/4] drm/msm/dpu: drop DSPP_MSM8998_MASK from hw catalog

2023-04-28 Thread Abhinav Kumar
Since GC and IGC masks have now been dropped DSPP_MSM8998_MASK is same as DSPP_SC7180_MASK. Since DSPP_SC7180_MASK is used more than DSPP_MSM8998_MASK, lets drop the latter. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten ---

[PATCH v3 1/4] drm/msm/dpu: remove DPU_DSPP_GC handling in dspp flush

2023-04-28 Thread Abhinav Kumar
Gamma correction blocks (GC) are not used today so lets remove the usage of DPU_DSPP_GC in the dspp flush to make it easier to remove GC from the catalog. We can add this back when GC is properly supported in DPU with one of the standard DRM properties. changes in v3: - drop the link tag

Re: [PATCH] drm/sysfs: Expose DRM connector id in each connector sysfs

2023-04-28 Thread Manasi Navare
Hi Won, Thanks for the patch, I have now merged to drm-misc-next Regards Manasi On Mon, Apr 17, 2023 at 3:52 PM Manasi Navare wrote: > > On Tue, Mar 28, 2023 at 6:45 PM Won Chung wrote: > > > > Expose DRM connector id in device sysfs so that we can map the connector > > id to the connector

Re: [PATCH v6] drm/sysfs: Link DRM connectors to corresponding Type-C connectors

2023-04-28 Thread Manasi Navare
Hi Won, Thanks for the patch, patch now merged to drm-misc-next Regards Manasi On Thu, Apr 27, 2023 at 9:58 AM Won Chung wrote: > > Create a symlink pointing to USB Type-C connector for DRM connectors > when they are created. The link will be created only if the firmware is > able to describe

Re: [PATCH v2] dt-bindings: display/msm: dsi-controller-main: Document qcom, master-dsi and qcom, sync-dual-dsi

2023-04-28 Thread Abhinav Kumar
On Thu, 27 Apr 2023 20:21:32 +0800, Jianhua Lu wrote: > This fixes warning: > sm8250-xiaomi-elish-csot.dtb: dsi@ae94000: Unevaluated properties are not > allowed ('qcom,master-dsi', 'qcom,sync-dual-dsi' were unexpected) > > Applied, thanks! [1/1] dt-bindings: display/msm:

Re: (subset) [PATCH 00/11] drm/msm/dpu: tweaks for better hardware resources allocation

2023-04-28 Thread Abhinav Kumar
On Wed, 19 Apr 2023 16:41:07 +0200, Arnaud Vrac wrote: > This series include misc fixes related to hardware resource allocations > in the msm dpu driver, some specifically for msm8998 (including hw > catalog fixes and cursor sspp support for cursor planes, instead of > using Smart DMA pipes). >

Re: (subset) [PATCH v3 0/3] drm/msm/dpu: Drop useless for-loop HW block lookup

2023-04-28 Thread Abhinav Kumar
On Wed, 26 Apr 2023 01:11:08 +0200, Marijn Suijten wrote: > Doing a for loop in every DPU HW block driver init to find a catalog > entry matching the given ID is rather useless if the init function > called by RM already has that catalog entry pointer, and uses exactly > its ID to drive this

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Yang, Fei
> On 27/04/2023 17:07, Yang, Fei wrote: >>> On 26/04/2023 16:41, Yang, Fei wrote: > On 26/04/2023 07:24, fei.y...@intel.com wrote: >> From: Fei Yang >> >> The first three patches in this series are taken from >> https://patchwork.freedesktop.org/series/116868/ >> These

Re: [PATCH] drm/msm/dp: unregister audio driver during unbind

2023-04-28 Thread Abhinav Kumar
On Fri, 21 Apr 2023 15:56:57 +0100, Srinivas Kandagatla wrote: > while binding the code always registers a audio driver, however there > is no corresponding unregistration done in unbind. This leads to multiple > redundant audio platform devices if dp_display_bind and dp_display_unbind > happens

[PATCH v2 3/8] drm/i915/huc: Parse the GSC-enabled HuC binary

2023-04-28 Thread Daniele Ceraolo Spurio
The new binaries that support the 2-step authentication have contain the legacy-style binary, which we can use for loading the HuC via DMA. To find out where this is located in the image, we need to parse the meu manifest of the GSC binary. The manifest consist of a partition header followed by

[PATCH v2 5/8] drm/i915/huc: differentiate the 2 steps of the MTL HuC auth flow

2023-04-28 Thread Daniele Ceraolo Spurio
Before we add the second step of the MTL HuC auth (via GSC), we need to have the ability to differentiate between them. To do so, the huc authentication check is duplicated for GuC and GSC auth, with meu binaries being considered fully authenticated only after the GSC auth step. To report the

[PATCH v2 8/8] drm/i915/huc: define HuC FW version for MTL

2023-04-28 Thread Daniele Ceraolo Spurio
Follow the same logic as DG2, so just a meu binary with no version number. Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c

[PATCH v2 6/8] drm/i915/mtl/huc: auth HuC via GSC

2023-04-28 Thread Daniele Ceraolo Spurio
The full authentication via the GSC requires an heci packet submission to the GSC FW via the GSC CS. The GSC has new PXP command for this (literally called NEW_HUC_AUTH). The intel_huc_auth fuction is also updated to handle both authentication types. Signed-off-by: Daniele Ceraolo Spurio Cc:

[PATCH v2 7/8] drm/i915/mtl/huc: Use the media gt for the HuC getparam

2023-04-28 Thread Daniele Ceraolo Spurio
On MTL, for obvious reasons, HuC is only available on the media tile. We already disable SW support for HuC on the root gt due to the absence of VCS engines, but we also need to update the getparam to point to the HuC struct in the media GT. Signed-off-by: Daniele Ceraolo Spurio Cc: John

[PATCH v2 4/8] drm/i915/huc: Load GSC-enabled HuC via DMA xfer if the fuse says so

2023-04-28 Thread Daniele Ceraolo Spurio
In the previous patch we extracted the offset of the legacy-style HuC binary located within the GSC-enabled blob, so now we can use that to load the HuC via DMA if the fuse is set that way. Note that we now need to differentiate between "GSC-enabled binary" and "loaded by GSC", so the former case

[PATCH v2 2/8] drm/i915/uc: perma-pin firmwares

2023-04-28 Thread Daniele Ceraolo Spurio
Now that each FW has its own reserved area, we can keep them always pinned and skip the pin/unpin dance on reset. This will make things easier for the 2-step HuC authentication, which requires the FW to be pinned in GGTT after the xfer is completed. Given that we use dummy vmas for the pinning, we

[PATCH v2 1/8] DO NOT REVIEW: drm/i915: Add support for MTL GSC SW Proxy

2023-04-28 Thread Daniele Ceraolo Spurio
This is a squash of the GSC proxy series, which is being reviewed separately [1]. It's being included here because some of the patches in this series depend on it. This is not a functional dependencies, the patches just touch the same code and the proxy patches are planned to be merged first, so

[PATCH v2 0/8] drm/i915: HuC loading and authentication for MTL

2023-04-28 Thread Daniele Ceraolo Spurio
The HuC loading and authentication flow is once again changing and a new "clear-media only" authentication step is introduced. The flow is as follows: 1) The HuC is loaded via DMA - same as all non-GSC HuC binaries. 2) The HuC is authenticated by the GuC - this is the same step as performed for

[PATCH v2 4/4] drm/i915/guc: Fix error capture for virtual engines

2023-04-28 Thread John . C . Harrison
From: John Harrison GuC based register dumps in error capture logs were basically broken for virtual engines. This can be seen in igt@gem_exec_balancer@hang: [IGT] gem_exec_balancer: starting subtest hang [drm] GPU HANG: ecode 12:4:e1524110, in gem_exec_balanc [6388] [drm] GT0: GUC: No

[PATCH v2 3/4] drm/i915/guc: Capture list naming clean up

2023-04-28 Thread John . C . Harrison
From: John Harrison Don't use 'xe_lp*' prefixes for register lists that are common with Gen8. Don't add Xe only GSC registers to pre-Xe devices that don't even have a GSC engine. Fix Xe_LP name. Don't use GEN9 as a prefix for register lists that contain all GEN8 registers. Rename the

[PATCH v2 2/4] drm/i915/guc: Consolidate duplicated capture list code

2023-04-28 Thread John . C . Harrison
From: John Harrison Remove 99% duplicated steered register list code. Also, include the pre-Xe steered registers in the pre-Xe list generation. Signed-off-by: John Harrison Reviewed-by: Alan Previn --- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 112 +- 1 file changed, 29

[PATCH v2 0/4] Improvements to GuC error capture

2023-04-28 Thread John . C . Harrison
From: John Harrison The GuC error capture list creation was including Gen8 registers on Xe platforms. While fixing that, it was noticed that there were other issues. The platform naming was wrong, the naming of lists was misleading, the steered register code was duplicated and steered registers

[PATCH v2 1/4] drm/i915/guc: Don't capture Gen8 regs on Xe devices

2023-04-28 Thread John . C . Harrison
From: John Harrison A pair of pre-Xe registers were being included in the Xe capture list. GuC was rejecting those as being invalid and logging errors about them. So, stop doing it. Signed-off-by: John Harrison Reviewed-by: Alan Previn Fixes: dce2bd542337 ("drm/i915/guc: Add Gen9 registers

Re: [PATCH v3 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Yang, Fei
>> On 4/28/23 17:19, Yang, Fei wrote: >>> On 4/28/23 07:47, fei.y...@intel.com wrote: From: Fei Yang The first three patches in this series are taken from https://patchwork.freedesktop.org/series/116868/ These patches are included here because the last patch has

Re: [PATCH resent] drm/bridge: it6505: Move a variable assignment behind a null pointer check in receive_timing_debugfs_show()

2023-04-28 Thread Robert Foss
On Fri, Apr 28, 2023 at 5:56 PM Markus Elfring wrote: > > From: Markus Elfring > Date: Sun, 16 Apr 2023 17:30:46 +0200 > > The address of a data structure member was determined before > a corresponding null pointer check in the implementation of > the function “receive_timing_debugfs_show”. > >

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Sam Ravnborg
Hi Thomas, On Fri, Apr 28, 2023 at 04:18:38PM +0200, Thomas Zimmermann wrote: > I'd be happy to have fb_() wrappers that are I/O helpers without > ordering guarantees. I'd just wouldn't want them in How about throwing them into a new drm_fb.h header file. This header file could be the home for

Re: [PATCH v2] dt-bindings: display/msm: dsi-controller-main: Document qcom,master-dsi and qcom,sync-dual-dsi

2023-04-28 Thread Abhinav Kumar
On 4/27/2023 5:21 AM, Jianhua Lu wrote: This fixes warning: sm8250-xiaomi-elish-csot.dtb: dsi@ae94000: Unevaluated properties are not allowed ('qcom,master-dsi', 'qcom,sync-dual-dsi' were unexpected) Reviewed-by: Dmitry Baryshkov Acked-by: Rob Herring Signed-off-by: Jianhua Lu ---

[PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example

2023-04-28 Thread Jianhua Lu
The kinetic,ktz8866 is a I2C driver, so add the missing reg property. And update example to make it clear. Signed-off-by: Jianhua Lu --- .../leds/backlight/kinetic,ktz8866.yaml | 29 --- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git

Re: [PATCH v3 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Intel
On 4/28/23 17:19, Yang, Fei wrote: > On 4/28/23 07:47, fei.y...@intel.com wrote: >> From: Fei Yang >> >> The first three patches in this series are taken from >> https://patchwork.freedesktop.org/series/116868/ >> These patches are included here because the last patch >> has dependency on the

[PATCH resent] drm/bridge: it6505: Move a variable assignment behind a null pointer check in receive_timing_debugfs_show()

2023-04-28 Thread Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2023 17:30:46 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “receive_timing_debugfs_show”. Thus avoid the risk for undefined behaviour by moving the assignment

Re: [PATCH v3 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-28 Thread Yang, Fei
> On 4/28/23 07:47, fei.y...@intel.com wrote: >> From: Fei Yang >> >> The first three patches in this series are taken from >> https://patchwork.freedesktop.org/series/116868/ >> These patches are included here because the last patch >> has dependency on the pat_index refactor. >> >> This series

Re: [PATCH 2/3] drm: add define for Static_Metadata_Descriptor_ID

2023-04-28 Thread Simon Ser
On Friday, April 28th, 2023 at 15:12, Pekka Paalanen wrote: > the subject says "define" but this is an enum. No big deal, but the > thing I started wondering is how I am going to use these in userspace. > There is no #define I could test to know if I need to provide a > fallback definition.

Re: [PATCH v2 13/19] fbdev/xen-fbfront: Use struct fb_info.screen_buffer

2023-04-28 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use info->screen_buffer when reading and writing framebuffers in > system memory. It's the correct pointer for this address space. > > The struct fb_info has a union to store the framebuffer memory. This can > either be info->screen_base if the framebuffer is stored

Re: [PATCH v2 12/19] fbdev/vfb: Use struct fb_info.screen_buffer

2023-04-28 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use info->screen_buffer when reading and writing framebuffers in > system memory. It's the correct pointer for this address space. > > The struct fb_info has a union to store the framebuffer memory. This can > either be info->screen_base if the framebuffer is stored

Re: [PATCH v2 11/19] fbdev/udlfb: Use struct fb_info.screen_buffer

2023-04-28 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use info->screen_buffer when reading and writing framebuffers in > system memory. It's the correct pointer for this address space. > > The struct fb_info has a union to store the framebuffer memory. This can > either be info->screen_base if the framebuffer is stored

Re: [PATCH v2 10/19] fbdev/smscufx: Use struct fb_info.screen_buffer

2023-04-28 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use info->screen_buffer when reading and writing framebuffers in > system memory. It's the correct pointer for this address space. > > The struct fb_info has a union to store the framebuffer memory. This can > either be info->screen_base if the framebuffer is stored

Re: [PATCH] accel/habanalabs: Make use of rhashtable

2023-04-28 Thread Cai Huoqing
On 26 4月 23 19:22:43, Cai Huoqing wrote: > On 26 4月 23 17:28:02, Cai Huoqing wrote: > > Using rhashtable to accelerate the search for userptr by address, > > instead of using a list. > > > > Preferably, the lookup complexity of a hash table is O(1). > > > > This patch will speedup the method > >

[PATCH v2] accel/habanalabs: Make use of rhashtable

2023-04-28 Thread Cai Huoqing
Using rhashtable to accelerate the search for userptr by address, instead of using a list. Preferably, the lookup complexity of a hash table is O(1). This patch will speedup the method hl_userptr_is_pinned by rhashtable_lookup_fast. Signed-off-by: Cai Huoqing --- v1->v2: Use

Re: [PATCH v2 09/19] fbdev/ps3fb: Use struct fb_info.screen_buffer

2023-04-28 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use info->screen_buffer when reading and writing framebuffers in > system memory. It's the correct pointer for this address space. > > The struct fb_info has a union to store the framebuffer memory. This can > either be info->screen_base if the framebuffer is stored

Re: [PATCH v2 5/9] drm: Add fdinfo memory stats

2023-04-28 Thread Rob Clark
On Fri, Apr 28, 2023 at 3:56 AM Tvrtko Ursulin wrote: > > > On 27/04/2023 18:53, Rob Clark wrote: > > From: Rob Clark > > > > Add support to dump GEM stats to fdinfo. > > > > v2: Fix typos, change size units to match docs, use div_u64 > > v3: Do it in core > > v4: more kerneldoc > > > >

Re: [PATCH v2 08/19] fbdev/metronomefb: Use struct fb_info.screen_buffer

2023-04-28 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use info->screen_buffer when reading and writing framebuffers in > system memory. It's the correct pointer for this address space. > > The struct fb_info has a union to store the framebuffer memory. This can > either be info->screen_base if the framebuffer is stored

Re: [PATCH v2 07/19] fbdev/hecubafb: Use struct fb_info.screen_buffer

2023-04-28 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use info->screen_buffer when reading and writing framebuffers in > system memory. It's the correct pointer for this address space. > > The struct fb_info has a union to store the framebuffer memory. This can > either be info->screen_base if the framebuffer is stored

Re: [PATCH v2 06/19] fbdev/broadsheetfb: Use struct fb_info.screen_buffer

2023-04-28 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use info->screen_buffer when reading and writing framebuffers in > system memory. It's the correct pointer for this address space. > > The struct fb_info has a union to store the framebuffer memory. This can > either be info->screen_base if the framebuffer is stored

Re: [PATCH v2 1/9] drm/docs: Fix usage stats typos

2023-04-28 Thread Rob Clark
On Fri, Apr 28, 2023 at 1:50 AM Christian König wrote: > > Am 27.04.23 um 19:53 schrieb Rob Clark: > > From: Rob Clark > > > > Fix a couple missing ':'s. > > > > Signed-off-by: Rob Clark > > Reviewed-by: Rodrigo Vivi > > Reviewed-by: Christian König > > Since this is a pretty clear fix I

Re: [PATCH v2 05/19] fbdev/au1200fb: Use struct fb_info.screen_buffer

2023-04-28 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use info->screen_buffer when reading and writing framebuffers in > system memory. It's the correct pointer for this address space. > > The struct fb_info has a union to store the framebuffer memory. This can > either be info->screen_base if the framebuffer is stored

  1   2   3   >