[PATCH 07/12] accel/habanalabs: remove support for mmu disable

2023-05-16 Thread Oded Gabbay
From: Ofir Bitton As mmu disable mode is only used for bring-up stages, let's remove this option and all code related to it. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- .../accel/habanalabs/common/command_buffer.c | 6 - .../habanalabs/common/command

[PATCH 06/12] accel/habanalabs: upon DMA errors, use FW-extracted error cause

2023-05-16 Thread Oded Gabbay
From: Koby Elbaz Initially, the driver used to read the error cause data directly from the ASIC. However, the FW now clears it before the driver could read it. Therefore we should use the error cause data that is extracted by the FW. Signed-off-by: Koby Elbaz Reviewed-by: Oded Gabbay Signed-of

[PATCH 09/12] accel/habanalabs: use lower QM in QM errors handling

2023-05-16 Thread Oded Gabbay
From: Tomer Tayar The QMAN GLBL_ERR_STS_4 register has indications for errors also in the lower CQ and the ARC CQ, and not just for errors in the lower CP. Modify the relevant define/struct and the related print to use "lower QM" instead of "lower CP". Signed-off-by: Tomer Tayar Reviewed-by: Od

[PATCH 05/12] accel/habanalabs: print max timeout value on CS stuck

2023-05-16 Thread Oded Gabbay
If a workload got stuck, we print an error to the kernel log about it. Add to that print the configured max timeout value, as that value is not fixed between ASICs and in addition it can be configured using a kernel module parameter. Signed-off-by: Oded Gabbay --- .../habanalabs/common/command_s

[PATCH 10/12] accel/habanalabs: print qman data on error only for lower qman

2023-05-16 Thread Oded Gabbay
From: Tomer Tayar By default, the upper QMANs are not used, and instead engines ARCs access the lower QMANs directly. Errors for upper QMANs are therefore not expected, and the debug print of the PQ entries is not needed. Modify the QMAN debug data print on errors to include only information for

[PATCH 03/12] accel/habanalabs: fix mem leak in capture user mappings

2023-05-16 Thread Oded Gabbay
From: Moti Haimovski This commit fixes a memory leak caused when clearing the user_mappings info when a new context is opened immediately after user_mapping is captured and a hard reset is performed. Signed-off-by: Moti Haimovski Reviewed-by: Dani Liberman Reviewed-by: Oded Gabbay Signed-off-

[PATCH 04/12] accel/habanalabs: align to latest firmware specs

2023-05-16 Thread Oded Gabbay
Update the firmware common interface files with the latest version. Signed-off-by: Oded Gabbay --- .../habanalabs/include/common/cpucp_if.h | 18 .../habanalabs/include/common/hl_boot_if.h| 41 --- 2 files changed, 16 insertions(+), 43 deletions(-) diff --git a

[PATCH 02/12] accel/habanalabs: set unused bit as reserved

2023-05-16 Thread Oded Gabbay
Get latest f/w gaudi2 interface file which marks unused bist_need_iatu_config bit in cold_rst_data structure as reserved bit. Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/include/gaudi2/gaudi2_fw_if.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/ha

[PATCH 01/12] accel/habanalabs: rename security functions related arguments

2023-05-16 Thread Oded Gabbay
From: Koby Elbaz Make the argument names specify the registers array represent registers that should be unsecured so the user can access them. Signed-off-by: Koby Elbaz Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/security.c | 57 +++

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-16 Thread Julien Stephan
On Mon, May 15, 2023 at 04:32:42PM +0200, AngeloGioacchino Del Regno wrote: > Il 15/05/23 16:07, Julien Stephan ha scritto: > > On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: > > > > +#define CSIxB_OFFSET 0x1000 > > > > > > What if we grab two (or three?) iosp

RE: [PATCH v2] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-05-16 Thread Lin, Wayne
[Public] Hi, Ping again for code review. Much appreciated! Regards, Wayne > -Original Message- > From: Lin, Wayne > Sent: Monday, May 8, 2023 5:49 PM > To: ly...@redhat.com; jani.nik...@intel.com; dri- > de...@lists.freedesktop.org; amd-...@lists.freedesktop.org > Cc: ville.syrj...@linu

[PATCH] drm/i915/pmu: Change bitmask of enabled events to u32

2023-05-16 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having it as u64 was a confusing (but harmless) mistake. Also add some asserts to make sure the internal field does not overflow in the future. Signed-off-by: Tvrtko Ursulin Cc: Ashutosh Dixit Cc: Umesh Nerlige Ramappa --- I am not entirely sure the __builtin_constant_p-

Re: [PATCH] drm: bridge: dw-mipi-dsi: Drop panel_bridge post_disable call

2023-05-16 Thread Jagan Teki
On Tue, May 16, 2023 at 2:04 PM Marek Vasut wrote: > > On 5/16/23 10:25, Jagan Teki wrote: > > On Tue, May 16, 2023 at 1:47 PM Marek Vasut wrote: > >> > >> On 5/16/23 10:12, Jagan Teki wrote: > >>> Hi Marek and Neil, > >>> > >>> On Sun, May 14, 2023 at 1:40 AM Marek Vasut wrote: > > Th

Re: [PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids

2023-05-16 Thread Neil Armstrong
On 16/05/2023 10:44, Arnd Bergmann wrote: On Mon, May 15, 2023, at 18:22, neil.armstr...@linaro.org wrote: On 15/05/2023 18:15, Krzysztof Kozlowski wrote: On 15/05/2023 18:13, Krzysztof Kozlowski wrote: Also one more argument maybe not relevant here but for other cases - this makes literally i

Re: [PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids

2023-05-16 Thread Arnd Bergmann
On Mon, May 15, 2023, at 18:22, neil.armstr...@linaro.org wrote: > On 15/05/2023 18:15, Krzysztof Kozlowski wrote: >> On 15/05/2023 18:13, Krzysztof Kozlowski wrote: >> >> Also one more argument maybe not relevant here but for other cases - >> this makes literally impossible to include the clock I

[PATCH v2 1/2] arm64: dts: tegra: smaug: add GPU power rail regulator

2023-05-16 Thread Diogo Ivo
Add the GPU power rail regulator node for the Pixel C. Signed-off-by: Diogo Ivo --- V1 -> V2: Use generic DT node name and GPIO flag defines (Krzysztof Kozlowski) arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/

[PATCH v2 2/2] arm64: dts: tegra: smaug: add GPU node

2023-05-16 Thread Diogo Ivo
Enable the GPU on the Pixel C. Signed-off-by: Diogo Ivo --- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts index 929372f24339..db25f3ae8e0b 10064

[PATCH v2 0/2] Enable GPU on Smaug

2023-05-16 Thread Diogo Ivo
Hello, This patch series enables the use of the GM20B GPU in the Google Pixel C. Patch 1 adds the needed regulator DT node for the GPU. Patch 2 enables the GPU in the DT. The first version of these patches can be found at: https://lore.kernel.org/linux-tegra/20230511083101.78516-1-diogo@tec

Re: [PATCH] drm: bridge: dw-mipi-dsi: Drop panel_bridge post_disable call

2023-05-16 Thread Marek Vasut
On 5/16/23 10:25, Jagan Teki wrote: On Tue, May 16, 2023 at 1:47 PM Marek Vasut wrote: On 5/16/23 10:12, Jagan Teki wrote: Hi Marek and Neil, On Sun, May 14, 2023 at 1:40 AM Marek Vasut wrote: This panel_bridge post_disable callback is called from the bridge chain now, so drop the explici

Re: [PATCH] dt-bindings: display: bridge: tc358867: Document TC358867/TC9595 compatible

2023-05-16 Thread Neil Armstrong
Hi, On Mon, 15 May 2023 18:20:33 +0200, Marek Vasut wrote: > The TC358867/TC9595 devices are compatible with the predecessor TC358767. > Document compatible strings for the new devices, so they can be discerned > in board DTs. Update the title to match description in the process. > > Thanks, Ap

Re: [PATCH v1] drm/bridge: tc358768: remove unneeded semicolon

2023-05-16 Thread Neil Armstrong
Hi, On Mon, 15 May 2023 20:44:08 +0200, Francesco Dolcini wrote: > Remove unneeded stray semicolon. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/bridge: tc358768: remove unneeded semicolon https://cgit.freedesktop.org/drm/drm-mis

Re: [PATCH] gpu: drm: bridge: No need to set device_driver owner

2023-05-16 Thread Neil Armstrong
Hi, On Sat, 13 May 2023 15:42:17 +0530, Anup Sharma wrote: > There is no need to exclusively set the .owner member of the struct > device_driver when defining the platform_driver struct. The Linux core > takes care of setting the .owner member as part of the call to > module_platform_driver() help

Re: [PATCH v4 0/2] Reduce lcm_reset to DSI LP11 send cmd time

2023-05-16 Thread Neil Armstrong
Hi, On Mon, 15 May 2023 17:49:53 +0800, Shuijing Li wrote: > The panel spec stipulates that after lcm_reset is pulled high, cmd > should be sent to initialize the panel. Within the allowable range of > the DSI spec, this time needs to be reduced to avoid panel exceptions. > > Base on the branch o

Re: [PATCH] drm: bridge: dw-mipi-dsi: Drop panel_bridge post_disable call

2023-05-16 Thread Jagan Teki
On Tue, May 16, 2023 at 1:47 PM Marek Vasut wrote: > > On 5/16/23 10:12, Jagan Teki wrote: > > Hi Marek and Neil, > > > > On Sun, May 14, 2023 at 1:40 AM Marek Vasut wrote: > >> > >> This panel_bridge post_disable callback is called from the bridge chain > >> now, > >> so drop the explicit call

Re: [PATCH] drm: bridge: dw-mipi-dsi: Drop panel_bridge post_disable call

2023-05-16 Thread Marek Vasut
On 5/16/23 10:12, Jagan Teki wrote: Hi Marek and Neil, On Sun, May 14, 2023 at 1:40 AM Marek Vasut wrote: This panel_bridge post_disable callback is called from the bridge chain now, so drop the explicit call here. This fixes call imbalance, where this driver does not call ->pre_enable, but d

Re: [PATCH] drm: bridge: dw-mipi-dsi: Drop panel_bridge post_disable call

2023-05-16 Thread Jagan Teki
Hi Marek and Neil, On Sun, May 14, 2023 at 1:40 AM Marek Vasut wrote: > > This panel_bridge post_disable callback is called from the bridge chain now, > so drop the explicit call here. This fixes call imbalance, where this driver > does not call ->pre_enable, but does call ->post_disable . In cas

Re: [PATCH] dt-bindings: display: bridge: tc358867: Document TC358867/TC9595 compatible

2023-05-16 Thread Krzysztof Kozlowski
On 15/05/2023 18:20, Marek Vasut wrote: > The TC358867/TC9595 devices are compatible with the predecessor TC358767. > Document compatible strings for the new devices, so they can be discerned > in board DTs. Update the title to match description in the process. > > Signed-off-by: Marek Vasut > --

Re: [PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-05-16 Thread Jani Nikula
On Thu, 09 Mar 2023, Jani Nikula wrote: > On Thu, 09 Mar 2023, Christian König wrote: >> Am 09.03.23 um 13:37 schrieb Jani Nikula: >>> Make the struct ttm_device_funcs pointers const so the data can be placed >>> in rodata. >>> >>> Cc: Christian Koenig >>> Cc: Huang Rui >>> Signed-off-by: Jani

Re: [PATCH v2 RESEND 7/7] swiotlb: per-device flag if there are dynamically allocated buffers

2023-05-16 Thread Petr Tesařík
On Mon, 15 May 2023 17:28:38 +0100 Catalin Marinas wrote: > (some of you replies may have been filtered to various of my mailboxes, > depending on which lists you cc'ed; replying here) > > On Mon, May 15, 2023 at 12:00:54PM +0200, Petr Tesařík wrote: > > On Mon, 15 May 2023 10:48:47 +0200 > > Pe

Re: [PATCH v3 1/5] i2c: Enhance i2c_new_ancillary_device API

2023-05-16 Thread Geert Uytterhoeven
Hi Biju, On Sat, May 13, 2023 at 6:52 PM Biju Das wrote: > Renesas PMIC RAA215300 exposes two separate i2c devices, one for the main > device and another for rtc device. > > Enhance i2c_new_ancillary_device() to instantiate a real device. > (eg: Instantiate rtc device from PMIC driver) > > Signed

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi83: Fix enable/disable flow to meet spec

2023-05-16 Thread Neil Armstrong
On 03/05/2023 18:33, Frieder Schrempf wrote: From: Frieder Schrempf The datasheet describes the following initialization flow including minimum delay times between each step: 1. DSI data lanes need to be in LP-11 and the clock lane in HS mode 2. toggle EN signal 3. initialize registers 4. enab

Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-05-16 Thread Neil Armstrong
On 03/05/2023 18:33, Frieder Schrempf wrote: From: Frieder Schrempf According to the documentation [1] the proper enable flow is: 1. Enable DSI link and keep data lanes in LP-11 (stop state) 2. Disable stop state to bring data lanes into HS mode Currently we do this all at once within enable(

Re: [PATCH] gpu: drm: bridge: No need to set device_driver owner

2023-05-16 Thread Neil Armstrong
On 13/05/2023 12:12, Anup Sharma wrote: There is no need to exclusively set the .owner member of the struct device_driver when defining the platform_driver struct. The Linux core takes care of setting the .owner member as part of the call to module_platform_driver() helper function. Issue identi

Re: [PATCH] drm: bridge: dw-mipi-dsi: Drop panel_bridge post_disable call

2023-05-16 Thread Neil Armstrong
On 13/05/2023 22:10, Marek Vasut wrote: This panel_bridge post_disable callback is called from the bridge chain now, so drop the explicit call here. This fixes call imbalance, where this driver does not call ->pre_enable, but does call ->post_disable . In case either of the two callbacks implemen

Re: [PATCH v4 5/9] drivers: use new capable_any functionality

2023-05-16 Thread Alexander Gordeev
On Thu, May 11, 2023 at 04:25:28PM +0200, Christian Göttsche wrote: > Use the new added capable_any function in appropriate cases, where a > task is required to have any of two capabilities. > > Reorder CAP_SYS_ADMIN last. > > Signed-off-by: Christian Göttsche > --- > v4: >Additional usage i

Re: [PATCH v2 RESEND 7/7] swiotlb: per-device flag if there are dynamically allocated buffers

2023-05-16 Thread Petr Tesařík
(restoring the Cc list that I accidentally removed in my previous reply.) On Mon, 15 May 2023 10:39:11 +0100 Catalin Marinas wrote: > Hi Petr, > > On Mon, May 15, 2023 at 10:47:37AM +0200, Petr Tesařík wrote: > > On Sun, 14 May 2023 19:54:27 +0100 > > Catalin Marinas wrote: > > > On Tue, May

Re: [PATCH v2 RESEND 7/7] swiotlb: per-device flag if there are dynamically allocated buffers

2023-05-16 Thread Catalin Marinas
(some of you replies may have been filtered to various of my mailboxes, depending on which lists you cc'ed; replying here) On Mon, May 15, 2023 at 12:00:54PM +0200, Petr Tesařík wrote: > On Mon, 15 May 2023 10:48:47 +0200 > Petr Tesařík wrote: > > On Sun, 14 May 2023 19:54:27 +0100 > > Catalin Ma

Re: [PATCH] mm: fix hugetlb page unmap count balance issue

2023-05-16 Thread Mike Kravetz
On 05/12/23 16:29, Mike Kravetz wrote: > On 05/12/23 14:26, James Houghton wrote: > > On Fri, May 12, 2023 at 12:20 AM Junxiao Chang > > wrote: > > > > This alone doesn't fix mapcounting for PTE-mapped HugeTLB pages. You > > need something like [1]. I can resend it if that's what we should be >

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-05-16 Thread Inki Dae
Hi, 2023년 5월 8일 (월) 오전 1:32, Uwe Kleine-König 님이 작성: > > Hello, > > this patch series adapts the platform drivers below drivers/gpu/drm > to use the .remove_new() callback. Compared to the traditional .remove() > callback .remove_new() returns no value. This is a good thing because First of all,

Re: [RESEND PATCH v3] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-05-16 Thread Arseniy Krasnov
Hello @Miquel! Sorry, but who could review this patch? :) IIUC this logic is very hw specific and we need someone who knows it well? I tested this patch on our devices (with already known Meson NAND controller). Thanks, Arseniy On 11.05.2023 21:21, Arseniy Krasnov wrote: > Cc: Mason Yang and

[PATCH v4 0/2] Reduce lcm_reset to DSI LP11 send cmd time

2023-05-16 Thread Shuijing Li
The panel spec stipulates that after lcm_reset is pulled high, cmd should be sent to initialize the panel. Within the allowable range of the DSI spec, this time needs to be reduced to avoid panel exceptions. Base on the branch of linus/master v6.3. Change since v3: 1. Rebase. Change since v2: 1.

[PATCH v4 1/2] drm/panel: boe-tv101wum-nl6: Remove extra delay

2023-05-16 Thread Shuijing Li
Reduce the delay after LCM reset by removing an extra delay in the initialization commands array. The required delay of at least 6ms after reset is guaranteed by boe_panel_prepare(). Signed-off-by: Shuijing Li Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/d

[PATCH v4 2/2] drm/panel: boe-tv101wum-nl6: Fine tune the panel power sequence

2023-05-16 Thread Shuijing Li
For "boe,tv105wum-nw0" this special panel, it is stipulated in the panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. Signed-off-by: Shuijing Li Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panel/panel-boe-tv101w

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-05-16 Thread Uwe Kleine-König
On Mon, May 15, 2023 at 04:50:57PM +0900, Inki Dae wrote: > Hi, > > 2023년 5월 8일 (월) 오전 1:32, Uwe Kleine-König 님이 > 작성: > > > > Hello, > > > > this patch series adapts the platform drivers below drivers/gpu/drm > > to use the .remove_new() callback. Compared to the traditional .remove() > > callba

Re: [PATCH v1] drm/bridge: tc358768: remove unneeded semicolon

2023-05-16 Thread Neil Armstrong
On 15/05/2023 20:44, Francesco Dolcini wrote: From: Francesco Dolcini Remove unneeded stray semicolon. Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202305152341.oisjrpv6-...@intel.com/ Signed-off-by: Francesco Dolcini --- drivers/gpu/drm/bridge/tc358768.c | 2

Re: [PATCH 1/1] drm/bridge: tc358767: explicitly set readable registers

2023-05-16 Thread Neil Armstrong
On 16/05/2023 09:19, Alexander Stein wrote: This map was created from register map from datasheet (section 5.1.2). Unused registers are stated by address, so they show up in debugfs as well. Signed-off-by: Alexander Stein --- When dumping the registers in debugfs there are a lot of unused and/o

Re: [PATCH v6 2/8] drm/bridge: tfp410: Set input_bus_flags in atomic_check

2023-05-16 Thread Neil Armstrong
On 09/05/2023 11:30, Aradhya Bhatia wrote: From: Nikhil Devshatwar input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from a

Re: [PATCH v6 6/8] drm/bridge: sii902x: Set input_bus_flags in atomic_check

2023-05-16 Thread Neil Armstrong
On 09/05/2023 11:30, Aradhya Bhatia wrote: input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from atomic_check. Implement at

Re: [PATCH v6 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

2023-05-16 Thread Neil Armstrong
On 09/05/2023 11:30, Aradhya Bhatia wrote: From: Nikhil Devshatwar input_bus_flags are specified in drm_bridge_timings (legacy) as well as drm_bridge_state->input_bus_cfg.flags The flags from the timings will be deprecated. Bridges are supposed to validate and set the bridge state flags from a

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-05-16 Thread Neil Armstrong
On 15/05/2023 17:59, Aradhya Bhatia wrote: Hi Tomi, On 12-May-23 14:45, Tomi Valkeinen wrote: On 09/05/2023 12:30, Aradhya Bhatia wrote: From: Nikhil Devshatwar With new connector model, mhdp bridge will not create the connector and SoC driver will rely on format negotiation to setup the enc

[PATCH 1/1] drm/bridge: tc358767: explicitly set readable registers

2023-05-16 Thread Alexander Stein
This map was created from register map from datasheet (section 5.1.2). Unused registers are stated by address, so they show up in debugfs as well. Signed-off-by: Alexander Stein --- When dumping the registers in debugfs there are a lot of unused and/or undocumented addresses. Instead explicitly s

Re: [PATCH v6 5/8] drm/bridge: sii902x: Support format negotiation hooks

2023-05-16 Thread Neil Armstrong
On 09/05/2023 11:30, Aradhya Bhatia wrote: With new connector model, sii902x will not create the connector, when DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and SoC driver will rely on format negotiation to setup the encoder format. Support format negotiations hooks in the drm_bridge_funcs. Use helper

<    1   2