[syzbot] [fbdev?] general protection fault in soft_cursor

2023-05-26 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:eb0f1697d729 Merge branch 'for-next/core', remote-tracking.. git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci console output: https://syzkaller.appspot.com/x/log.txt?x=10e08bde28 kernel

Re: [PATCH 3/6] drm/i915/uc/gsc: extract release and security versions from the gsc binary

2023-05-26 Thread Ceraolo Spurio, Daniele
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h b/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h index d55a66202576..8bce2b8aed84 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h alan:snip +struct

Re: (subset) [PATCH 0/4] ARM: dts: qcom: apq8074-dragonboard enable DSI and remoteproc

2023-05-26 Thread Bjorn Andersson
On Sun, 7 May 2023 22:07:31 +0300, Dmitry Baryshkov wrote: > Enable GPU, DSI panel and remoteprocs on the APQ8074 dragonboard device. > > Dmitry Baryshkov (4): > ARM: dts: qcom: msm8974: add ocmem clock to GPU > ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled > ARM: dts:

[PATCH v3 7/7] drm/i915/huc: define HuC FW version for MTL

2023-05-26 Thread Daniele Ceraolo Spurio
Follow the same logic as DG2, so just a meu binary with no version number. Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Previn Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c

[PATCH v3 6/7] drm/i915/mtl/huc: Use the media gt for the HuC getparam

2023-05-26 Thread Daniele Ceraolo Spurio
On MTL, for obvious reasons, HuC is only available on the media tile. We already disable SW support for HuC on the root gt due to the absence of VCS engines, but we also need to update the getparam to point to the HuC struct in the media GT. Signed-off-by: Daniele Ceraolo Spurio Cc: John

[PATCH v3 4/7] drm/i915/huc: differentiate the 2 steps of the MTL HuC auth flow

2023-05-26 Thread Daniele Ceraolo Spurio
Before we add the second step of the MTL HuC auth (via GSC), we need to have the ability to differentiate between them. To do so, the huc authentication check is duplicated for GuC and GSC auth, with meu binaries being considered fully authenticated only after the GSC auth step. To report the

[PATCH v3 3/7] drm/i915/huc: Load GSC-enabled HuC via DMA xfer if the fuse says so

2023-05-26 Thread Daniele Ceraolo Spurio
In the previous patch we extracted the offset of the legacy-style HuC binary located within the GSC-enabled blob, so now we can use that to load the HuC via DMA if the fuse is set that way. Note that we now need to differentiate between "GSC-enabled binary" and "loaded by GSC", so the former case

[PATCH v3 5/7] drm/i915/mtl/huc: auth HuC via GSC

2023-05-26 Thread Daniele Ceraolo Spurio
The full authentication via the GSC requires an heci packet submission to the GSC FW via the GSC CS. The GSC has new PXP command for this (literally called NEW_HUC_AUTH). The intel_huc_auth fuction is also updated to handle both authentication types. v2: check that the GuC auth for clear media

[PATCH v3 1/7] drm/i915/uc: perma-pin firmwares

2023-05-26 Thread Daniele Ceraolo Spurio
Now that each FW has its own reserved area, we can keep them always pinned and skip the pin/unpin dance on reset. This will make things easier for the 2-step HuC authentication, which requires the FW to be pinned in GGTT after the xfer is completed. Since the vma is now valid for a long time and

[PATCH v3 0/7] drm/i915: HuC loading and authentication for MTL

2023-05-26 Thread Daniele Ceraolo Spurio
The HuC loading and authentication flow is once again changing and a new "clear-media only" authentication step is introduced. The flow is as follows: 1) The HuC is loaded via DMA - same as all non-GSC HuC binaries. 2) The HuC is authenticated by the GuC - this is the same step as performed for

[PATCH v3 2/7] drm/i915/huc: Parse the GSC-enabled HuC binary

2023-05-26 Thread Daniele Ceraolo Spurio
The new binaries that support the 2-step authentication contain the legacy-style binary, which we can use for loading the HuC via DMA. To find out where this is located in the image, we need to parse the manifest of the GSC-enabled HuC binary. The manifest consist of a partition header followed by

Re: Fwd: Does not work backlight on Chromebook XE303C12 with Kernel version 6.3.4

2023-05-26 Thread Bagas Sanjaya
On Fri, May 26, 2023 at 08:46:32PM +0700, Bagas Sanjaya wrote: > Hi, > > I notice a regression report on Bugzilla [1]. Quoting from it: > > > I did check it by flashlight. Even with all available backlights drivers > > compiled as modules it does not work. With Kernel version 5.15.106 > >

[PATCH 0/3] Use FAST_REQUEST mechanism for non-blocking H2G calls

2023-05-26 Thread John . C . Harrison
From: John Harrison The GuC interface supports a mechanism for returning errors against non-blocking H2G calls. This is called FAST_REQUEST. Given that the call is asynchronous, matching the returned error up is difficult. However, getting any error at all back is better than no error. If any

[PATCH 3/3] drm/i915/guc: Track all sent actions to GuC

2023-05-26 Thread John . C . Harrison
From: Michal Wajdeczko For easier debug of any unexpected error responses from GuC that might be related to non-blocking fast requests, track action code (and stack if under DEBUG_GUC config) for every H2G request. Signed-off-by: Michal Wajdeczko Signed-off-by: John Harrison ---

[PATCH 2/3] drm/i915/guc: Update log for unsolicited CTB response

2023-05-26 Thread John . C . Harrison
From: Michal Wajdeczko Instead of printing message fence twice, include HXG header of the unexpected message and its len. Signed-off-by: Michal Wajdeczko Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH 1/3] drm/i915/guc: Use FAST_REQUEST for non-blocking H2G calls

2023-05-26 Thread John . C . Harrison
From: Michal Wajdeczko In addition to the already defined REQUEST HXG message format, which is used when sender expects some confirmation or data, HXG protocol includes definition of the FAST REQUEST message, that may be used when sender does not expect any useful data to be returned. Using

Re: [PATCH 6/6] drm/i915/uc/gsc: Add a gsc_info debugfs

2023-05-26 Thread Teres Alexis, Alan Previn
On Fri, 2023-05-05 at 09:04 -0700, Ceraolo Spurio, Daniele wrote: > Add a new debugfs to dump information about the GSC. This includes: alan:snip Actually everything looks good except for a couple of questions + asks - hope we can close on this patch in next rev. > > - the FW path and SW

Re: [PATCH net-next v5 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-05-26 Thread Justin Chen
On 5/25/23 8:54 PM, Jakub Kicinski wrote: On Wed, 24 May 2023 16:01:50 -0700 Justin Chen wrote: Add support for the Broadcom ASP 2.0 Ethernet controller which is first introduced with 72165. This controller features two distinct Ethernet ports that can be independently operated. This patch

Re: [git pull] drm fixes for 6.4-rc4

2023-05-26 Thread pr-tracker-bot
The pull request you sent on Fri, 26 May 2023 16:04:02 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-05-26 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b83ac44e02986e640ee954e187ba414cb94453e2 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] arm64: dts: mediatek: mt8173-elm: remove panel model number in DT

2023-05-26 Thread Doug Anderson
Hi, On Fri, May 26, 2023 at 8:33 AM Icenowy Zheng wrote: > > 在 2023-05-26星期五的 07:24 -0700,Doug Anderson写道: > > Hi, > > > > On Fri, May 26, 2023 at 3:09 AM Icenowy Zheng wrote: > > > > > > Currently a specific panel number is used in the Elm DTSI, which is > > > corresponded to a 12" panel.

Re: [PATCH V8 7/7] dt-bindings: bridge: samsung-dsim: Make some flags optional

2023-05-26 Thread Conor Dooley
On Fri, May 26, 2023 at 02:24:21PM -0500, Adam Ford wrote: > On Fri, May 26, 2023 at 1:19 PM Conor Dooley wrote: > > On Thu, May 25, 2023 at 10:05:59PM -0500, Adam Ford wrote: > > > description: > > > - DSIM high speed burst mode frequency. > > > + DSIM high speed burst mode

Re: [PATCH 0/9] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together

2023-05-26 Thread Konrad Dybcio
On 23.05.2023 21:27, Douglas Anderson wrote: > > The big motivation for this patch series is mostly described in the patch > ("drm/panel: Add a way for other devices to follow panel state"), but to > quickly summarize here: for touchscreens that are connected to a panel we > need the ability

Re: [PATCH V8 7/7] dt-bindings: bridge: samsung-dsim: Make some flags optional

2023-05-26 Thread Adam Ford
On Fri, May 26, 2023 at 1:19 PM Conor Dooley wrote: > > Adam, Neil, > > I meant to get to this earlier today, but broken CI got in the way... > > On Thu, May 25, 2023 at 10:05:59PM -0500, Adam Ford wrote: > > In the event a device is connected to the samsung-dsim > > controller that doesn't

Re: [PATCH V8 7/7] dt-bindings: bridge: samsung-dsim: Make some flags optional

2023-05-26 Thread Conor Dooley
Adam, Neil, I meant to get to this earlier today, but broken CI got in the way... On Thu, May 25, 2023 at 10:05:59PM -0500, Adam Ford wrote: > In the event a device is connected to the samsung-dsim > controller that doesn't support the burst-clock, the > driver is able to get the requested pixel

Re: [Freedreno] [PATCH v2 3/6] drm/msm/dpu: split interrupt address arrays

2023-05-26 Thread Abhinav Kumar
On 5/26/2023 1:43 AM, Dmitry Baryshkov wrote: On Fri, 26 May 2023 at 01:42, Abhinav Kumar wrote: On 5/25/2023 3:30 PM, Dmitry Baryshkov wrote: On Fri, 26 May 2023 at 00:40, Jeykumar Sankaran wrote: On 5/22/2023 2:45 PM, Dmitry Baryshkov wrote: There is no point in having a single enum

Re: [PATCH v6 5/6] drm: lcdif: Add multiple encoders and first bridges support

2023-05-26 Thread Marek Vasut
On 5/25/23 03:45, Ying Liu wrote: Hi Marek, Hi, On Thu, May 11, 2023 at 12:24 AM Marek Vasut wrote: On 5/10/23 11:24, Liu Ying wrote: The single LCDIF embedded in i.MX93 SoC may drive multiple displays simultaneously. Look at LCDIF output port's remote port parents to find all enabled

Re: [PATCH v3 2/3] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields

2023-05-26 Thread Marek Vasut
On 5/17/23 16:35, Raphael Gallais-Pou wrote: "#address-cells" and "#size-cells" are two properties that are not mandatory. For instance, the DSI could refer to a bridge outside the scope of the node rather than include a 'panel@0' subnode. By doing so, address and size fields become then

Re: [PATCH v3 1/3] ARM: dts: stm32: fix warnings on stm32f469-disco board

2023-05-26 Thread Marek Vasut
On 5/17/23 16:35, Raphael Gallais-Pou wrote: Several warnings appear when building and checking stm32f429 device-tree: arch/arm/boot/dts/stm32f469-disco.dts:182.28-184.5: Warning (unit_address_vs_reg): /soc/display-controller@40016800/port/endpoint@0: node has a unit name, but no reg or

Re: [PATCH v3 3/3] ARM: dts: stm32: fix several DT warnings on stm32mp15

2023-05-26 Thread Marek Vasut
On 5/25/23 10:14, Raphael Gallais-Pou wrote: Hi, I think if you retain the stm32mp151.dtsi { port { #address-cells = <1>; #size-cells = <0>; }; }; part, then you wouldn't be getting any warnings regarding LTDC , and you wouldn't have to remove the unit-address from endpoint@0 . btw. I do use

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Sebastian Wick
With the documentation about RGB and YCC variants added the drm core patches are Reviewed-by: Sebastian Wick On Fri, May 26, 2023 at 6:24 PM Sebastian Wick wrote: > > On Fri, May 26, 2023 at 3:16 PM Pekka Paalanen wrote: > > > > On Thu, 25 May 2023 15:17:56 -0400 > > Harry Wentland wrote: >

Re: [PATCH] drm/i915: Fix clang -Wimplicit-fallthrough in intel_async_flip_check_hw()

2023-05-26 Thread Nick Desaulniers
On Thu, May 25, 2023 at 1:30 PM Matthieu Baerts wrote: > > Hi Nick, > > On 24/05/2023 20:56, Nick Desaulniers wrote: > > On Wed, May 24, 2023 at 11:41 AM Nathan Chancellor > > wrote: > >> > >> On Wed, May 24, 2023 at 11:32:32AM -0700, Nick Desaulniers wrote: > >>> On Wed, May 24, 2023 at 8:38 

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 6:37 PM Simon Ser wrote: > > On Friday, May 26th, 2023 at 18:27, Sebastian Wick > wrote: > > > > + * @DRM_MODE_COLORIMETRY_DEFAULT: > > > + * Driver specific behavior. > > > + * @DRM_MODE_COLORIMETRY_NO_DATA: > > > + * Driver specific behavior. > > > > TBH this is still

Re: [PATCH v4 08/13] drm/amd/display: Register Colorspace property for DP and HDMI

2023-05-26 Thread Simon Ser
On Friday, May 26th, 2023 at 18:40, Sebastian Wick wrote: > On Thu, May 25, 2023 at 9:18 PM Harry Wentland harry.wentl...@amd.com wrote: > > > We want compositors to be able to set the output > > colorspace on DP and HDMI outputs, based on the > > caps reported from the receiver via EDID. > >

Re: [PATCH v4 08/13] drm/amd/display: Register Colorspace property for DP and HDMI

2023-05-26 Thread Sebastian Wick
On Thu, May 25, 2023 at 9:18 PM Harry Wentland wrote: > > We want compositors to be able to set the output > colorspace on DP and HDMI outputs, based on the > caps reported from the receiver via EDID. This commit message seems wrong for multiple reasons. The Colorspace property documentation

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Simon Ser
On Friday, May 26th, 2023 at 18:27, Sebastian Wick wrote: > > + * @DRM_MODE_COLORIMETRY_DEFAULT: > > + * Driver specific behavior. > > + * @DRM_MODE_COLORIMETRY_NO_DATA: > > + * Driver specific behavior. > > TBH this is still confusing me. Is DEFAULT really just driver specific > behavior?

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
On Thu, May 25, 2023 at 9:18 PM Harry Wentland wrote: > > From: Joshua Ashton > > To match the other enums, and add more information about these values. > > v2: > - Specify where an enum entry comes from > - Clarify DEFAULT and NO_DATA behavior > - BT.2020 CYCC is "constant luminance" > -

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 3:16 PM Pekka Paalanen wrote: > > On Thu, 25 May 2023 15:17:56 -0400 > Harry Wentland wrote: > > > This patchset is based on Joshua's previous patchset [1], as well > > as my previous patchset [2]. > > > > It is > > - enabling support for the colorspace property in

[RFC 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-05-26 Thread Aravind Iddamsetty
Whenever a correctable or an uncorrectable error happens an event is sent to the corresponding listeners of these groups. Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_irq.c | 32 drivers/gpu/drm/xe/xe_netlink.c | 2 ++ 2 files changed, 34

[RFC 4/5] drm/netlink: define multicast groups

2023-05-26 Thread Aravind Iddamsetty
Netlink subsystem supports event notifications to userspace. we define two multicast groups for correctable and uncorrectable errors to which userspace can subscribe and be notified when any of those errors happen. The group names are local to the driver's genl netlink family. Signed-off-by:

[RFC 3/5] drm/xe/RAS: Expose the error counters

2023-05-26 Thread Aravind Iddamsetty
We expose the various error counters supported on a hardware via genl subsystem through the registered commands to userspace. The DRM_CMD_QUERY lists the error names with config id, DRM_CMD_READ_ONE returns the counter value for the requested config id and the DRM_CMD_READ_ALL list the counters

[RFC 1/5] drm/netlink: Add netlink infrastructure

2023-05-26 Thread Aravind Iddamsetty
Define the netlink commands and attributes that can be commonly used across by drm drivers. Signed-off-by: Aravind Iddamsetty --- include/uapi/drm/drm_netlink.h | 68 ++ 1 file changed, 68 insertions(+) create mode 100644 include/uapi/drm/drm_netlink.h diff

[RFC 2/5] drm/xe/RAS: Register a genl netlink family

2023-05-26 Thread Aravind Iddamsetty
Use the generic netlink(genl) subsystem to expose the RAS counters to userspace. We define a family structure and operations and register to genl subsystem and these callbacks will be invoked by genl subsystem when userspace sends a registered command with a family identifier to genl subsystem.

[RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-05-26 Thread Aravind Iddamsetty
Our hardware supports RAS(Reliability, Availability, Serviceability) by exposing a set of error counters which can be used by observability tools to take corrective actions or repairs. Traditionally there were being exposed via PMU (for relative counters) and sysfs interface (for absolute value)

Re: [PATCH 0/7] Add a DRM driver to support AI Processing Unit (APU)

2023-05-26 Thread Alexandre Bailon
On 5/24/23 12:40, Daniel Vetter wrote: On Wed, May 24, 2023 at 01:27:00PM +0300, Oded Gabbay wrote: On Wed, May 24, 2023 at 2:34 AM Kevin Hilman wrote: Jeffrey Hugo writes: On 5/17/2023 8:52 AM, Alexandre Bailon wrote: This adds a DRM driver that implements communication between the

Re: [PATCH 5/7] drm/apu: allow platform driver to implement their own mmap function

2023-05-26 Thread Alexandre Bailon
On 5/17/23 21:45, Krzysztof Kozlowski wrote: On 17/05/2023 16:52, Alexandre Bailon wrote: From: Julien Stephan By default we will call drm_gem_mmap() unless the apu driver has declared it's own mmap handler. Signed-off-by: Julien Stephan Reviewed-by: Julien Stephan One does not have

Re: [PATCH v2] drm: Switch i2c drivers back to use .probe()

2023-05-26 Thread Doug Anderson
Hi, On Fri, May 26, 2023 at 2:08 AM Uwe Kleine-König wrote: > > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert > back to (the

[Bug 198907] Backlight control missing with /sys/class/backlight/ empty

2023-05-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198907 Jani Nikula (jani.nik...@intel.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH] arm64: dts: mediatek: mt8173-elm: remove panel model number in DT

2023-05-26 Thread Doug Anderson
Hi, On Fri, May 26, 2023 at 3:09 AM Icenowy Zheng wrote: > > Currently a specific panel number is used in the Elm DTSI, which is > corresponded to a 12" panel. However, according to the official Chrome > OS devices document, Elm refers to Acer Chromebook R13, which, as the > name specifies, uses

Re: [PATCH V8 0/7] drm: bridge: samsung-dsim: Support variable clocking

2023-05-26 Thread Adam Ford
On Fri, May 26, 2023 at 2:24 AM Neil Armstrong wrote: > > On 26/05/2023 09:22, Neil Armstrong wrote: > > Hi, > > > > On Thu, 25 May 2023 22:05:52 -0500, Adam Ford wrote: > >> This series fixes the blanking pack size and the PMS calculation. It then > >> adds support to allows the DSIM to

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: No 10bit gamma on desktop gen3 parts

2023-05-26 Thread Ville Syrjälä
On Thu, May 25, 2023 at 09:25:46PM +, Shankar, Uma wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of > > Ville Syrjala > > Sent: Thursday, April 13, 2023 10:19 PM > > To: intel-...@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org > > Subject:

Re: [PATCH v2 3/7] drm/i915: Fix CHV CGM CSC coefficient sign handling

2023-05-26 Thread Ville Syrjälä
On Thu, May 25, 2023 at 08:55:08PM +, Shankar, Uma wrote: > > > > -Original Message- > > From: dri-devel On Behalf Of > > Ville Syrjala > > Sent: Thursday, April 13, 2023 10:19 PM > > To: intel-...@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org > > Subject: [PATCH v2

Fwd: Does not work backlight on Chromebook XE303C12 with Kernel version 6.3.4

2023-05-26 Thread Bagas Sanjaya
Hi, I notice a regression report on Bugzilla [1]. Quoting from it: > I did check it by flashlight. Even with all available backlights drivers > compiled as modules it does not work. With Kernel version 5.15.106 backlight > works fine. > Kernels for Chomebook uses dtb files that have some

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Pekka Paalanen
On Thu, 25 May 2023 15:17:56 -0400 Harry Wentland wrote: > This patchset is based on Joshua's previous patchset [1], as well > as my previous patchset [2]. > > It is > - enabling support for the colorspace property in amdgpu, as well as > - allowing drivers to specify the supported set of

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Pekka Paalanen
On Thu, 25 May 2023 15:17:58 -0400 Harry Wentland wrote: > From: Joshua Ashton > > To match the other enums, and add more information about these values. > > v2: > - Specify where an enum entry comes from > - Clarify DEFAULT and NO_DATA behavior > - BT.2020 CYCC is "constant luminance" >

Re: [v4,12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-26 Thread Thomas Zimmermann
Hi Am 24.05.23 um 22:23 schrieb Sui Jingfeng: Tested-by: Sui Jingfeng This version works fine, I have tested it On LoongArch with drm/loongson(v14) as it is most handy for me. Also because it using fbdev-generic. fbdev of IGT report no error. Then I run fbtest from geert[1], Before

[PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails

2023-05-26 Thread Andi Shyti
kernel_context() returns an error pointer. Use pointer-error conversion functions to evaluate its return value, rather than checking for a '0' return. Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT") Reported-by: Dan Carpenter Signed-off-by: Andi Shyti Cc: Chris Wilson <

Re: [v4,02/13] fbdev: Add initializer macros for struct fb_ops

2023-05-26 Thread Thomas Zimmermann
Hi Am 24.05.23 um 22:57 schrieb Sui Jingfeng: Hi, we love your patch: On 2023/5/24 17:21, Thomas Zimmermann wrote: For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback

Re: [PATCH v2] drm: Switch i2c drivers back to use .probe()

2023-05-26 Thread Guenter Roeck
On Fri, May 26, 2023 at 2:08 AM Uwe Kleine-König wrote: > > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert > back to (the new)

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-26 Thread Linux regression tracking #update (Thorsten Leemhuis)
[TLDR: This mail in primarily relevant for Linux regression tracking. A change or fix related to the regression discussed in this thread was posted or applied, but it did not use a Link: tag to point to the report, as Linus and the documentation call for. Things happen, no worries -- but now the

Re: [PATCH 2/2] dt-bindings: backlight: document new property default-brightness-level

2023-05-26 Thread Philippe CORNU
On 5/19/23 22:05, Alexandru Ardelean wrote: From: Yannick Fertre Add documentation for new default-brightness-level property. Reviewed-by: Philippe CORNU Hi Alexandru, same comments as for the 1/2 patch. Many thanks Philippe :-) Signed-off-by: Yannick Fertre Signed-off-by: Alexandru

Re: [v10] media: mediatek: vcodec: support stateless AV1 decoder

2023-05-26 Thread Hans Verkuil
On 14/04/2023 10:30, Xiaoyong Lu wrote: > Add mediatek av1 decoder linux driver which use the stateless API in > MT8195. > > Signed-off-by: Xiaoyong Lu > Tested-by: Nicolas Dufresne > Reviewed-by: Nicolas Dufresne > Tested-by: AngeloGioacchino Del Regno > > Reviewed-by: AngeloGioacchino Del

Re: [PATCH 1/2] backlight: gpio_backlight: add new property default-brightness-level

2023-05-26 Thread Philippe CORNU
On 5/19/23 22:05, Alexandru Ardelean wrote: From: Yannick Fertre Add new property to set a brightness by default at probe. Reviewed-by: Philippe CORNU Hi Alexandru, Many thanks for your patch. You have sent a patch originally pushed on the STMicroelectronics github as mentioned in

[bug report] vga_switcheroo: set audio client id according to bound GPU id

2023-05-26 Thread Dan Carpenter
Hello Jim Qu, The patch 4aaf448fa975: "vga_switcheroo: set audio client id according to bound GPU id" from Jul 17, 2018, leads to the following Smatch static checker warning: drivers/gpu/vga/vga_switcheroo.c:378 vga_switcheroo_register_audio_client() warn: impossible condition

[PATCH v2] drm/msm/dpu: clean up dpu_kms_get_clk_rate() returns

2023-05-26 Thread Dan Carpenter
Static analysis tools complain about the -EINVAL error code being stored in an unsigned variable. Let's change this to match the clk_get_rate() function which is type unsigned long and returns zero on error. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Dan Carpenter

Re: [PATCH RESEND] drm/stm: ltdc: fix late dereference check

2023-05-26 Thread Philippe CORNU
On 5/15/23 14:38, Raphael Gallais-Pou wrote: In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a container_of() before the pointer check. This could cause a kernel panic. Fix this smatch warning: drivers/gpu/drm/stm/ltdc.c:1124 ltdc_crtc_set_crc_source() warn: variable

Re: [PATCH -next] drm/stm: dsi: Use devm_platform_ioremap_resource()

2023-05-26 Thread Philippe CORNU
On 4/21/23 10:34, Yang Li wrote: Convert platform_get_resource(),devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +--- 1 file changed, 1

Re: [RFC PATCH] dma-buf/dma-fence: Use a successful read_trylock() annotation for dma_fence_begin_signalling()

2023-05-26 Thread Thomas Hellström
Daniel, On 4/28/23 14:52, Thomas Hellström wrote: Condsider the following call sequence: /* Upper layer */ dma_fence_begin_signalling(); lock(tainted_shared_lock); /* Driver callback */ dma_fence_begin_signalling(); ... The driver might here use a utility that is annotated as intended for the

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915: No 10bit gamma on desktop gen3 parts

2023-05-26 Thread Jani Nikula
On Thu, 25 May 2023, "Shankar, Uma" wrote: >> -Original Message- >> From: Intel-gfx On Behalf Of Ville >> Syrjala >> Sent: Thursday, April 13, 2023 10:19 PM >> To: intel-...@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org >> Subject: [Intel-gfx] [PATCH v2 6/7] drm/i915: No

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-05-26 Thread Hans Verkuil
Hi Arnaud, My apologies for the long delay in replying, it's been very, very busy lately. I hope I'll be able to be more responsive going forward. On 21/04/2023 18:58, Arnaud Vrac wrote: > Le ven. 21 avr. 2023 à 15:27, Hans Verkuil a écrit > : >> >> Hi Arnaud, >> >> Some review comments

Re: [PATCH v2 4/4] arm64: dts: adapt to LP855X bindings changes

2023-05-26 Thread Daniel Thompson
On Fri, May 19, 2023 at 08:07:28PM +0200, Artur Weber wrote: > Change underscores in ROM node names to dashes, and remove deprecated > pwm-period property. > > Signed-off-by: Artur Weber Reviewed-by: Daniel Thompson

Re: [PATCH v2 2/4] video: backlight: lp855x: get PWM for PWM mode during probe

2023-05-26 Thread Daniel Thompson
On Fri, May 19, 2023 at 08:07:26PM +0200, Artur Weber wrote: > Also deprecate the pwm-period DT property, as it is now redundant > (pwms property already contains period value). > > Signed-off-by: Artur Weber Reviewed-by: Daniel Thompson

Re: [PATCH v2 1/4] dt-bindings: backlight: lp855x: convert to YAML and modernize

2023-05-26 Thread Daniel Thompson
On Fri, May 19, 2023 at 08:07:25PM +0200, Artur Weber wrote: > Notable changes: > - ROM child nodes use dashes instead of underscores; the driver > reads all child nodes regardless of their names, so this doesn't > break ABI. > - pwm-period argument is deprecated, as it effectively duplicates

Re: [PATCH 1/2] backlight: gpio_backlight: add new property default-brightness-level

2023-05-26 Thread Daniel Thompson
On Fri, May 19, 2023 at 11:05:19PM +0300, Alexandru Ardelean wrote: > From: Yannick Fertre > > Add new property to set a brightness by default at probe. > > Reviewed-by: Philippe CORNU > Signed-off-by: Yannick Fertre > Signed-off-by: Alexandru Ardelean Patch order should be reversed for v2.

Re: [PATCH 2/2] dt-bindings: backlight: document new property default-brightness-level

2023-05-26 Thread Daniel Thompson
On Fri, May 19, 2023 at 11:05:20PM +0300, Alexandru Ardelean wrote: > From: Yannick Fertre > > Add documentation for new default-brightness-level property. > > Reviewed-by: Philippe CORNU > Signed-off-by: Yannick Fertre > Signed-off-by: Alexandru Ardelean > --- > > Link to original patch: >

Re: [PATCH RESEND] drm/stm: ltdc: fix late dereference check

2023-05-26 Thread Philippe CORNU
On 5/15/23 14:38, Raphael Gallais-Pou wrote: In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a container_of() before the pointer check. This could cause a kernel panic. Fix this smatch warning: drivers/gpu/drm/stm/ltdc.c:1124 ltdc_crtc_set_crc_source() warn: variable

Re: [PATCH] drm/stm: Fix resolution bitmasks

2023-05-26 Thread Philippe CORNU
On 5/26/23 11:05, Marek Vasut wrote: On 5/15/23 18:02, Philippe CORNU wrote: Hi, The genmask of regsiter SSCR, BPCR & others were setted accordly to the chipset stm32f4. So that means: F4 -> 2048x2048 framebuffer H7/MP1 -> 4096x4096 framebuffer ? Worse F4 is 2048x2048 F7 is 4096x2048

Re: [PATCH v2] drm: Switch i2c drivers back to use .probe()

2023-05-26 Thread Javier Martinez Canillas
Kieran Bingham writes: Hello Uwe, > Quoting Uwe Kleine-König (2023-05-26 10:07:09) >> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() >> call-back type"), all drivers being converted to .probe_new() and then >> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")

Re: [PATCH v2] drm: Switch i2c drivers back to use .probe()

2023-05-26 Thread Martyn Welch
On 26/05/2023 10:07, Uwe Kleine-König wrote: After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able

Re: [PATCH v2] drm: Switch i2c drivers back to use .probe()

2023-05-26 Thread Kieran Bingham
Quoting Uwe Kleine-König (2023-05-26 10:07:09) > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert > back to (the new) .probe() to be

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-05-26 Thread Tomi Valkeinen
On 16/05/2023 17:25, Aradhya Bhatia wrote: Hi Neil, Thank you for reviewing the patch. On 16-May-23 12:51, Neil Armstrong wrote: On 15/05/2023 17:59, Aradhya Bhatia wrote: Hi Tomi, On 12-May-23 14:45, Tomi Valkeinen wrote: On 09/05/2023 12:30, Aradhya Bhatia wrote: From: Nikhil Devshatwar

Re: [Intel-gfx] [PATCH] drm/i915: simplify switch to if-elseif

2023-05-26 Thread Jani Nikula
On Tue, 23 May 2023, Jani Nikula wrote: > On Tue, 23 May 2023, Tom Rix wrote: >> clang with W=1 reports >> drivers/gpu/drm/i915/display/intel_display.c:6012:3: error: unannotated >> fall-through between switch labels [-Werror,-Wimplicit-fallthrough] >> case

Re: [PATCH] drm/i915: Fix clang -Wimplicit-fallthrough in intel_async_flip_check_hw()

2023-05-26 Thread Jani Nikula
On Wed, 24 May 2023, Nick Desaulniers wrote: > On Wed, May 24, 2023 at 8:38 AM Nathan Chancellor wrote: >> >> Clang warns: >> >> drivers/gpu/drm/i915/display/intel_display.c:6012:3: error: unannotated >> fall-through between switch labels [-Werror,-Wimplicit-fallthrough] >>

[PATCH v2] drm/nouveau: bring back blit subchannel for pre nv50 GPUs

2023-05-26 Thread Karol Herbst
1ba6113a90a0 removed a lot of the kernel GPU channel, but method 0x128 was important as otherwise the GPU spams us with `CACHE_ERROR` messages. We use the blit subchannel inside our vblank handling, so we should keep at least this part. v2: Only do it for NV11+ GPUs Closes:

[PATCH] drm/msm/dpu: use PINGPONG_NONE to unbind INTF from PP

2023-05-26 Thread Dmitry Baryshkov
Currently the driver passes the PINGPONG index to dpu_hw_intf_ops::bind_pingpong_blk() callback and uses separate boolean flag to tell whether INTF should be bound or unbound. Simplify this by passing PINGPONG_NONE in case of unbinding and drop the flag completely. Signed-off-by: Dmitry Baryshkov

[PATCH v2] drm: Switch i2c drivers back to use .probe()

2023-05-26 Thread Uwe Kleine-König
After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct

Re: [PATCH] drm/stm: Fix resolution bitmasks

2023-05-26 Thread Marek Vasut
On 5/15/23 18:02, Philippe CORNU wrote: Hi, The genmask of regsiter SSCR, BPCR & others were setted accordly to the chipset stm32f4. So that means: F4 -> 2048x2048 framebuffer H7/MP1 -> 4096x4096 framebuffer ? Worse F4 is 2048x2048 F7 is 4096x2048 MP1 is 4096x4096 and there is no IDR

Re: [PATCH v2 3/6] drm/msm/dpu: split interrupt address arrays

2023-05-26 Thread Neil Armstrong
On 22/05/2023 23:45, Dmitry Baryshkov wrote: There is no point in having a single enum (and a single array) for both DPU < 7.0 and DPU >= 7.0 interrupt registers. Instead define a single enum and two IRQ address arrays. Signed-off-by: Dmitry Baryshkov ---

Re: [Freedreno] [PATCH v2 3/6] drm/msm/dpu: split interrupt address arrays

2023-05-26 Thread Dmitry Baryshkov
On Fri, 26 May 2023 at 01:42, Abhinav Kumar wrote: > On 5/25/2023 3:30 PM, Dmitry Baryshkov wrote: > > On Fri, 26 May 2023 at 00:40, Jeykumar Sankaran > > wrote: > >> On 5/22/2023 2:45 PM, Dmitry Baryshkov wrote: > >>> There is no point in having a single enum (and a single array) for both > >>>

Re: [PATCH] drm/stm: Fix resolution bitmasks

2023-05-26 Thread Philippe CORNU
On 10/14/22 19:15, Marek Vasut wrote: On 10/14/22 17:55, Marek Vasut wrote: On 10/14/22 15:42, Yannick FERTRE wrote: Hi Marek, Hello Yannick, The genmask of regsiter SSCR, BPCR & others were setted accordly to the chipset stm32f4. So that means: F4 -> 2048x2048 framebuffer H7/MP1 ->

Re: [PATCH v4 03/11] drm/mediatek: gamma: Support SoC specific LUT size

2023-05-26 Thread AngeloGioacchino Del Regno
Il 26/05/23 07:20, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Thu, 2023-05-18 at 12:48 +0200, AngeloGioacchino Del Regno wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. Newer SoCs support a bigger Gamma LUT table: wire up a

Re: [PATCH v4 06/11] drm/mediatek: gamma: Use bitfield macros

2023-05-26 Thread AngeloGioacchino Del Regno
Il 26/05/23 07:32, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Thu, 2023-05-18 at 12:48 +0200, AngeloGioacchino Del Regno wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. Make the code more robust and improve readability by

Re: [PATCH] Revert "dt-bindings: bridge: samsung-dsim: Make some flags optional"

2023-05-26 Thread Neil Armstrong
Hi, On Fri, 26 May 2023 09:27:16 +0200, Neil Armstrong wrote: > This reverts commit cfaf76d349837f695c8aa6d7077847fec4231fe5 which was applied > without review due to a bad tool manipulation. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1]

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2023-05-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #55 from Harald Judt (h.j...@gmx.at) --- Unfortunately with the patch applied to 6.3.4 it causes the old problem. The screen stays dark, USB keyboard offline when trying to resume. So special treatment is still required it seems. --

Re: [PATCH] Revert "dt-bindings: bridge: samsung-dsim: Make some flags optional"

2023-05-26 Thread Neil Armstrong
: 20230526-revert-bad-binding-f77a3ca96419 Best regards, -- Neil Armstrong

Re: [Freedreno] [PATCH v2 3/6] drm/msm/dpu: split interrupt address arrays

2023-05-26 Thread Jeykumar Sankaran
On 5/22/2023 2:45 PM, Dmitry Baryshkov wrote: There is no point in having a single enum (and a single array) for both DPU < 7.0 and DPU >= 7.0 interrupt registers. Instead define a single enum and two IRQ address arrays. Signed-off-by: Dmitry Baryshkov ---

[PATCH] drm: Remove unnecessary (void*) conversions

2023-05-26 Thread Su Hui
Pointer variables of (void*) type do not require type cast. Signed-off-by: Su Hui --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- drivers/gpu/drm/amd/pm/amdgpu_pm.c| 2 +- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++--

Re: [PATCH] Revert "dt-bindings: bridge: samsung-dsim: Make some flags optional"

2023-05-26 Thread Conor Dooley
-137,7 +134,9 @@ required: >- compatible >- interrupts >- reg > + - samsung,burst-clock-frequency >- samsung,esc-clock-frequency > + - samsung,pll-clock-frequency > > allOf: >- $ref: ../dsi-controller.yaml# > > --- > ba

Re: [PATCH] drm/panel: simple: fix active size for Ampire AM-480272H3TMQW-T01H

2023-05-26 Thread Neil Armstrong
Hi, On Tue, 16 May 2023 10:50:39 +0200, Dario Binacchi wrote: > The previous setting was related to the overall dimension and not to the > active display area. > In the "PHYSICAL SPECIFICATIONS" section, the datasheet shows the > following parameters: > >

Re: [PATCH 0/2] drm/panel: simple: Add support for Ampire AM-800480L1TMQW-T00H

2023-05-26 Thread Neil Armstrong
Hi, On Wed, 24 May 2023 14:32:09 +0200, Geert Uytterhoeven wrote: > Hi all, > > This patch series adds support for the Ampire AM-800480L1TMQW-T00H 5" > WVGA TFT LCD panel, which can be found on e.g. the Atmark Techno > Armadillo-800-EVA development board. > > It has been tested with a WIP

Re: [PATCH 1/2] dt-bindings: display: panel: Add Visionox R66451 AMOLED DSI panel bindings

2023-05-26 Thread Neil Armstrong
On 22/05/2023 16:51, Marijn Suijten wrote: On 2023-05-22 11:05:38, Neil Armstrong wrote: On 21/05/2023 12:30, Marijn Suijten wrote: On 2023-05-16 13:20:30, Jessica Zhang wrote: Document the 1080x2340 Visionox R66451 AMOLED DSI panel bindings Signed-off-by: Jessica Zhang ---

  1   2   >