[PATCH 1/2] drm/msm: provide fb_dirty implemenation

2023-06-11 Thread Dmitry Baryshkov
Since commit 93e81e38e197 ("drm/fb_helper: Minimize damage-helper overhead") the drm_fb_helper_funcs::fb_dirty helper is required for proper dirty/damage processing. The drm/msm driver requires that to function to let CMD panels to work. Use simplified version of

[PATCH 2/2] drm/msm/dsi: don't allow enabling 7nm VCO with unprogrammed rate

2023-06-11 Thread Dmitry Baryshkov
CCF can try enabling VCO before the rate has been programmed. This can cause clock lockups and/or other boot issues. Program the VCO to the minimal PLL rate if the read rate is 0 Hz. Reported-by: Degdag Mohamed Fixes: 1ef7c99d145c ("drm/msm/dsi: add support for 7nm DSI PHY/PLL") Signed-off-by:

Re: [PATCH] drm/i2c: Switch i2c drivers back to use .probe()

2023-06-11 Thread Andi Shyti
Hi Uwe, On Sun, Jun 11, 2023 at 10:27:40PM +0200, Uwe Kleine-König wrote: > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") >

Re: [PATCH v6 6/6] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2023-06-11 Thread Marijn Suijten
On 2023-06-09 15:57:18, Jessica Zhang wrote: > Add documentation comments explaining the pclk_rate and hdisplay math > related to DSC. > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [Freedreno] [PATCH v5 2/5] drm/msm/dsi: Adjust pclk rate for compression

2023-06-11 Thread Marijn Suijten
On 2023-06-08 17:56:47, Jessica Zhang wrote: > > As discussed before we realized that this change is more-or-less a hack, > > since downstream calculates pclk quite differently - at least for > > command-mode panels. Do you still intend to land this patch this way, > > or go the proper route by

Re: [PATCH v5 2/5] drm/msm/dsi: Adjust pclk rate for compression

2023-06-11 Thread Marijn Suijten
On 2023-06-09 19:58:00, Dmitry Baryshkov wrote: > On 08/06/2023 23:36, Marijn Suijten wrote: > > Same title suggestion as earlier: s/adjust/reduce > > > > On 2023-05-22 18:08:56, Jessica Zhang wrote: > >> Adjust the pclk rate to divide hdisplay by the compression ratio when DSC > >> is enabled. >

Re: [Freedreno] [PATCH v5 2/5] drm/msm/dsi: Adjust pclk rate for compression

2023-06-11 Thread Marijn Suijten
On 2023-06-08 18:09:57, Abhinav Kumar wrote: > >> As discussed before we realized that this change is more-or-less a hack, > >> since downstream calculates pclk quite differently - at least for > >> command-mode panels.  Do you still intend to land this patch this way, > >> or go the proper route

Re: [PATCH] drm/i2c: Switch i2c drivers back to use .probe()

2023-06-11 Thread Javier Martinez Canillas
Uwe Kleine-König writes: Hello Uwe, > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") > convert back to (the new) .probe() to be

[PATCH] drm/i2c: Switch i2c drivers back to use .probe()

2023-06-11 Thread Uwe Kleine-König
After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-11 Thread Sam Ravnborg
Hi Thomas, On Mon, Jun 05, 2023 at 04:48:12PM +0200, Thomas Zimmermann wrote: > Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev > device optional. If the new option has not been selected, fbdev > does not create a files in devfs or sysfs. s/ a// > > Most modern Linux systems run a

[PATCH v2] drm/amdgpu: Add error reporting code for the display core

2023-06-11 Thread Sui Jingfeng
[why] Because the drm/amdgpu drivers do not work with Navi 10 [RX 5700] series GPUs on non-x86 platforms, this patch helps find out where the drivers fail. After applying his patch, the following error message can be found: [drm:dc_create [amdgpu]] *ERROR* dc_construct: failed to create resource

RE: [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-11 Thread Zhang, Carl
It is impossible to pass the PAT setting when sharing the fd. 1. All api , include vaapi, vulkan, gl... need such extension , the impact is huge. Even these API level accept , some middle ware , such as ffmpeg... also will reject it. 2. PAT is intel specific implementation , and MTL ,

Re: [PATCH] accel/habanalabs: add more debugfs stub helpers

2023-06-11 Thread Oded Gabbay
On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar wrote: > > On 09/06/2023 15:06, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Two functions got added with normal prototypes for debugfs, but not > > alternative when building without it: > > > > drivers/accel/habanalabs/common/device.c: In

Re: [RESEND, 12/15] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses

2023-06-11 Thread Sui Jingfeng
Reviewed-by: Sui Jingfeng On 2023/6/9 16:17, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Re: [PATCH] drm: etnaviv: Replace of_platform.h with explicit includes

2023-06-11 Thread Sui Jingfeng
Reviewed-by: Sui Jingfeng On 2023/6/10 04:17, Rob Herring wrote: On Mon, Apr 10, 2023 at 5:26 PM Rob Herring wrote: Etnaviv doesn't use anything from of_platform.h, but depends on of.h, of_device.h, and platform_device.h which are all implicitly included, but that is going to be removed

Re: [PATCH] drm/edid: Add quirk for OSVR HDK 2.0

2023-06-11 Thread Ralph Campbell
On 6/10/23 00:22, Jani Nikula wrote: On Fri, 09 Jun 2023, Ralph Campbell wrote: On 6/9/23 02:03, Jani Nikula wrote: On Thu, 08 Jun 2023, Ralph Campbell wrote: The OSVR virtual reality headset HDK 2.0 uses a different EDID vendor and device identifier than the HDK 1.1 - 1.4 headsets. Add