[PATCH V4 8/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7

2023-06-20 Thread Evan Quan
Fulfill the SMU13.0.7 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 59 +++ 1 file changed, 59 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c

[PATCH V4 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-06-20 Thread Evan Quan
Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 3 +

[PATCH V4 6/8] drm/amd/pm: add flood detection for wbrf events

2023-06-20 Thread Evan Quan
To protect PMFW from being overloaded. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 28 --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 7 + 2 files changed, 31 insertions(+), 4 deletions(-) diff --git

[PATCH V4 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-06-20 Thread Evan Quan
With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7). To make WBRF feature functional, the kernel

[PATCH V4 4/8] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature

2023-06-20 Thread Evan Quan
Add those data structures to support Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h | 14 +-

[PATCH V4 3/8] wifi: mac80211: Add support for ACPI WBRF

2023-06-20 Thread Evan Quan
To support AMD's WBRF interference mitigation mechanism, Wifi adapters utilized in the system must register the frequencies in use(or unregister those frequencies no longer used) via the dedicated APCI calls. So that, other drivers responding to the frequencies can take proper actions to mitigate

[PATCH V4 2/8] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-06-20 Thread Evan Quan
The newly added WBRF feature needs this interface for channel width calculation. Signed-off-by: Evan Quan --- include/net/cfg80211.h | 8 net/wireless/chan.c| 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index

[PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-20 Thread Evan Quan
From: Mario Limonciello Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has introduced

[PATCH V4 0/8] Support Wifi RFI interference mitigation feature

2023-06-20 Thread Evan Quan
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate possible RFI interference producers can advertise

Re: [PATCH v4 5/6] dma-buf: Change locking policy for mmap()

2023-06-20 Thread Christian König
Am 20.06.23 um 17:58 schrieb Dmitry Osipenko: On 5/31/23 22:58, Dmitry Osipenko wrote: On 5/30/23 01:39, Dmitry Osipenko wrote: Change locking policy of mmap() callback, making exporters responsible for handling dma-buf reservation locking. Previous locking policy stated that dma-buf is locked

RE: [PATCH] drm/amd/pm: Vangogh: Add new gpu_metrics_v2_4 to acquire gpu_metrics

2023-06-20 Thread Lazar, Lijo
[AMD Official Use Only - General] Could you add the expected units of voltage/current in 2.4 metrics structure? Is it mV/mA or mV/A? Thanks, Lijo -Original Message- From: amd-gfx On Behalf Of Wenyou Yang Sent: Thursday, June 1, 2023 7:08 AM To: Deucher, Alexander ; Limonciello, Mario

Re: [PATCH net-next v8 03/11] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-20 Thread Jakub Kicinski
On Fri, 16 Jun 2023 15:14:16 -0700 Justin Chen wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. This controller features two distinct Ethernet > ports that can be independently operated. First of all - thanks for splitting the patches up.

Re: [PATCH drm-next v5 09/14] drm/nouveau: fence: separate fence alloc and emit

2023-06-20 Thread kernel test robot
Hi Danilo, kernel test robot noticed the following build errors: [auto build test ERROR on dcb0775d36de28992f56455ab3967b30d380] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-execution-context-for-GEM-buffers-v4/20230620-084448 base

RE: [EXT] Re: [PATCH v6 2/8] dt-bindings: display: bridge: Add Cadence MHDP8501 HDMI and DP

2023-06-20 Thread Sandor Yu
Hi Rob, Thanks for your comments, > -Original Message- > From: Rob Herring > Sent: 2023年6月20日 23:49 > To: Sandor Yu > Cc: andrzej.ha...@intel.com; neil.armstr...@linaro.org; > robert.f...@linaro.org; laurent.pinch...@ideasonboard.com; > jo...@kwiboo.se; jernej.skra...@gmail.com;

[PATCH v2] drm/i915/guc/slpc: Apply min softlimit correctly

2023-06-20 Thread Vinay Belgaumkar
The scenario being fixed here is depicted in the following sequence- modprobe i915 echo 1 > /sys/class/drm/card0/gt/gt0/slpc_ignore_eff_freq echo 300 > /sys/class/drm/card0/gt_min_freq_mhz (RPn) cat /sys/class/drm/card0/gt_cur_freq_mhz --> cur == RPn as expected echo 1 >

RE: [PATCH V3 1/7] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Monday, June 19, 2023 10:04 AM > To: Quan, Evan > Cc: linux-ker...@vger.kernel.org; linux-a...@vger.kernel.org; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- >

RE: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Monday, June 19, 2023 10:17 AM > To: Quan, Evan > Cc: linux-ker...@vger.kernel.org; linux-a...@vger.kernel.org; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- >

RE: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Johannes Berg > Sent: Monday, June 19, 2023 4:24 PM > To: Limonciello, Mario ; Quan, Evan > > Cc: linux-ker...@vger.kernel.org; linux-a...@vger.kernel.org; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org;

[RFC PATCH v3 4/4] drm/i915: Implement DRM_IOCTL_GET_RESET

2023-06-20 Thread André Almeida
Implement get_reset ioctl for i915. Signed-off-by: André Almeida --- drivers/gpu/drm/i915/gem/i915_gem_context.c| 18 ++ drivers/gpu/drm/i915/gem/i915_gem_context.h| 2 ++ .../gpu/drm/i915/gem/i915_gem_context_types.h | 2 ++ drivers/gpu/drm/i915/i915_driver.c

[RFC PATCH v3 3/4] drm/amdgpu: Implement DRM_IOCTL_GET_RESET

2023-06-20 Thread André Almeida
Implement get_reset ioctl for amdgpu Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 35 + drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h | 5 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 +

[RFC PATCH v3 2/4] drm: Create DRM_IOCTL_GET_RESET

2023-06-20 Thread André Almeida
Create a new DRM ioctl operation to get the numbers of resets for a given context. The numbers reflect just the resets that happened after the context was created, and not since the machine was booted. Create a debugfs interface to make easier to test the API without real resets. Signed-off-by:

[RFC PATCH v3 1/4] drm/doc: Document DRM device reset expectations

2023-06-20 Thread André Almeida
Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Signed-off-by: André Almeida --- Documentation/gpu/drm-uapi.rst | 65 ++ 1 file changed, 65 insertions(+) diff --git a/Documentation/gpu/drm-uapi.rst

[RFC PATCH v3 0/4] drm: Standardize device reset notification

2023-06-20 Thread André Almeida
Hi, This is a new version of the documentation for DRM device resets. As I dived more in the subject, I started to believe that part of the problem was the lack of a DRM API to get reset information from the driver. With an API, we can better standardize reset queries, increase common code from

Re: [PATCH] drm/mediatek: Fix void-pointer-to-enum-cast warning

2023-06-20 Thread kernel test robot
Hi Jason-JH.Lin, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.4-rc7 next-20230620] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH] drm/amd/amdgpu: Properly tune the size of struct

2023-06-20 Thread kernel test robot
Hi Su, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.4-rc7 next-20230620] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

RE: [PATCH V3 4/7] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Monday, June 19, 2023 10:55 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; kv...@kernel.org;

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-20 Thread Jessica Zhang
On 6/20/2023 3:11 PM, Dmitry Baryshkov wrote: On Wed, 21 Jun 2023 at 00:37, Jessica Zhang wrote: On 6/16/2023 5:37 PM, Dmitry Baryshkov wrote: On 17/06/2023 00:10, Abhinav Kumar wrote: On 6/14/2023 1:43 PM, Dmitry Baryshkov wrote: On 14/06/2023 23:39, Abhinav Kumar wrote: On

[PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam The adreno_is_a20x() and adreno_is_a225() functions rely on the GPU revision, but such information is retrieved inside adreno_gpu_init(), which is called afterwards. Fix this problem by caling adreno_gpu_init() earlier, so that the GPU information revision is available when

Re: [PATCH] drm/gma500: Replace kmap{,_atomic}() with page_address()

2023-06-20 Thread Fabio M. De Francesco
On martedì 20 giugno 2023 20:01:48 CEST Sumitra Sharma wrote: > Remove unnecessary calls to kmap{,_atomic}() when acquiring > pages using GFP_DMA32. > > The GFP_DMA32 uses the DMA32 zone to satisfy the allocation > requests. Therefore, pages allocated with GFP_DMA32 cannot > come from Highmem. >

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-20 Thread Dmitry Baryshkov
On Wed, 21 Jun 2023 at 00:37, Jessica Zhang wrote: > > > > On 6/16/2023 5:37 PM, Dmitry Baryshkov wrote: > > On 17/06/2023 00:10, Abhinav Kumar wrote: > >> > >> > >> On 6/14/2023 1:43 PM, Dmitry Baryshkov wrote: > >>> On 14/06/2023 23:39, Abhinav Kumar wrote: > > > On 6/14/2023

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-20 Thread Dmitry Baryshkov
On Wed, 21 Jun 2023 at 00:38, Jessica Zhang wrote: > > > > On 6/16/2023 5:35 PM, Dmitry Baryshkov wrote: > > On 17/06/2023 00:54, Marijn Suijten wrote: > >> On 2023-06-16 14:18:39, Abhinav Kumar wrote: > >>> > >>> > >>> On 6/14/2023 12:56 AM, Dmitry Baryshkov wrote: > On 14/06/2023 04:57,

Re: [PATCH 1/3] drm/msm/a3xx: Pass the revision information

2023-06-20 Thread Dmitry Baryshkov
On Tue, 20 Jun 2023 at 21:14, Fabio Estevam wrote: > > On 20/06/2023 14:40, Dmitry Baryshkov wrote: > > > This looks like a boilerplate being added to all aYxx drivers (and > > then these fields are also set in adreno_gpu_init()). Can we remove > > duplication somehow? > > Sorry, I missed this

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-20 Thread Jessica Zhang
On 6/16/2023 5:35 PM, Dmitry Baryshkov wrote: On 17/06/2023 00:54, Marijn Suijten wrote: On 2023-06-16 14:18:39, Abhinav Kumar wrote: On 6/14/2023 12:56 AM, Dmitry Baryshkov wrote: On 14/06/2023 04:57, Jessica Zhang wrote: Add a DPU INTF op to set the DATABUS_WIDEN register to enable

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0

2023-06-20 Thread Jessica Zhang
On 6/16/2023 5:37 PM, Dmitry Baryshkov wrote: On 17/06/2023 00:10, Abhinav Kumar wrote: On 6/14/2023 1:43 PM, Dmitry Baryshkov wrote: On 14/06/2023 23:39, Abhinav Kumar wrote: On 6/14/2023 12:54 PM, Abhinav Kumar wrote: On 6/14/2023 12:35 PM, Abhinav Kumar wrote: On 6/14/2023

Re: [Intel-xe] [RFC PATCH 1/1] drm/xe: Introduce function pointers for MMIO functions

2023-06-20 Thread Lucas De Marchi
On Sun, Jun 18, 2023 at 11:28:20AM +0300, Oded Gabbay wrote: On Thu, Jun 15, 2023 at 7:34 PM Matt Roper wrote: On Thu, Jun 15, 2023 at 04:04:18PM +0300, Oded Gabbay wrote: > On Thu, Jun 15, 2023 at 3:01 AM Matt Roper wrote: > > > > On Mon, Jun 12, 2023 at 06:31:57PM +0200, Francois Dugast

Re: [PATCH v2] drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2

2023-06-20 Thread Lyude Paul
Also since I forgot, so patchwork picks this up: Reviewed-by: Lyude Paul On Tue, 2023-06-20 at 15:50 -0400, Lyude Paul wrote: > Eek - this might have been a situation where everyone involved assumed someone > else would push it, whoops. I'll make sure this is pushed upstream :). > > FWIW: You

Re: [PATCH v2] drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2

2023-06-20 Thread Lyude Paul
Eek - this might have been a situation where everyone involved assumed someone else would push it, whoops. I'll make sure this is pushed upstream :). FWIW: You could definitely send an MR to the fedora kernel's gitlab to get this included earlier. If you don't get to it before me I'll try to do

Re: [PATCH] drm/display/dp_mst: Fix missing check for return value of drm_atomic_get_mst_payload_state()

2023-06-20 Thread Lyude Paul
Hm, I suppose it's not -impossible- for this to return NULL, but if it does return NULL that absolutely means something broke well before this point in the code. More comments below: On Wed, 2023-06-14 at 09:09 -0700, Chenyuan Mi wrote: > The drm_atomic_get_mst_payload_state() function may >

Re: [PATCH] drm/bridge_connector: use drm_kms_helper_connector_hotplug_event()

2023-06-20 Thread Sam Ravnborg
Hi Simon, On Tue, Jun 20, 2023 at 07:01:59PM +, Simon Ser wrote: > On Tuesday, June 20th, 2023 at 20:58, Sam Ravnborg wrote: > > > On Tue, Jun 20, 2023 at 05:55:09PM +, Simon Ser wrote: > > > > > This adds more information to the hotplug uevent and lets user-space > > > know that it's

Re: [PATCH] drm/bridge_connector: use drm_kms_helper_connector_hotplug_event()

2023-06-20 Thread Simon Ser
On Tuesday, June 20th, 2023 at 20:58, Sam Ravnborg wrote: > On Tue, Jun 20, 2023 at 05:55:09PM +, Simon Ser wrote: > > > This adds more information to the hotplug uevent and lets user-space > > know that it's about a particular connector only. > > Will this change have impact on user

Re: [PATCH] drm/bridge_connector: use drm_kms_helper_connector_hotplug_event()

2023-06-20 Thread Sam Ravnborg
Hi Simon, On Tue, Jun 20, 2023 at 05:55:09PM +, Simon Ser wrote: > This adds more information to the hotplug uevent and lets user-space > know that it's about a particular connector only. Will this change have impact on user space? They will start to see CONNECTOR=n where they did not occur

RE: [PATCH] drm/amd/pm: Vangogh: Add new gpu_metrics_v2_4 to acquire gpu_metrics

2023-06-20 Thread Limonciello, Mario
[Public] You've got an A-b from Evan already on this. It looks fine to me too. Reviewed-by: Mario Limonciello > -Original Message- > From: Yang, WenYou > Sent: Sunday, June 11, 2023 12:53 AM > To: Yang, WenYou ; Deucher, Alexander > ; Limonciello, Mario > ; Koenig, Christian > ; Pan,

[PATCH] accel: make accel_class a static const structure

2023-06-20 Thread Greg Kroah-Hartman
From: Ivan Orlov Now that the driver core allows for struct class to be in read-only memory, move the accel_class structure to be declared at build time placing it into read-only memory, instead of having to be dynamically allocated at boot time. Cc: Oded Gabbay Cc:

Re: [Intel-xe] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-06-20 Thread Jani Nikula
On Tue, 20 Jun 2023, Andy Shevchenko wrote: > So, what does prevent you from using GENMASK_ULL()? > > Another point, you may teach GENMASK() to issue a warning if hi and/or lo > bigger than BITS_PER_LONG. What good does that do if you want the warning for a fixed size different from unsigned

Re: [PATCH 1/3] drm/msm/a3xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
On 20/06/2023 14:40, Dmitry Baryshkov wrote: This looks like a boilerplate being added to all aYxx drivers (and then these fields are also set in adreno_gpu_init()). Can we remove duplication somehow? Sorry, I missed this comment prior to sending v2. Maybe a simpler fix for a2xx_gpu would

Re: [PATCH] drm/bridge_connector: use drm_kms_helper_connector_hotplug_event()

2023-06-20 Thread Laurent Pinchart
Hi Simon, Thank you for the patch. On Tue, Jun 20, 2023 at 05:55:09PM +, Simon Ser wrote: > This adds more information to the hotplug uevent and lets user-space > know that it's about a particular connector only. > > Signed-off-by: Simon Ser > Cc: Dmitry Baryshkov > Cc: Paul Cercueil >

Re: [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-20 Thread Sumitra Sharma
On Tue, Jun 20, 2023 at 06:23:38AM -0700, Ira Weiny wrote: > Sumitra Sharma wrote: > > On Sun, Jun 18, 2023 at 11:11:08AM -0700, Ira Weiny wrote: > > > Sumitra Sharma wrote: > > > > kmap() has been deprecated in favor of the kmap_local_page() > > > > due to high cost, restricted mapping space,

Re: [PATCH v1] drm/i915/gsc: Fix intel_gsc_uc_fw_proxy_init_done with directed wakerefs

2023-06-20 Thread Ceraolo Spurio, Daniele
On 6/16/2023 8:54 AM, Ceraolo Spurio, Daniele wrote: On 6/15/2023 2:19 PM, Alan Previn wrote: intel_gsc_uc_fw_proxy_init_done is used by a few code paths and usages. However, certain paths need a wakeref while others can't take a wakeref such as from the runtime_pm_resume callstack. Add a

Re: [Intel-xe] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-06-20 Thread Lucas De Marchi
On Tue, Jun 20, 2023 at 08:41:10PM +0300, Andy Shevchenko wrote: On Tue, Jun 20, 2023 at 10:25:21AM -0700, Lucas De Marchi wrote: On Tue, Jun 20, 2023 at 05:55:19PM +0300, Andy Shevchenko wrote: > On Tue, Jun 20, 2023 at 05:47:34PM +0300, Jani Nikula wrote: > > On Thu, 15 Jun 2023, Andy

[PATCH] drm/gma500: Replace kmap{,_atomic}() with page_address()

2023-06-20 Thread Sumitra Sharma
Remove unnecessary calls to kmap{,_atomic}() when acquiring pages using GFP_DMA32. The GFP_DMA32 uses the DMA32 zone to satisfy the allocation requests. Therefore, pages allocated with GFP_DMA32 cannot come from Highmem. Avoid using calls to kmap_local_page() / kunmap_local() and kmap() /

Re: [PATCH] drm/amd/amdgpu: Use “__packed“ instead of "pragma pack()"

2023-06-20 Thread kernel test robot
Hi Su, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.4-rc7 next-20230620] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] drm/bridge_connector: use drm_kms_helper_connector_hotplug_event()

2023-06-20 Thread Simon Ser
This adds more information to the hotplug uevent and lets user-space know that it's about a particular connector only. Signed-off-by: Simon Ser Cc: Dmitry Baryshkov Cc: Paul Cercueil Cc: Laurent Pinchart Cc: Sam Ravnborg --- drivers/gpu/drm/drm_bridge_connector.c | 2 +- 1 file changed, 1

[PATCH v2 4/4] drm/msm/a5xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fabio Estevam

[PATCH v2 2/4] drm/msm/a3xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fabio Estevam

[PATCH v2 3/4] drm/msm/a4xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fabio Estevam

[PATCH v2 1/4] drm/msm/a2xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
msm/adreno/adreno_gpu.h:171 a2xx_gpu_init+0x138/0x184 Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.4.0-rc7-next-20230620 #993 Pass the GPU revision information to avoid run-time warning. Tested on a imx53-qsb board. Signed-off-by: Fabio Estevam --- Changes since v1: - Ma

Re: [PATCH] drm/sysfs: rename drm_sysfs_connector_status_event()

2023-06-20 Thread Sam Ravnborg
Hi Simon. On Tue, Jun 20, 2023 at 05:42:42PM +, Simon Ser wrote: > Rename drm_sysfs_connector_status_event() to > drm_sysfs_connector_property_event(). Indeed, "status" is a bit > vague: it can easily be confused with the connected/disconnected > status of the connector. This function has

[PATCH] drm/sysfs: rename drm_sysfs_connector_status_event()

2023-06-20 Thread Simon Ser
Rename drm_sysfs_connector_status_event() to drm_sysfs_connector_property_event(). Indeed, "status" is a bit vague: it can easily be confused with the connected/disconnected status of the connector. This function has nothing to do with connected/disconnected: it merely sends a notification that a

Re: [Intel-xe] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-06-20 Thread Andy Shevchenko
On Tue, Jun 20, 2023 at 10:25:21AM -0700, Lucas De Marchi wrote: > On Tue, Jun 20, 2023 at 05:55:19PM +0300, Andy Shevchenko wrote: > > On Tue, Jun 20, 2023 at 05:47:34PM +0300, Jani Nikula wrote: > > > On Thu, 15 Jun 2023, Andy Shevchenko > > > wrote: > > > > On Fri, May 12, 2023 at 02:45:19PM

Re: [PATCH 1/3] drm/msm/a3xx: Pass the revision information

2023-06-20 Thread Dmitry Baryshkov
On 20/06/2023 20:33, Fabio Estevam wrote: From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid

[PATCH 3/3] drm/msm/a5xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fabio Estevam

[PATCH 2/3] drm/msm/43xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fabio Estevam

[PATCH 1/3] drm/msm/a3xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
From: Fabio Estevam Commit cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") exposes the need of setting the GPU revision fields prior to using the adreno_is_xxx() functions. Pass the GPU revision information to avoid run-time warning. Signed-off-by: Fabio Estevam

Re: [Intel-xe] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-06-20 Thread Lucas De Marchi
On Tue, Jun 20, 2023 at 05:55:19PM +0300, Andy Shevchenko wrote: On Tue, Jun 20, 2023 at 05:47:34PM +0300, Jani Nikula wrote: On Thu, 15 Jun 2023, Andy Shevchenko wrote: > On Fri, May 12, 2023 at 02:45:19PM +0300, Jani Nikula wrote: >> On Fri, 12 May 2023, Andy Shevchenko wrote: >> > On Fri,

Re: [PATCH 3/3] drm/gem-dma: Unexport drm_gem_dma_vm_ops

2023-06-20 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Tue, Jun 20, 2023 at 02:03:23PM +0200, Thomas Zimmermann wrote: > There are no external users of drm_gem_dma_vm_ops. Unexport the symbol. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_gem_dma_helper.c |

Re: [PATCH 1/3] drm/rcar-du: Import buffers with GEM DMA's helpers

2023-06-20 Thread Laurent Pinchart
Hi Thomas, Thank you for the patch. On Tue, Jun 20, 2023 at 02:03:21PM +0200, Thomas Zimmermann wrote: > Call __drm_gem_dma_create() to create an object for imported buffers, > instead of reimplementing the function within the driver. Reduces > code duplication and will later allow to un-export

Re: [PATCH] drm/drm_gem.c: remove surplus else after return clause

2023-06-20 Thread Thomas Zimmermann
Hi Am 20.06.23 um 18:06 schrieb Sui Jingfeng: Hi, On 2023/6/20 22:43, Thomas Zimmermann wrote: Hi Am 20.06.23 um 06:08 schrieb Sui Jingfeng: ping ? On 2023/3/14 20:53, Sui Jingfeng wrote:   else is not generally useful after return No indention please. OK, will be fixed at the next

Re: [PATCH] drm/drm_gem.c: remove surplus else after return clause

2023-06-20 Thread Sui Jingfeng
Hi, On 2023/6/20 22:43, Thomas Zimmermann wrote: Hi Am 20.06.23 um 06:08 schrieb Sui Jingfeng: ping ? On 2023/3/14 20:53, Sui Jingfeng wrote:   else is not generally useful after return No indention please. OK, will be fixed at the next version. Signed-off-by: Sui Jingfeng

Re: [PATCH v4 5/6] dma-buf: Change locking policy for mmap()

2023-06-20 Thread Dmitry Osipenko
On 5/31/23 22:58, Dmitry Osipenko wrote: > On 5/30/23 01:39, Dmitry Osipenko wrote: >> Change locking policy of mmap() callback, making exporters responsible >> for handling dma-buf reservation locking. Previous locking policy stated >> that dma-buf is locked for both importers and exporters by

Re: [PATCH v2 3/3] drm/prime: Unexport helpers for fd/handle conversion

2023-06-20 Thread Jeffrey Hugo
On 6/20/2023 1:59 AM, Thomas Zimmermann wrote: Unexport drm_gem_prime_fd_to_handle() and drm_gem_prime_handle_to_fd(). Both are only used internally within the PRIME code. v2: * reword docs as functions are now unexported (Simon) Signed-off-by: Thomas Zimmermann Reviewed-by: Simon Ser

Re: [PATCH v2 1/3] drm: Enable PRIME import/export for all drivers

2023-06-20 Thread Jeffrey Hugo
On 6/20/2023 1:59 AM, Thomas Zimmermann wrote: Call drm_gem_prime_handle_to_fd() and drm_gem_prime_fd_to_handle() by default if no PRIME import/export helpers have been set. Both functions are the default for almost all drivers. DRM drivers implement struct drm_driver.gem_prime_import_sg_table

Re: [PATCH v6 2/8] dt-bindings: display: bridge: Add Cadence MHDP8501 HDMI and DP

2023-06-20 Thread Rob Herring
On Thu, Jun 15, 2023 at 09:38:12AM +0800, Sandor Yu wrote: > Add bindings for Cadence MHDP8501 DisplayPort and HDMI driver. Bindings are for h/w, not a driver. > > Signed-off-by: Sandor Yu > --- > .../display/bridge/cdns,mhdp8501.yaml | 105 ++ > 1 file changed, 105

Re: [PATCH v6 2/8] dt-bindings: display: bridge: Add Cadence MHDP8501 HDMI and DP

2023-06-20 Thread Rob Herring
On Fri, Jun 16, 2023 at 11:31:43AM +0200, Alexander Stein wrote: > Hi Sandor, > > Am Donnerstag, 15. Juni 2023, 03:38:12 CEST schrieb Sandor Yu: > > Add bindings for Cadence MHDP8501 DisplayPort and HDMI driver. > > > > Signed-off-by: Sandor Yu > > --- > > .../display/bridge/cdns,mhdp8501.yaml

[PATCH] drm/msm/a2xx: Pass the revision information

2023-06-20 Thread Fabio Estevam
x138/0x184 Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.4.0-rc7-next-20230620 #993 Fix the problem by assigning the GPU revision fields like it is done in a6xx_gpu. Fixes: cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before being set") Signed-off-by: Fabio E

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-06-20 Thread Andy Shevchenko
On Tue, Jun 20, 2023 at 05:47:34PM +0300, Jani Nikula wrote: > On Thu, 15 Jun 2023, Andy Shevchenko > wrote: > > On Fri, May 12, 2023 at 02:45:19PM +0300, Jani Nikula wrote: > >> On Fri, 12 May 2023, Andy Shevchenko > >> wrote: > >> > On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula

Re: [PATCH] dt-bindings: gpu: drop unneeded quotes

2023-06-20 Thread Rob Herring
On Fri, 09 Jun 2023 16:07:38 +0200, Krzysztof Kozlowski wrote: > Cleanup bindings dropping unneeded quotes. Once all these are fixed, > checking for this can be enabled in yamllint. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 2

Re: [RFC 02/10] drm: Update file owner during use

2023-06-20 Thread Emil Velikov
Hi Tvrtko Sorry for the delay, real life and other obligations got in the way. On Thu, 8 Jun 2023 at 15:26, Tvrtko Ursulin wrote: > On 21/04/2023 13:13, Emil Velikov wrote: > Are you okay if I just paste your very fine explanation verbatim, with > credits? > Yes, feel free to use as much of

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-06-20 Thread Jani Nikula
On Thu, 15 Jun 2023, Andy Shevchenko wrote: > On Fri, May 12, 2023 at 02:45:19PM +0300, Jani Nikula wrote: >> On Fri, 12 May 2023, Andy Shevchenko >> wrote: >> > On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula wrote: >> >> On Fri, 12 May 2023, Andy Shevchenko >> >> wrote: >> >> > On

Re: [PATCH] drm/drm_gem.c: remove surplus else after return clause

2023-06-20 Thread Thomas Zimmermann
Hi Am 20.06.23 um 06:08 schrieb Sui Jingfeng: ping ? On 2023/3/14 20:53, Sui Jingfeng wrote:   else is not generally useful after return No indention please. Signed-off-by: Sui Jingfeng <15330273...@189.cn> ---   drivers/gpu/drm/drm_gem.c | 7 ---   1 file changed, 4 insertions(+), 3

Re: [PATCH 2/3] drm/rockchip: Resolve dependency in GEM DMA helpers

2023-06-20 Thread Thomas Zimmermann
Hi Am 20.06.23 um 15:56 schrieb Jonas Karlman: Hi Thomas, On 2023-06-20 14:03, Thomas Zimmermann wrote: Remove the dependency on the GEM DMA helper library. Rockchip comes with its own implementation of the GEM interface. It only uses the VM callbacks in drm_gem_dma_vm_ops from the GEM DMA

Re: [Intel-gfx] [PATCH] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS

2023-06-20 Thread Balasubrawmanian, Vivaik
On 6/1/2023 12:45 PM, Alan Previn wrote: After recent discussions with Mesa folks, it was requested that we optimize i915's GET_PARAM for the PXP_STATUS without changing the UAPI spec. This patch adds this additional optimizations: - If any PXP initializatoin flow failed, then ensure that

Re: [PATCH v2] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2023-06-20 Thread Dmitry Baryshkov
On 20/06/2023 15:05, Marijn Suijten wrote: On 2023-06-20 00:06:47, Dmitry Baryshkov wrote: Provide actual documentation for the pclk and hdisplay calculations in the case of DSC compression being used. Signed-off-by: Dmitry Baryshkov --- Changes since v1: - Converted

Re: [PATCH drm-next v5 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-06-20 Thread Danilo Krummrich
Hi Boris, On 6/20/23 11:25, Boris Brezillon wrote: Hi Danilo, On Tue, 20 Jun 2023 02:42:03 +0200 Danilo Krummrich wrote: This patch series provides a new UAPI for the Nouveau driver in order to support Vulkan features, such as sparse bindings and sparse residency. Furthermore, with the DRM

Re: [PATCH] accel/qaic: Call DRM helper function to destroy prime GEM

2023-06-20 Thread Jeffrey Hugo
On 6/14/2023 10:15 AM, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya smatch warning: drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error: dereferencing freed memory 'obj->import_attach' obj->import_attach is detached and freed using dma_buf_detach().

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-20 Thread Danilo Krummrich
Hi Christian, On 6/20/23 08:45, Christian König wrote: Hi Danilo, sorry for the delayed reply. I've trying to dig myself out of a hole at the moment. No worries, thank you for taking a look anyway! Am 20.06.23 um 02:42 schrieb Danilo Krummrich: [SNIP] diff --git a/include/drm/drm_gem.h

Re: [PATCH 2/3] drm/rockchip: Resolve dependency in GEM DMA helpers

2023-06-20 Thread Jonas Karlman
Hi Thomas, On 2023-06-20 14:03, Thomas Zimmermann wrote: > Remove the dependency on the GEM DMA helper library. Rockchip comes > with its own implementation of the GEM interface. It only uses the VM > callbacks in drm_gem_dma_vm_ops from the GEM DMA helpers. These are > not DMA specific. > >

Re: [PATCH 00/14] drm/ast: Refactor the device-detection code

2023-06-20 Thread Jocelyn Falempe
On 16/06/2023 15:52, Thomas Zimmermann wrote: Ast's code for detecting the device type and features is convoluted. It mixes up several state fields, chip types and sub-models. Rework the driver into somehting more understandable. Patches 1 fixes a long-standing bug. The affected code has never

Re: [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-20 Thread Ira Weiny
Sumitra Sharma wrote: > On Sun, Jun 18, 2023 at 11:11:08AM -0700, Ira Weiny wrote: > > Sumitra Sharma wrote: > > > kmap() has been deprecated in favor of the kmap_local_page() > > > due to high cost, restricted mapping space, the overhead of a > > > global lock for synchronization, and making the

Re: [PATCH] gpu: drm: Optimize the unused variable ret

2023-06-20 Thread Artur Weber
On 19/06/2023 13:31, Li Dong wrote: > Use zero as the return value instead of the unused variable ret > > Signed-off-by: Li Dong > --- > drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

[PATCH v4 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-06-20 Thread Julien Stephan
From: Phi-bang Nguyen This is a new driver that supports the MIPI CSI CD-PHY version 0.5 The number of PHYs depend on the SoC. Each PHY can support D-PHY only or CD-PHY configuration. The driver supports only D-PHY mode, so CD-PHY compatible PHY are configured in D-PHY mode. Signed-off-by:

[PATCH v4 1/2] dt-bindings: phy: add mediatek MIPI CD-PHY module v0.5

2023-06-20 Thread Julien Stephan
From: Florian Sylvestre This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in some Mediatek soc, such as the mt8365 Signed-off-by: Florian Sylvestre Signed-off-by: Julien Stephan --- .../bindings/phy/mediatek,mt8365-csi-rx.yaml | 79 +++ MAINTAINERS

[PATCH v4 0/3] phy: mtk-mipi-csi: add driver for CSI phy

2023-06-20 Thread Julien Stephan
Adding a new driver for the MIPI CSI CD-PHY module v 0.5 embedded in some Mediatek soc, such as the MT8365 This driver was adapted from https://patchwork.kernel.org/project/linux-mediatek/cover/20200708104023.3225-1-louis@mediatek.com/ v1 can be found here:

[PATCH 3/3] drm/gem-dma: Unexport drm_gem_dma_vm_ops

2023-06-20 Thread Thomas Zimmermann
There are no external users of drm_gem_dma_vm_ops. Unexport the symbol. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_dma_helper.c | 11 +-- include/drm/drm_gem_dma_helper.h | 2 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git

[PATCH 1/3] drm/rcar-du: Import buffers with GEM DMA's helpers

2023-06-20 Thread Thomas Zimmermann
Call __drm_gem_dma_create() to create an object for imported buffers, instead of reimplementing the function within the driver. Reduces code duplication and will later allow to un-export a number of symbols from the GEM DMA helpers. Signed-off-by: Thomas Zimmermann ---

[PATCH 2/3] drm/rockchip: Resolve dependency in GEM DMA helpers

2023-06-20 Thread Thomas Zimmermann
Remove the dependency on the GEM DMA helper library. Rockchip comes with its own implementation of the GEM interface. It only uses the VM callbacks in drm_gem_dma_vm_ops from the GEM DMA helpers. These are not DMA specific. Duplicate drm_gem_dma_vm_ops in rockchip and remove all dependencies on

[PATCH 0/3] drm/gem-dma: Remove unnecessary calls

2023-06-20 Thread Thomas Zimmermann
Remove rockchip's dependency on GEM DMA helpers. Rework the GEM DMA interface to fit the needs of rcar-du. This intends to be a cleanup with no functional changes. With the patches merged, a later patchset can attempt to generate some of the boiler-plate code for struct drm_gem_object_funcs

Re: [PATCH v2] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2023-06-20 Thread Marijn Suijten
On 2023-06-20 00:06:47, Dmitry Baryshkov wrote: > Provide actual documentation for the pclk and hdisplay calculations in > the case of DSC compression being used. > > Signed-off-by: Dmitry Baryshkov > --- > > Changes since v1: > - Converted dsi_adjust_pclk_for_compression() into kerneldoc

Re: [PATCH v2] PCI: Add dummy implement for pci_clear_master() function

2023-06-20 Thread Bjorn Helgaas
On Tue, Jun 20, 2023 at 06:06:00AM -0500, Bjorn Helgaas wrote: > On Tue, Jun 20, 2023 at 12:04:40PM +0800, Sui Jingfeng wrote: > > Where is the formal(unstream) PCI git branch where we could see the latest > > patch ? > > Here's the "misc" branch: >

[PATCH v2 2/2] drm/msm/dsi: Enable runtime PM

2023-06-20 Thread Konrad Dybcio
Some devices power the DSI PHY/PLL through a power rail that we model as a GENPD. Enable runtime PM to make it suspendable. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c

[PATCH v2 1/2] drm/msm/dsi: Use pm_runtime_resume_and_get to prevent refcnt leaks

2023-06-20 Thread Konrad Dybcio
This helper has been introduced to avoid programmer errors (missing _put calls leading to dangling refcnt) when using pm_runtime_get, use it. While at it, start checking the return value. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 +++- 1 file changed, 3

  1   2   >