Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nouveau_usif.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_usif.c
b/drivers/gpu/drm/nouve
Add missing spaces to clear checkpatch errors.
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nouveau_svm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c
b/drivers/gpu/drm/no
On Tue, Jul 11, 2023 at 2:13 PM Dan Carpenter wrote:
>
> Negative -EINVAL was intended instead of positive EINVAL.
>
> Fixes: 6a23afad443a ("phy: phy-mtk-dp: Add driver for DP phy")
> Signed-off-by: Dan Carpenter
Reviewed-by: Chen-Yu Tsai
Hi Sam
Am 10.07.23 um 19:19 schrieb Sam Ravnborg:
Hi Thomas,
On Mon, Jul 10, 2023 at 02:50:04PM +0200, Thomas Zimmermann wrote:
Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from
fbdev and drivers, as briefly discussed at [1]. Both flags were maybe
useful when fbdev had specia
Add missing spaces to clear checkpatch errors.
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open parenthesis '('
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nouveau_drv.h | 28 +--
1 file changed, 14 insertions(+), 14 deletions(
NAK.
Wow. I really screwed this up. I didn't mean to send this patch. I
have a correct patch still sitting in my postponed messages.
I will send v4 in twenty minutes.
regards,
dan carpenter
Negative -EINVAL was intended instead of positive EINVAL.
Fixes: 6a23afad443a ("phy: phy-mtk-dp: Add driver for DP phy")
Signed-off-by: Dan Carpenter
---
drivers/phy/mediatek/phy-mtk-dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/mediatek/phy-mtk-dp.c
b/dri
If get_user_pages_fast() allocates some pages but not as many as we
wanted, then the current code leaks those pages. Call put_page() on
the pages before returning.
Fixes: 129776ac2e38 ("accel/qaic: Add control path")
Signed-off-by: Dan Carpenter
---
no change
drivers/accel/qaic/qaic_control.c
The integer overflow checking for find_and_map_user_pages() was done in
encode_dma(). Presumably this was to do it before the allocation. But
it's not super important that the failure path is a fast path and it
hurts readability to put the check so far from the where the variable is
used.
Move t
Fix two occurrences of the checkpatch.pl error:
ERROR: (foo*) should be (foo *)
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nouveau_fence.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c
b/drivers/gpu/drm/nouveau/nouveau_
The encode_dma() function has integer overflow checks. The
encode_passthrough(), encode_activate() and encode_status() functions
did not. I added integer overflow checking everywhere. I also
updated the integer overflow checking in encode_dma() to use size_add()
so everything is consistent.
Fix
Copy the bounds checking from encode_message() to decode_message().
This patch addresses the following concerns. Ensure that there is
enough space for at least one header so that we don't have a negative
size later.
if (msg_hdr_len < sizeof(*trans_hdr))
Ensure that we have enough space
There are several issues in this code. The check at the start of the
loop:
if (user_len >= user_msg->len) {
This check does not ensure that we have enough space for the trans_hdr
(8 bytes). Instead the check needs to be:
if (user_len >= user_msg->len - sizeof(*trans_hdr)) {
Th
Hi
Am 10.07.23 um 18:25 schrieb Miguel Ojeda:
On Mon, Jul 10, 2023 at 5:22 PM Thomas Zimmermann wrote:
I'll append a patch to the series that documents this.
Sure.
Thanks!
If you are planning to take it into some other tree:
Acked-by: Miguel Ojeda
Thanks.
Otherwise, I can take it i
Fixed in v3: Redo messed up threading
Fixed two things in v2: Include the file. Change
the >= in encode and decode to >.
regards,
dan carpenter
Oops. Left the v2 out of the subject.
Let me start this whole thread over...
regards,
dan carpenter
Hi
Am 10.07.23 um 23:11 schrieb Dmitry Baryshkov:
[...]
---
drivers/gpu/drm/armada/armada_fbdev.c | 4
drivers/gpu/drm/drm_client.c | 21 +
drivers/gpu/drm/drm_fbdev_dma.c | 4
drivers/gpu/drm/drm_fbdev_generic.c | 4
d
There are several issues in this code. The check at the start of the
loop:
if (user_len >= user_msg->len) {
This check does not ensure that we have enough space for the trans_hdr
(8 bytes). Instead the check needs to be:
if (user_len >= user_msg->len - sizeof(*trans_hdr)) {
Th
Fixed two things in v2: Include the file. Change
the >= in encode and decode to >.
regards,
dan carpenter
Add missing spaces to clear checkpatch errors.
ERROR: space required before the open brace ','
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.h
b/drivers/
Am 10.07.23 um 19:40 schrieb Rob Herring:
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many
"of-display.N" as required.
This means
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c
b/drivers/gpu/drm/nouveau/
On 7/10/23 15:19, Yangtao Li wrote:
Remove unnecessary release_mem_region from the error path to prevent
mem region from being released twice, which could avoid resource leak
or other unexpected issues.
Fixes: b083c22d5114 ("video: fbdev: imxfb: Convert request_mem_region + ioremap to
devm_iore
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c
b/drivers/gpu/drm/nouveau/
On Mon, Jul 10, 2023 at 6:32 PM Jani Nikula wrote:
>
> On Mon, 10 Jul 2023, Chen-Yu Tsai wrote:
> > The DRM DP code has macros for the DP power sequencing commands. Use
> > them in the anx7625 driver instead of raw numbers.
> >
> > Fixes: 548b512e144f ("drm/bridge: anx7625: send DPCD command to d
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
b/drivers/gpu/drm/nouveau/
Remove spaces to clear checkpatch errors.
ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: Ran Sun
---
.../gpu/drm/nouveau/nvkm/subdev/clk/gf100.c | 20 +--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c
b/drivers/gpu/dr
Add missing spaces to clear checkpatch errors.
ERROR: space required before the open brace '{'
ERROR: space required before the open parenthesis '('
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/subdev/clk/mcp77.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --gi
Add missing spaces to clear checkpatch errors.
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/subdev/clk/seq.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/
Remove spaces to clear checkpatch errors.
ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt21
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
b/drivers/
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/base.c
b/drivers/gpu/dr
On 11/07/2023 05:31, Abhinav Kumar wrote:
On 7/7/2023 12:39 PM, Dmitry Baryshkov wrote:
The values in struct dpu_core_perf_tune are fixed per the core perf
mode. Drop the 'tune' values and substitute them with known values when
performing perf management.
Note: min_bus_vote was not used at al
On 7/7/2023 12:39 PM, Dmitry Baryshkov wrote:
The values in struct dpu_core_perf_tune are fixed per the core perf
mode. Drop the 'tune' values and substitute them with known values when
performing perf management.
Note: min_bus_vote was not used at all, so it is just silently dropped.
Inte
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c
b/drivers/gpu
On 2023/7/11 0:46, Shengyu Qu wrote:
> Hello Keith,
>> +
>> +static void vs_plane_atomic_update(struct drm_plane *plane,
>> + struct drm_atomic_state *state)
>> +{
>> + struct drm_plane_state *new_state =
>> drm_atomic_get_new_plane_state(state,
>> +
This fixes the checkpatch.pl errors:
ERROR: spaces required around that '=' (ctx:VxW)
Signed-off-by: Ran Sun
---
drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gk20a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gk20a.c
b/drivers/gp
This change adds the ability to read or write a "1" or a "0" to the
newly added "connected" attribute of a connector in the vkms entry in
configfs.
A write will trigger a call to drm_kms_helper_hotplug_event, causing a
hotplug uevent.
With this we can write virtualized multidisplay tests that inv
Hi all,
On Tue, 27 Jun 2023 11:54:32 +1000 Stephen Rothwell
wrote:
>
> Today's linux-next merge of the drm tree got a conflict in:
>
> include/drm/gpu_scheduler.h
>
> between commit:
>
> db8b4968a8d0 ("drm/sched: Call drm_sched_fence_set_parent() from
> drm_sched_fence_scheduled()")
>
On 27/06/2023 23:31, Jessica Zhang wrote:
During a frame transfer in command mode, there could be frequent
LP11 <-> HS transitions when multiple DCS commands are sent mid-frame or
if the DSI controller is running on slow clock and is throttled. To
minimize frame latency due to these transitions,
On 30/06/2023 19:20, Rob Clark wrote:
From: Rob Clark
The range is actually len+1.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
On 6/30/2023 1:27 AM, Pekka Paalanen wrote:
On Thu, 29 Jun 2023 17:25:00 -0700
Jessica Zhang wrote:
Document and add support for solid_fill property to drm_plane. In
addition, add support for setting and getting the values for solid_fill.
To enable solid fill planes, userspace must assign
Use Jakub's memory provider PoC API:
https://github.com/kuba-moo/linux/tree/pp-providers
To implement a dmabuf devmem memory provider. The provider allocates
NET_RX dmabuf pages to the page pool. This abstracts any custom memory
allocation or freeing changes for devmem TCP from drivers using the
p
Implement a few updates to Jakub's RFC memory provider API to make it
suitable for device memory TCP:
1. Currently for devmem TCP the driver's netdev_rx_queue holds a reference to
the dma_buf_pages struct and needs to pass that to the page_pool's memory
provider somehow. For PoC purposes, cr
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it
sends and receives data using the devmem TCP APIs. It uses udmabuf as
the dmabuf provider. It is compatible with a regular netcat running on
a peer, or a ncdevmem running on a peer.
In addition to normal netcat support, ncdevmem
For device memory TCP, we let the user provide the kernel with a cmsg
container 2 items:
1. the dmabuf pages fd that the user would like to send data from.
2. the offset into this dmabuf that the user would like to start sending
from.
In tcp_sendmsg_locked(), if this cmsg is provided, we send
Add an interface for the user to notify the kernel that it is done reading
the NET_RX dmabuf pages returned as cmsg. The kernel will drop the
reference on the NET_RX pages to make them available for re-use.
Signed-off-by: Mina Almasry
---
include/uapi/asm-generic/socket.h | 1 +
include/uapi/li
In tcp_recvmsg_locked(), detect if the skb being received by the user
is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM
flag - pass it to tcp_recvmsg_devmem() for custom handling.
tcp_recvmsg_devmem() copies any data in the skb header to the linear
buffer, and returns a cmsg
For device memory TCP, we expect the skb headers to be available in host
memory for access, and we expect the skb frags to be in device memory
and unaccessible to the host. We expect there to be no mixing and matching
of device memory frags (unaccessible) with host memory frags
(accessible) in the
Used the paged attachment mappings support to create NET_TX pages.
NET_TX pages can be used in the networking transmit path:
1. Create an iov_iter & bio_vec entries to represent this dmabuf.
2. Initialize the bio_vec with the backing dmabuf pages.
Signed-off-by: Mina Almasry
---
drivers/dma-bu
Use the paged attachment mappings support to create NET_RX pages.
NET_RX pages are pages that can be used in the networking receive path:
Bind the pages to the driver's rx queues specified by the create_flags
param, and create a gen_pool to hold the free pages available for the
driver to allocate.
Currently dmabuf p2p memory doesn't present itself in the form of struct
pages and the memory can't be easily used with code that expects memory
in that form. Add support for paged attachment mappings. We use existing
dmabuf APIs to create a mapped attachment (dma_buf_attach() &
dma_buf_map_attachm
* TL;DR:
Device memory TCP (devmem TCP) is a proposal for transferring data to and/or
from device memory efficiently, without bouncing the data to a host memory
buffer.
* Problem:
A large amount of data transfers have device memory as the source and/or
destination. Accelerators drastically incre
Hi
I was hoping this might land for 6.5-rc1, is there a new version that
might apply against 6.5?
Cheers
Mike
On Tue, 9 May 2023 at 08:32, Greg Kroah-Hartman
wrote:
>
> On Tue, May 09, 2023 at 09:16:35AM +0200, Petr Tesařík wrote:
> > On Wed, 26 Apr 2023 14:44:39 +0200
> > Petr Tesařík wrote:
Yay! Glad to see the configfs stuff being extended!
Overall I don't see anything of major concern. Great stuff!
I'd be curious about how the IGT tests would look for this. Creating
before and after registration would be sufficient until removal is
added.
On Thu, Jul 6, 2023 at 1:08 AM Brandon Po
On 2023-07-10 16:56, Rob Clark wrote:
> From: Rob Clark
>
> Fixes the KASAN splat:
>
>==
>BUG: KASAN: use-after-free in msm_ioctl_wait_fence+0x31c/0x7b0
>Read of size 4 at addr ff808cb7c2f8 by task syz-executor/12236
On 10/07/2023 12:10, Thomas Zimmermann wrote:
Generate a hotplug event after registering a client to allow the
client to configure its display. Remove the hotplug calls from the
existing clients for fbdev emulation. This change fixes a concurrency
bug between registering a client and receiving ev
From: Rob Clark
Fixes the KASAN splat:
==
BUG: KASAN: use-after-free in msm_ioctl_wait_fence+0x31c/0x7b0
Read of size 4 at addr ff808cb7c2f8 by task syz-executor/12236
CPU: 6 PID: 12236 Comm: syz-executor Tainted: G
On 10/07/2023 22:56, Rob Clark wrote:
On Thu, Jul 6, 2023 at 7:54 PM Dmitry Baryshkov
wrote:
On 07/07/2023 00:10, Rob Clark wrote:
From: Rob Clark
This simplifies the code.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 171 ++---
drivers/gp
On Thu, Jul 6, 2023 at 4:36 PM Konrad Dybcio wrote:
>
> On 6.07.2023 23:10, Rob Clark wrote:
> > From: Rob Clark
> >
> > This is used in a few places, including one that is parsed by userspace
> > tools. So let's standardize it a bit better.
> >
> > Signed-off-by: Rob Clark
> > ---
> Userspace
Hi,
On 2023/7/10 15:58, Thomas Zimmermann wrote:
Include to get the global screen_info state.
Fixes the following errors:
drivers/video/fbdev/hyperv_fb.c:1033:10: error: use of undeclared identifier
'screen_info'
1033 | base = screen_info.lfb_base;
|
On 10/07/2023 22:51, Jessica Zhang wrote:
On 6/30/2023 1:27 AM, Pekka Paalanen wrote:
On Fri, 30 Jun 2023 03:42:28 +0300
Dmitry Baryshkov wrote:
On 30/06/2023 03:25, Jessica Zhang wrote:
Add support for pixel_source property to drm_plane and related
documentation.
This enum property will
On Thu, Jul 6, 2023 at 7:54 PM Dmitry Baryshkov
wrote:
>
> On 07/07/2023 00:10, Rob Clark wrote:
> > From: Rob Clark
> >
> > This simplifies the code.
> >
> > Signed-off-by: Rob Clark
> > ---
> > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 171 ++---
> > drivers/gpu/drm/msm/a
On 6/30/2023 1:27 AM, Pekka Paalanen wrote:
On Fri, 30 Jun 2023 03:42:28 +0300
Dmitry Baryshkov wrote:
On 30/06/2023 03:25, Jessica Zhang wrote:
Add support for pixel_source property to drm_plane and related
documentation.
This enum property will allow user to specify a pixel source for t
On Mon, Jul 10, 2023 at 09:20:01PM +0800, Yangtao Li wrote:
> These lables are redundant and don't do anything, let's remove it.
s/lable/label/ here an in the subject line.
Are you using this driver, or did you just stumble over it while looking
for some janitorial todo? If the former, I suggest
[Restored CC list]
On Mon, 10 Jul 2023 at 20:08, Kuogee Hsieh wrote:
>
>
> On 7/7/2023 5:32 PM, Dmitry Baryshkov wrote:
> > On 08/07/2023 02:52, Kuogee Hsieh wrote:
> >> Move of_dp_aux_populate_bus() to dp_display_probe() for eDP
> >> from dp_display_bind() so that probe deferral cases can be
> >
On 10/07/2023 19:52, Kuogee Hsieh wrote:
On 7/7/2023 5:34 PM, Dmitry Baryshkov wrote:
On 08/07/2023 02:52, Kuogee Hsieh wrote:
EV_HPD_INIT_SETUP flag is used to trigger the initialization of external
DP host controller. Since external DP host controller initialization had
been incorporated int
On 10/07/2023 19:57, Kuogee Hsieh wrote:
On 7/7/2023 5:11 PM, Dmitry Baryshkov wrote:
On 08/07/2023 02:52, Kuogee Hsieh wrote:
In preparation of moving edp of_dp_aux_populate_bus() to
dp_display_probe(), move dp_display_request_irq(),
dp->parser->parse() and dp_power_client_init() to dp_displa
On 10/07/2023 19:18, Kuogee Hsieh wrote:
On 7/7/2023 5:04 PM, Dmitry Baryshkov wrote:
On 08/07/2023 02:52, Kuogee Hsieh wrote:
Incorporating pm runtime framework into DP driver so that power
and clock resource handling can be centralized allowing easier
control of these resources in preparatio
On 10/07/2023 20:25, Kuogee Hsieh wrote:
On 7/9/2023 1:32 PM, Abhinav Kumar wrote:
On 7/9/2023 11:00 AM, Dmitry Baryshkov wrote:
On Sun, 9 Jul 2023 at 20:22, Abhinav Kumar
wrote:
On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote:
On 08/07/2023 02:52, Kuogee Hsieh wrote:
Since both pm_runtim
On 7/10/23 01:17, Pekka Paalanen wrote:
On Fri, 7 Jul 2023 13:54:21 -0700
Michael Banack wrote:
On 7/7/23 01:38, Pekka Paalanen wrote:
...
The question of which input device corresponds to which cursor plane
might be good to answer too. I presume the VM runner is configured to
expose exa
On Mon, Jul 10, 2023 at 11:40:07AM -0600, Rob Herring wrote:
> Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
> as spotted by Frédéric Bonnard, the historical "of-display" device is
> gone: the updated logic creates "of-display.0" instead, then as many
> "of-display.N" a
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many
"of-display.N" as required.
This means that offb no longer finds the expected device
Applied. Thanks. I've applied all the patches you sent out, but all
of them had whitespace problems. Please double check your mailer on
any future submissions.
Thanks,
Alex
On Mon, Jul 10, 2023 at 6:03 AM wrote:
>
> Fix five occurrences of the checkpatch.pl error:
> ERROR: "(foo*)" should be
Applied. Thanks!
On Mon, Jul 10, 2023 at 5:06 AM wrote:
>
> Fix eleven occurrences of the checkpatch.pl error:
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/radeon/rv770.c | 22 +++---
> 1 file changed, 11 inserti
Applied. Thanks!
On Mon, Jul 10, 2023 at 4:27 AM wrote:
>
> Fix four occurrences of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/radeon/radeon_atombios.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> d
On 7/9/2023 1:32 PM, Abhinav Kumar wrote:
On 7/9/2023 11:00 AM, Dmitry Baryshkov wrote:
On Sun, 9 Jul 2023 at 20:22, Abhinav Kumar
wrote:
On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote:
On 08/07/2023 02:52, Kuogee Hsieh wrote:
Since both pm_runtime_resume() and pm_runtime_suspend() are n
Applied. Thanks!
Alex
On Mon, Jul 10, 2023 at 3:52 AM wrote:
>
> Fix four occurrences of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/radeon/radeon_test.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>
Applied. Thanks!
On Mon, Jul 10, 2023 at 3:38 AM wrote:
>
> Fix nine occurrences of the checkpatch.pl error:
> ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/radeon/atom.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> d
Hi Thomas,
On Mon, Jul 10, 2023 at 02:50:04PM +0200, Thomas Zimmermann wrote:
> Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from
> fbdev and drivers, as briefly discussed at [1]. Both flags were maybe
> useful when fbdev had special handling for driver modules. With
> commit 376
On 7/7/2023 5:11 PM, Dmitry Baryshkov wrote:
On 08/07/2023 02:52, Kuogee Hsieh wrote:
In preparation of moving edp of_dp_aux_populate_bus() to
dp_display_probe(), move dp_display_request_irq(),
dp->parser->parse() and dp_power_client_init() to dp_display_probe()
too.
Signed-off-by: Kuogee Hsi
Liviu Dudau writes:
Hello Liviu,
> On Tue, Jul 04, 2023 at 01:05:27AM +0200, Javier Martinez Canillas wrote:
>> Otherwise if CONFIG_DRM is disabled, menuconfig will show an empty menu.
>>
>> Signed-off-by: Javier Martinez Canillas
>
> Acked-by: Liviu Dudau
>
Thanks! I've pushed this to drm-m
+regressions
On 7/10/2023 04:58, Thomas Zimmermann wrote:
Hi
Am 10.07.23 um 11:52 schrieb Javier Martinez Canillas:
Thomas Zimmermann writes:
Hello Thomas,
Generate a hotplug event after registering a client to allow the
client to configure its display. Remove the hotplug calls from the
exi
On 7/7/2023 5:34 PM, Dmitry Baryshkov wrote:
On 08/07/2023 02:52, Kuogee Hsieh wrote:
EV_HPD_INIT_SETUP flag is used to trigger the initialization of external
DP host controller. Since external DP host controller initialization had
been incorporated into pm_runtime_resume(), this flag become o
Hello Keith,
+
+static void vs_plane_atomic_update(struct drm_plane *plane,
+ struct drm_atomic_state *state)
+{
+ struct drm_plane_state *new_state =
drm_atomic_get_new_plane_state(state,
+
On Wed, Apr 12, 2023 at 11:55:09AM +0200, Cyril Brulebois wrote:
> Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
> as spotted by Frédéric Bonnard, the historical "of-display" device is
> gone: the updated logic creates "of-display.0" instead, then as many
> "of-display.
On Wed, Apr 12, 2023 at 11:55:08AM +0200, Cyril Brulebois wrote:
> Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
> as spotted by Frédéric Bonnard, the historical "of-display" device is
> gone: the updated logic creates "of-display.0" instead, then as many
> "of-display.
On Mon, Jul 10, 2023 at 5:22 PM Thomas Zimmermann wrote:
>
> I'll append a patch to the series that documents this.
>
> Sure.
Thanks!
If you are planning to take it into some other tree:
Acked-by: Miguel Ojeda
Otherwise, I can take it into the `auxdisplay` tree.
Cheers,
Miguel
On 7/8/2023 7:52 PM, Bjorn Andersson wrote:
On Fri, Jul 07, 2023 at 04:52:20PM -0700, Kuogee Hsieh wrote:
Incorporating pm runtime framework into DP driver so that power
and clock resource handling can be centralized allowing easier
control of these resources in preparation of registering aux
On 7/7/2023 5:04 PM, Dmitry Baryshkov wrote:
On 08/07/2023 02:52, Kuogee Hsieh wrote:
Incorporating pm runtime framework into DP driver so that power
and clock resource handling can be centralized allowing easier
control of these resources in preparation of registering aux bus
uring probe.
Si
Hi
Am 10.07.23 um 16:24 schrieb Miguel Ojeda:
On Mon, Jul 10, 2023 at 3:01 PM Thomas Zimmermann wrote:
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
not set it.
`framebuffer_alloc()` does indeed use `kzal
Hi Aradhya,
On Tue, Jun 06, 2023 at 01:51:39PM +0530, Aradhya Bhatia wrote:
> With new connector model, sii902x will not create the connector, when
> DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and SoC driver will rely on format
> negotiation to setup the encoder format.
>
> Support format negotiations
On Mon, Jul 10, 2023 at 3:01 PM Thomas Zimmermann wrote:
>
> The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
> fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
> not set it.
`framebuffer_alloc()` does indeed use `kzalloc()`, but the docs do not
mention the zero
Hi!
On Mon, 2023-07-10 at 16:04 +0200, Thomas Zimmermann wrote:
> > > I won't argue with that, but the flag itself is wrong.
> > > FBINFO_FLAG_DEFAULT is/was for struct fb_info.flags. You have struct
> > > fb_videomode.flag. The valid flags for this field are at [1]. If
> > > anything, the field c
Hi
Am 10.07.23 um 15:59 schrieb John Paul Adrian Glaubitz:
Hi Thomas!
On Mon, 2023-07-10 at 15:52 +0200, Thomas Zimmermann wrote:
I would argue that the current code is more readable that your proposed change.
I agree that it's a no-op, but code is not just about functionality but also
readab
Hi Thomas!
On Mon, 2023-07-10 at 15:52 +0200, Thomas Zimmermann wrote:
> > I would argue that the current code is more readable that your proposed
> > change.
> >
> > I agree that it's a no-op, but code is not just about functionality but also
> > readability, isn't it?
>
> I won't argue with t
Hi
Am 10.07.23 um 15:42 schrieb John Paul Adrian Glaubitz:
Hi Thomas!
On Mon, 2023-07-10 at 14:50 +0200, Thomas Zimmermann wrote:
FBINFO_FLAG_DEFAULT is a flag for a framebuffer in struct fb_info.
Flags for videomodes are prefixed with FB_MODE_. FBINFO_FLAG_DEFAULT
is 0 and the static declarat
Hi,
On 2023/7/10 18:26, Jani Nikula wrote:
On Mon, 10 Jul 2023, Sui Jingfeng wrote:
When accessing I/O memory, we should pass '__iomem *' type instead of
'void *' simply, otherwise sparse tests will complain. After applied
this patch, the following two sparse warnings got fixed.
Usually the c
Hi Thomas!
On Mon, 2023-07-10 at 14:50 +0200, Thomas Zimmermann wrote:
> FBINFO_FLAG_DEFAULT is a flag for a framebuffer in struct fb_info.
> Flags for videomodes are prefixed with FB_MODE_. FBINFO_FLAG_DEFAULT
> is 0 and the static declaration already clears the memory area of
> sh7763fb_videomod
1 - 100 of 233 matches
Mail list logo
