Re: [PATCH v4 12/18] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-15 Thread Greg Kroah-Hartman
On Sat, Jul 15, 2023 at 08:51:54PM +0200, Thomas Zimmermann wrote: > The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct > fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do > not set it. > > Flags should signal differences from the default values. After cleaning > up

Re: [syzbot] [dri?] KMSAN: uninit-value in drm_mode_setcrtc

2023-07-15 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-and-tested-by: syzbot+4fad2e57beb6397ab...@syzkaller.appspotmail.com Tested on: commit: d1d7f15c DO-NOT-SUBMIT: kmsan: add the kmsan_exceed_ma.. git tree: https://github.com/google/

[PATCH] drm/crtc: Fix uninit-value bug in drm_mode_setcrtc

2023-07-15 Thread Ziqi Zhao
The connector_set contains uninitialized values when allocated with kmalloc_array. However, in the "out" branch, the logic assumes that any element in connector_set would be equal to NULL if failed to initialize, which causes the bug reported by Syzbot. The fix is to use an extra variable to keep t

[PATCH] drm/connector: mark enum counter value as private

2023-07-15 Thread Randy Dunlap
Mark the DRM_MODE_COLORIMETRY_COUNT enum value as private in kernel-doc to prevent a build warning: include/drm/drm_connector.h:527: warning: Enum value 'DRM_MODE_COLORIMETRY_COUNT' not described in enum 'drm_colorspace' Fixes: c627087cb164 ("drm/connector: Use common colorspace_names array") Si

Re: [PATCH] phy: Explicitly include correct DT includes

2023-07-15 Thread Heiko Stuebner
Am Freitag, 14. Juli 2023, 19:48:35 CEST schrieb Rob Herring: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each ot

[PATCH v4 16/18] fbdev/pxafb: Remove flag FBINFO_FLAG_DEFAULT

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix co

[PATCH v4 17/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT

2023-07-15 Thread Thomas Zimmermann
Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Helge Deller --- include/linux/fb.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 1d5c13f34b0

[PATCH v4 12/18] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * f

[PATCH v4 11/18] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit

[PATCH v4 09/18] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * f

[PATCH v4 14/18] fbdev: Remove FBINFO_FLAG_DEFAULT from framebuffer_alloc()'ed structs

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v4: * c

[PATCH v4 18/18] fbdev: Document that framebuffer_alloc() returns zero'ed data

2023-07-15 Thread Thomas Zimmermann
Most fbdev drivers depend on framebuffer_alloc() to initialize the allocated memory to 0. Document this guarantee. v3: * slightly reword the sentence (Miguel) Suggested-by: Miguel Ojeda Signed-off-by: Thomas Zimmermann Reviewed-by: Miguel Ojeda Reviewed-by: Sui Jingfeng Cc: Helge Dell

[PATCH v4 05/18] fbdev: Remove FBINFO_DEFAULT from framebuffer_alloc()'ed structs

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v4: * clarif

[PATCH v4 15/18] fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by a static declaration. So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: *

[PATCH v4 08/18] sh: mach-sh7763rdp: Assign FB_MODE_IS_UNKNOWN to struct fb_videomode.flag

2023-07-15 Thread Thomas Zimmermann
Assign FB_MODE_IS_UNKNOWN to sh7763fb_videomode.flag instead of FBINFO_FLAG_DEFAULT. Both are 0, so the stored value does not change. FBINFO_FLAG_DEFAULT is a flag for a framebuffer in struct fb_info. Flags for videomodes are prefixed with FB_MODE_. v3: * include board name in commit mess

[PATCH v4 07/18] vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix co

[PATCH v4 03/18] fbdev: Remove FBINFO_DEFAULT from kzalloc()'ed structs

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v4: * clarify commit m

[PATCH v4 06/18] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by dmam_alloc_coherent(__GFP_ZERO). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2:

[PATCH v4 13/18] fbdev: Remove FBINFO_FLAG_DEFAULT from kzalloc()'ed structs

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v4: * clarify com

[PATCH v4 10/18] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * f

[PATCH v4 00/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags

2023-07-15 Thread Thomas Zimmermann
Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from fbdev and drivers, as briefly discussed at [1]. Both flags were maybe useful when fbdev had special handling for driver modules. With commit 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE"), they are both 0 and have no further effect. P

[PATCH v4 02/18] fbdev: Remove FBINFO_DEFAULT from static structs

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by a static declaration. So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v4: * clari

[PATCH v4 04/18] fbdev: Remove FBINFO_DEFAULT from devm_kzalloc()'ed structs

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v4: * clarify com

[PATCH v4 01/18] drm: Remove flag FBINFO_DEFAULT from fbdev emulation

2023-07-15 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix co

Re: [PATCH] fb: Explicitly include correct DT includes

2023-07-15 Thread Thomas Zimmermann
Hi Am 14.07.23 um 19:50 schrieb Rob Herring: The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include

[PATCH v5] Documentation/gpu: Add a VM_BIND async draft document

2023-07-15 Thread Thomas Hellström
Add a motivation for and description of asynchronous VM_BIND operation v2: - Fix typos (Nirmoy Das) - Improve the description of a memory fence (Oak Zeng) - Add a reference to the document in the Xe RFC. - Add pointers to sample uAPI suggestions v3: - Address review comments (Danilo Krummrich) - F

Re: [PATCH v2 0/2] DSIPHY RPM

2023-07-15 Thread Konrad Dybcio
On 11.07.2023 18:31, Dmitry Baryshkov wrote: > On 11/07/2023 17:21, Dmitry Baryshkov wrote: >> >> On Tue, 20 Jun 2023 13:43:19 +0200, Konrad Dybcio wrote: >>> Some recent SoCs use power rails that we model as GENPDs to power the >>> DSIPHY. This series attempts to make such configurations suspendab

Re: [PATCH 02/14] dt-bindings: display/msm/gmu: Allow passing QMP handle

2023-07-15 Thread Konrad Dybcio
On 4.07.2023 10:29, Krzysztof Kozlowski wrote: > On 28/06/2023 22:35, Konrad Dybcio wrote: >> When booting the GMU, the QMP mailbox should be pinged about some tunables >> (e.g. adaptive clock distribution state). To achieve that, a reference to >> it is necessary. Allow it and require it with A730

Re: [PATCH 4/5] arm64: dts: qcom: qrb5165-rb5: enable displayport controller

2023-07-15 Thread Konrad Dybcio
On 9.07.2023 06:19, Dmitry Baryshkov wrote: > Enable the onboard displayport controller, connect it to QMP PHY. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 13 + > 1 file changed, 13 insertions(+) > > dif

Re: [PATCH v3 00/19] Sitronix ST7789V improvements

2023-07-15 Thread Miquel Raynal
Hi Sebastian, + Thomas s...@kernel.org wrote on Fri, 14 Jul 2023 03:37:37 +0200: > Hi, > > This adds panel support for Inanbo T28CP45TN89, which I found inside of a > handheld thermal camera. The panel is based on the st7789v controller. All > information is based on reverse engineering. I also

Re: [BUG]: Getting a unique connector name when identical displays are connected

2023-07-15 Thread Freelancer Intern
I have also seen this case... On Thu, Jul 13, 2023, 1:14 PM SUNIDHI DIXIT wrote: > Hello all, > > This is regarding an issue I have encountered recently in drm. When I > connect two identical HDMI display(with same resolution) there is no way to > distinguish them uniquely. > > I looked into tha

Re: [PATCH 2/3] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-07-15 Thread alyssa
15 July 2023 at 00:03, "Luben Tuikov" wrote: > > On 2023-07-14 05:57, Christian König wrote: > > > > > Am 14.07.23 um 11:49 schrieb Asahi Lina: > > > > > > > > On 14/07/2023 17.43, Christian König wrote: > > > > > > > Am 14.07.23 um 10:21 schrieb Asahi Lina: > > A signaled scheduler fen

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #5 from popus_czy_to_ty (pentelja...@o2.pl) --- https://www.youtube.com/shorts/vuCrMdrtGdU - video of symptom BOE NV156FHM-N4G -display model NVIDIA-SMI 525.125.06 Driver Version: 525.125.06 CUDA Version: 12.0 -- You may reply to

Re: [PATCH 12/12] drm/msm/adreno: Switch to chip-id for identifying GPU

2023-07-15 Thread Rob Clark
On Sat, Jul 15, 2023 at 6:38 AM Konrad Dybcio wrote: > > On 7.07.2023 18:08, Rob Clark wrote: > > On Thu, Jul 6, 2023 at 5:25 PM Konrad Dybcio > > wrote: > >> > >> On 6.07.2023 23:10, Rob Clark wrote: > >>> From: Rob Clark > >>> > >>> Since the revision becomes an opaque identifier with future

Re: [PATCH 12/12] drm/msm/adreno: Switch to chip-id for identifying GPU

2023-07-15 Thread Konrad Dybcio
On 7.07.2023 18:08, Rob Clark wrote: > On Thu, Jul 6, 2023 at 5:25 PM Konrad Dybcio wrote: >> >> On 6.07.2023 23:10, Rob Clark wrote: >>> From: Rob Clark >>> >>> Since the revision becomes an opaque identifier with future GPUs, move >>> away from treating different ranges of bits as having a give

Re: [PATCH v2 7/8] drm/msm/mdss: Handle the reg bus ICC path

2023-07-15 Thread Konrad Dybcio
On 12.07.2023 14:11, Dmitry Baryshkov wrote: > Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there's > another path that needs to be handled to ensure MDSS functions properly, > namely the "reg bus", a.k.a the CPU-MDSS interconnect. > > Gating that path may have a variety of effects,

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-15 Thread Conor Dooley
Hey Sarah, Your series does not appear to be threaded. `git send-email` can be passed, for example, a directory containing a whole series & will set the correct in-reply-to headers so that the series is in a single thread. On Fri, Jul 14, 2023 at 03:25:26PM +0100, Sarah Walker wrote: > Add the de

Re: [PATCH] phy: Explicitly include correct DT includes

2023-07-15 Thread Sergio Paracuellos
On Fri, Jul 14, 2023 at 7:49 PM Rob Herring wrote: > > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. The

Re: [PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: : trailing statements should be on next line

2023-07-15 Thread Karol Herbst
On Sat, Jul 15, 2023 at 1:07 AM Lyude Paul wrote: > > NAK - checkpatch.pl is a (strongish) guideline, but not a rule. In the cases > corrected in the patch series here, we format the switch cases on single lines > as it dramatically improves the readability of what is otherwise just a /long/ > lis

[PATCH] fbdev: au1200fb: Fix missing IRQ check in au1200fb_drv_probe

2023-07-15 Thread Zhang Shurong
This func misses checking for platform_get_irq()'s call and may passes the negative error codes to request_irq(), which takes unsigned IRQ #, causing it to fail with -EINVAL, overriding an original error code. Fix this by stop calling request_irq() with invalid IRQ #s. Fixes: 1630d85a8312 ("au120

[PATCH] drm: Explicitly include correct DT includes

2023-07-15 Thread Rob Herring
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there'

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-15 Thread Luben Tuikov
On 2023-07-14 04:21, Asahi Lina wrote: > drm_sched_fini() currently leaves any pending jobs dangling, which > causes segfaults and other badness when job completion fences are > signaled after the scheduler is torn down. If there are pending jobs, ideally we want to call into the driver, so that i