Re: [PATCH v2] drm/bridge: Add debugfs print for bridge chains

2023-07-23 Thread Alexander Stein
Hi Tomi, Am Freitag, 21. Juli 2023, 17:01:39 CEST schrieb Tomi Valkeinen: > DRM bridges are not visible to the userspace and it may not be > immediately clear if the chain is somehow constructed incorrectly. I > have had two separate instances of a bridge driver failing to do a >

Re: [PATCH] drm: bridge: samsung-dsim: Clean up a call to request_irq()

2023-07-23 Thread Alexander Stein
Hi, Am Freitag, 21. Juli 2023, 16:56:17 CEST schrieb Dan Carpenter: > This is calling request_threaded_irq() but the thread parameter is NULL > so it's actually not a threaded irq. Which is a bit misleading. Call > request_irq() instead. > > Signed-off-by: Dan Carpenter > --- >

Re: linux-next: build warning after merge of the drm tree

2023-07-23 Thread Stephen Rothwell
Hi all, On Wed, 12 Jul 2023 09:17:14 +1000 Stephen Rothwell wrote: > > On Thu, 30 Mar 2023 07:28:26 -0700 Rob Clark wrote: > > > > On Wed, Mar 29, 2023 at 8:28 PM Stephen Rothwell > > wrote: > > > > > > After merging the drm tree, today's linux-next build (htmldocs) produced > > > this

[PATCH] drm/radeon: Move assignment outside if condition

2023-07-23 Thread sunran001
Fixes the following checkpatch errors: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/radeon_legacy_tv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_legacy_tv.c

[PATCH] drm/radeon: that open brace { should be on the previous line

2023-07-23 Thread sunran001
ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/rv770_smc.c | 36 ++ 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/radeon/rv770_smc.c b/drivers/gpu/drm/radeon/rv770_smc.c

[PATCH] drm/radeon: that open brace { should be on the previous line

2023-07-23 Thread sunran001
ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/clearstate_si.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/clearstate_si.h b/drivers/gpu/drm/radeon/clearstate_si.h index

[PATCH] drm/radeon: add missing spaces after ',' and else should follow close brace '}'

2023-07-23 Thread sunran001
ERROR: else should follow close brace '}' ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/radeon_connectors.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c

[PATCH] drm/radeon: that open brace { should be on the previous line

2023-07-23 Thread sunran001
ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/ni_dpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/ni_dpm.c b/drivers/gpu/drm/radeon/ni_dpm.c index a101ba00ea30..1cf4de4cda23 100644 ---

[PATCH] drm/radeon: add missing spaces before ';'

2023-07-23 Thread sunran001
ERROR: space required after that ';' (ctx:BxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/radeon_vce.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c index ca4a36464340..d1871af967d4

[PATCH] drm/radeon/si_dpm: open brace '{' following struct go on the same line

2023-07-23 Thread sunran001
ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/sislands_smc.h | 51 +-- 1 file changed, 17 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/radeon/sislands_smc.h

RE: [PATCH V7 0/9] Enable Wifi RFI interference mitigation feature support

2023-07-23 Thread Quan, Evan
[AMD Official Use Only - General] Gentle ping on this series. Hi Rafael and Andrew, Can you help to check this latest series and share your thoughts if any? BR, Evan > -Original Message- > From: Quan, Evan > Sent: Wednesday, July 19, 2023 5:00 PM > To: raf...@kernel.org;

[PATCH] drm/ttm: check null pointer before accessing when swapping

2023-07-23 Thread Guchun Chen
Add a check to avoid null pointer dereference as below: [ 90.002283] general protection fault, probably for non-canonical address 0xdc00: [#1] PREEMPT SMP KASAN NOPTI [ 90.002292] KASAN: null-ptr-deref in range [0x-0x0007] [ 90.002346] ?

Re: [PATCH v6 07/11] drm/mediatek: dp: Avoid mutex locks if audio is not supported/enabled

2023-07-23 Thread 胡俊光

Re: [PATCH] Remove unnecessary calls to kmap{,_local_page}() when acquiring pages using GFP_DMA32.

2023-07-23 Thread Ira Weiny
Sumitra Sharma wrote: > The GFP_DMA32 uses the DMA32 zone to satisfy the allocation > requests. Therefore, pages allocated with GFP_DMA32 cannot > come from Highmem. > > Avoid using calls to kmap() / kunmap() as the kmap() is being > deprecated [1]. > > Avoid using calls to kmap_local_page() /

[PATCH AUTOSEL 4.14 9/9] drm/amdgpu: Fix potential fence use-after-free v2

2023-07-23 Thread Sasha Levin
From: shanzhulig [ Upstream commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 ] fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig Signed-off-by:

[PATCH AUTOSEL 4.19 9/9] drm/amdgpu: Fix potential fence use-after-free v2

2023-07-23 Thread Sasha Levin
From: shanzhulig [ Upstream commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 ] fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig Signed-off-by:

[PATCH AUTOSEL 5.4 10/12] drm/amdgpu: Fix potential fence use-after-free v2

2023-07-23 Thread Sasha Levin
From: shanzhulig [ Upstream commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 ] fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig Signed-off-by:

[PATCH AUTOSEL 5.10 13/16] drm/amdgpu: Fix potential fence use-after-free v2

2023-07-23 Thread Sasha Levin
From: shanzhulig [ Upstream commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 ] fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig Signed-off-by:

[PATCH AUTOSEL 5.15 17/24] drm/amdgpu: Fix potential fence use-after-free v2

2023-07-23 Thread Sasha Levin
From: shanzhulig [ Upstream commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 ] fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig Signed-off-by:

[PATCH AUTOSEL 6.1 23/34] drm/amdgpu: Fix potential fence use-after-free v2

2023-07-23 Thread Sasha Levin
From: shanzhulig [ Upstream commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 ] fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig Signed-off-by:

[PATCH AUTOSEL 6.4 25/40] drm/amdgpu: Fix potential fence use-after-free v2

2023-07-23 Thread Sasha Levin
From: shanzhulig [ Upstream commit 2e54154b9f27262efd0cb4f903cc7d5ad1fe9628 ] fence Decrements the reference count before exiting. Avoid Race Vulnerabilities for fence use-after-free. v2 (chk): actually fix the use after free and not just move it. Signed-off-by: shanzhulig Signed-off-by:

[PATCH AUTOSEL 4.19 01/11] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-07-23 Thread Sasha Levin
From: hackyzh002 [ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ] The type of size is unsigned, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later Reviewed-by: Christian

[PATCH AUTOSEL 4.14 1/9] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-07-23 Thread Sasha Levin
From: hackyzh002 [ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ] The type of size is unsigned, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later Reviewed-by: Christian

[PATCH AUTOSEL 5.4 01/12] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-07-23 Thread Sasha Levin
From: hackyzh002 [ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ] The type of size is unsigned, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later Reviewed-by: Christian

[PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-07-23 Thread Sasha Levin
From: Lang Yu [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] When using cpu to update page tables, vm update fences are unused. Install stub fence into these fence pointers instead of NULL to avoid NULL dereference when calling dma_fence_wait() on them. Suggested-by: Christian

[PATCH AUTOSEL 5.10 01/22] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-07-23 Thread Sasha Levin
From: hackyzh002 [ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ] The type of size is unsigned, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later Reviewed-by: Christian

[PATCH AUTOSEL 5.15 13/23] drm/amdgpu: install stub fence into potential unused fence pointers

2023-07-23 Thread Sasha Levin
From: Lang Yu [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] When using cpu to update page tables, vm update fences are unused. Install stub fence into these fence pointers instead of NULL to avoid NULL dereference when calling dma_fence_wait() on them. Suggested-by: Christian

[PATCH AUTOSEL 5.15 01/23] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-07-23 Thread Sasha Levin
From: hackyzh002 [ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ] The type of size is unsigned, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later Reviewed-by: Christian

[PATCH AUTOSEL 6.1 32/41] drm/amd/display: Enable dcn314 DPP RCO

2023-07-23 Thread Sasha Levin
From: Daniel Miess [ Upstream commit 17fbdbda9cc87ff5a013898de506212d25323ed7 ] [Why and How] Add back debug bits enabling RCO for dcn314 as underflow associated with this change has been resolved Acked-by: Stylon Wang Signed-off-by: Daniel Miess Reviewed-by: Jun Lei Tested-by: Daniel

[PATCH AUTOSEL 6.1 31/41] drm/amd/display: Skip DPP DTO update if root clock is gated

2023-07-23 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 30f90f3c1c2c63c2fa44f61233737d27b72637c2 ] [Why] Hardware implements root clock gating by utilizing the DPP DTO registers with a special case of DTO enabled, phase = 0, modulo = 1. This conflicts with our policy to always update the DPPDTO for cases

[PATCH AUTOSEL 6.1 28/41] Revert "drm/amd/display: Do not set drr on pipe commit"

2023-07-23 Thread Sasha Levin
From: Michel Dänzer [ Upstream commit 8e1b45c578b799510f9a01a9745a737e74f43cb1 ] This reverts commit 474f01015ffdb74e01c2eb3584a2822c64e7b2be. Caused a regression: Samsung Odyssey Neo G9, running at 5120x1440@240/VRR, connected to Navi 21 via DisplayPort, blanks and the GPU hangs while

[PATCH AUTOSEL 6.1 27/41] drm/amd/display: Apply 60us prefetch for DCFCLK <= 300Mhz

2023-07-23 Thread Sasha Levin
From: Alvin Lee [ Upstream commit 7e60ab4eb3e4ba2adac46d737fdbbc5732bebd58 ] [Description] - Previously we wanted to apply extra 60us of prefetch for min DCFCLK (200Mhz), but DCFCLK can be calculated to be 201Mhz which underflows also without the extra prefetch - Instead, apply the the

[PATCH AUTOSEL 6.1 26/41] drm/amdgpu: install stub fence into potential unused fence pointers

2023-07-23 Thread Sasha Levin
From: Lang Yu [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] When using cpu to update page tables, vm update fences are unused. Install stub fence into these fence pointers instead of NULL to avoid NULL dereference when calling dma_fence_wait() on them. Suggested-by: Christian

[PATCH AUTOSEL 6.1 12/41] drm: rcar-du: remove R-Car H3 ES1.* workarounds

2023-07-23 Thread Sasha Levin
From: Wolfram Sang [ Upstream commit 2da4b728f994a1f9189a8066b0be90b615768764 ] R-Car H3 ES1.* was only available to an internal development group and needed a lot of quirks and workarounds. These become a maintenance burden now, so our development group decided to remove upstream support for

[PATCH AUTOSEL 6.1 11/41] drm/stm: ltdc: fix late dereference check

2023-07-23 Thread Sasha Levin
From: Raphael Gallais-Pou [ Upstream commit 898a9e3f56db9860ab091d4bf41b6caa99aafc3d ] In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a container_of() before the pointer check. This could cause a kernel panic. Fix this smatch warning: drivers/gpu/drm/stm/ltdc.c:1124

[PATCH AUTOSEL 6.1 04/41] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

2023-07-23 Thread Sasha Levin
From: hackyzh002 [ Upstream commit 87c2213e85bd81e4a9a4d0880c256568794ae388 ] The type of size is unsigned int, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later. Reviewed-by:

[PATCH AUTOSEL 6.1 05/41] drm/amdgpu: fix memory leak in mes self test

2023-07-23 Thread Sasha Levin
From: Jack Xiao [ Upstream commit 31d7c3a4fc3d312a0646990767647925d5bde540 ] The fences associated with mes queue have to be freed up during amdgpu_ring_fini. Signed-off-by: Jack Xiao Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.1 03/41] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-07-23 Thread Sasha Levin
From: hackyzh002 [ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ] The type of size is unsigned, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later Reviewed-by: Christian

[PATCH AUTOSEL 6.1 02/41] drm/amdgpu: fix calltrace warning in amddrm_buddy_fini

2023-07-23 Thread Sasha Levin
From: Longlong Yao [ Upstream commit 01382501509871d0799bab6bd412c228486af5bf ] The following call trace is observed when removing the amdgpu driver, which is caused by that BOs allocated for psp are not freed until removing. [61811.450562] RIP: 0010:amddrm_buddy_fini.cold+0x29/0x47

[PATCH AUTOSEL 6.1 01/41] drm/amd/display: Do not set drr on pipe commit

2023-07-23 Thread Sasha Levin
From: Wesley Chalmers [ Upstream commit e101bf95ea87ccc03ac2f48dfc0757c6364ff3c7 ] [WHY] Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a pipe commit can cause underflow. [HOW] Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets optimized_required.

[PATCH AUTOSEL 6.4 49/58] drm/amd/display: Enable dcn314 DPP RCO

2023-07-23 Thread Sasha Levin
From: Daniel Miess [ Upstream commit 17fbdbda9cc87ff5a013898de506212d25323ed7 ] [Why and How] Add back debug bits enabling RCO for dcn314 as underflow associated with this change has been resolved Acked-by: Stylon Wang Signed-off-by: Daniel Miess Reviewed-by: Jun Lei Tested-by: Daniel

[PATCH AUTOSEL 6.4 48/58] drm/amd/display: Skip DPP DTO update if root clock is gated

2023-07-23 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 30f90f3c1c2c63c2fa44f61233737d27b72637c2 ] [Why] Hardware implements root clock gating by utilizing the DPP DTO registers with a special case of DTO enabled, phase = 0, modulo = 1. This conflicts with our policy to always update the DPPDTO for cases

[PATCH AUTOSEL 6.4 45/58] drm/amdgpu: unmap and remove csa_va properly

2023-07-23 Thread Sasha Levin
From: Lang Yu [ Upstream commit 5daff15cd013422bc6d1efcfe82b586800025384 ] Root PD BO should be reserved before unmap and remove a bo_va from VM otherwise lockdep will complain. v2: check fpriv->csa_va is not NULL instead of amdgpu_mcbp (christian) [14616.936827] WARNING: CPU: 6 PID: 1711 at

[PATCH AUTOSEL 6.4 44/58] drm/amd/pm: Fill metrics data for SMUv13.0.6

2023-07-23 Thread Sasha Levin
From: Lijo Lazar [ Upstream commit 1718e973e3d23b653cd77994073a9deda3875689 ] Populate metrics data table for SMU v13.0.6. Add PCIe link speed/width information also. Signed-off-by: Lijo Lazar Reviewed-by: Le Ma Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.4 42/58] Revert "drm/amd/display: Do not set drr on pipe commit"

2023-07-23 Thread Sasha Levin
From: Michel Dänzer [ Upstream commit 360930985ec9f394c82ba0b235403b4a366d1560 ] This reverts commit e101bf95ea87ccc03ac2f48dfc0757c6364ff3c7. Caused a regression: Samsung Odyssey Neo G9, running at 5120x1440@240/VRR, connected to Navi 21 via DisplayPort, blanks and the GPU hangs while

[PATCH AUTOSEL 6.4 41/58] drm/amd/display: Apply 60us prefetch for DCFCLK <= 300Mhz

2023-07-23 Thread Sasha Levin
From: Alvin Lee [ Upstream commit 7e60ab4eb3e4ba2adac46d737fdbbc5732bebd58 ] [Description] - Previously we wanted to apply extra 60us of prefetch for min DCFCLK (200Mhz), but DCFCLK can be calculated to be 201Mhz which underflows also without the extra prefetch - Instead, apply the the

[PATCH AUTOSEL 6.4 40/58] drm/amd/display: Trigger DIO FIFO resync on commit streams

2023-07-23 Thread Sasha Levin
From: Saaem Rizvi [ Upstream commit 3e8d74cb128fb1a4d56270ffbecea6056c55739a ] [WHY] Currently, there is an intermittent issue where a screen can either go blank or be corrupted. [HOW] To resolve the issue we trigger the ramping logic for DIO FIFO so that it goes back up to the correct speed.

[PATCH AUTOSEL 6.4 39/58] drm/amd/display: Remove v_startup workaround for dcn3+

2023-07-23 Thread Sasha Levin
From: Daniel Miess [ Upstream commit 3a31e8b89b7240d9a17ace8a1ed050bdcb560f9e ] [Why] Calls to dcn20_adjust_freesync_v_startup are no longer needed as of dcn3+ and can cause underflow in some cases [How] Move calls to dcn20_adjust_freesync_v_startup up into validate_bandwidth for dcn2.x

[PATCH AUTOSEL 6.4 38/58] drm/amdgpu: install stub fence into potential unused fence pointers

2023-07-23 Thread Sasha Levin
From: Lang Yu [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] When using cpu to update page tables, vm update fences are unused. Install stub fence into these fence pointers instead of NULL to avoid NULL dereference when calling dma_fence_wait() on them. Suggested-by: Christian

[PATCH AUTOSEL 6.4 32/58] accel/habanalabs: fix mem leak in capture user mappings

2023-07-23 Thread Sasha Levin
From: Moti Haimovski [ Upstream commit 314a7ffd7c196b27eedd50cb7553029e17789b55 ] This commit fixes a memory leak caused when clearing the user_mappings info when a new context is opened immediately after user_mapping is captured and a hard reset is performed. Signed-off-by: Moti Haimovski

[PATCH AUTOSEL 6.4 31/58] accel/habanalabs: add pci health check during heartbeat

2023-07-23 Thread Sasha Levin
From: Ofir Bitton [ Upstream commit d8b9cea584661b30305cf341bf9f675dc0a25471 ] Currently upon a heartbeat failure, we don't know if the failure is due to firmware hang or due to a bad PCI link. Hence, we are reading a PCI config space register with a known value (vendor ID) so we will know

[PATCH AUTOSEL 6.4 18/58] drm: rcar-du: remove R-Car H3 ES1.* workarounds

2023-07-23 Thread Sasha Levin
From: Wolfram Sang [ Upstream commit 2da4b728f994a1f9189a8066b0be90b615768764 ] R-Car H3 ES1.* was only available to an internal development group and needed a lot of quirks and workarounds. These become a maintenance burden now, so our development group decided to remove upstream support for

[PATCH AUTOSEL 6.4 16/58] drm/stm: ltdc: fix late dereference check

2023-07-23 Thread Sasha Levin
From: Raphael Gallais-Pou [ Upstream commit 898a9e3f56db9860ab091d4bf41b6caa99aafc3d ] In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a container_of() before the pointer check. This could cause a kernel panic. Fix this smatch warning: drivers/gpu/drm/stm/ltdc.c:1124

[PATCH AUTOSEL 6.4 08/58] Revert "drm/amd/display: disable SubVP + DRR to prevent underflow"

2023-07-23 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit f38129bb081758176dd78304faaee95007fb8838 ] This reverts commit 80c6d6804f31451848a3956a70c2bcb1f07cfcb0. The orignal commit was intended as a workaround to prevent underflow and flickering when using one normal monitor and the other high refresh rate

[PATCH AUTOSEL 6.4 07/58] drm/amdgpu: fix memory leak in mes self test

2023-07-23 Thread Sasha Levin
From: Jack Xiao [ Upstream commit 31d7c3a4fc3d312a0646990767647925d5bde540 ] The fences associated with mes queue have to be freed up during amdgpu_ring_fini. Signed-off-by: Jack Xiao Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.4 06/58] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

2023-07-23 Thread Sasha Levin
From: hackyzh002 [ Upstream commit 87c2213e85bd81e4a9a4d0880c256568794ae388 ] The type of size is unsigned int, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later. Reviewed-by:

[PATCH AUTOSEL 6.4 05/58] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-07-23 Thread Sasha Levin
From: hackyzh002 [ Upstream commit f828b681d0cd566f86351c0b913e6cb6ed8c7b9c ] The type of size is unsigned, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later Reviewed-by: Christian

[PATCH AUTOSEL 6.4 04/58] drm/amdgpu: fix calltrace warning in amddrm_buddy_fini

2023-07-23 Thread Sasha Levin
From: Longlong Yao [ Upstream commit 01382501509871d0799bab6bd412c228486af5bf ] The following call trace is observed when removing the amdgpu driver, which is caused by that BOs allocated for psp are not freed until removing. [61811.450562] RIP: 0010:amddrm_buddy_fini.cold+0x29/0x47

[PATCH AUTOSEL 6.4 03/58] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

2023-07-23 Thread Sasha Levin
From: Danilo Krummrich [ Upstream commit 96c7c2f4d5bd94b15fe63448c087f01607b56f4a ] It already happend a few times that patches slipped through which implemented access to an entity through a job that was already removed from the entities queue. Since jobs and entities might have different

[PATCH AUTOSEL 6.4 02/58] drm/amd/display: Update DTBCLK for DCN32

2023-07-23 Thread Sasha Levin
From: Alvin Lee [ Upstream commit 128c1ca0303fe764a4cde5f761e72810d9e40b6e ] [Why] - Implement interface to program DTBCLK DTO’s according to reference DTBCLK returned by PMFW - This is required because DTO programming requires exact DTBCLK reference freq or it could result in underflow

[PATCH AUTOSEL 6.4 01/58] drm/amd/display: Do not set drr on pipe commit

2023-07-23 Thread Sasha Levin
From: Wesley Chalmers [ Upstream commit e101bf95ea87ccc03ac2f48dfc0757c6364ff3c7 ] [WHY] Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a pipe commit can cause underflow. [HOW] Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets optimized_required.

Re: [PATCH drm-misc-next v8 11/12] drm/nouveau: implement new VM_BIND uAPI

2023-07-23 Thread Dave Airlie
On Sun, 23 Jul 2023 at 01:12, Faith Ekstrand wrote: > > On Wed, Jul 19, 2023 at 7:15 PM Danilo Krummrich wrote: >> >> This commit provides the implementation for the new uapi motivated by the >> Vulkan API. It allows user mode drivers (UMDs) to: >> >> 1) Initialize a GPU virtual address (VA)

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

2023-07-23 Thread Marek Vasut
On 7/18/23 21:33, Doug Anderson wrote: Hi, On Tue, Jul 18, 2023 at 10:37 AM Marek Vasut wrote: On 7/18/23 18:15, Doug Anderson wrote: Hi, Hi, On Tue, Jul 18, 2023 at 8:36 AM Marek Vasut wrote: On 7/18/23 16:17, Doug Anderson wrote: Hi, Hi, On Sun, Jul 9, 2023 at 6:52 AM Marek

Re: [PATCH v2] drm/vkms: Implement all blend mode properties

2023-07-23 Thread Maira Canal
Hi Melissa, On 7/23/23 18:00, Melissa Wen wrote: On 07/23, Maíra Canal wrote: Following the DRM assumption, VKMS currently assumes that the alpha is pre-multiplied. Moreover, it doesn't support the alpha property. So, first, implement the alpha property to VKMS and then, the blend mode

Re: [PATCH v2] drm/vkms: Implement all blend mode properties

2023-07-23 Thread Melissa Wen
On 07/23, Maíra Canal wrote: > Following the DRM assumption, VKMS currently assumes that the alpha is > pre-multiplied. Moreover, it doesn't support the alpha property. > > So, first, implement the alpha property to VKMS and then, the blend > mode property. In order to support all possible

Re: [PATCH v2 1/2] drm/mipi-dbi: Lock SPI bus before setting D/C GPIO

2023-07-23 Thread Noralf Trønnes
On 7/20/23 12:26, Otto Pflüger wrote: > Multiple displays may be connected to the same bus and share a D/C GPIO, > so the display driver needs exclusive access to the bus to ensure that > it can control the D/C GPIO safely. > > Signed-off-by: Otto Pflüger > --- >

Re: [PATCH v5 2/2 RESEND] drm: panel: Add novatek nt35596s panel driver

2023-07-23 Thread Linus Walleij
Hi Arnaud & Molly, overall the driver looks very good! On Wed, Jul 19, 2023 at 5:20 PM Arnaud Ferraris wrote: > From: Molly Sophia > > Novatek NT35596s is a generic DSI IC that drives command and video mode > panels. Add the driver for it. Currently add support for the LCD panel > from JDI

[PATCH v4 16/17] arm64: dts: qcom: sm6125: Add display hardware nodes

2023-07-23 Thread Marijn Suijten
Add the DT nodes that describe the MDSS hardware on SM6125, containing one MDP (display controller) together with a single DSI and DSI PHY. No DisplayPort support is added for now. Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Marijn Suijten ---

[PATCH v4 15/17] arm64: dts: qcom: sm6125: Add dispcc node

2023-07-23 Thread Marijn Suijten
Enable and configure the dispcc node on SM6125 for consumption by MDSS later on. Signed-off-by: Marijn Suijten --- arch/arm64/boot/dts/qcom/sm6125.dtsi | 29 + 1 file changed, 29 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi

[PATCH v4 17/17] arm64: dts: qcom: sm6125-seine: Configure MDSS, DSI and panel

2023-07-23 Thread Marijn Suijten
Enable MDSS and DSI, and configure the Samsung SOFEF01-M ams597ut01 6.0" 1080x2520 panel. Reviewed-by: Konrad Dybcio Signed-off-by: Marijn Suijten --- .../dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 59 ++ 1 file changed, 59 insertions(+) diff --git

[PATCH v4 14/17] arm64: dts: qcom: sm6125: Switch fixed xo_board clock to RPM XO clock

2023-07-23 Thread Marijn Suijten
We have a working RPM XO clock; no other driver except rpmcc should be parenting directly to the fixed-factor xo_board clock nor should it be reachable by that global name. Remove the name to that effect, so that every clock relation is explicitly defined in DTS. Reviewed-by: Konrad Dybcio

[PATCH v4 13/17] drm/msm/dsi: Reuse QCM2290 14nm DSI PHY configuration for SM6125

2023-07-23 Thread Marijn Suijten
SM6125 features only a single PHY (despite a secondary PHY PLL source being available to the disp_cc_mdss_pclk0_clk_src clock), and downstream sources for this "trinket" SoC do not define the typical "vcca" regulator to be available nor used. This, including the register offset is identical to

[PATCH v4 12/17] dt-bindings: msm: dsi-phy-14nm: Document SM6125 variant

2023-07-23 Thread Marijn Suijten
Document availability of the 14nm DSI PHY on SM6125. Note that this compatible uses the SoC-suffix variant, intead of postfixing an arbitrary number without the sm/sdm portion. The PHY is not powered by a vcca regulator like on most SoCs, but by the MX power domain that is provided via the

[PATCH v4 11/17] drm/msm/mdss: Add SM6125 support

2023-07-23 Thread Marijn Suijten
SM6125 has an UBWC 3.0 decoder but only an UBWC 1.0 encoder. Reviewed-by: Dmitry Baryshkov Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/msm_mdss.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index

[PATCH v4 10/17] drm/msm/dpu: Add SM6125 support

2023-07-23 Thread Marijn Suijten
Add definitions for the display hardware used on the Qualcomm SM6125 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Marijn Suijten --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_5_4_sm6125.h | 236 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 7 +

[PATCH v4 07/17] dt-bindings: display/msm: dsi-controller-main: Document SM6125

2023-07-23 Thread Marijn Suijten
Document general compatibility of the DSI controller on SM6125. Reviewed-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov Signed-off-by: Marijn Suijten --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v4 08/17] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-07-23 Thread Marijn Suijten
SM6125 is identical to SM6375 including the throttle clock that is also provided to the MDP node downstream. Note that any SoC other than SM6375 (currently SC7180 and SM6350) has an unconstrained maximum number of clocks and could either pass or leave out this "throttle" clock. Signed-off-by:

[PATCH v4 09/17] dt-bindings: display/msm: Add SM6125 MDSS

2023-07-23 Thread Marijn Suijten
Document the SM6125 MDSS. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Marijn Suijten --- .../bindings/display/msm/qcom,sm6125-mdss.yaml | 213 + 1 file changed, 213 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml

[PATCH v4 05/17] dt-bindings: clock: qcom,dispcc-sm6125: Require GCC PLL0 DIV clock

2023-07-23 Thread Marijn Suijten
The "gcc_disp_gpll0_div_clk_src" clock is consumed by the driver, will be passed from DT, and should be required by the bindings. Fixes: 8397c9c0c26b ("dt-bindings: clock: add QCOM SM6125 display clock bindings") Reviewed-by: Rob Herring Signed-off-by: Marijn Suijten ---

[PATCH v4 03/17] arm64: dts: qcom: sm6125: Sort spmi_bus node numerically by reg

2023-07-23 Thread Marijn Suijten
This node has always resided in the wrong spot, making it somewhat harder to contribute new node entries while maintaining proper sorting around it. Move the node up to sit after hsusb_phy1 where it maintains proper numerical sorting on the (first of its many) reg address property. Fixes:

[PATCH v4 06/17] dt-bindings: clock: qcom,dispcc-sm6125: Allow power-domains property

2023-07-23 Thread Marijn Suijten
On SM6125 the dispcc block is gated behind VDDCX: allow this domain to be configured. Acked-by: Krzysztof Kozlowski Signed-off-by: Marijn Suijten --- .../devicetree/bindings/clock/qcom,dispcc-sm6125.yaml| 16 1 file changed, 16 insertions(+) diff --git

[PATCH v4 02/17] arm64: dts: qcom: sm6125: Pad APPS IOMMU address to 8 characters

2023-07-23 Thread Marijn Suijten
APPS IOMMU is the only node in sm6125.dtsi that doesn't have its address padded to 8 hexadecimals; fix this by prepending a 0. Fixes: 8ddb4bc3d3b5 ("arm64: dts: qcom: sm6125: Configure APPS SMMU") Signed-off-by: Marijn Suijten --- arch/arm64/boot/dts/qcom/sm6125.dtsi | 2 +- 1 file changed, 1

[PATCH v4 04/17] dt-bindings: display/msm: Remove DSI1 ports from SM6350/SM6375 example

2023-07-23 Thread Marijn Suijten
Both SM6350 and SM6375 support only a single DSI link, and don't have a corresponding dsi1 node in DTS. Their examples should not suggest an output interface port on the display-controller node to this inexistant DSI host, with a dsi1_in label reference that doesn't exist in the example either.

[PATCH v4 00/17] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel

2023-07-23 Thread Marijn Suijten
Bring up the SM6125 DPU now that all preliminary series (such as INTF TE) have been merged (for me to test the hardware properly), and most other conflicting work (barring ongoing catalog *improvements*) has made its way in as well or is still being discussed. The second part of the series

[PATCH v4 01/17] drm/msm/dsi: Drop unused regulators from QCM2290 14nm DSI PHY config

2023-07-23 Thread Marijn Suijten
The regulator setup was likely copied from other SoCs by mistake. Just like SM6125 the DSI PHY on this platform is not getting power from a regulator but from the MX power domain. Fixes: 572e9fd6d14a ("drm/msm/dsi: Add phy configuration for QCM2290") Reviewed-by: Konrad Dybcio Reviewed-by:

[PATCH v2] drm/vkms: Implement all blend mode properties

2023-07-23 Thread Maíra Canal
Following the DRM assumption, VKMS currently assumes that the alpha is pre-multiplied. Moreover, it doesn't support the alpha property. So, first, implement the alpha property to VKMS and then, the blend mode property. In order to support all possible supported modes, change the

Re: [PATCH v2 00/11] drm: kunit: Switch to kunit actions

2023-07-23 Thread Maira Canal
Hi Maxime, On 7/20/23 08:15, Maxime Ripard wrote: Hi, Since v6.5-rc1, kunit gained a devm/drmm-like mechanism that makes tests resources much easier to cleanup. This series converts the existing tests to use those new actions where relevant. > Let me know what you think, With the problems

Patch "dma-buf/dma-resv: Stop leaking on krealloc() failure" has been added to the 6.4-stable tree

2023-07-23 Thread gregkh
This is a note to let you know that I've just added the patch titled dma-buf/dma-resv: Stop leaking on krealloc() failure to the 6.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "dma-buf/dma-resv: Stop leaking on krealloc() failure" has been added to the 6.1-stable tree

2023-07-23 Thread gregkh
This is a note to let you know that I've just added the patch titled dma-buf/dma-resv: Stop leaking on krealloc() failure to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH v2 2/2] drm/tiny: panel-mipi-dbi: Allow sharing the D/C GPIO

2023-07-23 Thread Noralf Trønnes
On 7/20/23 12:26, Otto Pflüger wrote: > Displays that are connected to the same SPI bus may share the D/C GPIO. > Use GPIOD_FLAGS_BIT_NONEXCLUSIVE to allow access to the same GPIO for > multiple panel-mipi-dbi instances. Exclusive access to the GPIO during > transfers is ensured by the locking

Re: [PATCH v2 1/2] drm/mipi-dbi: Lock SPI bus before setting D/C GPIO

2023-07-23 Thread Noralf Trønnes
On 7/20/23 12:26, Otto Pflüger wrote: > Multiple displays may be connected to the same bus and share a D/C GPIO, > so the display driver needs exclusive access to the bus to ensure that > it can control the D/C GPIO safely. > > Signed-off-by: Otto Pflüger > --- Reviewed-by: Noralf Trønnes

Re: [PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544 displays

2023-07-23 Thread Krzysztof Kozlowski
On 21/07/2023 14:25, Viktar Simanenka wrote: > On Fri, Jul 21, 2023 at 11:42 AM Krzysztof Kozlowski > wrote: >> >> On 20/07/2023 14:40, Viktar Simanenka wrote: >>> +allOf: >>> + - $ref: panel/panel-common.yaml# >> >> This is not a panel, is it? > > I can't clearly tell the difference between

[PATCH] drm/crtc: do not release uninitialized connector reference

2023-07-23 Thread Fedor Pchelkin
Inside drm_mode_setcrtc() connector_set is allocated using kmalloc_array() so its values are uninitialized. When filling this array with actual pointers to drm connector objects, an error caused with invalid ioctl request data may occur leading us to put references to already taken objects.

[PATCH] drm/msm: Slightly simplify memory allocation in submit_lookup_cmds()

2023-07-23 Thread Christophe JAILLET
If 'sz' is SIZE_MAX, kmalloc() will fail. So there is no need to explicitly check for an hypothetical overflow. Remove the check to save a few lines of code. Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/msm/msm_gem_submit.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-)