Re: [PATCH RESEND] drm/mediatek: Add valid modifier check

Il 24/07/23 19:58, Justin Green ha scritto: Add a check to mtk_drm_mode_fb_create() that rejects any modifier that is not the AFBC mode supported by MT8195's display overlays. Tested by booting ChromeOS and verifying the UI works, and by running the ChromeOS kms_addfb_basic binary, which has a t

Re: [PATCH v6 11/11] drm/mediatek: dp: Don't register HPD interrupt handler for eDP case

Re: [Nouveau] [PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space p

You can unsubscribe here: https://lists.freedesktop.org/mailman/listinfo/nouveau Den mån 24 juli 2023 kl 19:16 skrev Mark Dymek : > > not sure how i got signed up for this and i don’t see a way to unsubscribe. > this is flooding my email with things i don’t care about. > > On Fri, Jul 14, 2023, a

Re: [PATCH 07/19] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

On 7/20/2023 2:54 PM, Lisovskiy, Stanislav wrote: On Thu, Jul 13, 2023 at 04:03:34PM +0530, Ankit Nautiyal wrote: As per Bsepc:49259, Bigjoiner BW check puts restriction on the compressed bpp for a given CDCLK, pixelclock in cases where Bigjoiner + DSC are used. Currently compressed bpp is co

Re: [PATCH 06/19] drm/i915/display: Account for DSC not split case while computing cdclk

On 7/20/2023 2:46 PM, Lisovskiy, Stanislav wrote: On Thu, Jul 13, 2023 at 04:03:33PM +0530, Ankit Nautiyal wrote: Currently we assume 2 Pixels Per Clock (PPC) while computing plane cdclk and min_cdlck. In cases where DSC single engine is used the throughput is 1 PPC. So account for the above

Re: [Intel-gfx] [PATCH v2] drm/i915/tv: avoid possible division by zero

The reason why the first five attempts had bugs is because we are trying to write it in the most complicated way possible, shifting by logical not what? regards, dan carpenter diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c index 36b479b46b60..6997b

RE: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

On Mon, 24 Jul 2023, Kasireddy, Vivek wrote: > Hi Jason, > > On Mon, Jul 24, 2023 at 07:54:38AM +, Kasireddy, Vivek wrote: > > > > > > I'm not at all familiar with the udmabuf use case but that sounds > > > > brittle and effectively makes this notifier udmabuf specific right? > > > Oh, Qemu us

Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

"Kasireddy, Vivek" writes: > Hi Alistair, Hi Vivek, >> I wonder if we actually need the flag? IIUC it is already used for more >> than just KSM. For example it can be called as part of fault handling by >> set_pte_at_notify() in in wp_page_copy(). > Yes, I noticed that but what I really meant

Re: [Intel-gfx] [PATCH v2] drm/i915/tv: avoid possible division by zero

On 2023/7/25 01:35, Andi Shyti wrote: On Tue, Jul 18, 2023 at 09:32:17AM +0800, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1, then division by zero will happen. Fixes: 1bb

Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

Jason Gunthorpe writes: > On Mon, Jul 24, 2023 at 07:54:38AM +, Kasireddy, Vivek wrote: >> And replace mmu_notifier_update_mapping(vma->vm_mm, address, pte_pfn(*ptep)) >> in the current patch with >> mmu_notifier_change_pte(vma->vm_mm, address, ptep, false)); > > It isn't very useful becau

Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file

On 2023/7/25 11:23, Muchun Song wrote: On Jul 25, 2023, at 11:09, Qi Zheng wrote: On 2023/7/25 10:35, Muchun Song wrote: On Jul 24, 2023, at 17:43, Qi Zheng wrote: The mm/vmscan.c file is too large, so separate the shrinker-related code from it into a separate file. No functional cha

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

On 2023/6/7 16:53, Lucas Stach wrote: > Hi Keith, > > Am Freitag, dem 02.06.2023 um 15:40 +0800 schrieb Keith Zhao: >> Add a basic platform driver of the DRM driver for JH7110 SoC. >> >> Signed-off-by: Keith Zhao >> --- >> MAINTAINERS | 2 + >> drivers/gpu/drm/Kcon

Re: [PATCH v2 01/47] mm: vmscan: move shrinker-related code into a separate file

On 2023/7/25 10:35, Muchun Song wrote: On Jul 24, 2023, at 17:43, Qi Zheng wrote: The mm/vmscan.c file is too large, so separate the shrinker-related code from it into a separate file. No functional changes. Signed-off-by: Qi Zheng --- include/linux/shrinker.h | 3 + mm/Makefile

Re: [PATCH v2 24/47] drm/panfrost: dynamically allocate the drm-panfrost shrinker

Hi Steven, On 2023/7/24 19:17, Steven Price wrote: On 24/07/2023 10:43, Qi Zheng wrote: In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the drm-panfrost shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait fo

Re: [PATCH v2 03/47] mm: shrinker: add infrastructure for dynamically allocating shrinker

Hi Peter, On 2023/7/24 20:25, Peter Zijlstra wrote: On Mon, Jul 24, 2023 at 05:43:10PM +0800, Qi Zheng wrote: +void shrinker_unregister(struct shrinker *shrinker) +{ + struct dentry *debugfs_entry; + int debugfs_id; + + if (!shrinker || !(shrinker->flags & SHRINKER_REGISTERED

Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

Hi everyone, It's not clear what we should do about non-robust OpenGL apps after GPU resets, so I'll try to summarize the topic, show some options and my proposal to move forward on that. Em 27/06/2023 10:23, André Almeida escreveu: +Robustness +-- + +The only way to try to keep an a

Re: [PATCH -next] drm/fb-helper: Remove unused inline function drm_fb_helper_defio_init()

On 2023/7/24 22:27, Thomas Zimmermann wrote: > Hi > > Am 21.07.23 um 14:09 schrieb YueHaibing: >> Since commit 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() >> and update docs") >> this inline helper not used anymore. >> >> Signed-off-by: YueHaibing > > You need to add a Fixes

[PATCH v2 -next] drm/fb-helper: Remove unused inline function drm_fb_helper_defio_init()

Since commit 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs") this inline helper not used anymore. Fixes: 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs") Signed-off-by: YueHaibing Reviewed-by: Thomas Zimmermann --- v2: Add Fixe

Re: [PATCH drm-misc-next v8 11/12] drm/nouveau: implement new VM_BIND uAPI

On 7/22/23 17:12, Faith Ekstrand wrote: On Wed, Jul 19, 2023 at 7:15 PM Danilo Krummrich > wrote: This commit provides the implementation for the new uapi motivated by the Vulkan API. It allows user mode drivers (UMDs) to: 1) Initialize a GPU virtual addr

Re: [PATCH drm-misc-next v8 03/12] drm/nouveau: new VM_BIND uapi interfaces

On 7/22/23 00:58, Faith Ekstrand wrote: On Wed, Jul 19, 2023 at 7:15 PM Danilo Krummrich > wrote: This commit provides the interfaces for the new UAPI motivated by the Vulkan API. It allows user mode drivers (UMDs) to: 1) Initialize a GPU virtual address

[PATCH v6 0/3] Fix IS_ERR() vs NULL check for drm

v6: - Update the first patch, return dev_err_probe(...), Thanks! v5: - Update the third patch, change IS_ERR to IS_ERR_OR_NULL. Thanks! v4: - 1. Update the second patch's commit messages. 2. Update the first patch, use dev_err_probe() instead of dev_err(). Thanks! v3: - Update the second

[PATCH v6 2/3] drm/msm: Fix IS_ERR_OR_NULL() vs NULL check in a5xx_submit_in_rb()

The msm_gem_get_vaddr() returns an ERR_PTR() on failure, and a null is catastrophic here, so we should use IS_ERR_OR_NULL() to check the return value. Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl") Signed-off-by: Gaosheng Cui Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kum

[PATCH v6 3/3] drm/komeda: Fix IS_ERR_OR_NULL() vs NULL check in komeda_component_get_avail_scaler()

The komeda_pipeline_get_state() returns an ERR_PTR() on failure, and a null is catastrophic here we should use IS_ERR_OR_NULL() to check the return value. Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") Signed-off-by: Gaosheng Cui Reviewed-by: Liviu Dudau --- drivers

[PATCH v6 1/3] drm/panel: Fix IS_ERR() vs NULL check in nt35950_probe()

The mipi_dsi_device_register_full() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. By the way, use dev_err_probe instead of dev_err to print the error code. Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") Signed-off-by: Ga

Re: drm/ast: Do not enable PCI resources multiple times

Hi, On 2023/7/25 02:34, Thomas Zimmermann wrote: Hi Am 18.07.23 um 07:40 schrieb suijingfeng: Hi, Actually,  I'm only a little bit worry about the ast_pm_thaw() code path. |- ast_pm_thaw() |-- ast_drm_thaw() |--- ast_post_gpu() I'm not quite sure what mean here, because the post-GPU

[PATCH v9 7/7] drm/i915/gt: Support aux invalidation on all engines

Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed

[PATCH v9 6/7] drm/i915/gt: Poll aux invalidation register bit on invalidation

From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: #

[PATCH v9 5/7] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control and in the CS

Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). For the copy engine add MI_FLUSH_DW_CCS (bit 16) in the command streamer. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")

[PATCH v9 4/7] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

In preparation of the next patch align with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1. Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTR

[PATCH v9 3/7] drm/i915/gt: Ensure memory quiesced before invalidation

From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Requires: a2a4aa0eef3b ("drm/i915: Add the gen12_needs_ccs_aux_inv helper") Signed-off-b

[PATCH v9 2/7] drm/i915: Add the gen12_needs_ccs_aux_inv helper

We always assumed that a device might either have AUX or FLAT CCS, but this is an approximation that is not always true, e.g. PVC represents an exception. Set the basis for future finer selection by implementing a boolean gen12_needs_ccs_aux_inv() function that tells whether aux invalidation is ne

[PATCH v9 1/7] drm/i915/gt: Cleanup aux invalidation registers

Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also VD1, VD3 and VE1 registers that don't exist and

[PATCH v9 0/7] Update AUX invalidation sequence

Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. In this version we support all the engines affected by this change. The stable backport has some challenges because the original patch that this series fixes has had more changes in between.

RE: [PATCH] drm/i915: Avoid GGTT flushing on non-GGTT paths of i915_vma_pin_iomap

Hi Tvrtko, The changes makes sense and based on the description looks good. I am bit skeptical about the exec buffer failure reported by ci hence, withholding the r-b for now. If you believe the CI failure is unrelated please feel free to add my r-b. On a side note on platforms with non-coherent

Re: [PATCH] drm/panel: ld9040: add backlight Kconfig dependency

Hi, Le lundi 24 juillet 2023 à 19:11 +0200, Sam Ravnborg a écrit : > On Mon, Jul 24, 2023 at 02:17:05PM +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The driver now uses the backlight interface, which breaks when that > > is disabled: > > > > ld.lld: error: undefined symbol: devm_

Re: [PATCH v3] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

The Xwayland merge request linked below has been updated to the new interface (via pending libdrm wrappers). I have also posted a revised IGT test here https://lists.freedesktop.org/archives/igt-dev/2023-July/058449.html On 7/21/23 11:50, Erik Kurzinger wrote: > These new ioctls perform a task s

RE: [PATCH v2] drm/amd/pm: Vangogh: Add new gpu_metrics_v2_4 to acquire gpu_metrics

[AMD Official Use Only - General] Hi Wenyou, Could you merge the patch? Thanks, Richard -Original Message- From: Quan, Evan Sent: Tuesday, July 18, 2023 12:03 AM To: Yang, WenYou ; Deucher, Alexander ; Limonciello, Mario ; Koenig, Christian ; Pan, Xinhui Cc: Yuan, Perry ; Liang, Rich

Re: [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS

On 2023-07-24 17:14, Michał Winiarski wrote: Having a limit of 64 DRM devices is not good enough for modern world where we have multi-GPU servers, SR-IOV virtual functions and virtual devices used for testing. Let's utilize full minor range for DRM devices. To avoid regressing the existing users

Re: [Intel-gfx] [PATCH v3] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

On 6/15/2023 14:15, Zhanjun Dong wrote: This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset. Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle

Re: [PATCH] drm/amd/pm: open brace '{' following struct go on the same line

Applied. Thanks! On Mon, Jul 24, 2023 at 5:08 AM wrote: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > .../amd/pm/swsmu/inc/smu_v13_0_7_pptable.h| 21 +++ > 1 file changed, 7 insertions(+), 14 deletions(-) > > diff --git

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_1_pmfw.h

This doesn't apply cleanly. Alex On Mon, Jul 24, 2023 at 4:57 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h | 4 ++-- > 1 file changed, 2 insertions(

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v11_0_7_pptable.h

This one doesn't apply cleanly. Alex On Mon, Jul 24, 2023 at 4:54 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > .../amd/pm/swsmu/inc/smu_v11_0_7_ppta

Re: [PATCH] drm/amd/pm: open brace '{' following function definitions go on the next line

Applied. Thanks! On Mon, Jul 24, 2023 at 4:44 AM wrote: > > ERROR: open brace '{' following function definitions go on the next line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dr

Re: [PATCH] drm/amd/pm: that open brace { should be on the previous line

Applied. Thanks! On Mon, Jul 24, 2023 at 4:42 AM wrote: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/inc/smu_11_0_cdr_table.h | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/

Re: [PATCH] drm/amd/pm: Clean up errors in smu11_driver_if_sienna_cichlid.h

This doesn't apply cleanly. Alex On Mon, Jul 24, 2023 at 4:34 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_1_pmfw.h | 4 ++-- > 1 file changed, 2 insertions(

Re: [PATCH] drm/amd/pm: Clean up errors in smu11_driver_if_sienna_cichlid.h

This doesn't apply cleanly. Alex On Mon, Jul 24, 2023 at 4:30 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > ERROR: space prohibited before open square bracket '[' > ERROR: space prohibited before that close square bracket ']' > > Signed-off-by: R

Re: [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c

Applied. Thanks! On Mon, Jul 24, 2023 at 3:49 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: "foo* bar" should be "foo *bar" > ERROR: spaces required around that '=' (ctx:VxW) > ERROR: space prohibited before that close parenthesis ')' > > Signed-off-by: Ran Sun > ---

Re: [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c

Applied. thanks! On Mon, Jul 24, 2023 at 3:32 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '=' (ctx:VxW) > ERROR: spaces required around that '>=' (ctx:WxV) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_

Re: [PATCH] drm/amd/pm: Clean up errors in navi10_ppt.c

Applied. Thanks! On Mon, Jul 24, 2023 at 3:21 AM wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following function definitions go on the next line > ERROR: space required before the open parenthesis '(' > ERROR: space required after that ',' (ctx:VxV) > ERR

Re: [PATCH] drm/amd/pm: add missing spaces before '('

Applied. Thanks! On Mon, Jul 24, 2023 at 3:02 AM wrote: > > ERROR: space required before the open parenthesis '(' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/

Re: [PATCH] drm/radeon: Move assignment outside if condition

Applied. Thanks! On Sun, Jul 23, 2023 at 11:45 PM wrote: > > Fixes the following checkpatch errors: > > ERROR: do not use assignment in if condition > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/radeon_legacy_tv.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > >

Re: [PATCH] drm/radeon: that open brace { should be on the previous line

Applied. thanks! Alex On Sun, Jul 23, 2023 at 11:40 PM wrote: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/rv770_smc.c | 36 ++ > 1 file changed, 12 insertions(+), 24 deletions(-) > > diff -

Re: [PATCH] drm/radeon: that open brace { should be on the previous line

Applied. Thanks! On Sun, Jul 23, 2023 at 11:37 PM wrote: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/clearstate_si.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/cle

Re: [PATCH] drm/radeon: add missing spaces after ', ' and else should follow close brace '}'

Applied. Thanks! Alex On Sun, Jul 23, 2023 at 11:30 PM wrote: > > ERROR: else should follow close brace '}' > > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deleti

Re: [PATCH] drm/radeon: that open brace { should be on the previous line

On Sun, Jul 23, 2023 at 11:12 PM wrote: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/ni_dpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/ni_dpm.c > b/drivers/gpu/drm/ra

Re: [PATCH] drm/radeon: add missing spaces before ';'

Applied. Thanks! On Sun, Jul 23, 2023 at 11:00 PM wrote: > > ERROR: space required after that ';' (ctx:BxV) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/radeon_vce.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_vce.c

Re: [PATCH] drm/radeon/si_dpm: open brace '{' following struct go on the same line

Applied. Thanks. Alex On Sun, Jul 23, 2023 at 10:55 PM wrote: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/sislands_smc.h | 51 +-- > 1 file changed, 17 insertions(+), 34 deletions(-) > > dif

[PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS

Having a limit of 64 DRM devices is not good enough for modern world where we have multi-GPU servers, SR-IOV virtual functions and virtual devices used for testing. Let's utilize full minor range for DRM devices. To avoid regressing the existing userspace, we're still maintaining the numbering sche

[PATCH v6 4/4] drm: Introduce force_extended_minors modparam

While there is support for >64 DRM devices on kernel side, existing userspace may still have some hardcoded assumptions and it's possible that it will require changes to be able to use more than 64 devices. Add a modparam to simplify testing and development of >64 devices support on userspace side

[PATCH v6 2/4] accel: Use XArray instead of IDR for minors

Accel minor management is based on DRM (and is also using struct drm_minor internally), since DRM is using XArray for minors, it makes sense to also convert accel. As the two implementations are identical (only difference being the underlying xarray), move the accel_minor_* functionality to DRM. S

[PATCH v6 1/4] drm: Use XArray instead of IDR for minors

IDR is deprecated, and since XArray manages its own state with internal locking, it simplifies the locking on DRM side. Additionally, don't use the IRQ-safe variant, since operating on drm minor is not done in IRQ context. Signed-off-by: Michał Winiarski Suggested-by: Matthew Wilcox --- drivers

[PATCH v6 0/4] drm: Use full allocated minor range for DRM

64 DRM device nodes is not enough for everyone. Upgrade it to ~512K (which definitely is more than enough). To allow testing userspace support for >64 devices, add additional DRM modparam (force_extended_minors) which causes DRM to skip allocating minors in 0-192 range. Additionally - convert mino

RE: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

Hi Alistair, > >> > >> Yes, although obviously as I think you point out below you wouldn't be > >> able to take any sleeping locks in mmu_notifier_update_mapping(). > > Yes, I understand that, but I am not sure how we can prevent any potential > > notifier callback from taking sleeping locks other

RE: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

Hi Jason, > > On Mon, Jul 24, 2023 at 07:54:38AM +, Kasireddy, Vivek wrote: > > > > I'm not at all familiar with the udmabuf use case but that sounds > > > brittle and effectively makes this notifier udmabuf specific right? > > Oh, Qemu uses the udmabuf driver to provide Host Graphics compon

[PATCH] drm/msm: Disallow submit with fence id 0

From: Rob Clark A fence id of zero is expected to be invalid, and is not removed from the fence_idr table. If userspace is requesting to specify the fence id with the FENCE_SN_IN flag, we need to reject a zero fence id value. Fixes: 17154addc5c1 ("drm/msm: Add MSM_SUBMIT_FENCE_SN_IN") Signed-of

Re: [PATCH v3] drm/msm/a2xx: Call adreno_gpu_init() earlier

Hi Rob, A gentle ping. On Thu, Jun 22, 2023 at 3:37 PM Dmitry Baryshkov wrote: > > On 21/06/2023 02:23, Fabio Estevam wrote: > > From: Fabio Estevam > > > > The adreno_is_a20x() and adreno_is_a225() functions rely on the > > GPU revision, but such information is retrieved inside adreno_gpu_init

Re: [Intel-gfx] [PATCH] drm/i915: Avoid GGTT flushing on non-GGTT paths of i915_vma_pin_iomap

Hi Tvrtko, On Mon, Jul 24, 2023 at 01:56:33PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit 4bc91dbde0da ("drm/i915/lmem: Bypass aperture when lmem is available") > added a code path which does not map via GGTT, but was still setting the > ggtt write bit, and so triggering the G

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

Am 24.07.23 um 20:48 schrieb Thomas Zimmermann: Hi Jocelyn Am 17.07.23 um 15:29 schrieb Jocelyn Falempe: A G200SE_A rev 1 user reported that prior to v6.0, he was able to get Xorg working at 1440x900@60Hz. This somehow bypassed the bandwidth test in the driver. After v6.0, and the driver ref

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

Hi Jocelyn Am 17.07.23 um 15:29 schrieb Jocelyn Falempe: A G200SE_A rev 1 user reported that prior to v6.0, he was able to get Xorg working at 1440x900@60Hz. This somehow bypassed the bandwidth test in the driver. After v6.0, and the driver refactor, it's no longer possible. I took that bandwi

Re: drm/ast: Do not enable PCI resources multiple times

Hi Am 18.07.23 um 07:40 schrieb suijingfeng: Hi, Actually,  I'm only a little bit worry about the ast_pm_thaw() code path. |- ast_pm_thaw() |-- ast_drm_thaw() |--- ast_post_gpu() I'm not quite sure what mean here, because the post-GPU code is not involved in this patch. All this patch do

[PATCH RESEND] drm/mediatek: Add valid modifier check

Add a check to mtk_drm_mode_fb_create() that rejects any modifier that is not the AFBC mode supported by MT8195's display overlays. Tested by booting ChromeOS and verifying the UI works, and by running the ChromeOS kms_addfb_basic binary, which has a test called "addfb25-bad-modifier" that attempt

Re: [PATCH] drm/panel: db7430: remove unused variables

On Wed, Jul 19, 2023 at 12:59 PM Luca Ceresoli wrote: > These variables are never referenced in the code. > > Signed-off-by: Luca Ceresoli Patch applied and pushed to drm-misc-next. Yours, Linus Walleij

Re: [PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state

On Fri, Jul 21, 2023 at 11:29 AM Ying Liu wrote: > If GPIO pin is in input state but backlight is currently off due to > default pull downs, Oh what an interesting corner case! > then initial power state is set to FB_BLANK_UNBLANK > in DT boot mode with phandle link and the backlight is effecti

Re: [Intel-gfx] [PATCH v2] drm/i915/tv: avoid possible division by zero

On Tue, Jul 18, 2023 at 09:32:17AM +0800, Su Hui wrote: > Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: > line 991, column 22 Division by zero. > Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1, > then division by zero will happen. > > Fixes: 1bba5543e4fe ("drm/i915: Fix TV

Re: [PATCH v3 1/2] drm/mipi-dbi: Lock SPI bus before setting D/C GPIO

On 7/24/23 1:56 AM, Otto Pflüger wrote: Multiple displays may be connected to the same bus and share a D/C GPIO, so the display driver needs exclusive access to the bus to ensure that it can control the D/C GPIO safely. Signed-off-by: Otto Pflüger Reviewed-by: Noralf Trønnes --- Acked-by: Da

Re: [PATCH v5 1/3] drm/panel: Fix IS_ERR() vs NULL check in nt35950_probe()

Hi Gaosheng, On Mon, Jul 24, 2023 at 10:00:34PM +0800, Gaosheng Cui wrote: > The mipi_dsi_device_register_full() returns an ERR_PTR() on failure, > we should use IS_ERR() to check the return value. > > By the way, use dev_err_probe instead of dev_err to print the error code. > > Fixes: 623a3531e9

Re: [PATCH] drm/panel: ld9040: add backlight Kconfig dependency

On Mon, Jul 24, 2023 at 02:17:05PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The driver now uses the backlight interface, which breaks when that > is disabled: > > ld.lld: error: undefined symbol: devm_backlight_device_register > > Enforce the necessary Kconfig dependency to avoid t

[PATCH] Revert "fbcon: Use kzalloc() in fbcon_prepare_logo()"

This reverts commit a6a00d7e8ffd78d1cdb7a43f1278f081038c638f. The syzbot report turned out to be a false possitive, caused by a KMSAN problem. Indeed, after allocating the buffer, it is fully initialized using scr_memsetw(). Hence there is no point in allocating zeroed memory, while this does in

Re: [Intel-gfx] [PATCH] drm/i915: Fix an error handling path in igt_write_huge()

Hi Christophe, > All error handling paths go to 'out', except this one. Be consistent and > also branch to 'out' here. > > Fixes: c10a652e239e ("drm/i915/selftests: Rework context handling in > hugepages selftests") > Signed-off-by: Christophe JAILLET Pushed to drm-intel-gt-next. Thanks, Andi

Re: [Intel-gfx] [PATCH] drm/i915: Fix an error handling path in igt_write_huge()

Hi Christophe, On Mon, Jul 17, 2023 at 08:49:31PM +0200, Christophe JAILLET wrote: > All error handling paths go to 'out', except this one. Be consistent and > also branch to 'out' here. > > Fixes: c10a652e239e ("drm/i915/selftests: Rework context handling in > hugepages selftests") > Signed-off

Re: [PATCH] dma-buf/sync_file: Fix docs syntax

On 7/24/23 07:49, Rob Clark wrote: > From: Rob Clark > > Fixes the warning: > > include/uapi/linux/sync_file.h:77: warning: Function parameter or member > 'num_fences' not described in 'sync_file_info' > > Fixes: 2d75c88fefb2 ("staging/android: refactor SYNC IOCTLs") > Signed-off-by: Rob

[PATCH v2] drm: bridge: samsung-dsim: Fix init during host transfer

From: Frieder Schrempf In case the downstream bridge or panel uses DSI transfers before the DSI host was actually initialized through samsung_dsim_atomic_enable() which clears the stop state (LP11) mode, all transfers will fail. This happens with downstream bridges that are controlled by DSI com

[PATCH] drm: bridge: samsung-dsim: Fix init during host transfer

From: Frieder Schrempf In case the downstream bridge or panel uses DSI transfers before the DSI host was actually initialized through samsung_dsim_atomic_enable() which clears the stop state (LP11) mode, all transfers will fail. This happens with downstream bridges that are controlled by DSI com

[PATCH] dma-buf/sync_file: Fix docs syntax

From: Rob Clark Fixes the warning: include/uapi/linux/sync_file.h:77: warning: Function parameter or member 'num_fences' not described in 'sync_file_info' Fixes: 2d75c88fefb2 ("staging/android: refactor SYNC IOCTLs") Signed-off-by: Rob Clark --- include/uapi/linux/sync_file.h | 2 +- 1 fil

Re: [Intel-gfx] [PATCH v8 9/9] drm/i915/gt: Support aux invalidation on all engines

Hi Andrzej, On Mon, Jul 24, 2023 at 11:42:16AM +0200, Andrzej Hajda wrote: > On 21.07.2023 18:15, Andi Shyti wrote: > > Perform some refactoring with the purpose of keeping in one > > single place all the operations around the aux table > > invalidation. > > > > With this refactoring add more eng

Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

On Thu, Jul 20, 2023 at 03:52:38PM +0200, Luca Ceresoli wrote: > Hello Rob, > > thanks for reviewing. > > On Wed, 19 Jul 2023 13:02:54 -0600 > Rob Herring wrote: > > > On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > > > Add bindings for LCD panels based on the ILITEK ILI9806E R

Re: [PATCH -next] drm/fb-helper: Remove unused inline function drm_fb_helper_defio_init()

Hi Am 21.07.23 um 14:09 schrieb YueHaibing: Since commit 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs") this inline helper not used anymore. Signed-off-by: YueHaibing You need to add a Fixes: tag here with the commit you mentioned in the description. Wi

Re: [PATCH v3 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

If you're going to update the other patches to use IS_ERR_OR_NULL() please do so here too. You can keep my R-b for that change. Thanks for taking time to review the patch. I have update the patch set and add this change to v5. On 2023/7/21 18:24, Liviu Dudau wrote: Hi Gaosheng, On Fri, Jul 1

[PATCH v5 3/3] drm/komeda: Fix IS_ERR_OR_NULL() vs NULL check in komeda_component_get_avail_scaler()

The komeda_pipeline_get_state() returns an ERR_PTR() on failure, and a null is catastrophic here we should use IS_ERR_OR_NULL() to check the return value. Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") Signed-off-by: Gaosheng Cui Reviewed-by: Liviu Dudau --- drivers

[PATCH v5 0/3] Fix IS_ERR() vs NULL check for drm

v5: - Update the third patch, change IS_ERR to IS_ERR_OR_NULL. Thanks! v4: - 1. Update the second patch's commit messages. 2. Update the first patch, use dev_err_probe() instead of dev_err(). Thanks! v3: - Update the second patch: 1. change IS_ERR to IS_ERR_OR_NULL 2. add Dmitry's R-b

[PATCH v5 1/3] drm/panel: Fix IS_ERR() vs NULL check in nt35950_probe()

The mipi_dsi_device_register_full() returns an ERR_PTR() on failure, we should use IS_ERR() to check the return value. By the way, use dev_err_probe instead of dev_err to print the error code. Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") Signed-off-by: Ga

[PATCH v5 2/3] drm/msm: Fix IS_ERR_OR_NULL() vs NULL check in a5xx_submit_in_rb()

The msm_gem_get_vaddr() returns an ERR_PTR() on failure, and a null is catastrophic here, so we should use IS_ERR_OR_NULL() to check the return value. Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl") Signed-off-by: Gaosheng Cui Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kum

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

Hi, On Sun, Jul 23, 2023 at 3:47 PM Marek Vasut wrote: > > On 7/18/23 21:33, Doug Anderson wrote: > > Hi, > > > > On Tue, Jul 18, 2023 at 10:37 AM Marek Vasut wrote: > >> > >> On 7/18/23 18:15, Doug Anderson wrote: > >>> Hi, > >> > >> Hi, > >> > >>> On Tue, Jul 18, 2023 at 8:36 AM Marek Vasut w

Re: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

On 7/24/2023 04:22, Andrew Lunn wrote: @@ -1395,6 +1395,8 @@ int ieee80211_register_hw(struct ieee80211_hw *hw) debugfs_hw_add(local); rate_control_add_debugfs(local); + ieee80211_check_wbrf_support(local); + rtnl_lock(); wiphy_lock(hw->wiphy); +void ieee

Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

On Mon, Jul 24, 2023 at 11:36:47PM +1000, Alistair Popple wrote: > My primary issue with this patch is the notifier is called without the > PTL while providing a PTE value. Right, this is no-go. The PTE value must be protected by the PTLs at all times. We've made enough bugs already by being laz

Re: [PATCH] drm/ttm: check null pointer before accessing when swapping

On Sun, Jul 23, 2023 at 10:43 PM Guchun Chen wrote: > > Add a check to avoid null pointer dereference as below: > > [ 90.002283] general protection fault, probably for non-canonical > address 0xdc00: [#1] PREEMPT SMP KASAN NOPTI > [ 90.002292] KASAN: null-ptr-deref in range >

Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

On Mon, Jul 24, 2023 at 07:54:38AM +, Kasireddy, Vivek wrote: > > I'm not at all familiar with the udmabuf use case but that sounds > > brittle and effectively makes this notifier udmabuf specific right? > Oh, Qemu uses the udmabuf driver to provide Host Graphics components > (such as Spice, G

Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

"Kasireddy, Vivek" writes: > Hi Alistair, > >> >> >> "Kasireddy, Vivek" writes: >> >> Yes, although obviously as I think you point out below you wouldn't be >> able to take any sleeping locks in mmu_notifier_update_mapping(). > Yes, I understand that, but I am not sure how we can prevent any

Re: [PATCH] drm/amd/pm: Clean up errors in sienna_cichlid_ppt.c

Hi, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.5-rc3 next-20230724] [If your

[PATCH 2/2] accel/habanalabs: fix ETR/ETF flush logic

From: Benjamin Dotan When config_etr or config_etf are called we need to validate the parameters that are passed into them to make sure the requested operation is valid. Signed-off-by: Benjamin Dotan Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/gaudi/gaudi

  1   2   3   >