[PATCH] drm/amd/pm: Clean up errors in vega10_hwmgr.c

Fix the following errors reported by checkpatch: ERROR: trailing statements should be on next line ERROR: space required before the open brace '{' ERROR: space required before the open parenthesis '(' ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun ---

RE: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

Hi Jason, > > > > Later the importer decides it needs the memory again so it again asks > > > for the dmabuf to be present, which does hmm_range_fault and gets > > > whatever is appropriate at the time. > > Unless I am missing something, I think just doing the above still won't > > solve > >

Re: [PATCH] drm/amd/display: check attr flag before set cursor degamma on DCN3+

Tested-by: Alex Hung On 2023-07-31 02:35, Melissa Wen wrote: Don't set predefined degamma curve to cursor plane if the cursor attribute flag is not set. Applying a degamma curve to the cursor by default breaks userspace expectation. Checking the flag before performing any color transformation

[PATCH] drm/amd/pm: Clean up errors in vega10_powertune.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Ran Sun --- .../amd/pm/powerplay/hwmgr/vega10_powertune.c | 89 +++ 1 file changed, 31 insertions(+),

[PATCH -next v2] drm/i2c: tda998x: remove redundant CONFIG_OF and of_match_ptr

The driver depends on CONFIG_OF, so it is not necessary to use CONFIG_OF and of_match_ptr here, we remove them all. Even for drivers that do not depend on CONFIG_OF, it's almost always better to leave out the of_match_ptr(), since the only thing it can possibly do is to save a few bytes of .text

Re: [PATCH -next] drm/i2c: tda998x: remove redundant of_match_ptr

Hi Zhu, kernel test robot noticed the following build errors: [auto build test ERROR on next-20230731] url: https://github.com/intel-lab-lkp/linux/commits/Zhu-Wang/drm-i2c-tda998x-remove-redundant-of_match_ptr/20230731-210417 base: next-20230731 patch link: https://lore.kernel.org/r

[PATCH] drm/amd/pm: Clean up errors in fiji_baco.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/hwmgr/fiji_baco.c| 24 +++ 1 file changed, 8 insertions(+), 16 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in smu10_hwmgr.c

Fix the following errors reported by checkpatch: ERROR: spaces required around that '=' (ctx:VxW) ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun --- .../gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH] drm/amd/pm/powerplay/hwmgr/ppevvmath: Clean up errors in ppevvmath.h

Fix the following errors reported by checkpatch: ERROR: return is not a function, parentheses are not required ERROR: space required after that ',' (ctx:VxV) ERROR: space required before the open parenthesis '(' ERROR: need consistent spacing around '-' (ctx:WxV) Signed-off-by: Ran Sun ---

[RESEND PATCH] drm/qxl: prevent memory leak

The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_object before qxl suspend. otherwise,qxl_create_monitors_object will be called to reallocate memory for qdev->dumb_heads after qxl resume, it will cause memory leak. Signed-off-by: Zongmin Zhou ---

[PATCH] drm/amd/pm: Clean up errors in vega12_hwmgr.c

Fix the following errors reported by checkpatch: ERROR: need consistent spacing around '/' (ctx:WxV) ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH] drm/amd/pm: Clean up errors in vega10_baco.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space required after that ',' (ctx:VxV) ERROR: space prohibited before that ',' (ctx:WxV) Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/hwmgr/vega10_baco.c | 26

Re: [PATCH v7 03/13] drm/mediatek: gamma: Support SoC specific LUT size

[PATCH] drm/amd/pm: Clean up errors in vega20_hwmgr.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following enum go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in amd_powerplay.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: spaces required around that '||' (ctx:WxO) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 16 1 file changed, 8 insertions(+), 8

[PATCH] drm/amd/pm: Clean up errors in amdgpu_smu.c

Fix the following errors reported by checkpatch: ERROR: spaces required around that '=' (ctx:WxV) ERROR: spaces required around that '&&' (ctx:VxW) ERROR: that open brace { should be on the previous line ERROR: space required before the open parenthesis '(' ERROR: space required before the open

[PATCH] drm/amd: Clean up errors in smu_v13_0_5_ppt.c

Fix the following errors reported by checkpatch: ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/smu_internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_internal.h

[PATCH] drm/amd/pm: Clean up errors in smu_v13_0_5_ppt.c

Fix the following errors reported by checkpatch: ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in smu_v13_0_6_ppt.c

Fix the following errors reported by checkpatch: ERROR: code indent should use tabs where possible ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 9 - 1 file changed, 4 insertions(+), 5

[PATCH] drm/amd/pm: Clean up errors in aldebaran_ppt.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space required after that ',' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxW) ERROR: else should follow close brace '}' Signed-off-by: Ran Sun ---

[PATCH] drm/amd/pm: Clean up errors in smu_v13_0.c

Fix the following errors reported by checkpatch: ERROR: space required before the open parenthesis '(' ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

Re: [PATCH -next] drm/amdgpu: Remove a lot of unnecessary ternary operators

On 2023/8/1 0:14, Limonciello, Mario wrote: > > > On 7/31/2023 8:26 AM, Ruan Jinjie wrote: >> Ther are many ternary operators, the true or false judgement >> of which is unnecessary in C language semantics. > s/Ther/There/ > > Unnecessary; sure.  But don't they improve the readability quite

[PATCH] drm/amd/pm: Clean up errors in smu_v13_0_7_ppt.c

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: spaces required around that '=' (ctx:VxW) ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c |

Re: [PATCH -next] drm/amdgpu: Remove a lot of unnecessary ternary operators

On 2023/8/1 0:22, Tom Rix wrote: > > On 7/31/23 6:26 AM, Ruan Jinjie wrote: >> Ther are many ternary operators, the true or false judgement >> of which is unnecessary in C language semantics. >> >> Signed-off-by: Ruan Jinjie >> --- > > snip >> data->registry_data.avfs_support = >> -

[PATCH] drm/amd/pm: Clean up errors in smu_v11_0.h

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0.h | 7 +++--- scripts/checkpatch.pl| 23

Re: [PATCH RFC v5 09/10] drm/msm/dpu: Use DRM solid_fill property

On 01/08/2023 03:39, Jessica Zhang wrote: On 7/30/2023 9:15 PM, Dmitry Baryshkov wrote: On 28/07/2023 20:02, Jessica Zhang wrote: Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to determine if the plane is solid fill. In addition drop the DPU plane color_fill field as

linux-next: manual merge of the fbdev tree with the drm tree

Hi all, Today's linux-next merge of the fbdev tree got a conflict in: drivers/video/fbdev/mx3fb.c between commit: 8a4675ebbd30 ("fbdev: Remove FBINFO_FLAG_DEFAULT from framebuffer_alloc()'ed structs") from the drm tree and commit: 87ac8777d424 ("fbdev: mx3fb: Remove the driver") from

Re: [PATCH RFC v5 09/10] drm/msm/dpu: Use DRM solid_fill property

On 7/30/2023 9:15 PM, Dmitry Baryshkov wrote: On 28/07/2023 20:02, Jessica Zhang wrote: Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to determine if the plane is solid fill. In addition drop the DPU plane color_fill field as we can now use drm_plane_state.solid_fill

[PATCH v3] drm/panfrost: Sync IRQ by job's timeout handler

Panfrost IRQ handler may stuck for a long time, for example this happens when there is a bad HDMI connection and HDMI handler takes a long time to finish processing, holding Panfrost. Make Panfrost's job timeout handler to sync IRQ before checking fence signal status in order to prevent spurious

Re: [PATCH] fbdev/ps3fb: Build without kernel device

On 7/31/23 10:55, Thomas Zimmermann wrote: > Use fb_info() to print status message at the end of the probe function, > which avoids decoding the devices. fb_info() works with or without an > fbdev kernel device. Fixes the following error: > > ../drivers/video/fbdev/ps3fb.c: In function

Re: [PATCH -next] drm/i2c: tda998x: remove redundant of_match_ptr

Hi Zhu, kernel test robot noticed the following build errors: [auto build test ERROR on next-20230731] url: https://github.com/intel-lab-lkp/linux/commits/Zhu-Wang/drm-i2c-tda998x-remove-redundant-of_match_ptr/20230731-210417 base: next-20230731 patch link: https://lore.kernel.org/r

Re: [PATCH v6 3/3] drm/virtio: Support sync objects

On 4/16/23 14:52, Dmitry Osipenko wrote: > Add sync object DRM UAPI support to VirtIO-GPU driver. Sync objects > support is needed by native context VirtIO-GPU Mesa drivers, it also will > be used by Venus and Virgl contexts. > > Reviewed-by; Emil Velikov > Signed-off-by: Dmitry Osipenko > ---

Re: [PATCH v3 00/19] Sitronix ST7789V improvements

Hi, Each patch in the series has at least one Reviewed-by tag and the DT binding changes have an Acked-by from at least one of the DT binding maintainers. It has been pending on the mailing list for two weeks now, so can it be applied? P.S.: Looks like I missed Neil in the original recipients

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

On 7/31/23 23:34, Doug Anderson wrote: Hi, On Mon, Jul 31, 2023 at 2:15 PM Marek Vasut wrote: On 7/31/23 21:50, Doug Anderson wrote: Hi, On Mon, Jul 31, 2023 at 11:03 AM Marek Vasut wrote: On 7/24/23 15:49, Doug Anderson wrote: Hi, [...] Maybe the EPROBE_DEFER actually happens and

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

Hi, On Mon, Jul 31, 2023 at 2:15 PM Marek Vasut wrote: > > On 7/31/23 21:50, Doug Anderson wrote: > > Hi, > > > > On Mon, Jul 31, 2023 at 11:03 AM Marek Vasut wrote: > >> > >> On 7/24/23 15:49, Doug Anderson wrote: > >> > >> Hi, > >> > >> [...] > >> > Maybe the EPROBE_DEFER actually

Re: [PATCH] drm/i915/huc: fix intel_huc.c doc bulleted list format error

On 7/26/2023 7:54 PM, David Reaver wrote: Fix the following make htmldocs errors/warnings: ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:29: ERROR: Unexpected indentation. ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:30: WARNING: Block quote ends without a blank line; unexpected unindent.

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

On 7/31/23 21:50, Doug Anderson wrote: Hi, On Mon, Jul 31, 2023 at 11:03 AM Marek Vasut wrote: On 7/24/23 15:49, Doug Anderson wrote: Hi, [...] Maybe the EPROBE_DEFER actually happens and triggers the failure ? I could certainly believe that EPROBE_DEFER is involved. So no, it is

[PATCH 1/2] dt-bindings: display: simple: Add Innolux G156HCE-L01 panel

Add entry for Innolux G156HCE-L01 15.6" 1920x1080 24bpp dual-link LVDS TFT panel. Documentation is available at [1]. [1] https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G156HCE-L01_Rev.C3_Datasheet.pdf Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter Cc:

[PATCH 2/2] drm/panel-simple: Add Innolux G156HCE-L01 panel entry

Add support for Innolux G156HCE-L01 15.6" 1920x1080 24bpp dual-link LVDS TFT panel. Documentation is available at [1]. The middle frequency is tuned slightly upward from 70.93 MHz to 72 MHz, otherwise the panel shows slight flicker. [1]

Re: [PATCH v2] drm/panel: Enable DSC and CMD mode for Visionox VTDR6130 panel

CC-ing rest of correspondents On 7/28/2023 5:43 PM, Paloma Arellano wrote: On 7/28/2023 2:37 AM, Dmitry Baryshkov wrote: On Fri, 28 Jul 2023 at 04:26, Paloma Arellano wrote: Enable display compression (DSC v1.2) and CMD mode for 1080x2400 Visionox VTDR6130 AMOLED DSI panel. In addition,

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

Hi, On Mon, Jul 31, 2023 at 11:03 AM Marek Vasut wrote: > > On 7/24/23 15:49, Doug Anderson wrote: > > Hi, > > [...] > > >> Maybe the EPROBE_DEFER actually happens and triggers the failure ? > > > > I could certainly believe that EPROBE_DEFER is involved. > > So no, it is not. It is difficult to

Re: [PATCH] fbdev/ps3fb: Build without kernel device

On Mon, Jul 31, 2023 at 07:55:00PM +0200, Thomas Zimmermann wrote: > Use fb_info() to print status message at the end of the probe function, > which avoids decoding the devices. fb_info() works with or without an > fbdev kernel device. Fixes the following error: > >

[PATCH] drm/nouveau: fixup the uapi header file.

From: Dave Airlie nouveau > 10 years ago had a plan for new multiplexer inside a multiplexer API using nvif. It never fully reached fruition, fast forward 10 years, and the new vulkan driver is avoiding libdrm and calling ioctls, and these 3 ioctls, getparam, channel alloc + free don't seem to

[PATCH v3] drm/tests: Alloc drm_device on drm_exec tests

The drm_exec tests where crashing[0] because of a null dereference. This is caused by a new access of the `driver` attribute of `struct drm_driver` on drm_gem_private_object_init(). Alloc the drm_device to fix that. [0] [15:05:24] == drm_exec (6 subtests) ===

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

On 7/24/23 15:49, Doug Anderson wrote: Hi, [...] Maybe the EPROBE_DEFER actually happens and triggers the failure ? I could certainly believe that EPROBE_DEFER is involved. So no, it is not. It is difficult to set this up and access the signals, but so I did. What happens is this:

[PATCH] fbdev/ps3fb: Build without kernel device

Use fb_info() to print status message at the end of the probe function, which avoids decoding the devices. fb_info() works with or without an fbdev kernel device. Fixes the following error: ../drivers/video/fbdev/ps3fb.c: In function 'ps3fb_probe': ../drivers/video/fbdev/ps3fb.c:1172:40: error:

Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

On Sat, Jul 29, 2023 at 12:08:25AM +, Kasireddy, Vivek wrote: > Hi Peter, > > > > > > > > > I'm not at all familiar with the udmabuf use case but that > > > > > > > > sounds > > > > > > > > brittle and effectively makes this notifier udmabuf specific > > > > > > > > right? > > > > > > > Oh,

Re: [PATCH v3 02/10] drm/panel: Check for already prepared/enabled in drm_panel

Hi, On Mon, Jul 31, 2023 at 11:33:22AM -0500, Chris Morgan wrote: > In my case a few different panel drivers disable the regulators in the > unprepare/disable routines. And that's totally fine. > For at least the Rockchip DSI implementations for some reason the > panel gets unprepared more than

Re: [PATCH 00/14] A7xx support

On 28/06/2023 23:35, Konrad Dybcio wrote: This series attempts to introduce Adreno 700 support (with A730 and A740 found on SM8450 and SM8550 respectively), reusing much of the existing A6xx code. This submission largely lays the groundwork for expansion and more or less gives us feature parity

Re: [PATCH v4 0/6] Adreno QoL changes

On 20.06.2023 13:10, Konrad Dybcio wrote: > This series brings some niceties in preparation for A7xx introduction. > > It should be fully independent of the GMU wrapper series. > > Signed-off-by: Konrad Dybcio > --- Bump Konrad

Re: [PATCH drm-misc-next v8 11/12] drm/nouveau: implement new VM_BIND uAPI

On Sun, Jul 30, 2023 at 10:30 PM Faith Ekstrand wrote: > > On Tue, Jul 25, 2023 at 5:48 PM Danilo Krummrich wrote: > >> On 7/25/23 18:43, Danilo Krummrich wrote: >> > On 7/25/23 18:16, Faith Ekstrand wrote: >> >> Thanks for the detailed write-up! That would definitely explain it. If >> >> I

Re: [PATCH v3 02/10] drm/panel: Check for already prepared/enabled in drm_panel

In my case a few different panel drivers disable the regulators in the unprepare/disable routines. For at least the Rockchip DSI implementations for some reason the panel gets unprepared more than once, which triggers an unbalanced regulator disable. Obviously though the correct course of action

Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

On 7/29/23 01:03, Gurchetan Singh wrote: > On Wed, Jul 19, 2023 at 11:58 AM Dmitry Osipenko < > dmitry.osipe...@collabora.com> wrote: > >> 27.06.2023 20:16, Rob Clark пишет: >> ... Now these are just suggestions, and while I think they are good, you >> can safely ignore them. But

Re: [PATCH -next] drm/amdgpu: Remove a lot of unnecessary ternary operators

On 7/31/23 6:26 AM, Ruan Jinjie wrote: Ther are many ternary operators, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie --- snip data->registry_data.avfs_support = - hwmgr->feature_mask & PP_AVFS_MASK ? true :

Re: [PATCH -next] drm/amdgpu: Remove a lot of unnecessary ternary operators

On 7/31/2023 8:26 AM, Ruan Jinjie wrote: Ther are many ternary operators, the true or false judgement of which is unnecessary in C language semantics. s/Ther/There/ Unnecessary; sure. But don't they improve the readability quite a bit? Signed-off-by: Ruan Jinjie ---

[PATCH 6/6] accel/ivpu: Add initial support for VPU 4

Add support VPU 4 - new generation of VPU IP with various hardware design improvements. From driver point of view, it differs in register set, initialization process and MMU memory ranges. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Co-developed-by: Krystian Pradzynski

[PATCH 5/6] accel/ivpu: Refactor memory ranges logic

From: Karol Wachowski Add new dma range and change naming convention for virtual address memory ranges managed by KMD. New available ranges are named as follows: * global range - global context accessible by FW * aliased range - user context accessible by FW * dma range - user context

[PATCH 4/6] accel/ivpu: Add param ioctl to identify capabilities

Add DRM_IVPU_PARAM_CAPABILITIES ioctl to query driver capabilities. For now use it for identify metric streamer and new dma memory range features. Currently upstream version of intel_vpu does not have those, they will be added it the future. Reviewed-by: Jacek Lawrynowicz Signed-off-by:

[PATCH 3/6] accel/ivpu: Switch to generation based FW names

From: Jacek Lawrynowicz Use VPU IP generation for naming FW instead of the platform name. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_fw.c | 21 +++-- 1 file changed, 15 insertions(+), 6

[PATCH 1/6] accel/ivpu: Rename sources to use generation based names

From: Jacek Lawrynowicz Given that VPU generation can be used by multiple platforms, driver should use VPU IP generation in names instead of a platform names. Change naming for sources files. Use 37XX format, where: 3 - major VPU IP generation version 7 - minor VPU IP generation version

[PATCH 2/6] accel/ivpu: Use generation based function and registers names

From: Jacek Lawrynowicz Given that VPU generation can be used by multiple platforms, driver should use VPU IP generation names instead of a platform names. Change naming for functions and registries. Use 37XX format, where: 3 - major VPU IP generation version 7 - minor VPU IP generation

[PATCH 0/6] accel/ivpu: Refactor driver code and support new hardware

Various code additions and refactoring in order to add support for VPU IP 4, which be included in Intel Lunar Lake CPUs. Jacek Lawrynowicz (3): accel/ivpu: Rename sources to use generation based names accel/ivpu: Use generation based function and registers names accel/ivpu: Switch to

Re: [PATCH v7 4/4] drm/mediatek: Add DSI support for mt8188 vdosys0

Re: [PATCH 1/2] drm/exec: use unique instead of local label

On Mon, 31 Jul 2023 08:31:19 -0700 Nathan Chancellor wrote: > On Mon, Jul 31, 2023 at 02:36:24PM +0200, Christian König wrote: > > GCC forbids to jump to labels in loop conditions and a new clang > > check stumbled over this. > > > > So instead using a local label inside the loop condition use

Re: (subset) [PATCH v4 0/3] Add startek-kd070fhfid015 display support

Hi, On Mon, 31 Jul 2023 17:08:55 +0200, Alexandre Mergnat wrote: > Add the support of the Startek KD070FHFID015 panel. > It's a 7-inch TFT LCD display with a resolution of 1024 x 600 pixels. > > I use this display plugged to my mt8365-evk board. > > This serie come from a bigger one [1]. Then I

Re: [PATCH 1/2] drm/exec: use unique instead of local label

On Mon, Jul 31, 2023 at 02:36:24PM +0200, Christian König wrote: > GCC forbids to jump to labels in loop conditions and a new clang > check stumbled over this. > > So instead using a local label inside the loop condition use an > unique label outside of it. > > Fixes: commit 09593216bff1 ("drm:

[PATCH v4 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support

The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution of 1024 x 600 pixels. Reviewed-by: Conor Dooley Signed-off-by: Alexandre Mergnat --- .../display/panel/startek,kd070fhfid015.yaml | 69 ++ 1 file changed, 69 insertions(+) diff --git

[PATCH v4 2/3] drm/panel: Support for startek-kd070fhfid015 MIPI-DSI panel

From: Guillaume La Roque This driver support the Startek KD070FHFID015, which is a 7-inch TFT LCD display using MIPI DSI interface. Signed-off-by: Guillaume La Roque Reviewed-by: Neil Armstrong Signed-off-by: Alexandre Mergnat --- drivers/gpu/drm/panel/Kconfig | 11 +

[PATCH v4 3/3] arm64: defconfig: enable STARTEK KD070FHFID015 panel

Build Startek KD070FHFID015 panel driver. This MIPI-DSI display can be used for the mt8365-evk board for example. Signed-off-by: Alexandre Mergnat --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig

[PATCH v4 0/3] Add startek-kd070fhfid015 display support

Add the support of the Startek KD070FHFID015 panel. It's a 7-inch TFT LCD display with a resolution of 1024 x 600 pixels. I use this display plugged to my mt8365-evk board. This serie come from a bigger one [1]. Then I addressed the previous comments for the related commits here. [1]:

Re: [PATCH v10] drm: Add initial ci/ subdirectory

On Mon, Jul 31, 2023 at 5:25 AM Helen Mae Koike Fornazier wrote: > > Hello all, > > Thanks for your comments. > > On Friday, July 28, 2023 11:37 -03, Rob Clark wrote: > > > On Thu, Jul 27, 2023 at 10:26 PM Daniel Stone wrote: > > > > > > On Thu, 27 Jul 2023 at 22:47, Rob Clark wrote: > > > > >

Re: [PATCH] drm/amd/display: check attr flag before set cursor degamma on DCN3+

On 2023-07-31 04:35, Melissa Wen wrote: > Don't set predefined degamma curve to cursor plane if the cursor > attribute flag is not set. Applying a degamma curve to the cursor by > default breaks userspace expectation. Checking the flag before > performing any color transformation prevents too

[PATCH] drivers: gpu: drm: nouveau: fix invalid variable name

This commit fixes logic error in function 'nvkm_dp_train': argument of function nvkm_dp_train_link might be rate, not ret Co-developed-by: Ivanov Mikhail Signed-off-by: Konstantin Meskhidze --- drivers/gpu/drm/nouveau/nvkm/engine/disp/dp.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support

The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution of 1024 x 600 pixels. Reviewed-by: Conor Dooley Signed-off-by: Alexandre Mergnat --- .../display/panel/startek,kd070fhfid015.yaml | 69 ++ 1 file changed, 69 insertions(+) diff --git

[PATCH v3 3/3] arm64: defconfig: enable STARTEK KD070FHFID015 panel

Build Startek KD070FHFID015 panel driver. This MIPI-DSI display can be used for the mt8365-evk board for example. Signed-off-by: Alexandre Mergnat --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig

[PATCH v3 2/3] drm/panel: Support for startek-kd070fhfid015 MIPI-DSI panel

From: Guillaume La Roque This driver support the Startek KD070FHFID015, which is a 7-inch TFT LCD display using MIPI DSI interface. Signed-off-by: Guillaume La Roque Reviewed-by: Neil Armstrong Signed-off-by: Alexandre Mergnat --- drivers/gpu/drm/panel/Kconfig | 11 +

[PATCH v3 0/3] Add startek-kd070fhfid015 display support

Add the support of the Startek KD070FHFID015 panel. It's a 7-inch TFT LCD display with a resolution of 1024 x 600 pixels. I use this display plugged to my mt8365-evk board. This serie come from a bigger one [1]. Then I addressed the previous comments for the related commits here. [1]:

Re: [PATCH v3] drm/bridge: Add debugfs print for bridge chains

Hi Tomi, Am Montag, 31. Juli 2023, 14:13:14 CEST schrieb Tomi Valkeinen: > DRM bridges are not visible to the userspace and it may not be > immediately clear if the chain is somehow constructed incorrectly. I > have had two separate instances of a bridge driver failing to do a >

Re: [PATCH v3 0/4] mm: convert to vma_is_initial_heap/stack()

On Fri, Jul 28, 2023 at 01:00:39PM +0800, Kefeng Wang wrote: > Kefeng Wang (4): > mm: factor out VMA stack and heap checks > drm/amdkfd: use vma_is_initial_stack() and vma_is_initial_heap() > selinux: use vma_is_initial_stack() and vma_is_initial_heap() > perf/core: use

Re: [PATCH v14 02/12] drm/shmem-helper: Add pages_pin_count field

+Danilo, to confirm my understanding of the gpuva remap operation is correct. On Mon, 31 Jul 2023 15:27:31 +0300 Dmitry Osipenko wrote: > On 7/25/23 11:32, Boris Brezillon wrote: > >> Can we make it an atomic_t, so we can avoid taking the lock when the > >> GEM has already been pinned. That's

[PATCH -next] drm/amdgpu: Remove a lot of unnecessary ternary operators

Ther are many ternary operators, the true or false judgement of which is unnecessary in C language semantics. Signed-off-by: Ruan Jinjie --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 2 +- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c

[PATCH -next] drm/omap: remove redundant of_match_ptr

The driver depends on CONFIG_OF, so it is not necessary to use of_match_ptr here. Even for drivers that do not depend on CONFIG_OF, it's almost always better to leave out the of_match_ptr(), since the only thing it can possibly do is to save a few bytes of .text if a driver can be used both with

[PATCH -next] drm/mcde: remove redundant of_match_ptr

The driver depends on CONFIG_OF, so it is not necessary to use of_match_ptr here. Even for drivers that do not depend on CONFIG_OF, it's almost always better to leave out the of_match_ptr(), since the only thing it can possibly do is to save a few bytes of .text if a driver can be used both with

Re: [PATCH -next] drm/exynos: remove redundant of_match_ptr

On 31/07/2023 14:33, Zhu Wang wrote: > The driver depends on CONFIG_OF, so it is not necessary to use > of_match_ptr here. > > Even for drivers that do not depend on CONFIG_OF, it's almost always > better to leave out the of_match_ptr(), since the only thing it can > possibly do is to save a few

Re: [PATCH] fbdev: fbmem: mark registered_fb static

On 7/14/23 02:37, Min-Hua Chen wrote: Mark registered_fb, num_registered_fb, fbcon_registered_fb, and fbcon_num_registered_fb static to fix the following sparse warnings: drivers/video/fbdev/core/fbmem.c:51:16: sparse: warning: symbol 'registered_fb' was not declared. Should it be static?

[PATCH v7 10/13] drm/mediatek: gamma: Make sure relay mode is disabled

Disable relay mode at the end of LUT programming to make sure that the processed image goes through. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jason-JH.Lin Reviewed-by: Alexandre Mergnat --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 1 file changed, 4 insertions(+)

[PATCH v7 02/13] drm/mediatek: gamma: Reduce indentation in mtk_gamma_set_common()

Invert the check for state->gamma_lut and move it at the beginning of the function to reduce indentation: this prepares the code for keeping readability on later additions. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jason-JH.Lin

[PATCH v7 09/13] drm/mediatek: gamma: Add support for 12-bit LUT and MT8195

Add support for 12-bit gamma lookup tables and introduce the first user for it: MT8195. While at it, also reorder the variables in mtk_gamma_set_common() and rename `lut_base` to `lut0_base` to improve readability. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jason-JH.Lin

[PATCH v7 01/13] drm/mediatek: gamma: Adjust mtk_drm_gamma_set_common parameters

From: "Jason-JH.Lin" Adjust the parameters in mtk_drm_gamma_set_common() - add (struct device *dev) to get lut_diff from gamma's driver data - remove (bool lut_diff) and use false as default value in the function Signed-off-by: Jason-JH.Lin Signed-off-by: AngeloGioacchino Del Regno

[PATCH v7 13/13] drm/mediatek: gamma: Add kerneldoc for struct mtk_disp_gamma

The mtk_disp_gamma structure was completely undocumented: add some kerneldoc documentation to it. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH v7 04/13] drm/mediatek: gamma: Improve and simplify HW LUT calculation

Use drm_color_lut_extract() to avoid open-coding the bits reduction calculations for each color channel and use a struct drm_color_lut to temporarily store the information instead of an array of u32. Also, slightly improve the precision of the HW LUT calculation in the LUT DIFF case by performing

[PATCH v7 08/13] drm/mediatek: gamma: Support multi-bank gamma LUT

Newer Gamma IP have got multiple LUT banks: support specifying the size of the LUT banks and handle bank-switching before programming the LUT in mtk_gamma_set_common() in preparation for adding support for MT8195 and newer SoCs. Suggested-by: Jason-JH.Lin [Angelo: Refactored original commit]

[PATCH v7 12/13] drm/mediatek: aal: Rewrite kerneldoc for struct mtk_disp_aal

The kerneldoc for struct mtk_disp_aal was entirely wrong: rewrite it to actually document the structure. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_aal.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH v7 11/13] drm/mediatek: gamma: Program gamma LUT type for descending or rising

All of the SoCs that don't have dithering control in the gamma IP have got a GAMMA_LUT_TYPE bit that tells to the IP if the LUT is "descending" (bit set) or "rising" (bit cleared): make sure to set it correctly after programming the LUT. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by:

[PATCH v7 07/13] drm/mediatek: gamma: Support specifying number of bits per LUT component

New SoCs, like MT8195, not only may support bigger lookup tables, but have got a different register layout to support bigger precision: support specifying the number of `lut_bits` for each SoC and use it in mtk_gamma_set_common() to perform the right calculation. Signed-off-by: AngeloGioacchino

[PATCH v7 05/13] drm/mediatek: gamma: Enable the Gamma LUT table only after programming

Move the write to DISP_GAMMA_CFG to enable the Gamma LUT to after programming the actual table to avoid potential visual glitches during table modification. Note: GAMMA should get enabled in between vblanks, but this requires many efforts in order to make this happen, as that requires migrating

[PATCH v7 03/13] drm/mediatek: gamma: Support SoC specific LUT size

Newer SoCs support a bigger Gamma LUT table: wire up a callback to retrieve the correct LUT size for each different Gamma IP. Co-developed-by: Jason-JH.Lin Signed-off-by: Jason-JH.Lin [Angelo: Rewritten commit message/description + porting] Signed-off-by: AngeloGioacchino Del Regno

[PATCH v7 06/13] drm/mediatek: gamma: Use bitfield macros

Make the code more robust and improve readability by using bitfield macros instead of open coding bit operations. While at it, also add a definition for LUT_BITS_DEFAULT. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Jason-JH.Lin Reviewed-by: Alexandre Mergnat ---

[PATCH v7 00/13] MediaTek DDP GAMMA - 12-bit LUT support

Changes in v7: - Added check for NULL dev for AAL-gamma case - Added get_lut_size callback for AAL-gamma - Added comment to clarify SoC 10/12 bits support and old vs new register layout as suggested by Alexandre M. Changes in v6: - Fixed smatch warning in patch 11/11, ref.:

Re: [PATCH v14 12/12] drm/gem: Add _unlocked postfix to drm_gem_pin/unpin()

On 7/25/23 10:53, Boris Brezillon wrote: > On Sun, 23 Jul 2023 02:47:46 +0300 > Dmitry Osipenko wrote: > >> Make clear that drm_gem_pin/unpin() functions take reservation lock by >> adding _unlocked postfix to the function names. >> >> Suggested-by: Boris Brezillon >> Signed-off-by: Dmitry

  1   2   >