Re: [RESEND v3 1/5] drm/amdgpu: Create a module param to disable soft recovery

2023-08-14 Thread Christian König
Am 10.08.23 um 21:23 schrieb André Almeida: Create a module parameter to disable soft recoveries on amdgpu, making every recovery go through the device reset path. This option makes easier to force device resets for testing and debugging purposes. I'm still torn apart on this. On the one hand i

Re: [PATCH v2 02/14] dt-bindings: display/msm/gmu: Allow passing QMP handle

2023-08-14 Thread Krzysztof Kozlowski
On 08/08/2023 23:02, Konrad Dybcio wrote: > When booting the GMU, the QMP mailbox should be pinged about some tunables > (e.g. adaptive clock distribution state). To achieve that, a reference to > it is necessary. Allow it and require it with A730. > > Tested-by: Neil Armstrong # on SM8550-QRD >

Re: [RFC PATCH 1/3] drm/virtio: .release ops for virtgpu fence release

2023-08-14 Thread Dmitry Osipenko
On 7/13/23 01:44, Dongwon Kim wrote: > virtio_gpu_fence_release is added to free virtio-gpu-fence > upon release of dma_fence. > > Cc: Gerd Hoffmann > Cc: Vivek Kasireddy > Signed-off-by: Dongwon Kim > --- > drivers/gpu/drm/virtio/virtgpu_fence.c | 8 > 1 file changed, 8 insertions(+)

Implement svm without BO concept in xe driver

2023-08-14 Thread Zeng, Oak
Hi Thomas, Matt and all, This came up when I port i915 svm codes to xe driver. In i915 implementation, we have i915_buddy manage gpu vram and svm codes directly call i915_buddy layer to allocate/free vram. There is no gem_bo/ttm bo concept involved in the svm implementation. In xe driver, we

Re: [PATCH v2 0/3] Resolve suspend-resume racing with GuC destroy-context-worker

2023-08-14 Thread Teres Alexis, Alan Previn
On Mon, 2023-08-14 at 18:12 -0700, Teres Alexis, Alan Previn wrote: > This series is the result of debugging issues root caused to > races between the GuC's destroyed_worker_func being triggered > vs repeating suspend-resume cycles with concurrent delayed > fence signals for engine-freeing. alan: f

[PATCH v2 1/3] drm/i915/guc: Flush context destruction worker at suspend

2023-08-14 Thread Alan Previn
When suspending, flush the context-guc-id deregistration worker at the final stages of intel_gt_suspend_late when we finally call gt_sanitize that eventually leads down to __uc_sanitize so that the deregistration worker doesn't fire off later as we reset the GuC microcontroller. Signed-off-by: Ala

[PATCH v2 2/3] drm/i915/guc: Close deregister-context race against CT-loss

2023-08-14 Thread Alan Previn
If we are at the end of suspend or very early in resume its possible an async fence signal could lead us to the execution of the context destruction worker (after the prior worker flush). Even if checking that the CT is enabled before calling destroyed_worker_func, guc_lrc_desc_unpin may still fai

[PATCH v2 0/3] Resolve suspend-resume racing with GuC destroy-context-worker

2023-08-14 Thread Alan Previn
This series is the result of debugging issues root caused to races between the GuC's destroyed_worker_func being triggered vs repeating suspend-resume cycles with concurrent delayed fence signals for engine-freeing. The reproduction steps require that an app is launched right before the start of t

[PATCH v2 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-08-14 Thread Alan Previn
When suspending, add a timeout when calling intel_gt_pm_wait_for_idle else if we have a lost G2H event that holds a wakeref (which would be indicative of a bug elsewhere in the driver), driver will at least complete the suspend-resume cycle, (albeit not hitting all the targets for low power hw coun

Re: [Intel-gfx] [PATCH v1 1/3] drm/i915/guc: Flush context destruction worker at suspend

2023-08-14 Thread Teres Alexis, Alan Previn
> > > Rodrigo: And why here and not some upper layer? like in prepare > alan: wait_for_suspend does both the checking for idle as well as the > potential > wedging if guc or hw has hung at this late state. if i call from the upper > layer before this wait_for_suspend, it might be too early b

[PULL for v6.6] drm-misc-next

2023-08-14 Thread Helen Koike
The following changes since commit f5d8f9c0d8b4bc8ad7e7b23a9f4d116e99202dd3: drm/panel: JDI LT070ME05000 simplify with dev_err_probe() (2023-08-14 14:44:30 +0200) are available in the Git repository at: g...@gitlab.freedesktop.org:helen.fornazier/linux.git tags/drm-ci-v13-drm-misc for you

Re: [PULL] drm-misc-next

2023-08-14 Thread Helen Mae Koike Fornazier
On Monday, August 14, 2023 19:17 -03, Helen Koike wrote: > The following changes since commit f5d8f9c0d8b4bc8ad7e7b23a9f4d116e99202dd3: > > drm/panel: JDI LT070ME05000 simplify with dev_err_probe() (2023-08-14 > 14:44:30 +0200) > > are available in the Git repository at: > > g...@gitlab.

[PATCH v3 0/3] drm/i915/pxp/mtl: Update gsc-heci cmd submission

2023-08-14 Thread Alan Previn
For MTL, update the GSC-HECI packet size and the max firmware response timeout to match internal fw specs. Enforce setting run-alone bit in LRC for protected contexts. Changes from prio revs: v2: - Patch #3: fix sparse warning reported by kernel test robot. v1: - N/A (Re-test) Signed-off-by

[PULL] drm-misc-next

2023-08-14 Thread Helen Koike
The following changes since commit f5d8f9c0d8b4bc8ad7e7b23a9f4d116e99202dd3: drm/panel: JDI LT070ME05000 simplify with dev_err_probe() (2023-08-14 14:44:30 +0200) are available in the Git repository at: g...@gitlab.freedesktop.org:helen.fornazier/linux.git tags/drm-ci-v12-drm-misc for you

[PATCH v3 6/6] drm/tests: Add KUnit tests for drm_fb_memcpy()

2023-08-14 Thread Arthur Grillo
Insert parameterized test for the drm_fb_memcpy() to ensure correctness and prevent future regressions. The test case can accept different formats. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 362 + 1 file changed, 362 insertions(+)

[PATCH v3 5/6] drm/tests: Add multi-plane support to conversion_buf_size()

2023-08-14 Thread Arthur Grillo
The drm_fb_memcpy() supports multi-plane formats. To fully test it in the future, add multi-plane support to the conversion_buf_size() helper. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 28 +- 1 file changed

[PATCH v3 4/6] drm/tests: Add KUnit tests for drm_fb_build_fourcc_list()

2023-08-14 Thread Arthur Grillo
Insert parameterized test for the drm_fb_build_fourcc_list() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 144 + 1 file changed, 144 insertions(+) diff --git a/drivers/gpu/drm/test

[PATCH v3 3/6] drm/tests: Add KUnit tests for drm_fb_clip_offset()

2023-08-14 Thread Arthur Grillo
Insert parameterized test for the drm_fb_clip_offset() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 91 ++ 1 file changed, 91 insertions(+) diff --git a/d

[PATCH v3 2/6] drm/tests: Add KUnit tests for drm_fb_swab()

2023-08-14 Thread Arthur Grillo
Insert parameterized test for the drm_fb_swab() to ensure correctness and prevent future regressions. Each expected color has it bytes reversed in order, so xrgb would be bgrx. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_format_helper_test.c | 66 +++

[PATCH v3 1/6] drm/tests: Test default pitch fallback

2023-08-14 Thread Arthur Grillo
Test the default pitch fallback when NULL is passed as the dst_pitch on the conversion procedures. Reviewed-by: Maíra Canal Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_format_helper_test.c | 126 - 1 file changed, 81 insertions(+), 45 deletions(-) diff --

[PATCH v3 0/6] Increase code coverage on drm_format_helper.c

2023-08-14 Thread Arthur Grillo
The following series include improvements and new KUnit tests to some functions on drm_format_helper.c. The first patch improves existing conversion tests to assure that the default pitch is used when NULL is used on the `dst_pitch` argument. Patches 2, 3, 4, and 6 add the new parametrized tests

Re: [PATCH v2 08/14] drm/msm/a6xx: Add skeleton A7xx support

2023-08-14 Thread Rob Clark
On Tue, Aug 8, 2023 at 2:03 PM Konrad Dybcio wrote: > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h > b/drivers/gpu/drm/msm/adreno/adreno_gpu.h > index 49f38edf9854..3e69ef9dde3f 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h > @@ -

[drm-misc:for-linux-next 3/3] drivers/gpu/drm/ttm/tests/ttm_pool_test.c:231:37: warning: cast to pointer from integer of different size

2023-08-14 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: f5d8f9c0d8b4bc8ad7e7b23a9f4d116e99202dd3 commit: 204042049a941d2a9a7d49bdcda768578b5f88ec [3/3] drm/ttm/tests: Add tests for ttm_pool config: arm-randconfig-m041-20230815 (https://download.01.org/0day-ci/archive/20230815/20

Re: [PATCH v2 6/6] drm/tests: Add KUnit tests for drm_fb_memcpy()

2023-08-14 Thread Arthur Grillo
On 13/08/23 10:30, Maira Canal wrote: > Hi Arthur, > > On 8/11/23 15:17, Arthur Grillo wrote: >> Insert parameterized test for the drm_fb_memcpy() to ensure correctness >> and prevent future regressions. The test case can accept different >> formats. >> >> Signed-off-by: Arthur Grillo >> --- >

Re: [PATCH v1] drm/i915: Fix TLB-Invalidation seqno store

2023-08-14 Thread Andi Shyti
Hi Alan, On Mon, Aug 14, 2023 at 11:24:49AM -0700, Alan Previn wrote: > When getting the next gt's seqno to be stored into an > objects mm.tlb[gt_id] array, fix the retrieval code > to get it from the correct gt instead of the same one. > > Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on e

[PATCH v1] drm/i915: Fix TLB-Invalidation seqno store

2023-08-14 Thread Alan Previn
When getting the next gt's seqno to be stored into an objects mm.tlb[gt_id] array, fix the retrieval code to get it from the correct gt instead of the same one. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/i915_vma.c | 2 +-

Re: [PATCH] drm/radeon: Use pci_dev_id() to simplify the code

2023-08-14 Thread Alex Deucher
Applied. Thanks! On Fri, Aug 11, 2023 at 9:45 AM Zheng Zengkai wrote: > > PCI core API pci_dev_id() can be used to get the BDF number for a pci > device. We don't need to compose it mannually. Use pci_dev_id() to > simplify the code a little bit. > > Signed-off-by: Zheng Zengkai > --- > driver

Re: [PATCH] drm/panel: Add prepare_prev_first flag to Visionox VTDR6130

2023-08-14 Thread Abhinav Kumar
Hi Neil On 8/14/2023 1:01 AM, neil.armstr...@linaro.org wrote: Hi Abhinav, On 10/08/2023 18:26, Abhinav Kumar wrote: Hi Neil On 8/3/2023 10:19 AM, Jessica Zhang wrote: On 7/31/2023 6:00 AM, Neil Armstrong wrote: Hi, On 26/07/2023 00:56, Jessica Zhang wrote: Due to a recent introduction o

Re: [PATCH] drm/amd/pm: Clean up errors in amdgpu_smu.h

2023-08-14 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 5:30 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following enum go on the same line > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v11_0_pptable.h

2023-08-14 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 5:22 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > ERROR: open brace '{' following struct go on the same line > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/i915: Fix Kconfig error for CONFIG_DRM_I915

2023-08-14 Thread Wang Jinchao
On Mon, Aug 14, 2023 at 03:13:32PM +0300, Jani Nikula wrote: > On Mon, 14 Aug 2023, Wang Jinchao wrote: > > On Mon, Aug 14, 2023 at 10:26:45AM +0300, Jani Nikula wrote: > >> On Sat, 12 Aug 2023, Wang Jinchao wrote: > >> > When CONFIG_DRM_I915 is set to 'y' and CONFIG_BACKLIGHT_CLASS_DEVICE > >> >

Re: [PATCH 1/2] drm: rcar-du: Add more formats to DRM_MODE_BLEND_PIXEL_NONE support

2023-08-14 Thread Damian Hobson-Garcia
Hi Laurent, On 2023/08/14 6:46, Laurent Pinchart wrote: On Fri, Aug 04, 2023 at 06:52:51PM +0300, Laurent Pinchart wrote: On Fri, Aug 04, 2023 at 11:49:32AM -0400, Damian Hobson-Garcia wrote: On 2023/08/03 20:06, Laurent Pinchart wrote: On Fri, Aug 04, 2023 at 02:53:17AM +0300, Laurent Pinch

Re: [PATCH] drm/i915: Fix Kconfig error for CONFIG_DRM_I915

2023-08-14 Thread Wang Jinchao
On Mon, Aug 14, 2023 at 10:26:45AM +0300, Jani Nikula wrote: > On Sat, 12 Aug 2023, Wang Jinchao wrote: > > When CONFIG_DRM_I915 is set to 'y' and CONFIG_BACKLIGHT_CLASS_DEVICE > > is set to 'm', we encountered an ld.lld error during the build process: > > > > ld.lld: error: undefined symbol:

Re: [PATCH v1] MAINTAINERS: Add Boris Brezillon as Panfrost driver maintainer

2023-08-14 Thread Dmitry Osipenko
On 7/17/23 11:15, Dmitry Osipenko wrote: > Add Boris Brezillon as Panfrost driver maintainer. Boris is a new lead > developer of the Panfrost Mesa driver and main developer behind the > upcoming Panthor kernel driver that will serve next-gen Mali GPUs. > > Remove Tomeu and Alyssa, who left Collabo

Re: [PATCH 3/3] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-14 Thread Shashank Sharma
Ah, Thanks for pointing that out Alex. @Arvind, please refer to the patch (https://patchwork.freedesktop.org/patch/504854/?series=109060&rev=4) in previous series of SMU workload hints with UAPI (here: https://patchwork.freedesktop.org/series/109060/) Regards Shashank On 14/08/2023 17:20,

Re: [PATCH v2 08/15] drm/panthor: Add the MMU/VM logical block

2023-08-14 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > MMU and VM management is related and placed in the same source file. > > Page table updates are delegated to the io-pgtable-arm driver that's in > the iommu subsystem. > > The VM management logic is based on drm_gpuva_mgr, and is assuming the > VA spa

Re: [PATCH 3/3] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-14 Thread Alex Deucher
KFD also changes the profile when queues are active. Please make sure that is properly taken into account as well. Alex On Mon, Aug 14, 2023 at 3:36 AM Arvind Yadav wrote: > > This reverts commit 5ce71f59bb9bd3d8a09b96afdbc92975cb6dc303. > > Reason for revert: New amdgpu_smu* api is added to sw

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Takashi Iwai
On Mon, 14 Aug 2023 16:51:08 +0200, Karol Herbst wrote: > > I've sent a patch out to address this memory corruption > https://patchwork.freedesktop.org/patch/552642/ > > It might or might not fix regressions from the original I2C fix, so > please test and report if there are remaining issues. Th

Re: [PATCH 1/3] drm/amdgpu: Add new api to switch on/off power profile mode

2023-08-14 Thread Shashank Sharma
Hey Arvind, On 14/08/2023 09:34, Arvind Yadav wrote: This patch adds a function which will allow to change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by:

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Mon, Aug 14, 2023 at 4:19 PM Karol Herbst wrote: > > On Mon, Aug 14, 2023 at 3:35 PM Takashi Iwai wrote: > > > > On Mon, 14 Aug 2023 15:19:11 +0200, > > Karol Herbst wrote: > > > > > > On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst wrote: > > > > > > > > On Mon, Aug 14, 2023 at 2:48 PM Takashi

[PATCH] drm/nouveau/disp: fix use-after-free in error handling of nouveau_connector_create

2023-08-14 Thread Karol Herbst
We can't simply free the connector after calling drm_connector_init on it. We need to clean up the drm side first. It might not fix all regressions from 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts"), but at least it fixes a memory corruption in error handlin

Re: [PATCH RFC 03/13] drm/connector: hdmi: Add Broadcast RGB property

2023-08-14 Thread Simon Ser
+1 for a standardized property. wlroots is blocked on the kernel making this property standard before starting using it. Can docs be added in the "Standard Connector Properties" section?

Re: [REGRESSION] HDMI connector detection broken in 6.3 on Intel(R) Celeron(R) N3060 integrated graphics

2023-08-14 Thread Imre Deak
On Sun, Aug 13, 2023 at 03:41:30PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: Hi, > On 11.08.23 20:10, Mikhail Rudenko wrote: > > On 2023-08-11 at 08:45 +02, Thorsten Leemhuis > > wrote: > >> On 10.08.23 21:33, Mikhail Rudenko wrote: > >>> The following is a copy an issue I pos

Re: [PATCH 1/3] drm/amdgpu: Add new api to switch on/off power profile mode

2023-08-14 Thread Alex Deucher
On Mon, Aug 14, 2023 at 3:35 AM Arvind Yadav wrote: > > This patch adds a function which will allow to > change the GPU power profile based on a submitted job. > This can optimize the power performance when the > workload is on. A few minor comments inline below. One thing to double check is tha

Re: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-08-14 Thread Andrew Lunn
On Mon, Aug 14, 2023 at 09:50:49AM +, Quan, Evan wrote: > [AMD Official Use Only - General] > > Hi Andrew, > > I sent out a new V8 series last week. > A kernel parameter `wbrf` was introduced there to decide the policy. > Please help to check whether that makes sense to you. > Please share yo

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Mon, Aug 14, 2023 at 3:35 PM Takashi Iwai wrote: > > On Mon, 14 Aug 2023 15:19:11 +0200, > Karol Herbst wrote: > > > > On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst wrote: > > > > > > On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai wrote: > > > > > > > > On Mon, 14 Aug 2023 14:38:18 +0200, > > >

[PATCH -next] video: fbdev: kyro: Remove unused declarations

2023-08-14 Thread Yue Haibing
These declarations is never implemented since the beginning of git history. Signed-off-by: Yue Haibing --- include/video/kyro.h | 12 1 file changed, 12 deletions(-) diff --git a/include/video/kyro.h b/include/video/kyro.h index b958c2e9c915..418eef6c5523 100644 --- a/include/video

[PATCH RFC 13/13] drm/vc4: hdmi: Switch to HDMI connector

2023-08-14 Thread Maxime Ripard
The new HDMI connector infrastructure allows us to remove a lot of boilerplate, so let's switch to it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 730 +++-- drivers/gpu/drm/vc4/vc4_hdmi.h | 37 +- drivers/gpu/drm/vc4/vc4_hdmi_phy.c

[PATCH RFC 12/13] drm/vc4: hdmi: Create destroy state implementation

2023-08-14 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 5261526d286f..ac5debd47e99 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drive

[PATCH RFC 11/13] drm/connector: hdmi: Create Infoframe DebugFS entries

2023-08-14 Thread Maxime Ripard
There has been some discussions recently about the infoframes sent by drivers and if they were properly generated. In parallel, there's been some interest in creating an infoframe-decode tool similar to edid-decode. Both would be much easier if we were to expose the infoframes programmed in the h

[PATCH RFC 09/13] drm/connector: hdmi: Compute bpc and format automatically

2023-08-14 Thread Maxime Ripard
Now that we have all the infrastructure needed, we can add some code that will, for a given connector state and mode, compute the best output format and bpc. The algorithm is the same one than the one already found in i915 and vc4. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_hdmi_conne

[PATCH RFC 10/13] drm/connector: hdmi: Add Infoframes generation

2023-08-14 Thread Maxime Ripard
Infoframes in KMS is usually handled by a bunch of low-level helpers that require quite some boilerplate for drivers. This leads to discrepancies with how drivers generate them, and which are actually sent. Now that we have everything needed to generate them in the HDMI connector state, we can gen

[PATCH RFC 07/13] drm/connector: hdmi: Calculate TMDS character rate

2023-08-14 Thread Maxime Ripard
Most HDMI drivers have some code to calculate the TMDS character rate, usually to adjust an internal clock to match what the mode requires. Since the TMDS character rates mostly depends on the resolution, whether we need to repeat pixels or not, the bpc count and the format, we can now derive it f

[PATCH RFC 08/13] drm/connector: hdmi: Add custom hook to filter TMDS character rate

2023-08-14 Thread Maxime Ripard
Most of the HDMI controllers have an upper TMDS character rate limit they can't exceed. On "embedded"-grade display controllers, it will typically be lower than what high-grade monitors can provide these days, so drivers will filter the TMDS character rate based on the controller capabilities. To

[PATCH RFC 05/13] drm/connector: hdmi: Add output BPC to the connector state

2023-08-14 Thread Maxime Ripard
We'll add automatic selection of the output BPC in a following patch, but let's add it to the HDMI connector state already. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_hdmi_connector.c | 21 +++-- include/drm/drm_connector.h | 13 - 2 files changed,

[PATCH RFC 06/13] drm/connector: hdmi: Add support for output format

2023-08-14 Thread Maxime Ripard
Just like BPC, we'll add support for automatic selection of the output format for HDMI connectors. Let's add the needed defaults and fields for now. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_hdmi_connector.c | 29 + include/drm/drm_connector.h |

[PATCH RFC 03/13] drm/connector: hdmi: Add Broadcast RGB property

2023-08-14 Thread Maxime Ripard
The i915 driver has a property to force the RGB range of an HDMI output. The vc4 driver then implemented the same property with the same semantics. KWin has support for it, and a PR for mutter is also there to support it. Both drivers implementing the same property with the same semantics, plus th

[PATCH RFC 04/13] drm/connector: hdmi: Add helper to get the RGB range

2023-08-14 Thread Maxime Ripard
HDMI controller drivers will need to figure out the RGB range they need to configure based on a given atomic state. Let's provide a helper to provide that information. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_hdmi_connector.c | 41 include/drm/dr

[PATCH RFC 02/13] drm/connector: hdmi: Create a custom state

2023-08-14 Thread Maxime Ripard
The next features we will need to share across drivers will need to store some parameters for drivers to use, such as the selected output format. Let's create a new connector state dedicated to HDMI controllers, that will eventually store everything we need. Signed-off-by: Maxime Ripard --- dri

[PATCH RFC 01/13] drm/connector: Introduce an HDMI connector

2023-08-14 Thread Maxime Ripard
A lot of the various HDMI drivers duplicate some logic that depends on the HDMI spec itself and not really a particular hardware implementation. Output BPC or format selection, infoframe generation are good examples of such areas. This creates a lot of boilerplate, with a lot of variations, which

[PATCH RFC 00/13] drm/connector: Create HDMI Connector infrastructure

2023-08-14 Thread Maxime Ripard
drivers/gpu/drm/vc4/vc4_hdmi.h | 37 +- drivers/gpu/drm/vc4/vc4_hdmi_phy.c |4 +- include/drm/drm_connector.h | 256 6 files changed, 1508 insertions(+), 622 deletions(-) --- base-commit: 5d0c230f1de8c7515b6567d9afba1f196fb4e2f4 change-id: 20230814-kms-hdmi-

Re: [PATCH v2] drm/panel: simple: Fix Innolux G156HCE-L01 LVDS clock

2023-08-14 Thread Neil Armstrong
Hi, On 14/08/2023 15:40, Luca Ceresoli wrote: This panel has been implemented in commit 225213f24c79 ("drm/panel-simple: Add Innolux G156HCE-L01 panel entry") with a higher clock than the typical one mentioned on the documentation to avoid flickering on the unit tested. Testing on a different un

Re: [PATCH v2 07/15] drm/panthor: Add the devfreq logical block

2023-08-14 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > Every thing related to devfreq in placed in panthor_devfreq.c, and > helpers that can be called by other logical blocks are exposed through > panthor_devfreq.h. > > This implementation is loosely based on the panfrost implementation, > the only differe

[PATCH v2] drm/panel: simple: Fix Innolux G156HCE-L01 LVDS clock

2023-08-14 Thread Luca Ceresoli
This panel has been implemented in commit 225213f24c79 ("drm/panel-simple: Add Innolux G156HCE-L01 panel entry") with a higher clock than the typical one mentioned on the documentation to avoid flickering on the unit tested. Testing on a different unit shows that the panel actually works with the i

Re: [PATCH v2 06/15] drm/panthor: Add GEM logical block

2023-08-14 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > Anything relating to GEM object management is placed here. Nothing > particularly interesting here, given the implementation is based on > drm_gem_shmem_object, which is doing most of the work. > > v2: > - Rename the driver (pancsf -> panthor) > - Chan

Re: [PATCH] drm/panel: simple: Fix Innolux G156HCE-L01 LVDS clock

2023-08-14 Thread Luca Ceresoli
Hello Neil, On Mon, 14 Aug 2023 14:38:51 +0200 Neil Armstrong wrote: > On 04/08/2023 17:10, Luca Ceresoli wrote: > > This panel has been implemented in commit 225213f24c79 ("drm/panel-simple: > > Add Innolux G156HCE-L01 panel entry") with a higher clock than the typical > > one mentioned on the

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Takashi Iwai
On Mon, 14 Aug 2023 15:19:11 +0200, Karol Herbst wrote: > > On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst wrote: > > > > On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai wrote: > > > > > > On Mon, 14 Aug 2023 14:38:18 +0200, > > > Karol Herbst wrote: > > > > > > > > On Wed, Aug 9, 2023 at 6:16 PM Tak

Re: [PATCH 11/11] drm/bridge: tc358768: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support

2023-08-14 Thread Tomi Valkeinen
Hi Sam, On 14/08/2023 13:10, Sam Ravnborg wrote: Hi Tomi, From c13c691bd8826b978325575be9a87f577b83b86b Mon Sep 17 00:00:00 2001 From: Tomi Valkeinen Date: Mon, 14 Aug 2023 13:02:23 +0300 Subject: [PATCH] drm/bridge: tc358768: fix 'Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support' Signed-off-by

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Tue, Aug 8, 2023 at 3:47 PM Borislav Petkov wrote: > > On Tue, Aug 08, 2023 at 12:39:32PM +0200, Karol Herbst wrote: > > ahh, that would have been good to know :) > > Yeah, I didn't see it before - it would only freeze. Only after I added > the printk you requested. > > > Mind figuring out what

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst wrote: > > On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai wrote: > > > > On Mon, 14 Aug 2023 14:38:18 +0200, > > Karol Herbst wrote: > > > > > > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai wrote: > > > > > > > > On Wed, 09 Aug 2023 16:46:38 +0200, > > >

[GIT PULL FOR v6.6] drm: rcar-du: Miscellaneous changes

2023-08-14 Thread Laurent Pinchart
kernel/git/pinchartl/linux.git tags/drm-next-20230814 for you to fetch changes up to 97018453946bbca869640d92c19400b17e61b94b: drm:rcar-du: Enable ABGR and XBGR formats (2023-08-14 13:47:30 +0300) Renesas R-Car DU miscellaneo

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai wrote: > > On Mon, 14 Aug 2023 14:38:18 +0200, > Karol Herbst wrote: > > > > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai wrote: > > > > > > On Wed, 09 Aug 2023 16:46:38 +0200, > > > Takashi Iwai wrote: > > > > > > > > On Wed, 09 Aug 2023 15:13:23 +0200

Re: [PATCH 1/3] drm/amdgpu: Add new api to switch on/off power profile mode

2023-08-14 Thread Yadav, Arvind
On 8/14/2023 5:35 PM, Christian König wrote: Am 14.08.23 um 09:34 schrieb Arvind Yadav: This patch adds a function which will allow to change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. Cc: Shashank Sharma Cc: Christian Koe

Re: [PATCH] drm/panel: simple: Fix AUO G121EAN01 panel timings according to the docs

2023-08-14 Thread Neil Armstrong
Hi, On Fri, 04 Aug 2023 17:12:39 +0200, Luca Ceresoli wrote: > Commit 03e909acd95a ("drm/panel: simple: Add support for AUO G121EAN01.4 > panel") added support for this panel model, but the timings it implements > are very different from what the datasheet describes. I checked both the > G121EAN01

Re: [RESEND PATCH v2] drm/panel: JDI LT070ME05000 simplify with dev_err_probe()

2023-08-14 Thread Neil Armstrong
Hi, On Sat, 12 Aug 2023 20:52:39 +0200, David Heidelberg wrote: > Use the dev_err_probe() helper to simplify error handling during probe. > This also handle scenario, when EDEFER is returned and useless error is > printed. > > Fixes error: > panel-jdi-lt070me05000 470.dsi.0: cannot get enabl

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Takashi Iwai
On Mon, 14 Aug 2023 14:38:18 +0200, Karol Herbst wrote: > > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai wrote: > > > > On Wed, 09 Aug 2023 16:46:38 +0200, > > Takashi Iwai wrote: > > > > > > On Wed, 09 Aug 2023 15:13:23 +0200, > > > Takashi Iwai wrote: > > > > > > > > On Wed, 09 Aug 2023 14:19:23

Re: [RESEND PATCH v2] drm/panel: JDI LT070ME05000 simplify with dev_err_probe()

2023-08-14 Thread Neil Armstrong
Hi, On Sat, 12 Aug 2023 20:52:39 +0200, David Heidelberg wrote: > Use the dev_err_probe() helper to simplify error handling during probe. > This also handle scenario, when EDEFER is returned and useless error is > printed. > > Fixes error: > panel-jdi-lt070me05000 470.dsi.0: cannot get enabl

Re: [PATCH v4 1/2] dt-bindings: display: simple: Add Mitsubishi AA084XE01 panel

2023-08-14 Thread Neil Armstrong
Hi, On Mon, 07 Aug 2023 14:31:37 +0200, Miquel Raynal wrote: > Add Mitsubishi AA084XE01 8.4" XGA TFT LCD panel compatible string. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/2] dt-bindings: display: simple: Add Mitsubishi AA084XE01 panel

Re: [PATCH v3] drm/bridge: panel: Add a device link between drm device and panel device

2023-08-14 Thread Neil Armstrong
Hi, On Mon, 07 Aug 2023 14:11:15 +0800, Liu Ying wrote: > Add the device link when panel bridge is attached and delete the link > when panel bridge is detached. The drm device is the consumer while > the panel device is the supplier. This makes sure that the drm device > suspends eariler and res

Re: [PATCH] drm/panel: JDI LT070ME05000 drop broken link

2023-08-14 Thread Neil Armstrong
Hi, On Sat, 12 Aug 2023 20:34:03 +0200, David Heidelberg wrote: > Link is no longer functional and web.archive.org doesn't provide PDF > with detail information. > > Some informations can be found from web.archive.org here: > https://web.archive.org/web/20170629205602/http://panelone.net/en/7-0-i

Re: [RESEND PATCH v2] drm/panel: JDI LT070ME05000 simplify with dev_err_probe()

2023-08-14 Thread Neil Armstrong
On 12/08/2023 20:52, David Heidelberg wrote: Use the dev_err_probe() helper to simplify error handling during probe. This also handle scenario, when EDEFER is returned and useless error is printed. Fixes error: panel-jdi-lt070me05000 470.dsi.0: cannot get enable-gpio -517 Signed-off-by: Dav

Re: [PATCH] drm/panel: JDI LT070ME05000 drop broken link

2023-08-14 Thread Neil Armstrong
On 12/08/2023 20:34, David Heidelberg wrote: Link is no longer functional and web.archive.org doesn't provide PDF with detail information. Some informations can be found from web.archive.org here: https://web.archive.org/web/20170629205602/http://panelone.net/en/7-0-inch/JDI_LT070ME05000_7.0_inc

Re: [PATCH v4 2/2] drm/panel: simple: Add support for Mitsubishi AA084XE01

2023-08-14 Thread Neil Armstrong
On 07/08/2023 14:31, Miquel Raynal wrote: From: Thomas Weber Add support for the Mitsubishi AA084XE01 panel which is an 8.4 inch XGA TFT-LCD module for industrial use. Link: https://www.mouser.fr/datasheet/2/274/aa084xe01_e-364171.pdf Signed-off-by: Thomas Weber Signed-off-by: Miquel Raynal

Re: [PATCH] drm/panel: simple: Fix Innolux G156HCE-L01 LVDS clock

2023-08-14 Thread Neil Armstrong
On 04/08/2023 17:10, Luca Ceresoli wrote: This panel has been implemented in commit 225213f24c79 ("drm/panel-simple: Add Innolux G156HCE-L01 panel entry") with a higher clock than the typical one mentioned on the documentation to avoid flickering on the unit tested. Testing on a different unit sh

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai wrote: > > On Wed, 09 Aug 2023 16:46:38 +0200, > Takashi Iwai wrote: > > > > On Wed, 09 Aug 2023 15:13:23 +0200, > > Takashi Iwai wrote: > > > > > > On Wed, 09 Aug 2023 14:19:23 +0200, > > > Karol Herbst wrote: > > > > > > > > On Wed, Aug 9, 2023 at 1:46

Re: [PATCH] drm/panel: simple: Fix AUO G121EAN01 panel timings according to the docs

2023-08-14 Thread Neil Armstrong
On 04/08/2023 17:12, Luca Ceresoli wrote: Commit 03e909acd95a ("drm/panel: simple: Add support for AUO G121EAN01.4 panel") added support for this panel model, but the timings it implements are very different from what the datasheet describes. I checked both the G121EAN01.0 datasheet from [0] and

Re: [PATCH] drm/i915: Fix Kconfig error for CONFIG_DRM_I915

2023-08-14 Thread Jani Nikula
On Mon, 14 Aug 2023, Wang Jinchao wrote: > On Mon, Aug 14, 2023 at 10:26:45AM +0300, Jani Nikula wrote: >> On Sat, 12 Aug 2023, Wang Jinchao wrote: >> > When CONFIG_DRM_I915 is set to 'y' and CONFIG_BACKLIGHT_CLASS_DEVICE >> > is set to 'm', we encountered an ld.lld error during the build process

Re: [PATCH 1/3] drm/amdgpu: Add new api to switch on/off power profile mode

2023-08-14 Thread Christian König
Am 14.08.23 um 09:34 schrieb Arvind Yadav: This patch adds a function which will allow to change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yad

Re: [PATCH v2 13/15] drm/panthor: Allow driver compilation

2023-08-14 Thread Steven Price
On 11/08/2023 20:26, Robin Murphy wrote: > On 2023-08-11 17:56, Daniel Stone wrote: >> Hi, >> >> On 11/08/2023 17:35, Robin Murphy wrote: >>> On 2023-08-09 17:53, Boris Brezillon wrote: +obj-$(CONFIG_DRM_PANTHOR) += panthor.o >>> >>> FWIW I still think it would be nice to have a minor >>> dire

Re: [PATCH v2 05/15] drm/panthor: Add the GPU logical block

2023-08-14 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > Handles everything that's not related to the FW, the MMU or the > scheduler. This is the block dealing with the GPU property retrieval, > the GPU block power on/off logic, and some global operations, like > global cache flushing. > > v2: > - Rename the

Re: [PATCH 1/2] drm: rcar-du: Add more formats to DRM_MODE_BLEND_PIXEL_NONE support

2023-08-14 Thread Laurent Pinchart
On Fri, Aug 04, 2023 at 06:52:51PM +0300, Laurent Pinchart wrote: > On Fri, Aug 04, 2023 at 11:49:32AM -0400, Damian Hobson-Garcia wrote: > > On 2023/08/03 20:06, Laurent Pinchart wrote: > > > On Fri, Aug 04, 2023 at 02:53:17AM +0300, Laurent Pinchart wrote: > > >> On Fri, Aug 04, 2023 at 02:47:04A

Re: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-08-14 Thread Johannes Berg
On Tue, 2023-07-25 at 22:09 +0200, Andrew Lunn wrote: > > > It could well be that AMD based machine has a different ACPI extension > to indicate this policy to what Intel machine has. As far as i > understand it, you have not submitted this yet for formal approval, > this is all vendor specific,

Re: [PATCH v5] Documentation/gpu: Add a VM_BIND async draft document

2023-08-14 Thread Thomas Hellström
On 7/19/23 16:24, Danilo Krummrich wrote: On 7/15/23 17:45, Thomas Hellström wrote: Add a motivation for and description of asynchronous VM_BIND operation v2: - Fix typos (Nirmoy Das) - Improve the description of a memory fence (Oak Zeng) - Add a reference to the document in the Xe RFC. - Add

Re: [PATCH 11/11] drm/bridge: tc358768: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support

2023-08-14 Thread Laurent Pinchart
On Mon, Aug 14, 2023 at 12:10:41PM +0200, Sam Ravnborg wrote: > > From c13c691bd8826b978325575be9a87f577b83b86b Mon Sep 17 00:00:00 2001 > > From: Tomi Valkeinen > > Date: Mon, 14 Aug 2023 13:02:23 +0300 > > Subject: [PATCH] drm/bridge: tc358768: fix 'Add > > DRM_BRIDGE_ATTACH_NO_CONNECTOR > > s

Re: [PATCH v6] drm/doc: Document DRM device reset expectations

2023-08-14 Thread Michel Dänzer
On 8/11/23 20:55, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Signed-off-by: André Almeida [...] > +Robustness > +-- > + > +The only way to try to keep an application working after a reset is if it > +

Re: [PATCH 11/11] drm/bridge: tc358768: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support

2023-08-14 Thread Sam Ravnborg
Hi Tomi, > From c13c691bd8826b978325575be9a87f577b83b86b Mon Sep 17 00:00:00 2001 > From: Tomi Valkeinen > Date: Mon, 14 Aug 2023 13:02:23 +0300 > Subject: [PATCH] drm/bridge: tc358768: fix 'Add DRM_BRIDGE_ATTACH_NO_CONNECTOR > support' > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/dr

Re: [PATCH 11/11] drm/bridge: tc358768: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support

2023-08-14 Thread Tomi Valkeinen
On 13/08/2023 20:11, Maxim Schwalm wrote: On 04.08.23 12:44, Tomi Valkeinen wrote: Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358768.c | 64 +++ 1 file changed, 45 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768

RE: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] Hi Andrew, I sent out a new V8 series last week. A kernel parameter `wbrf` was introduced there to decide the policy. Please help to check whether that makes sense to you. Please share your insights there. BR, Evan > -Original Message- > From: Andrew Lun

Re: [PATCH v4,2/3] drm/mediatek: dp: Add the audio packet flag to mtk_dp_data struct

2023-08-14 Thread Fei Shao
On Mon, Aug 14, 2023 at 3:29 PM Shuijing Li wrote: > > The audio packet arrangement function is to only arrange audio. > packets into the Hblanking area. In order to align with the HW > default setting of mt8195, this function needs to be turned off. > > Signed-off-by: Shuijing Li > Signed-off-by

RE: [PATCH] drm: bridge: it66121: Extend match support for OF tables

2023-08-14 Thread Biju Das
Hi Laurent Pinchart, Thanks for the feedback. > Subject: Re: [PATCH] drm: bridge: it66121: Extend match support for OF > tables > > Hi Biju, > > Thank you for the patch. > > On Sun, Aug 13, 2023 at 09:05:20AM +0100, Biju Das wrote: > > The driver has OF match table, still it uses ID lookup tab

  1   2   >