RE: [PATCH v1 0/3] udmabuf: Add support for page migration out of movable zone or CMA

2023-09-16 Thread Kasireddy, Vivek
Hi David, > >> I think it makes sense to have a generic (non-GUP) version of > >> check_and_migrate_movable_pages() available in migration.h that > >> drivers can use to ensure that they don't break memory hotunplug > >> accidentally. > > > > Definately not. > > > > Either use the VMA and

Re: [PATCH v3 12/13] drm/sched/doc: Add Entity teardown documentaion

2023-09-16 Thread Danilo Krummrich
On 9/12/23 04:16, Matthew Brost wrote: Provide documentation to guide in ways to teardown an entity. Signed-off-by: Matthew Brost --- Documentation/gpu/drm-mm.rst | 6 ++ drivers/gpu/drm/scheduler/sched_entity.c | 19 +++ 2 files changed, 25 insertions(+)

Re: [PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-16 Thread Danilo Krummrich
On 9/12/23 16:47, Matthew Brost wrote: On Tue, Sep 12, 2023 at 11:57:30AM +0200, Christian König wrote: Am 12.09.23 um 04:16 schrieb Matthew Brost: Wait for pending jobs to be complete before signaling queued jobs. This ensures dma-fence signaling order correct and also ensures the entity is

Re: [PATCH v3 02/13] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-09-16 Thread Danilo Krummrich
On 9/12/23 04:16, Matthew Brost wrote: In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 mapping between a drm_gpu_scheduler and drm_sched_entity. At first this seems a bit odd but let us explain the reasoning below. 1. In XE the submission order from multiple drm_sched_entity

[PATCH] drm/nouveau: sched: fix leaking memory of timedout job

2023-09-16 Thread Danilo Krummrich
Always stop and re-start the scheduler in order to let the scheduler free up the timedout job in case it got signaled. In case of exec jobs the job type specific callback will take care to signal all fences and tear down the channel. Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")

Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-16 Thread Danilo Krummrich
On 9/16/23 16:26, Dan Carpenter wrote: On Sat, Sep 16, 2023 at 05:24:04PM +0300, Dan Carpenter wrote: On Sat, Sep 16, 2023 at 01:41:43AM +0200, Danilo Krummrich wrote: Hi Dan, On 9/15/23 14:59, Dan Carpenter wrote: The u_memcpya() function is supposed to return error pointers on error.

Re: [PATCH v2 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-09-16 Thread Dan Carpenter
On Fri, Sep 08, 2023 at 09:59:40PM +0200, Philipp Stanner wrote: > +static inline void *memdup_array_user(const void __user *src, size_t n, > size_t size) > +{ > + size_t nbytes; > + > + if (unlikely(check_mul_overflow(n, size, ))) > + return ERR_PTR(-EOVERFLOW); No need for

Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-16 Thread Dan Carpenter
On Sat, Sep 16, 2023 at 05:24:04PM +0300, Dan Carpenter wrote: > On Sat, Sep 16, 2023 at 01:41:43AM +0200, Danilo Krummrich wrote: > > Hi Dan, > > > > On 9/15/23 14:59, Dan Carpenter wrote: > > > The u_memcpya() function is supposed to return error pointers on > > > error. Returning NULL will

Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-16 Thread Dan Carpenter
On Sat, Sep 16, 2023 at 01:41:43AM +0200, Danilo Krummrich wrote: > Hi Dan, > > On 9/15/23 14:59, Dan Carpenter wrote: > > The u_memcpya() function is supposed to return error pointers on > > error. Returning NULL will lead to an Oops. > > > > Fixes: 68132cc6d1bc ("nouveau/u_memcpya: use

Re: [RFC][PATCH v2 0/2] drm/panic: Add a drm panic handler

2023-09-16 Thread nerdopolis
On Friday, September 15, 2023 4:28:20 AM EDT Jocelyn Falempe wrote: > This introduces a new drm panic handler, which displays a message when a > panic occurs. > So when fbcon is disabled, you can still see a kernel panic. > > This is one of the missing feature, when disabling VT/fbcon in the

Re: [PATCH] drm/omap: dsi: Fix deferred probe warnings

2023-09-16 Thread H. Nikolaus Schaller
Hi Tomi and Tony, > Am 13.09.2023 um 13:59 schrieb Tomi Valkeinen > : > > On 12/04/2023 10:39, Tony Lindgren wrote: >> We may not have dsi->dsidev initialized during probe, and that can >> lead into various dsi related warnings as omap_dsi_host_detach() gets >> called with dsi->dsidev set to

[PATCH 4/4] drm/i915/dsi: Add some debug logging to mipi_exec_i2c (v2)

2023-09-16 Thread Hans de Goede
Add some debug logging to mipi_exec_i2c, to make debugging various issues seen with it easier. Changes in v2: - Drop unnecessary __func__ drm_dbg_kms() argument Reviewed-by: Javier Martinez Canillas Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 3 +++ 1 file

[PATCH 2/4] drm/i915/vlv_dsi: Add DMI quirk for wrong I2C bus and panel size on Lenovo Yoga Tablet 2 series (v2)

2023-09-16 Thread Hans de Goede
On the Lenovo Yoga Tablet 2 830 / 1050 there are 2 problems: 1. The I2C MIPI sequence elements reference bus 3. ACPI has I2C1 - I2C7 which under Linux become bus 0 - 6. And the MIPI sequence reference to bus 3 is indented for I2C3 which is bus 2 under Linux. This leads to errors like

[PATCH 3/4] drm/i915/vlv_dsi: Add DMI quirk for backlight control issues on Lenovo Yoga Tab 3

2023-09-16 Thread Hans de Goede
On the Lenovo Yoga Tab 3 Pro YT3-X90F there are 2 issues with the backlight on/off MIPI sequences: 1. The backlight on sequence has an I2C MIPI sequence element which uses bus 0, but there is a bogus I2cSerialBus resource under the GPU in the DSDT which causes i2c_acpi_find_adapter() to

[PATCH 0/4] drm/i915/vlv_dsi: Add quirks for x86 android tablets (v2)

2023-09-16 Thread Hans de Goede
Hi All, Some vlv/chv tablets ship with Android as factory OS. The factory OS BSP style kernel on these tablets does not use the normal x86 hw autodetection instead it hardcodes a whole bunch of things including using panel drivers instead of relying on VBT MIPI sequences to turn the

[PATCH 1/4] drm/i915/vlv_dsi: Add DMI quirk for wrong panel modeline in BIOS on Asus TF103C (v2)

2023-09-16 Thread Hans de Goede
Vtotal is wrong in the BIOS supplied modeline for the DSI panel on the Asus TF103C leading to the last line of the display being shown as the first line. Original: "1280x800": 60 67700 1280 1312 1328 1376 800 808 812 820 0x8 0xa Fixed:"1280x800": 60 67700 1280 1312 1328 1376 800 808 812 816

[Bug 217916] amdgpu: ring gfx_low timeout (Google Maps zooming)

2023-09-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217916 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED