Re: [PATCH v10 16/16] drm/mediatek: aal: Compress of_device_id entries and add sentinel

2023-10-03 Thread 胡俊光

Re: [PATCH] dma-buf: Deny copy-on-writes mmaps

2023-10-03 Thread kernel test robot
Hi Andi, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.6-rc4 next-20231003] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

bulk_move in ttm_resource manager

2023-10-03 Thread Zeng, Oak
Hi Christian, As a follow up to this thread: https://www.spinics.net/lists/dri-devel/msg410740.html, I started the work of moving the lru out of ttm_resource_manager and make it a common library for both ttm and svm. While look into the details of the bulk_move in ttm resource manager, I

[Patch v2] Add uAPI to query microcontroller fw version

2023-10-03 Thread Vivaik Balasubrawmanian
Due to a bug in GuC firmware, Mesa can't enable by default the usage of async compute engines feature in DG2 and newer. A new GuC firmware fixed the issue but until now there was no way for Mesa to know if KMD was running with the fixed GuC version or not, so this uAPI is required. More

[PATCH] drm/msm/dpu: drop MSM_ENC_VBLANK support

2023-10-03 Thread Dmitry Baryshkov
There are no in-kernel users of MSM_ENC_VBLANK wait type. Drop it together with the corresponding wait_for_vblank callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 -- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 1 -

Re: [PATCH 01/10] drm/mediatek: Add interface to allocate MediaTek GEM buffer.

2023-10-03 Thread 林睿祥

[PATCH v11 5/9] drm/mediatek: Add connector dynamic selection capability

2023-10-03 Thread Jason-JH . Lin
Add dynamic select available connector flow in mtk_drm_crtc_create() and mtk_drm_crtc_atomic_enable(). In mtk_drm_crtc_create(), if there is a connector routes array in drm driver data, all components definded in the connector routes array will be checked and their encoder_index will be set. In

[PATCH v11 4/9] drm/mediatek: Add encoder_index interface for mtk_ddp_comp_funcs

2023-10-03 Thread Jason-JH . Lin
To support dynamic connector selection function, each ddp_comp need to get their encoder_index to identify which connector should be selected. Add encoder_index interface for mtk_ddp_comp_funcs to get the encoder identifier by drm_encoder_index(). Then drm driver will call

[PATCH v11 0/9] Add connector dynamic selection capability

2023-10-03 Thread Jason-JH . Lin
To support DSI and eDP as main display connector without modifying mtk-drm driver, we add connector dynamic selection capability. Change in v11: 1. move some global variable to a scope. 2. move mtk_drm_crtc_update_output() after pm_runtime_resume_and_get(). 3. move return 0 when error occurred

[PATCH v11 6/9] drm/mediatek: dpi: Support dynamic connector selection

2023-10-03 Thread Jason-JH . Lin
Add implementation of mtk_dpi_encoder_index to mtk_ddp_comp_func to make mtk_dpi support dynamic connector selection. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + drivers/gpu/drm/mediatek/mtk_dpi.c | 9

[PATCH v11 9/9] drm/mediatek: Support dynamic selection of DSI0 on MT8188 VDOSYS0

2023-10-03 Thread Jason-JH . Lin
Add DDP_COMPONENT_DSI0 as a main display output selection on MT8188 VDOSYS0. Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin Reviewed-by: Matthias Brugger Reviewed-by: Fei Shao Reviewed-by: AngeloGioacchino Del Regno Tested-by: Fei Shao --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1

[PATCH v11 3/9] drm/mediatek: Fix using wrong drm private data to bind mediatek-drm

2023-10-03 Thread Jason-JH . Lin
According to mtk_drm_kms_init(), the all_drm_private array in each drm private data stores all drm private data in display path order. In mtk_drm_get_all_drm_priv(), each element in all_drm_priv should have one display path private data, such as: all_drm_priv[CRTC_MAIN] should only have main_path

[PATCH v11 7/9] drm/mediatek: Support dynamic selection of DP_INTF0 on MT8188 VDOSYS0

2023-10-03 Thread Jason-JH . Lin
Move DDP_COMPONENT_DP_INTF0 from mt8188_mtk_ddp_main array to a connector routes array called mt8188_mtk_ddp_main_routes to support dynamic selection capability for mt8188. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 7

[PATCH v11 8/9] drm/mediatek: dsi: Support dynamic connector selection

2023-10-03 Thread Jason-JH . Lin
Add implementation of mtk_dsi_encoder_index to mtk_ddp_comp_func to make mtk_dsi support dynamic connector selection. Signed-off-by: Jason-JH.Lin Reviewed-by: CK Hu Reviewed-by: Fei Shao Reviewed-by: AngeloGioacchino Del Regno Tested-by: Fei Shao --- drivers/gpu/drm/mediatek/mtk_disp_drv.h

[PATCH v11 2/9] drm/mediatek: Add crtc path enum for all_drm_priv array

2023-10-03 Thread Jason-JH . Lin
Add mtk_drm_crtc_path enum for each display path. Instead of using array index of all_drm_priv in mtk_drm_kms_init(), mtk_drm_crtc_path enum can make code more readable. Signed-off-by: Jason-JH.Lin Reviewed-by: Fei Shao Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Tested-by:

[PATCH v11 1/9] drm/mediatek: Add mmsys_dev_num to mt8188 vdosys0 driver data

2023-10-03 Thread Jason-JH . Lin
Add missing mmsys_dev_num to mt8188 vdosys0 driver data. Fixes: 54b48080278a ("drm/mediatek: Add mediatek-drm of vdosys0 support for mt8188") Signed-off-by: Jason-JH.Lin Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao Tested-by: Fei Shao ---

Re: [PATCH v4 1/4] drm/format-helper: Export line conversion helper for drm_panic

2023-10-03 Thread nerdopolis
On Tuesday, October 3, 2023 10:22:44 AM EDT Jocelyn Falempe wrote: > drm_panic will need the low-level drm_fb__line functions. > Also add drm_fb_r1_to_xrgb to render the fonts. > > Signed-off-by: Jocelyn Falempe > --- > drivers/gpu/drm/drm_format_helper.c | 88

[PATCH] drm/amdgpu: Annotate struct amdgpu_bo_list with __counted_by

2023-10-03 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).

[PATCH] dma-buf: Deny copy-on-writes mmaps

2023-10-03 Thread Andi Shyti
From: Chris Wilson Enforce that an mmap of a dmabuf is always using MAP_SHARED so that all access (both read and writes) using the device memory and not a local copy-on-write page in system memory. Signed-off-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/dma-buf/dma-buf.c | 15

Re: [PATCH v4 7/8] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-10-03 Thread Kuogee Hsieh
On 10/3/2023 3:36 PM, Dmitry Baryshkov wrote: On Wed, 4 Oct 2023 at 01:12, Kuogee Hsieh wrote: On 10/3/2023 10:53 AM, Dmitry Baryshkov wrote: On Tue, 3 Oct 2023 at 19:44, Kuogee Hsieh wrote: On 9/27/2023 3:00 PM, Dmitry Baryshkov wrote: On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh

Re: [PATCH v4 7/8] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-10-03 Thread Dmitry Baryshkov
On Wed, 4 Oct 2023 at 01:12, Kuogee Hsieh wrote: > > > On 10/3/2023 10:53 AM, Dmitry Baryshkov wrote: > > On Tue, 3 Oct 2023 at 19:44, Kuogee Hsieh wrote: > >> > >> On 9/27/2023 3:00 PM, Dmitry Baryshkov wrote: > >>> On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh > >>> wrote: > After

Re: [PATCH v4 7/8] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-10-03 Thread Kuogee Hsieh
On 10/3/2023 10:53 AM, Dmitry Baryshkov wrote: On Tue, 3 Oct 2023 at 19:44, Kuogee Hsieh wrote: On 9/27/2023 3:00 PM, Dmitry Baryshkov wrote: On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: After incorporated pm_runtime framework into eDP/DP driver, the incorporating original

Re: [PATCH v4 8/8] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-10-03 Thread Dmitry Baryshkov
On Tue, 3 Oct 2023 at 23:18, Kuogee Hsieh wrote: > > > On 10/3/2023 10:56 AM, Dmitry Baryshkov wrote: > > On 03/10/2023 20:25, Kuogee Hsieh wrote: > >> > >> On 9/27/2023 2:57 PM, Dmitry Baryshkov wrote: > >>> On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh > >>> wrote: > Currently eDP

Re: [PATCH 1/3] drm/i915/guc: Support new and improved engine busyness

2023-10-03 Thread Umesh Nerlige Ramappa
On Fri, Sep 22, 2023 at 03:25:08PM -0700, john.c.harri...@intel.com wrote: From: John Harrison The GuC has been extended to support a much more friendly engine busyness interface. So partition the old interface into a 'busy_v1' space and add 'busy_v2' support alongside. And if v2 is available,

Re: [PATCH V4 2/2] drm/panel: nv3051d: Add Support for Anbernic 351V

2023-10-03 Thread Jessica Zhang
On 10/3/2023 9:33 AM, Chris Morgan wrote: From: Chris Morgan Add support for the Anbernic 351V. Just like the 353 series the underlying vendor is unknown/unmarked (at least not visible in a non-destructive manner). The panel had slightly different init sequences and timings in the BSP

Re: [PATCH v4 8/8] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-10-03 Thread Kuogee Hsieh
On 10/3/2023 10:56 AM, Dmitry Baryshkov wrote: On 03/10/2023 20:25, Kuogee Hsieh wrote: On 9/27/2023 2:57 PM, Dmitry Baryshkov wrote: On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: Currently eDP population is done at msm_dp_modeset_init() which happen at binding time. Move eDP

Re: [PATCH 0/5] drm/amd/display: Remove migrate-disable and move memory allocation.

2023-10-03 Thread Harry Wentland
On 2023-10-02 06:58, Sebastian Andrzej Siewior wrote: > On 2023-09-22 07:33:26 [+0200], Christian König wrote: >> Am 21.09.23 um 16:15 schrieb Sebastian Andrzej Siewior: >>> Hi, >>> >>> I stumbled uppon the amdgpu driver via a bugzilla report. The actual fix >>> is #4 + #5 and the rest was made

Re: [PATCH 1/5] drm/amd/display: Remove migrate_en/dis from dc_fpu_begin().

2023-10-03 Thread Harry Wentland
On 2023-09-21 10:15, Sebastian Andrzej Siewior wrote: > This is a revert of the commit mentioned below while it is not wrong, as > in the kernel will explode, having migrate_disable() here it is > complete waste of resources. > > Additionally commit message is plain wrong the review tag does not

Re: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-03 Thread Thomas Hellström
On 10/3/23 18:55, Danilo Krummrich wrote: It seems like we're mostly aligned on this series, except for the key controversy we're discussing for a few versions now: locking of the internal lists. Hence, let's just re-iterate the options we have to get this out of the way. (1) The spinlock

Re: [PATCH 01/10] drm/mediatek: Add interface to allocate MediaTek GEM buffer.

2023-10-03 Thread Jeffrey Kardatzke
You can remove the DRIVER_RENDER flag from this patchset. That should not be upstreamed. The IOCTLs are still needed though because of the flag for allocating a secure surface that is in the next patch. If that flag wasn't needed, then dumb buffer allocations could be used instead. Thanks, Jeff

Re: [PATCH v4 8/8] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-10-03 Thread Dmitry Baryshkov
On 03/10/2023 20:25, Kuogee Hsieh wrote: On 9/27/2023 2:57 PM, Dmitry Baryshkov wrote: On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: Currently eDP population is done at msm_dp_modeset_init() which happen at binding time. Move eDP population to be done at display probe time so that probe

Re: [PATCH v4 7/8] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-10-03 Thread Dmitry Baryshkov
On Tue, 3 Oct 2023 at 19:44, Kuogee Hsieh wrote: > > > On 9/27/2023 3:00 PM, Dmitry Baryshkov wrote: > > On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: > >> After incorporated pm_runtime framework into eDP/DP driver, the > > incorporating > > > > > >> original dp_pm_suspend() to handle power

Re: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-03 Thread Thomas Hellström
Hi, Danilo On Tue, 2023-10-03 at 18:55 +0200, Danilo Krummrich wrote: > It seems like we're mostly aligned on this series, except for the key > controversy we're discussing for a few versions now: locking of the > internal > lists. Hence, let's just re-iterate the options we have to get this >

Re: [PATCH v4 8/8] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-10-03 Thread Kuogee Hsieh
On 9/27/2023 2:57 PM, Dmitry Baryshkov wrote: On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: Currently eDP population is done at msm_dp_modeset_init() which happen at binding time. Move eDP population to be done at display probe time so that probe deferral cases can be handled

Re: [PATCH v4 8/8] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-10-03 Thread Dmitry Baryshkov
On Tue, 3 Oct 2023 at 20:16, Kuogee Hsieh wrote: > > > On 9/27/2023 2:57 PM, Dmitry Baryshkov wrote: > > On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: > >> Currently eDP population is done at msm_dp_modeset_init() which happen > >> at binding time. Move eDP population to be done at display

Re: [PATCH v4 8/8] drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()

2023-10-03 Thread Kuogee Hsieh
On 9/27/2023 2:57 PM, Dmitry Baryshkov wrote: On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: Currently eDP population is done at msm_dp_modeset_init() which happen at binding time. Move eDP population to be done at display probe time so that probe deferral cases can be handled

Re: [PATCH 2/2] drm: add documentation for drm_buddy_test kUnit test

2023-10-03 Thread Jonathan Corbet
One other little thing... Mauro Carvalho Chehab writes: > As an example for the new documentation tool, add a documentation > for drm_buddy_test. > > I opted to place this on a completely different directory, in order > to make easier to test the feature with: > > $ make

Re: [PATCH 0/2] Add support for inlined documentation for kunit and kselftests

2023-10-03 Thread Jonathan Corbet
Mauro Carvalho Chehab writes: > This is a follow-up of the discussions taken here: > > > https://lore.kernel.org/linux-doc/20230704132812.02ba97ba@maurocar-mobl2/T/#t > > I sent a previous version as RFC. This is basically what we had there, with > some > improvements at test_list.py. > >

Re: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-03 Thread Danilo Krummrich
It seems like we're mostly aligned on this series, except for the key controversy we're discussing for a few versions now: locking of the internal lists. Hence, let's just re-iterate the options we have to get this out of the way. (1) The spinlock dance. This basically works for every use case,

Re: [PATCH v4 7/8] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-10-03 Thread Kuogee Hsieh
On 9/27/2023 3:00 PM, Dmitry Baryshkov wrote: On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: After incorporated pm_runtime framework into eDP/DP driver, the incorporating original dp_pm_suspend() to handle power off both DP phy and controller during suspend and dp_pm_resume() to

[PATCH V4 1/2] dt-bindings: display: newvision, nv3051d: Add Anbernic 351V

2023-10-03 Thread Chris Morgan
From: Chris Morgan Document the Anbernic RG351V panel, which is identical to the panel used in their 353 series except for in inclusion of an additional DSI format flag. Signed-off-by: Chris Morgan Acked-by: Conor Dooley --- .../devicetree/bindings/display/panel/newvision,nv3051d.yaml | 5

[PATCH V4 0/2] Support Anbernic RG351V Panel

2023-10-03 Thread Chris Morgan
From: Chris Morgan Add support for the Anbernic RG351V panel. This panel is mostly identical to the one used in the 353 series, except it has a different panel ID when queried (0x4000 for the 351V, 0x3052 for the 353 panel) and will not work without the inclusion of the

[PATCH V4 2/2] drm/panel: nv3051d: Add Support for Anbernic 351V

2023-10-03 Thread Chris Morgan
From: Chris Morgan Add support for the Anbernic 351V. Just like the 353 series the underlying vendor is unknown/unmarked (at least not visible in a non-destructive manner). The panel had slightly different init sequences and timings in the BSP kernel, but works fine with the same ones used in

Re: [PATCH v3 09/32] drm/amd/display: add plane 3D LUT driver-specific properties

2023-10-03 Thread Melissa Wen
On 09/27, Harry Wentland wrote: > > > On 2023-09-25 15:49, Melissa Wen wrote: > > Add 3D LUT property for plane color transformations using a 3D lookup > > table. 3D LUT allows for highly accurate and complex color > > transformations and is suitable to adjust the balance between color > >

RE: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-03 Thread Flavio Suligoi
Hi Daniel, ... > > > > +required: > > > > + - compatible > > > > + - reg > > > > + - max-brightness > > > > > > Why is this mandatory? > > > > > > There's no point in setting max-brightness when running in I2C mode > > > (max- brightness should default to 31 in that case). > > > > > > > > > >

Re: [PATCH v4 1/4] drm/format-helper: Export line conversion helper for drm_panic

2023-10-03 Thread kernel test robot
Hi Jocelyn, kernel test robot noticed the following build warnings: [auto build test WARNING on 2dde18cd1d8fac735875f2e4987f11817cc0bc2c] url: https://github.com/intel-lab-lkp/linux/commits/Jocelyn-Falempe/drm-format-helper-Export-line-conversion-helper-for-drm_panic/20231003-222642 base

Re: [PATCH v8 4/5] drm/drm_file: Add DRM obj's RSS reporting function for fdinfo

2023-10-03 Thread Rob Clark
On Fri, Sep 29, 2023 at 11:16 AM Adrián Larumbe wrote: > > Some BO's might be mapped onto physical memory chunkwise and on demand, > like Panfrost's tiler heap. In this case, even though the > drm_gem_shmem_object page array might already be allocated, only a very > small fraction of the BO is

Re: [PATCH] drm/mediatek: Correctly free sg_table in gem prime vmap

2023-10-03 Thread Fei Shao
Hi, On Mon, Oct 2, 2023 at 5:21 PM Chen-Yu Tsai wrote: > > The MediaTek DRM driver implements GEM PRIME vmap by fetching the > sg_table for the object, iterating through the pages, and then > vmapping them. In essence, unlike the GEM DMA helpers which vmap > when the object is first created or

Re: [PATCH] dma-buf: heaps: Fix off by one in cma_heap_vm_fault()

2023-10-03 Thread T.J. Mercier
On Tue, Oct 3, 2023 at 1:30 AM Dan Carpenter wrote: > > On Mon, Oct 02, 2023 at 10:16:24AM -0700, T.J. Mercier wrote: > > On Mon, Oct 2, 2023 at 12:04 AM Dan Carpenter > > wrote: > > > > > > The buffer->pages[] has "buffer->pagecount" elements so this > comparison > > > has to be changed to >=

[PATCH v4 4/4] drm/mgag200: Add drm_panic support

2023-10-03 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c

[PATCH v4 3/4] drm/simpledrm: Add drm_panic support

2023-10-03 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a user-friendly message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/tiny/simpledrm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/tiny/simpledrm.c

[PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-03 Thread Jocelyn Falempe
This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer() instead of the drm client API. (Thomas Zimmermann) * Add the panic reason to the panic message (Nerdopolis)

[PATCH v4 1/4] drm/format-helper: Export line conversion helper for drm_panic

2023-10-03 Thread Jocelyn Falempe
drm_panic will need the low-level drm_fb__line functions. Also add drm_fb_r1_to_xrgb to render the fonts. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_format_helper.c | 88 ++--- include/drm/drm_format_helper.h | 9 +++ 2 files changed, 89

[RFC][PATCH v4 0/4] drm/panic: Add a drm panic handler

2023-10-03 Thread Jocelyn Falempe
This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic. This is one of the missing feature, when disabling VT/fbcon in the kernel: https://www.reddit.com/r/linux/comments/10eccv9/config_vtn_in_2023/ Fbcon

Re: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-03 Thread Boris Brezillon
On Tue, 03 Oct 2023 14:25:56 +0200 Thomas Hellström wrote: > > > > +/** > > > > + * get_next_vm_bo_from_list() - get the next vm_bo element > > > > + * @__gpuvm: The GPU VM > > > > + * @__list_name: The name of the list we're iterating on > > > > + * @__local_list: A pointer to the local list

Re: [PATCH] drm/bridge: ti-sn65dsi86: Associate DSI device lifetime with auxiliary device

2023-10-03 Thread Neil Armstrong
On 03/10/2023 01:54, Stephen Boyd wrote: The kernel produces a warning splat and the DSI device fails to register in this driver if the i2c driver probes, populates child auxiliary devices, and then somewhere in ti_sn_bridge_probe() a function call returns -EPROBE_DEFER. When the auxiliary

Re: [LINUX KERNEL PATCH v5 1/2] virtio_pci: Add freeze_mode for virtio_pci_common_cfg

2023-10-03 Thread Michael S. Tsirkin
On Tue, Sep 19, 2023 at 06:46:06PM +0800, Jiqian Chen wrote: > When guest vm does S3, Qemu will reset and clear some things of virtio > devices, but guest can't aware that, so that may cause some problems. > For excample, Qemu calls virtio_reset->virtio_gpu_gl_reset, that will > destroy render

Re: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-03 Thread Thomas Hellström
Hi, Boris, On Tue, 2023-10-03 at 12:05 +0200, Boris Brezillon wrote: > Hello Thomas, > > On Tue, 3 Oct 2023 10:36:10 +0200 > Thomas Hellström wrote: > > > > +/** > > > + * get_next_vm_bo_from_list() - get the next vm_bo element > > > + * @__gpuvm: The GPU VM > > > + * @__list_name: The name of

Re: [PATCH v6 1/7] drm: atmel-hlcdc: add flag and driver ops to differentiate XLCDC and HLCDC IP

2023-10-03 Thread claudiu beznea
On 03.10.2023 07:18, manikanda...@microchip.com wrote: > On 28/09/23 11:31 am, claudiu beznea wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> Hi, Manikandan, >> >> On 27.09.2023 12:47, Manikandan Muralidharan wrote: >>> +void

RE: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-03 Thread Flavio Suligoi
Hi Daniel, ... > > +required: > > + - compatible > > + - reg > > + - max-brightness > > Why is this mandatory? > > There's no point in setting max-brightness when running in I2C mode (max- > brightness should default to 31 in that case). > > > > + - default-brightness > > Again. I'm not

RE: [PATCH v3 2/2] backlight: mp3309c: Add support for MPS MP3309C

2023-10-03 Thread Flavio Suligoi
Hi Daniel, ... > > +static int mp3309c_bl_update_status(struct backlight_device *bl) { > > + struct mp3309c_chip *chip = bl_get_data(bl); > > + int brightness = backlight_get_brightness(bl); > > + struct pwm_state pwmstate; > > + unsigned int analog_val, bits_val; > > + int i, ret; > >

Re: [PATCH v14 RESEND 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2023-10-03 Thread Maxime Ripard
On Tue, Sep 26, 2023 at 03:55:35AM +, Ying Liu wrote: > > > > > + cf->pec_base = devm_ioremap(dpu->dev, pec_base, SZ_16); > > > > > + if (!cf->pec_base) > > > > > + return -ENOMEM; > > > > > + > > > > > + cf->base = devm_ioremap(dpu->dev, base, SZ_32); > > > > > +

[PATCH v11 3/5] drm/etnaviv: Allow bypass component framework

2023-10-03 Thread Sui Jingfeng
Component framework is used to bind multiple GPU cores to a virtual master, but there are SoC/chipset that contain only one GPU core. In those case, component framework can be avoided. The reason is that usperspace programs (such as X server and Mesa) will search the PCI device to use precedently.

[PATCH v11 0/5] drm/etnaviv: Add pci device driver wrapper

2023-10-03 Thread Sui Jingfeng
This series is add PCI device driver wrapper, to support the Vivante GC1000 GPU in LS2K1000 and LS7A1000. The whole serie have been tested on LS3A5000+LS7A1000 board, with another trivial patchset [1] applied beforehand. [1] https://patchwork.freedesktop.org/series/119825/ v6: * Fix

[PATCH v11 1/5] drm/etnaviv: Add a dedicated function to get various clocks

2023-10-03 Thread Sui Jingfeng
Because the current implement is platform-dependent, there are systems which don't has the DT-based clock device drivers support. Such as x86 and Loongarch desktop platform. Don't rage quit if so. For the GPU in LS7A1000/LS2K1000, the working frequency of the GPU is control by the GFX PLL

[PATCH v11 4/5] drm/etnaviv: Add driver support for the PCI devices

2023-10-03 Thread Sui Jingfeng
There is a Vivante GC1000 GPU (v5037) in Loongson LS2K1000 (0x0014:0x7a05) and LS7A1000 (0x0014:0x7a15), the GPU in these chips is a PCI(e) device. This patch adds PCI driver wrapper for this gpu. This GPU has only one GPU core, there no need to bind to anything for now. Hence, the component

[PATCH v11 2/5] drm/etnaviv: Add constructor and destructor function for etnaviv_drm_private

2023-10-03 Thread Sui Jingfeng
Noticed that there are a lot of members in the struct etnaviv_drm_private, which are intended to be shared by all GPU core. This patch introduces two helper functions for the construction and destruction of the instances of it. A side benefit is that the error handling needed can be simplified.

[PATCH v11 5/5] drm/etnaviv: Add support for cached coherent caching mode

2023-10-03 Thread Sui Jingfeng
Loongson CPUs maintain cache coherency by hardware, which means that the data in the CPU cache is identical to the data in main system memory. As for the peripheral device, most of Loongson chips choose to define the peripherals as DMA coherent by default, device drivers do not need to maintain

Re: [PATCH v2 3/6] dt-bindings: display: msm: Add SDM670 MDSS

2023-10-03 Thread Krzysztof Kozlowski
On 03/10/2023 12:31, Dmitry Baryshkov wrote: >>> +patternProperties: >>> + "^display-controller@[0-9a-f]+$": >>> +type: object >>> +additionalProperties: true >>> + >>> +properties: >>> + compatible: >>> +const: qcom,sdm670-dpu >>> + >>> +

Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for One Mix 2S

2023-10-03 Thread Liviu Dudau
On Sun, Oct 01, 2023 at 02:21:43PM +0200, Hans de Goede wrote: > Hi, > > On 10/1/23 13:47, Kai Uwe Broulik wrote: > > The One Mix 2S is a mini laptop with a 1200x1920 portrait screen > > mounted in a landscape oriented clamshell case. Because of the too > > generic DMI strings this entry is also

Re: [PATCH v17 13/18] drm/shmem-helper: Add memory shrinker

2023-10-03 Thread Boris Brezillon
On Mon, 2 Oct 2023 22:28:13 +0300 Dmitry Osipenko wrote: > On 9/26/23 10:35, Boris Brezillon wrote: > >> On 9/15/23 11:46, Boris Brezillon wrote: > >>> The naming becomes quite confusing, with drm_gem_shmem_unpin_locked() > >>> and drm_gem_shmem_unpin_pages_locked(). By the look of it, it

Re: [PATCH v2 3/6] dt-bindings: display: msm: Add SDM670 MDSS

2023-10-03 Thread Dmitry Baryshkov
On Tue, 3 Oct 2023 at 11:48, Krzysztof Kozlowski wrote: > > On 03/10/2023 03:21, Richard Acayan wrote: > > Add documentation for the SDM670 display subsystem, adapted from the > > SDM845 and SM6125 documentation. > > > > Signed-off-by: Richard Acayan > > --- > >

Re: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-03 Thread Daniel Thompson
On Tue, Oct 03, 2023 at 09:43:15AM +, Flavio Suligoi wrote: > Hi Daniel, > > ... > > > > +required: > > > + - compatible > > > + - reg > > > + - max-brightness > > > > Why is this mandatory? > > > > There's no point in setting max-brightness when running in I2C mode (max- > > brightness

Re: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-03 Thread Boris Brezillon
Hello Thomas, On Tue, 3 Oct 2023 10:36:10 +0200 Thomas Hellström wrote: > > +/** > > + * get_next_vm_bo_from_list() - get the next vm_bo element > > + * @__gpuvm: The GPU VM > > + * @__list_name: The name of the list we're iterating on > > + * @__local_list: A pointer to the local list used to

Re: [RFC PATCH v1 03/12] drm/connector: extend PATH property to covert Type-C case

2023-10-03 Thread Simon Ser
On Sunday, September 3rd, 2023 at 23:41, Dmitry Baryshkov wrote: > To facilitate this, reuse the 'PATH' property, which was used to > describe the DP port in the DP MST configuration. Use either > 'typec:portN' to point out to the Type-C port class device, or just > 'typec:' if the

Re: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-03 Thread Thomas Hellström
Hi Again, On 10/3/23 10:36, Thomas Hellström wrote: Hi, Danilo, On 9/28/23 21:16, Danilo Krummrich wrote: Currently the DRM GPUVM offers common infrastructure to track GPU VA allocations and mappings, generically connect GPU VA mappings to their backing buffers and perform more complex

Re: [PATCH v1] drm/msm/dp: do not reinitialize phy unless retry during link training

2023-10-03 Thread Johan Hovold
On Tue, Aug 08, 2023 at 03:19:50PM -0700, Kuogee Hsieh wrote: > DP PHY re-initialization done using dp_ctrl_reinitialize_mainlink() will > cause PLL unlocked initially and then PLL gets locked at the end of > initialization. PLL_UNLOCKED interrupt will fire during this time if the > interrupt mask

Re: [PATCH v17 13/18] drm/shmem-helper: Add memory shrinker

2023-10-03 Thread Boris Brezillon
Hello Dmitry, On Tue, 3 Oct 2023 03:31:32 +0300 Dmitry Osipenko wrote: > On 9/26/23 10:35, Boris Brezillon wrote: > +__drm_gem_shmem_release_pages(shmem); > >>> Make sure you drop the implicit pages_use_count ref the sgt had, this > >>> way you can still tie the necessity to

Re: [PATCH v2 3/6] dt-bindings: display: msm: Add SDM670 MDSS

2023-10-03 Thread Krzysztof Kozlowski
On 03/10/2023 03:21, Richard Acayan wrote: > Add documentation for the SDM670 display subsystem, adapted from the > SDM845 and SM6125 documentation. > > Signed-off-by: Richard Acayan > --- > .../display/msm/qcom,sdm670-mdss.yaml | 287 ++ > 1 file changed, 287

Re: [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers

2023-10-03 Thread Joel Granados
On Mon, Oct 02, 2023 at 12:27:18PM +, Christophe Leroy wrote: > > > Le 02/10/2023 à 10:55, Joel Granados via B4 Relay a écrit : > > From: Joel Granados > > <--- snip ---> > > - The "yesall" config saves 2432 bytes [4] > > - The "tiny" config saves 64 bytes [5] > > *

Re: [PATCH v2] drm/ttm: Make sure the mapped tt pages are decrypted when needed

2023-10-03 Thread Thomas Hellström
On 10/3/23 06:13, Zack Rusin wrote: On Mon, 2023-10-02 at 16:27 +0200, Thomas Hellström wrote: !! External Email On Mon, 2023-10-02 at 10:16 +0200, Thomas Hellström wrote: Hi, Zack On 9/26/23 19:51, Zack Rusin wrote: From: Zack Rusin Some drivers require the mapped tt pages to be

Re: [PATCH drm-misc-next v5 4/6] drm/gpuvm: track/lock/validate external/evicted objects

2023-10-03 Thread Thomas Hellström
Hi, Danilo, On 9/28/23 21:16, Danilo Krummrich wrote: Currently the DRM GPUVM offers common infrastructure to track GPU VA allocations and mappings, generically connect GPU VA mappings to their backing buffers and perform more complex mapping operations on the GPU VA space. However, there are

Re: [PATCH] dma-buf: heaps: Fix off by one in cma_heap_vm_fault()

2023-10-03 Thread Dan Carpenter
On Mon, Oct 02, 2023 at 10:16:24AM -0700, T.J. Mercier wrote: > On Mon, Oct 2, 2023 at 12:04 AM Dan Carpenter > wrote: > > > > The buffer->pages[] has "buffer->pagecount" elements so this > comparison > > has to be changed to >= to avoid reading beyond the end of the array. > > The

[PATCH v1 1/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages

2023-10-03 Thread Vivek Kasireddy
For drivers that would like to longterm-pin the pages associated with a file, the pin_user_pages_fd() API provides an option to not only FOLL_PIN the pages but also to check and migrate them if they reside in movable zone or CMA block. For now, this API can only work with files belonging to shmem

[PATCH v1 2/3] udmabuf: Pin the pages using pin_user_pages_fd() API

2023-10-03 Thread Vivek Kasireddy
Using pin_user_pages_fd() will ensure that the pages are pinned correctly using FOLL_PIN. And, this also ensures that we don't accidentally break features such as memory hotunplug as it would not allow pinning pages in the movable zone. This patch also adds back support for mapping hugetlbfs

[PATCH v1 3/3] selftests/dma-buf/udmabuf: Add tests to verify data after page migration

2023-10-03 Thread Vivek Kasireddy
Since the memfd pages associated with a udmabuf may be migrated as part of udmabuf create, we need to verify the data coherency after successful migration. The new tests added in this patch try to do just that using 4k sized pages and also 2 MB sized huge pages for the memfd. Successful

[PATCH v1 0/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages

2023-10-03 Thread Vivek Kasireddy
The first patch introduces pin_user_pages_fd() API and the second patch shows how the udmabuf driver can use it to longterm-pin the the pages. The last patch adds two new udmabuf selftests to verify data coherency after page migration. Cc: David Hildenbrand Cc: Daniel Vetter Cc: Mike Kravetz

Re: [PATCH v4 5/8] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-03 Thread Dmitry Baryshkov
On Tue, 3 Oct 2023 at 01:48, Kuogee Hsieh wrote: > > > On 9/27/2023 2:41 PM, Dmitry Baryshkov wrote: > > On Wed, 27 Sept 2023 at 23:54, Kuogee Hsieh wrote: > >> Currently DP driver is executed independent of PM runtime framework. > >> This lead to msm edp panel can not be detected by edp_panel

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-10-03 Thread Dmitry Baryshkov
On Tue, 3 Oct 2023 at 04:33, Abhinav Kumar wrote: > > > > On 10/2/2023 3:58 PM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2023-09-28 17:46:11) > >> On 9/27/2023 3:01 PM, Stephen Boyd wrote: > >>> Quoting Kuogee Hsieh (2023-09-25 09:07:18) > > However for external DP case, link

[PATCH] accel/ivpu: Don't enter d0i3 during FLR

2023-10-03 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Fix a bug on some platforms where FLR causes complete system hang when CPU is low power states (C8 or above). Fixes: 852be13f3bd3 ("accel/ivpu: Add PM support") Cc: sta...@vger.kernel.org Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: