Re: [PATCH] drm/i915/gem: Allow users to disable waitboost

2023-10-26 Thread kernel test robot
Hello, kernel test robot noticed "assertion_failure" on: commit: 54fef7ea35dadd66193b98805b0bc42ef2b279db ("[PATCH] drm/i915/gem: Allow users to disable waitboost") url:

[drm:topic/nvidia-gsp 41/48] disp.c:undefined reference to `__udivdi3'

2023-10-26 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm topic/nvidia-gsp head: c09ddadcb05445b46e1dd0554a3ee1a96328 commit: e9ad7a2f99667b6ba6ac966050e5d7d6b5e485dd [41/48] drm/nouveau/disp/r535: initial support config: powerpc-randconfig-003-20231026 (https://download.01.org/0day-ci/archive

[PATCH v2] drm/atomic-helper: Fix spelling mistake "preceeding" -> "preceding"

2023-10-26 Thread chentao
From: Kunwu Chan There is a typo in the kernel documentation for function drm_atomic_helper_wait_for_dependencies. Fix it. Signed-off-by: Kunwu Chan --- drivers/gpu/drm/drm_atomic_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[drm:topic/nvidia-gsp 41/48] ld: disp.c:undefined reference to `__udivdi3'

2023-10-26 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm topic/nvidia-gsp head: c09ddadcb05445b46e1dd0554a3ee1a96328 commit: e9ad7a2f99667b6ba6ac966050e5d7d6b5e485dd [41/48] drm/nouveau/disp/r535: initial support config: i386-buildonly-randconfig-002-20231027

Re: [PATCH] drm/atomic: Spelling fix in comments

2023-10-26 Thread Kunwu Chan
Hi Hamza, Thank you very much for your guidance and advice to me, I have revised it according to your suggestion. On 2023/10/25 22:50, Hamza Mahfooz wrote: Hi Kunwu, Can you make the tagline something along the lines of `drm/atomic helper: fix spelling mistake "preceeding" -> "preceding"`,

Re: [PATCH 1/1] drm/mediatek: Fix errors when reporting rotation capability

2023-10-26 Thread 宋孝謙

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-26 Thread Luben Tuikov
On 2023-10-26 17:13, Luben Tuikov wrote: > On 2023-10-26 12:13, Danilo Krummrich wrote: >> Currently, job flow control is implemented simply by limiting the number >> of jobs in flight. Therefore, a scheduler is initialized with a credit >> limit that corresponds to the number of jobs which can be

Re: drm/panel: panel-simple power-off sequencing

2023-10-26 Thread Doug Anderson
Hi, On Thu, Oct 26, 2023 at 7:37 AM Jonas Mark (BT-FS/ENG1-GRB) wrote: > > Hi, > > We have a parallel LCD panel which is driven by panel/panel-simple. The > power-off sequence specified in the datasheet requires that the enable-gpio > must be deasserted for a number of VSYNC cycles before

[PATCH] drm/i915: Skip pxp init if gt is wedged

2023-10-26 Thread Zhanjun Dong
gt wedged is fatal error, skip the pxp init on this situation. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c index

[PATCH] staging: fbtft: Convert to platform remove callback returning void

2023-10-26 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH] drm/amdgpu: Fixes uninitialized variable usage in amdgpu_dm_setup_replay

2023-10-26 Thread Yuran Pereira
Since `pr_config` is not initialized after its declaration, the following operations with `replay_enable_option` may be performed when `replay_enable_option` is holding junk values which could possibly lead to undefined behaviour ``` ... pr_config.replay_enable_option |=

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-26 Thread Luben Tuikov
On 2023-10-26 12:13, Danilo Krummrich wrote: > Currently, job flow control is implemented simply by limiting the number > of jobs in flight. Therefore, a scheduler is initialized with a credit > limit that corresponds to the number of jobs which can be sent to the > hardware. > > This implies

Re: [PATCH v3 05/15] phy: qualcomm: add legacy HDMI PHY driver

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: Add the driver for pre-QMP Qualcomm HDMI PHYs. Currently it suppports Qualcomm MSM8960 / APQ8064 platforms, other platforms will come later. Signed-off-by: Dmitry Baryshkov --- [...] +{ + unsigned int pixclk =

Re: [PATCH v3 15/15] drm/msm/hdmi: drop old HDMI PHY code

2023-10-26 Thread Konrad Dybcio
On 10/26/23 23:03, Dmitry Baryshkov wrote: On Fri, 27 Oct 2023 at 00:00, Konrad Dybcio wrote: On 9/28/23 13:16, Dmitry Baryshkov wrote: Drop source files used by old HDMI PHY and HDMI PLL drivers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 216

Re: [PATCH v3 02/15] phy: qualcomm: add QMP HDMI PHY driver

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: Port Qualcomm QMP HDMI PHY to the generic PHY framework. Split the generic part and the msm8996 part. When adding support for msm8992/4 and msm8998 (which also employ QMP for HDMI PHY), one will have to provide the PLL programming part only.

Re: [PATCH v3 15/15] drm/msm/hdmi: drop old HDMI PHY code

2023-10-26 Thread Dmitry Baryshkov
On Fri, 27 Oct 2023 at 00:00, Konrad Dybcio wrote: > > > > On 9/28/23 13:16, Dmitry Baryshkov wrote: > > Drop source files used by old HDMI PHY and HDMI PLL drivers. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 216 --- > >

Re: [PATCH v3 15/15] drm/msm/hdmi: drop old HDMI PHY code

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: Drop source files used by old HDMI PHY and HDMI PLL drivers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 216 --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c | 51 -- drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c

Re: [PATCH v3 14/15] drm/msm/hdmi: switch to generic PHY subsystem

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: Change the MSM HDMI driver to use generic PHY subsystem. Moving PHY drivers allows better code sharing with the rest of the PHY system. Signed-off-by: Dmitry Baryshkov --- Looks like this will require some atomicity with the phy changes Acked-by:

Re: [PATCH v3 13/15] drm/msm/hdmi: pair msm_hdmi_phy_powerup with msm_hdmi_phy_powerdown

2023-10-26 Thread Dmitry Baryshkov
On Thu, 26 Oct 2023 at 22:54, Konrad Dybcio wrote: > > > > On 9/28/23 13:16, Dmitry Baryshkov wrote: > > In preparation to converting MSM HDMI driver to use PHY framework, which > > requires phy_power_on() calls to be paired with phy_power_off(), add a > > conditional call to

Re: [PATCH v2] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full

2023-10-26 Thread Jonas Karlman
Hi Chris, On 2023-10-26 22:02, Christopher Obbard wrote: > Hi Jonas, > > On Thu, 2023-10-26 at 19:14 +, Jonas Karlman wrote: >> Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328 >> and RK3399 result in wrong colors being displayed. >> >> The issue can be observed using

Re: [RFC] drm: bridge: samsung-dsim: Recalculate timings when rounding HFP up

2023-10-26 Thread Adam Ford
On Thu, Oct 26, 2023 at 1:12 PM Frieder Schrempf wrote: > > Hi Adam, > > On 13.10.23 05:10, Adam Ford wrote: > > When using video sync pulses, the HFP, HBP, and HSA are divided between > > the available lanes if there is more than one lane. For certain > > timings and lane configurations, the

Re: [PATCH v2] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full

2023-10-26 Thread Christopher Obbard
Hi Jonas, On Thu, 2023-10-26 at 19:14 +, Jonas Karlman wrote: > Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328 > and RK3399 result in wrong colors being displayed. > > The issue can be observed using modetest: > >   modetest -s @:1920x1080-60@RG24 >   modetest -s

Re: [PATCH v3 13/15] drm/msm/hdmi: pair msm_hdmi_phy_powerup with msm_hdmi_phy_powerdown

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: In preparation to converting MSM HDMI driver to use PHY framework, which requires phy_power_on() calls to be paired with phy_power_off(), add a conditional call to msm_hdmi_phy_powerdown() before the call to msm_hdmi_phy_powerup(). Signed-off-by:

Re: [PATCH v3 11/15] drm/msm/hdmi: switch to atomic_pre_enable/post_disable

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: In preparation of reworking the HDMI mode setting, switch pre_enable and post_disable callbacks to their atomic variants. Signed-off-by: Dmitry Baryshkov --- This looks good, but I'm far from knowledgeable in terms of drm, so: Acked-by: Konrad

Re: [PATCH v3 10/15] drm/msm/hdmi: correct indentation of HDMI bridge functions

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 09/15] drm/msm/hdmi: simplify extp clock handling

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: With the extp being the only "power" clock left, remove the surrounding loops and handle the extp clock directly. Signed-off-by: Dmitry Baryshkov ---Reviewed-by: Konrad Dybcio Konrad

[PATCH v2] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full

2023-10-26 Thread Jonas Karlman
Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328 and RK3399 result in wrong colors being displayed. The issue can be observed using modetest: modetest -s @:1920x1080-60@RG24 modetest -s @:1920x1080-60@BG24 Vendor 4.4 kernel apply an inverted rb swap for these formats on

Re: [PATCH v2 2/2] drm/todo: Add entry to clean up former seltests suites

2023-10-26 Thread Maxime Ripard
Hi Maira, On Wed, Oct 25, 2023 at 02:26:44PM -0300, Maira Canal wrote: > Hi Maxime, > > Wouldn't be nice to add to the TODO list an item regarding the deleted > drm_mm tests? Something just to remember us to develop new tests for it > in the future. I guess we could, but it's really not clear

Re: [PATCH] MAINTAINERS: Update the GPU Scheduler email

2023-10-26 Thread Alex Deucher
On Thu, Oct 26, 2023 at 1:45 PM Luben Tuikov wrote: > > Update the GPU Scheduler maintainer email. > > Cc: Alex Deucher > Cc: Christian König > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: AMD Graphics > Cc: Direct Rendering Infrastructure - Development > > Signed-off-by: Luben Tuikov

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-26 Thread Alex Goins
On Thu, 26 Oct 2023, Sebastian Wick wrote: > On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka Paalanen wrote: > > On Wed, 25 Oct 2023 15:16:08 -0500 (CDT) > > Alex Goins wrote: > > > > > Thank you Harry and all other contributors for your work on this. > > > Responses > > > inline - > > > > > >

Re: [PATCH v2] drm/syncobj: fix DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE

2023-10-26 Thread Simon Ser
On Thursday, October 26th, 2023 at 21:16, Simon Ser wrote: > On Thursday, October 26th, 2023 at 19:55, Erik Kurzinger > ekurzin...@nvidia.com wrote: > > > Is there anything else needed for this fix to be merged? I have shared > > an accompanying patch for the IGT test suite here > >

Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs

2023-10-26 Thread Konrad Dybcio
On 10/23/23 22:20, Rob Clark wrote: On Mon, Oct 23, 2023 at 12:56 PM Konrad Dybcio wrote: On 10/23/23 21:42, Rob Clark wrote: On Mon, Oct 23, 2023 at 7:29 AM Konrad Dybcio wrote: New GPUs still use the lower 2 bytes of the chip id (in whatever form it comes) to signify silicon

Re: [PATCH v2] drm/syncobj: fix DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE

2023-10-26 Thread Simon Ser
On Thursday, October 26th, 2023 at 19:55, Erik Kurzinger wrote: > Is there anything else needed for this fix to be merged? I have shared > an accompanying patch for the IGT test suite here > https://lists.freedesktop.org/archives/igt-dev/2023-August/060154.html Do you also happen to have

Re: [PATCH] drm: bridge: adv7511: fix reading edid segments

2023-10-26 Thread Frieder Schrempf
On 26.10.23 13:30, Emil Abildgaard Svendsen wrote: > [Sie erhalten nicht häufig E-Mails von e...@bang-olufsen.dk. Weitere > Informationen, warum dies wichtig ist, finden Sie unter > https://aka.ms/LearnAboutSenderIdentification ] > > Currently reading EDID only works because usually only two

Re: [REGRESSION] rx7600 stopped working after "1cfb4d612127 drm/amdgpu: put MQDs in VRAM"

2023-10-26 Thread Alex Deucher
On Thu, Oct 26, 2023 at 1:33 PM Alexey Klimov wrote: > > #regzbot introduced: 1cfb4d612127 > #regzbot title: rx7600 stopped working after "1cfb4d612127 drm/amdgpu: put > MQDs in VRAM" > > Hi all, > > I've been playing with RX7600 and it was observed that amdgpu stopped working > between kernel

Re: [RFC] drm: bridge: samsung-dsim: Recalculate timings when rounding HFP up

2023-10-26 Thread Frieder Schrempf
Hi Adam, On 13.10.23 05:10, Adam Ford wrote: > When using video sync pulses, the HFP, HBP, and HSA are divided between > the available lanes if there is more than one lane. For certain > timings and lane configurations, the HFP may not be evenly divisible > and it gets rounded down which can

Re: [PATCH v2] drm/syncobj: fix DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE

2023-10-26 Thread Erik Kurzinger
Is there anything else needed for this fix to be merged? I have shared an accompanying patch for the IGT test suite here https://lists.freedesktop.org/archives/igt-dev/2023-August/060154.html On 8/16/23 09:26, Erik Kurzinger wrote: > If DRM_IOCTL_SYNCOBJ_TIMELINE_WAIT is invoked with the >

[PATCH] MAINTAINERS: Update the GPU Scheduler email

2023-10-26 Thread Luben Tuikov
Update the GPU Scheduler maintainer email. Cc: Alex Deucher Cc: Christian König Cc: Daniel Vetter Cc: Dave Airlie Cc: AMD Graphics Cc: Direct Rendering Infrastructure - Development Signed-off-by: Luben Tuikov --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[REGRESSION] rx7600 stopped working after "1cfb4d612127 drm/amdgpu: put MQDs in VRAM"

2023-10-26 Thread Alexey Klimov
#regzbot introduced: 1cfb4d612127 #regzbot title: rx7600 stopped working after "1cfb4d612127 drm/amdgpu: put MQDs in VRAM" Hi all, I've been playing with RX7600 and it was observed that amdgpu stopped working between kernel 6.2 and 6.5. Then I narrowed it down to 6.4 <-> 6.5-rc1 and finally

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-26 Thread Sebastian Wick
On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka Paalanen wrote: > On Wed, 25 Oct 2023 15:16:08 -0500 (CDT) > Alex Goins wrote: > > > Thank you Harry and all other contributors for your work on this. Responses > > inline - > > > > On Mon, 23 Oct 2023, Pekka Paalanen wrote: > > > > > On Fri, 20

Re: [PATCH] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-26 Thread Luben Tuikov
On 2023-10-26 12:39, Danilo Krummrich wrote: > On 10/23/23 05:22, Luben Tuikov wrote: >> The GPU scheduler has now a variable number of run-queues, which are set up >> at >> drm_sched_init() time. This way, each driver announces how many run-queues it >> requires (supports) per each GPU scheduler

[PATCH] drm/nouveau: Prevents NULL pointer dereference in nouveau_uvmm_sm_prepare

2023-10-26 Thread Yuran Pereira
There are instances where the "args" argument passed to nouveau_uvmm_sm_prepare() is NULL. I.e. when nouveau_uvmm_sm_prepare() is called from nouveau_uvmm_sm_unmap_prepare() ``` static int nouveau_uvmm_sm_unmap_prepare(struct nouveau_uvmm *uvmm, ... { return nouveau_uvmm_sm_prepare(uvmm,

Re: [PATCH] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-26 Thread Danilo Krummrich
On 10/23/23 05:22, Luben Tuikov wrote: The GPU scheduler has now a variable number of run-queues, which are set up at drm_sched_init() time. This way, each driver announces how many run-queues it requires (supports) per each GPU scheduler it creates. Note, that run-queues correspond to scheduler

[PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-26 Thread Danilo Krummrich
Currently, job flow control is implemented simply by limiting the number of jobs in flight. Therefore, a scheduler is initialized with a credit limit that corresponds to the number of jobs which can be sent to the hardware. This implies that for each job, drivers need to account for the maximum

Re: [PATCH] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-26 Thread Luben Tuikov
Hi, I've pushed this commit as I got a verbal Acked-by from Christian in our kernel meeting this morning. Matt, please rebase your patches to drm-misc-next. Regards, Luben On 2023-10-26 11:20, Luben Tuikov wrote: > Ping! > > On 2023-10-22 23:22, Luben Tuikov wrote: >> The GPU scheduler has

Re: [PATCH] MAINTAINERS: drm/ci: add entries for xfail files

2023-10-26 Thread Maxime Ripard
On Tue, 19 Sep 2023 15:22:49 -0300, Helen Koike wrote: > DRM CI keeps track of which tests are failing, flaking or being skipped > by the ci in the expectations files. Add entries for those files to the > corresponding driver maintainer, so they can be notified when they > change. > > Applied

Re: (subset) [PATCH v2] drm/doc: ci: Require more context for flaky tests

2023-10-26 Thread Maxime Ripard
Hi, On Thu, Oct 26, 2023 at 11:27:18AM -0300, Helen Koike wrote: > On 26/10/2023 10:27, Maxime Ripard wrote: > > On Thu, Oct 26, 2023 at 09:08:03AM -0300, Helen Koike wrote: > > > > > > > > > On 26/10/2023 09:01, Helen Koike wrote: > > > > > > > > > > > > On 26/10/2023 07:58, Maxime Ripard

Re: [PATCH] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-26 Thread Luben Tuikov
Ping! On 2023-10-22 23:22, Luben Tuikov wrote: > The GPU scheduler has now a variable number of run-queues, which are set up at > drm_sched_init() time. This way, each driver announces how many run-queues it > requires (supports) per each GPU scheduler it creates. Note, that run-queues >

Re: [PATCH v2 1/1] dt-bindings: backlight: mp3309c: remove two required properties

2023-10-26 Thread Conor Dooley
On Wed, Oct 25, 2023 at 05:50:57PM +0200, Flavio Suligoi wrote: > The two properties: > > - max-brightness > - default brightness > > are not really required, so they can be removed from the "required" > section. > The "max-brightness" is no longer used in the current version > of the driver (it

Re: [PATCH] drm: bridge: adv7511: fix reading edid segments

2023-10-26 Thread Fabio Estevam
Hi Emil, On Thu, Oct 26, 2023 at 11:47 AM Emil Abildgaard Svendsen wrote: > > Currently reading EDID only works because usually only two EDID blocks > of 128 bytes is used. Where an EDID segment holds 256 bytes or two EDID > blocks. And the first EDID segment read works fine but E-EDID specifies

[PULL] drm-intel-fixes

2023-10-26 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2023-10-26: - Determine context valid in OA reports (Umesh) - Hold GT forcewake during steering operations (Matt Roper) - Check if PMU is closed before stopping event (Umesh) Thanks, Rodrigo. The following changes since commit

Re: [PATCH 1/7] drm: Do not round to megabytes for greater than 1MiB sizes in fdinfo stats

2023-10-26 Thread Tvrtko Ursulin
On 28/09/2023 13:47, Tvrtko Ursulin wrote: On 27/09/2023 14:48, Steven Price wrote: On 27/09/2023 14:38, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It is better not to lose precision and not revert to 1 MiB size granularity for every size greater than 1 MiB. Sizes in KiB should not be so

drm/panel: panel-simple power-off sequencing

2023-10-26 Thread Jonas Mark (BT-FS/ENG1-GRB)
Hi, We have a parallel LCD panel which is driven by panel/panel-simple. The power-off sequence specified in the datasheet requires that the enable-gpio must be deasserted for a number of VSYNC cycles before shutting down all other control signals. See the diagram below:

Re: (subset) [PATCH v2] drm/doc: ci: Require more context for flaky tests

2023-10-26 Thread Helen Koike
On 26/10/2023 10:27, Maxime Ripard wrote: On Thu, Oct 26, 2023 at 09:08:03AM -0300, Helen Koike wrote: On 26/10/2023 09:01, Helen Koike wrote: On 26/10/2023 07:58, Maxime Ripard wrote: On Wed, 25 Oct 2023 16:24:41 +0200, Maxime Ripard wrote: Flaky tests can be very difficult to

[PATCH] drm: bridge: adv7511: fix reading edid segments

2023-10-26 Thread Emil Abildgaard Svendsen
Currently reading EDID only works because usually only two EDID blocks of 128 bytes is used. Where an EDID segment holds 256 bytes or two EDID blocks. And the first EDID segment read works fine but E-EDID specifies up to 128 segments. The logic is broken so change EDID segment index to multiple

Re: (subset) [PATCH v2] drm/doc: ci: Require more context for flaky tests

2023-10-26 Thread Maxime Ripard
On Thu, Oct 26, 2023 at 09:08:03AM -0300, Helen Koike wrote: > > > On 26/10/2023 09:01, Helen Koike wrote: > > > > > > On 26/10/2023 07:58, Maxime Ripard wrote: > > > On Wed, 25 Oct 2023 16:24:41 +0200, Maxime Ripard wrote: > > > > Flaky tests can be very difficult to reproduce after the

Re: [PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE

2023-10-26 Thread Maxime Ripard
On Mon, 02 Oct 2023 09:47:14 -0700, Rob Clark wrote: > Dependency for CONFIG_DRM_PANEL_EDP. Missing this was causing the drm > driver to not probe on devices that use panel-edp. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo

2023-10-26 Thread Maxime Ripard
On Sun, 08 Oct 2023 16:23:19 +0300, Dmitry Baryshkov wrote: > In case of the merge requests it might be useful to push repo-specific > fixes which have not yet propagated to the -external-fixes branch in the > main UPSTREAM_REPO. For example, in case of drm/msm development, we are > staging fixes

Re: [PATCH v3 00/10] drm/ci: fixes and improvements

2023-10-26 Thread Maxime Ripard
On Mon, 23 Oct 2023 21:45:15 -0300, Helen Koike wrote: > This series contains the several fixes, making drm/ci much > more reliable and useful. > > Highlights: > > * Current DRM/CI in drm-misc is broken, this series fixes it with mesa > uprev (commit 1/9). > > [...] Applied to drm/drm-misc

Re: [PATCH 2/2] fbdev/simplefb: Add support for generic power-domains

2023-10-26 Thread Hans de Goede
Hi, Thank you for your patches. On 10/11/23 16:38, Thierry Reding wrote: > From: Thierry Reding > > The simple-framebuffer device tree bindings document the power-domains > property, so make sure that simplefb supports it. This ensures that the > power domains remain enabled as long as

Re: [PATCH 1/2] fbdev/simplefb: Support memory-region property

2023-10-26 Thread Hans de Goede
Hi, On 10/11/23 16:38, Thierry Reding wrote: > From: Thierry Reding > > The simple-framebuffer bindings specify that the "memory-region" > property can be used as an alternative to the "reg" property to define > the framebuffer memory used by the display hardware. Implement support > for this

Re: [Intel-gfx] [PATCH] drm/i915/mtl: avoid stringop-overflow warning

2023-10-26 Thread Jani Nikula
On Mon, 23 Oct 2023, Jani Nikula wrote: > On Mon, 16 Oct 2023, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The newly added memset() causes a warning for some reason I could not figure >> out: >> >> In file included from arch/x86/include/asm/string.h:3, >> from

Re: (subset) [PATCH v2] drm/doc: ci: Require more context for flaky tests

2023-10-26 Thread Helen Koike
On 26/10/2023 09:01, Helen Koike wrote: On 26/10/2023 07:58, Maxime Ripard wrote: On Wed, 25 Oct 2023 16:24:41 +0200, Maxime Ripard wrote: Flaky tests can be very difficult to reproduce after the facts, which will make it even harder to ever fix. Let's document the metadata we agreed on

Re: (subset) [PATCH v2] drm/doc: ci: Require more context for flaky tests

2023-10-26 Thread Helen Koike
On 26/10/2023 07:58, Maxime Ripard wrote: On Wed, 25 Oct 2023 16:24:41 +0200, Maxime Ripard wrote: Flaky tests can be very difficult to reproduce after the facts, which will make it even harder to ever fix. Let's document the metadata we agreed on to provide more context to anyone trying to

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-10-26 Thread Maxime Ripard
On Thu, Oct 26, 2023 at 11:57:22AM +0300, Dmitry Baryshkov wrote: > On Thu, 26 Oct 2023 at 11:07, Maxime Ripard wrote: > > > > On Thu, Oct 26, 2023 at 01:23:53AM +0300, Dmitry Baryshkov wrote: > > > > +static int starfive_hdmi_register(struct drm_device *drm, struct > > > > starfive_hdmi *hdmi)

Re: [PATCH v5 4/6] drm/bridge: implement generic DP HPD bridge

2023-10-26 Thread kernel test robot
-helper/20231026-063135 base: next-20231025 patch link: https://lore.kernel.org/r/20231025223027.943563-5-dmitry.baryshkov%40linaro.org patch subject: [PATCH v5 4/6] drm/bridge: implement generic DP HPD bridge config: csky-randconfig-002-20231026 (https://download.01.org/0day-ci/archive

Re: (subset) [PATCH] drm/vc4: tests: Fix UAF in the mock helpers

2023-10-26 Thread Maxime Ripard
On Tue, 24 Oct 2023 12:56:40 +0200, Maxime Ripard wrote: > The VC4 mock helpers allocate the CRTC, encoders and connectors using a > call to kunit_kzalloc(), but the DRM device they are attache to survives > for longer than the test itself which leads to use-after-frees reported > by KASAN. > >

Re: [PATCH] drm/doc: ci: Require more context for flaky tests

2023-10-26 Thread Maxime Ripard
On Thu, Oct 26, 2023 at 12:58:48PM +0200, Maxime Ripard wrote: > On Thu, 19 Oct 2023 11:46:09 +0200, Maxime Ripard wrote: > > Flaky tests can be very difficult to reproduce after the facts, which > > will make it even harder to ever fix. > > > > Let's document the metadata we agreed on to provide

[PULL] drm-misc-fixes

2023-10-26 Thread Thomas Zimmermann
Hi, this is the week's PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2023-10-26: Short summary of fixes pull: amdgpu: - ignore duplicated BOs in CS parser - remove redundant call to amdgpu_ctx_priority_is_valid() amdkfd: - reserve fence slot while locking BO dp_mst: - Fix NULL

Re: [PATCH] drm/doc: ci: Require more context for flaky tests

2023-10-26 Thread Maxime Ripard
On Thu, 19 Oct 2023 11:46:09 +0200, Maxime Ripard wrote: > Flaky tests can be very difficult to reproduce after the facts, which > will make it even harder to ever fix. > > Let's document the metadata we agreed on to provide more context to > anyone trying to address these fixes. > > > [...]

Re: (subset) [PATCH v2] drm/doc: ci: Require more context for flaky tests

2023-10-26 Thread Maxime Ripard
On Wed, 25 Oct 2023 16:24:41 +0200, Maxime Ripard wrote: > Flaky tests can be very difficult to reproduce after the facts, which > will make it even harder to ever fix. > > Let's document the metadata we agreed on to provide more context to > anyone trying to address these fixes. > > > [...]

Re: [PATCH] drm/vc4: tests: Fix UAF in the mock helpers

2023-10-26 Thread Anders Roxell
On Tue, 24 Oct 2023 at 18:38, Maíra Canal wrote: > > On 10/24/23 07:56, Maxime Ripard wrote: > > The VC4 mock helpers allocate the CRTC, encoders and connectors using a > > call to kunit_kzalloc(), but the DRM device they are attache to survives > > for longer than the test itself which leads to

Re: [PATCH v2 5/6] drm/vs: Add KMS crtc

2023-10-26 Thread Keith Zhao
sorry Dmitry ,accidentally wrote the wrong name Take no offense On 2023/10/26 17:42, Keith Zhao wrote: > hi Ville: > very glad to receive your feedback > Some of them are very good ideas. > Some are not very clear and hope to get your further reply! > > > On 2023/10/26 3:49, Ville Syrjälä

Re: [PATCH v2 07/11] drm/mediatek: Add secure layer config support for ovl

2023-10-26 Thread 胡俊光

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-10-26 Thread Lazar, Lijo
On 10/23/2023 8:59 PM, Alex Deucher wrote: On Fri, Oct 20, 2023 at 7:42 PM Aravind Iddamsetty wrote: Our hardware supports RAS(Reliability, Availability, Serviceability) by reporting the errors to the host, which the KMD processes and exposes a set of error counters which can be used by

Re: [PATCH 7/8] drm/msm: dsi: add support for DSI-PHY on SM8650

2023-10-26 Thread Neil Armstrong
On 25/10/2023 10:03, Dmitry Baryshkov wrote: On Wed, 25 Oct 2023 at 10:35, Neil Armstrong wrote: Add DSI PHY support for the SM8650 platform. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 +

Re: [PATCH v2 5/6] drm/vs: Add KMS crtc

2023-10-26 Thread Keith Zhao
hi Ville: very glad to receive your feedback Some of them are very good ideas. Some are not very clear and hope to get your further reply! On 2023/10/26 3:49, Ville Syrjälä wrote: > On Wed, Oct 25, 2023 at 10:28:56PM +0300, Dmitry Baryshkov wrote: >> On 25/10/2023 13:39, Keith Zhao wrote: >> >

[PATCH 2/2] drm/bridge: switch to drm_bridge_read_edid()

2023-10-26 Thread Jani Nikula
Prefer using the struct drm_edid based functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge_connector.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c index

[PATCH 0/2] drm/bridge: start moving towards struct drm_edid

2023-10-26 Thread Jani Nikula
This is just the first two patches of a lengthy series that I'm not really sure how to proceed with. Basically the series converts all of drm/bridge to the new struct drm_edid infrastructure. It's safer than struct edid, because it contains meta information about the allocated size of the EDID,

[PATCH 1/2] drm/bridge: add ->edid_read hook and drm_bridge_edid_read()

2023-10-26 Thread Jani Nikula
Add new struct drm_edid based ->edid_read hook and drm_bridge_edid_read() function to call the hook. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge.c | 46 +++- include/drm/drm_bridge.h | 33 ++ 2 files changed, 78

Re: [PATCH v7 3/6] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-26 Thread Luben Tuikov
t;> https://github.com/intel-lab-lkp/linux/commits/Matthew-Brost/drm-sched-Add-drm_sched_wqueue_-helpers/20231026-121313 >> base: 201c8a7bd1f3f415920a2df4b8a8817e973f42fe >> patch link: >> https://lore.kernel.org/r/20231026041236.1273694-4-matthew.brost%40intel.com >>

Re: [PATCH v7 3/6] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-26 Thread Luben Tuikov
thew-Brost/drm-sched-Add-drm_sched_wqueue_-helpers/20231026-121313 > base: 201c8a7bd1f3f415920a2df4b8a8817e973f42fe > patch link: > https://lore.kernel.org/r/20231026041236.1273694-4-matthew.brost%40intel.com > patch subject: [PATCH v7 3/6] drm/sched: Convert the GPU scheduler to >

Re: [PATCH v2] vga_switcheroo: Fix impossible judgment condition

2023-10-26 Thread Dan Carpenter
On Thu, Oct 26, 2023 at 05:18:04PM +0800, Su Hui wrote: > 'id' is enum type like unsigned int, so it will never be less than zero. > It's better to check VGA_SWITCHEROO_UNKNOWN_ID too. > > Fixes: 4aaf448fa975 ("vga_switcheroo: set audio client id according to bound > GPU id") > Signed-off-by: Su

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-10-26 Thread Aravind Iddamsetty
On 24/10/23 14:29, Zhang, Hawking wrote: Hi Hawking, Thank you for your comment. > [AMD Official Use Only - General] > > Hi Aravind, > > Is it allowed to register multiple genl families per drm_device? Also, is it > allowed to customize error type and even error counter (status)? In the

[PATCH v2] vga_switcheroo: Fix impossible judgment condition

2023-10-26 Thread Su Hui
'id' is enum type like unsigned int, so it will never be less than zero. It's better to check VGA_SWITCHEROO_UNKNOWN_ID too. Fixes: 4aaf448fa975 ("vga_switcheroo: set audio client id according to bound GPU id") Signed-off-by: Su Hui --- v2: - add check of VGA_SWITCHEROO_UNKNOWN_ID(Dan's

Re: [PATCH] vga_switcheroo: Fix impossible judgment condition

2023-10-26 Thread Dan Carpenter
On Thu, Oct 26, 2023 at 04:46:29PM +0800, Su Hui wrote: > On 2023/10/26 12:44, Dan Carpenter wrote: > > On Thu, Oct 26, 2023 at 10:10:57AM +0800, Su Hui wrote: > > > 'id' is enum type like unsigned int, so it will never be less than zero. > > > > > > Fixes: 4aaf448fa975 ("vga_switcheroo: set

Re: [Intel-gfx] [PATCH] drm/i915/gt: Remove {} from if-else

2023-10-26 Thread Andi Shyti
Hi Soumya, On Wed, Oct 25, 2023 at 09:43:08PM -0700, Soumya Negi wrote: > In accordance to Linux coding style(Documentation/process/4.Coding.rst), > remove unneeded braces from if-else block as all arms of this block > contain single statements. > > Suggested-by: Andi Shyti > Signed-off-by:

Re: [PATCH] drm/rockchip: vop2: Add NV20 and NV30 support

2023-10-26 Thread Christopher Obbard
Hi Jonas, On Wed, 2023-10-25 at 21:32 +, Jonas Karlman wrote: > Add support for the 10-bit 4:2:2 and 4:4:4 formats NV20 and NV30. > > These formats can be tested using modetest [1]: > >   modetest -P @:1920x1080@ > > e.g. on a ROCK 3 Model A (rk3568): > >   modetest -P

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-26 Thread Pekka Paalanen
On Wed, 25 Oct 2023 15:16:08 -0500 (CDT) Alex Goins wrote: > Thank you Harry and all other contributors for your work on this. Responses > inline - > > On Mon, 23 Oct 2023, Pekka Paalanen wrote: > > > On Fri, 20 Oct 2023 11:23:28 -0400 > > Harry Wentland wrote: > > > > > On 2023-10-20

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-10-26 Thread Dmitry Baryshkov
On Thu, 26 Oct 2023 at 11:07, Maxime Ripard wrote: > > On Thu, Oct 26, 2023 at 01:23:53AM +0300, Dmitry Baryshkov wrote: > > > +static int starfive_hdmi_register(struct drm_device *drm, struct > > > starfive_hdmi *hdmi) > > > +{ > > > + struct drm_encoder *encoder = >encoder; > > > + struct

Re: [PATCH] vga_switcheroo: Fix impossible judgment condition

2023-10-26 Thread Su Hui
On 2023/10/26 12:44, Dan Carpenter wrote: On Thu, Oct 26, 2023 at 10:10:57AM +0800, Su Hui wrote: 'id' is enum type like unsigned int, so it will never be less than zero. Fixes: 4aaf448fa975 ("vga_switcheroo: set audio client id according to bound GPU id") Signed-off-by: Su Hui ---

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-26 Thread Dmitry Baryshkov
On Thu, 26 Oct 2023 at 11:04, Maxime Ripard wrote: > > On Wed, Oct 25, 2023 at 06:16:14PM +0300, Dmitry Baryshkov wrote: > > On 25/10/2023 15:44, Maxime Ripard wrote: > > > On Thu, Oct 19, 2023 at 02:19:51PM +0300, Dmitry Baryshkov wrote: > > > > On Thu, 19 Oct 2023 at 12:26, Maxime Ripard

Re: [PATCH 1/1] drm/mediatek: Fix errors when reporting rotation capability

2023-10-26 Thread 胡俊光

Re: [PATCH 1/1] drm/mediatek: Fix errors when reporting rotation capability

2023-10-26 Thread 宋孝謙

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-10-26 Thread Maxime Ripard
On Thu, Oct 26, 2023 at 01:23:53AM +0300, Dmitry Baryshkov wrote: > > +static int starfive_hdmi_register(struct drm_device *drm, struct > > starfive_hdmi *hdmi) > > +{ > > + struct drm_encoder *encoder = >encoder; > > + struct device *dev = hdmi->dev; > > + > > + encoder->possible_crtcs =

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-26 Thread Maxime Ripard
On Wed, Oct 25, 2023 at 06:16:14PM +0300, Dmitry Baryshkov wrote: > On 25/10/2023 15:44, Maxime Ripard wrote: > > On Thu, Oct 19, 2023 at 02:19:51PM +0300, Dmitry Baryshkov wrote: > > > On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote: > > > > > > > > On Mon, Oct 16, 2023 at 07:53:48PM +0300,

Re: [PATCH] drm/i915/gt: Remove {} from if-else

2023-10-26 Thread Karolina Stolarek
On 26.10.2023 06:43, Soumya Negi wrote: In accordance to Linux coding style(Documentation/process/4.Coding.rst), remove unneeded braces from if-else block as all arms of this block contain single statements. I'd just keep the description simple, and say that braces are not needed for single

Re: [PATCH 4/9] dma-buf: heaps: Initialise MediaTek secure heap

2023-10-26 Thread Vijayanand Jitta
On 10/20/2023 3:29 PM, Yong Wu (吴勇) wrote: > On Thu, 2023-10-19 at 10:15 +0530, Vijayanand Jitta wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 9/11/2023 8:00 AM, Yong Wu wrote: >>>

[PATCH] drm/i915/gt: Remove {} from if-else

2023-10-26 Thread Soumya Negi
In accordance to Linux coding style(Documentation/process/4.Coding.rst), remove unneeded braces from if-else block as all arms of this block contain single statements. Suggested-by: Andi Shyti Signed-off-by: Soumya Negi --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 7 +++ 1 file changed, 3

Re: [PATCH v7 3/6] drm/sched: Convert the GPU scheduler to variable number of run-queues

2023-10-26 Thread kernel test robot
Hi Matthew, kernel test robot noticed the following build warnings: [auto build test WARNING on 201c8a7bd1f3f415920a2df4b8a8817e973f42fe] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Brost/drm-sched-Add-drm_sched_wqueue_-helpers/20231026-121313 base

  1   2   >