Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-28 Thread Huacai Chen
On Sat, Oct 28, 2023 at 7:06 PM Jaak Ristioja wrote: > > On 26.10.23 03:58, Huacai Chen wrote: > > Hi, Jaak, > > > > On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja wrote: > >> > >> On 25.10.23 16:23, Huacai Chen wrote: > >>> On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis > >>> wrote: > >

[PATCH] drm/tests: Add KUnit tests for drm_mode_create_dvi_i_properties()

2023-10-28 Thread Dipam Turkar
Introduce unit tests for the drm_mode_create_dvi_i_properties() function to ensure the proper creation of DVI-I specific connector properties. Signed-off-by: Dipam Turkar --- drivers/gpu/drm/tests/drm_connector_test.c | 20 1 file changed, 20 insertions(+) diff --git a/dri

[PATCH 8/8] accel/ivpu: Rename VPU to NPU in product strings

2023-10-28 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz VPU was rebranded as NPU (Neural Processing Unit) so user facing strings have to be updated but the code remains as is and the module is still called intel_vpu.ko. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- dri

[PATCH 5/8] accel/ivpu: Print CMDQ errors after consumer timeout

2023-10-28 Thread Stanislaw Gruszka
From: Karol Wachowski Add checking of error reason bits in IVPU_MMU_CMDQ_CONS register when waiting for consumer timeout occurred. Signed-off-by: Karol Wachowski Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_mmu.c | 34 +++

[PATCH 7/8] accel/ivpu: Simplify MMU SYNC command

2023-10-28 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz CMD_SYNC does not need any args as we poll for completion anyway. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_mmu.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a

[PATCH 6/8] accel/ivpu: Make DMA allocations for MMU600 write combined

2023-10-28 Thread Stanislaw Gruszka
From: Karol Wachowski Previously using dma_alloc_wc() API we created cache coherent (mapped as write-back) mappings. Because we disable MMU600 snooping it was required to do costly page walk and cache flushes after each page table modification. With write-combined buffers it's possible to do a

[PATCH 4/8] accel/ivpu: Abort pending rx ipc on reset

2023-10-28 Thread Stanislaw Gruszka
Waking up process, which wait for particular condition, will go to sleep again on wake_up() if the condition is not met. Add abort flag to wake up IPC receivers, which will finish with -ECANCELED error. This is only needed for reset, run time power management prevent to suspend VPU when there is p

[PATCH 2/8] accel/ivpu: Assure device is off if power up sequence fail

2023-10-28 Thread Stanislaw Gruszka
We should not leave device half enabled if there is failure somewhere it power up sequence. Fix device init and resume paths. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 2 +- drivers/accel/ivpu/ivpu_pm.c | 30 +

[PATCH 1/8] accel/ivpu/40xx: Allow to change profiling frequency

2023-10-28 Thread Stanislaw Gruszka
From: Krystian Pradzynski Profiling freq is a debug firmware feature. It switches default clock to higher resolution for fine-grained and more accurate firmware task profiling. We already configure it during boot up of VPU4. Add debugfs knob and helpers per HW generation that allow to change it.

[PATCH 0/8] accel/ivpu: Update for -next 2023-10-28

2023-10-28 Thread Stanislaw Gruszka
Various driver updates: - MMU page tables handling optimizations - Rebrand to NPU - FW profiling frequency knob - job done thread suspend handling This is based on top of previous update: https://lore.kernel.org/dri-devel/20231028133415.1169975-1-stanislaw.grus...@linux.intel.com/ Jacek Lawry

[PATCH 3/8] accel/ivpu: Stop job_done_thread on suspend

2023-10-28 Thread Stanislaw Gruszka
Stop job_done thread when going to suspend. Use kthread_park() instead of kthread_stop() to avoid memory allocation and potential failure on resume. Use separate function as thread wake up condition. Use spin lock to assure rx_msg_list is properly protected against concurrent access. Reviewed-by:

Re: [PATCH] drm/msm/gem: Add metadata

2023-10-28 Thread Rob Clark
On Fri, Oct 27, 2023 at 6:16 PM Dmitry Baryshkov wrote: > > On Fri, 27 Oct 2023 at 22:45, Rob Clark wrote: > > > > From: Rob Clark > > > > The EXT_external_objects extension is a bit awkward as it doesn't pass > > explicit modifiers, leaving the importer to guess with incomplete > > information.

[PATCH v2 11/11] accel/ivpu: Add support for delayed D0i3 entry message

2023-10-28 Thread Stanislaw Gruszka
From: Andrzej Kacprowski Currently the VPU firmware prepares for D0i3 every time the VPU is entering D0i2 Idle state. This is not optimal as we might not enter D0i3 every time we enter D0i2 Idle and this preparation is quite costly. This optimization moves D0i3 preparation to a dedicated message

[PATCH v2 10/11] accel/ivpu/37xx: Print warning when VPUIP is not idle during power down

2023-10-28 Thread Stanislaw Gruszka
Print warning if VPUIP is not idle during power down. Use warn log level also when we fail to enter reset state as this is not really an error but unexpected behavior. Reviewed-by: Krystian Pradzynski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx.c | 7 +-- 1 file ch

[PATCH v2 09/11] accel/ivpu: Introduce ivpu_ipc_send_receive_active()

2023-10-28 Thread Stanislaw Gruszka
From: Karol Wachowski Split ivpu_ipc_send_receive() implementation to have a version that does not call pm_runtime_resume_and_get(). That implementation can be invoked when device is up and runtime resume is prohibited (for example at the end of boot sequence). The new function will be used for

[PATCH v2 08/11] accel/ivpu: Pass D0i3 residency time to the VPU firmware

2023-10-28 Thread Stanislaw Gruszka
From: Andrzej Kacprowski The firmware needs to know the time spent in D0i3/D3 to calculate telemetry data. The D0i3/D3 residency time is calculated by the driver and passed to the firmware in the boot parameters. The driver also passes VPU perf counter value captured right before entering D0i3 -

[PATCH v2 06/11] accel/ivpu: Change test_mode module param to bitmask

2023-10-28 Thread Stanislaw Gruszka
From: Karol Wachowski Change meaning of test_mode module parameter from integer value to bitmask allowing setting different test features with corresponding bits. Signed-off-by: Karol Wachowski Reviewed-by: Stanislaw Gruszka Reviewed-by: Jeffrey Hugo Signed-off-by: Stanislaw Gruszka --- dri

[PATCH v2 07/11] accel/ivpu/40xx: Capture D0i3 entry host and device timestamps

2023-10-28 Thread Stanislaw Gruszka
From: Andrzej Kacprowski The driver needs to capture the D0i3 entry timestamp to calculate D0i3 residency time. The D0i3 residency time and the VPU timestamp are passed to the firmware at D0i3 exit (warm boot). Signed-off-by: Andrzej Kacprowski Reviewed-by: Stanislaw Gruszka Reviewed-by: Jeff

[PATCH v2 05/11] accel/ivpu: Add support for VPU_JOB_FLAGS_NULL_SUBMISSION_MASK

2023-10-28 Thread Stanislaw Gruszka
From: Andrzej Kacprowski Add test_mode = 3 that add VPU_JOB_FLAGS_NULL_SUBMISSION_MASK flag to the job send to the VPU device. Then the VPU will process the job but won't execute commands (except the command to signal the fence). This can be used to estimate job processing overhead in the host s

[PATCH v2 04/11] accel/ivpu: Remove reset from power up sequence

2023-10-28 Thread Stanislaw Gruszka
From: Karol Wachowski Setting a non-zero work point resets the IP hence IP_RESET trigger is redundant. Signed-off-by: Karol Wachowski Reviewed-by: Stanislaw Gruszka Reviewed-by: Jeffrey Hugo Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx.c | 4 drivers/accel/ivpu/

[PATCH v2 02/11] accel/ivpu: Remove unneeded drm_driver declaration

2023-10-28 Thread Stanislaw Gruszka
Cleanup drm_driver declaration leftover. Reviewed-by: Krystian Pradzynski Reviewed-by: Jeffrey Hugo Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c index b6aa88

[PATCH v2 03/11] accel/ivpu: Add dvfs_mode file to debugfs

2023-10-28 Thread Stanislaw Gruszka
From: Tomasz Rusinowicz Add new debugfs file to set dvfs_mode FW boot parameter and restart the FW to allow experimenting with DVFS (dynamic voltage & frequency scaling). Signed-off-by: Tomasz Rusinowicz Reviewed-by: Jeffrey Hugo Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_d

[PATCH v2 01/11] accel/ivpu: Update FW API

2023-10-28 Thread Stanislaw Gruszka
From: Krystian Pradzynski Bump boot API to 4.20 Bump JSM API to 3.15 Signed-off-by: Krystian Pradzynski Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_jsm_msg.c | 17 ++ drivers/accel/ivpu/vpu_boot_api.h | 90 - drivers/accel/ivpu/vpu_js

[PATCH v2 00/11] accel/ivpu: Update for -next 2023-10-25

2023-10-28 Thread Stanislaw Gruszka
Various driver updates: - FW api update - suspend/resume optimizations - dynamic valtage and frequency mode knob - new test modes v2: - fix spelling mistakes pointed Jeffrey - move patch 7, add note where new function will be used - change patches 8 and 9 ordering - separate print warn

Re: [PATCH] drm/radeon: replace 1-element arrays with flexible-array members

2023-10-28 Thread José Pekkarinen
On 2023-10-27 20:55, Deucher, Alexander wrote: [Public] -Original Message- From: José Pekkarinen Sent: Friday, October 27, 2023 12:59 PM To: Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; sk...@linuxfoundation.org Cc: José Pekkarinen ; airl...@gmail.com; dan...@ffwll.ch; amd-..

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-10-28 Thread Jaak Ristioja
On 26.10.23 03:58, Huacai Chen wrote: Hi, Jaak, On Thu, Oct 26, 2023 at 2:49 AM Jaak Ristioja wrote: On 25.10.23 16:23, Huacai Chen wrote: On Wed, Oct 25, 2023 at 6:08 PM Thorsten Leemhuis wrote: Javier, Dave, Sima, On 23.10.23 00:54, Evan Preston wrote: On 2023-10-20 Fri 05:48pm, Huaca

[PATCH] drm/panel-edp: Add timings for BOE NV133WUM-N63

2023-10-28 Thread Clayton Craft
This panel is found on laptops e.g., variants of the Thinkpad X13s. Configuration was collected from the panel's EDID. Signed-off-by: Clayton Craft --- drivers/gpu/drm/panel/panel-edp.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-e

[linux-next:master] BUILD REGRESSION 66f1e1ea3548378ff6387b1ce0b40955d54e86aa

2023-10-28 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 66f1e1ea3548378ff6387b1ce0b40955d54e86aa Add linux-next specific files for 20231027 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202310042215.w9pg3rqs-...@intel.com https://lore

Re: [PATCH 10/11] accel/ivpu: Add support for delayed D0i3 entry message

2023-10-28 Thread Stanislaw Gruszka
On Fri, Oct 27, 2023 at 09:07:22AM -0600, Jeffrey Hugo wrote: > > + if (!ivpu_hw_37xx_is_idle(vdev)) { > > + ivpu_warn(vdev, "VPU not idle during power down\n"); > > + if (ivpu_hw_37xx_ip_reset(vdev)) > > + ivpu_err(vdev, "Failed to reset the VPU\n"); > > +

Re: [PATCH 07/11] accel/ivpu: Introduce ivpu_ipc_send_receive_active()

2023-10-28 Thread Stanislaw Gruszka
On Fri, Oct 27, 2023 at 08:49:21AM -0600, Jeffrey Hugo wrote: > On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote: > > From: Karol Wachowski > > > > Split ivpu_ipc_send_receive() implementation to have a version > > that does not call pm_runtime_resume_and_get(). That implementation > > can be invok

Re: [PATCH 11/11] accel/ivpu: Wait for VPU to enter idle state after D0i3 entry message

2023-10-28 Thread Stanislaw Gruszka
On Fri, Oct 27, 2023 at 09:09:16AM -0600, Jeffrey Hugo wrote: > On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote: > > From: Andrzej Kacprowski > > > > The VPU needs non zero time to enter IDLE state after responding to > > D0i3 entry message. If the driver does not wait for the VPU to enter > > IDL

Re: [PATCH 06/11] accel/ivpu: Change test_mode module param to bitmask

2023-10-28 Thread Stanislaw Gruszka
On Fri, Oct 27, 2023 at 08:47:11AM -0600, Jeffrey Hugo wrote: > On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote: > > From: Karol Wachowski > > > > Change meaning of test_mode module parameter from integer value > > to bitmask allowing setting different test features with corresponding > > bits. >

Re: [PATCH 01/11] accel/ivpu: Update FW API

2023-10-28 Thread Stanislaw Gruszka
Hi On Fri, Oct 27, 2023 at 08:37:39AM -0600, Jeffrey Hugo wrote: > On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote: > > From: Krystian Pradzynski > > > > Bump boot API to 4.20 > > Bump JSM API to 3.15 > > > > Signed-off-by: Krystian Pradzynski > > Reviewed-by: Stanislaw Gruszka > > Signed-off-