Re: [PATCH 20/32] media/ivtvfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-11-20 Thread Thomas Zimmermann
Hi Am 20.11.23 um 09:52 schrieb Hans Verkuil: Hi Thomas, On 15/11/2023 11:19, Thomas Zimmermann wrote: Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. This explictily sets the read/write, draw and mmap callbacks to the correct

Re: [EXTERNAL] Re: [PATCH v8 02/20] drm/gpuvm: Helper to get range of unmap from a remap op.

2023-11-20 Thread Donald Robson
On Tue, 2023-11-14 at 17:42 +0100, Danilo Krummrich wrote: > *** CAUTION: This email originates from a source not known to Imagination > Technologies. Think before you click a link or open an attachment *** > > On 10/31/23 16:12, Sarah Walker wrote: > > From: Donald Robson > > > > Determining

Re: [PATCH v18 11/26] drm/shmem-helper: Prepare drm_gem_shmem_free() to shrinker addition

2023-11-20 Thread Boris Brezillon
On Mon, 20 Nov 2023 14:02:29 +0300 Dmitry Osipenko wrote: > On 11/10/23 13:16, Boris Brezillon wrote: > > On Mon, 30 Oct 2023 02:01:50 +0300 > > Dmitry Osipenko wrote: > > > >> Prepare drm_gem_shmem_free() to addition of memory shrinker support > >> to drm-shmem by adding and using variant

Re: [PATCH v18 11/26] drm/shmem-helper: Prepare drm_gem_shmem_free() to shrinker addition

2023-11-20 Thread Dmitry Osipenko
On 11/10/23 13:16, Boris Brezillon wrote: > On Mon, 30 Oct 2023 02:01:50 +0300 > Dmitry Osipenko wrote: > >> Prepare drm_gem_shmem_free() to addition of memory shrinker support >> to drm-shmem by adding and using variant of put_pages() that doesn't >> touch reservation lock. Reservation

Re: [PATCH 2/2] drm/i915: Add __rcu annotation to cursor when iterating client objects

2023-11-20 Thread Andi Shyti
Hi Tvrtko, On Mon, Nov 13, 2023 at 08:54:57AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > __rcu annotation is needed to avoid the sparse warnings such as: > > .../i915_drm_client.c:92:9: sparse: sparse: incompatible types in > comparison expression (different address spaces): >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove return type from i915_drm_client_remove_object

2023-11-20 Thread Andi Shyti
Hi Tvrtko, On Mon, Nov 13, 2023 at 08:54:56AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > There is no need to return anything in the version which was merged and > also the implementation of the !CONFIG_PROC_FS wasn't returning anything, > causing a build failure there. > >

RE: [PATCH v3] drm/bridge: panel: Add a device link between drm device and panel device

2023-11-20 Thread Ying Liu
Hi Linus, On Wednesday, November 15, 2023 6:00 AM, Linus Walleij wrote: > On Mon, Aug 7, 2023 at 8:06 AM Liu Ying wrote: > > > Add the device link when panel bridge is attached and delete the link > > when panel bridge is detached. The drm device is the consumer while > > the panel device is

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add __rcu annotation to cursor when iterating client objects

2023-11-20 Thread Jani Nikula
On Mon, 13 Nov 2023, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > __rcu annotation is needed to avoid the sparse warnings such as: > > .../i915_drm_client.c:92:9: sparse: sparse: incompatible types in > comparison expression (different address spaces): > .../i915_drm_client.c:92:9:

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-20 Thread Dmitry Baryshkov
On Fri, 17 Nov 2023 at 19:36, Sui Jingfeng wrote: > > Hi, > > > On 2023/11/17 17:03, Dmitry Baryshkov wrote: > > On Fri, 17 Nov 2023 at 06:24, Sui Jingfeng wrote: > >> Hi, > >> > >> On 2023/11/16 23:23, Dmitry Baryshkov wrote: > >> Then you will need some way (fwnode?) to > >> discover

Re: [PATCH 1/2] drm/i915: Remove return type from i915_drm_client_remove_object

2023-11-20 Thread Jani Nikula
On Mon, 13 Nov 2023, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > There is no need to return anything in the version which was merged and > also the implementation of the !CONFIG_PROC_FS wasn't returning anything, > causing a build failure there. > > Signed-off-by: Tvrtko Ursulin > Fixes:

Re: [PATCH] dma-buf: Replace strlcpy() with strscpy()

2023-11-20 Thread Christian König
Am 17.11.23 um 19:50 schrieb T.J. Mercier: On Thu, Nov 16, 2023 at 11:14 AM Kees Cook wrote: strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not

Re: [PULL] drm-misc-next

2023-11-20 Thread Daniel Vetter
On Fri, Nov 17, 2023 at 10:41:34AM +0100, Maxime Ripard wrote: > Hi, > > Here's the first drm-misc-next PR for what will become 6.8. > > There's one missing SoB on the commit 0da611a87021 ("dma-buf: add > dma_fence_timestamp helper") from the committer. They provided their SoB > on the ML here

[PATCH 2/2] drm/bridge: anx7625: Fix Set HPD irq detect window to 2ms

2023-11-20 Thread Xin Ji
Polling firmware HPD GPIO status, set HPD irq detect window to 2ms after firmware HPD GPIO initial done Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 51 --- drivers/gpu/drm/bridge/analogix/anx7625.h | 4 ++ 2 files changed, 40 insertions(+), 15

[PATCH 1/2] Revert "drm/bridge: Add 200ms delay to wait FW HPD status stable"

2023-11-20 Thread Xin Ji
This reverts commit 330140d7319fcc4ec68bd924ea212e476bf12275 200ms delay will cause panel display image later than backlight turn on, revert this patch. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-20 Thread kernel test robot
Hi Sui, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.7-rc2 next-20231120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH 20/32] media/ivtvfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-11-20 Thread Hans Verkuil
Hi Thomas, On 15/11/2023 11:19, Thomas Zimmermann wrote: > Initialize the instance of struct fb_ops with fbdev initializer > macros for framebuffers in I/O address space. This explictily sets > the read/write, draw and mmap callbacks to the correct default > implementation. > > Fbdev drivers

Re: [PATCH v4 3/5] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v4)

2023-11-20 Thread David Hildenbrand
On 18.11.23 07:32, Vivek Kasireddy wrote: For drivers that would like to longterm-pin the pages associated with a file, the pin_user_pages_fd() API provides an option to not only pin the pages via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API

Re: [PATCH V2 0/5] Elida KD35T133 Panel Improvements

2023-11-20 Thread Neil Armstrong
Hi, On Fri, 17 Nov 2023 13:44:00 -0600, Chris Morgan wrote: > From: Chris Morgan > > Fix a few bugs and clean up no longer needed code on the Elida KD35T133 > DSI panel, as used in devices such as the Odroid Go Advance and the > Anbernic RG351M. > > Changes since V1: > - Split removal of

Re: (subset) [PATCH V4 0/6] rockchip: Add Powkiddy RK2023

2023-11-20 Thread Neil Armstrong
Hi, On Fri, 17 Nov 2023 14:25:30 -0600, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Powkiddy RK2023, which is extremely similar to > existing Powkiddy RGB30 device. > > Changes since V3: > - Corrected commit subject lines. > > [...] Thanks, Applied to

Re: [PATCH V2 5/5] drm/panel-elida-kd35t133: Drop prepare/unprepare logic

2023-11-20 Thread neil . armstrong
On 17/11/2023 20:44, Chris Morgan wrote: From: Chris Morgan Drop the prepare/unprepare logic, as this is now tracked elsewhere since this commit [1]. [1] commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel") Signed-off-by: Chris Morgan ---

Re: [PATCH V2 4/5] drm/panel-elida-kd35t133: Drop shutdown logic

2023-11-20 Thread neil . armstrong
On 17/11/2023 20:44, Chris Morgan wrote: From: Chris Morgan The driver shutdown is duplicate as it calls drm_unprepare and drm_disable which are called anyway when associated drivers are shutdown/removed. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/panel-elida-kd35t133.c | 17

Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags

2023-11-20 Thread neil . armstrong
On 19/11/2023 20:50, Marek Vasut wrote: On 11/17/23 09:40, Maxime Ripard wrote: On Thu, Nov 16, 2023 at 10:15:31PM +0100, Marek Vasut wrote: On 10/9/23 10:58, Neil Armstrong wrote: On 09/10/2023 00:33, Marek Vasut wrote: Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel

Re: [Freedreno] [PATCH v2] drm/msm: remove unnecessary NULL check

2023-11-20 Thread Dan Carpenter
On Thu, Nov 16, 2023 at 01:05:52PM -0800, Abhinav Kumar wrote: > > > On 11/1/2023 12:23 PM, Abhinav Kumar wrote: > > > > > > On 10/13/2023 1:25 AM, Dan Carpenter wrote: > > > This NULL check was required when it was added, but we shuffled the code > > > around and now it's not.? The

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-20 Thread Neil Armstrong
On 17/11/2023 18:14, Sui Jingfeng wrote: Hi, On 2023/11/17 17:03, Dmitry Baryshkov wrote: On Fri, 17 Nov 2023 at 06:24, Sui Jingfeng wrote: Hi, On 2023/11/16 23:23, Dmitry Baryshkov wrote: Then you will need some way (fwnode?) to discover the bridge chain. And at the last point you will

Re: [PATCH 8/9] dt-bindings: reserved-memory: MediaTek: Add reserved memory for SVP

2023-11-20 Thread Jaskaran Singh
On 11/6/2023 11:26 AM, Yong Wu (吴勇) wrote: > On Wed, 2023-11-01 at 11:20 +0530, Jaskaran Singh wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 10/20/2023 3:20 PM, Yong Wu (吴勇) wrote: >>> On Thu,

Re: [PATCH 1/2] accel/qaic: Increase number of in_reset states

2023-11-20 Thread Jacek Lawrynowicz
Hi, On 17.11.2023 18:43, Jeffrey Hugo wrote: > From: Carl Vanderlip > > 'in_reset' holds the state of the device. As part of bringup, the device > needs to be queried to check if it's in a valid state. Add a new state > that indicates that the device is coming up, but not ready for users > yet.

Re: [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support

2023-11-20 Thread Neil Armstrong
On 19/11/2023 12:28, Heiner Kallweit wrote: After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove

<    1   2