Re: [PATCH 4/8] drm/bridge: it66121: Add a helper function to get the next bridge

2023-11-22 Thread Dmitry Baryshkov
On Thu, 23 Nov 2023 at 07:25, Sui Jingfeng wrote: > > Hi, > > > On 2023/11/15 00:05, Dmitry Baryshkov wrote: > > On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > >> From: Sui Jingfeng > >> > >> Group the code lines(which with the same functional) into one dedicated > >> function, which reduce

Re: [PATCH 5/8] drm/bridge: it66121: Add a helper function to read chip id

2023-11-22 Thread Dmitry Baryshkov
On Thu, 23 Nov 2023 at 07:37, Sui Jingfeng wrote: > > Hi, > > > On 2023/11/16 21:00, Dmitry Baryshkov wrote: > > On Thu, 16 Nov 2023 at 14:18, Sui Jingfeng wrote: > >> Hi, > >> > >> > >> On 2023/11/15 00:06, Dmitry Baryshkov wrote: > >>> On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > F

Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-22 Thread Heiner Kallweit
On 23.11.2023 07:56, Thomas Zimmermann wrote: > Hi > > Am 20.11.23 um 22:46 schrieb Heiner Kallweit: >> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >> Class-based device auto-detection is a legacy m

[PATCH v5 3/5] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v5)

2023-11-22 Thread Vivek Kasireddy
For drivers that would like to longterm-pin the pages associated with a file, the pin_user_pages_fd() API provides an option to not only pin the pages via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API currently works with files that belong to eith

[PATCH v5 4/5] udmabuf: Pin the pages using pin_user_pages_fd() API (v3)

2023-11-22 Thread Vivek Kasireddy
Using pin_user_pages_fd() will ensure that the pages are pinned correctly using FOLL_PIN. And, this also ensures that we don't accidentally break features such as memory hotunplug as it would not allow pinning pages in the movable zone. Using this new API also simplifies the code as we no longer h

[PATCH v5 2/5] udmabuf: Add back support for mapping hugetlb pages (v4)

2023-11-22 Thread Vivek Kasireddy
A user or admin can configure a VMM (Qemu) Guest's memory to be backed by hugetlb pages for various reasons. However, a Guest OS would still allocate (and pin) buffers that are backed by regular 4k sized pages. In order to map these buffers and create dma-bufs for them on the Host, we first need to

[PATCH v5 1/5] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap

2023-11-22 Thread Vivek Kasireddy
Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Daniel V

[PATCH v5 5/5] selftests/dma-buf/udmabuf: Add tests to verify data after page migration

2023-11-22 Thread Vivek Kasireddy
Since the memfd pages associated with a udmabuf may be migrated as part of udmabuf create, we need to verify the data coherency after successful migration. The new tests added in this patch try to do just that using 4k sized pages and also 2 MB sized huge pages for the memfd. Successful completion

[PATCH v5 0/5] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v5)

2023-11-22 Thread Vivek Kasireddy
The first two patches were previously reviewed but not yet merged. These ones need to be merged first as the fourth patch depends on the changes introduced in them and they also fix bugs seen in very specific scenarios (running Qemu with hugetlb=on, blob=true and rebooting guest VM). The third pat

RE: [PATCH] drm/i915/psr: Fix unsigned expression compared with zero

2023-11-22 Thread Kahola, Mika
> -Original Message- > From: Jani Nikula > Sent: Wednesday, November 22, 2023 11:15 AM > To: Jiapeng Chong > Cc: joonas.lahti...@linux.intel.com; Vivi, Rodrigo ; > tvrtko.ursu...@linux.intel.com; airl...@gmail.com; > dan...@ffwll.ch; intel-...@lists.freedesktop.org; > dri-devel@lists.fr

Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support

2023-11-22 Thread Thomas Zimmermann
Hi Am 20.11.23 um 22:46 schrieb Heiner Kallweit: After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remov

Re: [PATCH 5/8] drm/bridge: it66121: Add a helper function to read chip id

2023-11-22 Thread Sui Jingfeng
Hi, On 2023/11/16 21:00, Dmitry Baryshkov wrote: On Thu, 16 Nov 2023 at 14:18, Sui Jingfeng wrote: Hi, On 2023/11/15 00:06, Dmitry Baryshkov wrote: On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: From: Sui Jingfeng Read the required chip id data back by calling regmap_bulk_read() onc

Re: [PATCH 4/8] drm/bridge: it66121: Add a helper function to get the next bridge

2023-11-22 Thread Sui Jingfeng
Hi, On 2023/11/15 00:05, Dmitry Baryshkov wrote: On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: From: Sui Jingfeng Group the code lines(which with the same functional) into one dedicated function, which reduce the weight of it66121_probe() function. Just trivial cleanuo, no functional ch

[PATCH v2] drm/bridge: imx93-mipi-dsi: Fix a couple of building warnings

2023-11-22 Thread Liu Ying
Fix a couple of building warnings on used uninitialized 'best_m' and 'best_n' local variables by initializing 'best_m' to zero and 'best_n' to UINT_MAX. This makes compiler happy only. No functional change. Fixes: ce62f8ea7e3f ("drm/bridge: imx: Add i.MX93 MIPI DSI support") Reported-by: kernel

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-22 Thread Sui Jingfeng
Hi, On 2023/11/16 19:19, Dmitry Baryshkov wrote: On Thu, 16 Nov 2023 at 12:13, Sui Jingfeng wrote: Hi, On 2023/11/16 17:30, Dmitry Baryshkov wrote: On Thu, 16 Nov 2023 at 11:14, Sui Jingfeng wrote: Hi, Thanks a lot for reviewing! On 2023/11/15 00:30, Dmitry Baryshkov wrote: On Tue, 1

[PATCH] drm/msm/gpu: Fix null-pointer dereference in zap_shader_load_mdt

2023-11-22 Thread Kunwu Chan
kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Ensure the allocation was successful by checking the pointer validity. Fixes: a9e2559c931d ("drm/msm/gpu: Move zap shader loading to adreno") Signed-off-by: Kunwu Chan --- drivers/gpu/drm/msm/adreno/adr

[PATCH] drm/bridge: panel: Check device dependency before managing device link

2023-11-22 Thread Liu Ying
Some panel devices already depend on DRM device, like the panel in arch/arm/boot/dts/st/ste-ux500-samsung-skomer.dts, because DRM device is the ancestor of those panel devices. device_link_add() would fail by returning a NULL pointer for those panel devices because of the existing dependency. So,

RE: [PATCH v3] drm/bridge: panel: Add a device link between drm device and panel device

2023-11-22 Thread Ying Liu
On Wednesday, November 22, 2023 9:59 PM, Linus Walleij wrote: > Hi Ying, Hi Linus, > > On Mon, Nov 20, 2023 at 11:08 AM Ying Liu wrote: > > [Me] > > > > v2->v3: > > > > * Improve commit message s/swapped/reversed/. > > > > > > This patch causes a regression in the Ux500 MCDE > > > drivers/gp

Re: [PATCH 1/3] riscv: Add support for kernel-mode FPU

2023-11-22 Thread kernel test robot
Hi Samuel, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.7-rc2 next-20231122] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: Radeon regression in 6.6 kernel

2023-11-22 Thread Luben Tuikov
On 2023-11-21 17:05, Phillip Susi wrote: > Alex Deucher writes: > >> Does reverting 56e449603f0ac580700621a356d35d5716a62ce5 alone fix it? >> Can you also attach your full dmesg log for the failed suspend? > > No, it doesn't. Here is the full syslog from the boot with only that > revert: > Th

Re: [PATCH] drm/rockchip: rk3066_hdmi: include drm/drm_atomic.h

2023-11-22 Thread Heiko Stuebner
On Wed, 22 Nov 2023 23:18:29 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Without this header, the newly added code fails to build: > > drivers/gpu/drm/rockchip/rk3066_hdmi.c: In function > 'rk3066_hdmi_encoder_enable': > drivers/gpu/drm/rockchip/rk3066_hdmi.c:397:22: error: implicit d

[PATCH v2] drm/amdgpu: Fix cat debugfs amdgpu_regs_didt causes kernel null pointer

2023-11-22 Thread Lu Yao
For 'AMDGPU_FAMILY_SI' family cards, in 'si_common_early_init' func, init 'didt_rreg' and 'didt_wreg' to 'NULL'. But in func 'amdgpu_debugfs_regs_didt_read/write', using 'RREG32_DIDT' 'WREG32_DIDT' lacks of relevant judgment. And other 'amdgpu_ip_block_version' that use these two definitions won't

Re: [PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine

2023-11-22 Thread Danila Tikhonov
sc7180/sm7125 (atoll) expects speedbins from atoll.dtsi: And has a parameter: /delete-property/ qcom,gpu-speed-bin; 107 for 504Mhz max freq, pwrlevel 4 130 for 610Mhz max freq, pwrlevel 3 159 for 750Mhz max freq, pwrlevel 5 169 for 800Mhz max freq, pwrlevel 2 174 for 825Mhz max freq, pwrlevel 1 (D

Re: [PATCH v2 1/4] i915: make inject_virtual_interrupt() void

2023-11-22 Thread Zhenyu Wang
On 2023.11.22 13:48:22 +0100, Christian Brauner wrote: > The single caller of inject_virtual_interrupt() ignores the return value > anyway. This allows us to simplify eventfd_signal() in follow-up > patches. > > Signed-off-by: Christian Brauner > --- > drivers/gpu/drm/i915/gvt/interrupt.c | 14 +

[PATCH 6/6] x86/vmware: Add TDX hypercall support

2023-11-22 Thread Alexey Makhalov
VMware hypercalls use I/O port, VMCALL or VMMCALL instructions. Add __tdx_hypercall path to support TDX guests. No change in high bandwidth hypercalls, as only low bandwidth ones are supported for TDX guests. Co-developed-by: Tim Merrifield Signed-off-by: Tim Merrifield Signed-off-by: Alexey Ma

[PATCH 5/6] drm/vmwgfx: Use vmware_hypercall API

2023-11-22 Thread Alexey Makhalov
Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. Eliminate arch specific code. drivers/gpu/drm/vmwgfx/vmwgfx_msg_arm64.h: implement arm64 variant of vmware_hypercall here. To be moved to arch/arm64/include/asm/vmware.h later. Signed-off-by: Alexey Makhalov --- drivers/gpu/drm/vmwgfx/

[PATCH 3/6] ptp/vmware: Use vmware_hypercall API

2023-11-22 Thread Alexey Makhalov
Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. Eliminate arch specific code. No functional changes intended. Signed-off-by: Alexey Makhalov --- drivers/ptp/ptp_vmw.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/ptp/ptp_vmw.c b/drivers/ptp/

[PATCH 1/6] x86/vmware: Move common macros to vmware.h

2023-11-22 Thread Alexey Makhalov
Move VMware hypercall macros to vmware.h as a preparation step for the next commit. No functional changes besides exporting vmware_hypercall_mode symbol. Signed-off-by: Alexey Makhalov --- arch/x86/include/asm/vmware.h | 69 ++- arch/x86/kernel/cpu/vmware.c | 57

[PATCH 0/6] VMware hypercalls enhancements

2023-11-22 Thread Alexey Makhalov
VMware hypercalls invocations were all spread out across the kernel implementing same ABI as in-place asm-inline. With encrypted memory and confidential computing it became harder to maintain every changes in these hypercall implementations. Intention of this patchset is to introduce arch independ

[PATCH 6/6] x86/vmware: Add TDX hypercall support

2023-11-22 Thread Alexey Makhalov
VMware hypercalls use I/O port, VMCALL or VMMCALL instructions. Add __tdx_hypercall path to support TDX guests. No change in high bandwidth hypercalls, as only low bandwidth ones are supported for TDX guests. Co-developed-by: Tim Merrifield Signed-off-by: Tim Merrifield Signed-off-by: Alexey Ma

[PATCH 2/6] x86/vmware: Introduce vmware_hypercall API

2023-11-22 Thread Alexey Makhalov
Introducing vmware_hypercall family of functions as a common implementation to be used by the VMware guest code and virtual device drivers in arhitecture independent manner. By analogy with KVM hypercall API, vmware_hypercallX and vmware_hypercall_hb_{out,in} set of functions was added to achieve

[PATCH 1/6] x86/vmware: Move common macros to vmware.h

2023-11-22 Thread Alexey Makhalov
Move VMware hypercall macros to vmware.h as a preparation step for the next commit. No functional changes besides exporting vmware_hypercall_mode symbol. Signed-off-by: Alexey Makhalov --- arch/x86/include/asm/vmware.h | 69 ++- arch/x86/kernel/cpu/vmware.c | 57

[PATCH 4/6] input/vmmouse: Use vmware_hypercall API

2023-11-22 Thread Alexey Makhalov
Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. Eliminate arch specific code. No functional changes intended. Signed-off-by: Alexey Makhalov --- drivers/input/mouse/vmmouse.c | 76 ++- 1 file changed, 22 insertions(+), 54 deletions(-) diff --git a/dri

[PATCH 4/6] input/vmmouse: Use vmware_hypercall API

2023-11-22 Thread Alexey Makhalov
Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. Eliminate arch specific code. No functional changes intended. Signed-off-by: Alexey Makhalov --- drivers/input/mouse/vmmouse.c | 76 ++- 1 file changed, 22 insertions(+), 54 deletions(-) diff --git a/dri

[PATCH 2/6] x86/vmware: Introduce vmware_hypercall API

2023-11-22 Thread Alexey Makhalov
Introducing vmware_hypercall family of functions as a common implementation to be used by the VMware guest code and virtual device drivers in arhitecture independent manner. By analogy with KVM hypercall API, vmware_hypercallX and vmware_hypercall_hb_{out,in} set of functions was added to achieve

[PATCH 5/6] drm/vmwgfx: Use vmware_hypercall API

2023-11-22 Thread Alexey Makhalov
Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. Eliminate arch specific code. drivers/gpu/drm/vmwgfx/vmwgfx_msg_arm64.h: implement arm64 variant of vmware_hypercall here. To be moved to arch/arm64/include/asm/vmware.h later. Signed-off-by: Alexey Makhalov --- drivers/gpu/drm/vmwgfx/

[PATCH 0/6] VMware hypercalls enhancements

2023-11-22 Thread Alexey Makhalov
VMware hypercalls invocations were all spread out across the kernel implementing same ABI as in-place asm-inline. With encrypted memory and confidential computing it became harder to maintain every changes in these hypercall implementations. Intention of this patchset is to introduce arch independ

[PATCH 3/6] ptp/vmware: Use vmware_hypercall API

2023-11-22 Thread Alexey Makhalov
Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. Eliminate arch specific code. No functional changes intended. Signed-off-by: Alexey Makhalov --- drivers/ptp/ptp_vmw.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/ptp/ptp_vmw.c b/drivers/ptp/

Re: drm scheduler redesign causes deadlocks [extended repost]

2023-11-22 Thread Luben Tuikov
On 2023-11-21 04:00, Bert Karwatzki wrote: > Since linux-next-20231115 my linux system (debian sid on msi alpha 15 laptop) > suffers from random deadlocks which can occur after  30 - 180min of usage. > These > deadlocks can be actively provoked by creating high system load (usually by > compiling

Re: [PATCH v3] drm/i915/vma: Fix VMA UAF on destroy against deactivate race

2023-11-22 Thread Andi Shyti
Hi Janusz, this patch is conflicting now with: 5e4e06e4087e ("drm/i915: Track gt pm wakerefs") from Andrzej. I have fixed the conflict and if you want I can send it. But I thought you might want to check it yourself, first. Andi On Thu, Nov 16, 2023 at 03:07:20PM +0100, Janusz Krzysztofik wr

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-22 Thread Luben Tuikov
On 2023-11-22 07:00, Maxime Ripard wrote: > Hi Luben, > > On Thu, Nov 16, 2023 at 09:27:58AM +0100, Daniel Vetter wrote: >> On Thu, Nov 16, 2023 at 09:11:43AM +0100, Maxime Ripard wrote: >>> On Tue, Nov 14, 2023 at 06:46:21PM -0500, Luben Tuikov wrote: On 2023-11-13 22:08, Stephen Rothwell wr

Re: [PATCH v18 24/26] drm/virtio: Attach shmem BOs dynamically

2023-11-22 Thread Dmitry Osipenko
On 11/23/23 01:37, Dmitry Osipenko wrote: > On 11/13/23 12:57, Boris Brezillon wrote: >> On Mon, 30 Oct 2023 02:02:03 +0300 >> Dmitry Osipenko wrote: >> >>> Prepare for addition of memory shrinker support by attaching shmem pages >>> to host dynamically on first use. Previously the attachment vq c

Re: [PATCH v18 24/26] drm/virtio: Attach shmem BOs dynamically

2023-11-22 Thread Dmitry Osipenko
On 11/13/23 12:57, Boris Brezillon wrote: > On Mon, 30 Oct 2023 02:02:03 +0300 > Dmitry Osipenko wrote: > >> Prepare for addition of memory shrinker support by attaching shmem pages >> to host dynamically on first use. Previously the attachment vq command >> wasn't fenced and there was no vq kick

Re: [PATCH] drm/rockchip: rk3066_hdmi: include drm/drm_atomic.h

2023-11-22 Thread Randy Dunlap
On 11/22/23 14:18, Arnd Bergmann wrote: > From: Arnd Bergmann > > Without this header, the newly added code fails to build: > > drivers/gpu/drm/rockchip/rk3066_hdmi.c: In function > 'rk3066_hdmi_encoder_enable': > drivers/gpu/drm/rockchip/rk3066_hdmi.c:397:22: error: implicit declaration of

Re: [PATCH v18 22/26] drm/shmem-helper: Don't free refcounted GEM

2023-11-22 Thread Dmitry Osipenko
On 11/13/23 12:54, Boris Brezillon wrote: > On Mon, 30 Oct 2023 02:02:01 +0300 > Dmitry Osipenko wrote: > >> Don't free refcounted shmem object to prevent use-after-free bug that >> is worse than a memory leak. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/gpu/drm/drm_gem_shmem_helper.

[PATCH] drm/rockchip: rk3066_hdmi: include drm/drm_atomic.h

2023-11-22 Thread Arnd Bergmann
From: Arnd Bergmann Without this header, the newly added code fails to build: drivers/gpu/drm/rockchip/rk3066_hdmi.c: In function 'rk3066_hdmi_encoder_enable': drivers/gpu/drm/rockchip/rk3066_hdmi.c:397:22: error: implicit declaration of function 'drm_atomic_get_new_connector_state'; did you m

[PATCH] drm/amd/display: avoid stringop-overflow warnings for dp_decide_lane_settings()

2023-11-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc prints a warning about a possible array overflow for a couple of callers of dp_decide_lane_settings() after commit 1b56c90018f0 ("Makefile: Enable -Wstringop-overflow globally"): drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_training_fixed_vs_pe_retimer.

Re: [PATCH v18 15/26] drm/panfrost: Explicitly get and put drm-shmem pages

2023-11-22 Thread Dmitry Osipenko
On 11/10/23 13:53, Boris Brezillon wrote: > Hm, there was no drm_gem_shmem_get_pages_sgt() call here, why should we > add a drm_gem_shmem_get_pages()? What we should do instead is add a > drm_gem_shmem_get_pages() for each drm_gem_shmem_get_pages_sgt() we > have in the driver (in panfrost_mmu_map()

[PATCH v2 1/1] drm/i915/pxp: Add missing tag for Wa_14019159160

2023-11-22 Thread Alan Previn
Add missing tag for "Wa_14019159160 - Case 2" (for existing PXP code that ensures run alone mode bit is set to allow PxP-decryption. v2: - Fix WA id number (John Harrison). - Improve comments and code to be specific for the targetted platforms (John Harrison) Signed-off-by: Alan Prev

Re: [PATCH v9 0/4] drm: Add support for atomic async page-flip

2023-11-22 Thread André Almeida
Hi Hamza, Em 22/11/2023 17:23, Hamza Mahfooz escreveu: Hi André, On 11/22/23 11:19, André Almeida wrote: Hi, This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC through the atomic API. This feature is already available via the legacy API. The use case is to be able to pres

Re: [PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine

2023-11-22 Thread Konrad Dybcio
On 10/16/23 16:32, Dmitry Baryshkov wrote: On 26/09/2023 23:03, Konrad Dybcio wrote: On 26.09.2023 21:10, Danila Tikhonov wrote: I think you mean by name downstream dt - sdmmagpie-gpu.dtsi You can see the forked version of the mainline here: https://github.com/sm7150-mainline/linux/blob/ne

Re: [PATCH 1/3] riscv: Add support for kernel-mode FPU

2023-11-22 Thread kernel test robot
Hi Samuel, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.7-rc2 next-20231122] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v9 0/4] drm: Add support for atomic async page-flip

2023-11-22 Thread Hamza Mahfooz
Hi André, On 11/22/23 11:19, André Almeida wrote: Hi, This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC through the atomic API. This feature is already available via the legacy API. The use case is to be able to present a new frame immediately (or as soon as possible), even i

Re: [PATCH -next] drm/nouveau/fifo: Remove duplicated include in chan.c

2023-11-22 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push upstream in a moment On Wed, 2023-11-22 at 08:49 +0800, Yang Li wrote: > ./drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c: chid.h is included more > than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7603 > Signe

Re: [PATCH v9 00/20] Imagination Technologies PowerVR DRM driver

2023-11-22 Thread Maxime Ripard
Hi, On Wed, Nov 22, 2023 at 04:34:21PM +, Donald Robson wrote: > This patch series adds the initial DRM driver for Imagination Technologies > PowerVR > GPUs, starting with those based on our Rogue architecture. It's worth pointing > out that this is a new driver, written from the ground up, r

Re: [PATCH v2 2/4] drm/prime: Helper to export dmabuf without fd

2023-11-22 Thread Felix Kuehling
On 2023-11-22 05:32, Thomas Zimmermann wrote: Hi, my apologies if this sounds picky or annoying. This change appears to be going in the wrong direction. The goal of the refactoring is to be able to use drm_driver.gem_prime_import and drm_gem_object_funcs.export for the additional import/export

[PATCH v5] drm/i915/pxp: Add drm_dbgs for critical PXP events.

2023-11-22 Thread Alan Previn
Debugging PXP issues can't even begin without understanding precedding sequence of important events. Add drm_dbg into the most important PXP events. v5 : - rebase. v4 : - rebase. v3 : - move gt_dbg to after mutex block in function i915_gsc_proxy_component_bind. (Vivaik) v2 : - remove _

Re: [PATCH v2 09/12] dt-bindings: soc: vop2: Add more endpoint definition

2023-11-22 Thread Krzysztof Kozlowski
On 22/11/2023 13:55, Andy Yan wrote: > From: Andy Yan > > There are 2 HDMI, 2 DP, 2 eDP on rk3588, so add > corresponding endpoint definition for it. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com

Re: [PATCH v2 08/12] dt-bindings: display: vop2: Add rk3588 support

2023-11-22 Thread Krzysztof Kozlowski
On 22/11/2023 13:55, Andy Yan wrote: > From: Andy Yan > > The vop2 on rk3588 is similar to which on rk356x > but with 4 video ports and need to reference > more grf modules. > > Signed-off-by: Andy Yan > > --- > > Changes in v2: > - fix errors when running 'make DT_CHECKER_FLAGS=-m dt_binding

Re: [PATCH] dma-buf: Correct the documentation of name and exp_name symbols

2023-11-22 Thread Christian König
Am 22.11.23 um 17:05 schrieb Ramesh Errabolu: Fix the documentation of struct dma_buf members name and exp_name as to how these members are to be used and accessed. Signed-off-by: Ramesh Errabolu Reviewed-by: Christian König --- include/linux/dma-buf.h | 11 +++ 1 file changed,

Re: Implement per-key keyboard backlight as auxdisplay?

2023-11-22 Thread Hans de Goede
Hi Werner, On 11/21/23 14:29, Werner Sembach wrote: > > Am 21.11.23 um 13:20 schrieb Hans de Goede: >> Hi Werner, >> >> On 11/21/23 12:33, Werner Sembach wrote: >>> Hi, >>> >>> Am 20.11.23 um 21:52 schrieb Pavel Machek: Hi! >>> So... a bit of rationale. The keyboard does not really

Re: [PATCH v6 0/6] drm: simplify support for transparent DRM bridges

2023-11-22 Thread Dmitry Baryshkov
On Wed, 22 Nov 2023 at 18:03, Sui Jingfeng wrote: > > Hi, > > > On 2023/11/4 07:03, Dmitry Baryshkov wrote: > > Supporting DP/USB-C can result in a chain of several transparent > > bridges (PHY, redrivers, mux, etc). All attempts to implement DP support > > in a different way resulted either in se

Re: [PATCH 04/14] drm/i915: Include

2023-11-22 Thread Jani Nikula
On Wed, 22 Nov 2023, Thomas Zimmermann wrote: > One of the source files includes via , > which will be removed. Include drm_auth.h directly. > > Signed-off-by: Thomas Zimmermann > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: intel-...@lists.freedesktop.

Re: [v6,1/6] drm/bridge: add transparent bridge helper

2023-11-22 Thread Sui Jingfeng
Hi, On 2023/11/4 07:03, Dmitry Baryshkov wrote: Define a helper for creating simple transparent bridges which serve the only purpose of linking devices into the bridge chain up to the last bridge representing the connector. As far as I can tell, traditionally, transparent display bridges are

[PATCH v9 20/20] drm/imagination: Add driver documentation

2023-11-22 Thread Donald Robson
From: Sarah Walker Add documentation for the UAPI. Changes since v5: - Remove obsolete VM documentation Co-developed-by: Matt Coster Signed-off-by: Matt Coster Co-developed-by: Donald Robson Signed-off-by: Donald Robson Signed-off-by: Sarah Walker Reviewed-by: Maxime Ripard --- Documenta

[PATCH v9 19/20] drm/imagination: Add firmware trace to debugfs

2023-11-22 Thread Donald Robson
From: Sarah Walker Firmware trace is exposed at /sys/debug/dri//pvr_fw/trace_0. Trace is enabled via the group mask at /sys/debug/dri//pvr_params/fw_trace_mask. Changes since v8: - Corrected license identifiers Changes since v3: - Use drm_dev_{enter,exit} Co-developed-by: Matt Coster Signed-o

[PATCH v9 18/20] drm/imagination: Add firmware trace header

2023-11-22 Thread Donald Robson
From: Sarah Walker Changes since v8: - Corrected license identifiers Changes since v5: - Split up header commit due to size Signed-off-by: Sarah Walker Signed-off-by: Donald Robson --- .../gpu/drm/imagination/pvr_rogue_fwif_sf.h | 1648 + 1 file changed, 1648 insertions(+)

[PATCH v9 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU

2023-11-22 Thread Donald Robson
From: Sarah Walker Add the device tree binding documentation for the IMG AXE GPU used in TI AM62 SoCs. Co-developed-by: Frank Binns Signed-off-by: Frank Binns Signed-off-by: Sarah Walker Signed-off-by: Donald Robson Reviewed-by: Maxime Ripard Reviewed-by: Linus Walleij Reviewed-by: Conor D

[PATCH v9 05/20] drm/imagination: Add skeleton PowerVR driver

2023-11-22 Thread Donald Robson
From: Sarah Walker This adds the basic skeleton of the driver. The driver registers itself with DRM on probe. Ioctl handlers are currently implemented as stubs. Changes since v8: - Corrected license identifiers Changes since v5: - Update compatible string & description to match marketing name -

[PATCH v9 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-11-22 Thread Donald Robson
From: Sarah Walker Add the UAPI implementation for the PowerVR driver. Changes from v8: - Fixed documentation for unmapping, which previously suggested the size was not used - Corrected license identifier Changes from v7: - Remove prefixes from DRM_PVR_BO_* flags - Improve struct drm_pvr_ioct

[PATCH v9 17/20] drm/imagination: Implement job submission and scheduling

2023-11-22 Thread Donald Robson
From: Sarah Walker Implement job submission ioctl. Job scheduling is implemented using drm_sched. Jobs are submitted in a stream format. This is intended to allow the UAPI data format to be independent of the actual FWIF structures in use, which vary depending on the GPU in use. The stream form

[PATCH v9 06/20] drm/imagination: Get GPU resources

2023-11-22 Thread Donald Robson
From: Sarah Walker Acquire clock and register resources, and enable/map as appropriate. Changes since v8: - Corrected license identifiers Changes since v3: - Remove regulator resource (not used on supported platform) - Use devm helpers - Use devm_clk_get_optional() for optional clocks - Don't p

[PATCH v9 14/20] drm/imagination: Implement MIPS firmware processor and MMU support

2023-11-22 Thread Donald Robson
From: Sarah Walker Add support for the MIPS firmware processor, used in the Series AXE GPU. The MIPS firmware processor uses a separate MMU to the rest of the GPU, so this patch adds support for that as well. Changes since v8: - Corrected license identifiers Changes since v6: - Fix integer over

[PATCH v9 01/20] sizes.h: Add entries between SZ_32G and SZ_64T

2023-11-22 Thread Donald Robson
From: Matt Coster sizes.h has a gap in defines between SZ_32G and SZ_64T. Add the missing defines so they can be used in drivers. Signed-off-by: Matt Coster Signed-off-by: Sarah Walker Signed-off-by: Donald Robson Reviewed-by: Linus Walleij --- include/linux/sizes.h | 9 + 1 file ch

Re: [PATCH v2 0/8] dma-buf: heaps: Add secure heap

2023-11-22 Thread Pratyush Brahma
Hi We have sent a patch series at [1] using this series to add support for Qualcomm secure heaps. Instead of TEE calls, it uses qcom_scm_assign_mem() to secure the memory. Thanks, Pratyush [1] https://lore.kernel.org/lkml/cover.1700544802.git.quic_vji...@quicinc.com/

[PATCH v9 13/20] drm/imagination: Implement firmware infrastructure and META FW support

2023-11-22 Thread Donald Robson
From: Sarah Walker The infrastructure includes parsing of the firmware image, initialising FW-side structures, handling the kernel and firmware command ringbuffers and starting & stopping the firmware processor. This patch also adds the necessary support code for the META firmware processor. Ch

[PATCH v9 15/20] drm/imagination: Implement free list and HWRT create and destroy ioctls

2023-11-22 Thread Donald Robson
From: Sarah Walker Implement ioctls to create and destroy free lists and HWRT datasets. Free lists are used for GPU-side memory allocation during geometry processing. HWRT datasets are the FW-side structures representing render targets. Changes since v8: - Corrected license identifiers Changes

[PATCH v9 10/20] drm/imagination: Add GPU ID parsing and firmware loading

2023-11-22 Thread Donald Robson
From: Sarah Walker Read the GPU ID register at probe time and select the correct features/quirks/enhancements. Use the GPU ID to form the firmware file name and load the firmware. The features/quirks/enhancements arrays are currently hardcoded in the driver for the supported GPUs. We are looking

[PATCH v9 16/20] drm/imagination: Implement context creation/destruction ioctls

2023-11-22 Thread Donald Robson
From: Sarah Walker Implement ioctls for the creation and destruction of contexts. Contexts are used for job submission and each is associated with a particular job type. Changes since v8: - Fixed one error path in pvr_stream_process_1() - Corrected license identifiers Changes since v5: - Fix co

[PATCH v9 12/20] drm/imagination: Implement power management

2023-11-22 Thread Donald Robson
From: Sarah Walker Add power management to the driver, using runtime pm. The power off sequence depends on firmware commands which are not implemented in this patch. Changes since v8: - Corrected license identifiers Changes since v5: - Use RUNTIME_PM_OPS() to declare PM callbacks - Add Kconfig

[PATCH v9 08/20] drm/imagination: Add firmware and MMU related headers

2023-11-22 Thread Donald Robson
From: Sarah Walker Changes since v8: - Corrected license identifiers Changes since v5: - Split up header commit due to size Signed-off-by: Sarah Walker Signed-off-by: Donald Robson Acked-by: Maxime Ripard --- .../drm/imagination/pvr_rogue_heap_config.h | 113 ++ drivers/gpu/drm/imagin

[PATCH v9 02/20] drm/gpuvm: Helper to get range of unmap from a remap op.

2023-11-22 Thread Donald Robson
Determining the start and range of the unmap stage of a remap op is a common piece of code currently implemented by multiple drivers. Add a helper for this. Changes since v7: - Renamed helper to drm_gpuva_op_remap_to_unmap_range() - Improved documentation Changes since v6: - Remove use of __alway

[PATCH v9 00/20] Imagination Technologies PowerVR DRM driver

2023-11-22 Thread Donald Robson
This patch series adds the initial DRM driver for Imagination Technologies PowerVR GPUs, starting with those based on our Rogue architecture. It's worth pointing out that this is a new driver, written from the ground up, rather than a refactored version of our existing downstream driver (pvrsrvkm)

[PATCH v9 4/4] drm/doc: Define KMS atomic state set

2023-11-22 Thread André Almeida
From: Pekka Paalanen Specify how the atomic state is maintained between userspace and kernel, plus the special case for async flips. Signed-off-by: Pekka Paalanen Signed-off-by: André Almeida --- v9: - no changes v8: - no changes v7: - add a note that drivers can make exceptions for ad-hoc pro

[PATCH v9 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2023-11-22 Thread André Almeida
From: Simon Ser This new kernel capability indicates whether async page-flips are supported via the atomic uAPI. DRM clients can use it to check for support before feeding DRM_MODE_PAGE_FLIP_ASYNC to the kernel. Make it clear that DRM_CAP_ASYNC_PAGE_FLIP is for legacy uAPI only. Signed-off-by:

[PATCH v9 2/4] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits

2023-11-22 Thread André Almeida
From: Simon Ser If the driver supports it, allow user-space to supply the DRM_MODE_PAGE_FLIP_ASYNC flag to request an async page-flip. Set drm_crtc_state.async_flip accordingly. Document that drivers will reject atomic commits if an async flip isn't possible. This allows user-space to fall back

[PATCH v9 1/4] drm: Refuse to async flip with atomic prop changes

2023-11-22 Thread André Almeida
Given that prop changes may lead to modesetting, which would defeat the fast path of the async flip, refuse any atomic prop change for async flips in atomic API. The only exception is the framebuffer ID to flip to. Currently the only plane type supported is the primary one. Signed-off-by: André Al

[PATCH v9 0/4] drm: Add support for atomic async page-flip

2023-11-22 Thread André Almeida
Hi, This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC through the atomic API. This feature is already available via the legacy API. The use case is to be able to present a new frame immediately (or as soon as possible), even if after missing a vblank. This might result in teari

Re: [PATCH] drm/msm/a690: Fix reg values for a690

2023-11-22 Thread Konrad Dybcio
On 11/21/23 17:21, Rob Clark wrote: From: Danylo Piliaiev KGSL doesn't support a690 so all reg values were the same as on a660. Now we know the values and they are different from the windows driver. This fixes hangs on D3D12 games and some CTS tests. Signed-off-by: Danylo Piliaiev Signed-

[PATCH] dma-buf: Correct the documentation of name and exp_name symbols

2023-11-22 Thread Ramesh Errabolu
Fix the documentation of struct dma_buf members name and exp_name as to how these members are to be used and accessed. Signed-off-by: Ramesh Errabolu --- include/linux/dma-buf.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/linux/dma-buf.h b/include/linu

Re: [PATCH v6 0/6] drm: simplify support for transparent DRM bridges

2023-11-22 Thread Sui Jingfeng
Hi, On 2023/11/4 07:03, Dmitry Baryshkov wrote: Supporting DP/USB-C can result in a chain of several transparent bridges (PHY, redrivers, mux, etc). All attempts to implement DP support in a different way resulted either in series of hacks or in device tree not reflecting the actual hardware de

[drm-intel:for-linux-next-gt 1/6] drivers/gpu/drm/i915/i915_drm_client.h:81:1: error: non-void function does not return a value

2023-11-22 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-gt head: 5032c607e886e0c40749a05d37b835c1757d38ff commit: e4ae85e364fc652ea15d85b0f3a6da304c9b5ce7 [1/6] drm/i915: Add ability for tracking buffer objects per client config: x86_64-buildonly-randconfig-006-20231122 (https

[PATCH AUTOSEL 4.14 3/3] drm/amdgpu: correct chunk_ptr to a pointer to chunk.

2023-11-22 Thread Sasha Levin
From: YuanShang [ Upstream commit 50d51374b498457c4dea26779d32ccfed12ddaff ] The variable "chunk_ptr" should be a pointer pointing to a struct drm_amdgpu_cs_chunk instead of to a pointer of that. Signed-off-by: YuanShang Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by:

[PATCH AUTOSEL 4.19 6/6] drm/amdgpu: correct chunk_ptr to a pointer to chunk.

2023-11-22 Thread Sasha Levin
From: YuanShang [ Upstream commit 50d51374b498457c4dea26779d32ccfed12ddaff ] The variable "chunk_ptr" should be a pointer pointing to a struct drm_amdgpu_cs_chunk instead of to a pointer of that. Signed-off-by: YuanShang Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by:

[PATCH AUTOSEL 5.4 6/6] drm/amdgpu: correct chunk_ptr to a pointer to chunk.

2023-11-22 Thread Sasha Levin
From: YuanShang [ Upstream commit 50d51374b498457c4dea26779d32ccfed12ddaff ] The variable "chunk_ptr" should be a pointer pointing to a struct drm_amdgpu_cs_chunk instead of to a pointer of that. Signed-off-by: YuanShang Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by:

[PATCH AUTOSEL 5.10 7/7] drm/amdgpu: correct chunk_ptr to a pointer to chunk.

2023-11-22 Thread Sasha Levin
From: YuanShang [ Upstream commit 50d51374b498457c4dea26779d32ccfed12ddaff ] The variable "chunk_ptr" should be a pointer pointing to a struct drm_amdgpu_cs_chunk instead of to a pointer of that. Signed-off-by: YuanShang Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by:

[PATCH AUTOSEL 5.15 7/7] drm/amdgpu: correct chunk_ptr to a pointer to chunk.

2023-11-22 Thread Sasha Levin
From: YuanShang [ Upstream commit 50d51374b498457c4dea26779d32ccfed12ddaff ] The variable "chunk_ptr" should be a pointer pointing to a struct drm_amdgpu_cs_chunk instead of to a pointer of that. Signed-off-by: YuanShang Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by:

[PATCH AUTOSEL 6.1 9/9] drm/amdgpu: correct chunk_ptr to a pointer to chunk.

2023-11-22 Thread Sasha Levin
From: YuanShang [ Upstream commit 50d51374b498457c4dea26779d32ccfed12ddaff ] The variable "chunk_ptr" should be a pointer pointing to a struct drm_amdgpu_cs_chunk instead of to a pointer of that. Signed-off-by: YuanShang Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by:

[PATCH AUTOSEL 6.5 14/15] drm/amdgpu: correct chunk_ptr to a pointer to chunk.

2023-11-22 Thread Sasha Levin
From: YuanShang [ Upstream commit 50d51374b498457c4dea26779d32ccfed12ddaff ] The variable "chunk_ptr" should be a pointer pointing to a struct drm_amdgpu_cs_chunk instead of to a pointer of that. Signed-off-by: YuanShang Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by:

[PATCH AUTOSEL 6.5 13/15] drm/amdgpu: finalizing mem_partitions at the end of GMC v9 sw_fini

2023-11-22 Thread Sasha Levin
From: Le Ma [ Upstream commit bdb72185d310fc8049c7ea95221d640e9e7165e5 ] The valid num_mem_partitions is required during ttm pool fini, thus move the cleanup at the end of the function. Signed-off-by: Le Ma Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --

  1   2   >