Re: [net-next v1 09/16] page_pool: device memory support

2023-12-12 Thread Mina Almasry
On Sun, Dec 10, 2023 at 8:04 PM Mina Almasry wrote: > > On Sun, Dec 10, 2023 at 6:26 PM Mina Almasry wrote: > > > > On Sun, Dec 10, 2023 at 6:04 PM Yunsheng Lin wrote: > > > > > > On 2023/12/9 0:05, Mina Almasry wrote: > > > > On Fri, Dec 8, 2023 at 1:30 AM Yunsheng Lin > > > > wrote: > > >

Re: [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-12 Thread Uwe Kleine-König
Hello Maxime, On Wed, Dec 13, 2023 at 08:16:04AM +0100, Maxime Ripard wrote: > On Tue, Dec 12, 2023 at 06:26:37PM +0100, Uwe Kleine-König wrote: > > clk_rate_exclusive_get() returns zero unconditionally. Most users "know" > > that and don't check the return value. This series fixes the four users

Re: [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-12 Thread Maxime Ripard
Hi, On Tue, Dec 12, 2023 at 06:26:37PM +0100, Uwe Kleine-König wrote: > Hello, > > clk_rate_exclusive_get() returns zero unconditionally. Most users "know" > that and don't check the return value. This series fixes the four users > that do error checking on the returned value and then makes

Re: [PATCH v2] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread Krzysztof Kozlowski
On 12/12/2023 21:09, David Heidelberg wrote: > Originally was in the panel-simple, but belongs to panel-simple-dsi. > > See arch/arm/boot/dts/nvidia/tegra114-roth.dts for more details. > > Resolves the following warning: > ``` > arch/arm/boot/dts/tegra114-roth.dt.yaml: panel@0: 'reg' does not

[PATCH] drm/uapi: drm_mode.h: fix spellos and grammar

2023-12-12 Thread Randy Dunlap
Correct spellos reported by codespell. Fix some grammar (as 's' to a few words). Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/uapi/drm/drm_mode.h | 18 +- 1 file changed, 9

[PATCH] drm/i915/uapi: fix typos/spellos and punctuation

2023-12-12 Thread Randy Dunlap
Use "its" for possessive form instead of "it's". Hyphenate multi-word adjectives. Correct some spelling. End one line of code with ';' instead of ','. The before and after object files are identical. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko

[PATCH] drm/fourcc: fix spelling/typos

2023-12-12 Thread Randy Dunlap
Correct spelling mistakes that were identified by codespell. Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/uapi/drm/drm_fourcc.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[PATCH] iosys-map: fix typos

2023-12-12 Thread Randy Dunlap
Correct spellos/typos in comments. Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- include/linux/iosys-map.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/include/linux/iosys-map.h b/include/linux/iosys-map.h ---

[PATCH] drm/drm_modeset_helper_vtables.h: fix typos/spellos

2023-12-12 Thread Randy Dunlap
Fix spelling problems as identified by codespell. Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann --- include/drm/drm_modeset_helper_vtables.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [Freedreno] [PATCH 0/2] drm/msm/dpu: INTF CRC configuration cleanups and fix

2023-12-12 Thread Jessica Zhang
On 11/30/2023 11:39 PM, Dmitry Baryshkov wrote: On Fri, 1 Dec 2023 at 03:31, Jessica Zhang wrote: This series drops the frame_count and enable parameters (as they're always set to the same value). It also sets input_sel=0x1 for INTF. Signed-off-by: Jessica Zhang --- Jessica Zhang (2):

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread David Ahern
On 12/12/23 6:09 PM, Mina Almasry wrote: > OK, I imagine this is not that hard to implement - it's really whether > the change is acceptable to reviewers. > > I figure I can start by implementing a no-op abstraction to page*: > > typedef struct page netmem_t > > and replace the page* in the

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-12 Thread Keith Zhao
On 2023/12/11 20:13, Andy Yan wrote: > Hi Keith: > > 在 2023-12-11 18:24:35,"Keith Zhao" 写道: >>hi Maxime: >>hi Andy: >> >>On 2023/12/8 17:14, Maxime Ripard wrote: >>> Hi, >>> >>> On Fri, Dec 08, 2023 at 11:23:37AM +0800, Andy Yan wrote: 在 2023-12-08 11:00:31,"Keith Zhao" 写道: >

Re: [PATCH v2] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread Jessica Zhang
On 12/12/2023 12:09 PM, David Heidelberg wrote: Originally was in the panel-simple, but belongs to panel-simple-dsi. See arch/arm/boot/dts/nvidia/tegra114-roth.dts for more details. Resolves the following warning: ``` arch/arm/boot/dts/tegra114-roth.dt.yaml: panel@0: 'reg' does not match

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread Mina Almasry
On Tue, Dec 12, 2023 at 7:08 AM Jason Gunthorpe wrote: > > On Tue, Dec 12, 2023 at 06:58:17AM -0800, Mina Almasry wrote: > > > Jason, we set the LSB on page_pool_iov pointers before casting it to > > struct page pointers. The resulting pointers are not useable as page > > pointers at all. > > I

Re: [PATCH] drm/msm/dpu: move CSC tables to dpu_hw_util.c

2023-12-12 Thread Dmitry Baryshkov
On Wed, 13 Dec 2023 at 02:59, Abhinav Kumar wrote: > > > > On 12/12/2023 4:57 PM, Dmitry Baryshkov wrote: > > Move CSC tables out of the header file to fix following kind of warnings: > > > > In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h:8, > > from

Re: [PATCH] drm/msm/dpu: move CSC tables to dpu_hw_util.c

2023-12-12 Thread Abhinav Kumar
On 12/12/2023 4:57 PM, Dmitry Baryshkov wrote: Move CSC tables out of the header file to fix following kind of warnings: In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h:8, from drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:5:

linux-next: manual merge of the fbdev tree with the drm tree

2023-12-12 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the fbdev tree got a conflict in: drivers/video/fbdev/vermilion/vermilion.c between commit: 76f92201b821 ("fbdev: Push pgprot_decrypted() into mmap implementations") from the drm tree and commit: d8a47ee16884 ("fbdev: Remove support for Carillo Ranch

[PATCH] drm/msm/dpu: move CSC tables to dpu_hw_util.c

2023-12-12 Thread Dmitry Baryshkov
Move CSC tables out of the header file to fix following kind of warnings: In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_hwio.h:8, from drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c:5: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h:54:33: warning: ‘dpu_csc10_rgb2yuv_601l’

linux-next: manual merge of the fbdev tree with the drm tree

2023-12-12 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the fbdev tree got a conflict in: drivers/video/fbdev/amba-clcd.c between commit: 76f92201b821 ("fbdev: Push pgprot_decrypted() into mmap implementations") from the drm tree and commit: 13366c25125e ("fbdev: amba-clcd: Delete the old CLCD driver")

Re: [PATCH v4 0/1] Stabilize use of vblank_refcount

2023-12-12 Thread Dmitry Baryshkov
On Tue, 12 Dec 2023 15:10:57 -0800, Paloma Arellano wrote: > There is currently a race condition occuring when accessing > vblank_refcount. Therefore, vblank irq timeouts may occur. > > Avoid any vblank irq timeouts by stablizing the use of vblank_refcount. > > Changes from prior versions: >

Re: [PATCH v2 0/3] drm/msm/dpu: enable writeback on several platforms

2023-12-12 Thread Dmitry Baryshkov
On Sun, 03 Dec 2023 03:27:40 +0300, Dmitry Baryshkov wrote: > This enables writeback on several platforms where I could actually test > it. > > Changes since v1: > - Fixed the CLK_CTRL for SDM845 platform. > > Dmitry Baryshkov (3): > drm/msm/dpu: enable writeback on SDM845 > drm/msm/dpu:

Re: [PATCH v4 00/15] Add CDM support for MSM writeback

2023-12-12 Thread Dmitry Baryshkov
On Tue, 12 Dec 2023 12:52:38 -0800, Abhinav Kumar wrote: > Chroma Down Sampling (CDM) block is a hardware block in the DPU pipeline > which among other things has a CSC block that can convert RGB input > from the DPU to YUV data. > > This block can be used with either HDMI, DP or writeback

Re: [PATCH RESEND v2 0/3] drm: introduce per-encoder debugfs directory

2023-12-12 Thread Dmitry Baryshkov
On Sun, 03 Dec 2023 14:53:12 +0300, Dmitry Baryshkov wrote: > Resending, patch 1 needs review from DRM core maintainers, but it got no > attention since October. > > Each of connectors and CRTCs used by the DRM device provides debugfs > directory, which is used by several standard debugfs files

Re: [PATCH] drm/msm/dpu: Ratelimit framedone timeout msgs

2023-12-12 Thread Dmitry Baryshkov
On Mon, 11 Dec 2023 10:19:55 -0800, Rob Clark wrote: > When we start getting these, we get a *lot*. So ratelimit it to not > flood dmesg. > > Applied, thanks! [1/1] drm/msm/dpu: Ratelimit framedone timeout msgs https://gitlab.freedesktop.org/lumag/msm/-/commit/e37cb117b819 Best

Re: [PATCH 0/9] arm64: dts: qcom: sm8150-hdk: enable display output

2023-12-12 Thread Dmitry Baryshkov
On Sun, 10 Dec 2023 02:21:23 +0300, Dmitry Baryshkov wrote: > Enable display output on the SM8150 HDK device. This includes HDMI > output through the onboard DSI-HDMI bridge and DP output on the USB-C > port. > > Dmitry Baryshkov (9): > dt-bindings: display: msm: dp: declare compatible string

Re: [PATCH] drm/msm/dpu: remove extra drm_encoder_cleanup from the error path

2023-12-12 Thread Dmitry Baryshkov
On Mon, 11 Dec 2023 17:54:40 +0300, Dmitry Baryshkov wrote: > The drmm handler will perform drm_encoder_cleanup() for us. Moreover if > we call drm_encoder_cleanup() manually, the drmm_encoder_alloc_release() > will spawn warnings at drivers/gpu/drm/drm_encoder.c:214. Drop these > extra

Re: [PATCH v4 1/1] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-12 Thread Dmitry Baryshkov
On Wed, 13 Dec 2023 at 01:11, Paloma Arellano wrote: > > Add a mutex lock to control vblank irq to synchronize vblank > enable/disable operations happening from different threads to prevent > race conditions while registering/unregistering the vblank irq callback. > > v4: -Removed vblank_ctl_lock

[PATCH v4 1/1] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-12 Thread Paloma Arellano
Add a mutex lock to control vblank irq to synchronize vblank enable/disable operations happening from different threads to prevent race conditions while registering/unregistering the vblank irq callback. v4: -Removed vblank_ctl_lock from dpu_encoder_virt, so it is only a parameter of

[PATCH v4 0/1] Stabilize use of vblank_refcount

2023-12-12 Thread Paloma Arellano
There is currently a race condition occuring when accessing vblank_refcount. Therefore, vblank irq timeouts may occur. Avoid any vblank irq timeouts by stablizing the use of vblank_refcount. Changes from prior versions: v4: - Removed vblank_ctl_lock from dpu_encoder_virt, so it is only a

Re: nouveau 0000:01:00.0: drm_WARN_ON(!found_head)

2023-12-12 Thread Borislav Petkov
On Sat, Nov 11, 2023 at 01:03:23PM +0100, Borislav Petkov wrote: > Hi, > > this is ontop of Linus' tree from the 4th (lemme know if I should try > the latest) on one of my test boxes: > > nouveau :01:00.0: vgaarb: deactivate vga console > Console: switching to colour dummy device 80x25 >

Re: [PATCH v4 01/15] drm/msm/dpu: add formats check for writeback encoder

2023-12-12 Thread Abhinav Kumar
On 12/12/2023 2:03 PM, Dmitry Baryshkov wrote: On Tue, 12 Dec 2023 at 23:30, Dmitry Baryshkov wrote: On Tue, 12 Dec 2023 at 22:53, Abhinav Kumar wrote: In preparation for adding more formats to dpu writeback add format validation to it to fail any unsupported formats. changes in v4:

Re: [PATCH v4 01/15] drm/msm/dpu: add formats check for writeback encoder

2023-12-12 Thread Dmitry Baryshkov
On Tue, 12 Dec 2023 at 23:30, Dmitry Baryshkov wrote: > > On Tue, 12 Dec 2023 at 22:53, Abhinav Kumar wrote: > > > > In preparation for adding more formats to dpu writeback add > > format validation to it to fail any unsupported formats. > > > > changes in v4: > > - change the failure

Re: [PATCH v4] drm/msm/dpu: improve DSC allocation

2023-12-12 Thread Dmitry Baryshkov
On Tue, 12 Dec 2023 at 23:37, Kuogee Hsieh wrote: > > At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. > However, at DSC V1.2 DCE consists of two DSC encoders, one has an odd > index and another one has an even index. Each encoder can work > independently. But only two DSC

Re: [PATCH] drm/tegra: include drm/drm_edid.h only where needed

2023-12-12 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.7-rc5 next-20231212

Re: [PATCH v4 07/15] drm/msm/dpu: add dpu_hw_cdm abstraction for CDM block

2023-12-12 Thread Dmitry Baryshkov
On Tue, 12 Dec 2023 at 22:53, Abhinav Kumar wrote: > > CDM block comes with its own set of registers and operations > which can be done. In-line with other hardware blocks, this > change adds the dpu_hw_cdm abstraction for the CDM block. > > changes in v4: > - used FIELD_PREP() for

[PATCH v4] drm/msm/dpu: improve DSC allocation

2023-12-12 Thread Kuogee Hsieh
At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. However, at DSC V1.2 DCE consists of two DSC encoders, one has an odd index and another one has an even index. Each encoder can work independently. But only two DSC encoders from same DCE can be paired to work together to support

Re: [PATCH v3 01/15] drm/msm/dpu: add formats check for writeback encoder

2023-12-12 Thread Dmitry Baryshkov
On Tue, 12 Dec 2023 at 19:17, Abhinav Kumar wrote: > > > > On 12/11/2023 10:40 PM, Dmitry Baryshkov wrote: > > On Tue, 12 Dec 2023 at 02:23, Abhinav Kumar > > wrote: > >> > >> In preparation for adding more formats to dpu writeback add > >> format validation to it to fail any unsupported

Re: [PATCH v4 01/15] drm/msm/dpu: add formats check for writeback encoder

2023-12-12 Thread Dmitry Baryshkov
On Tue, 12 Dec 2023 at 22:53, Abhinav Kumar wrote: > > In preparation for adding more formats to dpu writeback add > format validation to it to fail any unsupported formats. > > changes in v4: > - change the failure message of the API >

Re: [PATCH v3 07/15] drm/msm/dpu: add dpu_hw_cdm abstraction for CDM block

2023-12-12 Thread Dmitry Baryshkov
On Tue, 12 Dec 2023 at 19:51, Abhinav Kumar wrote: > > > > On 12/12/2023 1:40 AM, Dmitry Baryshkov wrote: > > On Tue, 12 Dec 2023 at 02:23, Abhinav Kumar > > wrote: > >> > >> CDM block comes with its own set of registers and operations > >> which can be done. In-line with other hardware blocks,

Re: [PATCH v4 000/115] pwm: Fix lifetime issues for pwm_chips

2023-12-12 Thread Uwe Kleine-König
Hello Thierry, On Mon, Dec 11, 2023 at 12:33:04PM +0100, Thierry Reding wrote: > On Fri, Dec 08, 2023 at 07:50:33PM +0100, Uwe Kleine-König wrote: > > You don't need to touch all drivers because you didn't change struct > > pwm_chip::dev yet. (If you really want, you don't need to change that, >

Re: [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed

2023-12-12 Thread Andrew Halaney
On Tue, Dec 12, 2023 at 02:57:54PM -0500, Brian Masney wrote: > When the power domains cannot be parsed, the message is incorrectly > logged as an info message. Let's change this to an error since an error > is returned. > > Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic

[PATCH v4 13/15] drm/msm/dpu: reserve cdm blocks for writeback in case of YUV output

2023-12-12 Thread Abhinav Kumar
Reserve CDM blocks for writeback if the format of the output fb is YUV. At the moment, the reservation is done only for writeback but can easily be extended by relaxing the checks once other interfaces are ready to output YUV. changes in v3: - squash CDM disable during encoder cleanup

[PATCH v4 14/15] drm/msm/dpu: introduce separate wb2_format arrays for rgb and yuv

2023-12-12 Thread Abhinav Kumar
Lets rename the existing wb2_formats array wb2_formats_rgb to indicate that it has only RGB formats and can be used on any chipset having a WB block. Introduce a new wb2_formats_rgb_yuv array to the catalog to indicate support for YUV formats to writeback in addition to RGB. Chipsets which have

[PATCH v4 15/15] drm/msm/dpu: add cdm blocks to dpu snapshot

2023-12-12 Thread Abhinav Kumar
Now that CDM block support has been added to DPU lets also add its entry to the DPU snapshot to help debugging. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v4 11/15] drm/msm/dpu: add an API to setup the CDM block for writeback

2023-12-12 Thread Abhinav Kumar
Add an API dpu_encoder_helper_phys_setup_cdm() which can be used by the writeback encoder to setup the CDM block. Currently, this is defined and used within the writeback's physical encoder layer however, the function can be modified to be used to setup the CDM block even for non-writeback

[PATCH v4 12/15] drm/msm/dpu: plug-in the cdm related bits to writeback setup

2023-12-12 Thread Abhinav Kumar
To setup and enable CDM block for the writeback pipeline, lets add the pieces together to set the active bits and the flush bits for the CDM block. changes in v2: - passed the cdm idx to update_pending_flush_cdm() (have retained the R-b as its a minor change) Signed-off-by:

[PATCH v4 07/15] drm/msm/dpu: add dpu_hw_cdm abstraction for CDM block

2023-12-12 Thread Abhinav Kumar
CDM block comes with its own set of registers and operations which can be done. In-line with other hardware blocks, this change adds the dpu_hw_cdm abstraction for the CDM block. changes in v4: - used FIELD_PREP() for dpu_hw_cdm_setup_cdwn() operations - change to lowercase hex in

[PATCH v4 10/15] drm/msm/dpu: add CDM related logic to dpu_hw_ctl layer

2023-12-12 Thread Abhinav Kumar
CDM block will need its own logic to program the flush and active bits in the dpu_hw_ctl layer. Make necessary changes in dpu_hw_ctl to support CDM programming. changes in v3: - drop unused cdm_active as reported by kbot - retained the R-b as its a trivial change changes in v2:

[PATCH v4 08/15] drm/msm/dpu: add cdm blocks to RM

2023-12-12 Thread Abhinav Kumar
Add the RM APIs necessary to initialize and allocate CDM blocks to be used by the rest of the DPU pipeline. changes in v2: - treat cdm_init() failure as fatal - fixed the commit text Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov ---

[PATCH v4 06/15] drm/msm/dpu: add cdm blocks to sm8250 dpu_hw_catalog

2023-12-12 Thread Abhinav Kumar
Add CDM blocks to the sm8250 dpu_hw_catalog to support YUV format output from writeback block. changes in v2: - re-use the cdm definition from sc7280 Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_0_sm8250.h | 1 + 1 file

[PATCH v4 09/15] drm/msm/dpu: add support to allocate CDM from RM

2023-12-12 Thread Abhinav Kumar
Even though there is usually only one CDM block, it can be used by either HDMI, DisplayPort OR Writeback interfaces. Hence its allocation needs to be tracked properly by the resource manager to ensure appropriate availability of the block. changes in v2: - move needs_cdm to topology

[PATCH v4 05/15] drm/msm/dpu: add cdm blocks to sc7280 dpu_hw_catalog

2023-12-12 Thread Abhinav Kumar
Add CDM blocks to the sc7280 dpu_hw_catalog to support YUV format output from writeback block. changes in v3: - change the comment from sub-blk to clk for CDM changes in v2: - remove explicit zero assignment for features - move sc7280_cdm to dpu_hw_catalog from the sc7280

[PATCH v4 04/15] drm/msm/dpu: move csc matrices to dpu_hw_util

2023-12-12 Thread Abhinav Kumar
Since the type and usage of CSC matrices is spanning across DPU lets introduce a helper to the dpu_hw_util to return the CSC corresponding to the request type. This will help to add more supported CSC types such as the RGB to YUV one which is used in the case of CDM. changes in v3: - drop

[PATCH v4 02/15] drm/msm/dpu: rename dpu_encoder_phys_wb_setup_cdp to match its functionality

2023-12-12 Thread Abhinav Kumar
dpu_encoder_phys_wb_setup_cdp() is not programming the chroma down prefetch block. Its setting up the display ctl path for writeback. Hence rename it to dpu_encoder_phys_wb_setup_ctl() to match what its actually doing. Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for

[PATCH v4 03/15] drm/msm/dpu: fix writeback programming for YUV cases

2023-12-12 Thread Abhinav Kumar
For YUV cases, setting the required format bits was missed out in the register programming. Lets fix it now in preparation of adding YUV formats support for writeback. changes in v2: - dropped the fixes tag as its not a fix but adding new functionality Signed-off-by: Abhinav Kumar

[PATCH v4 01/15] drm/msm/dpu: add formats check for writeback encoder

2023-12-12 Thread Abhinav Kumar
In preparation for adding more formats to dpu writeback add format validation to it to fail any unsupported formats. changes in v4: - change the failure message of the API drm_atomic_helper_check_wb_connector_state() to a generic one in case it checks more errors later

[PATCH v4 00/15] Add CDM support for MSM writeback

2023-12-12 Thread Abhinav Kumar
Chroma Down Sampling (CDM) block is a hardware block in the DPU pipeline which among other things has a CSC block that can convert RGB input from the DPU to YUV data. This block can be used with either HDMI, DP or writeback interface. In this series, lets first add the support for CDM block to

Re: (subset) [PATCH v1 1/3] dt-bindings: drm: rockchip: convert inno_hdmi-rockchip.txt to yaml

2023-12-12 Thread Heiko Stuebner
On Mon, 4 Dec 2023 18:39:03 +0100, Johan Jonker wrote: > Convert inno_hdmi-rockchip.txt to yaml. > > Applied, thanks! [2/3] ARM: dts: rockchip: rk3036: fix hdmi ports node commit: 27ded76ef0fcfcf939914532aae575cf23c221b4 [3/3] ARM: dts: rockchip: rk3036-kylin: add hdmi-connector node

Re: [PATCH] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread David Heidelberg
Good catch, thank you! Sent v2. David On 12/12/2023 20:41, Jessica Zhang wrote: On 12/12/2023 9:53 AM, David Heidelberg wrote: Originally was in the panel-simple, but belongs to panel-simple-dsi. See arch/arm/boot/dts/nvidia/tegra114-roth.dts for more details. Fixes: ```

[PATCH v2] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread David Heidelberg
Originally was in the panel-simple, but belongs to panel-simple-dsi. See arch/arm/boot/dts/nvidia/tegra114-roth.dts for more details. Resolves the following warning: ``` arch/arm/boot/dts/tegra114-roth.dt.yaml: panel@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+' From

Re: [PATCH 00/31] Fix and improve Rockchip RK3128 support

2023-12-12 Thread Heiko Stuebner
Hi Alex, Am Dienstag, 29. August 2023, 19:16:16 CET schrieb Alex Bee: > this series fixes some issues I found when testing my "new" RK3128 board > with the mainline kernel and adds some core functionality like SMP bringup, > usb and networking. before I discard this thread, is everything from

[PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed

2023-12-12 Thread Brian Masney
When the power domains cannot be parsed, the message is incorrectly logged as an info message. Let's change this to an error since an error is returned. Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains") Signed-off-by: Brian Masney --- drivers/video/fbdev/simplefb.c |

Re: [PATCH] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread Jessica Zhang
On 12/12/2023 9:53 AM, David Heidelberg wrote: Originally was in the panel-simple, but belongs to panel-simple-dsi. See arch/arm/boot/dts/nvidia/tegra114-roth.dts for more details. Fixes: ``` arch/arm/boot/dts/tegra114-roth.dt.yaml: panel@0: 'reg' does not match any of the regexes:

Re: [net-next v1 15/16] net: add devmem TCP documentation

2023-12-12 Thread Simon Horman
On Thu, Dec 07, 2023 at 04:52:46PM -0800, Mina Almasry wrote: > Signed-off-by: Mina Almasry > --- > Documentation/networking/devmem.rst | 270 > 1 file changed, 270 insertions(+) > create mode 100644 Documentation/networking/devmem.rst > > diff --git

Re: [net-next v1 14/16] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2023-12-12 Thread Simon Horman
On Thu, Dec 07, 2023 at 04:52:45PM -0800, Mina Almasry wrote: > Add an interface for the user to notify the kernel that it is done > reading the devmem dmabuf frags returned as cmsg. The kernel will > drop the reference on the frags to make them available for re-use. > > Signed-off-by: Willem de

Re: [PATCH] ASoC: hdmi-codec: drop drm/drm_edid.h include

2023-12-12 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on tiwai-sound/for-next] [also build test ERROR on tiwai-sound/for-linus linus/master v6.7-rc5 next-20231212] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH 1/3] drm/mxsfb: Add an entry for "fsl,imx8mq-lcdif"

2023-12-12 Thread Fabio Estevam
Hi Lucas, On Tue, Dec 12, 2023 at 3:19 PM Lucas Stach wrote: > I don't really like this series. While we don't make any strong > guarantees in this way, it breaks booting older kernels with a new DT. I thought we needed only to guarantee that old DTs still run with newer kernels, not the other

Re: [PATCH 1/3] drm/mxsfb: Add an entry for "fsl,imx8mq-lcdif"

2023-12-12 Thread Lucas Stach
Hi Fabio, Am Montag, dem 11.12.2023 um 17:41 -0300 schrieb Fabio Estevam: > From: Fabio Estevam > > On i.MX6SX, the LCDIF has an associated power domain. > > However, i.MX8MQ does not have an LCDIF power domain. > > imx8mq.dtsi has the following compatible string: > > compatible =

[PATCH] dt-bindings: panel-simple-dsi: move LG 5" HD TFT LCD panel into DSI yaml

2023-12-12 Thread David Heidelberg
Originally was in the panel-simple, but belongs to panel-simple-dsi. See arch/arm/boot/dts/nvidia/tegra114-roth.dts for more details. Fixes: ``` arch/arm/boot/dts/tegra114-roth.dt.yaml: panel@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+' From schema:

Re: [PATCH v3 07/15] drm/msm/dpu: add dpu_hw_cdm abstraction for CDM block

2023-12-12 Thread Abhinav Kumar
On 12/12/2023 1:40 AM, Dmitry Baryshkov wrote: On Tue, 12 Dec 2023 at 02:23, Abhinav Kumar wrote: CDM block comes with its own set of registers and operations which can be done. In-line with other hardware blocks, this change adds the dpu_hw_cdm abstraction for the CDM block. changes in

Re: [PATCH 3/3] drm/amd/display: Support DRM_AMD_DC_FP on RISC-V

2023-12-12 Thread Josh Poimboeuf
On Mon, Dec 11, 2023 at 11:12:42PM -0800, Christoph Hellwig wrote: > On Thu, Dec 07, 2023 at 10:49:53PM -0600, Samuel Holland wrote: > > Actually tracking all possibly-FPU-tainted functions and their call sites is > > probably possible, but a much larger task. > > I think objtool should be able

[PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-12 Thread Uwe Kleine-König
Hello, clk_rate_exclusive_get() returns zero unconditionally. Most users "know" that and don't check the return value. This series fixes the four users that do error checking on the returned value and then makes function return void. Given that the changes to the drivers are simple and so merge

[PATCH 5/5] clk: Make clk_rate_exclusive_get() return void

2023-12-12 Thread Uwe Kleine-König
The function currently returns 0 unconditionally. This isn't very useful and makes users create dead code error paths. So let this function return no value. All users were adapted before to ignore the returned value. Also fix a few typos in the kernel doc comment for clk_rate_exclusive_get().

[PATCH 2/5] drm/meson: Simplify usage of clk_rate_exclusive_get()

2023-12-12 Thread Uwe Kleine-König
clk_rate_exclusive_get() returns 0 unconditionally. So remove error handling. This prepares making clk_rate_exclusive_get() return void. Signed-off-by: Uwe Kleine-König --- Hello, btw, the driver fails to call clk_rate_exclusive_put() in the error paths of dw_mipi_dsi_phy_init(). Best regards

Re: [PATCH v3 00/12] RB1/QCM2290 features

2023-12-12 Thread Will Deacon
On Wed, 29 Nov 2023 15:43:57 +0100, Konrad Dybcio wrote: > This series brings: > - interconnect plumbing > - display setup > > for QCM2290/QRB2210 and > > - CAN bus controller > - HDMI display > - wifi fw variant name > > [...] Applied SMMU update to will (for-joerg/arm-smmu/updates), thanks!

Re: [PATCH v3 01/15] drm/msm/dpu: add formats check for writeback encoder

2023-12-12 Thread Abhinav Kumar
On 12/11/2023 10:40 PM, Dmitry Baryshkov wrote: On Tue, 12 Dec 2023 at 02:23, Abhinav Kumar wrote: In preparation for adding more formats to dpu writeback add format validation to it to fail any unsupported formats. changes in v3: - rebase on top of msm-next - replace

Re: [PATCH v2 05/16] drm/msm/dpu: add cdm blocks to sc7280 dpu_hw_catalog

2023-12-12 Thread Dmitry Baryshkov
Hi Abhinav, On Tue, 12 Dec 2023 at 08:49, Dmitry Baryshkov wrote: > > On Mon, 11 Dec 2023 at 23:48, Abhinav Kumar wrote: > > > > > > > > On 12/11/2023 1:42 PM, Dmitry Baryshkov wrote: > > > On Mon, 11 Dec 2023 at 23:32, Abhinav Kumar > > > wrote: > > >> > > >> > > >> > > >> On 12/11/2023 1:31

[PATCH v8 1/2] drm/i915/guc: Flush context destruction worker at suspend

2023-12-12 Thread Alan Previn
When suspending, flush the context-guc-id deregistration worker at the final stages of intel_gt_suspend_late when we finally call gt_sanitize that eventually leads down to __uc_sanitize so that the deregistration worker doesn't fire off later as we reset the GuC microcontroller. Signed-off-by:

[PATCH v8 2/2] drm/i915/guc: Close deregister-context race against CT-loss

2023-12-12 Thread Alan Previn
If we are at the end of suspend or very early in resume its possible an async fence signal (via rcu_call) is triggered to free_engines which could lead us to the execution of the context destruction worker (after a prior worker flush). Thus, when suspending, insert rcu_barriers at the start of

[PATCH v8 0/2] Resolve suspend-resume racing with GuC destroy-context-worker

2023-12-12 Thread Alan Previn
This series is the result of debugging issues root caused to races between the GuC's destroyed_worker_func being triggered vs repeating suspend-resume cycles with concurrent delayed fence signals for engine-freeing. The reproduction steps require that an app is launched right before the start of

Re: [PATCH 2/3] dt-bindings: lcdif: Decouple imx8mq from imx6sx

2023-12-12 Thread Conor Dooley
On Mon, Dec 11, 2023 at 05:41:37PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > On i.MX6SX, the LCDIF has an associated power domain. > > i.MX8MQ does not have an LCDIF power domain, so allow passing only > "fsl,imx8mq-lcdif" as compatible string to fix the following > dt-schema

Re: [PATCH v3 0/7] dma-buf: heaps: Add secure heap

2023-12-12 Thread Simon Ser
Is there a chance to pick a better name than "secure" here? "Secure" is super overloaded, it's not clear at all what it means from just the name. Something like "restricted" would be an improvement.

[PATCH] drm/ci: uprev mesa version: fix kdl commit fetch

2023-12-12 Thread Vignesh Raman
build-kdl.sh was doing a `clone --depth 1` of the default branch, then checking out a commit that might not be the latest of that branch, resulting in container build error. https://gitlab.freedesktop.org/mesa/mesa/-/commit/5efa4d56 fixes kdl commit fetch issue. Uprev mesa in drm-ci to fix this.

Re: [PATCH v7 3/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v7)

2023-12-12 Thread kernel test robot
Hi Vivek, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Vivek-Kasireddy/udmabuf-Use-vmf_insert_pfn-and-VM_PFNMAP-for-handling-mmap/20231212-160312 base: https://git.kernel.org/pub

Re: [PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()

2023-12-12 Thread Mark Brown
On Tue, Dec 12, 2023 at 07:22:18AM -0800, Guenter Roeck wrote: > On 12/12/23 03:41, Uwe Kleine-König wrote: > > Several affected maintainers already acked, so I guess it's fine to take > > this via the pwm tree. An Ack from the remaining maintainers would be > > very welcome, an alternative would

Re: [PATCH v8 1/6] pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()

2023-12-12 Thread Guenter Roeck
On 12/12/23 03:41, Uwe Kleine-König wrote: On Tue, Dec 12, 2023 at 08:34:00AM +, Sean Young wrote: In order to introduce a pwm api which can be used from atomic context, we will need two functions for applying pwm changes: int pwm_apply_might_sleep(struct pwm *, struct pwm_state

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread Jason Gunthorpe
On Tue, Dec 12, 2023 at 06:58:17AM -0800, Mina Almasry wrote: > Jason, we set the LSB on page_pool_iov pointers before casting it to > struct page pointers. The resulting pointers are not useable as page > pointers at all. I understand that, the second ask is about maintainability of the mm by

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread Mina Almasry
On Tue, Dec 12, 2023 at 6:39 AM Jason Gunthorpe wrote: > > On Tue, Dec 12, 2023 at 06:26:51AM -0800, Mina Almasry wrote: > > On Tue, Dec 12, 2023 at 4:25 AM Jason Gunthorpe wrote: > > > > > > On Thu, Dec 07, 2023 at 04:52:39PM -0800, Mina Almasry wrote: > > > > > > > +static inline struct

Re: Radeon regression in 6.6 kernel

2023-12-12 Thread Alex Deucher
On Mon, Dec 11, 2023 at 7:28 PM Phillip Susi wrote: > > Phillip Susi writes: > > > And it works, but 6.7-rc5 does not, even though it includes that patch. > > Here's the syslog from the attempt. I'll start bisecting again. > > I checked out the patch that got merged upstream and it also fails.

[PATCH] drm/edid: prefer forward declarations over includes in drm_edid.h

2023-12-12 Thread Jani Nikula
There's no need to include either linux/hdmi.h or drm/drm_mode.h. They can be removed by using forward declarations. While at it, group the forward declarations together, and remove the unnecessary ones. Signed-off-by: Jani Nikula --- include/drm/drm_edid.h | 12 +--- 1 file changed, 5

Re: [PATCH] drm/amd: include drm/drm_edid.h only where needed

2023-12-12 Thread Alex Deucher
Applied with some minor fixups for our -next tree. Thanks! Alex On Tue, Dec 12, 2023 at 9:10 AM Jani Nikula wrote: > > Including drm_edid.h from amdgpu_mode.h causes the rebuild of literally > hundreds of files when drm_edid.h is modified, while there are only a > handful of files that

Re: [net-next v1 02/16] net: page_pool: create hooks for custom page providers

2023-12-12 Thread Mina Almasry
On Tue, Dec 12, 2023 at 12:07 AM Ilias Apalodimas wrote: > > Hi Mina, > > Apologies for not participating in the party earlier. > No worries, thanks for looking. > On Fri, 8 Dec 2023 at 02:52, Mina Almasry wrote: > > > > From: Jakub Kicinski > > > > The page providers which try to reuse the

Re: [PATCH] fbdev/clcd: Delete the old CLCD driver

2023-12-12 Thread Helge Deller
On 12/12/23 15:18, Linus Walleij wrote: We have managed to ascertain that all users of the old FBDEV code that are out of tree are now gone. The new DRM driver can be found in drivers/gpu/drm/pl111/. The remaining out of tree user was the ARM FVP emulation platform, running Android. Thanks to

Re: [PATCH] drm/radeon: include drm/drm_edid.h only where needed

2023-12-12 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Dec 12, 2023 at 9:10 AM Jani Nikula wrote: > > Including drm_edid.h from radeon_mode.h causes the rebuild of more than > a hundred files when drm_edid.h is modified, while there are only a > handful of files that actually need to include drm_edid.h. > >

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread Jason Gunthorpe
On Tue, Dec 12, 2023 at 06:26:51AM -0800, Mina Almasry wrote: > On Tue, Dec 12, 2023 at 4:25 AM Jason Gunthorpe wrote: > > > > On Thu, Dec 07, 2023 at 04:52:39PM -0800, Mina Almasry wrote: > > > > > +static inline struct page_pool_iov *page_to_page_pool_iov(struct page > > > *page) > > > +{ > >

[PATCH] ASoC: hdmi-codec: drop drm/drm_edid.h include

2023-12-12 Thread Jani Nikula
hdmi-codec.h does not appear to need drm/drm_edid.h for anything. Remove it. Signed-off-by: Jani Nikula --- I'm pretty sure I haven't compiled everything that might implicitly depend on the include. However, the right thing to do is to include drm_edid.h where needed, not from somewhat random

Re: [net-next v1 09/16] page_pool: device memory support

2023-12-12 Thread Mina Almasry
On Tue, Dec 12, 2023 at 3:17 AM Yunsheng Lin wrote: > > On 2023/12/12 2:14, Mina Almasry wrote: > > On Mon, Dec 11, 2023 at 3:51 AM Yunsheng Lin wrote: > >> > >> On 2023/12/11 12:04, Mina Almasry wrote: > >>> On Sun, Dec 10, 2023 at 6:26 PM Mina Almasry > >>> wrote: > > On Sun, Dec

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-12 Thread Mina Almasry
On Tue, Dec 12, 2023 at 4:25 AM Jason Gunthorpe wrote: > > On Thu, Dec 07, 2023 at 04:52:39PM -0800, Mina Almasry wrote: > > > +static inline struct page_pool_iov *page_to_page_pool_iov(struct page > > *page) > > +{ > > + if (page_is_page_pool_iov(page)) > > + return (struct

[PATCH] drm/hisilicon: include drm/drm_edid.h only where needed

2023-12-12 Thread Jani Nikula
Reduce the need for rebuilds when drm_edid.h is modified by including it only where needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 - drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/tegra: include drm/drm_edid.h only where needed

2023-12-12 Thread Jani Nikula
Reduce the need for rebuilds when drm_edid.h is modified by including it only where needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/tegra/drm.h| 2 +- drivers/gpu/drm/tegra/output.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/drm.h

  1   2   >