Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-19 Thread Tomi Valkeinen
On 20/03/2024 00:51, Sean Anderson wrote: Retraining the link can take a while, and might involve waiting for DPCD reads/writes to complete. This is inappropriate for an IRQ handler. Just schedule this work for later completion. This is racy, but will be fixed in the next commit. You should add

[PATCH 0/1] Add interface to allocate MediaTek GEM buffer

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Add an interface to allocate Mediatek GEM buffers, allow the IOCTLs to be used by render nodes. This patch also sets the RENDER driver feature. This patch is: - Based on 20240320024222.14234-1-shawn.s...@mediatek.com - Reviewed on https://chromium-review.googlesource.com/

[PATCH 1/1] drm/mediatek: Add interface to allocate MediaTek GEM buffer.

2024-03-19 Thread Shawn Sung
From: CK Hu Add an interface to allocate MediaTek GEM buffers, allow the IOCTLs to be used by render nodes. This patch also sets the RENDER driver feature. Signed-off-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 16 ++- drivers/gpu/drm/mediatek/mt

Re: [PATCH] mediatek: dsi: Correct calculation formula of PHY Timing

2024-03-19 Thread 胡俊光

Re: [PATCH v2 4/8] drm: zynqmp_dp: Rearrange zynqmp_dp for better padding

2024-03-19 Thread Tomi Valkeinen
On 20/03/2024 00:51, Sean Anderson wrote: Sort the members of struct zynqmp_dp to reduce padding necessary for alignment. Signed-off-by: Sean Anderson --- Changes in v2: - New drivers/gpu/drm/xlnx/zynqmp_dp.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions

Re: [PATCH 6/6] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-19 Thread Yujie Liu
Hi Sean, On Mon, Mar 18, 2024 at 03:05:57PM -0400, Sean Anderson wrote: > On 3/18/24 13:50, Laurent Pinchart wrote: > > On Mon, Mar 18, 2024 at 11:06:40AM -0400, Sean Anderson wrote: > >> On 3/16/24 06:14, kernel test robot wrote: > >> > Hi Sean, > >> > > >> > kernel test robot noticed the follow

Re: [PATCH v2 1/8] drm: xlnx: Fix kerneldoc

2024-03-19 Thread Randy Dunlap
On 3/19/24 22:42, Tomi Valkeinen wrote: > On 20/03/2024 00:51, Sean Anderson wrote: >> Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed >> members. >> >> Signed-off-by: Sean Anderson >> --- >> >> Changes in v2: >> - New >> >>   drivers/gpu/drm/xlnx/zynqmp_disp.c  | 6 +++

Re: [PATCH] mediatek: dsi: Add dsi per-frame lp code for mt8188

2024-03-19 Thread 胡俊光

Re: [PATCH v2 3/8] drm: zynqmp_dp: Adjust training values per-lane

2024-03-19 Thread Tomi Valkeinen
On 20/03/2024 00:51, Sean Anderson wrote: The feedback we get from the DPRX is per-lane. Make changes using this information, instead of picking the maximum values from all lanes. This results in more-consistent training on marginal links. Signed-off-by: Sean Anderson --- (no changes since v1)

Re: [PATCH v2 2/8] drm: zynqmp_dp: Downgrade log level for aux retries message

2024-03-19 Thread Tomi Valkeinen
On 20/03/2024 00:51, Sean Anderson wrote: Enable this message for verbose debugging only as it is otherwise printed after every AUX message, quickly filling the log buffer. Signed-off-by: Sean Anderson Reviewed-by: Laurent Pinchart --- (no changes since v1) drivers/gpu/drm/xlnx/zynqmp_dp.c

Re: [PATCH v2 1/8] drm: xlnx: Fix kerneldoc

2024-03-19 Thread Tomi Valkeinen
On 20/03/2024 00:51, Sean Anderson wrote: Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed members. Signed-off-by: Sean Anderson --- Changes in v2: - New drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++--- drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 + drivers/gpu/drm/xlnx

Re: [PATCH v2 11/14] drm/mediatek: Rename files "mtk_drm_plane.c" to "mtk_plane.c"

2024-03-19 Thread 宋孝謙

Re: [PATCH] video: fbdev: au1200fb: replace deprecated strncpy with strscpy

2024-03-19 Thread Kees Cook
On Mon, Mar 18, 2024 at 11:46:33PM +, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > Let's use the new 2-argument strscpy() which guarantees NUL-termination >

[PATCH v3 10/14] drm/mediatek: Rename files "mtk_drm_plane.h" to "mtk_plane.h"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_plane.h to mtk_plane.h. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_crtc.h | 2

[PATCH v3 02/14] drm/mediatek: Rename "mtk_drm_ddp_comp" to "mtk_ddp_comp"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_ddp_comp" to "mtk_ddp_comp": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 16 +++- driv

[PATCH v3 01/14] drm/mediatek: Rename "mtk_drm_crtc" to "mtk_crtc"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_crtc" to "mtk_crtc" due to the following benefits: - Lower the matches when searching the native drm_crtc* codes - Reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/m

[PATCH v3 04/14] drm/mediatek: Rename "mtk_drm_gem" to "mtk_gem"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_gem" to "mtk_gem": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +-- drivers/gpu/drm/mediatek/mtk_d

[PATCH v3 06/14] drm/mediatek: Rename files "mtk_drm_crtc.h" to "mtk_crtc.h"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_crtc.h to mtk_crtc.h. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/{mtk_drm_crtc.h => mtk_crtc.h} | 0 drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +- drive

[PATCH v3 05/14] drm/mediatek: Rename "mtk_drm_hdmi" to "mtk_hdmi"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_hdmi" to "mtk_hdmi": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 14 +++--- 1 file changed, 7 inse

[PATCH v3 08/14] drm/mediatek: Rename files "mtk_drm_ddp_comp.h" to "mtk_ddp_comp.h"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_ddp_comp.h to mtk_ddp_comp.h. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_crtc.h

[PATCH v3 14/14] drm/mediatek: Rename mtk_ddp_comp functions

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename functions of mtk_ddp_comp: - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 45 ++--- drivers/gpu/dr

[PATCH v3 00/14] Rename mtk_drm_* to mtk_*

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename some unnecessary "mtk_drm_*" to "mtk_*" because: - Lower the matches when searching the native drm_* codes - Reduce the code Changes in v3: - Fix typo and patch error Changes in v2: - Sort header files alphabetically - Seperate patches for renaming .c files to avo

[PATCH v3 03/14] drm/mediatek: Rename "mtk_drm_plane" to "mtk_plane"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_plane" to "mtk_plane": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 6 +++--- drivers/gpu/drm/mediatek

[PATCH v3 07/14] drm/mediatek: Rename files "mtk_drm_crtc.c" to "mtk_crtc.c"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_crtc.c to mtk_crtc.c and modify the Makefile accordingly. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 4 ++-- drivers/gpu/drm/mediatek/{mtk_drm_crtc.c => mtk_crtc.c} | 0 2 files c

[PATCH v3 12/14] drm/mediatek: Rename files "mtk_drm_gem.h" to "mtk_gem.h"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_gem.h to mtk_gem.h. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c| 2 +- drivers/

[PATCH v3 13/14] drm/mediatek: Rename files "mtk_drm_gem.c" to "mtk_gem.c"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_gem.c to mtk_gem.c. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 2 +- drivers/gpu/drm/mediatek/{mtk_drm_gem.c => mtk_gem.c} | 0 2 files cha

[PATCH v3 11/14] drm/mediatek: Rename files "mtk_drm_plane.c" to "mtk_plane.c"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_plane.c to mtk_plane.c and modify the Makefile accordingly. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 4 ++-- drivers/gpu/drm/mediatek

[PATCH v3 09/14] drm/mediatek: Rename files "mtk_drm_ddp_comp.c" to "mtk_ddp_comp.c"

2024-03-19 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_ddp_comp.c to mtk_ddp_comp.c and modify the Makefile accordingly. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 2 +- drivers/gpu/drm/mediatek/{mtk_drm_ddp_comp.c => mtk_ddp_

Re: [PATCH v2 13/14] drm/mediatek: Rename files "mtk_drm_gem.c" to "mtk_gem.c"

2024-03-19 Thread 胡俊光

Re: [PATCH v2 12/14] drm/mediatek: Rename files "mtk_drm_gem.h" to "mtk_gem.h"

2024-03-19 Thread 胡俊光

Re: [PATCH v2 11/14] drm/mediatek: Rename files "mtk_drm_plane.c" to "mtk_plane.c"

2024-03-19 Thread 胡俊光

Re: [PATCH v2 10/14] drm/mediatek: Rename files "mtk_drm_plane.h" to "mtk_plane.h"

2024-03-19 Thread 胡俊光

Re: [PATCH v2 09/14] drm/mediatek: Rename files "mtk_drm_ddp_comp.c" to "mtk_ddp_comp.c"

2024-03-19 Thread 胡俊光

Re: [PATCH v2 08/14] drm/mediatek: Rename files "mtk_drm_ddp_comp.h" to "mtk_ddp_comp.h"

2024-03-19 Thread 胡俊光

Re: [PATCH v2 07/14] drm/mediatek: Rename files "mtk_drm_crtc.c" to "mtk_crtc.c"

2024-03-19 Thread 胡俊光

Re: [PATCH v2 06/14] drm/mediatek: Rename files "mtk_drm_crtc.h" to "mtk_crtc.h"

2024-03-19 Thread 胡俊光

RE: [PATCH v2 5/8] drm: xlnx: zynqmp_dpsub: Set input live format

2024-03-19 Thread Klymenko, Anatoliy
Hi Laurent, Thanks a lot for your review. > -Original Message- > From: Laurent Pinchart > Sent: Monday, March 18, 2024 5:35 PM > To: Klymenko, Anatoliy > Cc: Maarten Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; David > Airlie ; Daniel Vetter ; Simek, Michal > ; Andrzej Hajda ; Neil

Re: [PATCH v2 02/14] drm/mediatek: Rename "mtk_drm_ddp_comp" to "mtk_ddp_comp"

2024-03-19 Thread 宋孝謙

RE: [PATCH v2 4/8] drm: xlnx: zynqmp_dpsub: Minimize usage of global flag

2024-03-19 Thread Klymenko, Anatoliy
Hi Laurent, Thank you for the review. > -Original Message- > From: Laurent Pinchart > Sent: Monday, March 18, 2024 5:13 PM > To: Klymenko, Anatoliy > Cc: Maarten Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; David > Airlie ; Daniel Vetter ; Simek, Michal > ; Andrzej Hajda ; Neil > A

RE: [PATCH v2 3/8] drm: xlnx: zynqmp_dpsub: Anounce supported input formats

2024-03-19 Thread Klymenko, Anatoliy
Hi Laurent, Thanks a lot for the review. > -Original Message- > From: Laurent Pinchart > Sent: Monday, March 18, 2024 5:05 PM > To: Klymenko, Anatoliy > Cc: Maarten Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; David > Airlie ; Daniel Vetter ; Simek, Michal > ; Andrzej Hajda ; Neil

[PATCH] dma-buf: Fix NULL pointer dereference in sanitycheck()

2024-03-19 Thread Pavel Sakharov
If due to a memory allocation failure mock_chain() returns NULL, it is passed to dma_fence_enable_sw_signaling() resulting in NULL pointer dereference there. Call dma_fence_enable_sw_signaling() only if mock_chain() succeeds. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixe

Re: [PATCH v2 0/8] drm: zynqmp_dp: Misc. patches and debugfs support

2024-03-19 Thread Sean Anderson
On 3/19/24 18:51, Sean Anderson wrote: > This series adds debugfs support for the zynqmp_dp driver. The intent is > to enable compliance testing or to help debug signal-integrity issues. > > The first four patches are general improvements (and could be applied > independently), while the last four

[PATCH v2 8/8] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-19 Thread Sean Anderson
Add a debugfs interface for exercising the various test modes supported by the DisplayPort controller. This allows performing compliance testing, or performing signal integrity measurements on a failing link. At the moment, we do not support sink-driven link quality testing, although such support w

[PATCH v2 6/8] drm: zynqmp_dp: Add locking

2024-03-19 Thread Sean Anderson
Add some locking to prevent the IRQ/workers/bridge API calls from stepping on each other's toes. This lock protects: - Non-atomic registers configuring the link. That is, everything but the IRQ registers (since these are accessed in an atomic fashion), and the DP AUX registers (since these don

[PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-19 Thread Sean Anderson
Retraining the link can take a while, and might involve waiting for DPCD reads/writes to complete. This is inappropriate for an IRQ handler. Just schedule this work for later completion. This is racy, but will be fixed in the next commit. Signed-off-by: Sean Anderson --- Actually, on second look

[PATCH v2 4/8] drm: zynqmp_dp: Rearrange zynqmp_dp for better padding

2024-03-19 Thread Sean Anderson
Sort the members of struct zynqmp_dp to reduce padding necessary for alignment. Signed-off-by: Sean Anderson --- Changes in v2: - New drivers/gpu/drm/xlnx/zynqmp_dp.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_

[PATCH v2 7/8] drm: zynqmp_dp: Split off several helper functions

2024-03-19 Thread Sean Anderson
In preparation for supporting compliance testing, split off several helper functions. No functional change intended. Signed-off-by: Sean Anderson Reviewed-by: Laurent Pinchart --- (no changes since v1) drivers/gpu/drm/xlnx/zynqmp_dp.c | 49 ++-- 1 file changed, 34

[PATCH v2 0/8] drm: zynqmp_dp: Misc. patches and debugfs support

2024-03-19 Thread Sean Anderson
This series adds debugfs support for the zynqmp_dp driver. The intent is to enable compliance testing or to help debug signal-integrity issues. The first four patches are general improvements (and could be applied independently), while the last four add debugfs support. Changes in v2: - Fix kerne

[PATCH v2 3/8] drm: zynqmp_dp: Adjust training values per-lane

2024-03-19 Thread Sean Anderson
The feedback we get from the DPRX is per-lane. Make changes using this information, instead of picking the maximum values from all lanes. This results in more-consistent training on marginal links. Signed-off-by: Sean Anderson --- (no changes since v1) drivers/gpu/drm/xlnx/zynqmp_dp.c | 23 +++

[PATCH v2 2/8] drm: zynqmp_dp: Downgrade log level for aux retries message

2024-03-19 Thread Sean Anderson
Enable this message for verbose debugging only as it is otherwise printed after every AUX message, quickly filling the log buffer. Signed-off-by: Sean Anderson Reviewed-by: Laurent Pinchart --- (no changes since v1) drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH v2 1/8] drm: xlnx: Fix kerneldoc

2024-03-19 Thread Sean Anderson
Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed members. Signed-off-by: Sean Anderson --- Changes in v2: - New drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++--- drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 + drivers/gpu/drm/xlnx/zynqmp_kms.h | 4 ++-- 3 files changed, 6 in

Re: [PATCH v2] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Dmitry Baryshkov
On Tue, 19 Mar 2024 at 22:58, Douglas Anderson wrote: > > In response to my patch removing the "wait for HPD" logic at the > beginning of the MSM DP transfer() callback [1], we had some debate > about what the "This is an optional function" meant in the > documentation of the wait_hpd_asserted() c

Re: [PATCH v3 3/5] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

2024-03-19 Thread Dmitry Baryshkov
On Tue, 19 Mar 2024 at 23:35, Abhinav Kumar wrote: > > > > On 3/19/2024 1:43 PM, Dmitry Baryshkov wrote: > > On Tue, 19 Mar 2024 at 22:34, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote: > >>> Move perf mode handling for the bandwidth to > >>> _dpu_core

Re: [PATCH v3 3/5] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

2024-03-19 Thread Abhinav Kumar
On 3/19/2024 1:43 PM, Dmitry Baryshkov wrote: On Tue, 19 Mar 2024 at 22:34, Abhinav Kumar wrote: On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote: Move perf mode handling for the bandwidth to _dpu_core_perf_crtc_update_bus() rather than overriding per-CRTC data and then aggregating known val

Re: [PATCH] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Doug Anderson
Hi, On Tue, Mar 19, 2024 at 1:55 PM Dmitry Baryshkov wrote: > > > -* panel to finish powering on. This is an optional function. > > +* panel to finish powering on. It is optional for DP AUX > > controllers > > +* to implement this function but required

[PATCH v2] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Douglas Anderson
In response to my patch removing the "wait for HPD" logic at the beginning of the MSM DP transfer() callback [1], we had some debate about what the "This is an optional function" meant in the documentation of the wait_hpd_asserted() callback. Let's clarify. As talked about in the MSM DP patch [1],

Re: [PATCH] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Dmitry Baryshkov
On Tue, 19 Mar 2024 at 22:39, Abhinav Kumar wrote: > > > > On 3/19/2024 1:16 PM, Dmitry Baryshkov wrote: > > On Tue, 19 Mar 2024 at 21:02, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/19/2024 11:35 AM, Dmitry Baryshkov wrote: > >>> On Tue, 19 Mar 2024 at 20:15, Douglas Anderson > >>> wrot

Re: [PATCH v3 3/5] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

2024-03-19 Thread Dmitry Baryshkov
On Tue, 19 Mar 2024 at 22:34, Abhinav Kumar wrote: > > > > On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote: > > Move perf mode handling for the bandwidth to > > _dpu_core_perf_crtc_update_bus() rather than overriding per-CRTC data > > and then aggregating known values. > > > > Note, this changes the

Re: [PATCH] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Abhinav Kumar
On 3/19/2024 1:16 PM, Dmitry Baryshkov wrote: On Tue, 19 Mar 2024 at 21:02, Abhinav Kumar wrote: On 3/19/2024 11:35 AM, Dmitry Baryshkov wrote: On Tue, 19 Mar 2024 at 20:15, Douglas Anderson wrote: In response to my patch removing the "wait for HPD" logic at the beginning of the MSM D

Re: [PATCH v3 3/5] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

2024-03-19 Thread Abhinav Kumar
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote: Move perf mode handling for the bandwidth to _dpu_core_perf_crtc_update_bus() rather than overriding per-CRTC data and then aggregating known values. Note, this changes the fix_core_ab_vote. Previously it would be multiplied per the CRTC number, n

Re: [PATCH] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Dmitry Baryshkov
On Tue, 19 Mar 2024 at 21:02, Abhinav Kumar wrote: > > > > On 3/19/2024 11:35 AM, Dmitry Baryshkov wrote: > > On Tue, 19 Mar 2024 at 20:15, Douglas Anderson > > wrote: > >> > >> In response to my patch removing the "wait for HPD" logic at the > >> beginning of the MSM DP transfer() callback [1],

Re: [PATCH v3 2/5] drm/msm/dpu: core_perf: extract bandwidth aggregation function

2024-03-19 Thread Abhinav Kumar
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote: In preparation to refactoring the dpu_core_perf debugfs interface, extract the bandwidth aggregation function from _dpu_core_perf_crtc_update_bus(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 45

Re: [PATCH] drm/tilcdc: Set preferred depth

2024-03-19 Thread Frej Drejhammar
Hi, Jyri sa...@kapsi.fi writes: > So the trouble here is the 16bpp and 24/32bpp color wiring being > crossed, right? I'd just like to remind that there is another option > to overcome the issue by editing device tree files. The current > configuration from some 8 years back supports RG16, BG24, a

Re: [PATCH] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Abhinav Kumar
On 3/19/2024 11:35 AM, Dmitry Baryshkov wrote: On Tue, 19 Mar 2024 at 20:15, Douglas Anderson wrote: In response to my patch removing the "wait for HPD" logic at the beginning of the MSM DP transfer() callback [1], we had some debate about what the "This is an optional function" meant in th

Re: [PATCH] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Dmitry Baryshkov
On Tue, 19 Mar 2024 at 20:15, Douglas Anderson wrote: > > In response to my patch removing the "wait for HPD" logic at the > beginning of the MSM DP transfer() callback [1], we had some debate > about what the "This is an optional function" meant in the > documentation of the wait_hpd_asserted() c

Re: [PATCH v3 1/5] drm/msm/dpu: don't allow overriding data from catalog

2024-03-19 Thread Abhinav Kumar
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote: The data from catalog is marked as const, so it is a part of the RO segment. Allowing userspace to write to it through debugfs can cause protection faults. Set debugfs file mode to read-only for debug entries corresponding to perf_cfg coming from c

Re: [PATCH v2 3/4] drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer

2024-03-19 Thread Abhinav Kumar
On 3/19/2024 11:15 AM, Doug Anderson wrote: Hi, On Tue, Mar 19, 2024 at 10:27 AM Dmitry Baryshkov wrote: On Tue, 19 Mar 2024 at 19:13, Abhinav Kumar wrote: On 3/18/2024 5:55 PM, Dmitry Baryshkov wrote: On Tue, 19 Mar 2024 at 02:19, Abhinav Kumar wrote: +bjorn, johan as fyi for sc8

Re: [PATCH] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Abhinav Kumar
On 3/19/2024 11:14 AM, Douglas Anderson wrote: In response to my patch removing the "wait for HPD" logic at the beginning of the MSM DP transfer() callback [1], we had some debate about what the "This is an optional function" meant in the documentation of the wait_hpd_asserted() callback. Let'

Re: [PATCH v2 3/4] drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer

2024-03-19 Thread Doug Anderson
Hi, On Tue, Mar 19, 2024 at 10:27 AM Dmitry Baryshkov wrote: > > On Tue, 19 Mar 2024 at 19:13, Abhinav Kumar wrote: > > > > > > > > On 3/18/2024 5:55 PM, Dmitry Baryshkov wrote: > > > On Tue, 19 Mar 2024 at 02:19, Abhinav Kumar > > > wrote: > > >> > > >> +bjorn, johan as fyi for sc8280xp > > >

[PATCH] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Douglas Anderson
In response to my patch removing the "wait for HPD" logic at the beginning of the MSM DP transfer() callback [1], we had some debate about what the "This is an optional function" meant in the documentation of the wait_hpd_asserted() callback. Let's clarify. As talked about in the MSM DP patch [1],

Re: [PATCH] nouveau/gsp: don't check devinit disable on GSP.

2024-03-19 Thread Danilo Krummrich
On 3/19/24 18:38, Timothy Maden wrote: Hello Can this be merged please ? Applied this to drm-misc-next-fixes a couple of hours ago. - Danilo On 3/14/24 03:45, Dave Airlie wrote: From: Dave Airlie GSP should be handling this and I can see no evidence in opengpu driver that this register

Re: [PATCH v2 3/4] drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer

2024-03-19 Thread Dmitry Baryshkov
On Tue, 19 Mar 2024 at 19:13, Abhinav Kumar wrote: > > > > On 3/18/2024 5:55 PM, Dmitry Baryshkov wrote: > > On Tue, 19 Mar 2024 at 02:19, Abhinav Kumar > > wrote: > >> > >> +bjorn, johan as fyi for sc8280xp > >> > >> On 3/15/2024 2:36 PM, Douglas Anderson wrote: > >>> Before the introduction of

Re: [PATCH v2 3/4] drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer

2024-03-19 Thread Abhinav Kumar
On 3/18/2024 5:55 PM, Dmitry Baryshkov wrote: On Tue, 19 Mar 2024 at 02:19, Abhinav Kumar wrote: +bjorn, johan as fyi for sc8280xp On 3/15/2024 2:36 PM, Douglas Anderson wrote: Before the introduction of the wait_hpd_asserted() callback in commit 841d742f094e ("drm/dp: Add wait_hpd_assert

Re: [PATCH 0/2] Add POWERTIP PH128800T006-ZHC01 panel

2024-03-19 Thread Neil Armstrong
Hi, On Mon, 18 Mar 2024 09:17:06 -0700, Nathan Morrisson wrote: > Add the device tree bindings, timings, and compatible string for the > POWERTIP PH128800T006-ZHC01 panel. > > Nathan Morrisson (2): > dt-bindings: display: simple: Add POWERTIP PH128800T-006-ZHC01 panel > drm/panel: simple: Add

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-19 Thread Neil Armstrong
Hi, On Mon, 18 Mar 2024 18:06:01 +0200, Laurent Pinchart wrote: > Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use > of_graph_get_remote_node()") simplified the thc63lvd1024 driver by > replacing hand-rolled code with a helper function. While doing so, it > created an error code path

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-19 Thread Neil Armstrong
On 18/03/2024 20:23, Sui Jingfeng wrote: Hi, On 2024/3/19 02:04, Laurent Pinchart wrote: Improving core helpers is certainly a good idea, and if we do so, we can simplify drivers. What I'm concerned is that commit 00084f0c01bf creates a silent probe failure path, No, I can't agree here. It

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-19 Thread Neil Armstrong
On 18/03/2024 17:06, Laurent Pinchart wrote: Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()") simplified the thc63lvd1024 driver by replacing hand-rolled code with a helper function. While doing so, it created an error code path at probe time without any

Re: [PATCH v2] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-19 Thread Daniel Vetter
On Thu, Mar 14, 2024 at 11:20:09AM +0100, Maxime Ripard wrote: > On Mon, Mar 11, 2024 at 04:58:58PM +0100, Sebastian Wick wrote: > > When extending support for a driver-specific KMS property to additional > > drivers, we should apply all the requirements for new properties and > > make sure the sem

Re: [PATCH v2 3/6] backlight: omap1: Replace FB_BLANK_ states with simple on/off

2024-03-19 Thread Daniel Thompson
On Tue, Mar 19, 2024 at 10:37:22AM +0100, Thomas Zimmermann wrote: > The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for > any other value in fb_blank. But the field fb_blank in struct > backlight_properties is deprecated and should not be used any > longer. > > Replace the test for fb

Re: Future handling of complex RGB devices on Linux v3

2024-03-19 Thread Werner Sembach
Hi Hans, Am 18.03.24 um 12:11 schrieb Hans de Goede: Hi Werner, Sorry for the late reply. np On 2/22/24 2:14 PM, Werner Sembach wrote: Hi, Thanks everyone for the exhaustive feedback. And at least this thread is a good comprehesive reference for the future ^^. To recap the hopefully fina

RE: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
[AMD Official Use Only - General] Ignore this as I have send v3. -Original Message- From: Sunil Khatri Sent: Tuesday, March 19, 2024 8:41 PM To: Deucher, Alexander ; Koenig, Christian ; Sharma, Shashank Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-ker...@v

[PATCH v3] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Sunil Khatri
Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between ioctl, debugfs and devcoredump. Cc: Christian König Cc: Alex Deucher Signed-off-by: Suni

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
Sent a new patch based on discussion with Alex. On 3/19/2024 8:34 PM, Christian König wrote: Am 19.03.24 um 15:59 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 10:56 AM Christian König wrote: Am 19.03.24 um 15:26 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: Ref

[PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Sunil Khatri
Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between ioctl, debugfs and devcoredump. Cc: Christian König Cc: Alex Deucher Signed-off-by: Suni

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Christian König
Am 19.03.24 um 15:59 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 10:56 AM Christian König wrote: Am 19.03.24 um 15:26 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessar

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
On Tue, Mar 19, 2024 at 10:56 AM Christian König wrote: > > Am 19.03.24 um 15:26 schrieb Alex Deucher: > > On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: > >> Refactor the code so debugfs and devcoredump can reuse > >> the common information and avoid unnecessary copy of it. > >> > >> create

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Christian König
Am 19.03.24 um 15:26 schrieb Alex Deucher: On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used

Re: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Christian König
Am 19.03.24 um 15:44 schrieb Khatri, Sunil: On 3/19/2024 8:07 PM, Christian König wrote: Am 19.03.24 um 15:25 schrieb Sunil Khatri: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place

Re: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
On 3/19/2024 8:07 PM, Christian König wrote: Am 19.03.24 um 15:25 schrieb Sunil Khatri: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used betwee

Re: [PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Christian König
Am 19.03.24 um 15:25 schrieb Sunil Khatri: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between ioctl, debugfs and devcoredump. Ok, taking a

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri wrote: > > Refactor the code so debugfs and devcoredump can reuse > the common information and avoid unnecessary copy of it. > > created a new file which would be the right place to > hold functions which will be used between sysfs, debugfs > and devcor

[PATCH v2] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Sunil Khatri
Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between ioctl, debugfs and devcoredump. Cc: Christian König Cc: Alex Deucher Signed-off-by: Suni

Re: [PATCH v2] drm: Fix drm_fixp2int_round() making it add 0.5

2024-03-19 Thread Melissa Wen
On 03/17, Maíra Canal wrote: > Hi Melissa, > > On 3/17/24 14:50, Melissa Wen wrote: > > On 03/16, Arthur Grillo wrote: > > > As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong. > > > To round a number, you need to add 0.5 to the number and floor that, > > > drm_fixp2int_round()

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Alex Deucher
On Tue, Mar 19, 2024 at 10:22 AM Lazar, Lijo wrote: > > > > On 3/19/2024 7:27 PM, Khatri, Sunil wrote: > > > > On 3/19/2024 7:19 PM, Lazar, Lijo wrote: > >> > >> On 3/19/2024 6:02 PM, Sunil Khatri wrote: > >>> Refactor the code so debugfs and devcoredump can reuse > >>> the common information and

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
On 3/19/2024 7:43 PM, Lazar, Lijo wrote: On 3/19/2024 7:27 PM, Khatri, Sunil wrote: On 3/19/2024 7:19 PM, Lazar, Lijo wrote: On 3/19/2024 6:02 PM, Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a ne

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

2024-03-19 Thread Huacai Chen
Hi, Jaak, On Mon, Mar 18, 2024 at 11:42 PM Jaak Ristioja wrote: > > Hi Huacai, > > Uh, no, sorry, I did not get to test such changes. From what Thomas > wrote I presumed that this got fixed and no further action would be > required. > > To speed things up I would appreciate it if you provided a p

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Lazar, Lijo
On 3/19/2024 7:27 PM, Khatri, Sunil wrote: > > On 3/19/2024 7:19 PM, Lazar, Lijo wrote: >> >> On 3/19/2024 6:02 PM, Sunil Khatri wrote: >>> Refactor the code so debugfs and devcoredump can reuse >>> the common information and avoid unnecessary copy of it. >>> >>> created a new file which would

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Khatri, Sunil
On 3/19/2024 7:19 PM, Lazar, Lijo wrote: On 3/19/2024 6:02 PM, Sunil Khatri wrote: Refactor the code so debugfs and devcoredump can reuse the common information and avoid unnecessary copy of it. created a new file which would be the right place to hold functions which will be used between sy

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/19/2024 7:17 PM, Christian König wrote: Am 19.03.24 um 12:41 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian):

Re: [PATCH] drm/amdgpu: refactor code to reuse system information

2024-03-19 Thread Lazar, Lijo
On 3/19/2024 6:02 PM, Sunil Khatri wrote: > Refactor the code so debugfs and devcoredump can reuse > the common information and avoid unnecessary copy of it. > > created a new file which would be the right place to > hold functions which will be used between sysfs, debugfs > and devcoredump. >

  1   2   3   >