[PATCH 6/8] accel/ivpu: Return max freq for DRM_IVPU_PARAM_CORE_CLOCK_RATE

2024-04-02 Thread Jacek Lawrynowicz
DRM_IVPU_PARAM_CORE_CLOCK_RATE returned current NPU frequency which could be 0 if device was sleeping. This value wasn't really useful to the user space, so return max freq instead which can be used to estimate NPU performance. Fixes: c39dc15191c4 ("accel/ivpu: Read clock rate only if device is

[PATCH 5/8] accel/ivpu: Improve clarity of MMU error messages

2024-04-02 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" This patch improves readability and clarity of MMU error messages. Previously, the error strings were somewhat confusing and could lead to ambiguous interpretations, making it difficult to diagnose issues. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek

[PATCH 4/8] accel/ivpu: Put NPU back to D3hot after failed resume

2024-04-02 Thread Jacek Lawrynowicz
Put NPU in D3hot after ivpu_resume() fails to power up the device. This will assure that D3->D0 power cycle will be performed before the next resume and also will minimize power usage in this corner case. Fixes: 28083ff18d3f ("accel/ivpu: Fix DevTLB errors on suspend/resume and recovery") Cc: #

[PATCH 3/8] accel/ivpu: Fix PCI D0 state entry in resume

2024-04-02 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" In case of failed power up we end up left in PCI D3hot state making it impossible to access NPU registers on retry. Enter D0 state on retry before proceeding with power up sequence. Fixes: 28083ff18d3f ("accel/ivpu: Fix DevTLB errors on suspend/resume and recovery")

[PATCH 2/8] accel/ivpu: Remove d3hot_after_power_off WA

2024-04-02 Thread Jacek Lawrynowicz
Always enter D3hot after entering D0i3 an all platforms. This minimizes power usage. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 20 ++-- drivers/accel/ivpu/ivpu_drv.h | 3 +-- drivers/accel/ivpu/ivpu_hw_37xx.c | 4 +---

[PATCH 1/8] accel/ivpu: Check return code of ipc->lock init

2024-04-02 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Return value of drmm_mutex_init(ipc->lock) was unchecked. Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages") Cc: # v6.3+ Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_ipc.c | 8 ++-- 1 file changed,

[PATCH 0/8] accel/ivpu: Fixes for 6.9-rc3

2024-04-02 Thread Jacek Lawrynowicz
A couple of small stability fixes, one UAPI fix and some error message fixes. Jacek Lawrynowicz (5): accel/ivpu: Remove d3hot_after_power_off WA accel/ivpu: Put NPU back to D3hot after failed resume accel/ivpu: Return max freq for DRM_IVPU_PARAM_CORE_CLOCK_RATE accel/ivpu: Fix missed

Re: [PATCH v5 03/10] drm/ci: uprev IGT and update testlist

2024-04-02 Thread Maíra Canal
On 4/2/24 06:41, Dmitry Baryshkov wrote: On Tue, Apr 02, 2024 at 12:35:17PM +0530, Vignesh Raman wrote: Hi Maíra, On 01/04/24 22:33, Maíra Canal wrote: On 4/1/24 03:12, Vignesh Raman wrote: Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist and skip driver-specific tests.

[PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_probe()

2024-04-02 Thread Harshit Mogalapalli
The devm_drm_dev_alloc() function returns error pointers. Update the error handling to check for error pointers instead of NULL. Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block") Signed-off-by: Harshit Mogalapalli --- This is spotted by smatch and the patch is only compile

[PATCH net-next v6 2/3] net: ethernet: ti: Add desc_infos member to struct k3_cppi_desc_pool

2024-04-02 Thread Julien Panis
This patch introduces a member and the related accessors which can be used to store descriptor specific additional information. This member can store, for instance, an ID to differentiate a skb TX buffer type from a xdpf TX buffer type. Signed-off-by: Julien Panis ---

[PATCH net-next v6 3/3] net: ethernet: ti: am65-cpsw: Add minimal XDP support

2024-04-02 Thread Julien Panis
This patch adds XDP (eXpress Data Path) support to TI AM65 CPSW Ethernet driver. The following features are implemented: - NETDEV_XDP_ACT_BASIC (XDP_PASS, XDP_TX, XDP_DROP, XDP_ABORTED) - NETDEV_XDP_ACT_REDIRECT (XDP_REDIRECT) - NETDEV_XDP_ACT_NDO_XMIT (ndo_xdp_xmit callback) The page pool memory

[PATCH net-next v6 1/3] net: ethernet: ti: Add accessors for struct k3_cppi_desc_pool members

2024-04-02 Thread Julien Panis
This patch adds accessors for desc_size and cpumem members. They may be used, for instance, to compute a descriptor index. Signed-off-by: Julien Panis --- drivers/net/ethernet/ti/k3-cppi-desc-pool.c | 12 drivers/net/ethernet/ti/k3-cppi-desc-pool.h | 2 ++ 2 files changed, 14

[PATCH net-next v6 0/3] Add minimal XDP support to TI AM65 CPSW Ethernet driver

2024-04-02 Thread Julien Panis
This patch adds XDP support to TI AM65 CPSW Ethernet driver. The following features are implemented: NETDEV_XDP_ACT_BASIC, NETDEV_XDP_ACT_REDIRECT, and NETDEV_XDP_ACT_NDO_XMIT. Zero-copy and non-linear XDP buffer supports are NOT implemented. Besides, the page pool memory model is used to get

[PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_ioctl_tiler_heap_destroy()

2024-04-02 Thread Harshit Mogalapalli
panthor_vm_get_heap_pool() returns ERR_PTR on failure. Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block") Signed-off-by: Harshit Mogalapalli --- This is spotted by smatch and the patch is only compile tested --- drivers/gpu/drm/panthor/panthor_drv.c | 4 ++-- 1 file changed, 2

Re: [PATCH v5 03/10] drm/ci: uprev IGT and update testlist

2024-04-02 Thread Vignesh Raman
Hi Dmitry, On 02/04/24 15:11, Dmitry Baryshkov wrote: On Tue, Apr 02, 2024 at 12:35:17PM +0530, Vignesh Raman wrote: Hi Maíra, On 01/04/24 22:33, Maíra Canal wrote: On 4/1/24 03:12, Vignesh Raman wrote: Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist and skip

Re: [PATCH] drm/mediatek: Init `ddp_comp` with devm_kcalloc()

2024-04-02 Thread AngeloGioacchino Del Regno
Il 28/03/24 17:22, Douglas Anderson ha scritto: In the case where `conn_routes` is true we allocate an extra slot in the `ddp_comp` array but mtk_drm_crtc_create() never seemed to initialize it in the test case I ran. For me, this caused a later crash when we looped through the array in

Re: [PATCH 00/11] drm/mediatek: drop driver owner initialization

2024-04-02 Thread AngeloGioacchino Del Regno
Il 30/03/24 21:43, Krzysztof Kozlowski ha scritto: Simplify the code by dropping unnecessary .owner initialization in the driver. For the entire series: Reviewed-by: AngeloGioacchino Del Regno Best regards, Krzysztof --- Krzysztof Kozlowski (11): drm/mediatek: aal: drop driver

[PATCH] drm/panthor: Fix a couple -ENOMEM error codes

2024-04-02 Thread Dan Carpenter
These error paths forgot to set the error code to -ENOMEM. Fixes: 647810ec2476 ("drm/panthor: Add the MMU/VM logical block") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/panthor/panthor_mmu.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/panthor: Fix off by one in panthor_fw_get_cs_iface()

2024-04-02 Thread Dan Carpenter
The ->iface.streams[csg_slot][] array has MAX_CS_PER_CSG elements so this > comparison needs to be >= to prevent an out of bounds access. Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/panthor/panthor_fw.c | 2 +- 1 file changed, 1

[PATCH] drm/panthor: Fix error code in panthor_gpu_init()

2024-04-02 Thread Dan Carpenter
This code accidentally returns zero/success on error because of a typo. It should be "irq" instead of "ret". The other thing is that if platform_get_irq_byname() were to return zero then the error code would be cmplicated. Fortunately, it does not so we can just change <= to < 0. Fixes:

Re: [PATCH] drm/ast: Fix soft lockup

2024-04-02 Thread Thomas Zimmermann
Hi Am 01.04.24 um 04:20 schrieb 黃立銘: Hi Thomas and Jocelyn, What we do in ast_dp_set_on_off() is a handshake between host driver and bmc-fw to confirm the operation, on/off, is completed. We use some scratch registers in bmc to handshake with host. This handshake only work if BMC's scu-lock

Re: [PATCH v5 03/10] drm/ci: uprev IGT and update testlist

2024-04-02 Thread Dmitry Baryshkov
On Tue, Apr 02, 2024 at 12:35:17PM +0530, Vignesh Raman wrote: > Hi Maíra, > > On 01/04/24 22:33, Maíra Canal wrote: > > On 4/1/24 03:12, Vignesh Raman wrote: > > > Uprev IGT and add amd, v3d, vc4 and vgem specific tests to > > > testlist and skip driver-specific tests. Also add testlist > > > to

[PATCH] drm/virtio: fix memory leak of vbuf

2024-04-02 Thread Weishi Li
Both virtio_gpu_queue_ctrl_buffer and virtio_gpu_queue_cursor use virtqueue_add_sgs to upload the structure virtio_gpu_vbuffer * vbuf to virtqueue. However, when virtqueue_add_sgs returns -EIO or -ENOMEM, it means vbuf upload failed, and vbuf will not be able to be free by

RE: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver

2024-04-02 Thread Akhil R
> > > > + .alg.skcipher.op.do_one_request = tegra_aes_do_one_req, > > + .alg.skcipher.base = { > > + .init = tegra_aes_cra_init, > > + .exit = tegra_aes_cra_exit, > > + .setkey = tegra_aes_setkey, > > +

[PATCH v2 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-02 Thread Aravind Iddamsetty
PCI subsystem provides callbacks to inform the driver about a request to do function level reset by user, initiated by writing to sysfs entry /sys/bus/pci/devices/.../reset. This will allow the driver to handle FLR without the need to do unbind and rebind as the driver needs to reinitialize the

[PATCH 3/4] drm/xe: Extract xe_gt_idle() helper

2024-04-02 Thread Aravind Iddamsetty
This would be used in other places outside of gt_reset path. Cc: Lucas De Marchi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_gt.c | 31 +-- drivers/gpu/drm/xe/xe_gt.h | 1 + 2 files changed, 22 insertions(+), 10 deletions(-) diff --git

[PATCH 2/4] drm/xe: Save and restore PCI state

2024-04-02 Thread Aravind Iddamsetty
Save and restore PCI states where ever needed. Cc: Lucas De Marchi Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device_types.h | 3 ++ drivers/gpu/drm/xe/xe_pci.c | 48 ++-- drivers/gpu/drm/xe/xe_pci.h | 4 ++- 3 files changed, 51

[PATCH v2 1/4] drm: add devm release action

2024-04-02 Thread Aravind Iddamsetty
In scenarios where drm_dev_put is directly called by driver we want to release devm_drm_dev_init_release action associated with struct drm_device. v2: Directly expose the original function, instead of introducing a helper (Rodrigo) Cc: Thomas Hellstr_m Cc: Rodrigo Vivi Signed-off-by: Aravind

[PATCH v2 0/4] drm/xe: Support PCIe FLR

2024-04-02 Thread Aravind Iddamsetty
PCI subsystem provides callbacks to inform the driver about a request to do function level reset by user, initiated by writing to sysfs entry /sys/bus/pci/devices/.../reset. This will allow the driver to handle FLR without the need to do unbind and rebind as the driver needs to reinitialize the

Re: [PATCH 0/4] drm/edid & drm/i915: vendor and product id logging improvements

2024-04-02 Thread Jani Nikula
On Thu, 21 Mar 2024, Jani Nikula wrote: > Jani Nikula (4): > drm/edid: add drm_edid_get_product_id() > drm/edid: add drm_edid_print_product_id() > drm/i915/bios: switch to struct drm_edid and struct > drm_edid_product_id > drm/i915/bios: return drm_edid_product_id from

Re: [REGRESSION] external monitor+Dell dock in 6.8

2024-04-02 Thread Linux regression tracking (Thorsten Leemhuis)
[Adding a few folks and list while dropping the stable list, as this is unrelated to it] On 31.03.24 07:59, Andrei Gaponenko wrote: > > I noticed a regression with the mailine kernel pre-compiled by EPEL. > I have just tried linux-6.9-rc1.tar.gz from kernel.org, and it still > misbehaves. > >

Re: [PATCH v0 10/14] sfc: falcon: Make I2C terminology more inclusive

2024-04-02 Thread Simon Horman
On Fri, Mar 29, 2024 at 05:00:34PM +, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-04-02 Thread Christian König
Am 26.03.24 um 15:53 schrieb Alex Deucher: On Tue, Mar 26, 2024 at 10:01 AM Alex Deucher wrote: On Tue, Mar 26, 2024 at 9:59 AM Paneer Selvam, Arunpravin wrote: Hi Alex, On 3/26/2024 7:08 PM, Alex Deucher wrote: On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: Add clear

Re: [PATCH] dmabuf: fix dmabuf file poll uaf issue

2024-04-02 Thread Christian König
Am 02.04.24 um 08:49 schrieb zhiguojiang: As far as I can see that's not because of the DMA-buf code, but because you are somehow using this interface incorrectly. When dma_buf_poll() is called it is mandatory for the caller to hold a reference to the file descriptor on which the poll

[PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()

2024-04-02 Thread Thorsten Blum
Fixes the following Coccinelle/coccicheck warning reported by kfree_mismatch.cocci: WARNING kvmalloc is used to allocate this memory at line 10398 Signed-off-by: Thorsten Blum --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/mediatek: Add RENDER capability to DRM device

2024-04-02 Thread Wojciech Macek
DRM device shall create /dev/dri/renderXXX entry to allow ChromeOS VMs to access the OpenGL rendering offload. Signed-off-by: Wojciech Macek --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c

[PATCH] drm/mediatek/dp: fix mtk_dp_aux_transfer return value

2024-04-02 Thread Wojciech Macek
From: Wojciech Macek In case there is no DP device attached to the port the transfer function should return IO error, similar to what other drivers do. In case EAGAIN is returned then any read from /dev/drm_dp_aux device ends up in an infinite loop as the upper layers constantly repeats the

Re: 2024 X.Org Foundation Membership deadline for voting in the election

2024-04-02 Thread Laurent Pinchart
Hi Pekka, On Tue, Apr 02, 2024 at 10:46:08AM +0300, Pekka Paalanen wrote: > On Tue, 26 Mar 2024 11:42:48 -0400 Christopher Michael wrote: > > > The 2024 X.Org Foundation membership renewal period has been extended > > one additional week and elections will start the following week on 01 > >

Re: [PATCH v0 03/14] drm/gma500,drm/i915: Make I2C terminology more inclusive

2024-04-02 Thread Jani Nikula
On Fri, 29 Mar 2024, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT bitbanging interface, now

Re: 2024 X.Org Foundation Membership deadline for voting in the election

2024-04-02 Thread Pekka Paalanen
On Tue, 26 Mar 2024 11:42:48 -0400 Christopher Michael wrote: > The 2024 X.Org Foundation membership renewal period has been extended > one additional week and elections will start the following week on 01 > April 2024. > > Please note that only current members can vote in the upcoming

Re: [PATCH] drm/panthor: Fix clang -Wunused-but-set-variable in tick_ctx_apply()

2024-04-02 Thread Boris Brezillon
On Thu, 28 Mar 2024 09:22:07 -0700 Nathan Chancellor wrote: > Clang warns (or errors with CONFIG_WERROR): > > drivers/gpu/drm/panthor/panthor_sched.c:2048:6: error: variable > 'csg_mod_mask' set but not used [-Werror,-Wunused-but-set-variable] >2048 | u32 csg_mod_mask = 0,

Re: [PATCH v3 1/3] drm/panthor: Fix IO-page mmap() for 32-bit userspace on 64-bit kernel

2024-04-02 Thread Boris Brezillon
On Tue, 26 Mar 2024 12:12:03 +0100 Boris Brezillon wrote: > When mapping an IO region, the pseudo-file offset is dependent on the > userspace architecture. panthor_device_mmio_offset() abstracts that > away for us by turning a userspace MMIO offset into its kernel > equivalent, but we were not

Re: [PATCH v3 1/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel

2024-04-02 Thread Dmitry Baryshkov
On Tue, 2 Apr 2024 at 09:31, Krzysztof Kozlowski wrote: > > On 02/04/2024 01:51, Dmitry Baryshkov wrote: > > From: Sumit Semwal > > > > LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel present on Google Pixel 3 > > phones. > > > > Signed-off-by: Vinod Koul > > Signed-off-by: Sumit Semwal > >

Re: [PATCH v5 03/10] drm/ci: uprev IGT and update testlist

2024-04-02 Thread Vignesh Raman
Hi Maíra, On 01/04/24 22:33, Maíra Canal wrote: On 4/1/24 03:12, Vignesh Raman wrote: Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist and skip driver-specific tests. Also add testlist to the MAINTAINERS file and update xfails. Signed-off-by: Vignesh Raman --- v3:    -

Re: [PATCH v5 00/10] Improvments for tc358775 with support for tc358765

2024-04-02 Thread Michael Walle
Hi DRM maintainers, On Sun Feb 25, 2024 at 7:19 AM CET, Tony Lindgren wrote: > Here are v5 patches to improve tc358775 driver and add support for > tc358765. Any news on this series? Is there anything open or can it be merged? FWIW, I have another tc358775 improvement series based on this.

Re: [PATCH] dmabuf: fix dmabuf file poll uaf issue

2024-04-02 Thread zhiguojiang
As far as I can see that's not because of the DMA-buf code, but because you are somehow using this interface incorrectly. When dma_buf_poll() is called it is mandatory for the caller to hold a reference to the file descriptor on which the poll operation is executed. So adding code like "if

Re: [PATCH v5 04/10] drm/ci: mediatek: Refactor existing mediatek jobs

2024-04-02 Thread Vignesh Raman
Hi Helen, On 01/04/24 22:12, Helen Koike wrote: On 01/04/2024 03:12, Vignesh Raman wrote: For mediatek mt8173 and mt8183, the display driver is mediatek. Currently, in drm-ci for mediatek, only the display driver is tested. Refactor the existing mediatek jobs so that gpu driver testing jobs

Re: [PATCH v5 08/10] drm/ci: rockchip: Refactor existing rockchip jobs

2024-04-02 Thread Vignesh Raman
Hi Helen, On 01/04/24 22:13, Helen Koike wrote: On 01/04/2024 03:12, Vignesh Raman wrote: For rockchip rk3288 and rk3399, the display driver is rockchip. Currently, in drm-ci for rockchip, only the display driver is tested. Refactor the existing rockchip jobs so that gpu driver testing jobs

Re: [PATCH v5 09/10] drm/ci: rockchip: Add job to test panfrost GPU driver

2024-04-02 Thread Vignesh Raman
Hi Helen, On 01/04/24 22:13, Helen Koike wrote: On 01/04/2024 03:12, Vignesh Raman wrote: For rockchip rk3288 and rk3399, the GPU driver is panfrost. So add support in drm-ci to test panfrost driver for rockchip SOC and update xfails. Skip KMS tests for panfrost driver since it is not a not

Re: [PATCH v2 25/25] sound: virtio: drop owner assignment

2024-04-02 Thread Anton Yakovlev
Hi Krzysztof, On 31.03.2024 10:44, Krzysztof Kozlowski wrote: virtio core already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski Acked-by: Anton Yakovlev --- Depends on the first patch. --- sound/virtio/virtio_card.c | 1 - 1 file changed, 1

Re: [PATCH v3 1/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel

2024-04-02 Thread Krzysztof Kozlowski
On 02/04/2024 01:51, Dmitry Baryshkov wrote: > From: Sumit Semwal > > LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel present on Google Pixel 3 > phones. > > Signed-off-by: Vinod Koul > Signed-off-by: Sumit Semwal > [caleb: convert to yaml] > Signed-off-by: Caleb Connolly > Signed-off-by:

<    1   2