Re: [PATCH] drm/virtio: fix memory leak of vbuf

2024-04-28 Thread Markus Elfring
… > Therefore, when upload fails,vbuf needs to be free directly. Please choose a corresponding imperative wording for an improved change description. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94 Regards, Marku

Re: [PATCH v4 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-04-28 Thread Krzysztof Kozlowski
On 26/04/2024 19:22, Alexandre Mergnat wrote: >regulators: > type: object > $ref: /schemas/regulator/mediatek,mt6357-regulator.yaml > @@ -83,6 +111,12 @@ examples: > interrupt-controller; > #interrupt-cells = <2>; > > +audio-codec { > +

Re: [PATCH 2/2] drm/nouveau/gsp: Use the sg allocator for level 2 of radix3

2024-04-28 Thread Dave Airlie
> Currently, this can result in runtime PM issues on systems where memory > Luckily, we don't actually need to allocate coherent memory for the page > table thanks to being able to pass the GPU a radix3 page table for > suspend/resume data. So, let's rewrite nvkm_gsp_radix3_sg() to use the sg > all

Re: [PATCH v4 02/16] ASoC: dt-bindings: mediatek,mt8365-mt6357: Add audio sound card document

2024-04-28 Thread Krzysztof Kozlowski
On 26/04/2024 19:22, Alexandre Mergnat wrote: > + link-name: > +description: Indicates dai-link name and PCM stream name > +enum: > + - I2S_IN_BE > + - I2S_OUT_BE > + - PCM1_BE > + - PDM1_BE > + - PDM2_BE > + - PDM3_BE > +

Re: [PATCH v4 01/16] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document

2024-04-28 Thread Krzysztof Kozlowski
On 26/04/2024 19:22, Alexandre Mergnat wrote: > Add MT8365 audio front-end bindings > > Signed-off-by: Alexandre Mergnat > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 7/8] drm/v3d: Use gemfs/THP in BO creation if available

2024-04-28 Thread Iago Toral
Hi Maíra, a question below: El dom, 28-04-2024 a las 09:40 -0300, Maíra Canal escribió: > Although Big/Super Pages could appear naturally, it would be quite > hard > to have 1MB or 64KB allocated contiguously naturally. Therefore, we > can > force the creation of large pages allocated contiguous

linux-next: manual merge of the drm-xe tree with the drm tree

2024-04-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-xe tree got a conflict in: drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h between commit: cb4046d289bd ("drm/i915: Drop dead code for xehpsdv") from the drm tree and commit: 6a2a90cba12b ("drm/xe/display: Fix ADL-N detection") from the drm

[PATCH] [PATCH RESEND] drm/virtio: fix memory leak of vbuf

2024-04-28 Thread Weishi Li
Both virtio_gpu_queue_ctrl_buffer and virtio_gpu_queue_cursor use virtqueue_add_sgs to upload the structure virtio_gpu_vbuffer * vbuf to virtqueue. However, when virtqueue_add_sgs returns -EIO or -ENOMEM, it means vbuf upload failed, and vbuf will not be able to be free by virtio_gpu_dequeue_*_func

RE: [PATCH] drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()

2024-04-28 Thread Zhou, Bob
[Public] Reviewed-by: Bob Zhou Regards, Bob -Original Message- From: Dan Carpenter Sent: 2024年4月28日 20:57 To: Zhou, Bob Cc: Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Daniel Vetter ; Kuehling, Felix ; Zhang, Hawking ; Guchun Chen ; Ma, Le ; Lazar, Lijo

Re: [PATCH v2] drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2

2024-04-28 Thread Chris Bainbridge
On Tue, Jun 20, 2023 at 03:59:24PM -0400, Lyude Paul wrote: > Also since I forgot, so patchwork picks this up: > > Reviewed-by: Lyude Paul > > On Tue, 2023-06-20 at 15:50 -0400, Lyude Paul wrote: > > Eek - this might have been a situation where everyone involved assumed > > someone > > else wou

[PATCH] staging: fbtft:fixes unnecessary parentheses

2024-04-28 Thread pipishuo
This patch fixes the checks reported by checkpatch.pl for unnecessary parentheses Signed-off-by: pipishuo <1289151...@qq.com> --- drivers/staging/fbtft/fb_ili9320.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb

Re: drm/debugfs: Drop conditionals around of_node pointers

2024-04-28 Thread Sui Jingfeng
ping 在 2024/3/22 06:22, Sui Jingfeng 写道: Having conditional around the of_node pointer of the drm_bridge structure turns out to make driver code use ugly #ifdef blocks. Drop the conditionals to simplify debugfs. Fixes: d8dfccde2709 ("drm/bridge: Drop conditionals around of_node pointers") Signe

Re: [PATCH 5/7] drm/msm/dpu: Correct dual-ctl -> dual-intf typo in comment

2024-04-28 Thread Marijn Suijten
On 2024-04-18 02:30:59, Dmitry Baryshkov wrote: > On Wed, Apr 17, 2024 at 01:57:45AM +0200, Marijn Suijten wrote: > > This comment one line down references a single, "same CTL" that controls > > two interfaces, so the comment should clearly describe two interfaces > > used with a single active CTL

Re: [RFC] drm/nouveau: use tile_mode and pte_kind for VM_BIND bo allocations

2024-04-28 Thread Dave Airlie
This looks like a good start, though I wonder can we just refactor out the common code from the vma and non-vma paths easier. Also I wonder should we add a new GETPARAM so userspace can know this change is available. Of course we also need a pointer to the userspace implementation to move forward

Re: [PATCH 1/2] drm/nouveau/firmware: Fix SG_DEBUG error with nvkm_firmware_ctor()

2024-04-28 Thread Timur Tabi
On Sun, 2024-04-28 at 11:52 -0400, Lyude Paul wrote: > But we can't get a page pointer from an allocation made by > dma_alloc_coherent() - but we can from vmalloc(). I'll fix the patch > explanation in the next version, I have to send out another version > anyhow since I realized that patch #2 stil

Re: [PATCH] drm/amd/display: re-indent dpp401_dscl_program_isharp()

2024-04-28 Thread Aurabindo Pillai
Patch has been merged to amd-staging-drm-next. On 4/28/24 12:09 PM, Aurabindo Pillai wrote: Thanks for the fix! Reviewed-by: Aurabindo Pillai On 4/28/24 8:42 AM, Dan Carpenter wrote: Smatch complains because some lines are indented more than they should be.  I went a bit crazy re-indenting t

Re: [PATCH] drm/amd/display: re-indent dpp401_dscl_program_isharp()

2024-04-28 Thread Aurabindo Pillai
Thanks for the fix! Reviewed-by: Aurabindo Pillai On 4/28/24 8:42 AM, Dan Carpenter wrote: Smatch complains because some lines are indented more than they should be. I went a bit crazy re-indenting this. ;) The comments were not useful except as a marker of things which are left to implemen

Re: [PATCH 1/2] drm/nouveau/firmware: Fix SG_DEBUG error with nvkm_firmware_ctor()

2024-04-28 Thread Lyude Paul
On Fri, 2024-04-26 at 15:47 +, Timur Tabi wrote: > On Fri, 2024-04-26 at 11:41 -0400, Lyude Paul wrote: > > We hit this because when initializing firmware of type > > NVKM_FIRMWARE_IMG_DMA we allocate coherent memory and then attempt > > to > > include that coherent memory in a scatterlist. >

Re: [PATCH] staging: fbtft:fixes unnecessary parentheses

2024-04-28 Thread Dan Carpenter
On Sun, Apr 28, 2024 at 08:19:08PM +0800, pipishuo wrote: > This patch fixes the checks reported by checkpatch.pl > for unnecessary parentheses > > Signed-off-by: pipishuo <1289151...@qq.com> > --- > drivers/staging/fbtft/fb_ili9320.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[PATCH] drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()

2024-04-28 Thread Dan Carpenter
The "instance" variable needs to be signed for the error handling to work. Fixes: b34ddc71267a ("drm/amdgpu: add error handle to avoid out-of-bounds") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH v4 8/8] drm/v3d: Add modparam for turning off Big/Super Pages

2024-04-28 Thread Maíra Canal
Add a modparam for turning off Big/Super Pages to make sure that if an user doesn't want Big/Super Pages enabled, it can disabled it by setting the modparam to false. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_drv.c | 7 +++ drivers/gpu/drm/v3d/v3d_gemfs.c | 5 + 2 files ch

[PATCH v4 7/8] drm/v3d: Use gemfs/THP in BO creation if available

2024-04-28 Thread Maíra Canal
Although Big/Super Pages could appear naturally, it would be quite hard to have 1MB or 64KB allocated contiguously naturally. Therefore, we can force the creation of large pages allocated contiguously by using a mountpoint with "huge=within_size" enabled. Therefore, as V3D has a mountpoint with "h

[PATCH v4 6/8] drm/v3d: Support Big/Super Pages when writing out PTEs

2024-04-28 Thread Maíra Canal
The V3D MMU also supports 64KB and 1MB pages, called big and super pages, respectively. In order to set a 64KB page or 1MB page in the MMU, we need to make sure that page table entries for all 4KB pages within a big/super page must be correctly configured. In order to create a big/super page, we n

[PATCH v4 5/8] drm/v3d: Reduce the alignment of the node allocation

2024-04-28 Thread Maíra Canal
Currently, we are using an alignment of 128 kB to insert a node, which ends up wasting memory as we perform plenty of small BOs allocations (<= 4 kB). We require that allocations are aligned to 128Kb so for any allocation smaller than that, we are wasting the difference. This implies that we canno

[PATCH v4 4/8] drm/gem: Create shmem GEM object in a given mountpoint

2024-04-28 Thread Maíra Canal
Create a function `drm_gem_shmem_create_with_mnt()`, similar to `drm_gem_shmem_create()`, that has a mountpoint as a argument. This function will create a shmem GEM object in a given tmpfs mountpoint. This function will be useful for drivers that have a special mountpoint with flags enabled. Sign

[PATCH v4 0/8] drm/v3d: Enable Big and Super Pages

2024-04-28 Thread Maíra Canal
This series introduces support for big and super pages in V3D. The V3D MMU has support for 64KB and 1MB pages, called big pages and super pages, which are currently not used. Therefore, this patchset has the intention to enable big and super pages in V3D. The advantage of enabling big and super pag

[PATCH v4 1/8] drm/v3d: Fix return if scheduler initialization fails

2024-04-28 Thread Maíra Canal
If the scheduler initialization fails, GEM initialization must fail as well. Therefore, if `v3d_sched_init()` fails, free the DMA memory allocated and return the error value in `v3d_gem_init()`. Signed-off-by: Maíra Canal Reviewed-by: Iago Toral Quiroga --- drivers/gpu/drm/v3d/v3d_gem.c | 3 ++-

[PATCH v4 2/8] drm/gem: Create a drm_gem_object_init_with_mnt() function

2024-04-28 Thread Maíra Canal
For some applications, such as applications that uses huge pages, we might want to have a different mountpoint, for which we pass mount flags that better match our usecase. Therefore, create a new function `drm_gem_object_init_with_mnt()` that allow us to define the tmpfs mountpoint where the GEM

[PATCH v4 3/8] drm/v3d: Introduce gemfs

2024-04-28 Thread Maíra Canal
Create a separate "tmpfs" kernel mount for V3D. This will allow us to move away from the shmemfs `shm_mnt` and gives the flexibility to do things like set our own mount options. Here, the interest is to use "huge=", which should allow us to enable the use of THP for our shmem-backed objects. Signe

[PATCH] drm/amd/display: re-indent dpp401_dscl_program_isharp()

2024-04-28 Thread Dan Carpenter
Smatch complains because some lines are indented more than they should be. I went a bit crazy re-indenting this. ;) The comments were not useful except as a marker of things which are left to implement so I deleted most of them except for the TODO. I introduced a "data" pointer so that I could

Re: [PATCH v2][next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get

2024-04-28 Thread Shresth Prasad
Hi, any updates on this? Has this patch been accepted? Regards, Shresth

[Bug 218785] HP Victus by HP Laptop 16-e0xxx. HDMI connection doesn't detect counterpart projector.

2024-04-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218785 --- Comment #2 from Sergey Ivanov (icegood1...@gmail.com) --- same empty list is in Linux ice-home 6.5.0-28-generic #29-Ubuntu SMP PREEMPT_DYNAMIC Thu Mar 28 23:46:48 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux -- You may reply to this email to ad

Re: [PATCH 04/10] drm/panel: Add driver for Synaptics TD4328 LCD panel

2024-04-28 Thread Xilin Wu
On 2024/4/24 23:58, Bryan O'Donoghue wrote: On 24/04/2024 16:29, Xilin Wu via B4 Relay wrote: From: Xilin Wu Add support for the 1920x1080 LCD panel driven by the Synaptics TD4328 IC, as found on AYN Odin 2. Co-developed-by: Junhao Xie Signed-off-by: Junhao Xie Signed-off-by: Xilin Wu ch

Re: [PATCH 07/10] arm64: dts: qcom: sm8550: Update EAS properties

2024-04-28 Thread Xilin Wu
On 2024/4/25 6:45, Bryan O'Donoghue wrote: On 24/04/2024 16:29, Xilin Wu via B4 Relay wrote: From: Xilin Wu The original values provided by Qualcomm appear to be quite inaccurate. Specifically, some heavy gaming tasks could be improperly assigned to the A510 cores by the scheduler, resulting i

Re: [PATCH 10/10] arm64: dts: qcom: Add AYN Odin 2

2024-04-28 Thread Xilin Wu
On 2024/4/25 14:28, Krzysztof Kozlowski wrote: On 24/04/2024 17:29, Xilin Wu via B4 Relay wrote: From: Xilin Wu AYN Odin 2 is a gaming handheld based on QCS8550, which is derived from SM8550 but without modem RF system. + +/ { + model = "AYN Odin 2"; + compatible = "ayn,odin2

Re: [PATCH 08/10] dt-bindings: vendor-prefixes: Add AYN Technologies

2024-04-28 Thread Xilin Wu
On 2024/4/26 0:13, Rob Herring wrote: On Wed, Apr 24, 2024 at 11:29:13PM +0800, Xilin Wu wrote: Add an entry for AYN Technologies (https://www.ayntec.com/) Signed-off-by: Xilin Wu --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH] drm/vc4: remove all usages of of_node_put()

2024-04-28 Thread Amer Al Shanawany
Use the scope-based cleanup feature to clean up 'struct device_node *' when they go out of scope, and remove all instances of of_node_put() within the same scope, to simplify function exit and avoid potential memory leaks. Suggested-by: Julia Lawall Signed-off-by: Amer Al Shanawany --- drivers/

[RFC] drm/nouveau: use tile_mode and pte_kind for VM_BIND bo allocations

2024-04-28 Thread Mohamed Ahmed
Allows PTE kind and tile mode on BO create with VM_BIND. This is needed to support modifiers in NVK and ensure correctness when dealing with the nouveau GL driver. Signed-off-by: Mohamed Ahmed --- drivers/gpu/drm/nouveau/nouveau_bo.c | 24 +++- 1 file changed, 19 insertions

Re: [PATCH 03/10] dt-bindings: display: panel: Add Synaptics TD4328

2024-04-28 Thread Xilin Wu
On 2024/4/26 0:11, Rob Herring wrote: On Wed, Apr 24, 2024 at 11:29:08PM +0800, Xilin Wu wrote: Synaptics TD4328 is a display driver IC used to drive LCD DSI panels. Signed-off-by: Xilin Wu --- .../bindings/display/panel/synaptics,td4328.yaml | 69 ++ 1 file changed, 6