Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Guenter Roeck
On 5/17/24 11:00, Guenter Roeck wrote: On 5/17/24 10:48, Steven Rostedt wrote: On Fri, 17 May 2024 10:36:37 -0700 Guenter Roeck wrote: Building csky:allmodconfig (and others) ... failed -- Error log: In file included from include/trace/trace_events.h:419,   from in

Re: [PATCH net-next v9 05/14] netdev: netdevice devmem allocator

2024-05-17 Thread David Wei
On 2024-05-10 16:21, Mina Almasry wrote: > +/* This returns the absolute dma_addr_t calculated from > + * net_iov_owner(niov)->owner->base_dma_addr, not the page_pool-owned > + * niov->dma_addr. > + * > + * The absolute dma_addr_t is a dma_addr_t that is always uncompressed. > + * > + * The page_po

Re: [PATCH 1/6] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-17 Thread Dr. David Alan Gilbert
(oops the patch numbering in these 3 are wrong, they're all independent patches) Dave * li...@treblig.org (li...@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > 'bridge_init' is unused, I think following: > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model") > (whi

[RFC PATCH 1/4] drm/msm: register a fault handler for display mmu faults

2024-05-17 Thread Abhinav Kumar
In preparation to register a iommu fault handler for display related modules, register a fault handler for the backing mmu object of msm_kms. Currently, the fault handler only captures the display snapshot but we can expand this later if more information needs to be added to debug display mmu faul

[RFC PATCH 2/4] drm/msm/iommu: rename msm_fault_handler to msm_gpu_fault_handler

2024-05-17 Thread Abhinav Kumar
In preparation of registering a separate fault handler for display, lets rename the existing msm_fault_handler to msm_gpu_fault_handler. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/

[RFC PATCH 3/4] drm/msm/iommu: introduce msm_iommu_disp_new() for msm_kms

2024-05-17 Thread Abhinav Kumar
Introduce a new API msm_iommu_disp_new() for display use-cases. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_iommu.c | 28 drivers/gpu/drm/msm/msm_mmu.h | 1 + 2 files changed, 29 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gp

[RFC PATCH 4/4] drm/msm: switch msm_kms to use msm_iommu_disp_new()

2024-05-17 Thread Abhinav Kumar
Switch msm_kms to use msm_iommu_disp_new() so that the newly registered fault handler will kick-in during any mmu faults. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu

[RFC PATCH 0/4] drm/msm: add a display mmu fault handler

2024-05-17 Thread Abhinav Kumar
To debug display mmu faults, this series introduces a display fault handler similar to the gpu one. This is only compile tested at the moment, till a suitable method to trigger the fault is found and see if this handler does the needful on the device. Abhinav Kumar (4): drm/msm: register a faul

[PATCH 2/3] drm/amd/display: remove unused struct 'aux_payloads'

2024-05-17 Thread linux
From: "Dr. David Alan Gilbert" 'aux_payloads' is unused since commit eae5ffa9bd7b ("drm/amd/display: Switch ddc to new aux interface") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/amd/display/dc/link/protocols/link_ddc.c | 4 1 file changed, 4 deletions(-) diff --

[PATCH 3/3] drm/amd/display: remove unused struct 'dc_reg_sequence'

2024-05-17 Thread linux
From: "Dr. David Alan Gilbert" 'dc_reg_sequence' was added in commit 44788bbc309b ("drm/amd/display: refactor reg_update") but isn't actually used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/amd/display/dc/dc_helper.c | 5 - 1 file changed, 5 deletions(-) diff

[PATCH 1/3] drm/amdgpu: remove unused struct 'hqd_registers'

2024-05-17 Thread linux
From: "Dr. David Alan Gilbert" 'hqd_registers' used to be used in a member of the 'bonaire_mqd' struct. 'bonaire_mqd' was removed by commit 486d807cd9a9 ("drm/amdgpu: remove duplicate definition of cik_mqd") It's now unused. Remove 'hqd_registers' as well. Signed-off-by: Dr. David Alan Gilbert

[PATCH 0/3] A bunch of struct removals

2024-05-17 Thread linux
From: "Dr. David Alan Gilbert" A bunch of deadcode/struct removals in drm/amd Signed-off-by: Dr. David Alan Gilbert Dr. David Alan Gilbert (3): drm/amdgpu: remove unused struct 'hqd_registers' drm/amd/display: remove unused struct 'aux_payloads' drm/amd/display: remove unused struct 'dc

[PATCH 3/6] drm/vmwgfx: remove unused struct 'vmw_stdu_dma'

2024-05-17 Thread linux
From: "Dr. David Alan Gilbert" 'vmw_stdu_dma' is unused since commit 39985eea5a6d ("drm/vmwgfx: Abstract placement selection") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/vmwgf

[PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

2024-05-17 Thread linux
From: "Dr. David Alan Gilbert" 'init_exec' is unused since commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new init table parser") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/nouveau/nouveau_bios.c | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH 1/6] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-17 Thread linux
From: "Dr. David Alan Gilbert" 'bridge_init' is unused, I think following: commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model") (which is where a git --follow finds it) Remove it. Build tested. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/bridge/analogix/analo

Re: [PATCH v5 5/8] drm/xe: Add helper to accumulate exec queue runtime

2024-05-17 Thread Matt Roper
On Fri, May 17, 2024 at 01:43:07PM -0700, Lucas De Marchi wrote: > From: Umesh Nerlige Ramappa > > Add a helper to accumulate per-client runtime of all its > exec queues. This is called every time a sched job is finished. > > v2: > - Use guc_exec_queue_free_job() and execlist_job_free() to acc

[PATCH 6/8] drm/panel: himax-hx83102: If prepare fails, disable GPIO before regulators

2024-05-17 Thread Douglas Anderson
The enable GPIO should clearly be set low before turning off regulators. That matches both the inverse order that things were enabled and also the order in unprepare(). Fixes: 0ef94554dc40 ("drm/panel: himax-hx83102: Break out as separate driver") Signed-off-by: Douglas Anderson --- drivers/gpu

[PATCH 7/8] drm/panel: himax-hx83102: Check for errors on the NOP in prepare()

2024-05-17 Thread Douglas Anderson
The mipi_dsi_dcs_nop() function returns an error but we weren't checking it in hx83102_prepare(). Add a check. This is highly unlikely to matter in practice. If the NOP failed then likely later MIPI commands would fail too. Found by code inspection. Fixes: 0ef94554dc40 ("drm/panel: himax-hx83102:

[PATCH 8/8] drm/panel: himax-hx83102: use wrapped MIPI DCS functions

2024-05-17 Thread Douglas Anderson
Take advantage of some of the new wrapped routines introduced by commit f79d6d28d8fe ("drm/mipi-dsi: wrap more functions for streamline handling") to simplify the himax-hx83102 driver a bit more. This gets rid of some extra error prints (since the _multi functions all print errors for you) and simp

[PATCH 3/8] drm/panel: boe-tv101wum-nl6: Check for errors on the NOP in prepare()

2024-05-17 Thread Douglas Anderson
The mipi_dsi_dcs_nop() function returns an error but we weren't checking it in boe_panel_prepare(). Add a check. This is highly unlikely to matter in practice. If the NOP failed then likely later MIPI commands would fail too. Found by code inspection. Fixes: 812562b8d881 ("drm/panel: boe-tv101wum

[PATCH 5/8] drm/panel: ilitek-ili9882t: Check for errors on the NOP in prepare()

2024-05-17 Thread Douglas Anderson
The mipi_dsi_dcs_nop() function returns an error but we weren't checking it in ili9882t_prepare(). Add a check. This is highly unlikely to matter in practice. If the NOP failed then likely later MIPI commands would fail too. Found by code inspection. Fixes: e2450d32e5fb ("drm/panel: ili9882t: Bre

[PATCH 4/8] drm/panel: ilitek-ili9882t: If prepare fails, disable GPIO before regulators

2024-05-17 Thread Douglas Anderson
The enable GPIO should clearly be set low before turning off regulators. That matches both the inverse order that things were enabled and also the order in unprepare(). Fixes: e2450d32e5fb ("drm/panel: ili9882t: Break out as separate driver") Signed-off-by: Douglas Anderson --- drivers/gpu/drm/

[PATCH 2/8] drm/panel: boe-tv101wum-nl6: If prepare fails, disable GPIO before regulators

2024-05-17 Thread Douglas Anderson
The enable GPIO should clearly be set low before turning off regulators. That matches both the inverse order that things were enabled and also the order in unprepare(). Fixes: a869b9db7adf ("drm/panel: support for boe tv101wum-nl6 wuxga dsi video mode panel") Signed-off-by: Douglas Anderson ---

[PATCH 1/8] drm/panel: himax-hx8394: Handle errors from mipi_dsi_dcs_set_display_on() better

2024-05-17 Thread Douglas Anderson
If mipi_dsi_dcs_set_display_on() returned an error then we'd store that in the "ret" variable and jump to error handling. We'd then attempt an orderly poweroff. Unfortunately we then blew away the value stored in "ret". That means that if the orderly poweroff actually worked then we're return 0 (no

[PATCH 0/8] drm/panel: Some very minor err handling fixes + more _multi

2024-05-17 Thread Douglas Anderson
This series is pretty much just addressing a few minor error handling bugs that I noticed recently while reviewing some panel patches. For the most part these are all old issues. This also adjusts the new himax-hx83102 in a similar way that Dmitry did in his recent series that included commit f7

Re: [RESEND v3 1/2] drm: enable (most) W=1 warnings by default across the subsystem

2024-05-17 Thread Guenter Roeck
Hi, On Tue, Mar 05, 2024 at 11:07:35AM +0200, Jani Nikula wrote: > At least the i915 and amd drivers enable a bunch more compiler warnings > than the kernel defaults. > > Extend most of the W=1 warnings to the entire drm subsystem by > default. Use the copy-pasted warnings from scripts/Makefile.e

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-17 Thread Daniel Latypov
On Fri, May 17, 2024 at 1:14 PM Andy Shevchenko wrote: > > [devarsht: Rebase to 6.9 and change license to GPL] > > I'm not sure that you may change license. It needs the author's confirmation. Checking, this is referring to the MODULE_LICENSE, which used to be MODULE_LICENSE("GPL v2"); and is no

[PATCH v5 6/8] drm/xe: Cache data about user-visible engines

2024-05-17 Thread Lucas De Marchi
gt->info.engine_mask used to indicate the available engines, but that is not always true anymore: some engines are reserved to kernel and some may be exposed as a single engine (e.g. with ccs_mode). Runtime changes only happen when no clients exist, so it's safe to cache the list of engines in the

[PATCH v5 4/8] drm/xe: Add helper to capture engine timestamp

2024-05-17 Thread Lucas De Marchi
Just like CTX_TIMESTAMP is used to calculate runtime, add a helper to get the timestamp for the engine so it can be used to calculate the "engine time" with the same unit as the runtime is recorded. Reviewed-by: Umesh Nerlige Ramappa Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/xe_hw_e

[PATCH v5 7/8] drm/xe: Add helper to return any available hw engine

2024-05-17 Thread Lucas De Marchi
Get the first available engine from a gt, which helps in the case any engine serves as a context, like when reading RING_TIMESTAMP. Reviewed-by: Umesh Nerlige Ramappa Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/xe_gt.c | 11 +++ drivers/gpu/drm/xe/xe_gt.h | 7 +++ 2 files

[PATCH v5 5/8] drm/xe: Add helper to accumulate exec queue runtime

2024-05-17 Thread Lucas De Marchi
From: Umesh Nerlige Ramappa Add a helper to accumulate per-client runtime of all its exec queues. This is called every time a sched job is finished. v2: - Use guc_exec_queue_free_job() and execlist_job_free() to accumulate runtime when job is finished since xe_sched_job_completed() is not

[PATCH v5 3/8] drm/xe/lrc: Add helper to capture context timestamp

2024-05-17 Thread Lucas De Marchi
From: Umesh Nerlige Ramappa Add a helper to capture CTX_TIMESTAMP from the context image so it can be used to calculate the runtime. v2: Add kernel-doc to clarify expectation from caller Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Francois Dugast Signed-off-by: Lucas De Marchi --- dri

[PATCH v5 2/8] drm/xe: Add XE_ENGINE_CLASS_OTHER to str conversion

2024-05-17 Thread Lucas De Marchi
XE_ENGINE_CLASS_OTHER was missing from the str conversion. Add it and remove the default handling so it's protected by -Wswitch. Currently the only user is xe_hw_engine_class_sysfs_init(), which already skips XE_ENGINE_CLASS_OTHER, so there's no change in behavior. Reviewed-by: Nirmoy Das Signed-

[PATCH v5 1/8] drm/xe: Promote xe_hw_engine_class_to_str()

2024-05-17 Thread Lucas De Marchi
Move it out of the sysfs compilation unit so it can be re-used in other places. Reviewed-by: Nirmoy Das Reviewed-by: Oak Zeng Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/xe_hw_engine.c | 18 ++ drivers/gpu/drm/xe/xe_hw_engine.h | 2 ++ drivers

[PATCH v5 0/8] drm/xe: Per client usage

2024-05-17 Thread Lucas De Marchi
v5 of of https://lore.kernel.org/all/20240515214258.59209-1-lucas.demar...@intel.com Add per-client usage statistics to xe. This ports xe to use the common method in drm to export the usage to userspace per client (where 1 client == 1 drm fd open). However instead of using the current format mea

[PATCH v5 8/8] drm/xe/client: Print runtime to fdinfo

2024-05-17 Thread Lucas De Marchi
Print the accumulated runtime for client when printing fdinfo. Each time a query is done it first does 2 things: 1) loop through all the exec queues for the current client and accumulate the runtime, per engine class. CTX_TIMESTAMP is used for that, being read from the context image. 2) Rea

Re: [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core

2024-05-17 Thread Rob Herring
On Wed, May 15, 2024 at 04:47:05PM +0300, Laurent Pinchart wrote: > Hi Marek, > > Thank you for the patch. > > On Wed, May 15, 2024 at 08:27:44AM +0200, Marek Vasut wrote: > > The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' > > property, > > move the property description int

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 1:27 PM Tim Van Patten wrote: > > > Fair enough, but this is also the only gfx9 APU which defaults to > > noretry=1, all of the rest are dGPUs. I'd argue it should align with > > the other GFX9 APUs or they should all enable noretry=1. > > Do you mean we should remove all

Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-17 Thread Andy Shevchenko
On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote: > From: Daniel Latypov > > Add basic test coverage for files that don't require any config options: > * part of math.h (what seem to be the most commonly used macros) > * gcd.c > * lcm.c > * int_sqrt.c > * reciprocal_div.c > (Ignore

Re: [PATCH 2/2] drm/i915: Don't treat FLR resets as errors

2024-05-17 Thread Nirmoy Das
Hi Andi, On 5/17/2024 9:34 PM, Andi Shyti wrote: Hi Nirmoy, On Fri, May 17, 2024 at 04:00:02PM +0200, Nirmoy Das wrote: On 5/17/2024 1:25 PM, Andi Shyti wrote: If we timeout while waiting for an FLR reset, there is nothing we can do and i915 doesn't have any control on it. In any case the sys

Re: [PATCH v3 0/2] Fix Kernel CI issues

2024-05-17 Thread Jakub Kicinski
On Fri, 3 May 2024 20:25:49 +0300 Tomi Valkeinen wrote: > > I think the second patch also needs to go to drm-misc-next-fixes? The > > clang warning fixed by it has returned in next-20240503 because it > > appears that for-linux-next was switch from drm-misc-next to > > drm-misc-next-fixes, as I see

[PATCH] drm/msm/adreno: Check for zap node availability

2024-05-17 Thread Rob Clark
From: Rob Clark This should allow disabling the zap node via an overlay, for slbounce. Suggested-by: Nikita Travkin Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c

Re: [PATCH v2 0/7] drm/mipi-dsi: simplify MIPI DSI init/cleanup even more

2024-05-17 Thread Neil Armstrong
Hi, On Sun, 12 May 2024 02:00:17 +0300, Dmitry Baryshkov wrote: > Follow the example of mipi_dsi_generic_write_multi(), > mipi_dsi_dcs_write_buffer_multi(), mipi_dsi_generic_write_seq_multi() > and mipi_dsi_dcs_write_seq_multi(). Define _multi variants for several > other common MIPI DSI functions

Re: [PATCH 2/2] drm/i915: Don't treat FLR resets as errors

2024-05-17 Thread Andi Shyti
Hi Nirmoy, On Fri, May 17, 2024 at 04:00:02PM +0200, Nirmoy Das wrote: > On 5/17/2024 1:25 PM, Andi Shyti wrote: > > If we timeout while waiting for an FLR reset, there is nothing we > > can do and i915 doesn't have any control on it. In any case the > > system is still perfectly usable > > If a

Re: [PATCH v2 2/7] drm/mipi-dsi: wrap more functions for streamline handling

2024-05-17 Thread Neil Armstrong
On 12/05/2024 01:00, Dmitry Baryshkov wrote: Follow the pattern of mipi_dsi_dcs_*_multi() and wrap several existing MIPI DSI functions to use the context for processing. This simplifies and streamlines driver code to use simpler code pattern. Note, msleep function is also wrapped in this way as

Re: [git pull] drm urgent for 6.10-rc1

2024-05-17 Thread Linus Torvalds
On Fri, 17 May 2024 at 06:55, Alex Deucher wrote: > > Can you try this patch? > https://patchwork.freedesktop.org/patch/594539/ Ack. This seems to fix it for me - unless the problem is random and only happens sometimes, and I've just been *very* unlucky until now. Linus

Re: [git pull] drm urgent for 6.10-rc1

2024-05-17 Thread Linus Torvalds
On Thu, 16 May 2024 at 18:08, Dave Airlie wrote: > > Linus, do you see it a boot straight away? Ok, back at that computer now, and yes, I see those messages right away. In fact, they seem to happen before gnome even starts up, ie I see those messages long before the first messages from gnome-sess

[PATCH v2 4/4] drm/vmwgfx: Standardize use of kibibytes when logging

2024-05-17 Thread Ian Forbes
Use the same standard abbreviation KiB instead of incorrect variants. Signed-off-by: Ian Forbes --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 12 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu

[PATCH v2 3/4] drm/vmwgfx: Remove STDU logic from generic mode_valid function

2024-05-17 Thread Ian Forbes
STDU has its own mode_valid function now so this logic can be removed from the generic version. Fixes: 935f795045a6 ("drm/vmwgfx: Refactor drm connector probing for display modes") Signed-off-by: Ian Forbes --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 3 --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |

[PATCH v2 2/4] drm/vmwgfx: 3D disabled should not effect STDU memory limits

2024-05-17 Thread Ian Forbes
This limit became a hard cap starting with the change referenced below. Surface creation on the device will fail if the requested size is larger than this limit so altering the value arbitrarily will expose modes that are too large for the device's hard limits. Fixes: 7ebb47c9f9ab ("drm/vmwgfx: Re

[PATCH v2 1/4] drm/vmwgfx: Filter modes which exceed graphics memory

2024-05-17 Thread Ian Forbes
SVGA requires individual surfaces to fit within graphics memory (max_mob_pages) which means that modes with a final buffer size that would exceed graphics memory must be pruned otherwise creation will fail. Additionally llvmpipe requires its buffer height and width to be a multiple of its tile siz

[PATCH v2 0/4] Fix memory limits for STDU

2024-05-17 Thread Ian Forbes
Fixes a bug where modes that are too large for the device are exposed and set causing a black screen on boot. v2: Fixed llvmpipe over-alignment bug. Ian Forbes (4): drm/vmwgfx: Filter modes which exceed graphics memory drm/vmwgfx: 3D disabled should not effect STDU memory limits drm/vmwgfx:

Re: [PATCH v9] drm/bridge: it6505: This patch fixes hibernate to resume no display issue

2024-05-17 Thread Markus Elfring
Please omit the word combination “This patch” from the summary phrase. … > But the input FIFO reset will also trigger error interrupts of output > module rising.Thus, it6505 have to wait a period can clear those > expected error interrupts caused by manual hardware reset in one > interrupt handle

Re: [PATCH v3 0/2] drm: Fix dma_resv deadlock at drm object pin time

2024-05-17 Thread Adrián Larumbe
Hi Boris and Thomas, On 02.05.2024 14:18, Thomas Zimmermann wrote: > Hi > > Am 02.05.24 um 14:00 schrieb Boris Brezillon: > > On Thu, 2 May 2024 13:59:41 +0200 > > Boris Brezillon wrote: > > > > > Hi Thomas, > > > > > > On Thu, 2 May 2024 13:51:16 +0200 > > > Thomas Zimmermann wrote: > > > >

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Guenter Roeck
On 5/17/24 10:48, Steven Rostedt wrote: On Fri, 17 May 2024 10:36:37 -0700 Guenter Roeck wrote: Building csky:allmodconfig (and others) ... failed -- Error log: In file included from include/trace/trace_events.h:419, from include/trace/define_trace.h:102,

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Steven Rostedt
On Fri, 17 May 2024 10:36:37 -0700 Guenter Roeck wrote: > Building csky:allmodconfig (and others) ... failed > -- > Error log: > In file included from include/trace/trace_events.h:419, > from include/trace/define_trace.h:102, > from drivers/cxl/core/t

[PATCH v8 10/10] gpu: ipu-v3: Use generic macro for rounding closest to specified value

2024-05-17 Thread Devarsh Thakkar
Use generic macro round_closest_up() for rounding closest to specified value instead of using local macro round_closest(). There is no change from functionality point of view as round_closest_up() is functionally same as the previously used local macro round_closest(). Signed-off-by: Devarsh Thak

[PATCH v8 09/10] media: imagination: Round to closest multiple for cropping region

2024-05-17 Thread Devarsh Thakkar
If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest multiple of requested value while updating the crop rectangle coordinates. Use the rounding macro which gives preference to rounding down in case two nearest val

[PATCH v8 08/10] lib: math_kunit: Add tests for new rounding related macros

2024-05-17 Thread Devarsh Thakkar
Add tests for round_closest_up/down and roundclosest macros which round to nearest multiple of specified argument. These are tested with kunit tool as shared here [1]. [1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 Signed-off-by: Devarsh Thakkar --- V1->V8 (No change, pat

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Guenter Roeck
On Thu, May 16, 2024 at 01:34:54PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.10 and submit it then. Hoping >to keep the conflicts that it will

[PATCH v8 07/10] lib: add basic KUnit test for lib/math

2024-05-17 Thread Devarsh Thakkar
From: Daniel Latypov Add basic test coverage for files that don't require any config options: * part of math.h (what seem to be the most commonly used macros) * gcd.c * lcm.c * int_sqrt.c * reciprocal_div.c (Ignored int_pow.c since it's a simple textbook algorithm.) These tests aren't particular

[PATCH v8 06/10] math.h: Add macros for rounding to closest value

2024-05-17 Thread Devarsh Thakkar
Add below rounding related macros: round_closest_up(x, y) : Rounds x to closest multiple of y where y is a power of 2, with a preference to round up in case two nearest values are possible. round_closest_down(x, y) : Rounds x to closest multiple of y where y is a power of 2, with a preference to

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Tim Van Patten
> Fair enough, but this is also the only gfx9 APU which defaults to > noretry=1, all of the rest are dGPUs. I'd argue it should align with > the other GFX9 APUs or they should all enable noretry=1. Do you mean we should remove all IP_VERSION(9, X, X) entries from amdgpu_gmc_noretry_set(), leaving

[PATCH v8 00/10] Add V4L2 M2M Driver for E5010 JPEG Encoder

2024-05-17 Thread Devarsh Thakkar
This adds support for V4L2 M2M based driver for E5010 JPEG Encoder which is a stateful JPEG encoder from Imagination technologies and is present in TI AM62A SoC. While adding support for it, following additional framework changes were made: - Moved reference quantization and huffman tables provid

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Dave, Please help pull this patch into drm-next. This will fix any unnecessary warnings in memory pressure situation. Thanks for the help. Regards, Arun. On 5/17/2024 8:03 PM, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessaril

Re: [PATCH v4 3/8] drm/xe/lrc: Add helper to capture context timestamp

2024-05-17 Thread Francois Dugast
On Wed, May 15, 2024 at 02:42:53PM -0700, Lucas De Marchi wrote: > From: Umesh Nerlige Ramappa > > Add a helper to capture CTX_TIMESTAMP from the context image so it can > be used to calculate the runtime. > > v2: Add kernel-doc to clarify expectation from caller > > Signed-off-by: Umesh Nerlig

[PATCH v2 2/3] drm/print: Improve drm_dbg_printer

2024-05-17 Thread Michal Wajdeczko
With recent introduction of a generic drm dev printk function, we can now store and use location where drm_dbg_printer was invoked and output it's symbolic name like we do for all drm debug prints. Cc: Jani Nikula Reviewed-by: Jani Nikula Signed-off-by: Michal Wajdeczko --- v2: use full cast to

[PATCH v2 3/3] drm/i915: Don't use __func__ as prefix for drm_dbg_printer

2024-05-17 Thread Michal Wajdeczko
Updated code of drm_dbg_printer() is already printing symbolic name of the caller like drm_dbg() does. Reviewed-by: Jani Nikula Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/intel_reset.c | 2 +- drivers/gpu/drm/i915/gt/selftest_context.c | 2 +- 2 files changed, 2 insertions

[PATCH v2 0/3] Improve drm printer code

2024-05-17 Thread Michal Wajdeczko
We already have some drm printk functions that need to duplicate a code to get a similar format of the final result, for example: [ ] :00:00.0: [drm:foo] bar [ ] :00:00.0: [drm] foo bar [ ] :00:00.0: [drm] *ERROR* foo Add a generic __drm_dev_vprintk() function that can format th

[PATCH v2 1/3] drm/print: Add generic drm dev printk function

2024-05-17 Thread Michal Wajdeczko
We already have some drm printk functions that need to duplicate a code to get a similar format of the final result, for example: [ ] :00:00.0: [drm:foo] bar [ ] :00:00.0: [drm] foo bar [ ] :00:00.0: [drm] *ERROR* foo Add a generic __drm_dev_vprintk() function that can format th

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Darrick J. Wong
On Thu, May 16, 2024 at 01:34:54PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.10 and submit it then. Hoping >to keep the conflicts that it will

Re: [PATCH v6 0/7] Adds support for ConfigFS to VKMS!

2024-05-17 Thread Louis Chauvet
> > > Hi Louis, > > > > > > If you could share a RFC/WIP series it would be awesome! Hi all! I just uploaded my WIP series to github here [1]. Most of the work is extracted from the current ConfigFS series, I just splitted and completed what was done. I also tried to take in account the commen

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 2:35 AM Christian König wrote: > > Am 16.05.24 um 19:57 schrieb Tim Van Patten: > > From: Tim Van Patten > > > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > > 9.3.0: > > > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > > >

Re: [PATCH 1/3] drm/print: Add generic drm dev printk function

2024-05-17 Thread Michal Wajdeczko
On 17.05.2024 15:33, Jani Nikula wrote: > On Fri, 17 May 2024, Michal Wajdeczko wrote: >> We already have some drm printk functions that need to duplicate >> a code to get a similar format of the final result, for example: >> >> [ ] :00:00.0: [drm:foo] bar >> [ ] :00:00.0: [drm] foo

Re: [PATCH] drm/edid: add non-desktop quirk to Bigscreen Beyond HMD

2024-05-17 Thread Sefa Eyeoglu
On Fri, 2024-05-17 at 16:52 +0200, Philipp Zabel wrote: > On Fr, 2024-05-17 at 16:09 +0200, Sefa Eyeoglu wrote: > > The Bigscreen Beyond VR headset is a non-desktop output and should > > be > > marked as such using an EDID quirk. > > > > Closes https://gitlab.freedesktop.org/drm/misc/kernel/-/issu

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Tim Van Patten
On Fri, May 17, 2024 at 12:35 AM Christian König wrote: > > Am 16.05.24 um 19:57 schrieb Tim Van Patten: > > From: Tim Van Patten > > > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > > 9.3.0: > > > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > >

Re: [PATCH v2 2/2] drm/mgag200: Add an option to disable Write-Combine

2024-05-17 Thread Thomas Zimmermann
Hi Am 17.05.24 um 17:09 schrieb Jocelyn Falempe: Unfortunately, the G200 ioburst workaround doesn't work on some servers like Dell poweredge XR11, XR5610, or HPE XL260. In this case completely disabling WC is the only option to achieve low-latency. So this adds a new Kconfig option to disable WC

[PATCH v2 2/2] drm/mgag200: Add an option to disable Write-Combine

2024-05-17 Thread Jocelyn Falempe
Unfortunately, the G200 ioburst workaround doesn't work on some servers like Dell poweredge XR11, XR5610, or HPE XL260. In this case completely disabling WC is the only option to achieve low-latency. So this adds a new Kconfig option to disable WC mapping of the G200. Signed-off-by: Jocelyn Falemp

[PATCH v2 1/2] Revert "drm/mgag200: Add a workaround for low-latency"

2024-05-17 Thread Jocelyn Falempe
This reverts commit bfa4437fd3938ae2e186e7664b2db65bb8775670. This workaround doesn't work reliably on all servers. I'll replace it with an option to disable Write-Combine, which has more impact on performance, but fix the latency issue on all hardware. Signed-off-by: Jocelyn Falempe Reviewed-by

[PATCH v2 0/2] drm/mgag200: Add an option to disable Write-Combine

2024-05-17 Thread Jocelyn Falempe
Unfortunately, the G200 ioburst workaround doesn't work on some servers like Dell poweredge XR11, XR5610, or HPE XL260 In this case completely disabling WC is the only option to achieve low-latency. It's probably useless to maintain two workarounds for this, so I reverted commit bfa4437fd3938 drm/m

Re: [PATCH 2/2] drm/mgag200: Add an option to disable Write-Combine

2024-05-17 Thread Jocelyn Falempe
On 17/05/2024 11:39, Thomas Zimmermann wrote: Hi, just nits below. Am 16.05.24 um 18:17 schrieb Jocelyn Falempe: Unfortunately, the G200 ioburst workaround doesn't work on some servers like Dell poweredge XR11, XR5610, or HPE XL260 In this case completely disabling WC is the only option to

Re: [PATCH] drm/edid: add non-desktop quirk to Bigscreen Beyond HMD

2024-05-17 Thread Philipp Zabel
On Fr, 2024-05-17 at 16:09 +0200, Sefa Eyeoglu wrote: > The Bigscreen Beyond VR headset is a non-desktop output and should be > marked as such using an EDID quirk. > > Closes https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/39 >From the EDID posted there, it looks like the quirk should not

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
On 5/17/2024 7:30 PM, Matthew Auld wrote: On 17/05/2024 14:50, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge call

[PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Arunpravin Paneer Selvam
Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge call. v2:(Matthew) - Move the fallback and block incompatible checks above the contains check. Si

Re: [PATCH] drm/edid: add non-desktop quirk to Bigscreen Beyond HMD

2024-05-17 Thread Sefa Eyeoglu
Hi Jani, I have just just posted a modified patch with a link to the issue. Best, Sefa On Fri, 2024-05-17 at 15:54 +0300, Jani Nikula wrote: > On Fri, 17 May 2024, Sefa Eyeoglu wrote: > > The Bigscreen Beyond VR headset is a non-desktop output and should > > be > > marked as such using an EDID

[PATCH] drm/edid: add non-desktop quirk to Bigscreen Beyond HMD

2024-05-17 Thread Sefa Eyeoglu
The Bigscreen Beyond VR headset is a non-desktop output and should be marked as such using an EDID quirk. Closes https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/39 Signed-off-by: Sefa Eyeoglu --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/g

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Matthew Auld
On 17/05/2024 14:50, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge call. v2:(Matthew) - Move the fallback and blo

Re: [PATCH 2/2] drm/i915: Don't treat FLR resets as errors

2024-05-17 Thread Nirmoy Das
Hi Andi, On 5/17/2024 1:25 PM, Andi Shyti wrote: If we timeout while waiting for an FLR reset, there is nothing we can do and i915 doesn't have any control on it. In any case the system is still perfectly usable If a FLR reset fails then we will have a dead GPU, I don't think the GPU is usabl

Re: [git pull] drm urgent for 6.10-rc1

2024-05-17 Thread Alex Deucher
On Thu, May 16, 2024 at 2:02 PM Linus Torvalds wrote: > > On Wed, 15 May 2024 at 19:54, Dave Airlie wrote: > > > > Here is the buddy allocator fix I picked up from the list, please apply. > > So I removed my reverts, and am running a kernel that includes the > merge 972a2543e3dd ("Merge tag 'drm-

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Matthew, This fixes the problem. Regards, Arun. On 5/17/2024 7:20 PM, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_me

Re: [PATCH] arch: Fix name collision with ACPI's video.o

2024-05-17 Thread Hans de Goede
Hi, On 5/17/24 11:14 AM, Thomas Zimmermann wrote: > Commit 2fd001cd3600 ("arch: Rename fbdev header and source files") > renames the video source files under arch/ such that they do not > refer to fbdev any longer. The new files named video.o conflict with > ACPI's video.ko module. Modprobing the

[PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Arunpravin Paneer Selvam
Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge call. v2:(Matthew) - Move the fallback and block incompatible checks above the contains check. Si

Re: [RFC v2 0/2] Discussion around eviction improvements

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 3:41 AM Tvrtko Ursulin wrote: > > > On 16/05/2024 20:21, Alex Deucher wrote: > > On Thu, May 16, 2024 at 8:18 AM Tvrtko Ursulin wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Reduced re-spin of my previous series after Christian corrected a few > >> misconceptions that I

Re: [PATCH 3/3] drm/i915: Don't use __func__ as prefix for drm_dbg_printer

2024-05-17 Thread Jani Nikula
On Fri, 17 May 2024, Michal Wajdeczko wrote: > Updated code of drm_dbg_printer() is already printing symbolic > name of the caller like drm_dbg() does. > > Signed-off-by: Michal Wajdeczko Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/gt/intel_reset.c | 2 +- > drivers/gpu/drm/i91

Re: [PATCH 2/3] drm/print: Improve drm_dbg_printer

2024-05-17 Thread Jani Nikula
On Fri, 17 May 2024, Michal Wajdeczko wrote: > With recent introduction of a generic drm dev printk function, we > can now store and use location where drm_dbg_printer was invoked > and output it's symbolic name like we do for all drm debug prints. > > Signed-off-by: Michal Wajdeczko > Cc: Jani N

Re: [PATCH 1/3] drm/print: Add generic drm dev printk function

2024-05-17 Thread Jani Nikula
On Fri, 17 May 2024, Michal Wajdeczko wrote: > We already have some drm printk functions that need to duplicate > a code to get a similar format of the final result, for example: > > [ ] :00:00.0: [drm:foo] bar > [ ] :00:00.0: [drm] foo bar > [ ] :00:00.0: [drm] *ERROR* foo > > A

[PATCH 3/3] drm/i915: Don't use __func__ as prefix for drm_dbg_printer

2024-05-17 Thread Michal Wajdeczko
Updated code of drm_dbg_printer() is already printing symbolic name of the caller like drm_dbg() does. Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/gt/intel_reset.c | 2 +- drivers/gpu/drm/i915/gt/selftest_context.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/3] drm/print: Improve drm_dbg_printer

2024-05-17 Thread Michal Wajdeczko
With recent introduction of a generic drm dev printk function, we can now store and use location where drm_dbg_printer was invoked and output it's symbolic name like we do for all drm debug prints. Signed-off-by: Michal Wajdeczko Cc: Jani Nikula --- drivers/gpu/drm/drm_print.c | 3 +-- include/

[PATCH 1/3] drm/print: Add generic drm dev printk function

2024-05-17 Thread Michal Wajdeczko
We already have some drm printk functions that need to duplicate a code to get a similar format of the final result, for example: [ ] :00:00.0: [drm:foo] bar [ ] :00:00.0: [drm] foo bar [ ] :00:00.0: [drm] *ERROR* foo Add a generic __drm_dev_vprintk() function that can format th

[PATCH 0/3] Improve drm printer code

2024-05-17 Thread Michal Wajdeczko
We already have some drm printk functions that need to duplicate a code to get a similar format of the final result, for example: [ ] :00:00.0: [drm:foo] bar [ ] :00:00.0: [drm] foo bar [ ] :00:00.0: [drm] *ERROR* foo Add a generic __drm_dev_vprintk() function that can format th

  1   2   >