Re: [PATCH v6,17/24] media: mediatek: vcodec: re-construct h264 driver to support svp mode

2024-05-26 Thread Chen-Yu Tsai
On Thu, May 16, 2024 at 8:21 PM Yunfei Dong wrote: > > Need secure buffer size to convert secure handle to secure > pa in optee-os, re-construct the vsi struct to store each > secure buffer size. > > Separate svp and normal wait interrupt condition for svp mode > waiting hardware interrupt in

Re: [PATCH v7 05/18] drm/mediatek: Set DRM mode configs accordingly

2024-05-26 Thread Chen-Yu Tsai
On Mon, May 27, 2024 at 12:54 PM Fei Shao wrote: > > On Mon, May 27, 2024 at 12:38 PM Chen-Yu Tsai wrote: > > > > On Mon, May 27, 2024 at 12:34 PM Fei Shao wrote: > > > > > > Hi Shawn, > > > > > > On Thu, May 2, 2024 at 6:39 PM Shawn Sung wrote: > > > > > > > > From: Hsiao Chien Sung > > > >

Re: [PATCH RESEND, v6 2/8] dt-bindings: mailbox: Add property for CMDQ secure driver

2024-05-26 Thread 林睿祥

Re: [PATCH RESEND, v6 6/8] mailbox: mediatek: Add CMDQ secure mailbox driver

2024-05-26 Thread 林睿祥

Re: [PATCH v7 05/18] drm/mediatek: Set DRM mode configs accordingly

2024-05-26 Thread Fei Shao
On Mon, May 27, 2024 at 12:38 PM Chen-Yu Tsai wrote: > > On Mon, May 27, 2024 at 12:34 PM Fei Shao wrote: > > > > Hi Shawn, > > > > On Thu, May 2, 2024 at 6:39 PM Shawn Sung wrote: > > > > > > From: Hsiao Chien Sung > > > > > > Set DRM mode configs limitation according to the hardware

Re: [PATCH v7 05/18] drm/mediatek: Set DRM mode configs accordingly

2024-05-26 Thread Chen-Yu Tsai
On Mon, May 27, 2024 at 12:34 PM Fei Shao wrote: > > Hi Shawn, > > On Thu, May 2, 2024 at 6:39 PM Shawn Sung wrote: > > > > From: Hsiao Chien Sung > > > > Set DRM mode configs limitation according to the hardware capabilities > > and pass the IGT checks as below: > > > > - The test

Re: [PATCH v7 05/18] drm/mediatek: Set DRM mode configs accordingly

2024-05-26 Thread Fei Shao
Hi Shawn, On Thu, May 2, 2024 at 6:39 PM Shawn Sung wrote: > > From: Hsiao Chien Sung > > Set DRM mode configs limitation according to the hardware capabilities > and pass the IGT checks as below: > > - The test "graphics.IgtKms.kms_plane" requires a frame buffer with > width of 4512 pixels

Re: [PATCH RESEND, v6 6/8] mailbox: mediatek: Add CMDQ secure mailbox driver

2024-05-26 Thread 胡俊光

Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value

2024-05-26 Thread patchwork-bot+chrome-platform
Hello: This patch was applied to chrome-platform/linux.git (for-next) by Chun-Kuang Hu : On Wed, 17 Apr 2024 10:38:19 + you wrote: > In case there is no DP device attached to the port the > transfer function should return IO error, similar to what > other drivers do. > In case EAGAIN is

Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value

2024-05-26 Thread patchwork-bot+chrome-platform
Hello: This patch was applied to chrome-platform/linux.git (for-kernelci) by Chun-Kuang Hu : On Wed, 17 Apr 2024 10:38:19 + you wrote: > In case there is no DP device attached to the port the > transfer function should return IO error, similar to what > other drivers do. > In case EAGAIN is

Re: [PATCH v6 02/10] drm/bridge: Set firmware node of drm_bridge instances automatically

2024-05-26 Thread Sui Jingfeng
Hi, On 5/27/24 07:33, kernel test robot wrote: Hi Sui, kernel test robot noticed the following build errors: [auto build test ERROR on drm-exynos/exynos-drm-next] [also build test ERROR on linus/master v6.10-rc1 next-20240523] [cannot apply to shawnguo/for-next] [If your patch is applied to

Re: [PATCH v6 02/10] drm/bridge: Set firmware node of drm_bridge instances automatically

2024-05-26 Thread Sui Jingfeng
Hi, On 5/27/24 05:19, Dmitry Baryshkov wrote: On Mon, May 27, 2024 at 04:21:07AM +0800, Sui Jingfeng wrote: Normally, the drm_bridge::of_node won't be used by bridge driver instances themselves. Rather, it is mainly used by other modules to find associated drm bridge drvier. Therefore, adding

[PATCH] drm/radeon/r100: enhance error handling in r100_cp_init_microcode

2024-05-26 Thread Zhouyi Zhou
In r100_cp_init_microcode, if rdev->family don't match any of if statement, fw_name will be NULL, which will cause gcc (11.4.0 powerpc64le-linux-gnu) complain: In function ‘r100_cp_init_microcode’, inlined from ‘r100_cp_init’ at drivers/gpu/drm/radeon/r100.c:1136:7:

Re: [PATCH v6 02/10] drm/bridge: Set firmware node of drm_bridge instances automatically

2024-05-26 Thread kernel test robot
Hi Sui, kernel test robot noticed the following build errors: [auto build test ERROR on drm-exynos/exynos-drm-next] [also build test ERROR on linus/master v6.10-rc1 next-20240523] [cannot apply to shawnguo/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v6 02/10] drm/bridge: Set firmware node of drm_bridge instances automatically

2024-05-26 Thread Dmitry Baryshkov
On Mon, May 27, 2024 at 04:21:07AM +0800, Sui Jingfeng wrote: > Normally, the drm_bridge::of_node won't be used by bridge driver instances > themselves. Rather, it is mainly used by other modules to find associated > drm bridge drvier. Therefore, adding a drm bridge to the global bridge list > and

Re: [PATCH v2 1/3] drm/loongson: Add a helper for creating child devices

2024-05-26 Thread Dmitry Baryshkov
On Mon, May 27, 2024 at 03:58:24AM +0800, Sui Jingfeng wrote: > In some display subsystems, the functionality of a PCIe device may too > complex to be managed by a single driver. A split of the functionality > into child devices can helpful to achieve better modularity. > > Another benefit is

[Bug 218891] In function ‘dcn321_update_bw_bounding_box’ - warning: the frame size of 1336 bytes is larger than 1280 bytes

2024-05-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218891 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

[PATCH v6 10/10] drm/bridge: ch7033: Switch to use fwnode based APIs

2024-05-26 Thread Sui Jingfeng
Use the freshly created helper to replace the use of DT-dependent APIs, also print error log if the fwnode graph is not complete which is benefit to debug. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/chrontel-ch7033.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)

[PATCH v6 08/10] drm/bridge: tfp410: Use fwnode APIs to acquire device properties

2024-05-26 Thread Sui Jingfeng
Make this driver less DT-dependent by calling the newly created helpers, also switch to use fwnode APIs to acquire additional device properties. No functional changes for DT-based systems. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ti-tfp410.c | 39 +++--- 1

[PATCH v6 09/10] drm/bridge: sii9234: Use fwnode APIs to abstract DT dependent API away

2024-05-26 Thread Sui Jingfeng
Switch to use the freshly created drm_bridge_set_node() helper, no functional changes. The reason behind of this introduction is that the name 'of_node' itself has a smell of DT dependent, and it is a internal memeber, when there has helper function, we should use the revelant helper and avoid

[PATCH v6 07/10] drm-bridge: it66121: Use fwnode APIs to acquire device properties

2024-05-26 Thread Sui Jingfeng
Make this driver less DT-dependent by calling the newly created helpers, also switch to use fwnode APIs to acquire additional device properties. A side benifit is that boilerplates get reduced, no functional changes for DT-based systems. Signed-off-by: Sui Jingfeng ---

[PATCH v6 06/10] drm/bridge: sii902x: Switch to use fwnode APIs to acquire device properties

2024-05-26 Thread Sui Jingfeng
Make this driver less DT-dependent by calling the freshly created helpers, also switch to use fwnode APIs to acquire additional device properties. One side benifit is that boilerplates get reduced, no functional changes for DT-based systems. Signed-off-by: Sui Jingfeng ---

[PATCH v6 05/10] drm/bridge: display-connector: Use fwnode APIs to acquire device properties

2024-05-26 Thread Sui Jingfeng
Switch to use the fwnode APIs, which is a fundamental step to make this driver OF-independent possible. No functional changes for DT-based systems. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/display-connector.c | 23 +++--- 1 file changed, 11 insertions(+), 12

[PATCH v6 02/10] drm/bridge: Set firmware node of drm_bridge instances automatically

2024-05-26 Thread Sui Jingfeng
Normally, the drm_bridge::of_node won't be used by bridge driver instances themselves. Rather, it is mainly used by other modules to find associated drm bridge drvier. Therefore, adding a drm bridge to the global bridge list and setting 'of_node' field of a drm bridge share the same goal. Both are

[PATCH v6 04/10] drm/bridge: simple-bridge: Use fwnode APIs to acquire device properties

2024-05-26 Thread Sui Jingfeng
Make this driver less DT-dependent by calling the newly created helpers, also switch to use fwnode APIs to acquire additional device properties. A side benifit is that boilerplates get reduced, no functional changes for DT-based systems. Signed-off-by: Sui Jingfeng ---

[PATCH v6 03/10] drm/bridge: Implement of_drm_find_bridge() on the top of drm_bridge_find_by_fwnode()

2024-05-26 Thread Sui Jingfeng
Before applying this patch, people may worry about the OF and non-OF API will have a risk to diverge. Eliminate the risk by reimplement the of_drm_find_bridge() on the top of drm_bridge_find_by_fwnode(). As for now the fundamental searching method is unique. Signed-off-by: Sui Jingfeng ---

[PATCH v6 01/10] drm/bridge: Allow using fwnode APIs to get the next bridge

2024-05-26 Thread Sui Jingfeng
The various display bridge drivers rely on 'OF' infrastructures to works very well, yet there are some platforms and/or devices lack of 'OF' support. Such as virtual display drivers, USB display apapters and ACPI based systems etc. Add fwnode based helpers to fill the niche, this allows part of

[PATCH v6 00/10] drm/bridge: Allow using fwnode API to get the next bridge

2024-05-26 Thread Sui Jingfeng
Currently, the various display bridge drivers rely on OF infrastructures to works very well, yet there are platforms and/or devices absence of 'OF' support. Such as virtual display drivers, USB display apapters and ACPI based systems etc. Add fwnode based helpers to fill the niche, this allows

[PATCH v2 3/3] drm/loongson: Add dummy gpu driver as a subcomponent

2024-05-26 Thread Sui Jingfeng
Loongson Graphics are PCIe multi-functional devices, the GPU device and the display controller are two distinct devices. Drivers of them should loose coupling, but still be able to works togather to provide a unified service to userspace. Add a dummy driver for the GPU, it functional as a

[PATCH v2 2/3] drm/loongson: Introduce component framework support

2024-05-26 Thread Sui Jingfeng
Hardware units come with PCIe are actually all ready to be driven, but there has some board specific modules could return '-EPROBE_DEFER'. However, the driver needs all of the subcompoments ready to use before it can register the drm service to userspace. Introduce the component framework to

[PATCH v2 1/3] drm/loongson: Add a helper for creating child devices

2024-05-26 Thread Sui Jingfeng
In some display subsystems, the functionality of a PCIe device may too complex to be managed by a single driver. A split of the functionality into child devices can helpful to achieve better modularity. Another benefit is that we could migrate the dependency on exterinal modules to a submodule

[PATCH v2 0/3] drm/loongson: Introduce component framework support

2024-05-26 Thread Sui Jingfeng
Introduce component framework to bind child and sibling devices, for better modularity and offload the deferral probe issue to submodule if it need to attach exterinal module someday. Also for better reflect the hardware layout. Hardware units that come with PCIe are all ready to drive, but there

[PATCH v9 10/10] gpu: ipu-v3: Use generic macro for rounding closest to specified value

2024-05-26 Thread Devarsh Thakkar
Use generic macro round_closest_up() for rounding closest to specified value instead of using local macro round_closest(). There is no change from functionality point of view as round_closest_up() is functionally same as the previously used local macro round_closest(). Signed-off-by: Devarsh

[PATCH v9 09/10] media: imagination: Round to closest multiple for cropping region

2024-05-26 Thread Devarsh Thakkar
If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest multiple of requested value while updating the crop rectangle coordinates. Use the rounding macro which gives preference to rounding down in case two nearest

[PATCH v9 08/10] lib: math_kunit: Add tests for new macros related to rounding to nearest value

2024-05-26 Thread Devarsh Thakkar
Add tests for round_closest_up/down and roundclosest macros which round to nearest multiple of specified argument. These are tested with kunit tool as shared here [1]. [1]: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 Signed-off-by: Devarsh Thakkar --- V1->V9 (No change,

[PATCH v9 07/10] lib: add basic KUnit test for lib/math

2024-05-26 Thread Devarsh Thakkar
From: Daniel Latypov Add basic test coverage for files that don't require any config options: * part of math.h (what seem to be the most commonly used macros) * gcd.c * lcm.c * int_sqrt.c * reciprocal_div.c (Ignored int_pow.c since it's a simple textbook algorithm.) These tests aren't

[PATCH v9 06/10] math.h: Add macros for rounding to closest value

2024-05-26 Thread Devarsh Thakkar
Add below rounding related macros: round_closest_up(x, y) : Rounds x to closest multiple of y where y is a power of 2, with a preference to round up in case two nearest values are possible. round_closest_down(x, y) : Rounds x to closest multiple of y where y is a power of 2, with a preference to

[PATCH v9 00/10] Add V4L2 M2M Driver for E5010 JPEG Encoder

2024-05-26 Thread Devarsh Thakkar
This adds support for V4L2 M2M based driver for E5010 JPEG Encoder which is a stateful JPEG encoder from Imagination technologies and is present in TI AM62A SoC. While adding support for it, following additional framework changes were made: - Moved reference quantization and huffman tables

Re: [PATCH RESEND,v6 2/8] dt-bindings: mailbox: Add property for CMDQ secure driver

2024-05-26 Thread Rob Herring (Arm)
On Sun, 26 May 2024 22:44:37 +0800, Jason-JH.Lin wrote: > 1. Add mboxes property to define a GCE loopping thread as a secure IRQ > handler. > The CMDQ secure driver requests a mbox channel and sends a looping > command to the GCE thread. The looping command will wait for a secure > packet done

Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml

2024-05-26 Thread 林睿祥

[PATCH RESEND, v6 4/8] mailbox: mtk-cmdq: Support GCE loop packets in interrupt handler

2024-05-26 Thread Jason-JH . Lin
1. Add a loop flag for CMDQ packet struct. CMDQ helper will use a loop flag to mark CMDQ packet as lopping command and make current command buffer jumps to the beginning when GCE executes to the end of command buffer. 2. Add a looping task handle flow in irq handler. GCE irq occurs when GCE

[PATCH RESEND, v6 8/8] soc: mediatek: mtk-cmdq: Add secure cmdq_pkt APIs

2024-05-26 Thread Jason-JH . Lin
Open secure cmdq_pkt APIs to support executing commands in secure world. 1. Add cmdq_sec_pkt_alloc_sec_data(), cmdq_sec_pkt_free_sec_data() and cmdq_sec_pkt_set_data() to prepare the sec_data in cmdq_pkt that will be referenced in the secure world. 2. Add cmdq_sec_insert_backup_cookie()

[PATCH RESEND, v6 7/8] mailbox: mediatek: Add secure CMDQ driver support for CMDQ driver

2024-05-26 Thread Jason-JH . Lin
CMDQ driver will probe a secure CMDQ driver when has_sec flag in platform data is true and its device node in dts has defined a event id of CMDQ_SYNC_TOKEN_SEC_EOF. Secure CMDQ driver support on mt8188 and mt8195 currently. So add a has_secure flag to their driver data to probe it.

[PATCH RESEND, v6 2/8] dt-bindings: mailbox: Add property for CMDQ secure driver

2024-05-26 Thread Jason-JH . Lin
1. Add mboxes property to define a GCE loopping thread as a secure IRQ handler. The CMDQ secure driver requests a mbox channel and sends a looping command to the GCE thread. The looping command will wait for a secure packet done event signal from secure world and then jump back to the first

[PATCH RESEND, v6 6/8] mailbox: mediatek: Add CMDQ secure mailbox driver

2024-05-26 Thread Jason-JH . Lin
To support secure video path feature, GCE have to read/write registgers in the secure world. GCE will enable the secure access permission to the HW who wants to access the secure content buffer. Add CMDQ secure mailbox driver to make CMDQ client user is able to sending their HW settings to the

[PATCH RESEND, v6 5/8] mailbox: mediatek: Move reuseable definition to header for secure driver

2024-05-26 Thread Jason-JH . Lin
To support CMDQ secure driver, move some reuseable definition to header. - define: e.g. CMDQ_GCE_NUM_MAX, CMDQ_THR_BASE, CMDQ_THR_SIZE. - struct: e.g. cmdq_thread, cmdq, cmdq_task. - include: e.g. . Add "#include " for the function that takes "struct mbox_chan * chan" as a parameter. That may

[PATCH RESEND, v6 1/8] dt-bindings: gce: mt8195: Add CMDQ_SYNC_TOKEN_SECURE_THR_EOF event id

2024-05-26 Thread Jason-JH . Lin
There are 2 kind of GCE event signal: - The SW token means: a GCE event signal triggered by SW drivers. e.g. SW driver append a GCE command to set a GCE event after a specific GCE command. Or SW driver use CPU to write a event id to GCE register to trigger the GCE event corresponding to that event

[PATCH RESEND, v6 3/8] soc: mediatek: cmdq: Add cmdq_pkt_logic_command to support math operation

2024-05-26 Thread Jason-JH . Lin
Add cmdq_pkt_logic_command to support math operation. cmdq_pkt_logic_command can append logic command to the CMDQ packet, ask GCE to execute a arithmetic calculate instruction, such as add, subtract, multiply, AND, OR and NOT, etc. Note that all arithmetic instructions are unsigned calculations.

[PATCH RESEND,v6 0/8] Add CMDQ secure driver for SVP

2024-05-26 Thread Jason-JH . Lin
From: Jason-jh Lin For the Secure Video Path (SVP) feature, inculding the memory stored secure video content, the registers of display HW pipeline and the HW configure operations are required to execute in the secure world. So using a CMDQ secure driver to make all display HW registers

6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

2024-05-26 Thread Mikhail Gavrilov
Hi, Day before yesterday I replaced 7900XTX to 6900XT for got clear in which kernel first time appeared warning message "DMA-API: amdgpu :0f:00.0: cacheline tracking EEXIST, overlapping mappings aren't supported". The kernel 6.3 and older won't boot on a computer with Radeon 7900XTX. When I

[PATCH v6 2/2] backlight: Add new lm3509 backlight driver

2024-05-26 Thread Patrick Gansterer
This is a general driver for LM3509 backlight chip of TI. LM3509 is High Efficiency Boost for White LEDs and/or OLED Displays with Dual Current Sinks. This driver supports OLED/White LED select, brightness control and sub/main control. The datasheet can be found at

[PATCH v6 0/2] backlight: Add new lm3509 backlight driver

2024-05-26 Thread Patrick Gansterer
This is a general driver for LM3509 backlight chip of TI. LM3509 is High Efficiency Boost for White LEDs and/or OLED Displays with Dual Current Sinks. This driver supports OLED/White LED select, brightness control and sub/main control. The datasheet can be found at

[PATCH v6 1/2] dt-bindings: backlight: Add Texas Instruments LM3509

2024-05-26 Thread Patrick Gansterer
Add Device Tree bindings for Texas Instruments LM3509 - a High Efficiency Boost for White LED's and/or OLED Displays Signed-off-by: Patrick Gansterer Reviewed-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson --- .../bindings/leds/backlight/ti,lm3509.yaml| 136 ++ 1

Re: [PATCH v4 2/3] drm/lima: Fix dma_resv deadlock at drm object pin time

2024-05-26 Thread Val Packett
On Thu, May 23 2024 at 12:32:18 +01:00:00, Adrián Larumbe wrote: Commit a78027847226 ("drm/gem: Acquire reservation lock in drm_gem_{pin/unpin}()") moved locking the DRM object's dma reservation to drm_gem_pin(), but Lima's pin callback kept calling drm_gem_shmem_pin, which also tries to