Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Abhinav Kumar
On 6/7/2024 5:57 PM, Dmitry Baryshkov wrote: On Sat, 8 Jun 2024 at 02:55, Abhinav Kumar wrote: On 6/7/2024 3:26 PM, Dmitry Baryshkov wrote: On Sat, 8 Jun 2024 at 00:39, Abhinav Kumar wrote: On 6/7/2024 2:10 PM, Dmitry Baryshkov wrote: On Fri, Jun 07, 2024 at 12:22:16PM -0700, Abhin

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Dmitry Baryshkov
On Sat, 8 Jun 2024 at 02:55, Abhinav Kumar wrote: > > > > On 6/7/2024 3:26 PM, Dmitry Baryshkov wrote: > > On Sat, 8 Jun 2024 at 00:39, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 6/7/2024 2:10 PM, Dmitry Baryshkov wrote: > >>> On Fri, Jun 07, 2024 at 12:22:16PM -0700, Abhinav Kumar wrote: >

Re: [PATCH v3 1/4] drm/sched: store the drm_device instead of the device

2024-06-07 Thread kernel test robot
Hi Pierre-Eric, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.10-rc2 next-20240607] [cannot apply to drm-xe/drm-xe-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Abhinav Kumar
On 6/7/2024 3:26 PM, Dmitry Baryshkov wrote: On Sat, 8 Jun 2024 at 00:39, Abhinav Kumar wrote: On 6/7/2024 2:10 PM, Dmitry Baryshkov wrote: On Fri, Jun 07, 2024 at 12:22:16PM -0700, Abhinav Kumar wrote: On 6/7/2024 12:16 AM, Dmitry Baryshkov wrote: On Thu, Jun 06, 2024 at 03:21:11PM

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread FUJITA Tomonori
On Fri, 7 Jun 2024 19:55:49 +0200 Danilo Krummrich wrote: > On Fri, Jun 07, 2024 at 05:41:11PM +0200, Greg KH wrote: >> On Fri, Jun 07, 2024 at 03:33:39PM +0200, Danilo Krummrich wrote: >> > On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: >> > > Anyway, that's all hand-wavy right now, so

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Dmitry Baryshkov
On Sat, 8 Jun 2024 at 00:39, Abhinav Kumar wrote: > > > > On 6/7/2024 2:10 PM, Dmitry Baryshkov wrote: > > On Fri, Jun 07, 2024 at 12:22:16PM -0700, Abhinav Kumar wrote: > >> > >> > >> On 6/7/2024 12:16 AM, Dmitry Baryshkov wrote: > >>> On Thu, Jun 06, 2024 at 03:21:11PM -0700, Abhinav Kumar wrote

[PATCH v2] drm/nouveau: don't attempt to schedule hpd_work on headless cards

2024-06-07 Thread Vasily Khoruzhick
If the card doesn't have display hardware, hpd_work and hpd_lock are left uninitialized which causes BUG when attempting to schedule hpd_work on runtime PM resume. Fix it by adding headless flag to DRM and skip any hpd if it's set. Fixes: ae1aadb1eb8d ("nouveau: don't fail driver load if no displ

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Abhinav Kumar
On 6/7/2024 2:10 PM, Dmitry Baryshkov wrote: On Fri, Jun 07, 2024 at 12:22:16PM -0700, Abhinav Kumar wrote: On 6/7/2024 12:16 AM, Dmitry Baryshkov wrote: On Thu, Jun 06, 2024 at 03:21:11PM -0700, Abhinav Kumar wrote: On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: Only several SSPP blocks

Re: [git pull] drm fixes for 6.10-rc3

2024-06-07 Thread pr-tracker-bot
The pull request you sent on Fri, 7 Jun 2024 12:05:49 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-06-07 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2e32d580757362edc95fdd7a86d3b869b78e58d8 Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Dmitry Baryshkov
On Fri, Jun 07, 2024 at 12:22:16PM -0700, Abhinav Kumar wrote: > > > On 6/7/2024 12:16 AM, Dmitry Baryshkov wrote: > > On Thu, Jun 06, 2024 at 03:21:11PM -0700, Abhinav Kumar wrote: > > > On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: > > > > Only several SSPP blocks support such features as YUV o

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-07 Thread Dmitry Baryshkov
On Fri, Jun 07, 2024 at 10:00:04AM -0400, Kiarash Hajian wrote: > The driver's memory regions are currently just ioremap()ed, but not > reserved through a request. That's not a bug, but having the request is > a little more robust. > > Implement the region-request through the corresponding managed

[pull] amdgpu, amdkfd, radeon drm-next-6.11

2024-06-07 Thread Alex Deucher
Hi Dave, Sima, New stuff for 6.11. The following changes since commit b77bef36015c501f1e0f51db72c55e6dcd8bdd48: drm/amd/display: Add some HDCP registers DCN35 list (2024-04-26 17:22:45 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-

Re: [PATCH] drm/radeon: remove load callback

2024-06-07 Thread Hoi Pok Wu
no problem, thanks for your time. wu On Fri, Jun 7, 2024 at 1:35 PM Christian König wrote: > > In general thanks for looking into this, but when you don't have > hardware to at least briefly validate your work we probably can't accept > that. > > I can see if I can get anybody looking into this,

Re: [PATCH v7 00/13] Make PCI's devres API more consistent

2024-06-07 Thread Bjorn Helgaas
On Wed, Jun 05, 2024 at 10:15:52AM +0200, Philipp Stanner wrote: > Hello Bjorn, > > I tried to meet your requests from the last feedback round as much as > possible. Especially, I removed a lot of code, made almost all > interfaces private and cut the series into smaller chunks where > possible. >

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Abhinav Kumar
On 6/7/2024 12:16 AM, Dmitry Baryshkov wrote: On Thu, Jun 06, 2024 at 03:21:11PM -0700, Abhinav Kumar wrote: On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features. Properly uti

Re: [PATCH] drm/i915/gt/uc: Evaluate GuC priority within locks

2024-06-07 Thread Daniele Ceraolo Spurio
On 6/5/2024 5:17 PM, Andi Shyti wrote: The ce->guc_state.lock was made to protect guc_prio, which indicates the GuC priority level. But at the begnning of the function we perform some sanity check of guc_prio outside its protected section. Move them within the locked region. Use this occasio

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Danilo Krummrich
On Fri, Jun 07, 2024 at 05:41:11PM +0200, Greg KH wrote: > On Fri, Jun 07, 2024 at 03:33:39PM +0200, Danilo Krummrich wrote: > > On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: > > > Anyway, that's all hand-wavy right now, sorry, to get back to the point > > > here, again, let's take this,

Re: [PATCH] drm/radeon: remove load callback

2024-06-07 Thread Christian König
In general thanks for looking into this, but when you don't have hardware to at least briefly validate your work we probably can't accept that. I can see if I can get anybody looking into this, but the odds that somebody has time and hardware are pretty low. Christian. Am 07.06.24 um 16:15

Re: [PATCH] drm/radeon: remove load callback

2024-06-07 Thread Hoi Pok Wu
i do it because it is part of the todo list where the task is to remove load/unload callback there are only 2 drm_driver that still uses thats why i thought my amdgpu could test radeonsi but no, i still send it anyway regards, wu On Fri, Jun 7, 2024 at 3:51 AM Christian König wrote: > > Am 07.0

[PATCH] drm/radeon: remove load callback

2024-06-07 Thread wu hoi pok
this patch is to remove the load callback from the kms_driver, following closly to amdgpu, radeon_driver_load_kms and devm_drm_dev_alloc are used, most of the changes here are rdev->ddev to rdev_to_drm, which maps to adev_to_drm in amdgpu. however this patch is not tested on hardware, so if you are

[linux-next:master] BUILD REGRESSION d35b2284e966c0bef3e2182a5c5ea02177dd32e4

2024-06-07 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d35b2284e966c0bef3e2182a5c5ea02177dd32e4 Add linux-next specific files for 20240607 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202406071624.o81nljmg-...@intel.com https

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-07 Thread Mina Almasry
On Fri, Jun 7, 2024 at 8:47 AM Pavel Begunkov wrote: > > On 6/7/24 16:42, Pavel Begunkov wrote: > > On 6/7/24 15:27, David Ahern wrote: > >> On 6/7/24 7:42 AM, Pavel Begunkov wrote: > >>> I haven't seen any arguments against from the (net) maintainers so > >>> far. Nor I see any objection against

Re: [PATCH] drm/nouveau: don't attempt to schedule hpd_work on headless cards

2024-06-07 Thread Vasily Khoruzhick
On Thu, Jun 6, 2024 at 6:37 PM Dave Airlie wrote: > > readding original poster Thanks, Dave! Ben, please keep me on CC, since I'm not subscribed to either nouveau or dri-devel mailing lists. > On Wed, 29 May 2024 at 09:57, Ben Skeggs wrote: > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_c

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-07 Thread Pavel Begunkov
On 6/7/24 16:42, Pavel Begunkov wrote: On 6/7/24 15:27, David Ahern wrote: On 6/7/24 7:42 AM, Pavel Begunkov wrote: I haven't seen any arguments against from the (net) maintainers so far. Nor I see any objection against callbacks from them (considering that either option adds an if). I have s

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-07 Thread Pavel Begunkov
On 6/7/24 15:27, David Ahern wrote: On 6/7/24 7:42 AM, Pavel Begunkov wrote: I haven't seen any arguments against from the (net) maintainers so far. Nor I see any objection against callbacks from them (considering that either option adds an if). I have said before I do not understand why the d

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Greg KH
On Fri, Jun 07, 2024 at 03:33:39PM +0200, Danilo Krummrich wrote: > On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: > > Anyway, that's all hand-wavy right now, sorry, to get back to the point > > here, again, let's take this, which will allow the firmware bindings to > > be resubmitted and

Re: [PATCH] drm/i915/gt: debugfs: Evaluate forcewake usage within locks

2024-06-07 Thread Rodrigo Vivi
On Fri, Jun 07, 2024 at 04:51:31PM +0200, Andi Shyti wrote: > The forcewake count and domains listing is multi process critical > and the uncore provides a spinlock for such cases. > > Lock the forcewake evaluation section in the fw_domains_show() > debugfs interface. > > Signed-off-by: Andi Shyt

[Bug 218900] amdgpu: Fatal error during GPU init

2024-06-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218900 --- Comment #15 from Hanabishi (i.r.e.c.c.a.k.u.n+bugzilla.kernel@gmail.com) --- (In reply to Vasant Hegde from comment #5) > Created attachment 306364 [details] > Check Enhanced PPR support before enabling PPR I applied your patch on top of

Re: [PATCH v4 0/5] drm/tiny: panel-mipi-dbi: Support 18 bits per color RGB666

2024-06-07 Thread Noralf Trønnes
On 6/4/24 15:20, Noralf Trønnes via B4 Relay wrote: > Hi, > > In this version I've fixed up a commit message that I had forgotten to > write before sending and improved a struct member name. > > See version 1 of the patchset for the full cover letter. > > Signed-off-by: Noralf Trønnes > ---

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-07 Thread Jason Gunthorpe
On Fri, Jun 07, 2024 at 08:27:29AM -0600, David Ahern wrote: > On 6/7/24 7:42 AM, Pavel Begunkov wrote: > > I haven't seen any arguments against from the (net) maintainers so > > far. Nor I see any objection against callbacks from them (considering > > that either option adds an if). > > I have sa

[PATCH] drm/i915/gt: debugfs: Evaluate forcewake usage within locks

2024-06-07 Thread Andi Shyti
The forcewake count and domains listing is multi process critical and the uncore provides a spinlock for such cases. Lock the forcewake evaluation section in the fw_domains_show() debugfs interface. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 1 file cha

Re: [PATCH] drm: have config DRM_WERROR depend on !WERROR

2024-06-07 Thread Jani Nikula
On Fri, 07 Jun 2024, Javier Martinez Canillas wrote: > Jani Nikula writes: > > Hello Jani, > >> If WERROR is already enabled, there's no point in enabling DRM_WERROR or >> asking users about it. >> >> Reported-by: Linus Torvalds >> Closes: >> https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=v

Re: [PATCH RFC 7/8] drm/sun4i: de3: Implement AFBC support

2024-06-07 Thread Andre Przywara
On Fri, 7 Jun 2024 23:00:03 +1200 Ryan Walklin wrote: Hi Ryan, thanks for taking the time and posting those patches! > Buffers, compressed with AFBC, are generally more efficient for memory > transfers. Add support for them. > > Currently it's implemented only for VI layers, but vendor code a

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-07 Thread David Ahern
On 6/7/24 7:42 AM, Pavel Begunkov wrote: > I haven't seen any arguments against from the (net) maintainers so > far. Nor I see any objection against callbacks from them (considering > that either option adds an if). I have said before I do not understand why the dmabuf paradigm is not sufficient f

Re: [PATCH RFC 1/8] dt-bindings: bus: allwinner: add H616 DE33 bindings

2024-06-07 Thread Conor Dooley
On Fri, Jun 07, 2024 at 10:59:57PM +1200, Ryan Walklin wrote: > The Allwinner H616 and variants have a new display engine revision > (DE33). > > Add display engine bus, clock and mixer bindings for the DE33. > > Signed-off-by: Ryan Walklin > --- > .../devicetree/bindings/bus/allwinner,sun50i-a6

[PATCH] drm/msm/a6xx: request memory region

2024-06-07 Thread Kiarash Hajian
gpu *a6xx_gpu, struct device_node *node) detach_cxpd: dev_pm_domain_detach(gmu->cxpd, false); -err_mmio: - iounmap(gmu->mmio); - if (platform_get_resource_byname(pdev, IORESOURCE_MEM, "rscc")) - iounmap(gmu->rscc); +err_cleanup: free_irq(gmu->gmu_irq, gmu); free_irq(gmu->hfi_irq, gmu); --- base-commit: 1b294a1f35616977caddaddf3e9d28e576a1adbc change-id: 20240607-memory-45e13bb0cd16 Best regards, -- Kiarash Hajian

Re: [PATCH v6 05/26] drm/display: Add missing Panel Replay Enable SU Region ET bit

2024-06-07 Thread Hogander, Jouni
On Wed, 2024-06-05 at 13:31 +0300, Jouni Högander wrote: > Add missing Panel Replay Enable SU Region ET bit defined in DP2.1 > specification. Hello drm-core maintainers, Could you please consider providing your ack on this patch? I'm planning to merge it via drm-intel tree. I have already r-b tag

Re: [PATCH v3 1/4] drm/sched: store the drm_device instead of the device

2024-06-07 Thread Pierre-Eric Pelloux-Prayer
Hi, Le 06/06/2024 à 15:18, Christian König a écrit : Am 06.06.24 um 15:06 schrieb Pierre-Eric Pelloux-Prayer: When tracing is enabled, being able to identify which device is sending events is useful; for this the next commit will extend events to include drm_device::primary::index. That sound

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-07 Thread Pavel Begunkov
On 6/5/24 09:24, Christoph Hellwig wrote: On Mon, Jun 03, 2024 at 03:52:32PM +0100, Pavel Begunkov wrote: The question for Christoph is what exactly is the objection here? Why we would not be using well defined ops when we know there will be more users? The point is that there should be no mor

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-07 Thread Pavel Begunkov
On 6/3/24 16:43, Mina Almasry wrote: On Mon, Jun 3, 2024 at 7:52 AM Pavel Begunkov wrote: On 6/3/24 15:17, Mina Almasry wrote: On Fri, May 31, 2024 at 10:35 PM Christoph Hellwig wrote: On Thu, May 30, 2024 at 08:16:01PM +, Mina Almasry wrote: I'm unsure if the discussion has been reso

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

2024-06-07 Thread Alex Deucher
On Sun, May 26, 2024 at 10:12 AM Mikhail Gavrilov wrote: > > Hi, > Day before yesterday I replaced 7900XTX to 6900XT for got clear in > which kernel first time appeared warning message "DMA-API: amdgpu > :0f:00.0: cacheline tracking EEXIST, overlapping mappings aren't > supported". > The kerne

Re: [PATCH] drm/v3d: Fix perfmon build error/warning

2024-06-07 Thread Tvrtko Ursulin
On 05/06/2024 08:19, Iago Toral wrote: Thanks for looking at ixing this Tvrtko. El mar, 04-06-2024 a las 17:02 +0100, Tvrtko Ursulin escribió: From: Tvrtko Ursulin Move static const array into the source file to fix the "defined but not used" errors. The fix is perhaps not the prettiest du

[PATCH v13 13/13] gpu: ipu-v3: Use generic macro for rounding closest to specified value

2024-06-07 Thread Devarsh Thakkar
Use generic macro round_closest_up() for rounding closest to specified value instead of using local macro round_closest(). There is no change from functionality point of view as round_closest_up() is functionally same as the previously used local macro round_closest(). Signed-off-by: Devarsh Thak

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Danilo Krummrich
On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: > Anyway, that's all hand-wavy right now, sorry, to get back to the point > here, again, let's take this, which will allow the firmware bindings to > be resubmitted and hopefully accepted, and we can move forward from > there to "real" things

[PATCH v13 12/13] media: imagination: Round to closest multiple for cropping region

2024-06-07 Thread Devarsh Thakkar
If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest multiple of requested value while updating the crop rectangle coordinates. Use the rounding macro which gives preference to rounding down in case two nearest val

[PATCH v13 11/13] lib: math_kunit: Add tests for new macros related to rounding to nearest value

2024-06-07 Thread Devarsh Thakkar
Add tests for round_closest_up/down and roundclosest macros which round to nearest multiple of specified argument. These are tested with kunit tool as shared here [1] : Link: https://gist.github.com/devarsht/3f9042825be3da4e133b8f4eda067876 [1] Signed-off-by: Devarsh Thakkar Acked-by: Andy Shevch

[PATCH v13 10/13] lib: add basic KUnit test for lib/math

2024-06-07 Thread Devarsh Thakkar
From: Daniel Latypov Add basic test coverage for files that don't require any config options: * part of math.h (what seem to be the most commonly used macros) * gcd.c * lcm.c * int_sqrt.c * reciprocal_div.c (Ignored int_pow.c since it's a simple textbook algorithm.) These tests aren't particular

[PATCH v13 09/13] Documentation: core-api: Add math.h macros and functions

2024-06-07 Thread Devarsh Thakkar
Add documentation for rounding, scaling, absolute value and 32-bit division related macros and functions exported by math.h header file. Signed-off-by: Devarsh Thakkar Reviewed-by: Andy Shevchenko --- V13: No change V12: Add Reviewed-by V11: Fix title for math function header V10: Patch introduc

[PATCH v13 07/13] math.h: Add macros for rounding to closest value

2024-06-07 Thread Devarsh Thakkar
Add below rounding related macros: round_closest_up(x, y) : Rounds x to closest multiple of y where y is a power of 2, with a preference to round up in case two nearest values are possible. round_closest_down(x, y) : Rounds x to closest multiple of y where y is a power of 2, with a preference to

Re: [PATCH v3 3/4] drm/sched: cleanup gpu_scheduler trace events

2024-06-07 Thread Pierre-Eric Pelloux-Prayer
Hi, Le 06/06/2024 à 15:19, Steven Rostedt a écrit : On Thu, 6 Jun 2024 15:06:24 +0200 Pierre-Eric Pelloux-Prayer wrote: Print identifiers instead of pointers: * "fence=%p" is replaced by "fence=(context:%llu, seqno:%lld)" to have a coherent way to print the fence. A possible follow up change

[PATCH v5 7/9] drm/msm/hdmi: get rid of hdmi_mode

2024-06-07 Thread Dmitry Baryshkov
Use connector->display_info.is_hdmi instead of manually using drm_detect_hdmi_monitor(). Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c| 2 +- drivers/gpu/drm/msm/hdmi/hdmi.h| 2 -- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 11 --

[PATCH v5 9/9] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2024-06-07 Thread Dmitry Baryshkov
Extend the driver to send SPD and HDMI Vendor Specific InfoFrames. While the HDMI block has special block to send HVS InfoFrame, use GENERIC0 block instead. VENSPEC_INFO registers pack frame data in a way that requires manual repacking in the driver, while GENERIC0 doesn't have such format require

[PATCH v5 2/9] drm/bridge-connector: switch to using drmm allocations

2024-06-07 Thread Dmitry Baryshkov
Turn drm_bridge_connector to using drmm_kzalloc() and drmm_connector_init() and drop the custom destroy function. The drm_connector_unregister() and fwnode_handle_put() are already handled by the drm_connector_cleanup() and so are safe to be dropped. Acked-by: Maxime Ripard Signed-off-by: Dmitry

[PATCH v5 8/9] drm/msm/hdmi: update HDMI_GEN_PKT_CTRL_GENERIC0_UPDATE definition

2024-06-07 Thread Dmitry Baryshkov
The GENERIC0_UPDATE field is a single bit. Redefine it as boolean to simplify its usage in the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/display/hdmi.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/registers/display/hdmi

[PATCH v5 6/9] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-06-07 Thread Dmitry Baryshkov
Setup the HDMI connector on the MSM HDMI outputs. Make use of atomic_check hook and of the provided Infoframe infrastructure. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig| 2 + drivers/gpu/drm/msm/hdmi/hdmi.c| 45 ++--- drive

[PATCH v5 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-06-07 Thread Dmitry Baryshkov
The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Turn it into the atomic_enable callback as suggested by the documentation. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 33 +

[PATCH v5 1/9] drm/connector: hdmi: allow disabling Audio Infoframe

2024-06-07 Thread Dmitry Baryshkov
Add drm_atomic_helper_connector_hdmi_disable_audio_infoframe(), an API to allow the driver disable sending the Audio Infoframe. This is to be used by the drivers if setup of the infoframes is not tightly coupled with the audio functionality and just disabling the audio playback doesn't stop the HDM

[PATCH v5 4/9] drm/msm/hdmi: switch to atomic bridge callbacks

2024-06-07 Thread Dmitry Baryshkov
Change MSM HDMI bridge to use atomic_* callbacks in preparation to enablign the HDMI connector support. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[PATCH v5 3/9] drm/bridge-connector: implement glue code for HDMI connector

2024-06-07 Thread Dmitry Baryshkov
In order to let bridge chains implement HDMI connector infrastructure, add necessary glue code to the drm_bridge_connector. In case there is a bridge that sets DRM_BRIDGE_OP_HDMI, drm_bridge_connector will register itself as a HDMI connector and provide proxy drm_connector_hdmi_funcs implementation

[PATCH v5 0/9] drm/msm: make use of the HDMI connector infrastructure

2024-06-07 Thread Dmitry Baryshkov
This patchset sits on top Maxime's HDMI connector patchset ([1]). Currently this is an RFC exploring the interface between HDMI bridges and HDMI connector code. This has been lightly verified on the Qualcomm DB820c, which has native HDMI output. If this approach is considered to be acceptable, I'l

[PATCH v13 00/13] Add V4L2 M2M Driver for E5010 JPEG Encoder

2024-06-07 Thread Devarsh Thakkar
This adds support for V4L2 M2M based driver for E5010 JPEG Encoder which is a stateful JPEG encoder from Imagination technologies and is present in TI AM62A SoC. While adding support for it, following additional framework changes were made: - Moved reference quantization and huffman tables provid

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Danilo Krummrich
On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: > On Fri, Jun 07, 2024 at 09:11:32PM +0900, FUJITA Tomonori wrote: > > Hi, > > > > On Fri, 31 May 2024 11:59:47 +0200 > > Danilo Krummrich wrote: > > > > > Once we get to a conclusion I can send a series with only the device and > > > fir

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Danilo Krummrich
On Fri, Jun 07, 2024 at 09:11:32PM +0900, FUJITA Tomonori wrote: > Hi, > > On Fri, 31 May 2024 11:59:47 +0200 > Danilo Krummrich wrote: > > > Once we get to a conclusion I can send a series with only the device and > > firmare > > abstractions such that we can get them in outside of the scope o

Re: [PATCH v2 2/4] drm/panel: kd101ne3: add new panel driver

2024-06-07 Thread Alex Bee
Am 07.06.24 um 14:01 schrieb Dmitry Baryshkov: On Fri, Jun 07, 2024 at 07:44:33PM +0800, zhaoxiong lv wrote: hi Alex Bee I compared these two drivers. Although the control IC is the same, the panel is different, and the init_cmd and timing are also slightly different, so I added a separate dr

Re: [PATCH] drm: have config DRM_WERROR depend on !WERROR

2024-06-07 Thread Javier Martinez Canillas
Jani Nikula writes: Hello Jani, > If WERROR is already enabled, there's no point in enabling DRM_WERROR or > asking users about it. > > Reported-by: Linus Torvalds > Closes: > https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=veojn6gw8gk4j2v+biduntz...@mail.gmail.com > Fixes: f89632a9e5fa ("d

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Greg KH
On Fri, Jun 07, 2024 at 09:11:32PM +0900, FUJITA Tomonori wrote: > Hi, > > On Fri, 31 May 2024 11:59:47 +0200 > Danilo Krummrich wrote: > > > Once we get to a conclusion I can send a series with only the device and > > firmare > > abstractions such that we can get them in outside of the scope o

Re: [PATCH net-next v10 06/14] page_pool: convert to use netmem

2024-06-07 Thread Pavel Begunkov
On 6/6/24 02:48, Steven Rostedt wrote: On Thu, 30 May 2024 20:16:05 + Mina Almasry wrote: @@ -42,51 +42,52 @@ TRACE_EVENT(page_pool_release, TRACE_EVENT(page_pool_state_release, TP_PROTO(const struct page_pool *pool, -const struct page *page, u32 release), +

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

2024-06-07 Thread Linux regression tracking (Thorsten Leemhuis)
[CCing the other amd drm maintainers] On 05.06.24 14:04, Mikhail Gavrilov wrote: > On Sun, May 26, 2024 at 7:06 PM Mikhail Gavrilov > wrote: >> >> Day before yesterday I replaced 7900XTX to 6900XT for got clear in >> which kernel first time appeared warning message "DMA-API: amdgpu >> :0f:00.

Re: [PATCH] drm: have config DRM_WERROR depend on !WERROR

2024-06-07 Thread Jani Nikula
On Thu, 16 May 2024, Jani Nikula wrote: > If WERROR is already enabled, there's no point in enabling DRM_WERROR or > asking users about it. Ping. Any comments? (Besides the one snark.) BR, Jani. > > Reported-by: Linus Torvalds > Closes: > https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=ve

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread FUJITA Tomonori
Hi, On Fri, 31 May 2024 11:59:47 +0200 Danilo Krummrich wrote: > Once we get to a conclusion I can send a series with only the device and > firmare > abstractions such that we can get them in outside of the scope of the reset of > both series to get your driver going. Since your discussion wit

Re: [PATCH v2 4/4] drm/panel: starry: add new panel driver

2024-06-07 Thread Dmitry Baryshkov
On Fri, 7 Jun 2024 at 14:51, zhaoxiong lv wrote: > > hi Dmitry > > These two panels are not the same IC but their timing is the same, > only the init cmd and panel parameters are different, so I made it > compatible on the kingdisplay driver. We usually merge drivers by the driver IC, not by the

Re: [PATCH v3 07/10] media: intel: Add Displayport RX IP driver

2024-06-07 Thread Hans Verkuil
On 04/06/2024 14:32, Paweł Anikiel wrote: > On Mon, Jun 3, 2024 at 10:37 AM Hans Verkuil wrote: >> >> On 07/05/2024 17:54, Paweł Anikiel wrote: >>> Add v4l2 subdev driver for the Intel Displayport receiver FPGA IP. >>> It is a part of the DisplayPort Intel FPGA IP Core, and supports >>> DisplayPor

Re: [PATCH v2 2/4] drm/panel: kd101ne3: add new panel driver

2024-06-07 Thread Dmitry Baryshkov
On Fri, Jun 07, 2024 at 07:44:33PM +0800, zhaoxiong lv wrote: > hi Alex Bee > > I compared these two drivers. Although the control IC is the same, the > panel is different, and the init_cmd and timing are also slightly > different, so I added a separate driver. But it obviously uses the same stru

Re: [PATCH v2 0/3] Move blender setup from individual planes to crtc commit in sun4i-drm

2024-06-07 Thread Ondřej Jirman
Hi Maxime, On Sun, Apr 21, 2024 at 09:52:58PM GMT, Jernej Škrabec wrote: > Dne petek, 19. april 2024 ob 15:36:17 GMT +2 je Ondřej Jirman napisal(a): > > Hi, > > > > On Sat, Feb 24, 2024 at 04:05:57PM GMT, megi xff wrote: > > > From: Ondrej Jirman > > > > > > This series refactors blender setup

Re: [PATCH v2 4/4] drm/panel: starry: add new panel driver

2024-06-07 Thread zhaoxiong lv
hi Dmitry These two panels are not the same IC but their timing is the same, only the init cmd and panel parameters are different, so I made it compatible on the kingdisplay driver. Similar to this driver: panel-boe-tv101wum-nl6.c thanks On Sun, Jun 2, 2024 at 12:26 AM Dmitry Baryshkov wrote:

Re: [PATCH v2 1/4] dt-bindings: display: panel: Add KD101NE3-40TI support

2024-06-07 Thread Dmitry Baryshkov
On Fri, 7 Jun 2024 at 14:38, zhaoxiong lv wrote: > > hi Dmitry Baryshkov > > Because this is a separate mipi dsi driver, I did not put it in > panel-sample-dsi.yaml. Driver and bindings are two separate things. Bindings describe the hardware. If there is no other reason to have a separate binding

Re: [PATCH v2 2/4] drm/panel: kd101ne3: add new panel driver

2024-06-07 Thread zhaoxiong lv
hi Alex Bee I compared these two drivers. Although the control IC is the same, the panel is different, and the init_cmd and timing are also slightly different, so I added a separate driver. thanks On Sun, Jun 2, 2024 at 1:07 PM Alex Bee wrote: > > Am 01.06.24 um 10:45 schrieb Zhaoxiong Lv: > >

Re: [PATCH v2 1/4] dt-bindings: display: panel: Add KD101NE3-40TI support

2024-06-07 Thread zhaoxiong lv
hi Dmitry Baryshkov Because this is a separate mipi dsi driver, I did not put it in panel-sample-dsi.yaml. On Sun, Jun 2, 2024 at 12:28 AM Dmitry Baryshkov wrote: > > On Sat, Jun 01, 2024 at 04:45:25PM +0800, Zhaoxiong Lv wrote: > > Create a new dt-scheam for the kd101ne3-40ti. > > The bias IC

[PATCH RFC 8/8] drm: sun4i: add Display Engine 3.3 (DE33) support

2024-06-07 Thread Ryan Walklin
The DE33 is a newer version of the Allwinner Display Engine IP block, found in the H616, H618, H700 and T507 SoCs. DE2 and DE3 are already supported by the mainline driver. Notable features (from the H616 datasheet and implemented): - 4096 x 2048 (4K) output support - AFBC ARM Frame Buffer Compres

[PATCH RFC 7/8] drm/sun4i: de3: Implement AFBC support

2024-06-07 Thread Ryan Walklin
Buffers, compressed with AFBC, are generally more efficient for memory transfers. Add support for them. Currently it's implemented only for VI layers, but vendor code and documentation suggest UI layers can have them too. However, I haven't observed any SoC with such feature. Signed-off-by: Jerne

[PATCH RFC 6/8] drm/sun4i: de3: Add support for YUV420 output

2024-06-07 Thread Ryan Walklin
Signed-off-by: Jernej Skrabec Co-developed-by: Ryan Walklin Signed-off-by: Ryan Walklin --- drivers/gpu/drm/drm_atomic_state_helper.c | 7 + drivers/gpu/drm/sun4i/Makefile| 3 +- drivers/gpu/drm/sun4i/sun4i_tcon.c| 26 +++- drivers/gpu/drm/sun4i/sun50i_fmt.c| 7

[PATCH RFC 5/8] drm/sun4i: de2: Initialize layer fields earlier

2024-06-07 Thread Ryan Walklin
From: Jernej Skrabec drm_universal_plane_init() can already call some callbacks, like format_mod_supported, during initialization. Because of that, fields should be initialized beforehand. Signed-off-by: Jernej Skrabec Co-developed-by: Ryan Walklin Signed-off-by: Ryan Walklin --- drivers/gpu

[PATCH RFC 4/8] drm/sun4i: de2/de3: call csc setup also for UI layer

2024-06-07 Thread Ryan Walklin
From: Jernej Skrabec Currently, only VI layer calls CSC setup function. This comes from DE2 limitation, which doesn't have CSC unit for UI layers. However, DE3 has separate CSC units for each layer. This allows display pipeline to make output signal in different color spaces. To support both use

[PATCH RFC 3/8] drm/sun4i: de2/de3: Merge CSC functions into one

2024-06-07 Thread Ryan Walklin
From: Jernej Skrabec Merging both function into one lets this one decide on it's own if CSC should be enabled or not. Currently heuristics for that is pretty simple - enable it for YUV formats and disable for RGB. However, DE3 can have whole pipeline in RGB or YUV format. YUV pipeline will be sup

[PATCH RFC 2/8] drm: sun4i: de2/de3: Change CSC argument

2024-06-07 Thread Ryan Walklin
From: Jernej Skrabec Currently, CSC module takes care only for converting YUV to RGB. However, DE3 is more suited to work in YUV color space. Change CSC mode argument to format type to be more neutral. New argument only tells layer format type and doesn't imply output type. This commit doesn't m

[PATCH RFC 1/8] dt-bindings: bus: allwinner: add H616 DE33 bindings

2024-06-07 Thread Ryan Walklin
The Allwinner H616 and variants have a new display engine revision (DE33). Add display engine bus, clock and mixer bindings for the DE33. Signed-off-by: Ryan Walklin --- .../devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml| 1 + .../devicetree/bindings/clock/allwinner,sun8i-a83t-de

[PATCH RFC 0/8] drm: sunxi: support Allwinner Display Engine 3 IP block for H616/H700

2024-06-07 Thread Ryan Walklin
Hi, There is existing mainline support for the DE2 and DE3 AllWinner display pipeline IP blocks, used in the A64 and H6 among others, however the H700 (as well as the H616/H618 and the T507 automotive SoC) have a newer version of the Display Engine (v3.3/DE33) which adds additional high-resolut

Re: [PATCH v2 3/3] drm/panic: Add a kmsg panic screen

2024-06-07 Thread Javier Martinez Canillas
Jocelyn Falempe writes: > Add a kmsg option, which will display the last lines of kmsg, > and should be similar to fbcon. > Add a drm.panic_screen module parameter, so you can choose between > the different panic screens available. > two options currently, but more will be added later: > * "user

Re: [PATCH v2 2/3] drm/panic: Add a set_pixel() callback to drm_scanout_buffer

2024-06-07 Thread Javier Martinez Canillas
Jocelyn Falempe writes: > This allows drivers to draw the pixel, and handle tiling, or specific > color formats. > > v2: > * Use fg_color for blit() functions (Javier Martinez Canillas) > > Signed-off-by: Jocelyn Falempe > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier M

Re: [PATCH v2 1/3] drm/panic: only draw the foreground color in drm_panic_blit()

2024-06-07 Thread Javier Martinez Canillas
Jocelyn Falempe writes: Hello Jocelyn, > The whole framebuffer is cleared, so it's useless to rewrite the > background colored pixels. It allows to simplify the drawing > functions, and prepare the work for the set_pixel() callback. > > v2: > * keep fg16/fg24/fg32 as variable name for the blit

Re: [PATCH net-next v10 05/14] netdev: netdevice devmem allocator

2024-06-07 Thread Niklas Schnelle
On Tue, 2024-06-04 at 20:27 -0400, Steven Rostedt wrote: > On Wed, 5 Jun 2024 01:44:37 +0200 > Andrew Lunn wrote: > > > > Interesting, as I sped up the ftrace ring buffer by a substantial amount > > > by > > > adding strategic __always_inline, noinline, likely() and unlikely() > > > throughout t

Re: [PATCH] drm/radeon: remove load callback

2024-06-07 Thread Christian König
Am 07.06.24 um 03:14 schrieb wu hoi pok: this patch is to remove the load callback from the kms_driver, following closly to amdgpu, radeon_driver_load_kms and devm_drm_dev_alloc are used, most of the changes here are rdev->ddev to rdev_to_drm, which maps to adev_to_drm in amdgpu. however this pat

Re: [PATCH v10 6/6] Documentation: iio: Document high-speed DMABUF based API

2024-06-07 Thread Paul Cercueil
Hi Randy, Le jeudi 06 juin 2024 à 10:32 -0700, Randy Dunlap a écrit : > Hi, > > On 6/5/24 4:08 AM, Paul Cercueil wrote: > > Document the new DMABUF based API. > > > > Signed-off-by: Paul Cercueil > > Signed-off-by: Nuno Sa > > > > --- > > v2: - Explicitly state that the new interface is optio

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Dmitry Baryshkov
On Thu, Jun 06, 2024 at 03:21:11PM -0700, Abhinav Kumar wrote: > On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: > > Only several SSPP blocks support such features as YUV output or scaling, > > thus different DRM planes have different features. Properly utilizing > > all planes requires the attentio