[linux-next:master] BUILD REGRESSION a957267fa7e9159d3d2ee1421359ebf228570c68

2024-06-11 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a957267fa7e9159d3d2ee1421359ebf228570c68 Add linux-next specific files for 20240611 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202406111949.9wfztbkm-...@intel.com https

Re: [PATCH v6,12/24] media: mediatek: vcodec: add interface to allocate/free secure memory

2024-06-11 Thread Tomasz Figa
On Thu, May 16, 2024 at 08:20:50PM +0800, Yunfei Dong wrote: > Need to call dma heap interface to allocate/free secure memory when playing > secure video. > > Signed-off-by: Yunfei Dong > --- > .../media/platform/mediatek/vcodec/Kconfig| 1 + > .../mediatek/vcodec/common/mtk_vcodec_util.c

Re: [v4,1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-06-11 Thread Jayesh Choudhary
Hello Sui, Sam! Thanks for the review. (Sorry for delayed response. I was OoO last week) On 31/05/24 19:34, Sui Jingfeng wrote: Hi, Jayesh On 5/31/24 21:33, Sam Ravnborg wrote: Hi Jayesh, +    static const struct drm_bridge_funcs sii902x_bridge_funcs = {    .attach =

Re: [PATCH v6,04/24] v4l: add documentation for restricted memory flag

2024-06-11 Thread Tomasz Figa
On Wed, May 22, 2024 at 02:16:22PM +0300, Laurent Pinchart wrote: > Hi Jefrey, > > Thank you for the patch. > > On Thu, May 16, 2024 at 08:20:42PM +0800, Yunfei Dong wrote: > > From: Jeffrey Kardatzke > > > > Adds documentation for V4L2_MEMORY_FLAG_RESTRICTED. > > > > Signed-off-by: Jeffrey

Re: [PATCH v6,03/24] v4l2: verify restricted dmabufs are used in restricted queue

2024-06-11 Thread Tomasz Figa
On Thu, May 16, 2024 at 08:20:41PM +0800, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Verfies in the dmabuf implementations that if the restricted memory > flag is set for a queue that the dmabuf submitted to the queue is > unmappable. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by:

linux-next: build failure after merge of the drm-intel tree

2024-06-11 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (i386 defconfig) failed like this: x86_64-linux-gnu-ld: drivers/gpu/drm/i915/display/intel_vrr.o: in function `intel_vrr_compute_config': intel_vrr.c:(.text+0x4e4): undefined reference to `__udivdi3' Caused by commit

linux-next: build warning after merge of the drm-intel tree

2024-06-11 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (htmldocs) produced this warning: include/drm/display/drm_dp_helper.h:127: warning: Function parameter or struct member 'target_rr_divider' not described in 'drm_dp_as_sdp' Introduced by commit a20c6d954d75 ("drm/dp: Add

Re: [PATCH v4 12/13] drm/msm/dpu: allow sharing of blending stages

2024-06-11 Thread Abhinav Kumar
On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: It is possible to slightly bend the limitations of the HW blender. If two rectangles are contiguous (like two rectangles of a single plane) they can be blended using a single LM blending stage, allowing one to blend more planes via a single LM.

Re: [PATCH v8 15/16] drm/mediatek: Support CRC in OVL

2024-06-11 Thread 胡俊光

Re: [PATCH v6 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-06-11 Thread kernel test robot
Hi AngeloGioacchino, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v6.10-rc3 next-20240611] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v8 14/16] drm/mediatek: Support CRC in display driver

2024-06-11 Thread 胡俊光

Re: [PATCH 1/4] dt-bindings: display/msm: Add SM7150 MDSS

2024-06-11 Thread Rob Herring (Arm)
On Wed, 12 Jun 2024 01:37:40 +0300, Danila Tikhonov wrote: > Document the MDSS hardware found on the Qualcomm SM7150 platform. > > Signed-off-by: Danila Tikhonov > --- > .../display/msm/qcom,sm7150-mdss.yaml | 460 ++ > 1 file changed, 460 insertions(+) > create mode

Re: [PATCH v2 04/14] drm/msm/hdmi: set infoframes on all pre_enable calls

2024-06-11 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: In consequent modeset calls, the atomic_pre_enable() will be called several times without calling atomic_post_disable() inbetween. Thus Hi Dmitry, Just wondering, where are you seeing multiple pre_enable() calls without a post_disable()

Re: [PATCH v4 13/13] drm/msm/dpu: include SSPP allocation state into the dumped state

2024-06-11 Thread Abhinav Kumar
On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: Make dpu_rm_print_state() also output the SSPP allocation state. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Abhinav Kumar

Re: [PATCH 3/4] dt-bindings: display/msm: Add SM7150 DPU

2024-06-11 Thread Rob Herring (Arm)
On Wed, 12 Jun 2024 01:37:42 +0300, Danila Tikhonov wrote: > Document the DPU hardware found on the Qualcomm SM7150 platform. > > Signed-off-by: Danila Tikhonov > --- > .../bindings/display/msm/qcom,sm7150-dpu.yaml | 145 ++ > 1 file changed, 145 insertions(+) > create mode

Re: [PATCH v4 11/13] drm/msm/dpu: create additional virtual planes

2024-06-11 Thread Abhinav Kumar
On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: Since we have enabled sharing of SSPP blocks between two planes, it is now possible to use twice as much planes as there are hardware SSPP blocks. Create additional overlay planes. Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v4 10/13] drm/msm/dpu: allow sharing SSPP between planes

2024-06-11 Thread Abhinav Kumar
On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: Since SmartDMA planes provide two rectangles, it is possible to use them to drive two different DRM planes, first plane getting the rect_0, another one using rect_1 of the same SSPP. The sharing algorithm is pretty simple, it requires that each of

[PATCH 4/4] drm/msm/dpu: Add SM7150 support

2024-06-11 Thread Danila Tikhonov
Add definitions for the display hardware used on the Qualcomm SM7150 platform. Signed-off-by: Danila Tikhonov --- .../msm/disp/dpu1/catalog/dpu_5_2_sm7150.h| 349 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 1 +

[PATCH 1/4] dt-bindings: display/msm: Add SM7150 MDSS

2024-06-11 Thread Danila Tikhonov
Document the MDSS hardware found on the Qualcomm SM7150 platform. Signed-off-by: Danila Tikhonov --- .../display/msm/qcom,sm7150-mdss.yaml | 460 ++ 1 file changed, 460 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml

[PATCH 3/4] dt-bindings: display/msm: Add SM7150 DPU

2024-06-11 Thread Danila Tikhonov
Document the DPU hardware found on the Qualcomm SM7150 platform. Signed-off-by: Danila Tikhonov --- .../bindings/display/msm/qcom,sm7150-dpu.yaml | 145 ++ 1 file changed, 145 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml

[PATCH 2/4] drm/msm: mdss: Add SM7150 support

2024-06-11 Thread Danila Tikhonov
Add support for MDSS on SM7150. Signed-off-by: Danila Tikhonov --- drivers/gpu/drm/msm/msm_mdss.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index fab6ad4e5107c..d90b9471ba6ff 100644 ---

[PATCH 0/4] Add MDSS and DPU support for QCOM SM7150 SoC

2024-06-11 Thread Danila Tikhonov
This series adds MDSS and DPU support for SM7150. To: Rob Clark To: Abhinav Kumar To: Dmitry Baryshkov To: Sean Paul To: Marijn Suijten To: Maarten Lankhorst To: Maxime Ripard To: Thomas Zimmermann To: David Airlie To: Daniel Vetter To: Rob Herring To: Krzysztof Kozlowski To: Conor

Re: [PATCH v8 03/13] PCI: Reimplement plural devres functions

2024-06-11 Thread Bjorn Helgaas
I'm trying to merge these into pci/next, but I'm having a hard time writing the merge commit log. I want a one-sentence description of each patch that tells me what the benefit of the patch is. Usually the subject line is a good start. "Reimplement plural devres functions" is kind of vague and

Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

2024-06-11 Thread Danilo Krummrich
On 6/11/24 12:37, Dr. David Alan Gilbert wrote: * Danilo Krummrich (d...@redhat.com) wrote: On 5/18/24 01:26, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" 'init_exec' is unused since commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new init table parser") Remove

Re: [PATCH v2] drm/panel : truly-nt35521: transition to mipi_dsi wrapped functions

2024-06-11 Thread Doug Anderson
Hi, On Tue, Jun 11, 2024 at 2:10 PM Dmitry Baryshkov wrote: > > On Tue, Jun 11, 2024 at 08:57:48AM -0700, Doug Anderson wrote: > > Hi, > > > > On Tue, Jun 11, 2024 at 7:44 AM Tejas Vipin wrote: > > > > > > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce > > >

Re: [PATCH v2] drm/panel : truly-nt35521: transition to mipi_dsi wrapped functions

2024-06-11 Thread Dmitry Baryshkov
On Tue, Jun 11, 2024 at 08:57:48AM -0700, Doug Anderson wrote: > Hi, > > On Tue, Jun 11, 2024 at 7:44 AM Tejas Vipin wrote: > > > > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce > > mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe > > ("drm/mipi-dsi: wrap more

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-11 Thread Marek Vasut
On 6/6/24 12:10 PM, Alexander Stein wrote: Hi Marek, Hello Alexander, sorry for the delay. At least for 148.5MHz (1080p) apparently it is not possible to that exact clock anyway. Right, which sucks, but the TC9595 datasheet explicitly states that the FRMSYNC mode should always be enabled

Re: [PATCH v6 3/3] drm/mediatek: Implement OF graphs support for display paths

2024-06-11 Thread kernel test robot
Hi AngeloGioacchino, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v6.10-rc3 next-20240611] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v2 03/14] drm/msm/hdmi: switch to atomic_pre_enable/post_disable

2024-06-11 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: In preparation of reworking the HDMI mode setting, switch pre_enable and post_disable callbacks to their atomic variants. Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 15

Re: [PATCH v2 02/14] drm/msm/hdmi: simplify extp clock handling

2024-06-11 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: With the extp being the only "power" clock left, remove the surrounding loops and handle the extp clock directly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/hdmi/hdmi.c| 24

Re: [PATCH v2 01/14] drm/msm/hdmi: move the alt_iface clock to the hpd list

2024-06-11 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: According to the vendor kernel [1] , the alt_iface clock should be enabled together with the rest of HPD clocks, to make HPD to work properly. [1]

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-11 Thread Mina Almasry
On Mon, Jun 10, 2024 at 3:15 PM Jason Gunthorpe wrote: > > On Mon, Jun 10, 2024 at 08:20:08PM +0100, Pavel Begunkov wrote: > > On 6/10/24 16:16, David Ahern wrote: > > > > > There is no reason you shouldn't be able to use your fast io_uring > > > > completion and lifecycle flow with DMABUF backed

Re: [PATCH 01/17] backlight: Add BL_CORE_ constants for power states

2024-06-11 Thread Sam Ravnborg
Hi Thomas. On Tue, Jun 11, 2024 at 02:41:56PM +0200, Thomas Zimmermann wrote: > Duplicate FB_BLANK_ constants as BL_CORE_ constants in the backlight > header file. Allows backlight drivers to avoid including the fbdev > header file and removes a compile-time dependency between the two >

Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers

2024-06-11 Thread Mina Almasry
On Mon, Jun 10, 2024 at 11:26 PM Christoph Hellwig wrote: > > On Mon, Jun 10, 2024 at 09:16:43AM -0600, David Ahern wrote: > > > > exactly. io_uring, page_pool, dmabuf - all kernel building blocks for > > solutions. This why I was pushing for Mina's set not to be using the > > name `devmem` - it

Re: [RFC PATCH v4 00/42] Color Pipeline API w/ VKMS

2024-06-11 Thread Harry Wentland
On 2024-06-05 06:04, Melissa Wen wrote: > On 02/26, Harry Wentland wrote: >> This is an RFC set for a color pipeline API, along with a sample >> implementation in VKMS. All the key API bits are here. VKMS now >> supports two named transfer function colorops and two matrix >> colorops. We have

Re: [PATCH 0/2] drm bridge: drop drm_bridge_chain_mode_fixup.

2024-06-11 Thread Sam Ravnborg
Hi Robert, On Mon, Jun 10, 2024 at 02:53:09PM +0200, Robert Foss wrote: > On Fri, 31 May 2024 22:37:44 +0200, Sam Ravnborg wrote: > > I had a few bridge related patches in an old branch. > > > > They were last posted here almost one year ago: > >

Re: [PATCH resend v2] drm: renesas: shmobile: Call drm_helper_force_disable_all() at shutdown time

2024-06-11 Thread Doug Anderson
Hi, On Wed, May 29, 2024 at 5:16 AM Geert Uytterhoeven wrote: > > From: Douglas Anderson > > Based on grepping through the source code, this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown time. > This is important because drm_helper_force_disable_all()

[PATCH v2] drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-11 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call

Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1

2024-06-11 Thread Doug Anderson
Hi, On Tue, May 28, 2024 at 9:27 AM Doug Anderson wrote: > > Hi, > > On Mon, May 6, 2024 at 8:54 AM Doug Anderson wrote: > > > > Hi, > > > > On Tue, Apr 23, 2024 at 6:55 PM Xuxin Xiong > > wrote: > > > > > > Hi Doug, thank you! > > > We had reported this info to the CSOT to correct the vendor

Re: [PATCH v10 1/6] dmaengine: Add API function dmaengine_prep_peripheral_dma_vec()

2024-06-11 Thread Vinod Koul
On 05-06-24, 13:08, Paul Cercueil wrote: > This function can be used to initiate a scatter-gather DMA transfer, > where the address and size of each segment is located in one entry of > the dma_vec array. > > The major difference with dmaengine_prep_slave_sg() is that it supports > specifying the

Re: [PATCH 5/6] drm/amdgpu: always enable move threshold for BOs

2024-06-11 Thread Tvrtko Ursulin
Hi Christian, On 04/06/2024 17:05, Christian König wrote: This should prevent buffer moves when the threshold is reached during CS. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 36 -- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 22

Re: [PATCH v2] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

2024-06-11 Thread Doug Anderson
Hi, On Tue, Jun 11, 2024 at 7:05 AM Tejas Vipin wrote: > > mipi_dsi_msleep expects struct mipi_dsi_multi_context to be passed as a > value and not as a reference. > > Fixes: a2ab7cb169da ("drm/panel: himax-hx83102: use wrapped MIPI DCS > functions") > > Signed-off-by: Tejas Vipin Should be no

Re: [PATCH v2] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

2024-06-11 Thread Jessica Zhang
On 6/11/2024 7:05 AM, Tejas Vipin wrote: mipi_dsi_msleep expects struct mipi_dsi_multi_context to be passed as a value and not as a reference. Fixes: a2ab7cb169da ("drm/panel: himax-hx83102: use wrapped MIPI DCS functions") Signed-off-by: Tejas Vipin Hi Tejas, (for future reference, you

Re: [PATCH] drm: Fix alignment of temporary stack ioctl buffers

2024-06-11 Thread T.J. Mercier
On Tue, Jun 11, 2024 at 2:35 AM wrote: > > From: Carsten Haitzler > > In a few places (core drm + AMD kfd driver), the ioctl handling uses a > temporary 128 byte buffer on the stack to copy to/from user. ioctl data > can have structs with types of much larger sizes than a byte and a > system may

[PATCH 2/8] drm: bridge: dw_hdmi: Use passed mode instead of stored previous_mode

2024-06-11 Thread Jonas Karlman
Use the passed mode instead of mixing use of passed mode and the stored previous_mode. The passed mode is currenly always the previous_mode. Also fix a small type and add a variable to help shorten a code line. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9

[PATCH 6/8] drm: bridge: dw_hdmi: Remove cec_notifier_mutex

2024-06-11 Thread Jonas Karlman
With CEC phys addr invalidation moved away from the irq handler there is no longer a need for cec_notifier_mutex, remove it. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git

[PATCH 1/8] drm: bridge: dw_hdmi: Call poweron/poweroff from atomic enable/disable

2024-06-11 Thread Jonas Karlman
Change to only call poweron/poweroff from atomic_enable/atomic_disable ops instead of trying to keep a bridge_is_on state and poweron/off in the hotplug irq handler. A benefit of this is that drm mode_config mutex is always held at poweron/off, something that may reduce the need for our own

[PATCH 7/8] drm: bridge: dw_hdmi: Update EDID during hotplug processing

2024-06-11 Thread Jonas Karlman
Update successfully read EDID during hotplug processing to ensure the connector diplay_info is always up-to-date. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH 4/8] drm: bridge: dw_hdmi: Remove previous_mode and mode_set

2024-06-11 Thread Jonas Karlman
With the use of adjusted_mode directly from the crtc_state there is no longer a need to store a copy in previous_mode, remove it and the now unneeded mode_set ops. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 19 +-- 1 file changed, 1

[PATCH 5/8] drm: bridge: dw_hdmi: Invalidate CEC phys addr from connector detect

2024-06-11 Thread Jonas Karlman
Wait until the connector detect ops is called to invalidate CEC phys addr instead of doing it directly from the irq handler. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git

[PATCH 3/8] drm: bridge: dw_hdmi: Fold poweron and setup functions

2024-06-11 Thread Jonas Karlman
Fold the poweron and setup functions into one function and use the adjusted_mode directly from the new crtc_state to remove the need of storing previous_mode. Signed-off-by: Jonas Karlman --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 21 - 1 file changed, 8 insertions(+),

[PATCH 8/8] drm: bridge: dw_hdmi: Use display_info is_hdmi and has_audio

2024-06-11 Thread Jonas Karlman
drm_edid_connector_update() is being called from bridge connector ops and from detect and get_modes ops for dw-hdmi connector. Change to use is_hdmi and has_audio from display_info directly instead of keeping our own state in sink_is_hdmi and sink_has_audio. Also remove the old and unused edid

[PATCH 0/8] drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup

2024-06-11 Thread Jonas Karlman
This series ensure poweron/poweroff and CEC phys addr invalidation is happening under drm mode_config mutex lock, and also ensure EDID is updated (when the dw-hdmi connector is used) after a hotplug pulse. These changes has mainly been tested on Rockchip devices together with a forthcoming series

Re: [PATCH v2] drm/panel : truly-nt35521: transition to mipi_dsi wrapped functions

2024-06-11 Thread Doug Anderson
Hi, On Tue, Jun 11, 2024 at 7:44 AM Tejas Vipin wrote: > > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce > mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe > ("drm/mipi-dsi: wrap more functions for streamline handling") for the > sony tulip truly nt35521 panel.

Re: [RFC PATCH 3/8] rust: drm: Add Device and Driver abstractions

2024-06-11 Thread Rob Herring
On Sat, Jun 8, 2024 at 11:16 PM Asahi Lina wrote: > > > > On 5/22/24 6:23 AM, Rob Herring wrote: > > On Mon, May 20, 2024 at 07:20:50PM +0200, Danilo Krummrich wrote: > >> From: Asahi Lina > >> > >> Add abstractions for DRM drivers and devices. These go together in one > >> commit since both are

Re: [PATCH v2 3/3] drm/mgag200: Set .detect_ctx() and enable connector polling

2024-06-11 Thread Thomas Zimmermann
Hi Jocelyn Am 11.06.24 um 16:41 schrieb Jocelyn Falempe: On 10/06/2024 16:06, Thomas Zimmermann wrote: Set .detect_ctx() in struct drm_connector_helper_funcs to the common helper drm_connector_helper_detect_from_ddc() and enable polling for the connector. Mgag200 will now test for the

[PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-11 Thread Douglas Anderson
At shutdown if you've got a _properly_ coded DRM modeset driver then you'll get these two warnings at shutdown time: Skipping disable of already disabled panel Skipping unprepare of already unprepared panel These warnings are ugly and sound concerning, but they're actually a sign of a

Re: [PATCH] drm/i915/gt: debugfs: Evaluate forcewake usage within locks

2024-06-11 Thread Nirmoy Das
On 6/11/2024 3:58 PM, Tvrtko Ursulin wrote: On 10/06/2024 10:24, Nirmoy Das wrote: Hi Andi, On 6/7/2024 4:51 PM, Andi Shyti wrote: The forcewake count and domains listing is multi process critical and the uncore provides a spinlock for such cases. Lock the forcewake evaluation section in

Re: [PATCH v2 1/5] dt-bindings: connector: add GE SUNH hotplug addon connector

2024-06-11 Thread Luca Ceresoli
Hello Rob, thanks for the follow up. I still have a couple questions for you before I see a clear direction forward, see below. On Wed, 5 Jun 2024 08:45:31 -0600 Rob Herring wrote: [...] > > > > + # "base" overlay describing the common components on every add-on > > > > that > > > > + #

Re: [PATCH v2 3/3] drm/mgag200: Set .detect_ctx() and enable connector polling

2024-06-11 Thread Jocelyn Falempe
On 10/06/2024 16:06, Thomas Zimmermann wrote: Set .detect_ctx() in struct drm_connector_helper_funcs to the common helper drm_connector_helper_detect_from_ddc() and enable polling for the connector. Mgag200 will now test for the monitor's presence by probing the DDC in regular intervals.

Re: [PATCH v2 2/3] drm/mgag200: Add BMC output

2024-06-11 Thread Jocelyn Falempe
On 10/06/2024 16:06, Thomas Zimmermann wrote: The BMC output can be viewed via the BMC's web interface or a similar client. Represent it as virtual encoder and connector. It's attached to the same CRTC as the VGA connector. The connector's status depends on the physical connector's status.

Re: [PATCH v2 1/3] drm/mgag200: Consolidate VGA output

2024-06-11 Thread Jocelyn Falempe
On 10/06/2024 16:06, Thomas Zimmermann wrote: The various models have common code for the VGA output's encoder and connector. Move everything into a single shared source file. Remove some obsolete initializer macros. No functional changes. Thanks for this patch, it removes some duplication,

Re: [PATCH v2] drm: add missing MODULE_DESCRIPTION() macros

2024-06-11 Thread Jeff Johnson
On 6/11/2024 6:56 AM, Jeff Johnson wrote: > On x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/gud/gud.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/drm_panel_orientation_quirks.o > WARNING: modpost:

Re: [PATCH] drm/i915/gt: debugfs: Evaluate forcewake usage within locks

2024-06-11 Thread Tvrtko Ursulin
On 10/06/2024 10:24, Nirmoy Das wrote: Hi Andi, On 6/7/2024 4:51 PM, Andi Shyti wrote: The forcewake count and domains listing is multi process critical and the uncore provides a spinlock for such cases. Lock the forcewake evaluation section in the fw_domains_show() debugfs interface.

[PATCH v2] drm: add missing MODULE_DESCRIPTION() macros

2024-06-11 Thread Jeff Johnson
On x86, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/gud/gud.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/drm_panel_orientation_quirks.o WARNING: modpost: missing MODULE_DESCRIPTION() in

Re: [PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-06-11 Thread Andy Shevchenko
On Tue, Jun 11, 2024 at 06:46:12AM -0700, Jeff Johnson wrote: > On 4/25/24 05:56, Andy Shevchenko wrote: ... > I'll remove this from my series No need, Maxime already applied, and I see 665415092eca ("drm: add missing MODULE_DESCRIPTION() macros") > Reviewed-by: Jeff Johnson But thanks. --

Re: [PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-06-11 Thread Jeff Johnson
On 4/25/24 05:56, Andy Shevchenko wrote: The modpost script is not happy WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/drm_mipi_dbi.o because there is a missing module description. Add it to the module. Signed-off-by: Andy Shevchenko ---

Re: [PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-06-11 Thread Jeff Johnson
On 6/11/2024 6:34 AM, Andy Shevchenko wrote: > On Wed, Jun 05, 2024 at 11:38:31PM +0300, Andy Shevchenko wrote: >> On Thu, Apr 25, 2024 at 03:56:26PM +0300, Andy Shevchenko wrote: >>> The modpost script is not happy >>> >>> WARNING: modpost: missing MODULE_DESCRIPTION() in >>>

Re: [PATCH] drm/i915/gt/uc: Evaluate GuC priority within locks

2024-06-11 Thread Andi Shyti
Hi Daniele, thanks for checking this patch. > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > index 0eaa1064242c..1181043bc5e9 100644 > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > +++

Re: [PATCH] drm/i915/gt: debugfs: Evaluate forcewake usage within locks

2024-06-11 Thread Andi Shyti
Hi Rodrigo, ... > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > index 4fcba42cfe34..0437fd8217e0 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c > > @@

Re: [PATCH v1 1/1] drm/mipi-dbi: Add missing MODULE_DESCRIPTION()

2024-06-11 Thread Andy Shevchenko
On Wed, Jun 05, 2024 at 11:38:31PM +0300, Andy Shevchenko wrote: > On Thu, Apr 25, 2024 at 03:56:26PM +0300, Andy Shevchenko wrote: > > The modpost script is not happy > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in > > drivers/gpu/drm/drm_mipi_dbi.o > > > > because there is a

Re: [PATCH v13 12/12] drm/ttm/tests: Use u32 and u64 over uint*_t types

2024-06-11 Thread Thomas Hellström
On Mon, 2024-06-03 at 15:36 +0200, Karolina Stolarek wrote: > Update the tests and helpers to use unsigned kernel types. > > Signed-off-by: Karolina Stolarek > Suggested-by: Thomas Hellström Reviewed-by: Thomas Hellström > --- >  drivers/gpu/drm/ttm/tests/ttm_bo_test.c   | 12 ++--

Re: [PATCH v13 11/12] drm/ttm/tests: Correct modules' licenses

2024-06-11 Thread Thomas Hellström
On Mon, 2024-06-03 at 15:36 +0200, Karolina Stolarek wrote: > The test files are GPL and MIT, so update the definitions > accordingly. > > Signed-off-by: Karolina Stolarek Reviewed-by: Thomas Hellström > --- >  drivers/gpu/drm/ttm/tests/ttm_bo_test.c   | 2 +- >  

Re: [PATCH v13 06/12] drm/ttm/tests: Add tests with mock resource managers

2024-06-11 Thread Thomas Hellström
On Mon, 2024-06-03 at 15:36 +0200, Karolina Stolarek wrote: > Add mock resource manager to test ttm_bo_validate() with non-system > placements. Update KConfig entry to enable DRM Buddy allocator, used > by the mock manager. Update move function to do more than just assign > a resource. > >

[PATCH 11/17] backlight: lm3533-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/lm3533_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 15/17] backlight: pwm-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/pwm_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 07/17] backlight: journada_bl: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/jornada720_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 06/17] backlight: ipaq-micro-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/ipaq_micro_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 13/17] backlight: pandora-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/pandora_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 08/17] backlight: kb3886-bl: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/kb3886_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 12/17] backlight: mp3309c: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/mp3309c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 03/17] backlight: ams369fb06: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/ams369fg06.c | 23 +++ 1 file changed, 11 insertions(+), 12

[PATCH 16/17] backlight: rave-sp-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/rave-sp-backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 05/17] backlight: gpio-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/gpio_backlight.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff

[PATCH 02/17] backlight: aat2870-backlight: Use blacklight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/aat2870_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 14/17] backlight: pcf50633-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/pcf50633-backlight.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH 17/17] backlight: sky81452-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/sky81452-backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 09/17] backlight: ktd253-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/ktd253-backlight.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH 10/17] backlight: led-backlight: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/led_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 04/17] backlight: corgi-lcd: Use backlight power constants

2024-06-11 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Only change the driver's backlight device, but leave the LCD device as-is. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/corgi_lcd.c

[PATCH 01/17] backlight: Add BL_CORE_ constants for power states

2024-06-11 Thread Thomas Zimmermann
Duplicate FB_BLANK_ constants as BL_CORE_ constants in the backlight header file. Allows backlight drivers to avoid including the fbdev header file and removes a compile-time dependency between the two subsystems. The new BL_CORE constants have the same values as their FB_BLANK_ counterparts.

[PATCH 15/15] accel/ivpu: Remove unused ivpu_rpm_get_if_active()

2024-06-11 Thread Jacek Lawrynowicz
This is now dead code and has to be removed. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_pm.c | 10 -- drivers/accel/ivpu/ivpu_pm.h | 1 - 2 files changed, 11 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.c index

[PATCH 14/15] accel/ivpu: Remove duplicated debug messages

2024-06-11 Thread Jacek Lawrynowicz
Remove duplicated debug messages from ivpu_jsm_(un)register_db(). Debug messages are already printed one level higher. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_jsm_msg.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git

[PATCH 07/15] accel/ivpu: Make selected params read-only

2024-06-11 Thread Jacek Lawrynowicz
Make disable_mmu_cont_pages and force_snoop params read-only. It is unsafe to change these params after driver is loaded. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_drv.c

[PATCH 13/15] accel/ivpu: Increase autosuspend delay to 100ms on 40xx

2024-06-11 Thread Jacek Lawrynowicz
From: Andrzej Kacprowski The new HW is more power efficient and there is no need to enter the D0i3/D3 so quickly. Increasing autosuspend delay reduces latency in certain usage scenarios. Signed-off-by: Andrzej Kacprowski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_hw.c | 5

[PATCH 12/15] accel/ivpu: Synchronize device unbind with recovery work

2024-06-11 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Do not allow unbinding device in the middle of recovery flow. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_drv.c

[PATCH 11/15] accel/ivpu: Disable MMU before checking for idle

2024-06-11 Thread Jacek Lawrynowicz
Disable MMU communication before checking if NPU is idle. NPU may otherwise be woken up when adding/removing contexts. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_pm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/accel/ivpu/ivpu_pm.c

[PATCH 05/15] accel/ivpu: Disable clock relinquish for MMIO reset

2024-06-11 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" It is required to disable NPU clock relinquish for the time of MMIO reset. Clock relinquish gets into default (enabled) state after MMIO reset is performed. Signed-off-by: Wachowski, Karol Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_hw_btrs.c | 2 ++

[PATCH 09/15] accel/ivpu: Make parts of FW image read-only

2024-06-11 Thread Jacek Lawrynowicz
From: "Wachowski, Karol" Implement setting specified buffer ranges as read-only. In case if specified range is not 64K aligned and 64K contiguous MMU600 pages are turned on, split 64K mapping to allow 4K granularity for read-only configuration. Signed-off-by: Wachowski, Karol Signed-off-by:

[PATCH 10/15] accel/ivpu: Add test mode flag for disabling timeouts

2024-06-11 Thread Jacek Lawrynowicz
From: Maciej Falkowski Add new test mode flag that will disable all timeouts defined in timeout fields of struct ivpu_device. Remove also reschedule_suspend field as it is unused. Signed-off-by: Maciej Falkowski Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.h | 2 +-

  1   2   >