Re: [PATCH v10 3/6] iio: core: Add new DMABUF interface infrastructure

2024-06-16 Thread Markus Elfring
… > +++ b/drivers/iio/industrialio-buffer.c … > static int iio_buffer_chrdev_release(struct inode *inode, struct file *filep) > { … > wake_up(&buffer->pollq); > > + mutex_lock(&buffer->dmabufs_mutex); > + > + /* Close all attached DMABUFs */ … > + mutex_unlock(&buffer->dmabufs_m

Re: [PATCH v6,12/24] media: mediatek: vcodec: add interface to allocate/free secure memory

2024-06-16 Thread 吴勇
On Wed, 2024-06-12 at 14:22 +0900, Tomasz Figa wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Thu, May 16, 2024 at 08:20:50PM +0800, Yunfei Dong wrote: > > Need to call dma heap interface to allocate/free

Re: [PATCH v10 3/6] iio: core: Add new DMABUF interface infrastructure

2024-06-16 Thread Nuno Sá
On Sat, 2024-06-15 at 13:07 +0200, Paul Cercueil wrote: > Le dimanche 09 juin 2024 à 10:53 +0100, Jonathan Cameron a écrit : > > On Wed,  5 Jun 2024 13:08:42 +0200 > > Paul Cercueil wrote: > > > > > Add the necessary infrastructure to the IIO core to support a new > > > optional DMABUF based inte

drm/bridge/imx8mp-hdmi-tx: Allow inexact pixel clock frequencies (Was: [PATCH V8 10/12] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI)

2024-06-16 Thread Dominique MARTINET
Adam Ford wrote on Sat, Feb 03, 2024 at 10:52:50AM -0600: > From: Lucas Stach > > Add a simple wrapper driver for the DWC HDMI bridge driver that > implements the few bits that are necessary to abstract the i.MX8MP > SoC integration. Hi Lucas, Adam, (trimmed ccs a bit) First, thank you for the

[drm-intel:for-linux-next-gt 3/5] drivers/gpu/drm/i915/gem/i915_gem_stolen.c:942:5: error: format specifies type 'long long' but the argument has type 'resource_size_t' (aka 'unsigned int')

2024-06-16 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-gt head: ae45f07cade1a5853ff6fd745bbd86a64cc82643 commit: 05da7d9f717bcb03c457379fa8a61c1689dab86c [3/5] drm/i915/gem: Downgrade stolen lmem setup warning config: i386-randconfig-053-20240617 (https://download.01.org/0day-ci/archive

Re: [PATCH v6, 19/24] media: mediatek: vcodec: disable wait interrupt for svp mode

2024-06-16 Thread 董云飞
Hi CK, Sorry to reply your suggestion too late. Thanks for your help to review this patch. On Fri, 2024-05-17 at 09:53 +, CK Hu (胡俊光) wrote: > Hi, Yunfei: > > On Thu, 2024-05-16 at 20:20 +0800, Yunfei Dong wrote: > > Waiting interrupt in optee-os for svp mode, need to disable it in > > kerne

Re: [PATCH v4 resend 8/9] video: fbdev: use for_each_endpoint_of_node()

2024-06-16 Thread Helge Deller
On 6/17/24 02:59, Kuninori Morimoto wrote: We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart applied to fbdev git tree. Thanks! Helge --- drivers/video/fbdev/omap2/omap

Re: [PATCH v4 resend 0/9] use for_each_endpoint_of_node()

2024-06-16 Thread Helge Deller
On 6/17/24 02:58, Kuninori Morimoto wrote: Hi Rob, Helge, +Sakari, +Hans Hi Kuninori, 2 weeks past. This is resend v4 patch-set. I add +Sakari, +Hans on To. We already have for_each_endpoint_of_node(), but some drivers are not using it. This patch-set replace it. This patch-set is related t

Re: [PATCH v4 resend 9/9] fbdev: omapfb: use of_graph_get_remote_port()

2024-06-16 Thread Helge Deller
On 6/17/24 02:59, Kuninori Morimoto wrote: We already have of_graph_get_remote_port(), Let's use it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart applied to fbdev git tree. Thanks! Helge --- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 15 +-- 1 file ch

Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2024-06-16 Thread Jan Kiszka
On 16.02.24 15:57, Marek Vasut wrote: > On 2/16/24 10:10, Tomi Valkeinen wrote: >> On 15/02/2024 11:03, Alexander Stein wrote: >>> Hi everyone, >>> >>> Am Donnerstag, 15. Februar 2024, 09:53:54 CET schrieb Jan Kiszka: On 11.12.23 09:07, Aradhya Bhatia wrote: > On 06/12/23 17:41, Tomi Valke

Re: WARNING in drm_mode_create_lease_ioctl

2024-06-16 Thread Dave Airlie
Cc'ing dri-devel Does https://lore.kernel.org/dri-devel/20240617035258.2774032-1-airl...@gmail.com/T/#u help? Thanks, Dave. On Mon, 17 Jun 2024 at 13:12, Ubisectech Sirius wrote: > > Hello. > We are Ubisectech Sirius Team, the vulnerability lab of China ValiantSec. > Recently, our team has d

[PATCH] drm/lease: use kvcalloc instead of kcalloc to avoid warn triggering.

2024-06-16 Thread Dave Airlie
From: Dave Airlie Attempt to use kvmalloc to avoid kmalloc warnings on larger allocations. It might make sense to try and make a limit for the number of objects allowed here. [ cut here ] WARNING: CPU: 1 PID: 18929 at mm/page_alloc.c:4545 __alloc_pages+0x402/0x21b0 mm/

Re: [PATCH] drm/mediatek: Remove less-than-zero comparison of an unsigned value

2024-06-16 Thread 胡俊光

Re: [PATCH] nouveau: rip out busy fence waits

2024-06-16 Thread Ben Skeggs
On 17/4/24 15:40, Dave Airlie wrote: External email: Use caution opening links or attachments From: Dave Airlie I'm pretty sure this optimisation is actually not a great idea, and is racy with other things waiting for fences. Just nuke it, there should be no need to do fence waits in a busy

[PATCH v4 resend 9/9] fbdev: omapfb: use of_graph_get_remote_port()

2024-06-16 Thread Kuninori Morimoto
We already have of_graph_get_remote_port(), Let's use it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart --- drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss

[PATCH v4 resend 8/9] video: fbdev: use for_each_endpoint_of_node()

2024-06-16 Thread Kuninori Morimoto
We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart --- drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --g

[PATCH v4 resend 7/9] staging: media: atmel: use for_each_endpoint_of_node()

2024-06-16 Thread Kuninori Morimoto
We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart --- .../staging/media/deprecated/atmel/atmel-sama5d2-isc.c | 10 +++--- .../staging/media/deprecated/atmel/atmel-sama7g5-i

[PATCH v4 resend 6/9] media: platform: xilinx: use for_each_endpoint_of_node()

2024-06-16 Thread Kuninori Morimoto
We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart --- drivers/media/platform/xilinx/xilinx-vipp.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/d

[PATCH v4 resend 5/9] media: platform: ti: use for_each_endpoint_of_node()

2024-06-16 Thread Kuninori Morimoto
We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart --- drivers/media/platform/ti/am437x/am437x-vpfe.c | 12 +--- drivers/media/platform/ti/davinci/vpif_capture.c | 14

[PATCH v4 resend 4/9] media: platform: microchip: use for_each_endpoint_of_node()

2024-06-16 Thread Kuninori Morimoto
We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart --- .../microchip/microchip-sama5d2-isc.c | 21 +++ .../microchip/microchip-sama7g5-isc.c | 21

[PATCH v4 resend 3/9] hwtracing: use for_each_endpoint_of_node()

2024-06-16 Thread Kuninori Morimoto
We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Reviewed-by: Suzuki K Poulose Reviewed-by: Laurent Pinchart Reviewed-by: James Clark --- drivers/hwtracing/coresight/coresight-platform.c | 4 ++-- 1 file

[PATCH v4 resend 2/9] gpu: drm: use for_each_endpoint_of_node()

2024-06-16 Thread Kuninori Morimoto
We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Acked-by: Dmitry Baryshkov Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

[PATCH v4 resend 1/9] gpu: drm: replace of_graph_get_next_endpoint()

2024-06-16 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); + of_graph_get_endpoint_by_r

[PATCH v4 resend 0/9] use for_each_endpoint_of_node()

2024-06-16 Thread Kuninori Morimoto
Hi Rob, Helge, +Sakari, +Hans 2 weeks past. This is resend v4 patch-set. I add +Sakari, +Hans on To. We already have for_each_endpoint_of_node(), but some drivers are not using it. This patch-set replace it. This patch-set is related to "OF" (= Rob), but many driveres are for "MultiMedia" (= H

Re: Kernel 5.15.150 black screen with AMD Raven/Picasso GPU

2024-06-16 Thread Armin Wolf
Am 23.05.24 um 18:29 schrieb Greg KH: On Thu, May 23, 2024 at 05:59:39PM +0200, Armin Wolf wrote: Am 23.05.24 um 15:13 schrieb Barry Kauler: On Wed, May 22, 2024 at 12:58 AM Armin Wolf wrote: Am 20.05.24 um 18:22 schrieb Alex Deucher: On Sat, May 18, 2024 at 8:17 PM Armin Wolf wrote: Am

Re: [PATCH] drm: zynqmp_dpsub: Fix an error handling path in zynqmp_dpsub_probe()

2024-06-16 Thread Laurent Pinchart
On Thu, Jun 13, 2024 at 11:05:01AM -0400, Sean Anderson wrote: > On 5/20/24 11:05, Sean Anderson wrote: > > On 5/20/24 05:40, Christophe JAILLET wrote: > >> If zynqmp_dpsub_drm_init() fails, we must undo the previous > >> drm_bridge_add() call. > >> > >> Fixes: be3f3042391d ("drm: zynqmp_dpsub: Al

Re: [PATCH] drm/amdgpu: convert bios_hardcoded_edid to drm_edid

2024-06-16 Thread Thomas Weißschuh
On 2024-06-16 11:12:03+, Thomas Weißschuh wrote: > Instead of manually passing around 'struct edid *' and its size, > use 'struct drm_edid', which encapsulates a validated combination of > both. > > As the drm_edid_ can handle NULL gracefully, the explicit checks can be > dropped. > > Also sa

Re: [PATCH] drm/panic: depends on !VT_CONSOLE

2024-06-16 Thread Javier Martinez Canillas
Jocelyn Falempe writes: Hello Jocelyn, > The race condition between fbcon and drm_panic can only occurs if > VT_CONSOLE is set. So update drm_panic dependency accordingly. > This will make it easier for Linux distributions to enable drm_panic > by disabling VT_CONSOLE, and keeping fbcon terminal

Re: [PATCH v3] drm/fb-helper: Detect when lid is closed during initialization

2024-06-16 Thread kernel test robot
m-misc drm-misc-next patch link: https://lore.kernel.org/r/20240613051700.1112-1-mario.limonciello%40amd.com patch subject: [PATCH v3] drm/fb-helper: Detect when lid is closed during initialization config: x86_64-buildonly-randconfig-003-20240614 (https://download.01.org/0day-ci/archiv

vc4: WARNING during suspend to idle of Raspberry Pi 3 Plus

2024-06-16 Thread Stefan Wahren
Hi, i'm currently experiment with suspend to idle on the Raspberry Pi [1]. During my tests, i noticed a WARNING of the vc4 during suspend incl. Runtime PM usage count underflow. It would be nice if someone can look at it. In case you want to reproduce it, i can prepare a branch with some improvem

[PATCH] drm/amdgpu: convert bios_hardcoded_edid to drm_edid

2024-06-16 Thread Thomas Weißschuh
struct amdgpu_device *adev = (struct amdgpu_device *)handle; - kfree(adev->mode_info.bios_hardcoded_edid); + drm_edid_free(adev->mode_info.bios_hardcoded_edid); drm_kms_helper_poll_fini(adev_to_drm(adev)); --- base-commit: a3e18a540541325a8c8848171f71e0d45ad30b2c change-id: 20240616-amdgpu-edid-bios-a31aa16b0321 Best regards, -- Thomas Weißschuh

Re: [PATCH v2 5/7] drm/panic: Convert to drm_fb_clip_offset()

2024-06-16 Thread Geert Uytterhoeven
On Sun, Jun 16, 2024 at 11:08 AM Geert Uytterhoeven wrote: > On Sat, Jun 15, 2024 at 12:55 PM kernel test robot wrote: > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on drm-misc/drm-misc-next] > > [cannot apply to linus/master v6.10-rc3 next-20240613] > >

Re: [PATCH v2 5/7] drm/panic: Convert to drm_fb_clip_offset()

2024-06-16 Thread Geert Uytterhoeven
On Sat, Jun 15, 2024 at 12:55 PM kernel test robot wrote: > kernel test robot noticed the following build errors: > > [auto build test ERROR on drm-misc/drm-misc-next] > [cannot apply to linus/master v6.10-rc3 next-20240613] > [If your patch is applied to the wrong git tree, kindly drop us a note.

[PATCH 05/13] drm/mediatek: Set DRM mode configs accordingly

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung Set DRM mode configs limitation according to the hardware capabilities and pass the IGT checks as below: - The test "graphics.IgtKms.kms_plane" requires a frame buffer with width of 4512 pixels (> 4096). - The test "graphics.IgtKms.kms_cursor_crc" checks if the cursor si

[PATCH 04/13] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung Always add DRM_MODE_ROTATE_0 to rotation property to meet IGT's (Intel GPU Tools) requirement. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 6 +- drivers/gpu/drm/mediatek/

[PATCH 10/13] drm/mediatek: Fix XRGB setting error in Mixer

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung Although the alpha channel in XRGB formats can be ignored, ALPHA_CON must be configured accordingly when using XRGB formats or it will still affects CRC generation. Fixes: d886c0009bd0 ("drm/mediatek: Add ETHDR support for MT8195") Signed-off-by: Hsiao Chien Sung Reviewed

[PATCH 12/13] drm/mediatek: Support DRM plane alpha in OVL

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung Set the plane alpha according to DRM plane property. Signed-off-by: Hsiao Chien Sung Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drive

[PATCH 09/13] drm/mediatek: Fix XRGB setting error in OVL

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung CONST_BLD must be enabled for XRGB formats although the alpha channel can be ignored, or OVL will still read the value from memory. This error only affects CRC generation. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Hsiao Ch

[PATCH 01/13] soc: mediatek: Disable 9-bit alpha in ETHDR

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung When 9-bit alpha is enabled, its value will be converted from 0-255 to 0-256 (255 = not defined). This is designed for special HDR related calculation, which should be disabled by default, otherwise, alpha blending will not work correctly. Reviewed-by: AngeloGioacchino Del

[PATCH 11/13] drm/mediatek: Add new color format MACROs in OVL

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung Define new color formats to hide the bit operation in the MACROs to make the switch statement more concise. Change the MACROs to align the naming rule in DRM. Signed-off-by: Hsiao Chien Sung Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 14 ---

[PATCH 00/13] Fix the errors of MediaTek display driver found by IGT

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
This series fixes the errors of MediaTek display driver found by IGT. Signed-off-by: Hsiao Chien Sung --- Hsiao Chien Sung (13): soc: mediatek: Disable 9-bit alpha in ETHDR drm/mediatek: Add OVL compatible name for MT8195 drm/mediatek: Add missing plane settings when async updat

[PATCH 03/13] drm/mediatek: Add missing plane settings when async update

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung Fix an issue that plane coordinate was not saved when calling async update. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/d

[PATCH 13/13] drm/mediatek: Support DRM plane alpha in Mixer

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung Set the plane alpha according to DRM plane property. Signed-off-by: Hsiao Chien Sung Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu

[PATCH 07/13] drm/mediatek: Support more 10bit formats in OVL

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung Support more 10bit formats in OVL. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --gi

[PATCH 08/13] drm/mediatek: Support RGBA8888 and RGBX8888 in OVL on MT8195

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung Support RGBA and RGBX formats in OVL on MT8195. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediate

[PATCH 02/13] drm/mediatek: Add OVL compatible name for MT8195

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung Add OVL compatible name for MT8195. Without this commit, DRM won't work after modifying the device tree. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 ins

[PATCH 06/13] drm/mediatek: Turn off the layers with zero width or height

2024-06-16 Thread Hsiao Chien Sung via B4 Relay
From: Hsiao Chien Sung We found that IGT (Intel GPU Tool) will try to commit layers with zero width or height and lead to undefined behaviors in hardware. Disable the layers in such a situation. Fixes: 453c3364632a ("drm/mediatek: Add ovl_adaptor support for MT8195") Fixes: d886c0009bd0 ("drm/me

[PATCH 1/2] drm/i915/gem: Return -EINVAL instead of '0'

2024-06-16 Thread Andi Shyti
Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup warning") returns '0' from i915_gem_stolen_lmem_setup(), but it's supposed to return a pointer to the intel_memory_region structure. Sparse complains with the following message: >> drivers/gpu/drm/i915/gem/i915_gem_stolen.c:943:32: s

[PATCH 2/2] drm/i915/gem: Use the correct format specifier for resource_size_t

2024-06-16 Thread Andi Shyti
Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup warning") adds a debug message where the "lmem_size" and "dsm_base" variables are printed using the %lli identifier. However, these variables are defined as resource_size_t, which are unsigned long for 32-bit machines and unsigned lon

[PATCH 0/2] Sparse errors on the i915_gem_stolen

2024-06-16 Thread Andi Shyti
Hi Jonathan, Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup warning") produces two sparse warnings. The first one being a bit more sever as it might cause a segmentation fault. Andi Cc: Jonathan Cavitt Andi Shyti (2): drm/i915/gem: Return -EINVAL instead of '0' drm/i915/ge