[PATCH] tty: vt: add missing MODULE_DESCRIPTION() macros

2024-06-21 Thread Jeff Johnson
le/vgacon.c @@ -1222,4 +1222,5 @@ void vgacon_register_screen(struct screen_info *si) vga_si = si; } +MODULE_DESCRIPTION("VGA based console driver"); MODULE_LICENSE("GPL"); --- base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f change-id: 20240621-md-i386-drivers-video-console-ae292c09bb67

[PATCH] agp: add remaining missing MODULE_DESCRIPTION() macros

2024-06-21 Thread Jeff Johnson
orks_cleanup(void) module_init(agp_serverworks_init); module_exit(agp_serverworks_cleanup); +MODULE_DESCRIPTION("Serverworks AGPGART routines"); MODULE_LICENSE("GPL and additional rights"); --- base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f change-id: 20240621-md-i386-drivers-char-agp-d7221005d737

Re: [RFC PATCH 1/4] drm/msm: register a fault handler for display mmu faults

2024-06-21 Thread Abhinav Kumar
On 6/21/2024 4:35 PM, Abhinav Kumar wrote: On 5/19/2024 1:38 AM, Dmitry Baryshkov wrote: On Fri, May 17, 2024 at 04:37:56PM -0700, Abhinav Kumar wrote: In preparation to register a iommu fault handler for display related modules, register a fault handler for the backing mmu object of msm_k

Re: [RFC PATCH 1/4] drm/msm: register a fault handler for display mmu faults

2024-06-21 Thread Abhinav Kumar
On 5/20/2024 9:12 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-05-17 16:37:56) diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu/drm/msm/msm_kms.c index af6a6fcb1173..62c8e6163e81 100644 --- a/drivers/gpu/drm/msm/msm_kms.c +++ b/drivers/gpu/drm/msm/msm_kms.c @@ -200,6 +200,28 @@

[PATCH 0/3] [CI] Extend Wa14019159160 and enable for ARL and DG2

2024-06-21 Thread John . C . Harrison
From: John Harrison The context switch out workaround requires an extra piece on top. Also, it applies to more platforms. Signed-off-by: John Harrison John Harrison (3): drm/i915/arl: Enable Wa_14019159160 for ARL drm/i915/guc: Extend w/a 14019159160 drm/i915/dg2: Enable Wa_14019159160

[PATCH 2/3] drm/i915/guc: Extend w/a 14019159160

2024-06-21 Thread John . C . Harrison
From: John Harrison There is a new part to an existing workaround, so enable that piece as well. v2: Extend even further. v3: Drop DG2 as there are CI failures still to resolve. Also re-order the parameters to a function to reduce excessive line wrapping. Signed-off-by: John Harrison --- driv

[PATCH 3/3] drm/i915/dg2: Enable Wa_14019159160 for DG2

2024-06-21 Thread John . C . Harrison
From: John Harrison The context switch hold out workaround also applies to DG2. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 3 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr

[PATCH 1/3] drm/i915/arl: Enable Wa_14019159160 for ARL

2024-06-21 Thread John . C . Harrison
From: John Harrison The context switch out workaround also applies to ARL. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/

[PATCH 0/2] Extend Wa14019159160 and enable for ARL

2024-06-21 Thread John . C . Harrison
From: John Harrison The context switch out workaround requires an extra piece on top. Also, it applies to more platforms. Signed-off-by: John Harrison John Harrison (2): drm/i915/arl: Enable Wa_14019159160 for ARL drm/i915/guc: Extend w/a 14019159160 drivers/gpu/drm/i915/gt/uc/abi/guc_k

[PATCH 2/2] drm/i915/guc: Extend w/a 14019159160

2024-06-21 Thread John . C . Harrison
From: John Harrison There is a new part to an existing workaround, so enable that piece as well. v2: Extend even further. v3: Drop DG2 as there are CI failures still to resolve. Also re-order the parameters to a function to reduce excessive line wrapping. Signed-off-by: John Harrison --- driv

[PATCH 1/2] drm/i915/arl: Enable Wa_14019159160 for ARL

2024-06-21 Thread John . C . Harrison
From: John Harrison The context switch out workaround also applies to ARL. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/

Re: [PATCH v3 12/23] mfd: Add new driver for MAX77705 PMIC

2024-06-21 Thread kernel test robot
Hi Dzmitry, kernel test robot noticed the following build errors: [auto build test ERROR on 6906a84c482f098d31486df8dc98cead21cce2d0] url: https://github.com/intel-lab-lkp/linux/commits/Dzmitry-Sankouski/power-supply-add-undervoltage-health-status-property/20240618-222456 base: 6906a84c482

Re: [RFC PATCH 1/4] drm/msm: register a fault handler for display mmu faults

2024-06-21 Thread Abhinav Kumar
On 5/19/2024 1:38 AM, Dmitry Baryshkov wrote: On Fri, May 17, 2024 at 04:37:56PM -0700, Abhinav Kumar wrote: In preparation to register a iommu fault handler for display related modules, register a fault handler for the backing mmu object of msm_kms. Currently, the fault handler only capture

Re: [RFC PATCH 1/4] drm/msm: register a fault handler for display mmu faults

2024-06-21 Thread Abhinav Kumar
On 5/19/2024 1:31 AM, Dmitry Baryshkov wrote: On Fri, May 17, 2024 at 04:37:56PM -0700, Abhinav Kumar wrote: In preparation to register a iommu fault handler for display related modules, register a fault handler for the backing mmu object of msm_kms. Currently, the fault handler only capture

Re: [PATCH 2/2] drm/panel-xinpeng-xpp055c272: add check for mipi_dsi_dcs_enter_sleep_mode

2024-06-21 Thread Dmitry Baryshkov
On Thu, Jun 20, 2024 at 03:48:02PM GMT, Chen Ni wrote: > Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and > return the error if it fails in order to catch the error. > > Signed-off-by: Chen Ni > --- > drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 2 +- > 1 file changed,

Re: [PATCH 1/2] drm/panel: ltk050h3146w: add check for mipi_dsi_dcs_enter_sleep_mode

2024-06-21 Thread Dmitry Baryshkov
On Thu, Jun 20, 2024 at 03:47:20PM GMT, Chen Ni wrote: > Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and > return the error if it fails in order to catch the error. > > Signed-off-by: Chen Ni > --- > drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 +- > 1 file change

Re: [git pull] drm fixes for 6.10-rc5

2024-06-21 Thread pr-tracker-bot
The pull request you sent on Sat, 22 Jun 2024 06:41:13 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-06-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d6c941570680d4d11e5c7480c3bcbeff8d3860f9 Thank you! -- Deet-doot-dot, I am a bot. h

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-21 Thread Rob Clark
On Sat, Jun 8, 2024 at 8:44 AM Kiarash Hajian wrote: > > The driver's memory regions are currently just ioremap()ed, but not > reserved through a request. That's not a bug, but having the request is > a little more robust. > > Implement the region-request through the corresponding managed > devres

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-21 Thread Doug Anderson
Hi, On Fri, Jun 21, 2024 at 1:45 PM Douglas Anderson wrote: > > At shutdown if you've got a _properly_ coded DRM modeset driver then > you'll get these two warnings at shutdown time: > > Skipping disable of already disabled panel > Skipping unprepare of already unprepared panel > > These warn

[PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-21 Thread Douglas Anderson
At shutdown if you've got a _properly_ coded DRM modeset driver then you'll get these two warnings at shutdown time: Skipping disable of already disabled panel Skipping unprepare of already unprepared panel These warnings are ugly and sound concerning, but they're actually a sign of a properl

[git pull] drm fixes for 6.10-rc5

2024-06-21 Thread Dave Airlie
Hey Linus, Still pretty quiet, two weeks worth of amdgpu fixes, with one i915 and one xe. I didn't get the drm-misc-fixes tree PR this week, but there was only one fix queued and I think it can way another week, so seems pretty normal. Dave. drm-fixes-2024-06-22: drm fixes for 6.10-rc5 xe: - Fi

Re: [PATCH v3 17/23] mfd: add s2dos series core driver

2024-06-21 Thread kernel test robot
Hi Dzmitry, kernel test robot noticed the following build warnings: [auto build test WARNING on 6906a84c482f098d31486df8dc98cead21cce2d0] url: https://github.com/intel-lab-lkp/linux/commits/Dzmitry-Sankouski/power-supply-add-undervoltage-health-status-property/20240618-222456 base: 6906a84

Re: [PATCH v1 2/3] drm/panel: st7701: Add support for SPI for configuration

2024-06-21 Thread Jessica Zhang
On 6/18/2024 1:15 AM, Hironori KIKUCHI wrote: The ST7701 supports not only MIPI DSI, but also SPI as an interface for configuration. To support a panel connected via RGB parallel interface, add support for SPI using MIPI DBI helpers. Signed-off-by: Hironori KIKUCHI --- drivers/gpu/drm/pane

Re: [PATCH net-next v12 10/13] tcp: RX path for devmem TCP

2024-06-21 Thread Mina Almasry
On Mon, Jun 17, 2024 at 9:36 AM Pavel Begunkov wrote: > > On 6/13/24 02:35, Mina Almasry wrote: > > > > The pages awaiting freeing are stored in the newly added > > sk->sk_user_frags, and each page passed to userspace is get_page()'d. > > This reference is dropped once the userspace indicates that

[PATCH] drm/rockchip: analogix_dp: allow to work without panel

2024-06-21 Thread Lucas Stach
When the DP output is routed to a external connector there is no need for a fixed panel, as the panel may be detected via EDID on the AUX channel. Allow to continue probing if no panel reference is present. Signed-off-by: Lucas Stach --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +- 1

Re: [PATCH] drm/panel: asus-z00t-tm5p5-n35596: transition to mipi_dsi wrapped functions

2024-06-21 Thread Doug Anderson
Hi, On Fri, Jun 21, 2024 at 6:17 AM Tejas Vipin wrote: > > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: > Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe > ("drm/mipi-dsi: wrap more functions for streamline handling") for the > asus-z00t-tm5p5-n35596 panel. > >

[PATCH] drm/etnaviv: reduce number of ktime_get calls in IRQ handler

2024-06-21 Thread Lucas Stach
A single IRQ might signal the completion of multiple jobs/fences at once. There is no point in attaching a new timestamp to each fence that only differs in when exactly the IRQ handler was able to process this fence. Get a single timestamp when the IRQ handler has determined that there are complet

[PATCH] drm/etnaviv: don't block scheduler when GPU is still active

2024-06-21 Thread Lucas Stach
Since 45ecaea73883 ("drm/sched: Partial revert of 'drm/sched: Keep s_fence->parent pointer'") still active jobs aren't put back in the pending list on drm_sched_start(), as they don't have a active parent fence anymore, so if the GPU is still working and the timeout is extended, all currently activ

Re: [PATCH v3] software node: Implement device_get_match_data fwnode callback

2024-06-21 Thread Dmitry Torokhov
Hi Sui, On Sun, Apr 28, 2024 at 04:36:50AM +0800, Sui Jingfeng wrote: > Because the software node backend of the fwnode API framework lacks an > implementation for the .device_get_match_data function callback. This > makes it difficult to use(and/or test) a few drivers that originates > from DT wo

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-21 Thread Dmitry Baryshkov
On Fri, 21 Jun 2024 at 18:52, Daniel Vetter wrote: > > On Fri, Jun 21, 2024 at 09:40:09AM -0600, Jeffrey Hugo wrote: > > On 6/21/2024 5:19 AM, Dmitry Baryshkov wrote: > > > On Fri, 21 Jun 2024 at 09:19, Bjorn Andersson > > > wrote: > > > > > > > > On Wed, Jun 12, 2024 at 09:28:39PM GMT, Dmitry B

Re: [PATCH] drm/ssd130x: Add drm_panic support

2024-06-21 Thread Javier Martinez Canillas
Daniel Vetter writes: Hello Sima, Thanks for your comment and explanations. > On Fri, Jun 21, 2024 at 05:42:53PM +0200, Javier Martinez Canillas wrote: >> Javier Martinez Canillas writes: >> >> > Jocelyn Falempe writes: >> > >> > Hello Jocelyn, thanks for your feedback! >> > >> >> On 21/06/2

Re: [PATCH v4 4/4] drm/panel: jd9365da: Add the function of adjusting orientation

2024-06-21 Thread Doug Anderson
Hi, On Thu, Jun 20, 2024 at 1:05 AM Zhaoxiong Lv wrote: > > @@ -893,6 +901,12 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi) > drm_panel_init(&jadard->panel, dev, &jadard_funcs, >DRM_MODE_CONNECTOR_DSI); > > + ret = of_drm_get_panel_orientation(d

Re: [PATCH v4 3/4] drm/panel: jd9365da: Support for kd101ne3-40ti MIPI-DSI panel.

2024-06-21 Thread Doug Anderson
Hi, On Thu, Jun 20, 2024 at 1:05 AM Zhaoxiong Lv wrote: > > @@ -31,6 +31,15 @@ struct jadard_panel_desc { > enum mipi_dsi_pixel_format format; > const struct jadard_init_cmd *init_cmds; > u32 num_init_cmds; > + bool lp11_before_reset; > + bool reset_before_powe

Re: [PATCH v4 1/4] drm/panel: jd9365da: Modify the method of sending commands

2024-06-21 Thread Doug Anderson
Hi, On Thu, Jun 20, 2024 at 1:05 AM Zhaoxiong Lv wrote: > > Currently, the init_code of the jd9365da driver is placed > in the enable() function and sent, but this seems to take > a long time. It takes 17ms to send each instruction (an init > code consists of about 200 instructions), so it takes

Re: [PATCH net-next v12 06/13] page_pool: devmem support

2024-06-21 Thread Mina Almasry
On Mon, Jun 17, 2024 at 7:17 AM Pavel Begunkov wrote: > > On 6/13/24 02:35, Mina Almasry wrote: > > Convert netmem to be a union of struct page and struct netmem. Overload > > the LSB of struct netmem* to indicate that it's a net_iov, otherwise > > it's a page. > > > > Currently these entries in s

Re: [PATCH 1/2] drm/panel: ltk050h3146w: add check for mipi_dsi_dcs_enter_sleep_mode

2024-06-21 Thread Jessica Zhang
On 6/20/2024 12:47 AM, Chen Ni wrote: Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and return the error if it fails in order to catch the error. Signed-off-by: Chen Ni Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 +- 1 fil

Re: [PATCH 2/2] drm/panel-xinpeng-xpp055c272: add check for mipi_dsi_dcs_enter_sleep_mode

2024-06-21 Thread Jessica Zhang
On 6/20/2024 12:48 AM, Chen Ni wrote: Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and return the error if it fails in order to catch the error. Signed-off-by: Chen Ni Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 2 +- 1 file

Re: Correct sequencing of usage of DRM writeback connector

2024-06-21 Thread Daniel Vetter
On Tue, Jun 18, 2024 at 12:48:13PM +0300, Dmitry Baryshkov wrote: > On Tue, 18 Jun 2024 at 12:33, Daniel Vetter wrote: > > > > On Mon, Jun 17, 2024 at 10:52:27PM +0300, Dmitry Baryshkov wrote: > > > On Mon, Jun 17, 2024 at 11:28:35AM GMT, Abhinav Kumar wrote: > > > > Hi > > > > > > > > On 6/17/202

[PATCH v2] drm/etnaviv: switch devcoredump allocations to GFP_NOWAIT

2024-06-21 Thread Lucas Stach
The etnaviv devcoredump is created in the GPU reset path, which must make forward progress to avoid stalling memory reclaim on unsignalled dma fences. The currently used __GFP_NORETRY does not prohibit sleeping on direct reclaim, breaking the forward progress guarantee. Switch to GFP_NOWAIT, which

[PATCH v2] drm/etnaviv: fix DMA direction handling for cached RW buffers

2024-06-21 Thread Lucas Stach
The dma sync operation needs to be done with DMA_BIDIRECTIONAL when the BO is prepared for both read and write operations. Fixes: a8c21a5451d8 ("drm/etnaviv: add initial etnaviv DRM driver") Signed-off-by: Lucas Stach --- v2: switch conditions to be exact matches --- drivers/gpu/drm/etnaviv/etna

Re: [PATCH v3 11/11] drm: Replace strcpy() with __get_task_comm()

2024-06-21 Thread Daniel Vetter
On Fri, Jun 21, 2024 at 10:29:59AM +0800, Yafang Shao wrote: > To prevent erros from occurring when the src string is longer than the > dst string in strcpy(), we should use __get_task_comm() instead. This > approach also facilitates future extensions to the task comm. > > Signed-off-by: Yafang Sh

Re: [PATCH] drm/ssd130x: Add drm_panic support

2024-06-21 Thread Daniel Vetter
On Fri, Jun 21, 2024 at 05:42:53PM +0200, Javier Martinez Canillas wrote: > Javier Martinez Canillas writes: > > > Jocelyn Falempe writes: > > > > Hello Jocelyn, thanks for your feedback! > > > >> On 21/06/2024 00:22, Javier Martinez Canillas wrote: > >>> Add support for the drm_panic infrastruc

Re: Correct sequencing of usage of DRM writeback connector

2024-06-21 Thread Daniel Vetter
On Tue, Jun 18, 2024 at 07:10:58PM -0700, Abhinav Kumar wrote: > > > On 6/18/2024 2:33 AM, Daniel Vetter wrote: > > On Mon, Jun 17, 2024 at 10:52:27PM +0300, Dmitry Baryshkov wrote: > > > On Mon, Jun 17, 2024 at 11:28:35AM GMT, Abhinav Kumar wrote: > > > > Hi > > > > > > > > On 6/17/2024 9:54 AM

Re: [PATCH v3 12/23] mfd: Add new driver for MAX77705 PMIC

2024-06-21 Thread kernel test robot
Hi Dzmitry, kernel test robot noticed the following build errors: [auto build test ERROR on 6906a84c482f098d31486df8dc98cead21cce2d0] url: https://github.com/intel-lab-lkp/linux/commits/Dzmitry-Sankouski/power-supply-add-undervoltage-health-status-property/20240618-222456 base: 6906a84c482

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-21 Thread Daniel Vetter
On Tue, Jun 18, 2024 at 04:49:32PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jun 17, 2024 at 7:22 AM Daniel Vetter wrote: > > > > > I'm really not convinced that hacking with device links in order to > > > get the shutdown notification in the right order is correct, though. > > > The idea is

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-21 Thread Andrew Lunn
> I see other vendors have debugfs entries for debug configurations or > settings, not just for dumping debug info. Did you see any added in the last few years? This is also something DaveM pushed back on. We want uniform APIs so that all devices look alike. Please consider what you are exporting

Re: [PATCH] drm/buddy: Add start address support to trim function

2024-06-21 Thread Matthew Auld
Hi, On 21/06/2024 06:29, Arunpravin Paneer Selvam wrote: - Add a new start parameter in trim function to specify exact address from where to start the trimming. This would help us in situations like if drivers would like to do address alignment for specific requirements. - Add a new fl

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-21 Thread Daniel Vetter
On Tue, Jun 18, 2024 at 04:49:22PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jun 17, 2024 at 7:17 AM Daniel Vetter wrote: > > > > > That all being said, I'm also totally OK with any of the following: > > > > > > 1. Dropping my patch and just accepting that we will have warnings > > > printed

[PATCH v2 2/2] drm/bridge: tc358767: Add configurable default preemphasis

2024-06-21 Thread Marek Vasut
Make the default DP port preemphasis configurable via new DT property "toshiba,pre-emphasis". This is useful in case the DP link properties are known and starting link training from preemphasis setting of 0 dB is not useful. The preemphasis can be set separately for both DP lanes in range 0=0dB, 1=

[PATCH v2 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-06-21 Thread Marek Vasut
Document default DP port preemphasis configurable via new DT property "toshiba,pre-emphasis". This is useful in case the DP link properties are known and starting link training from preemphasis setting of 0 dB is not useful. The preemphasis can be set separately for both DP lanes in range 0=0dB, 1=

[PATCH v2 4/6] drm/bridge: tc358767: Disable MIPI_DSI_CLOCK_NON_CONTINUOUS

2024-06-21 Thread Marek Vasut
The MIPI_DSI_CLOCK_NON_CONTINUOUS causes visible artifacts in high resolution modes, disable it. Namely, in DSI->DP mode 1920x1200 24 bpp 59.95 Hz, with DSI bus at maximum 1 Gbps per lane setting, the image contains jittering empty lines. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Dani

[PATCH v2 5/6] drm/bridge: tc358767: Set LSCLK divider for SYSCLK to 1

2024-06-21 Thread Marek Vasut
The only information in the datasheet regarding this divider is a note in SYS_PLLPARAM register documentation which states that when LSCLK is 270 MHz, LSCLK_DIV should be 1. What should LSCLK_DIV be set to when LSCLK is 162 MHz (for DP 1.62G mode) is unclear, but empirical test confirms using LSCLK

[PATCH v2 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

2024-06-21 Thread Marek Vasut
This line_pixel_subtract is no longer needed now that the bridge can request and obtain specific pixel clock on input to the bridge, with clock frequency that matches the Pixel PLL frequency. The line_pixel_subtract is now always 0, so drop it entirely. The line_pixel_subtract was not reliable as

[PATCH v2 6/6] Revert "drm/bridge: tc358767: Set default CLRSIPO count"

2024-06-21 Thread Marek Vasut
This reverts commit 01338bb82fed40a6a234c2b36a92367c8671adf0. With clock improvements in place, this seems to be no longer necessary. Set the CLRSIPO to default setting recommended by manufacturer. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej

[PATCH v2 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-21 Thread Marek Vasut
Use tc_pxl_pll_calc() to find out the exact clock frequency generated by the Pixel PLL. Use the Pixel PLL frequency as adjusted_mode clock frequency and pass it down the display pipeline to obtain exactly this frequency on input into this bridge. The precise input frequency that matches the Pixel

[PATCH v2 1/6] drm/bridge: tc358767: Split tc_pxl_pll_en() into parameter calculation and enablement

2024-06-21 Thread Marek Vasut
Split tc_pxl_pll_en() into tc_pxl_pll_calc() which does only Pixel PLL parameter calculation and tc_pxl_pll_en() which calls tc_pxl_pll_calc() and then configures the Pixel PLL register. This is a preparatory patch for further rework, where tc_pxl_pll_calc() will also be used to find out the exact

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-21 Thread Daniel Vetter
On Fri, Jun 21, 2024 at 09:40:09AM -0600, Jeffrey Hugo wrote: > On 6/21/2024 5:19 AM, Dmitry Baryshkov wrote: > > On Fri, 21 Jun 2024 at 09:19, Bjorn Andersson wrote: > > > > > > On Wed, Jun 12, 2024 at 09:28:39PM GMT, Dmitry Baryshkov wrote: > > > > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekan

Re: [PATCH] drm/ttm/pool: Revert to clear-on-alloc to honor TTM_TT_FLAG_ZERO_ALLOC

2024-06-21 Thread Nirmoy Das
Hi Christian, On 6/21/2024 4:54 PM, Christian König wrote: Am 20.06.24 um 18:01 schrieb Nirmoy Das: Currently ttm pool is not honoring TTM_TT_FLAG_ZERO_ALLOC flag and clearing pages on free. It does help with allocation latency but clearing happens even if drm driver doesn't passes the flag.

Re: [PATCH] drm/ssd130x: Add drm_panic support

2024-06-21 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Jocelyn Falempe writes: > > Hello Jocelyn, thanks for your feedback! > >> On 21/06/2024 00:22, Javier Martinez Canillas wrote: >>> Add support for the drm_panic infrastructure, which allows to display >>> a user friendly message on the screen when a Linux kerne

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-21 Thread Jeffrey Hugo
On 6/21/2024 5:19 AM, Dmitry Baryshkov wrote: On Fri, 21 Jun 2024 at 09:19, Bjorn Andersson wrote: On Wed, Jun 12, 2024 at 09:28:39PM GMT, Dmitry Baryshkov wrote: On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-21 Thread Marek Vasut
On 6/21/24 12:32 PM, Alexander Stein wrote: Hi, skipping the parts where I would simply write "OK" ... As FVUEN is cleared at the next VSYNC event I suspect the DSI timings are (slightly) off, but unfortunately I don't have equipment to check DSI signal quality/timings. As long as the LCDIFv

Re: [PATCH v4 12/15] drm/mediatek: add MT8365 SoC support

2024-06-21 Thread Chun-Kuang Hu
Hi, Alexandre: 於 2024年5月23日 週四 下午8:49寫道: > > From: Fabien Parent > > Add DRM support for MT8365 SoC. > > Signed-off-by: Fabien Parent > Reviewed-by: AngeloGioacchino Del Regno > > Signed-off-by: Alexandre Mergnat > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 > 1 file changed,

[PATCH v2 16/31] drm/vc4: hdmi: Avoid hang with debug registers when suspended

2024-06-21 Thread Dave Stevenson
From: Dom Cobley Trying to read /sys/kernel/debug/dri/1/hdmi1_regs when the hdmi is disconnected results in a fatal system hang. This is due to the pm suspend code disabling the dvp clock. That is just a gate of the 108MHz clock in DVP_HT_RPI_MISC_CONFIG, which results in accesses hanging AXI bu

[PATCH v2 20/31] drm/vc4: Introduce generation number enum

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard With the introduction of the BCM2712 support, we will get yet another generation of display engine to support. The binary check of whether it's VC5 or not thus doesn't work anymore, especially since some parts of the driver will have changed with BCM2711, and some others with

[PATCH v2 14/31] drm/vc4: hvs: Don't write gamma luts on 2711

2024-06-21 Thread Dave Stevenson
The gamma block has changed in 2711, therefore writing the lut in vc4_hvs_lut_load is incorrect. Whilst the gamma property isn't created for 2711, it is called from vc4_hvs_init_channel, so abort if attempted. Fixes: c54619b0bfb3 ("drm/vc4: Add support for the BCM2711 HVS5") Signed-off-by: Dave S

[PATCH v2 23/31] drm/vc4: hvs: Create hw_init function

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard Since the BCM2712 will feature a significantly different HVS, let's move the hardware initialisation part of our bind function into a separate function. That way, it will be easier to extend in the future. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- dri

[PATCH v2 17/31] drm/vc4: hvs: Fix dlist debug not resetting the next entry pointer

2024-06-21 Thread Dave Stevenson
The debug function to display the dlists didn't reset next_entry_start when starting each display, so resulting in not stopping the list at the correct place. Fixes: c6dac00340fc ("drm/vc4: hvs: Add debugfs node that dumps the current display lists") Signed-off-by: Dave Stevenson --- drivers/gp

[PATCH v2 18/31] drm/vc4: hvs: Remove incorrect limit from hvs_dlist debugfs function

2024-06-21 Thread Dave Stevenson
The debugfs function to dump dlists aborted at 256 bytes, when actually the dlist memory is generally significantly larger but varies based on SoC. We already have the correct limit in __vc4_hvs_alloc, so store it for use in the debugfs dlist function. Fixes: c6dac00340fc ("drm/vc4: hvs: Add debu

[PATCH v2 04/31] drm/vc4: hdmi: Avoid log spam for audio start failure

2024-06-21 Thread Dave Stevenson
From: Dom Cobley We regularly get dmesg error reports of: [ 18.184066] hdmi-audio-codec hdmi-audio-codec.3.auto: ASoC: error at snd_soc_dai_startup on i2s-hifi: -19 [ 18.184098] MAI: soc_pcm_open() failed (-19) These are generated for any disconnected hdmi interface when pulseaudio attempt

[PATCH v2 13/31] drm/vc4: crtc: Move assigned_channel to a variable

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard We access multiple times the vc4_crtc_state->assigned_channel variable in the vc4_crtc_get_scanout_position() function, so let's store it in a local variable. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_crtc.c | 7 --- 1 file

[PATCH v2 15/31] drm/vc4: plane: YUV planes require vertical scaling to always be enabled

2024-06-21 Thread Dave Stevenson
It has been observed that a YUV422 unity scaled plane isn't displayed. Enabling vertical scaling on the UV planes solves this. There is already a similar clause to always enable horizontal scaling on the UV planes. Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_plane.c | 6 ++ 1 f

[PATCH v2 24/31] drm/vc4: hvs: Create cob_init function

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard Just like the HVS itself, the COB parameters will be fairly different in the BCM2712. Let's move the COB parameters computation and its initialisation to a separate function that will be easier to extend in the future. Signed-off-by: Maxime Ripard Signed-off-by: Dave Steven

[PATCH v2 08/31] drm/vc4: hdmi: Warn if writing to an unknown HDMI register

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard The VC4 HDMI driver has a bunch of accessors to read from a register. The read accessor was warning when accessing an unknown register, but the write one was just returning silently. Let's make sure we warn also when writing to an unknown register. Signed-off-by: Maxime Ripa

[PATCH v2 26/31] drm/vc4: plane: Change ptr0_offset to an array

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard The BCM2712 will have a fairly different dlist, that will feature one Pointer 0 word for each plane. Let's prepare by changing the ptr0_offset variable that holds the offset in a dlist of the pointer 0 word to an array. Signed-off-by: Maxime Ripard Signed-off-by: Dave Steve

[PATCH v2 30/31] drm/vc4: hvs: Enable SCALER_CONTROL early in HVS init

2024-06-21 Thread Dave Stevenson
From: Tim Gover Always enable SCALER_CONTROL before attempting other HVS operations. It's safe to write to some parts of the HVS but in general it's dangerous to do this because it can cause bus lockups. Signed-off-by: Tim Gover Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_hvs.c

[PATCH v2 25/31] drm/vc4: hvs: Rename hvs_regs list

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard The HVS register set has been heavily modified in the BCM2712, and we'll thus need a separate debugfs_reg32 array for it. The name hvs_regs is thus a bit too generic, so let's rename it to something more specific. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson

[PATCH v2 19/31] drm/vc4: hvs: Remove ABORT_ON_EMPTY flag

2024-06-21 Thread Dave Stevenson
From: Dom Cobley ABORT_ON_EMPTY chooses whether the HVS abandons the current frame when it experiences an underflow, or attempts to continue. In theory the frame should be black from the point of underflow, compared to a shift of sebsequent pixels to the left. Unfortunately it seems to put the

[PATCH v2 27/31] drm/vc4: hvs: Rework LBM alignment

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard With the introduction of the support for BCM2712, the check of whether we're running on vc5 or not to compute the LBM alignment requirement doesn't work anymore. Moreover, the LBM size will need to be computed in words for the BCM2712, while we've had sizes in bytes so far.

[PATCH v2 29/31] drm/vc4: plane: Move the buffer offset out of the vc4_plane_state

2024-06-21 Thread Dave Stevenson
The offset fields in vc4_plane_state are described as being the offset for each buffer in the bo, however it is used to store the complete DMA address that is then written into the register. The DMA address including the fb ofset can be retrieved using drm_fb_dma_get_gem_addr, and the offset adjus

[PATCH v2 28/31] drm/vc4: hvs: Change prototype of __vc4_hvs_alloc to pass registers

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard The BCM2712 HVS has registers to report the size of the various SRAM the driver uses, and their size actually differ depending on the stepping. The initialisation of the memory pools happen in the __vc4_hvs_alloc() function that also allocates the main HVS structure, that wil

[PATCH v2 22/31] drm/vc4: hvs: Use switch statement to simplify vc4_hvs_get_fifo_from_output

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard Since we'll support BCM2712 soon, let's move the logic behind vc4_hvs_get_fifo_from_output() to a switch to extend it more easily. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_hvs.c | 77 +++ 1 file

[PATCH v2 07/31] drm/vc4: hdmi: Increase audio MAI fifo dreq threshold

2024-06-21 Thread Dave Stevenson
From: Dom Cobley Now we wait for write responses and have a burst size of 4, we can set the fifo threshold much higher. Set it to 28 (of the 32 entry size) to keep fifo fuller and reduce chance of underflow. Signed-off-by: Dom Cobley Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_

[PATCH v2 31/31] drm/vc4: hvs: Correct logic on stopping an HVS channel

2024-06-21 Thread Dave Stevenson
When factoring out __vc4_hvs_stop_channel, the logic got inverted from if (condition) // stop channel to if (condition) goto out //stop channel out: and also changed the exact register writes used to stop the channel. Correct the logic so that th

[PATCH v2 21/31] drm/vc4: Make v3d paths unavailable on any generation newer than vc4

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard The V3D IP has been separate since BCM2711, so let's make sure we issue a WARN if we're running not only on BCM2711, but also anything newer. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_bo.c | 28 +++-

[PATCH v2 11/31] drm/vc4: plane: Add more debugging for LBM allocation

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard LBM allocations need a different size depending on the line length, format, etc. This can get tricky, and fail. Let's add some more prints to ease the debugging when it does. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_plane.c |

[PATCH v2 05/31] drm/vc4: plane: Add support for YUV444 formats

2024-06-21 Thread Dave Stevenson
From: Dom Cobley Support displaying DRM_FORMAT_YUV444 and DRM_FORMAT_YVU444 formats. Tested with kmstest and kodi. e.g. kmstest -r 1920x1080@60 -f 400x300-YU24 Note: without the shift of width, only half the chroma is fetched, resulting in correct left half of image and corrupt colours on right

[PATCH v2 06/31] drm/vc4: hvs: Set AXI panic modes for the HVS

2024-06-21 Thread Dave Stevenson
The HVS can change AXI request mode based on how full the COB FIFOs are. Until now the vc4 driver has been relying on the firmware to have set these to sensible values. With HVS channel 2 now being used for live video, change the panic mode for all channels to be explicitly set by the driver, and

[PATCH v2 09/31] drm/vc4: hvs: More logging for dlist generation

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard DLIST generation can get pretty tricky and there's not a lot of debug in the driver to help. Let's add a few more to track the generated DLIST size. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_hvs.c | 14 -- 1 file cha

[PATCH v2 12/31] drm/vc4: plane: Use return variable in atomic_check

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard The vc4_plane_atomic_check() directly returns the result of the final function it calls. Using the already defined ret variable to check its content on error, and a separate return 0 on success, makes it easier to extend. Signed-off-by: Maxime Ripard Signed-off-by: Dave Ste

[PATCH v2 03/31] drm/vc4: crtc: Force trigger of dlist update on margins change

2024-06-21 Thread Dave Stevenson
When the margins are changed, the dlist needs to be regenerated with the changed updated dest regions for each of the planes. Setting the zpos_changed flag is sufficient to trigger that without doing a full modeset, therefore set it should the margins be changed. Signed-off-by: Dave Stevenson --

[PATCH v2 10/31] drm/vc4: hvs: Print error if we fail an allocation

2024-06-21 Thread Dave Stevenson
From: Maxime Ripard We need to allocate a few additional structures when checking our atomic_state, especially related to hardware SRAM that will hold the plane descriptors (DLIST) and the current line context (LBM) during composition. Since those allocation can fail, let's add some error messag

[PATCH v2 02/31] drm/vc4: plane: Handle fractional coordinates using the phase field

2024-06-21 Thread Dave Stevenson
From: Dom Cobley Apply fractional source co-ordinates into the scaling filters. Signed-off-by: Dom Cobley Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_plane.c | 87 - 1 file changed, 76 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/v

[PATCH v2 01/31] drm/vc4: plane: Keep fractional source coords inside state

2024-06-21 Thread Dave Stevenson
From: Dom Cobley Fractional source co-ordinates can be used to setup the scaling filters, so retain the information. Signed-off-by: Dom Cobley Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_drv.h | 2 +- drivers/gpu/drm/vc4/vc4_plane.c | 68 - 2 f

[PATCH v2 00/31] Preparatory patches for BCM2712 (Pi5) support

2024-06-21 Thread Dave Stevenson
Hi This set is a number of minor fixes that we've had downstream for a while, and then lays down the some infrastructure changes to facilitate adding support of BCM2712. I'm just finalising those patches so they should follow on fairly soon. Thanks Dave --- v1 -> v2 - Sorted Maxime's email ad

Re: [PATCH v1 1/3] dt-bindings: display: st7701: Add Anbernic RG28XX panel

2024-06-21 Thread Krzysztof Kozlowski
On 21/06/2024 12:59, Hironori KIKUCHI wrote: > Hello Krzysztof, > > Thank you for your reply! > > On Tue, Jun 18, 2024 at 6:17 PM Krzysztof Kozlowski wrote: >> >> On 18/06/2024 10:15, Hironori KIKUCHI wrote: >>> The RG28XX panel is a panel specific to the Anbernic RG28XX. >>> It is 2.8 inches in

Re: [PATCH v4 06/15] dt-bindings: display: mediatek: dpi: add power-domains property

2024-06-21 Thread Chun-Kuang Hu
Hi, Alexandre: 於 2024年5月23日 週四 下午8:49寫道: > > From: Fabien Parent > > DPI is part of the display / multimedia block in MediaTek SoCs, and > always have a power-domain (at least in the upstream device-trees). > Add the power-domains property to the binding documentation. I've tired to apply this

Re: [PATCH v6 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-06-21 Thread Krzysztof Kozlowski
On 19/06/2024 16:46, Alexandre Mergnat wrote: > Add the audio codec sub-device. This sub-device is used to set the > optional voltage values according to the hardware. > The properties are: > - Setup of microphone bias voltage. > - Setup of the speaker pin pull-down. > > Also, add the audio po

Re: [PATCH v6 12/16] ASoC: codecs: add MT6357 support

2024-06-21 Thread Mark Brown
On Wed, Jun 19, 2024 at 04:46:48PM +0200, amerg...@baylibre.com wrote: > From: Nicolas Belin > > Add the support of MT6357 PMIC audio codec. This breaks an x86 allmodconfig build: /build/stage/linux/sound/soc/codecs/mt6357.c: In function ‘mt_delay_250_event’: /build/stage/linux/sound/soc/codecs

Re: [PATCH v6 3/3] drm/stm: ltdc: add lvds pixel clock

2024-06-21 Thread Yannick FERTRE
Hi Raphaël, Thanks for your patch, it will not merged due to a new clock management. Philippe, this patch will be replaced by another which manages all clocks that the display controller  will need (pixel clock, bus clock reference clock). Best regards Le 26/02/2024 à 11:48, Raphael Gall

Re: [PATCH] drm/ttm/pool: Revert to clear-on-alloc to honor TTM_TT_FLAG_ZERO_ALLOC

2024-06-21 Thread Christian König
Am 20.06.24 um 18:01 schrieb Nirmoy Das: Currently ttm pool is not honoring TTM_TT_FLAG_ZERO_ALLOC flag and clearing pages on free. It does help with allocation latency but clearing happens even if drm driver doesn't passes the flag. If clear on free is needed then a new flag can be added for tha

  1   2   >