Re: [PATCH -next] drm/xe: Remove duplicate generated/xe_wa_oob.h header

2024-07-09 Thread Lucas De Marchi
On Wed, Jul 10, 2024 at 01:49:41PM GMT, Jiapeng Chong wrote: ./drivers/gpu/drm/xe/xe_gt.c: generated/xe_wa_oob.h is included more than once. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9493 Signed-off-by: Jiapeng Chong thanks, but a similar patch got merge

Re: [PATCH 00/12] v3d: Perfmon cleanup

2024-07-09 Thread Iago Toral
El mar, 09-07-2024 a las 17:34 +0100, Tvrtko Ursulin escribió: > From: Tvrtko Ursulin > > When we had to quickly deal with a tree build issue via merging > 792d16b5375d ("drm/v3d: Move perfmon init completely into own unit"), > we > promised to follow up with a nicer solution. > > As in the proc

Re: [PATCH] drm/buddy: Add start address support to trim function

2024-07-09 Thread Paneer Selvam, Arunpravin
Thanks Alex. Hi Matthew, Any comments? Thanks, Arun. On 7/9/2024 1:42 AM, Alex Deucher wrote: On Thu, Jul 4, 2024 at 4:40 AM Arunpravin Paneer Selvam wrote: - Add a new start parameter in trim function to specify exact address from where to start the trimming. This would help us in sit

[PATCH -next] drm/xe: Remove duplicate generated/xe_wa_oob.h header

2024-07-09 Thread Jiapeng Chong
./drivers/gpu/drm/xe/xe_gt.c: generated/xe_wa_oob.h is included more than once. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9493 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/xe/xe_gt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/x

Re: [CRIU] va range based memory management discussion (was: 回复:回复:Re:Proposal to add CRIU support to DRM render nodes)

2024-07-09 Thread Chip (Support Bot) from ChickenGuard
Hi there, Thank you for your email. It has been received and a member of the team will be in contact as soon as possible. We are usually able to respond to queries within 1-2 working days. (If not already given, please let us know your full name, order number, and purchase date to aid us in

Re: [PATCH v9 10/13] PCI: Give pci_intx() its own devres callback

2024-07-09 Thread Krzysztof Wilczyński
[...] > pci_intx() calls into pcim_intx() in managed mode, i.e., when > pcim_enable_device() had been called. This recursive call causes a bug > by re-registering the device resource in the release callback. > > This is the same phenomenon that made it necessary to implement some > functionality a

Re: [PATCH v9 10/13] PCI: Give pci_intx() its own devres callback

2024-07-09 Thread Krzysztof Wilczyński
Hello Ashish and Philipp, > I have reviewed and tested this patch, looks to be working fine and fixes the > issue. Great news! Ashish, thank you for taking the time to report the problem and then also testing the fix. Much appreciated. Philipp, I will take this patch and squash into the serie

va range based memory management discussion (was: 回复:回复:Re:Proposal to add CRIU support to DRM render nodes)

2024-07-09 Thread 周春明(日月)
-- 发件人:Felix Kuehling 发送时间:2024年7月10日(星期三) 01:07 收件人:周春明(日月) ; Tvrtko Ursulin ; dri-devel@lists.freedesktop.org ; amd-...@lists.freedesktop.org ; Dave Airlie ; Daniel Vetter ; criu 抄 送:"Errabolu, Ramesh" ; "Christian König" 主 题:

Re: [PATCH v9 30/52] drm-dyndbg: adapt drm core to use dyndbg classmaps-v2

2024-07-09 Thread jim . cromie
On Wed, Jul 3, 2024 at 10:11 AM wrote: > > Got it. > I had some mental block about passing designated intializers as macro args. > it just worked, I needed to eyeball the .i file just to be sure. > thanks. > I have a fixup patch. > whats the best thing to do with it, squash it in for later ? send

[PATCH net-next v16 12/13] selftests: add ncdevmem, netcat for devmem TCP

2024-07-09 Thread Mina Almasry
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it sends and receives data using the devmem TCP APIs. It uses udmabuf as the dmabuf provider. It is compatible with a regular netcat running on a peer, or a ncdevmem running on a peer. In addition to normal netcat support, ncdevmem

[PATCH net-next v16 13/13] netdev: add dmabuf introspection

2024-07-09 Thread Mina Almasry
Add dmabuf information to page_pool stats: $ ./cli.py --spec ../netlink/specs/netdev.yaml --dump page-pool-get ... {'dmabuf': 10, 'id': 456, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208}, {'dmabuf': 10, 'id': 455, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208

[PATCH net-next v16 09/13] tcp: RX path for devmem TCP

2024-07-09 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a cmsg

[PATCH net-next v16 11/13] net: add devmem TCP documentation

2024-07-09 Thread Mina Almasry
Add documentation outlining the usage and details of devmem TCP. Signed-off-by: Mina Almasry Reviewed-by: Bagas Sanjaya --- v16: - Add documentation on unbinding the NIC from dmabuf (Donald). - Add note that any dmabuf should work (Donald). v9: https://lore.kernel.org/netdev/20240403002053.2

[PATCH net-next v16 10/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-07-09 Thread Mina Almasry
Add an interface for the user to notify the kernel that it is done reading the devmem dmabuf frags returned as cmsg. The kernel will drop the reference on the frags to make them available for reuse. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry Reviewe

[PATCH net-next v16 06/13] memory-provider: dmabuf devmem memory provider

2024-07-09 Thread Mina Almasry
Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The provider obtains a reference on the netde

[PATCH net-next v16 08/13] net: add support for skbs with unreadable frags

2024-07-09 Thread Mina Almasry
For device memory TCP, we expect the skb headers to be available in host memory for access, and we expect the skb frags to be in device memory and unaccessible to the host. We expect there to be no mixing and matching of device memory frags (unaccessible) with host memory frags (accessible) in the

[PATCH net-next v16 07/13] net: support non paged skb frags

2024-07-09 Thread Mina Almasry
Make skb_frag_page() fail in the case where the frag is not backed by a page, and fix its relevant callers to handle this case. Signed-off-by: Mina Almasry Reviewed-by: Eric Dumazet --- v10: - Fixed newly generated kdoc warnings found by patchwork. While we're at it, fix the Return section

[PATCH net-next v16 05/13] page_pool: devmem support

2024-07-09 Thread Mina Almasry
Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net stack: struct { unsigned long pp_mag

[PATCH net-next v16 04/13] netdev: netdevice devmem allocator

2024-07-09 Thread Mina Almasry
Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by:

[PATCH net-next v16 02/13] net: netdev netlink api to bind dma-buf to a net device

2024-07-09 Thread Mina Almasry
API takes the dma-buf fd as input, and binds it to the netdevice. The user can specify the rx queues to bind the dma-buf to. Suggested-by: Stanislav Fomichev Signed-off-by: Mina Almasry --- v16: - Use subset-of: queue queue-id instead of queue-dmabuf (Jakub). - Rename attribute 'bind-dmabuf' t

[PATCH net-next v16 03/13] netdev: support binding dma-buf to netdevice

2024-07-09 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a genpool

[PATCH net-next v16 01/13] netdev: add netdev_rx_queue_restart()

2024-07-09 Thread Mina Almasry
Add netdev_rx_queue_restart() function to netdev_rx_queue.h Signed-off-by: David Wei Signed-off-by: Mina Almasry Reviewed-by: Pavel Begunkov Reviewed-by: Jakub Kicinski --- v13: - Add reviewed-by from Pavel (thanks!) - Fixed comment (Pavel) v11: - Fix not checking dev->queue_mgmt_ops (Pavel

[PATCH net-next v16 00/13] Device Memory TCP

2024-07-09 Thread Mina Almasry
v16: https://patchwork.kernel.org/project/netdevbpf/list/?series=866353&state=* v15 got a thorough review and some testing, and this version addresses almost all the feedback. Some more minor comments where the authors said it could be done later, I left out. Major changes: - Addition of dma

[PATCH v3] accel/ivpu: Add missing MODULE_FIRMWARE metadata

2024-07-09 Thread Alexander F. Lent
Modules that load firmware from various paths at runtime must declare those paths at compile time, via the MODULE_FIRMWARE macro, so that the firmware paths are included in the module's metadata. The accel/ivpu driver loads firmware but lacks this metadata, preventing dracut from correctly locatin

Re: [PATCH RFC 0/3] Implement Qualcomm TEE IPC and ioctl calls

2024-07-09 Thread Amirreza Zarrabi
On 7/3/2024 9:36 PM, Dmitry Baryshkov wrote: > On Tue, Jul 02, 2024 at 10:57:35PM GMT, Amirreza Zarrabi wrote: >> Qualcomm TEE hosts Trusted Applications (TAs) and services that run in >> the secure world. Access to these resources is provided using MinkIPC. >> MinkIPC is a capability-based sync

[RESEND PATCH] drm: Combine identical if/elif code blocks

2024-07-09 Thread Thorsten Blum
Merge the identical if/elif code blocks and remove the following two warnings reported by make includecheck: asm/ioctl.h is included more than once linux/types.h is included more than once Reverts commit 00c9672606f7 ("drm: Untangle __KERNEL__ guards") because make headers_install seems to be

[PULL] drm-xe-next-fixes

2024-07-09 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes a very early drm-xe-next-fixes with 2 important fixes that are going to impact user space. 1. The first one is the rename of the OA stuff from the bad 'perf' name to the xe_observation. Although the rename in the uapi header is likely inoffensive because our UMDs

Re: [PATCH] dt-bindings: display: bridge: ti, sn65dsi83: add burst-mode-disabled

2024-07-09 Thread Stefano Radaelli
Yes this is not the mainline driver but it is the one from which the mainline driver is taken. Yes this problem occurs with this mainline driver. Stefano Il Mar 9 Lug 2024, 23:12 Marek Vasut ha scritto: > On 7/9/24 7:30 PM, Stefano Radaelli wrote: > > Okay, I get it. > > > > So if you think th

Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled

2024-07-09 Thread Marek Vasut
On 7/9/24 7:30 PM, Stefano Radaelli wrote: Okay, I get it. So if you think this mode shouldn't be implemented within this driver, we can close the thread. Just for information, this driver has been implemented from the work done by Compulab (as it says in the driver's initial comments), and they

Re: [PATCH 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-07-09 Thread Doug Anderson
Hi, On Tue, Jul 9, 2024 at 4:18 AM Tejas Vipin wrote: > > On 7/9/24 5:50 AM, Doug Anderson wrote: > > Hi, > > > > On Fri, Jun 28, 2024 at 11:25 AM Tejas Vipin wrote: > >> > >> +/** > >> + * mipi_dsi_dcs_set_page_address_multi() - define the column extent of the > >> + * frame memory accessed

Re: [PULL] drm-intel-next

2024-07-09 Thread Rodrigo Vivi
On Fri, Jun 28, 2024 at 05:46:01PM +0300, Jani Nikula wrote: > > Hi Dave & Sima - > > Another feature pull towards v6.11, hopefully last. This should also fix > the 32-bit build issue [1] seen in drm-next. Sima, Dave, I just noticed that we don't have this one yet in drm-next. Anything missing

[PATCH] MAINTAINERS: add myself to DRM/STi maintainers

2024-07-09 Thread Raphael Gallais-Pou
In lights of recent events and my will to participate in the Linux kernel development I see this opportunity to add myself, and help Alain as maintainer for the DRM/STi drivers. Signed-off-by: Raphael Gallais-Pou --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/M

Re: [PATCH 2/2] drm/msm/dpu: don't play tricks with debug macros

2024-07-09 Thread Abhinav Kumar
On 7/9/2024 6:48 AM, Dmitry Baryshkov wrote: DPU debugging macros need to be converted to a proper drm_debug_* macros, however this is a going an intrusive patch, not suitable for a fix. Wire DPU_DEBUG and DPU_DEBUG_DRIVER to always use DRM_DEBUG_DRIVER to make sure that DPU debugging messages

Re: [PATCH v9 10/13] PCI: Give pci_intx() its own devres callback

2024-07-09 Thread Kalra, Ashish
Hello Philipp, I have reviewed and tested this patch, looks to be working fine and fixes the issue. Thanks, Ashish On 7/9/2024 3:56 AM, Philipp Stanner wrote: > From c24bd5b66e798a341caf183fb7cdbdf235502d90 Mon Sep 17 00:00:00 2001 > From: Philipp Stanner > Date: Tue, 9 Jul 2024 09:45:48 +0200

Re: [PATCH 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-07-09 Thread Abhinav Kumar
On 7/9/2024 6:48 AM, Dmitry Baryshkov wrote: In order to prevent any errors on connector being disabled, move the state->crtc check upfront. This should fix the issues during suspend when the writeback connector gets forcebly disabled. Fixes: 71174f362d67 ("drm/msm/dpu: move writeback's atomi

Re: [PATCH v4] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes

2024-07-09 Thread Patrik Jakobsson
On Tue, Jul 9, 2024 at 1:33 PM Ma Ke wrote: > > In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a NULL pointer dereference on > failure of drm_mode_duplicate(). Add a check to avoid npd. > > Cc: sta...@vger.kernel.org > Fixes: 6a227

Re: [PATCH v3] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes

2024-07-09 Thread Patrik Jakobsson
On Tue, Jul 9, 2024 at 10:59 AM Ma Ke wrote: > > In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate() > is assigned to mode, which will lead to a NULL pointer dereference on > failure of drm_mode_duplicate(). Add a check to avoid npd. > > Cc: sta...@vger.kernel.org > Fixes: 6a22

[PATCH v1] drm/rockchip: rk3066_hdmi: change to bridge driver mode

2024-07-09 Thread Johan Jonker
Change rk3066_hdmi.c to bridge driver mode. Signed-off-by: Johan Jonker --- Apply after: [PATCH v10] drm/rockchip: rk3066_hdmi: add sound support --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 293 ++--- 1 file changed, 161 insertions(+), 132 deletions(-) diff --git a/drivers

[syzbot] [dri?] possible deadlock in drm_modeset_lock

2024-07-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:8e2f4becf4fa Merge remote-tracking branch 'tglx/devmsi-arm.. git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci console output: https://syzkaller.appspot.com/x/log.txt?x=10676a9e98 kernel conf

Re: [PATCH net-next v15 03/14] netdev: support binding dma-buf to netdevice

2024-07-09 Thread Mina Almasry
On Tue, Jul 9, 2024 at 8:37 AM Taehee Yoo wrote: > ... > And I found another bug. > > [ 236.625141] BUG: KASAN: slab-use-after-free in > net_devmem_unbind_dmabuf+0x364/0x440 ... > Reproducer: > ./ncdevmem -f -l -p 5201 -v 7 -t 0 -q 2 & > sleep 10 > modprobe -rv bnxt_en > killall ncdevmem > > I th

Re: [PATCH v3] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel

2024-07-09 Thread Clayton Craft
On Mon, 20 May 2024 15:18:36 -0700 Clayton Craft wrote: > This panel is found on some laptops e.g., variants of the Thinkpad X13s. > > Signed-off-by: Clayton Craft > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/panel-edp

Re: The TTM LRU-walk cherry-pick series

2024-07-09 Thread Matthew Brost
On Tue, Jul 09, 2024 at 12:54:13PM +0200, Christian König wrote: > Am 08.07.24 um 17:34 schrieb Matthew Brost: > > On Mon, Jul 08, 2024 at 05:29:30PM +0200, Christian König wrote: > > > Am 08.07.24 um 17:23 schrieb Matthew Brost: > > > > On Sun, Jul 07, 2024 at 05:49:16PM +0200, Thomas Hellström wr

Re: [PATCH] dt-bindings: display: bridge: ti, sn65dsi83: add burst-mode-disabled

2024-07-09 Thread Stefano Radaelli
Okay, I get it. So if you think this mode shouldn't be implemented within this driver, we can close the thread. Just for information, this driver has been implemented from the work done by Compulab (as it says in the driver's initial comments), and they do not put the burst mode by default, not ev

Re: 回复:Re:Proposal to add CRIU support to DRM render nodes

2024-07-09 Thread Felix Kuehling
On 2024-07-09 5:30, 周春明(日月) wrote: > > > > > > > -- > 发件人:Felix Kuehling > 发送时间:2024年7月9日(星期二) 06:40 > 收件人:周春明(日月) ; Tvrtko Ursulin > ; dri-devel@lists.freedesktop.org > ; amd-...@lists.freedesktop.org > ; Dave Airlie ; Da

Re: [PATCH] drm/rockchip: cdn-dp: Remove redundant workarounds for firmware loading

2024-07-09 Thread Dragan Simic
Hello Maxime, On 2024-07-09 13:09, Maxime Ripard wrote: On Tue, Jul 09, 2024 at 12:10:51PM GMT, Dragan Simic wrote: On 2024-07-09 11:10, Andy Yan wrote: > At 2024-07-09 16:17:06, "Dragan Simic" wrote: > > On 2024-07-08 09:46, Andy Yan wrote: > > > At 2024-07-04 18:35:42, "Dragan Simic" wrote:

[PATCH 12/12] drm/v3d: Move perfmon init completely into own unit

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Now that the build time dependencies on various array sizes have been removed, we can move the perfmon init completely into its own compilation unit and remove the hardcoded defines. This improves on the temporary fix quickly delivered in 792d16b5375d ("drm/v3d: Move perfmon

[PATCH 11/12] drm/v3d: Do not use intermediate storage when copying performance query results

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Removing the intermediate buffer removes the last use of the V3D_MAX_COUNTERS define, which will enable further driver cleanup. While at it pull the 32 vs 64 bit copying decision outside the loop in order to reduce the number of conditional instructions. Signed-off-by: Tvrt

[PATCH 10/12] drm/v3d: Size the kperfmon_ids array at runtime

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of statically reserving pessimistic space for the kperfmon_ids array, make the userspace extension code allocate the exactly required amount of space. Apart from saving some memory at runtime, this also removes the need for the V3D_MAX_PERFMONS macro whose removal wi

[PATCH 09/12] drm/v3d: Move part of copying of reset/copy performance extension to a helper

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin The loop which looks up the syncobj and copies the kperfmon ids is identical so lets move it to a helper. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/v3d/v3d_submit.c | 148 +-- 1 file changed, 64 insertions(+), 84 deletions(-) diff --git

[PATCH 07/12] drm/v3d: Validate passed in drm syncobj handles in the timestamp extension

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If userspace provides an unknown or invalid handle anywhere in the handle array the rest of the driver will not handle that well. Fix it by checking handle was looked up successfuly or otherwise fail the extension by jumping into the existing unwind. Signed-off-by: Tvrtko U

[PATCH 05/12] drm/v3d: Fix potential memory leak in the timestamp extension

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If fetching of userspace memory fails during the main loop, all drm sync objs looked up until that point will be leaked because of the missing drm_syncobj_put. Fix it by exporting and using a common cleanup helper. Signed-off-by: Tvrtko Ursulin Fixes: 9ba0ff3e083f ("drm/v3

[PATCH 08/12] drm/v3d: Validate passed in drm syncobj handles in the performance extension

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If userspace provides an unknown or invalid handle anywhere in the handle array the rest of the driver will not handle that well. Fix it by checking handle was looked up successfuly or otherwise fail the extension by jumping into the existing unwind. Signed-off-by: Tvrtko U

[PATCH 06/12] drm/v3d: Fix potential memory leak in the performance extension

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If fetching of userspace memory fails during the main loop, all drm sync objs looked up until that point will be leaked because of the missing drm_syncobj_put. Fix it by exporting and using a common cleanup helper. Signed-off-by: Tvrtko Ursulin Fixes: bae7cb5d6800 ("drm/v3

[PATCH 04/12] drm/v3d: Align data types of internal and uapi counts

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In the timestamp and performance extensions userspace type for counts is u32 so lets use unsigned in the kernel too. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/v3d/v3d_submit.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/d

[PATCH 03/12] drm/v3d: Add some local variables in queries/extensions

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add some local variables to make the code a bit less verbose, with the main benefit being pulling some lines to under 80 columns wide. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/v3d/v3d_submit.c | 103 --- 1 file changed, 54 insertions(+)

[PATCH 02/12] drm/v3d: Prefer get_user for scalar types

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It makes it just a tiny bit more obvious what is going on. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/v3d/v3d_submit.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_submit.c b/drivers/gpu/drm/v3d

[PATCH 00/12] v3d: Perfmon cleanup

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When we had to quickly deal with a tree build issue via merging 792d16b5375d ("drm/v3d: Move perfmon init completely into own unit"), we promised to follow up with a nicer solution. As in the process of eliminating the hardcoded defines we have discovered a few issues in han

[PATCH 01/12] drm/v3d: Prevent out of bounds access in performance query extensions

2024-07-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Check that the number of perfmons userspace is passing in the copy and reset extensions is not greater than the internal kernel storage where the ids will be copied into. Signed-off-by: Tvrtko Ursulin Fixes: bae7cb5d6800 ("drm/v3d: Create a CPU job extension for the reset

Re: [PATCH] drm/rockchip: cdn-dp: Remove redundant workarounds for firmware loading

2024-07-09 Thread Dragan Simic
Hello Andy, On 2024-07-09 12:46, Andy Yan wrote: At 2024-07-09 18:10:51, "Dragan Simic" wrote: On 2024-07-09 11:10, Andy Yan wrote: At 2024-07-09 16:17:06, "Dragan Simic" wrote: On 2024-07-08 09:46, Andy Yan wrote: At 2024-07-04 18:35:42, "Dragan Simic" wrote: On 2024-07-04 04:10, Andy Y

[PATCH AUTOSEL 6.9 38/40] drm/amd/swsmu: add MALL init support workaround for smu_v14_0_1

2024-07-09 Thread Sasha Levin
From: Li Ma [ Upstream commit c223376b3019a00a0241faea0bc8c966738d1cc5 ] [Why] SMU firmware has not supported MALL PG. [How] Disable MALL PG and make it always on until SMU firmware is ready. Signed-off-by: Li Ma Reviewed-by: Tim Huang Acked-by: Alex Deucher Signed-off-by: Alex Deucher Sig

Re: [PATCH net-next v15 03/14] netdev: support binding dma-buf to netdevice

2024-07-09 Thread Taehee Yoo
On Tue, Jul 9, 2024 at 5:08 AM Mina Almasry wrote: > Hi Mina, Thanks a lot for your reply! > On Thu, Jul 4, 2024 at 10:57 AM Taehee Yoo wrote: > > > > I found several locking warnings while testing. > > > > Thanks for Testing Taehee! And sorry for the late reply. I was off for > a couple of day

Re: [PATCH] drm/meson: fix canvas release in bind function

2024-07-09 Thread Neil Armstrong
Hi, On Wed, 03 Jul 2024 15:58:27 +, Yao Zi wrote: > Allocated canvases may not be released on the error exit path of > meson_drv_bind_master(), leading to resource leaking. Rewrite exit path > to release canvases on error. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kerne

Re: [PATCH] drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove

2024-07-09 Thread Doug Anderson
Hi, On Tue, Jul 9, 2024 at 12:53 AM Neil Armstrong wrote: > > On 08/07/2024 19:52, Douglas Anderson wrote: > > Commit d7d473d8464e ("drm/panel: sharp-lq101r1sx01: Don't call disable > > at shutdown/remove") had a subtle bug. We should be calling > > sharp_panel_del() when the "sharp" variable is

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Jocelyn Falempe
On 09/07/2024 11:41, Alice Ryhl wrote: On Tue, Jul 9, 2024 at 10:45 AM Jocelyn Falempe wrote: This patch adds a new panic screen, with a QR code and the kmsg data embedded. If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be compressed with zlib and encoded as a numerical seg

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Jocelyn Falempe
On 09/07/2024 11:41, Miguel Ojeda wrote: Hi Jocelyn, A quick docs-only review of the Rust side (some of these apply in several cases -- I just wanted to give an overview for you to consider). Thanks, I'll fix all typo/grammar you mentioned. On Tue, Jul 9, 2024 at 10:45 AM Jocelyn Falempe

Re: [PATCH v2] drm/amd/display: Add otg_master NULL check within init_pipe_slice_table_from_context

2024-07-09 Thread Rodrigo Siqueira Jordao
On 7/9/24 3:10 AM, Ma Ke wrote: To avoid reports of NULL_RETURN warning, we should add otg_master NULL check. Cc: sta...@vger.kernel.org Fixes: c51d87202d1f ("drm/amd/display: do not attempt ODM power optimization if minimal transition doesn't exist") Signed-off-by: Ma Ke --- Changes in v2: -

Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled

2024-07-09 Thread Marek Vasut
On 7/9/24 4:44 PM, Stefano Radaelli wrote: Hi Marek, Hi, Actually this property is specific also to DSI8x bridge, as you can see from the screenshot below taken from official datasheet: [image: image.png] And it's the sn65dsi8x driver that tells MIPI driver which flags to use during attachm

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

2024-07-09 Thread Rodrigo Siqueira Jordao
On 7/9/24 6:41 AM, Linux regression tracking (Thorsten Leemhuis) wrote: On 30.06.24 01:18, Mikhail Gavrilov wrote: On Sat, Jun 29, 2024 at 9:46 PM Rodrigo Siqueira Jordao wrote: I'm trying to reproduce this issue, but until now, I've been unable to reproduce it. I tried some different scen

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

2024-07-09 Thread Rodrigo Siqueira Jordao
On 6/29/24 5:18 PM, Mikhail Gavrilov wrote: On Sat, Jun 29, 2024 at 9:46 PM Rodrigo Siqueira Jordao wrote: Hi Mikhail, I'm trying to reproduce this issue, but until now, I've been unable to reproduce it. I tried some different scenarios with the following components: 1. Displays: I tried w

Re: [PATCH] dt-bindings: display: bridge: ti, sn65dsi83: add burst-mode-disabled

2024-07-09 Thread Stefano Radaelli
Hi Marek, Actually this property is specific also to DSI8x bridge, as you can see from the screenshot below taken from official datasheet: [image: image.png] And it's the sn65dsi8x driver that tells MIPI driver which flags to use during attachment. So, for example, this bridge can work also for

Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled

2024-07-09 Thread Marek Vasut
On 7/9/24 2:45 PM, Stefano Radaelli wrote: Hello everyone, Hi, Thank you a lot for your prompt feedbacks. I'm really sorry for all the mistakes, it is the first time that I try to submit a patch and i thought I followed the guideline but clearly that was not the case. @Marek Vasut About y

Re: [PATCH] drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8

2024-07-09 Thread Tvrtko Ursulin
On 09/07/2024 13:53, Nitin Gote wrote: We're seeing a GPU HANG issue on a CHV platform, which was caused by bac24f59f454 ("drm/i915/execlists: Enable coarse preemption boundaries for gen8"). Gen8 platform has only timeslice and doesn't support a preemption mechanism as engines do not have a p

Re: [PATCH 2/2] drm/amd/display: use drm_crtc_set_vblank_offdelay()

2024-07-09 Thread Hamza Mahfooz
On 7/9/24 06:09, Daniel Vetter wrote: On Tue, Jul 09, 2024 at 11:32:11AM +0200, Daniel Vetter wrote: On Mon, Jul 08, 2024 at 04:29:07PM -0400, Hamza Mahfooz wrote: Hook up drm_crtc_set_vblank_offdelay() in amdgpu_dm, so that we can enable PSR more quickly for displays that support it. Signed-o

Re: [PATCH v6 2/5] drm/panel: boe-th101mb31ig002: switch to devm_gpiod_get_optional() for reset_gpio

2024-07-09 Thread neil . armstrong
On 09/07/2024 15:47, Zhaoxiong Lv wrote: Switch the driver to use devm_gpiod_get_optional() on reset_gpio to avoid driver probe issues when reset line is not specified. Signed-off-by: Zhaoxiong Lv --- Changes between V6 and V5: - 1. No changes. v5: https://lore.kernel.org/all/20240704072958.2

Re: [PATCH v6 1/5] drm/panel: boe-th101mb31ig002 : Make it compatible with other panel.

2024-07-09 Thread neil . armstrong
On 09/07/2024 15:47, Zhaoxiong Lv wrote: This driver currently only applies to one panel. Modify it to be compatible with other panels. Signed-off-by: Zhaoxiong Lv --- Changes between V6 and V5: - 1. Corrected the use of "->init" in struct panel_desc, - 2. Modify indentation in "boe_th101mb31

[syzbot] [dri?] possible deadlock in modeset_lock

2024-07-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:661e504db04c Merge tag 'for-6.10-rc6-tag' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=144e9f9998 kernel config: https://syzkaller.appspot.com/x/.config?x=864caee5f78cab51 das

[PATCH v2 9/9] arm64: dts: renesas: r9a07g043u11-smarc: Enable DU

2024-07-09 Thread Biju Das
Enable DU and link with the HDMI add-on board connected with the parallel connector on RZ/G2UL SMARC EVK. Signed-off-by: Biju Das --- v1->v2: * No change. --- .../boot/dts/renesas/r9a07g043u11-smarc.dts | 111 ++ 1 file changed, 111 insertions(+) diff --git a/arch/arm64/boot/

[PATCH v2 8/9] arm64: dts: renesas: r9a07g043u: Add DU node

2024-07-09 Thread Biju Das
Add DU node to RZ/G2UL SoC DTSI. Signed-off-by: Biju Das --- v1->v2: * No change. --- arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi

[PATCH v2 7/9] arm64: dts: renesas: r9a07g043u: Add fcpvd node

2024-07-09 Thread Biju Das
Add fcpvd node to RZ/G2UL SoC DTSI. Signed-off-by: Biju Das --- v1->v2: * No change. --- arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi index

[PATCH v2 6/9] arm64: dts: renesas: r9a07g043u: Add vspd node

2024-07-09 Thread Biju Das
Add vspd node to RZ/G2UL SoC DTSI. Signed-off-by: Biju Das --- v1->v2: * No change. --- arch/arm64/boot/dts/renesas/r9a07g043u.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi index

[PATCH v2 5/9] drm: renesas: rz-du: Add RZ/G2UL DU Support

2024-07-09 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI interface and supports a maximum resolution of WXGA along with 2 RPFs to support the blending of two picture layers and raster operations (ROPs). The DU module i

[PATCH v2 3/9] dt-bindings: display: renesas, rzg2l-du: Document RZ/G2UL DU bindings

2024-07-09 Thread Biju Das
Document DU found in RZ/G2UL SoC. The DU block is identical to RZ/G2L SoC, but has only DPI interface. While at it, add missing required property port@1 for RZ/G2L and RZ/V2L SoCs. Currently there is no user for the DPI interface and hence there won't be any ABI breakage for adding port@1 as requi

[PATCH v2 0/9] Add support for RZ/G2UL Display Unit

2024-07-09 Thread Biju Das
This patch series aims to add support for RZ/G2UL DU. The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). The output of LCDC is connected display parallel interface (DPI) and supports a maximum resolution of WXGA along with

[PATCH v6 5/5] drm/panel: boe-th101mb31ig002: Support for starry-er88577 MIPI-DSI panel

2024-07-09 Thread Zhaoxiong Lv
The init_code of the starry-er88577 panel is very similar to the panel-boe-th101mb31ig002-28a.c driver, so we make it compatible with the panel-boe-th101mb31ig002-28a.c driver Signed-off-by: Zhaoxiong Lv Reviewed-by: Neil Armstrong --- Changes between V6 and V5: - 1. Add two lines of init_code

[PATCH v6 4/5] dt-bindings: display: panel: Add compatible for starry-er88577

2024-07-09 Thread Zhaoxiong Lv
The starry-er88577 is a 10.1" WXGA TFT-LCD panel, and the init_code of the starry-er88577 panel is very similar to the boe-th101mb31ig002 panel, so We will add a new configuration based on "boe,th101mb31ig002-28a.yaml". Because the panel used reset gpio before but did not add the definition of "re

[PATCH v6 3/5] drm/panel: boe-th101mb31ig002: use wrapped MIPI DCS functions

2024-07-09 Thread Zhaoxiong Lv
Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to simplify driver's init/enable/exit code. Convert the hex in init_code from UPPERCASE to lowercase. Signed-off-by: Zhaoxiong Lv Reviewed-by: Neil Armstrong --- Changes between V6 and V5: - 1. No changes. v5: https://lore.

[PATCH 2/2] drm/msm/dpu: don't play tricks with debug macros

2024-07-09 Thread Dmitry Baryshkov
DPU debugging macros need to be converted to a proper drm_debug_* macros, however this is a going an intrusive patch, not suitable for a fix. Wire DPU_DEBUG and DPU_DEBUG_DRIVER to always use DRM_DEBUG_DRIVER to make sure that DPU debugging messages always end up in the drm debug messages and are c

[PATCH 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-07-09 Thread Dmitry Baryshkov
In order to prevent any errors on connector being disabled, move the state->crtc check upfront. This should fix the issues during suspend when the writeback connector gets forcebly disabled. Fixes: 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c") Cc: sta...@vger.kern

[PATCH 0/2] drm/msm/dpu: two fixes targeting 6.11

2024-07-09 Thread Dmitry Baryshkov
- 2 files changed, 9 insertions(+), 19 deletions(-) --- base-commit: 0b58e108042b0ed28a71cd7edf517555b233 change-id: 20240709-dpu-fix-wb-6cd57e3eb182 Best regards, -- Dmitry Baryshkov

[PATCH v6 2/5] drm/panel: boe-th101mb31ig002: switch to devm_gpiod_get_optional() for reset_gpio

2024-07-09 Thread Zhaoxiong Lv
Switch the driver to use devm_gpiod_get_optional() on reset_gpio to avoid driver probe issues when reset line is not specified. Signed-off-by: Zhaoxiong Lv --- Changes between V6 and V5: - 1. No changes. v5: https://lore.kernel.org/all/20240704072958.27876-3-lvzhaoxi...@huaqin.corp-partner.goog

[PATCH v6 1/5] drm/panel: boe-th101mb31ig002 : Make it compatible with other panel.

2024-07-09 Thread Zhaoxiong Lv
This driver currently only applies to one panel. Modify it to be compatible with other panels. Signed-off-by: Zhaoxiong Lv --- Changes between V6 and V5: - 1. Corrected the use of "->init" in struct panel_desc, - 2. Modify indentation in "boe_th101mb31ig002_of_match[]" v5: https://lore.kernel

[PATCH v6 0/5] Support Starry er88577 MIPI-DSI panel

2024-07-09 Thread Zhaoxiong Lv
The Starry is a 10.1" WXGA TFT LCD panel. Because Starry-er88577 and boe-th101mb31ig002 have very similar inti_code, after discussing with Dmitry Baryshkov, We will modify it based on the panel-boe-th101mb31ig002-28a.c driver instead of using a separate driver. Changes between V6 and V5: - PAT

[PATCH 2/2] drm/panel: add BOE tv101wum-ll2 panel driver

2024-07-09 Thread Neil Armstrong
Add support for the 1200x1920 BOE TV101WUM-LL2 DSI Display Panel found in the Lenovo Smart Tab M10 tablet. The controller is unknown. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/

[PATCH 1/2] dt-bindings: display: panel: document BOE TV101WUM-LL2 DSI Display Panel

2024-07-09 Thread Neil Armstrong
Document the 1200x1920 BOE TV101WUM-LL2 DSI Display Panel found in the Lenovo Smart Tab M10 tablet. The controller is unknown. Signed-off-by: Neil Armstrong --- .../bindings/display/panel/boe,tv101wum-ll2.yaml | 63 ++ 1 file changed, 63 insertions(+) diff --git a/Documen

[PATCH 0/2] drm/panel: add support for the BOE TV101WUM-LL2 DSI Display Panel

2024-07-09 Thread Neil Armstrong
+ 4 files changed, 313 insertions(+) --- base-commit: 97e1ea2dc264da85da53b6ae5726a130bef690a3 change-id: 20240709-topic-sdm450-upstream-tbx605f-panel-f13d55fbd444 Best regards, -- Neil Armstrong

Re: [PATCH v2 0/3] Support for Melfas lmfbx101117480 MIPI-DSI panel

2024-07-09 Thread Neil Armstrong
Hi, On Thu, 04 Jul 2024 12:50:14 +0800, Cong Yang wrote: > This series support for Melfas lmfbx101117480 MIPI-DSI panel with > jadard-jd9365da controller. > Add compatible for melfas lmfbx101117480 in dt-bindings. > Break some CMDS into helper functions. > > Changes in v2: > - PATCH 1/3: No chang

Re: [PATCH v2 0/3] Panel HIMAX support for Microchip's AC40T08A MIPI display

2024-07-09 Thread Neil Armstrong
Hi, On Mon, 01 Jul 2024 14:28:34 +0530, Manikandan Muralidharan wrote: > This patch series adds panel himax display controller support for the > Microchip's AC40T08A MIPI display. > > yaml file is validated using the following commands > > make dt_binding_check DT_SCHEMA_FILES= > make CHECK_DTBS

Re: [PATCH] dt-bindings: display: bridge: ti, sn65dsi83: add burst-mode-disabled

2024-07-09 Thread Stefano Radaelli
Hello everyone, Thank you a lot for your prompt feedbacks. I'm really sorry for all the mistakes, it is the first time that I try to submit a patch and i thought I followed the guideline but clearly that was not the case. @Marek Vasut About your question to why disabling burst-mode: - I agree w

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

2024-07-09 Thread Linux regression tracking (Thorsten Leemhuis)
On 30.06.24 01:18, Mikhail Gavrilov wrote: > On Sat, Jun 29, 2024 at 9:46 PM Rodrigo Siqueira Jordao > wrote: >> >> I'm trying to reproduce this issue, but until now, I've been unable to >> reproduce it. I tried some different scenarios with the following >> components: >> >> 1. Displays: I tried

[PATCH] drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8

2024-07-09 Thread Nitin Gote
We're seeing a GPU HANG issue on a CHV platform, which was caused by bac24f59f454 ("drm/i915/execlists: Enable coarse preemption boundaries for gen8"). Gen8 platform has only timeslice and doesn't support a preemption mechanism as engines do not have a preemption timer and doesn't send an irq if

  1   2   >