Re: [PATCH v5 2/10] HID: hid-appletb-kbd: add driver for the keyboard mode

2024-09-27 Thread Aditya Garg
> On 27 Sep 2024, at 9:09 PM, Benjamin Tissoires wrote: > > On Aug 17 2024, Aditya Garg wrote: >> From: Kerem Karabay >> >> The Touch Bars found on x86 Macs support two USB configurations: one >> where the device presents itself as a HID keyboard and can display >> predefined sets of keys, a

[git pull] drm fixes for 6.12-rc1

2024-09-27 Thread Dave Airlie
Hi Linus, Regular fixes for the week to end the merge window, i915 and xe have a few each, amdgpu makes up most of it with a bunch of SR-IOV related fixes amongst others. Regards, Dave. drm-next-2024-09-28: drm fixes for 6.12-rc1 i915: - Fix BMG support to UHBR13.5 - Two PSR fixes - Fix colorim

[PATCH v8 5/5] drm/amd/display: Fetch the EDID from _DDC if available for eDP

2024-09-27 Thread Mario Limonciello
From: Mario Limonciello Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Attempt to fetch this EDID if it exists and prefer it over the EDID that is provided by the panel. If a user prefers to use the EDID from the panel, offer a DC d

[PATCH v8 4/5] drm/amd/display: remove redundant freesync parser for DP

2024-09-27 Thread Mario Limonciello
From: Melissa Wen When updating connector under drm_edid infrastructure, many calculations and validations are already done and become redundant inside AMD driver. Remove those driver-specific code in favor of the DRM common code. Signed-off-by: Melissa Wen Co-developed-by: Mario Limonciello S

[PATCH v8 3/5] drm/amd/display: always call connector_update when parsing freesync_caps

2024-09-27 Thread Mario Limonciello
From: Melissa Wen Update connector caps with drm_edid data before parsing info for freesync. Signed-off-by: Melissa Wen Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v8 0/5] drm/amd/display: Use drm_edid for more code

2024-09-27 Thread Mario Limonciello
From: Mario Limonciello This is the successor of Melissa's v5 series that was posted [1] as well as my series that was posted [2]. Melissa's patches are mostly unmodified from v5, but the series has been rebase on the new 6.10 based amd-staging-drm-next. As were both touching similar code for f

[PATCH v8 1/5] drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid

2024-09-27 Thread Mario Limonciello
From: Melissa Wen Replace raw edid handling (struct edid) with the opaque EDID type (struct drm_edid) on amdgpu_dm_connector for consistency. It may also prevent mismatch of approaches in different parts of the driver code. Signed-off-by: Melissa Wen Co-developed-by: Mario Limonciello Signed-o

[PATCH v8 2/5] drm/amd/display: switch to setting physical address directly

2024-09-27 Thread Mario Limonciello
From: Melissa Wen Connectors have source physical address available in display info. Use drm_dp_cec_attach() to use it instead of parsing the EDID again. Signed-off-by: Melissa Wen Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++--- 1 file change

[PATCH 5/5] drm: Add client-lib module

2024-09-27 Thread Thomas Zimmermann
Add drm_client_lib.ko to contain most of the client code. Move the existing client for fbdev emulation into the new module. Protect the new module behind CONFIG_DRM_CLIENT. The Kconfig rules separate the DRM drivers from the DRM clients. A driver can opt into the default clients, but the user conf

Re: [PATCH] gpu: drm: i915: display: Avoid null values intel_plane_atomic_check_with_state

2024-09-27 Thread Ville Syrjälä
On Fri, Sep 27, 2024 at 11:20:32AM +0300, Jani Nikula wrote: > On Fri, 27 Sep 2024, Alessandro Zanni wrote: > > This fix solves multiple Smatch errors: > > > > drivers/gpu/drm/i915/display/intel_atomic_plane.c:660 > > intel_plane_atomic_check_with_state() error: > > we previously assumed 'fb' coul

[PATCH 3/5] drm: Move client-device functions in to drm_client_dev.c

2024-09-27 Thread Thomas Zimmermann
A number of DRM-client functions serve as entry points from device operations to client code. Move them info a separate file, so that the other client functions can be moved into a different module. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/drm-client.rst | 3 + drivers/gpu/drm/Ma

[PATCH 4/5] drm: Select fbdev helpers for modules that require them

2024-09-27 Thread Thomas Zimmermann
Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/d

Re: [PATCH v5 7/10] HID: multitouch: allow specifying if a device is direct in a class

2024-09-27 Thread Benjamin Tissoires
On Aug 17 2024, Aditya Garg wrote: > From: Kerem Karabay > > Currently the driver determines the device type based on the > application, but this value is not reliable on Apple Touch Bars, where > the application is HID_DG_TOUCHPAD even though the devices are direct, > so allow setting it in clas

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-27 Thread Armin Wolf
Am 27.09.24 um 23:01 schrieb Pavel Machek: Hi! The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key controllable RGB keyboard backlight. The firmware API for it is implemented via WMI. Ok. To make the backlight userspace configurable this driver emulates a LampArray HI

Re: [PATCH 11/29] accel/ivpu: Remove 1-tile power up Simics workaround

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Previously Simics was not providing workpoint for configurations with 0 tiles enabled, that had to be worked around in the KMD. This got fixed in Simics and workaround is no longer needed. Signed-off-by: Karol Wachowski Revi

[PATCH 1/5] drm/i915: Select DRM_CLIENT_SELECTION

2024-09-27 Thread Thomas Zimmermann
The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from i915. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index db400aad

Re: [PATCH v6 05/11] drm/msm/a6xx: Implement preemption for a7xx targets

2024-09-27 Thread Antonino Maniscalco
On 9/27/24 6:29 PM, Rob Clark wrote: On Thu, Sep 26, 2024 at 2:17 PM Antonino Maniscalco wrote: This patch implements preemption feature for A6xx targets, this allows the GPU to switch to a higher priority ringbuffer if one is ready. A6XX hardware as such supports multiple levels of preemption

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-27 Thread Pavel Machek
Hi! > The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key > controllable RGB keyboard backlight. The firmware API for it is implemented > via WMI. Ok. > To make the backlight userspace configurable this driver emulates a > LampArray HID device and translates the input from

Re: [PATCH 29/29] accel/ivpu: Fix typos in ivpu_pm.c

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: Replace "Filed" with an actual word. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Karol Wachowski Reviewed-by: Jeffrey Hugo

Re: [PATCH v7 00/10] drm/amd/display: Use drm_edid for more code

2024-09-27 Thread Alex Hung
On 9/27/24 14:45, Melissa Wen wrote: Hi Alex, Thanks for the intensive testing. I'll need some time to reproduce and debug these regressions. So, we can divide this series into four steps: 1-2 are the basis for drm_edid migration 3-4 are code cleanups 5-9 are drm_edid_product_id migration 1

Re: [PATCH 27/29] accel/ivpu: Remove HWS_EXTRA_EVENTS from test modes

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: IVPU_TEST_MODE_HWS_EXTRA_EVENTS was never used and can be safely removed Reviewed-by: Karol Wachowski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 26/29] accel/ivpu: Fix ivpu_jsm_dyndbg_control()

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: Use correct channel for dyndbg JSM message. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Karol Wachowski Reviewed-by: Jeffrey Hugo

Re: [PATCH 25/29] accel/ivpu: Increase MS info buffer size

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: Increase MS info BO to 64KB to allow collecting more metrics. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Karol Wachowski Reviewed-by: Jeffrey Hugo

Re: [PATCH 24/29] accel/ivpu: Use whole user and shave ranges for preemption buffers

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Do not restrict range for preemption buffers allocation just to the end of user and shave ranges, use them whole instead to avoid situation where end of range might be already allocated causing preemption buffers allocation to

Re: [PATCH 23/29] accel/ivpu: Do not fail on cmdq if failed to allocate preemption buffers

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Allow to proceed with job command queue creation even if preemption buffers failed to be allocated, print warning that preemption on such command queue will be disabled. Signed-off-by: Karol Wachowski Reviewed-by: Jacek Lawr

Re: [PATCH 22/29] accel/ivpu: Remove invalid warnings

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: Warn in ivpu_file_priv_put() checks a pointer that is previously accessed. Warn in ivpu_ipc_fini() can be triggered even in valid cases where IPC is disabled upon closing the device. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Karol Wachowski

Re: [PATCH 21/29] accel/ivpu: Refactor failure diagnostics during boot

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Move diagnostic functions to common error handling within ivpu_boot() function to ensure diagnostics are gathered even in cases where NPU fails after successful boot (DCT and HWS init failures). Signed-off-by: Karol Wachowski

Re: [PATCH 20/29] accel/ivpu: Prevent recovery invocation during probe and resume

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Refactor IPC send and receive functions to allow correct handling of operations that should not trigger a recovery process. Expose ivpu_send_receive_internal(), which is now utilized by the D0i3 entry, DCT initialization, and

Re: [WHY SUCH DELAY!] Touch Bar support for T2 Macs

2024-09-27 Thread Benjamin Tissoires
On Sep 26 2024, Aditya Garg wrote: > It has been more than a month since I've sent this patch set and I haven't > got a clear yes or not for the same. I understand maintainers are busy > people, but I'd really appreciate if I get some response for this series of > patches from the HID and DRM ma

Re: [PATCH 19/29] accel/ivpu: Fix reset_engine debugfs file logic

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Andrzej Kacprowski The current reset_engine implementation unconditionally resets all engines. Improve implementation to reset only the engine requested by the user space to allow more granular testing. Also use DEFINE_DEBUGFS_ATTRIBUTE() to

Re: [PATCH 18/29] accel/ivpu: Remove skip of clock own resource ack on Simics

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski With recent Simics model update CLOCK_RESOURCE_OWN_ACK signal was implemented as part of VPU STATUS register and workaround is no longer needed. Signed-off-by: Karol Wachowski Reviewed-by: Jacek Lawrynowicz Signed-off-by: J

Re: [PATCH 17/29] accel/ivpu: Add test_mode bit to force turbo

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Andrzej Kacprowski Add new test_mode BIT(9) that forces firmware to enable turbo burst mode. Signed-off-by: Andrzej Kacprowski Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_drv.h | 1 + dri

Re: [PATCH 16/29] accel/ivpu: Make DB_ID and JOB_ID allocations incremental

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Tomasz Rusinowicz Save last used ID and use it to limit the possible values for the ID. This should decrease the rate at which the IDs are reused, which will make debugging easier. Signed-off-by: Tomasz Rusinowicz Reviewed-by: Jacek Lawryno

Re: [PATCH 15/29] accel/ivpu: Print JSM message result in case of error

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Change debug message to error level in case of receiving non-successful result of JSM message. Signed-off-by: Karol Wachowski Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 14/29] accel/ivpu: Add auto selection logic for job scheduler

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: --- a/drivers/accel/ivpu/ivpu_sysfs.c +++ b/drivers/accel/ivpu/ivpu_sysfs.c @@ -6,6 +6,8 @@ #include #include +#include "ivpu_drv.h" +#include "ivpu_fw.h" #include "ivpu_hw.h" #include "ivpu_sysfs.h" @@ -39,8 +41,20 @@ npu_busy_time_

Re: [PATCH 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04

2024-09-27 Thread Pavel Machek
On Fri 2024-09-27 18:08:52, Benjamin Tissoires wrote: > On Sep 26 2024, Werner Sembach wrote: > > Hi, > > took some time but now a first working draft of the suggested new way of > > handling per-key RGB keyboard backlights is finished. See: > > https://lore.kernel.org/all/1fb08a74-62c7-4d0c-ba5d-6

Re: [PATCH 12/29] accel/ivpu: Allow reading dvfs_mode debugfs file

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Andrzej Kacprowski Make the dvfs_mode read-write to allow checking current mode. Simplify the dvfs_mode implementation with the DEFINE_DEBUGFS_ATTRIBUTE. Signed-off-by: Andrzej Kacprowski Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jacek

Re: [PATCH 01/29] accel/ivpu: Update VPU FW API headers

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: @@ -301,7 +308,14 @@ struct vpu_boot_params { u32 temp_sensor_period_ms; /** PLL ratio for efficient clock frequency */ u32 pn_freq_pll_ratio; - /** DVFS Mode: Default: 0, Max Performance: 1, On Demand: 2, Power Save: 3

Re: [PATCH 09/29] accel/ivpu: Add FW version debugfs entry

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Add debugfs that prints current firmware version string on read. Signed-off-by: Karol Wachowski Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_debugfs.c | 12 1

Re: [PATCH 08/29] accel/ivpu: Turn on autosuspend on Simics

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski With recent Simics update DVFS flows using cdyn were fixed and it is possible to enable D0i3/D3 entry flows on autosuspend. Set autosuspend timeout to 100 ms by default on Simics. Signed-off-by: Karol Wachowski Reviewed-by:

Re: [PATCH 04/29] accel/ivpu: Refactor FW log

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: - use read_wrap_count from new FW Boot API - fix logic issues in fw_log_print_buffer What issues? Fixes tag? - remove unused functions/structures - rename some of the functions for better readability Feels like this should be 4 sep

Re: [PATCH 07/29] accel/ivpu: Set 500 ns delay between power island TRICKLE and ENABLE

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: "Wachowski, Karol" Follow HAS recommendation of 500 ns delay when setting "HAS"? AON_PWR_ISLAND_TRICKLE_EN and AON_PWR_ISLAND_EN registers Missing "." ? Also, you currently have a 500 ns delay when setting both. Perhaps the recommen

[PATCH] drm/atomic_helper: Add missing NULL check for drm_plane_helper_funcs.atomic_update

2024-09-27 Thread Lyude Paul
Something I discovered while writing rvkms since some versions of the driver didn't have a filled out atomic_update function - we mention that this callback is "optional", but we don't actually check whether it's NULL or not before calling it. As a result, we'll segfault if it's not filled in. r

Re: [PATCH v7 00/10] drm/amd/display: Use drm_edid for more code

2024-09-27 Thread Melissa Wen
Hi Alex, Thanks for the intensive testing. I'll need some time to reproduce and debug these regressions. So, we can divide this series into four steps: 1-2 are the basis for drm_edid migration 3-4 are code cleanups 5-9 are drm_edid_product_id migration 10 is for ACPI EDID feature. Bearing this

Re: [PATCH 06/29] accel/ivpu: Fix JSM state dump message warnings

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Tomasz Rusinowicz We are disabling IRQs prior to queuing recovery work, so state dump messages always timed out with a warning. Use simple msleep() to prevent IPC warnings. It looks to me like this patch is adding state dump messages, but t

[PATCH] drm/vblank: Require a driver register vblank support for 0 or all CRTCs

2024-09-27 Thread Lyude Paul
Currently, there's nothing actually stopping a driver from only registering vblank support for some of it's CRTCs and not for others. As far as I can tell, this isn't really defined behavior on the C side of things - as the documentation explicitly mentions to not use drm_vblank_init() if you don't

Re: [PATCH 05/29] accel/ivpu: Add coredump support

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: "Wachowski, Karol" Use coredump (if available) to collect FW logs in case of a FW crash. This makes dmesg more readable and allows to collect more log data. Signed-off-by: Wachowski, Karol Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jace

[pull] amdgpu, amdkfd drm-fixes-6.12

2024-09-27 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.12. The following changes since commit 84f76408abe989809de19d02e476b044fd985adc: drm/amdgpu/mes12: reduce timeout (2024-09-18 16:15:13 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.12-2024-09

Re: [PATCH 03/29] accel/ivpu: Reset fw log on cold boot

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: From: Tomasz Rusinowicz Add ivpu_fw_log_reset() that resets the read_index of all FW logs on cold boot so logs are properly read. Signed-off-by: Tomasz Rusinowicz Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jacek Lawrynowicz Reviewed-by: Je

Re: [PATCH 02/29] accel/ivpu: Rename ivpu_log_level to fw_log_level

2024-09-27 Thread Jeffrey Hugo
On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: Rename module param ivpu_log_level to fw_log_level, so it is clear what log level is actually changed. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Maciej Falkowski Reviewed-by: Jeffrey Hugo

Re: [PATCH v5 4/10] HID: multitouch: support getting the contact ID from HID_DG_TRANSDUCER_INDEX fields

2024-09-27 Thread Benjamin Tissoires
On Aug 17 2024, Aditya Garg wrote: > From: Kerem Karabay > > This is needed to support Apple Touch Bars, where the contact ID is > contained in fields with the HID_DG_TRANSDUCER_INDEX usage. > > Signed-off-by: Kerem Karabay > Signed-off-by: Aditya Garg > --- > drivers/hid/hid-multitouch.c | 5

Re: [Linaro-mm-sig] Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-27 Thread Nicolas Dufresne
Le jeudi 26 septembre 2024 à 19:22 +0530, Sumit Garg a écrit : > [Resend in plain text format as my earlier message was rejected by > some mailing lists] > > On Thu, 26 Sept 2024 at 19:17, Sumit Garg wrote: > > > > On 9/25/24 19:31, Christian König wrote: > > > > Am 25.09.24 um 14:51 schrieb Dm

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-09-27 Thread Nicolas Dufresne
Le mercredi 25 septembre 2024 à 22:45 +0200, Marek Vasut a écrit : > On 9/25/24 7:58 PM, Nicolas Dufresne wrote: > > [...] > > > > +static irqreturn_t ipu_mem2mem_vdic_nfb4eof_interrupt(int irq, void > > > *dev_id) > > > +{ > > > + struct ipu_mem2mem_vdic_priv *priv = dev_id; > > > + > > > +

Re: [PATCH 0/5] drm: Introduce DRM client library

2024-09-27 Thread Felix Kuehling
On 2024-09-27 10:37, Thomas Zimmermann wrote: With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko stores most of the common client code. It's designe

[PATCH] drm/radeon/r600_cs: Fix possible int overflow in r600_packet3_check()

2024-09-27 Thread Igor Artemiev
It is possible, although unlikely, that an integer overflow will occur when the result of radeon_get_ib_value() is shifted to the left. Avoid it by casting one of the operands to larger data type (u64). Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Signe

RE: [PATCH 1/2] drm/amd/display: increase max surfaces in line with planes and streams

2024-09-27 Thread Mohamed, Zaeem
[AMD Official Use Only - AMD Internal Distribution Only] Hi Melissa, MAX_SURFACE_NUM and MAX_PLANES both represent the upper bound of planes that are supported by HW. It is best to replace MAX_SURFACE_NUM with MAX_PLANES to remove redundancy. MAX_SURFACES is used to represent the upper bound of

Re: [PATCH v7 00/10] drm/amd/display: Use drm_edid for more code

2024-09-27 Thread Alex Hung
Hi Mario and Melissa, There are three regressions identified during the test, and improvement is required before the patches can be merged. Please see details below. 1. null pointer when hot-plugging a dsc hub (+ three 4k60 monitors). This may point to "drm/amd/display: use drm_edid_product_i

Re: [PATCH v3] drm: Print bad EDID notices less often

2024-09-27 Thread Jani Nikula
On Fri, 27 Sep 2024, Andi Kleen wrote: > On Fri, Sep 27, 2024 at 12:30:04PM +0300, Jani Nikula wrote: >> On Thu, 26 Sep 2024, Andi Kleen wrote: >> > I have an old monitor that reports a zero EDID block, which results in a >> > warning message. This happens on every screen save cycle, and maybe in

Re: [PATCH 1/2] drm/amd/display: increase max surfaces in line with planes and streams

2024-09-27 Thread Melissa Wen
Hi Zaeem, Thanks for explaining their relationship. So IIUC, current DM implementation for dc_surface_updates array is wrong, since it's taking MAX_SURFACES (=3) for allocation but MAX_PLANES (=6) as the upper bound of size of the dc_surface_updates array, as you can see in this allocation an

Re: [PATCH v3] docs/gpu: ci: update flake tests requirements

2024-09-27 Thread Rodrigo Vivi
On Fri, Sep 27, 2024 at 10:54:14AM +0530, Vignesh Raman wrote: > Update the documentation to specify linking to a relevant GitLab > issue or email report for each new flake entry. Added specific > GitLab issue urls for i915, msm and amdgpu driver. > > Acked-by: Abhinav Kumar # msm > Acked-by: Dmi

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-27 Thread Armin Wolf
Am 27.09.24 um 08:59 schrieb Werner Sembach: Hi, Am 26.09.24 um 20:39 schrieb Armin Wolf: Am 26.09.24 um 19:44 schrieb Werner Sembach: The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key controllable RGB keyboard backlight. The firmware API for it is implemented via

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-27 Thread Armin Wolf
Am 27.09.24 um 13:24 schrieb Werner Sembach: Hi, an additional question below Am 27.09.24 um 08:59 schrieb Werner Sembach: Hi, Am 26.09.24 um 20:39 schrieb Armin Wolf: Am 26.09.24 um 19:44 schrieb Werner Sembach: [...] +// We don't know if the WMI API is stable and how unique the GUID is

Re: [PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2024-09-27 Thread Aditya Garg
Hi Thomas Thanks for the review, I’ll soon get to work. > On 27 Sep 2024, at 1:18 PM, Thomas Zimmermann wrote: > > Hi > > Am 17.08.24 um 13:52 schrieb Aditya Garg: >> From: Kerem Karabay >> >> The Touch Bars found on x86 Macs support two USB configurations: one >> where the device presents i

Re: [PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2024-09-27 Thread Aditya Garg
> On 27 Sep 2024, at 1:12 PM, mrip...@kernel.org wrote: > > On Sat, Aug 17, 2024 at 11:52:22AM GMT, Aditya Garg wrote: >> From: Kerem Karabay >> >> The Touch Bars found on x86 Macs support two USB configurations: one >> where the device presents itself as a HID keyboard and can display >> pred

Re: [WHY SUCH DELAY!] Touch Bar support for T2 Macs

2024-09-27 Thread Aditya Garg
Hi Benjamin I’ve noticed the DRM folks also have requested a lot of changes in the drm bit. I really appreciate that finally we got some review on the patches, irrespective of whether it was acceptance/rejection/change. Anyways, since the hid-multitouch changes are needed only for the DRM drive

Re: [PATCH v6 05/11] drm/msm/a6xx: Implement preemption for a7xx targets

2024-09-27 Thread Rob Clark
On Thu, Sep 26, 2024 at 2:17 PM Antonino Maniscalco wrote: > > This patch implements preemption feature for A6xx targets, this allows > the GPU to switch to a higher priority ringbuffer if one is ready. A6XX > hardware as such supports multiple levels of preemption granularities, > ranging from co

[PATCH] drm: panel: jd9365da-h3: fix reset signal polarity

2024-09-27 Thread Hugo Villeneuve
From: Hugo Villeneuve In jadard_prepare() a reset pulse is generated with the following statements (delays ommited for clarity): gpiod_set_value(jadard->reset, 1); --> Deassert reset gpiod_set_value(jadard->reset, 0); --> Assert reset for 10ms gpiod_set_value(jadard->reset, 1); --> D

Re: [PATCH 0/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04

2024-09-27 Thread Benjamin Tissoires
On Sep 26 2024, Werner Sembach wrote: > Hi, > took some time but now a first working draft of the suggested new way of > handling per-key RGB keyboard backlights is finished. See: > https://lore.kernel.org/all/1fb08a74-62c7-4d0c-ba5d-648e23082...@tuxedocomputers.com/ > First time for me sending a w

Re: [PATCH 1/2] drm/msm/dpu: Add MSM8996 support

2024-09-27 Thread Dmitry Baryshkov
On Fri, 27 Sept 2024 at 17:44, wrote: > > On 2024-08-18 09:16, Icenowy Zheng wrote: > > 在 2024-06-28星期五的 16:39 +0200,Barnabás Czémán写道: > >> From: Konrad Dybcio > >> > >> Add support for MSM8996, which - fun fact - was the SoC that this > >> driver > >> (or rather SDE, its downstream origin) was

Re: [PATCH v6 05/11] drm/msm/a6xx: Implement preemption for a7xx targets

2024-09-27 Thread Rob Clark
On Thu, Sep 26, 2024 at 2:17 PM Antonino Maniscalco wrote: > > This patch implements preemption feature for A6xx targets, this allows > the GPU to switch to a higher priority ringbuffer if one is ready. A6XX > hardware as such supports multiple levels of preemption granularities, > ranging from co

Re: [PATCH 0/2] Add MSM8996/MSM8953 dpu catalog

2024-09-27 Thread Dmitry Baryshkov
On Fri, 27 Sept 2024 at 17:39, wrote: > > On 2024-08-01 21:25, Dmitry Baryshkov wrote: > > On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: > >> This patch series add dpu support for MSM8996/MSM8953 devices. > >> > >> Note, by default these platforms are still handled by the MDP5 dri

Re: [PATCH v5 2/10] HID: hid-appletb-kbd: add driver for the keyboard mode

2024-09-27 Thread Benjamin Tissoires
On Aug 17 2024, Aditya Garg wrote: > From: Kerem Karabay > > The Touch Bars found on x86 Macs support two USB configurations: one > where the device presents itself as a HID keyboard and can display > predefined sets of keys, and one where the operating system has full > control over what is disp

Re: [PATCH 1/2] drm/msm/dpu: Add MSM8996 support

2024-09-27 Thread barnabas . czeman
On 2024-08-18 09:16, Icenowy Zheng wrote: 在 2024-06-28星期五的 16:39 +0200,Barnabás Czémán写道: From: Konrad Dybcio Add support for MSM8996, which - fun fact - was the SoC that this driver (or rather SDE, its downstream origin) was meant for and first tested on. It has some hardware that differs fr

Re: [PATCH 0/2] Add MSM8996/MSM8953 dpu catalog

2024-09-27 Thread barnabas . czeman
On 2024-08-01 21:25, Dmitry Baryshkov wrote: On Fri, Jun 28, 2024 at 04:39:38PM GMT, Barnabás Czémán wrote: This patch series add dpu support for MSM8996/MSM8953 devices. Note, by default these platforms are still handled by the MDP5 driver unless the `msm.prefer_mdp5=false' parameter is provid

[PATCH v2 1/1] drm/mediatek: Fix potential KP on 0 bytes nvmem cell read

2024-09-27 Thread Liankun Yang
If the len is 0, kernel crash will occur when performing operations. Add the len check conditions to prevent kernel crash. Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") Signed-off-by: Liankun Yang --- Changes in V2: - Fix the commit title. - Remove blank line betwee

Re: [PATCH v6 04/11] drm/msm: Add CONTEXT_SWITCH_CNTL bitfields

2024-09-27 Thread Antonino Maniscalco
On 9/27/24 1:57 PM, Connor Abbott wrote: In the future, the right thing to do is open a mesa MR with just the register changes and then copy the file from mesa once it's merged, because all of the XML files are supposed to flow from mesa to keep mesa and the kernel in sync. I've opened a mesa MR

[PATCH v3 2/2] drm/panel: boe-th101mb31ig002: Modify Starry panel timing

2024-09-27 Thread Zhaoxiong Lv
In MTK chips, if the DRM runtime resume has not yet completed and the system enters sleep mode at the same time, there is a possibility of a black screen after waking the machine. Reduce the disable delay resolves this issue, The "backlight_off_to_display_off_delay_ms" was added between "backlight

Re: [PATCH v6 1/5] drm/panthor: introduce job cycle and timestamp accounting

2024-09-27 Thread Adrián Larumbe
On 25.09.2024 10:56, Steven Price wrote: >On 23/09/2024 21:43, Adrián Larumbe wrote: >> Hi Steve, >> >> On 23.09.2024 09:55, Steven Price wrote: >>> On 20/09/2024 23:36, Adrián Larumbe wrote: Hi Steve, thanks for the review. >>> >>> Hi Adrián, >>> I've applied all of your suggestions for

Re: [PATCH v5 79/80] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev.

2024-09-27 Thread Thomas Zimmermann
Hi Am 26.09.24 um 15:07 schrieb Tomi Valkeinen: Hi, On 24/09/2024 10:13, Thomas Zimmermann wrote: Store instances of drm_fb_helper and struct omap_fbdev separately. This will allow omapdrm to use the common fbdev client, which allocates its own instance of struct drm_fb_helper. There is at mo

[PATCH 2/5] drm/xe: Select DRM_CLIENT_SELECTION

2024-09-27 Thread Thomas Zimmermann
The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from xe. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/xe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig index ebd0879e04d4..ba

[PATCH 0/5] drm: Introduce DRM client library

2024-09-27 Thread Thomas Zimmermann
With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko stores most of the common client code. It's designed such that drivers can opt into client support, b

Document drm_sched_fini and add some warnings and a BUG_ON()

2024-09-27 Thread Christian König
Sorry for sending incomplete patches earlier today, I've messed up my branch and had to re-create it. Let's try this again, Christian.

[PATCH 2/2] drm/sched: clarify the documentation on drm_sched_entity_error

2024-09-27 Thread Christian König
Sima requested that in a discussion, just copy&paste my explanation from the mail. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_entity.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/driver

[PATCH 1/2] drm/sched: document drm_sched_fini requirements v2

2024-09-27 Thread Christian König
Document the necessary steps which needs to be done before calling drm_sched_fini(). Tearing down the scheduler with jobs still on the pending list can lead to use after free issues. Add a warning if drivers try to destroy a scheduler which still has work pushed to the HW. When there are still en

Re: [PATCH 2/5] drm/mgag200: vga-bmc: Transparently handle BMC

2024-09-27 Thread Thomas Zimmermann
Hi Am 27.09.24 um 16:08 schrieb Jani Nikula: On Mon, 05 Aug 2024, Thomas Zimmermann wrote: The VGA-BMC connector selects the VGA output if a display has been attached to the physical connector. Otherwise it selects the BMC output. In any case, the connector status is set to 'detected', so that

[PATCH v3] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-27 Thread Werner Sembach
The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key controllable RGB keyboard backlight. The firmware API for it is implemented via WMI. To make the backlight userspace configurable this driver emulates a LampArray HID device and translates the input from hidraw to the corre

Re: [PATCH 2/5] drm/mgag200: vga-bmc: Transparently handle BMC

2024-09-27 Thread Jani Nikula
On Mon, 05 Aug 2024, Thomas Zimmermann wrote: > The VGA-BMC connector selects the VGA output if a display has been > attached to the physical connector. Otherwise it selects the BMC > output. In any case, the connector status is set to 'detected', so > that the userspace compositor displays to it.

Re: [PATCH] gpu: drm: i915: display: Avoid null values intel_plane_atomic_check_with_state

2024-09-27 Thread Ville Syrjälä
On Fri, Sep 27, 2024 at 04:45:44PM +0300, Ville Syrjälä wrote: > On Fri, Sep 27, 2024 at 04:14:17PM +0300, Jani Nikula wrote: > > On Fri, 27 Sep 2024, Ville Syrjälä wrote: > > > On Fri, Sep 27, 2024 at 11:20:32AM +0300, Jani Nikula wrote: > > >> On Fri, 27 Sep 2024, Alessandro Zanni > > >> wrote

Re: [PATCH] gpu: drm: i915: display: Avoid null values intel_plane_atomic_check_with_state

2024-09-27 Thread Ville Syrjälä
On Fri, Sep 27, 2024 at 04:14:17PM +0300, Jani Nikula wrote: > On Fri, 27 Sep 2024, Ville Syrjälä wrote: > > On Fri, Sep 27, 2024 at 11:20:32AM +0300, Jani Nikula wrote: > >> On Fri, 27 Sep 2024, Alessandro Zanni wrote: > >> > This fix solves multiple Smatch errors: > >> > > >> > drivers/gpu/drm/

[PATCH v2 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO

2024-09-27 Thread Werner Sembach
The TUXEDO Sirius 16 Gen1 and TUXEDO Sirius 16 Gen2 devices have a per-key controllable RGB keyboard backlight. The firmware API for it is implemented via WMI. To make the backlight userspace configurable this driver emulates a LampArray HID device and translates the input from hidraw to the corre

Re: [PATCH] gpu: drm: i915: display: Avoid null values intel_plane_atomic_check_with_state

2024-09-27 Thread Jani Nikula
On Fri, 27 Sep 2024, Ville Syrjälä wrote: > On Fri, Sep 27, 2024 at 11:20:32AM +0300, Jani Nikula wrote: >> On Fri, 27 Sep 2024, Alessandro Zanni wrote: >> > This fix solves multiple Smatch errors: >> > >> > drivers/gpu/drm/i915/display/intel_atomic_plane.c:660 >> > intel_plane_atomic_check_with_

[PATCH v2 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO

2024-09-27 Thread Werner Sembach
Hi, first revision integrating Armins feedback. Stuff I did not yet change and did not comment on previously: - Still have to ask Christoffer why the mutex is required - Still using acpi_size instad of size_t in the util functions, because the value is put directly into a struct using acpi_size -

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-27 Thread kernel test robot
Hi Werner, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip linus/master v6.11 next-20240927] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v6 04/11] drm/msm: Add CONTEXT_SWITCH_CNTL bitfields

2024-09-27 Thread Connor Abbott
In the future, the right thing to do is open a mesa MR with just the register changes and then copy the file from mesa once it's merged, because all of the XML files are supposed to flow from mesa to keep mesa and the kernel in sync. I've opened a mesa MR [1] based on this that will hopefully get q

Re: [PATCH 5.10] drm/vmwgfx: Remove rcu locks from user resources

2024-09-27 Thread Greg KH
On Sat, Sep 21, 2024 at 02:48:04PM +0800, Huang Xiaojia wrote: > [ Upstream commit a309c7194e8a2f8bd4539b9449917913f6c2cd50 ] We can't take this until you submit backports for newer kernels also. Please send for all affected kernels, thanks. greg k-h

Re: [PATCH v3] drm: Print bad EDID notices less often

2024-09-27 Thread Andi Kleen
On Fri, Sep 27, 2024 at 12:30:04PM +0300, Jani Nikula wrote: > On Thu, 26 Sep 2024, Andi Kleen wrote: > > I have an old monitor that reports a zero EDID block, which results in a > > warning message. This happens on every screen save cycle, and maybe in > > some other situations, and over time the

Re: [PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

2024-09-27 Thread Werner Sembach
Hi, an additional question below Am 27.09.24 um 08:59 schrieb Werner Sembach: Hi, Am 26.09.24 um 20:39 schrieb Armin Wolf: Am 26.09.24 um 19:44 schrieb Werner Sembach: [...] +// We don't know if the WMI API is stable and how unique the GUID is for this ODM. To be on the safe +// side we th

[PATCH v3 1/2] drm/panel: jd9365da: Modify Kingdisplay and Melfas panel timing

2024-09-27 Thread Zhaoxiong Lv
In MTK chips, if the DRM runtime resume has not yet completed and the system enters sleep mode at the same time, there is a possibility of a black screen after waking the machine. Reduce the disable delay resolves this issue, The "backlight_off_to_display_off_delay_ms" was added between "backlight

[PATCH v3 0/2] Modify the timing of three panels

2024-09-27 Thread Zhaoxiong Lv
Modify the power-off sequence of the Kingdisplay/Starry/Melfas panel. Changes between V3 and V2: - PATCH 1/2: Modify the commit message - PATCH 2/2: Modify the commit message. - Link to v2: https://lore.kernel.org/all/20240923134227.11383-1-lvzhaoxi...@huaqin.corp-partner.google.com/ Changes be

Re: [PATCH v2] dt-bindings: display: mediatek: split: add clocks count constraint for MT8195

2024-09-27 Thread Krzysztof Kozlowski
On Fri, Sep 27, 2024 at 01:51:40PM +0800, Moudy Ho wrote: > From: Moudy Ho > > The display node in mt8195.dtsi was triggering a CHECK_DTBS error due > to an excessively long 'clocks' property: > display@14f06000: clocks: [[31, 14], [31, 43], [31, 44]] is too long > > To resolve this issue, app

  1   2   >