Re: [PATCH] driver: gpu: Fix warning directly dereferencing a rcu pointer

2023-12-03 Thread Abhinav Singh
On 11/30/23 05:22, Danilo Krummrich wrote: Hi Abhinav, Thanks for sending this follow-up patch. On 11/26/23 15:57, Abhinav Singh wrote: Fix a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagg

[PATCH] driver: gpu: Fix warning directly dereferencing a rcu pointer

2023-11-26 Thread Abhinav Singh
ockdep enabled. Signed-off-by: Abhinav Singh --- drivers/gpu/drm/nouveau/nv10_fence.c | 2 +- drivers/gpu/drm/nouveau/nv84_fence.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv10_fence.c b/drivers/gpu/drm/nouveau/nv10_fence.c index c6a0db5b9e21..845b64

Re: [PATCH v3] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-21 Thread Abhinav Singh
On 11/21/23 06:50, Danilo Krummrich wrote: On 11/13/23 20:13, Abhinav Singh wrote: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not b

Re: [PATCH v3] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
On 11/14/23 00:43, Abhinav Singh wrote: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be directly dereferencing a rcu pointer. To get a n

[PATCH v3] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
vm.log with lockdep enabled. Signed-off-by: Abhinav Singh --- v1 -> v2 : Replaced the rcu_dereference(...) with unrcu_pointer(...) and also removed the rcu locking and unlocking function call. v2 -> v3 : Changed the description of the patch to match it with the actual implemen

Re: [PATCH v2] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
On 11/14/23 00:19, Danilo Krummrich wrote: Hi, thanks for sending a v2. On 11/13/23 19:42, Abhinav Singh wrote: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointe

[PATCH v2] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
ot; \ -drive file=bullseye.img,format=raw \ -net user,host=10.0.2.10,hostfwd=tcp:127.0.0.1:10021-:22 \ -net nic,model=e1000 \ -enable-kvm \ -nographic \ -pidfile vm.pid \ 2>&1 | tee vm.log with lockdep enabled. Signed-off-by: Abhinav Sin

[PATCH v2] drivers: gpu: Fixing warning directly dereferencing a rcu pointer v2

2023-11-13 Thread Abhinav Singh
ot; \ -drive file=bullseye.img,format=raw \ -net user,host=10.0.2.10,hostfwd=tcp:127.0.0.1:10021-:22 \ -net nic,model=e1000 \ -enable-kvm \ -nographic \ -pidfile vm.pid \ 2>&1 | tee vm.log with lockdep enabled. Signed-off-by: Abhinav Sin

[PATCH] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
ot; \ -drive file=bullseye.img,format=raw \ -net user,host=10.0.2.10,hostfwd=tcp:127.0.0.1:10021-:22 \ -net nic,model=e1000 \ -enable-kvm \ -nographic \ -pidfile vm.pid \ 2>&1 | tee vm.log with lockdep enabled. Signed-off-by: Abhinav

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Abhinav Singh
On 11/7/23 03:07, Alex Deucher wrote: On Mon, Nov 6, 2023 at 4:20 PM Abhinav Singh wrote: On 11/7/23 00:25, Alex Deucher wrote: Applied. This matches what we already do in the other clear state headers. Alex On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh wrote: sparse static analysis

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Abhinav Singh
On 11/7/23 00:25, Alex Deucher wrote: Applied. This matches what we already do in the other clear state headers. Alex On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh wrote: sparse static analysis tools generate a warning with this message "Using plain integer as NULL pointer". In

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Abhinav Singh
On 11/6/23 22:10, Jani Nikula wrote: On Mon, 06 Nov 2023, Abhinav Singh wrote: On 11/6/23 16:53, Jani Nikula wrote: On Fri, 03 Nov 2023, Abhinav Singh wrote: sparse static analysis tools generate a warning with this message "Using plain integer as NULL pointer". In this case th

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Abhinav Singh
On 11/6/23 16:53, Jani Nikula wrote: On Fri, 03 Nov 2023, Abhinav Singh wrote: sparse static analysis tools generate a warning with this message "Using plain integer as NULL pointer". In this case this warning is being shown because we are trying to intialize a pointer to NULL usi

[PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-03 Thread Abhinav Singh
sparse static analysis tools generate a warning with this message "Using plain integer as NULL pointer". In this case this warning is being shown because we are trying to intialize a pointer to NULL using integer value 0. Signed-off-by: Abhinav Singh --- drivers/gpu/