Re: [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver

regress Rockchip with a partial integration, so I'm getting a panel for RK to test to be sure and will re-submit. On 24/08/2020 11:47, Neil Armstrong wrote: Hi, On 15/08/2020 15:05, Ezequiel Garcia wrote: Hi Neil, On Wed, 2020-07-01 at 09:35 +0300, Adrian Ratiu wrote: Hi Neil, On Mo

Re: [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver

Hi Heiko, On Wed, 01 Jul 2020, Heiko Stübner wrote: Hi Adrian, Am Dienstag, 9. Juni 2020, 19:49:48 CEST schrieb Adrian Ratiu: [Re-submitting to cc dri-devel, sorry about the noise] Hello all, v9 cleanly applies on top of latest next-20200609 tree. at least it doesn't apply on t

Re: [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver

Hi Neil, On Mon, 29 Jun 2020, Neil Armstrong wrote: Hi Adrian, On 09/06/2020 19:49, Adrian Ratiu wrote: [Re-submitting to cc dri-devel, sorry about the noise] Hello all, v9 cleanly applies on top of latest next-20200609 tree. v9 does not depend on other patches as the last binding doc

[PATCH v9 10/11] drm: bridge: dw-mipi-dsi: fix bad register field offsets

ed-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 46 +-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-

[PATCH v9 03/11] drm: bridge: dw_mipi_dsi: add dsi v1.01 support

symbolized by new registers so adding support for it is just a matter of defining the new layout and adding a couple of dsi version checks. Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- Changes since v7: - Minor commit msg rewording for consistency Changes

[PATCH v9 02/11] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- Changes since v5: - Fix CONFIG_DEBUG_FS build (Adrian) - Fix DRM_MODE_FLAG_* test negation (Adrian) - Fixed cfg_phy_status range from [0,0] to [0,2] - Replace do {} while(0) with GCC extension ({}) (Andrzej) - Fixed payload no-op wri

[PATCH v9 05/11] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- Changes since v8: - Fixed small compatible string typo caught by checkpatch - Added custom select for 'fsl,imx6-mipi-dsi' (Rob) - Replaced additionalProperties -> unevaluatedProperties (Rob)

[PATCH v9 04/11] drm: bridge: dw_mipi_dsi: remove bind/unbind API

doesn't convert it to a proper bridge daisy-chain with simple encoder and bridge .attach call-backs, that refactoring work should be done separately (and the i.MX6 driver can be used as reference). Suggested-by: Laurent Pinchart Signed-off-by: Adrian Ratiu --- New in v9. --- drivers/gp

[PATCH v9 06/11] ARM: dts: imx6qdl: add missing mipi dsi properties

Now that we have a proper driver for the imx6 mipi dsi host controller we can fill in the missing properties to get it working. Cc: Laurent Pinchart Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Adrian Ratiu --- New in v8. --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1

[PATCH v9 08/11] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check

he version test. Tested on STM32F769 and STM32MP1. Cc: linux-st...@st-md-mailman.stormreply.com Cc: Emil Velikov Reported-by: Adrian Pop Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 16 +++- 1

[PATCH v9 07/11] drm: imx: Add i.MX 6 MIPI DSI host platform driver

Ying Cc: Fabio Estevam Cc: Enric Balletbo i Serra Reviewed-by: Emil Velikov Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- Changes since v8: - Changed Enric's email in the CC tag to his

[PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver

let's add them to the TODO doc. :) I intend to tackle those after this series is merged to avoid two complex inter-dependent simultaneous series. As always more testing is welcome especially on Rockchip and STM SoCs. Big thank you to everyone who has contributed to this up to now, Adrian Ad

[PATCH v9 01/11] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

: Adrian Ratiu --- Changes since v8: - Minor typo fix - Added Reviewed-by Enric tag Changes since v7: - Minor checkpatch line fix Changes since v6: - Select REGMAP_MMIO in Kconfig (Enric) - Drop unnecessary stack variable inits (Enric) - Make bridge error ASAP after a bad revision read

[PATCH v9 11/11] Documentation: gpu: todo: Add dw-mipi-dsi consolidation plan

Cc: Sam Ravnborg Cc: Daniel Vetter Signed-off-by: Adrian Ratiu --- Documentation/gpu/todo.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 658b52f7ffc6c..2b142980a4b16 100644 --- a/Documentation/gpu

[PATCH v9 09/11] drm: bridge: dw-mipi-dsi: split low power cfg register into fields

ugly defines and making field ranges & values written more explicit. Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 105 ++ 1 file changed, 33 insertions(+), 72 deletions(-) diff -

Re: [PATCH v8 04/10] drm: bridge: dw_mipi_dsi: allow bridge daisy chaining

On Wed, 03 Jun 2020, Laurent Pinchart wrote: Hi Adrian, Hi Laurent, Thank you for the patch. On Mon, Apr 27, 2020 at 11:19:46AM +0300, Adrian Ratiu wrote: Up until now the assumption was that the synopsis dsi bridge will directly connect to an encoder provided by the platform driver

Re: [Linux-stm32] [PATCH v8 08/10] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check

On Tue, 02 Jun 2020, Emil Velikov wrote: Hi Adrian, Hi Email, On Mon, 1 Jun 2020 at 10:14, Adrian Ratiu wrote: On Fri, 29 May 2020, Philippe CORNU wrote: > Hi Adrian, and thank you very much for the patchset. Thank > you also for having tested it on STM32F769 and ST

Re: [Linux-stm32] [PATCH v8 08/10] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check

n over a month since I posted v8 and I was just gearing up to address all feedback, rebase & retest to prepare v9 but I'll wait a little longer, no problem, it's no rush. Have an awesome day, Adrian On 4/27/20 10:19 AM, Adrian Ratiu wrote: The stm mipi-dsi platform dri

Re: [PATCH v7 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

Hi Daniel, On Tue, 28 Apr 2020, Daniel Vetter wrote: On Wed, Apr 22, 2020 at 04:07:27AM +0300, Laurent Pinchart wrote: Hi Adrian, On Tue, Apr 21, 2020 at 07:16:06PM +0300, Adrian Ratiu wrote: > This adds support for the Synopsis DesignWare MIPI DSI v1.01 > host controller wh

Re: [PATCH v8 05/10] drm: imx: Add i.MX 6 MIPI DSI host platform driver

Hi Enric, Thank you very much for your review, comments below. I'll leave this a bit more on review before resending with your suggested fixes. On Mon, 27 Apr 2020, Enric Balletbo i Serra wrote: Hi Adrian Thank you for your patch. On 27/4/20 10:19, Adrian Ratiu wrote: This

[PATCH v8 09/10] drm: bridge: dw-mipi-dsi: split low power cfg register into fields

ugly defines and making field ranges & values written more explicit. Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 105 ++ 1 file changed, 33 insertions(+), 72 deletions(-) diff -

[PATCH v8 03/10] drm: bridge: dw_mipi_dsi: add dsi v1.01 support

symbolized by new registers so adding support for it is just a matter of defining the new layout and adding a couple of dsi version checks. Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- Changes since v7: - Minor commit msg rewording for consistency Changes

[PATCH v8 06/10] ARM: dts: imx6qdl: add missing mipi dsi properties

Now that we have a proper driver for the imx6 mipi dsi host controller we can fill in the missing properties to get it working. Cc: Laurent Pinchart Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Adrian Ratiu --- New in v8. --- arch/arm/boot/dts/imx6qdl.dtsi | 8 1

[PATCH v8 05/10] drm: imx: Add i.MX 6 MIPI DSI host platform driver

Ying Cc: Fabio Estevam Cc: Enric Balletbo Serra Reviewed-by: Emil Velikov Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- Changes since v7: - Removed encoder helper ops and added drm_bridge

[PATCH v8 04/10] drm: bridge: dw_mipi_dsi: allow bridge daisy chaining

connect the DSI bridge to another bridge provided by the platform driver, so we extend the dw_mipi_dsi bind() API with a new "previous bridge" arg instead of just hardcoding NULL. Cc: Laurent Pinchart Signed-off-by: Adrian Ratiu --- New in v8. --- drivers/gpu/drm/bridge/synopsys/dw-

[PATCH v8 07/10] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- Changes since v7: - Clarified port@0,1 descriptions, marked them as required and added missing port@0 in example (Laurent) Changes since v6: - Added ref to the newly created snps,dw-mipi-dsi.yaml (Laurent

[PATCH v8 10/10] drm: bridge: dw-mipi-dsi: fix bad register field offsets

ed-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 46 +-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-

[PATCH v8 01/10] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

detected during bridge probe which will be used in future commits to load the relevant register layout which the bridge will use transparently to the platform drivers. Cc: Enric Balletbo Serra Suggested-by: Ezequiel Garcia Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian

[PATCH v8 00/10] Genericize DW MIPI DSI bridge and add i.MX 6 driver

0423100058.1734009-1-adrian.ra...@collabora.com/ Adrian Ratiu (10): drm: bridge: dw_mipi_dsi: add initial regmap infrastructure drm: bridge: dw_mipi_dsi: abstract register access using reg_fields drm: bridge: dw_mipi_dsi: add dsi v1.01 support drm: bridge: dw_mipi_dsi: allow bridge daisy chai

[PATCH v8 08/10] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check

he version test. Tested on STM32F769 and STM32MP1. Cc: linux-st...@st-md-mailman.stormreply.com Reported-by: Adrian Pop Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 12 +++- 1 file changed, 3 i

[PATCH v8 02/10] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- Changes since v5: - Fix CONFIG_DEBUG_FS build (Adrian) - Fix DRM_MODE_FLAG_* test negation (Adrian) - Fixed cfg_phy_status range from [0,0] to [0,2] - Replace do {} while(0) with GCC extension ({}) (Andrzej) - Fixed payload no-op wri

RE: [PATCH v4] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

Hi Angelo, On Thu, 23 Apr 2020, Angelo Ribeiro wrote: Hi Adrian, From: Adrian Ratiu Date: Thu, Apr 23, 2020 at 11:00:58 This converts the Synopsis MIPI DSI binding documentation to yaml and should be quite straightforward. I've added a missing ref clk and also added Philip

[PATCH v4] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

g.org. Cc: Philippe CORNU Cc: devicet...@vger.kernel.org Suggested-by: Laurent Pinchart Reviewed-by: Rob Herring Signed-off-by: Adrian Ratiu --- Changes in v4: - Dropped panel patternProperties (Rob) Changes in v3: - Added ports property and its children which are required (Laurent) - Sorted req

Re: [PATCH v7 5/8] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

On Wed, 22 Apr 2020, Laurent Pinchart wrote: Hi Adrian, Thank you for the patch. On Tue, Apr 21, 2020 at 07:16:07PM +0300, Adrian Ratiu wrote: This provides an example DT binding for the MIPI DSI host controller present on the i.MX6 SoC based on Synopsis DesignWare v1.01 IP. Cc: Rob

[PATCH v3] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

. Cc: Rob Herring Cc: Philippe CORNU Cc: devicet...@vger.kernel.org Suggested-by: Laurent Pinchart Signed-off-by: Adrian Ratiu --- Changes in v3: - Added ports property and its children which are required (Laurent) - Sorted required list alphabetically Changes in v2: - Removed unnecessary de

[PATCH v3] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

. Cc: Rob Herring Cc: Philippe CORNU Cc: devicet...@vger.kernel.org Suggested-by: Laurent Pinchart Signed-off-by: Adrian Ratiu --- Changes in v3: - Added ports property and its children which are required (Laurent) - Sorted required list alphabetically Changes in v2: - Removed unnecessary de

Re: [PATCH v7 5/8] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

On Wed, 22 Apr 2020, Laurent Pinchart wrote: Hi Adrian, On Wed, Apr 22, 2020 at 01:15:41PM +0300, Adrian Ratiu wrote: On Wed, 22 Apr 2020, Laurent Pinchart wrote: > On Wed, Apr 22, 2020 at 03:58:33AM +0300, Laurent Pinchart > wrote: >> On Tue, Apr 21, 2020 at 07:16:07PM +

Re: [PATCH v7 5/8] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

On Wed, 22 Apr 2020, Laurent Pinchart wrote: Hi Adrian, Hi Laurent, On Wed, Apr 22, 2020 at 03:58:33AM +0300, Laurent Pinchart wrote: On Tue, Apr 21, 2020 at 07:16:07PM +0300, Adrian Ratiu wrote: > This provides an example DT binding for the MIPI DSI host > controller present

Re: [PATCH v7 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

On Wed, 22 Apr 2020, Laurent Pinchart wrote: Hi Adrian, Hi Laurent, On Tue, Apr 21, 2020 at 07:16:06PM +0300, Adrian Ratiu wrote: This adds support for the Synopsis DesignWare MIPI DSI v1.01 host controller which is embedded in i.MX 6 SoCs. Based on following patches, but updated

[PATCH v7 8/8] drm: bridge: dw-mipi-dsi: fix bad register field offsets

ed-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 46 +-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-

[PATCH v7 7/8] drm: bridge: dw-mipi-dsi: split low power cfg register into fields

ugly defines and making field ranges & values written more explicit. Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 105 ++ 1 file changed, 33 insertions(+), 72 deletions(-) diff -

[PATCH v7 6/8] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check

he version test. Tested on STM32F769 and STM32MP1. Cc: linux-st...@st-md-mailman.stormreply.com Reported-by: Adrian Pop Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 12 +++- 1 file changed, 3 i

[PATCH v7 3/8] drm: bridge: synopsis: add dsi v1.01 support

symbolized by new registers so adding support for it is just a matter of defining the new layout and adding a couple of dsi version checks. Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- Changes since v5: - Fixed cfg_phy_status range from [0,0] to [0,2] New in

[PATCH v7 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

detected during bridge probe which will be used in future commits to load the relevant register layout which the bridge will use transparently to the platform drivers. Cc: Enric Balletbo Serra Suggested-by: Ezequiel Garcia Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian

[PATCH v7 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

Ying Cc: Fabio Estevam Cc: Enric Balletbo Serra Reviewed-by: Emil Velikov Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- Changes since v6: - Replaced custom noop encoder with the simple drm

[PATCH v7 2/8] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- Changes since v5: - Fix CONFIG_DEBUG_FS build (Adrian) - Fix DRM_MODE_FLAG_* test negation (Adrian) - Fixed cfg_phy_status range from [0,0] to [0,2] - Replace do {} while(0) with GCC extension ({}) (Andrzej) - Fixed payload no-op wri

[PATCH v7 5/8] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- Changes since v6: - Added ref to the newly created snps,dw-mipi-dsi.yaml (Laurent) - Moved *-cells properties outside patternProperties (Laurent) - Removed the panel port documentation (Laurent) - Wrapped

[PATCH v7 0/8] Genericize DW MIPI DSI bridge and add i.MX 6 driver

-next 20200421 with the above two patches applied. Thank you, Adrian Adrian Ratiu (8): drm: bridge: dw_mipi_dsi: add initial regmap infrastructure drm: bridge: dw_mipi_dsi: abstract register access using reg_fields drm: bridge: synopsis: add dsi v1.01 support drm: imx: Add i.MX 6 MIPI DSI

[PATCH v2] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

. Cc: Rob Herring Cc: Philippe CORNU Cc: devicet...@vger.kernel.org Suggested-by: Laurent Pinchart Signed-off-by: Adrian Ratiu --- Changes in v2: - Removed unnecessary descriptions and maxItems (Rob) - Changed maintainers entry / dropped Mark (Rob) - Added dsi-controller.yam

Rule for bridge yaml dt binding maintainers?

Hello, I got confused while doing the txt -> yaml conversion at [1] and it's still not clear to me who should be added in the "maintainers" field. Clearly not the maintainers as returned by get_maintainer.pl. :) Rob mentioned that "owners" should be manintainers but I also have trouble pic

[PATCH] drm: imx: Unify encoder creation

ter the move to imx-drm-core. Suggested-by: Laurent Pinchart Suggested-by: Enric Balletbo Serra Signed-off-by: Adrian Ratiu --- drivers/gpu/drm/imx/dw_hdmi-imx.c | 18 ++ drivers/gpu/drm/imx/imx-drm-core.c | 13 ++--- drivers/gpu/drm/imx/imx-drm.h | 2

Re: [PATCH v6 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

Hi Enric & Laurent, On Wed, 15 Apr 2020, Laurent Pinchart wrote: Hi Enric, On Wed, Apr 15, 2020 at 07:26:02PM +0200, Enric Balletbo Serra wrote: Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: > > This adds support for the Synopsis DesignWare MIPI DSI v1.

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

On Thu, 16 Apr 2020, Enric Balletbo Serra wrote: Hi Adrian, [snip] >> >> +static void dw_mipi_dsi_get_hw_version(struct dw_mipi_dsi >> *dsi) +{ + regmap_read(dsi->regs, DSI_VERSION, >> &dsi->hw_version); + dsi->hw_version &= VERSION; + if >> (!dsi->hw_version) +

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

On Wed, 15 Apr 2020, Enric Balletbo Serra wrote: Hi Adrian, Some few comments/nits below, Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: In order to support multiple versions of the Synopsis MIPI DSI host controller, which have different register layouts but almost

Re: [PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

On Wed, 15 Apr 2020, Enric Balletbo Serra wrote: Hi Adrian, Some few comments/nits below, Hi Enric, Thank you for your review, all your suggested changes will be part of v7. I have only one minor comment below. Missatge de Adrian Ratiu del dia dt., 14 d’abr. 2020 a les 17:19: In

Re: [PATCH] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

Hi Rob, Thank you for the review, I will address all your points in v2, however I have a one neclarity below. On Thu, 16 Apr 2020, Rob Herring wrote: On Thu, Apr 16, 2020 at 7:51 AM Adrian Ratiu wrote: This converts the Synopsis MIPI DSI binding documentation to yaml and should be

[PATCH] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

rg Suggested-by: Laurent Pinchart Signed-off-by: Adrian Ratiu --- .../bindings/display/bridge/dw_mipi_dsi.txt | 32 - .../display/bridge/snps,dw-mipi-dsi.yaml | 66 +++ 2 files changed, 66 insertions(+), 32 deletions(-) delete mode 100644 Documentation/devicetree/b

Re: [PATCH v6 5/8] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

you suggest and send that as a separate patch. Best wishes, Adrian On Tue, Apr 14, 2020 at 06:19:52PM +0300, Adrian Ratiu wrote: This provides an example DT binding for the MIPI DSI host controller present on the i.MX6 SoC based on Synopsis DesignWare v1.01 IP. Cc: Rob Herring Cc: Neil

[PATCH v6 3/8] drm: bridge: synopsis: add dsi v1.01 support

symbolized by new registers so adding support for it is just a matter of defining the new layout and adding a couple of dsi version checks. Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- Changes since v5: - Fixed cfg_phy_status range from [0,0] to [0,2] New in

[PATCH v6 6/8] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check

he version test. Tested on STM32F769 and STM32MP1. Cc: linux-st...@st-md-mailman.stormreply.com Reported-by: Adrian Pop Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 12 +++- 1 file changed, 3 i

[PATCH v6 4/8] drm: imx: Add i.MX 6 MIPI DSI host platform driver

Ying Cc: Fabio Estevam Reviewed-by: Emil Velikov Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- Changes since v5: - Reword to remove unrelated device tree patch mention (Fabio) - Move pllref_clk

[PATCH v6 7/8] drm: bridge: dw-mipi-dsi: split low power cfg register into fields

ugly defines and making field ranges & values written more explicit. Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 105 ++ 1 file changed, 33 insertions(+), 72 deletions(-) diff -

[PATCH v6 0/8] Genericize DW MIPI DSI bridge and add i.MX 6 driver

have been addressed and this series should apply cleanly on latest next-20200414 tree. Tested on imx6dl, stm32mp1 and stm32f7. Best wishes, Adrian Adrian Ratiu (8): drm: bridge: dw_mipi_dsi: add initial regmap infrastructure drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

[PATCH v6 8/8] drm: bridge: dw-mipi-dsi: fix bad register field offsets

ed-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v6. --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 46 +-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-

[PATCH v6 1/8] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

detected during bridge probe which will be used in future commits to load the relevant register layout which the bridge will use transparently to the platform drivers. Suggested-by: Ezequiel Garcia Tested-by: Adrian Pop Tested-by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- New in v5

[PATCH v6 5/8] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- Changes since v5: - Fixed missing reg warning (Fabio) - Updated dt-schema and fixed warnings (Rob) Changes since v4: - Fixed yaml binding to pass `make dt_binding_check dtbs_check` and addressed received binding feedback (Rob

[PATCH v6 2/8] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

by: Arnaud Ferraris Signed-off-by: Adrian Ratiu --- Changes since v5: - Fix CONFIG_DEBUG_FS build (Adrian) - Fix DRM_MODE_FLAG_* test negation (Adrian) - Fixed cfg_phy_status range from [0,0] to [0,2] - Replace do {} while(0) with GCC extension ({}) (Andrzej) - Fixed payload no-op wri

Re: [PATCH v5 2/5] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

Hi Andrzej, Thank you for the feedback, I really appreciate it, replies are below. On Mon, 06 Apr 2020, Andrzej Hajda wrote: W dniu 30.03.2020 o 13:35, Adrian Ratiu pisze: Register existence, address/offsets, field layouts, reserved bits and so on differ between MIPI-DSI versions and

Re: [PATCH v5 4/5] drm: imx: Add i.MX 6 MIPI DSI host platform driver

On Tue, 31 Mar 2020, Ezequiel Garcia wrote: On Tue, 2020-03-31 at 00:31 +0300, Adrian Ratiu wrote: On Mon, 30 Mar 2020, Ezequiel Garcia wrote: > Hello Fabio, Adrian: On Mon, 2020-03-30 at 08:49 -0300, > Fabio Estevam wrote: > > Hi Adrian, On Mon, Mar 30, 2020 at 8:34 AM

Re: [PATCH v5 4/5] drm: imx: Add i.MX 6 MIPI DSI host platform driver

On Mon, 30 Mar 2020, Ezequiel Garcia wrote: Hello Fabio, Adrian: On Mon, 2020-03-30 at 08:49 -0300, Fabio Estevam wrote: Hi Adrian, On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu wrote: > This adds support for the Synopsis DesignWare MIPI DSI v1.01 > host controller which is embed

Re: [PATCH v5 4/5] drm: imx: Add i.MX 6 MIPI DSI host platform driver

On Mon, 30 Mar 2020, Fabio Estevam wrote: Hi Adrian, On Mon, Mar 30, 2020 at 8:34 AM Adrian Ratiu wrote: This adds support for the Synopsis DesignWare MIPI DSI v1.01 host controller which is embedded in i.MX 6 SoCs. Based on following patches, but updated/extended to work with

Re: [PATCH v5 3/5] drm: bridge: synopsis: add dsi v1.01 support

On Mon, 30 Mar 2020, adrian61 wrote: Hello Adrian, Here i get a compile error: I neglected to test with CONFIG_DEBUG_FS, oops! Will fix in v6, thanks! On Mon, Mar 30, 2020 at 2:36 PM Adrian Ratiu wrote: The Synopsis MIPI DSI v1.01 host controller is quite widely used on platforms

Re: [PATCH v5 1/5] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

On Mon, 30 Mar 2020, adrian61 wrote: Hello Adrian, I am testing hese changes on my STM32F769-DISCO and i found that: On Mon, Mar 30, 2020 at 2:35 PM Adrian Ratiu wrote: In order to support multiple versions of the Synopsis MIPI DSI host controller, which have different register

[PATCH v5 5/5] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

This provides an example DT binding for the MIPI DSI host controller present on the i.MX6 SoC based on Synopsis DesignWare v1.01 IP. Cc: Rob Herring Cc: Neil Armstrong Cc: devicet...@vger.kernel.org Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu

[PATCH v5 4/5] drm: imx: Add i.MX 6 MIPI DSI host platform driver

Ying - ARM: dtsi: imx6qdl: Add support for MIPI DSI host controller Signed-off-by: Liu Ying Cc: Fabio Estevam Reviewed-by: Emil Velikov Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- Changes since v4: - Split off driver-specific configuration

[PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver

re of the layout logic, so there's no need to expose the regmap via plat_data anymore. Starting from this version I also opted to add per-patch changelogs. All review comments up to now have been addressed. Tested on IMX6DL. Adrian Ratiu (5): drm: bridge: dw_mipi_dsi: add initial regmap infr

[PATCH v5 2/5] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

ter layout versioning will be handled transparently by the bridge, but if in the future the regmap or layouts needs to be exposed to the drivres, it could easily be done via plat_data or a new API in dw_mipi_dsi.h. Suggested-by: Boris Brezillon Reviewed-by: Emil Velikov Signed-off-by: Adrian Ratiu -

[PATCH v5 1/5] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure

detected during bridge probe which will be used in future commits to load the relevant register layout which the bridge will use transparently to the platform drivers. Signed-off-by: Adrian Ratiu --- New in v5. --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 208 ++ 1 file

[PATCH v5 3/5] drm: bridge: synopsis: add dsi v1.01 support

symbolized by new registers so adding support for it is just a matter of defining the new layout and adding a couple of dsi version checks. Signed-off-by: Adrian Ratiu --- New in v5. --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 125 +- 1 file changed, 119 insertions(+), 6

Re: [Linux-stm32] [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver

. Many thanks, Philippe :-) Hi Philippe, Thank you for taking the time to test this, I really appreciate it. Adrian On 12/2/19 8:33 PM, Adrian Ratiu wrote: Having a generic Synopsis DesignWare MIPI-DSI host controller bridge driver is a very good idea, however the current implementation has har

Re: [Linux-stm32] [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver

On Mon, 02 Dec 2019, Adrian Ratiu wrote: Having a generic Synopsis DesignWare MIPI-DSI host controller bridge driver is a very good idea, however the current implementation has hardcoded quite a lot of the register layouts used by the two supported SoC vendors, STM and Rockchip, which use IP

[PATCH v4 2/4] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

pported by the current vendor platform drivers (rockchip, stm and now imx), more can be added in the future as needed. Suggested-by: Boris Brezillon Reviewed-by: Emil Velikov Signed-off-by: Adrian Ratiu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 504 -- 1 file ch

[PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver

get the regmap via plat_data after calling the bridge probe (Emil). Adrian Ratiu (4): drm: bridge: dw_mipi_dsi: access registers via a regmap drm: bridge: dw_mipi_dsi: abstract register access using reg_fields drm: imx: Add i.MX 6 MIPI DSI host driver dt-bindings: display: add i.MX6

[PATCH v4 4/4] dt-bindings: display: add i.MX6 MIPI DSI host controller doc

This provides an example DT binding for the MIPI DSI host controller present on the i.MX6 SoC based on Synopsis DesignWare v1.01 IP. Cc: Rob Herring Cc: Neil Armstrong Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- .../display/imx/fsl,mipi-dsi-imx6

[PATCH v4 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap

l Velikov Signed-off-by: Adrian Ratiu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 215 ++ .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 17 +- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 34 ++- include/drm/bridge/dw_mipi_dsi.h | 2 +- 4 files cha

[PATCH v4 3/4] drm: imx: Add i.MX 6 MIPI DSI host driver

Ying - ARM: dtsi: imx6qdl: Add support for MIPI DSI host controller Signed-off-by: Liu Ying Cc: Fabio Estevam Reviewed-by: Emil Velikov Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 146

Re: [PATCH v3 4/4] dt-bindings: display: add IMX MIPI DSI host controller doc

On Wed, 20 Nov 2019, Neil Armstrong wrote: Hi, On 18/11/2019 16:25, Adrian Ratiu wrote: A small commit log would be welcome here. Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- .../bindings/display/imx/mipi-dsi.txt | 56

Re: [PATCH v3 3/4] drm: imx: Add i.MX 6 MIPI DSI host driver

On Tue, 19 Nov 2019, Fabio Estevam wrote: Hi Adrian, Hi Fabio, On Mon, Nov 18, 2019 at 12:25 PM Adrian Ratiu wrote: Some nitpicks: + +config DRM_IMX_MIPI_DSI + tristate "Freescale i.MX DRM MIPI DSI" This text seems too generic as there are i.MX SoCs that use diff

[PATCH v3 4/4] dt-bindings: display: add IMX MIPI DSI host controller doc

Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- .../bindings/display/imx/mipi-dsi.txt | 56 +++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx/mipi-dsi.txt diff --git a

[PATCH v3 3/4] drm: imx: Add i.MX 6 MIPI DSI host driver

Ying - ARM: dtsi: imx6qdl: Add support for MIPI DSI host controller Signed-off-by: Liu Ying Reviewed-by: Emil Velikov Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 146 ++- drivers/gpu/drm/imx

[PATCH v3 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap

l Velikov Signed-off-by: Adrian Ratiu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 215 ++ .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 17 +- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 34 ++- include/drm/bridge/dw_mipi_dsi.h | 2 +- 4 files cha

[PATCH v3 2/4] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

pported by the current vendor platform drivers (rockchip, stm and now imx), more can be added in the future as needed. Suggested-by: Boris Brezillon Reviewed-by: Emil Velikov Signed-off-by: Adrian Ratiu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 504 -- 1 file ch

[PATCH v3 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver

regmap via plat_data after calling the bridge probe (Emil). Adrian Ratiu (4): drm: bridge: dw_mipi_dsi: access registers via a regmap drm: bridge: dw_mipi_dsi: abstract register access using reg_fields drm: imx: Add i.MX 6 MIPI DSI host driver dt-bindings: display: add IMX MIPI DSI

Re: [PATCH v2 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap

On Wed, 13 Nov 2019, Emil Velikov wrote: On Wed, 6 Nov 2019 at 16:30, Adrian Ratiu wrote: Convert the common bridge code and the two rockchip & stm drivers which currently use it to the regmap API in anticipation for further changes to make it more generic and add older DSI

[PATCH v2 3/4] drm: imx: Add i.MX 6 MIPI DSI host driver

Ying - ARM: dtsi: imx6qdl: Add support for MIPI DSI host controller Signed-off-by: Liu Ying Reviewed-by: Neil Armstrong Reviewed-by: Emil Velikov Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 146

[PATCH v2 2/4] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields

pported by the current vendor platform drivers (rockchip, stm and now imx), more can be added in the future as needed. Suggested-by: Boris Brezillon Reviewed-by: Neil Armstrong Reviewed-by: Emil Velikov Signed-off-by: Adrian Ratiu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-d

[PATCH v2 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver

& regmap initialization into the bridge module as suggested by Emil. Platform drivers can get the regmap via their plat_data after calling the bridge probe() without worrying at all about layouts, which are handled by the bridge now. Adrian Ratiu (4): drm: bridge: dw_mipi_dsi: access reg

[PATCH v2 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap

l Velikov Signed-off-by: Adrian Ratiu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 215 ++ .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 17 +- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 34 ++- include/drm/bridge/dw_mipi_dsi.h | 2 +- 4 files cha

[PATCH v2 4/4] dt-bindings: display: add IMX MIPI DSI host controller doc

Reviewed-by: Neil Armstrong Reviewed-by: Emil Velikov Signed-off-by: Sjoerd Simons Signed-off-by: Martyn Welch Signed-off-by: Adrian Ratiu --- .../bindings/display/imx/mipi-dsi.txt | 56 +++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap

On Mon, 04 Nov 2019, Neil Armstrong wrote: On 31/10/2019 15:26, Adrian Ratiu wrote: Convert the common bridge code and the two rockchip & stm drivers which currently use it to the regmap API in anticipation for further changes to make it more generic and add older DSI host controller sup

  1   2   >