[PATCH-next v3] drm/amdgpu: Cleanup shift coding style

2024-10-08 Thread Advait Dhamorikar
Improves the coding style by updating bit-shift operations in the amdgpu_jpeg.c driver file. It ensures consistency and avoids potential issues by explicitly using 1U and 1ULL for unsigned and unsigned long long shifts in all relevant instances. Signed-off-by: Advait Dhamorikar --- v1->

Re: [PATCH-next] Fix unintentional integer overflow

2024-10-07 Thread Advait Dhamorikar
nd a v3 with the two changes? Thanks and regards, Advait On Mon, 7 Oct 2024 at 19:26, Christian König wrote: > > Am 05.10.24 um 09:05 schrieb Advait Dhamorikar: > > Hi Sathish, > > > >> Please collate the changes together with Lijo's suggestion as well, > >&g

[PATCH v2] drm/atmel_hlcdc: Fix uninitialized variable

2024-10-07 Thread Advait Dhamorikar
.mzpgi3up-...@intel.com/ Signed-off-by: Advait Dhamorikar --- v1->v2: add reported by and closes labels drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hl

Re: [PATCH-next] Fix unintentional integer overflow

2024-10-05 Thread Advait Dhamorikar
terday. > > I've dropped the patch. Please pick it up once it's fixed up appropriately. > Thanks Alex. > > Hi Advait, > Please collate the changes together with Lijo's suggestion as well, > "1ULL <<" instead of typecast, there are 3 occurrences of the e

[PATCH] drm/atmel_hlcdc: Fix uninitialized variable

2024-10-04 Thread Advait Dhamorikar
atmel_hlcdc_plane_update_buffers: may use an uninitialized sr variable when the if condition remains unsatisfied Signed-off-by: Advait Dhamorikar --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/atmel-hlcdc

[PATCH-next] Fix unintentional integer overflow

2024-10-04 Thread Advait Dhamorikar
Fix shift-count-overflow when creating mask. The expression's value may not be what the programmer intended, because the expression is evaluated using a narrower integer type. Fixes: f0b19b84d391 ("drm/amdgpu: add amdgpu_jpeg_sched_mask debugfs") Signed-off-by: Advait Dhamorikar -

[PATCH-next v2] Fix unintentional integer overflow

2024-10-03 Thread Advait Dhamorikar
Fix shift-count-overflow in JPEG instance multiplication. The expression's value may not be what the programmer intended, because the expression is evaluated using a narrower integer type. Fixes: f0b19b84d391 ("drm/amdgpu: add amdgpu_jpeg_sched_mask debugfs") Signed-off-by: Ad

[PATCH-next] Fix unintentional integer overflow

2024-10-03 Thread Advait Dhamorikar
sk debugfs") Signed-off-by: Advait Dhamorikar --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c index 95e2796919fc..b6f0435f56ba 100644 --- a/driv