Re: [PATCH linux-next] drm/imx: Use device_match_of_node()

2022-11-28 Thread Ahmad Fatoum
Hello, On 17.11.22 08:11, ye.xingc...@zte.com.cn wrote: > From: ye xingchen > > Replace the open-code with device_match_of_node(). device_match_of_node() exists so a pointer to the function can be passed to class/driver_find_device. I see no reason to call it directly. I don't think you should

[PATCH v2] drm: bridge: adv7511: use dev_err_probe in probe function

2022-10-26 Thread Ahmad Fatoum
Signed-off-by: Ahmad Fatoum --- v1 -> v2: - broke overly long lines (Laurent) - Added Laurent's Reviewed-by --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 ++ drivers/gpu/drm/bridge/adv7511/adv7533.c | 20 2 files changed, 10 insertions(+), 16 d

[PATCH] drm: bridge: adv7511: use dev_err_probe in probe function

2022-10-17 Thread Ahmad Fatoum
ridge: adv7533: Create a MIPI DSI device") Signed-off-by: Ahmad Fatoum --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 ++ drivers/gpu/drm/bridge/adv7511/adv7533.c | 18 ++ 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/brid

Re: [PATCH v2 2/2] drm/panel: simple: add LOGIC Technologies LTTD800480070-L6WH-RT

2021-08-05 Thread Ahmad Fatoum
> Signed-off-by: Oleksij Rempel Reviewed-by: Ahmad Fatoum > --- > drivers/gpu/drm/panel/panel-simple.c | 35 > 1 file changed, 35 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > b/drivers/gpu/drm/panel/panel-simple.c >

Re: [PATCH v2 1/2] drm/panel: simple: add Multi-Innotechnology MI1010AIT-1CP1

2021-08-05 Thread Ahmad Fatoum
t; > Co-Developed-by: Sam Ravnborg > Co-Developed-by: Ulrich Ölmann > Signed-off-by: Sam Ravnborg > Signed-off-by: Ulrich Ölmann > Signed-off-by: Oleksij Rempel Reviewed-by: Ahmad Fatoum > --- > drivers/gpu/drm/panel/panel-simple.c | 34 >

Re: [PATCH v1 2/2] drm/panel: simple: add LOGIC Technologies LTTD800480070-L6WH-RT

2021-08-05 Thread Ahmad Fatoum
Hello Oleksi, On 05.08.21 06:37, Oleksij Rempel wrote: > From: Søren Andersen > > Add support for the LOGIC Technologies, Inc LTTD800480070-L6WH-RT > > Co-Developed-by: Søren Andersen > Co-Developed-by: Sam Ravnborg > Signed-off-by: Søren Andersen > Signed-off-by: Sam Ravnborg > Signed-off-

Re: [PATCH v1 1/2] drm/panel: simple: add Multi-Innotechnology MI1010AIT-1CP1

2021-08-05 Thread Ahmad Fatoum
Hello Oleksij, On 05.08.21 06:37, Oleksij Rempel wrote: > From: Sam Ravnborg > > The Multi Innotechnology is a 10.1" 1280x800 panel. > > The datasheet did not specify specific values for sync, back, front porch. > The values are a best guess based on values for similar panels. > > Co-Developed

Re: [PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused

2020-11-08 Thread Ahmad Fatoum
On 11/6/20 8:41 AM, Lee Jones wrote: > On Thu, 05 Nov 2020, Ahmad Fatoum wrote: > >> Hello Lee, >> >> On 11/5/20 3:45 PM, Lee Jones wrote: >>> In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided >>> as a container for state-

Re: [PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused

2020-11-06 Thread Ahmad Fatoum
Hello Lee, On 11/5/20 3:45 PM, Lee Jones wrote: > In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided > as a container for state->crtcs[i].new_state, but is not utilised in > this use-case. We cannot simply delete the variable, so here we tell > the compiler that we're intention

Re: [PATCH 0/3] drm/mxsfb: support swapped RGB lanes

2019-03-27 Thread Ahmad Fatoum
Hello, On 2/1/19 22:05, Stefan Agner wrote: > On 02.01.2019 18:02, Ahmad Fatoum wrote: >> Hello, >> >> I got a board with the RED[0:7]/BLUE[0:7] lanes originating from the >> LCDIF swapped and would like to describe this in the device tree: >> >> This

Re: [PATCH 0/3] drm/mxsfb: support swapped RGB lanes

2019-03-27 Thread Ahmad Fatoum
Hello Sam, On 7/1/19 19:04, Sam Ravnborg wrote: > Hi Ahmad. > >> On 2/1/19 22:37, Sam Ravnborg wrote: >>> The problem with the RED/BLUE lines swapped is something I >>> have encountered while working with DRM support for Atmel at91sam9263 too. >>> >>> The solution selected is to extend the endpoi

[PATCH] drm/panel: simple: innolux, at070tn92: specify correct pixdata edge

2019-01-10 Thread Ahmad Fatoum
en running modetest -s. Signed-off-by: Ahmad Fatoum --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index a04ffb3b2174..021066a231b5 100644 --- a/drivers/gpu/drm/panel/pane

Re: [PATCH 0/3] drm/mxsfb: support swapped RGB lanes

2019-01-08 Thread Ahmad Fatoum
Hello Sam, On 2/1/19 22:37, Sam Ravnborg wrote: > The problem with the RED/BLUE lines swapped is something I > have encountered while working with DRM support for Atmel at91sam9263 too. > > The solution selected is to extend the endpoint with > a new optional property: > > - wiring: Wiring of da

Re: [PATCH 0/3] drm/mxsfb: support swapped RGB lanes

2019-01-04 Thread Ahmad Fatoum
On 1/2/19 10:05 PM, Stefan Agner wrote: > On a quick glance patch 1 looks good. > > However, patch 2/3 are probably unnecessary when using of graph/panel > support. E.g. panel-simple.c supports bus formats. > > Is the display you are using regular RGB and only the board/connectors > happen to sw

[PATCH 2/3] drm/mxsfb: implement interface-pix-fmt of_property to override bus format

2019-01-03 Thread Ahmad Fatoum
This way hardware that has the LCD signal lines swapped can express so in the device tree and existing panel support can be reused unmodified. Signed-off-by: Ahmad Fatoum --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 4 +++- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 13 + drivers/gpu/drm

Re: [PATCH 1/3] drm/mxsfb: use bus_format to determine pixel RGB component order

2019-01-03 Thread Ahmad Fatoum
On 2/1/19 18:02, Ahmad Fatoum wrote: > - reg &= ~CTRL_BUS_WIDTH_MASK; > + ctrl &= ~CTRL_BUS_WIDTH_MASK; > switch (bus_format) { > default: > + pattern = CTRL2_PATTERN_RGB; > dev_err(drm->dev, "Unknown

[PATCH 3/3] dt-bindings: mxsfb: document new interface-pix-fmt property

2019-01-03 Thread Ahmad Fatoum
This newly implemented binding allows expressing swapped signal lanes in the device tree so existing panel support can be reused. Signed-off-by: Ahmad Fatoum --- Documentation/devicetree/bindings/display/mxsfb.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree

[PATCH 0/3] drm/mxsfb: support swapped RGB lanes

2019-01-03 Thread Ahmad Fatoum
MEDIA_BUS_FMT_GBR888_1X24 The latter two patches add a new interface-pix-fmt property (named so because fsl,imx-parallel-display has one), which allows a device tree to override the bus format to account for swapped signal lanes. Thoughts? Cheers Ahmad -- Ahmad Fatoum (3): drm/mxsfb: use

[PATCH 1/3] drm/mxsfb: use bus_format to determine pixel RGB component order

2019-01-03 Thread Ahmad Fatoum
The LCDIF controller v4, like the one included in the i.MX6UL, can be configured to accept other RGB pixel formats. Extend the driver to configure the controller to do so. Signed-off-by: Ahmad Fatoum --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 41 +- drivers/gpu/drm